On Tue, 2 Apr 2024 08:05:41 +0200 Mattias Rönnblom <hof...@lysator.liu.se> wrote:
> On 2024-04-02 02:47, Stephen Hemminger wrote: > > On Mon, 1 Apr 2024 22:28:52 +0000 > > Aditya Ambadipudi <aditya.ambadip...@arm.com> wrote: > > > >> Thanks, Stephen, for the comment. > >> > >> Unfortunately, we don't have the dev setup nor the resources to test out > >> this change using MSVC. > >> > >> Thank you, > >> Aditya Ambadipudi > > > > All it requires is the community version of MSVC which is free. And setting > > up a Windows > > VM with KVM is free and easy. > > > > IMHO all new libraries have to build on all environments, unless they are > > enabling > > platform specific features. > > Requiring all contributors to build and test on what is, in this > context, a pretty obscure platform with a pretty obscure compiler seems > like a bad idea to me. > > It will raise the bar for contributions further. > > In principle I agree though. Your contribution should not only build, > but also run (and be tested) on all platforms. Otherwise, Windows isn't > supported in the upstream, but rather we have a Windows port (which > happens to live in the same source tree). > > I never tested any contribution on a FreeBSD system, but at least those > use the de-facto standard compilers and a standard API (POSIX), so the > likelihood of things actually working is greater (but maybe not great > enough). > > Surely, this is something the tech board must have discussed when it > agreed to supporting Windows *and* MSVC. Many if not most of the > man-hours involved won't be spent by the Windows maintainer, but the > individual future contributors. This what CI systems are for. FreeBSD and Windows are enabled in the build system; just need to make sure all new libraries are enabled. That said, I am all for keeping focus. So open to discussions on dropping lesser platforms or build environments if they interfere.
