On Tue, Apr 02, 2024 at 10:15:50AM -0700, Stephen Hemminger wrote: > On Tue, 2 Apr 2024 09:55:48 -0700 > Tyler Retzlaff <roret...@linux.microsoft.com> wrote: > > > Some libraries that could be built with MSVC were not being built. > > > > Switch from explicit include to exclude of libs to get immediate CI > > coverage of libraries that already work with MSVC Windows builds. > > > > Signed-off-by: Tyler Retzlaff <roret...@linux.microsoft.com> > > For mbuf, since it requires mempool, you might not need to explicitly > exclude it. But the change looks good.
interesting, i wonder if the dependency isn't properly working. the way i chose to exclude libs was to just enable them all and then selectively disable those that were attempted build but failed. mbuf did not complain of missing mempool and there was an attempt to build it. with your changes mempool will build though, just need to wait for it to merge. > Acked-by: Stephen Hemminger <step...@networkplumber.org>
