Re: [PATCH] net/ice: fix tso tunnel setting to not take effect

2023-11-24 Thread David Marchand
On Fri, Nov 24, 2023 at 8:27 AM Kaiwen Deng wrote: > > The Tx offload capabilities of ICE ethdev doesn't include > tso tunnel, which will result in tso tunnel setting to > not take effect. > > This commit will add tso tunnel capabilities in ice_dev_info_get(). > > Fixes: 295968d17407 ("ethdev: add

Re: [PATCH 3/5] doc: fix some ordered lists

2023-11-24 Thread David Marchand
On Thu, Nov 23, 2023 at 6:22 PM Dariusz Sosnowski wrote: > > Hi, > > > diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst index > > 45379960f0..39a8c5d7b4 100644 > > --- a/doc/guides/nics/mlx5.rst > > +++ b/doc/guides/nics/mlx5.rst > > @@ -2326,19 +2326,18 @@ This command performs: >

RE: [PATCH 2/2] app/graph: implement L2FWD usecase

2023-11-24 Thread Sunil Kumar Kori
> -Original Message- > From: Rakesh Kudurumalla > Sent: Thursday, November 23, 2023 11:46 AM > To: Sunil Kumar Kori ; Rakesh Kudurumalla > > Cc: dev@dpdk.org; Jerin Jacob Kollanukkaran ; Nithin > Kumar Dabilpuram > Subject: [PATCH 2/2] app/graph: implement L2FWD usecase > > Added l2fwd

DPDK Release Status Meeting 2023-11-23

2023-11-24 Thread Mcnamara, John
Release status meeting minutes 2023-11-23 = Agenda: * Release Dates * Subtrees * Roadmaps * LTS * Defects * Opens Participants: * AMD * ARM * Debian/Microsoft * Intel * Marvell * Nvidia * Red Hat Release Dates - The following are the current w

net/virtio: duplicated xstats

2023-11-24 Thread Edwin Brossette
Hello, I noticed a small inconsistency in the virtio pmd's xstats. The stat "rx_q0_errors" appears twice. I also think the stats "rx_q0_packets", "rx_q0_bytes", "tx_q0_packets" and "tx_q0_bytes" are duplicates of "rx_q0_good_packets", "rx_q0_good_bytes", "tx_q0_good_packets" and "tx_q0_good_bytes"

Re: net/virtio: duplicated xstats

2023-11-24 Thread Olivier Matz
Fix Maxime's mail. On Fri, Nov 24, 2023 at 10:18:27AM +0100, Edwin Brossette wrote: > Hello, > > I noticed a small inconsistency in the virtio pmd's xstats. > The stat "rx_q0_errors" appears twice. > I also think the stats "rx_q0_packets", "rx_q0_bytes", "tx_q0_packets" and > "tx_q0_bytes" are du

RE: [PATCH] maintainers: add mlx5 driver platform guides

2023-11-24 Thread Dariusz Sosnowski
> As drivers/common/mlx5/ is listed before drivers/net/mlx5/ we should list > doc/guides/platform/mlx5.rst before doc/guides/nics/mlx5.rst Probably that > bluefield.rst should be in the middle between common and NIC docs. I agree, this ordering will be more logical. I'll send v2. Thank you.

[PATCH v2] maintainers: add mlx5 driver platform guides

2023-11-24 Thread Dariusz Sosnowski
Add NVIDIA's platform specific guides to files maintained by networking mlx5 driver maintainers. Signed-off-by: Dariusz Sosnowski --- Changes since v1: - Placed common docs before NIC docs. MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index b07dfbc

Re: [PATCH v2] crypto/ipsec_mb: fix getting process ID per job

2023-11-24 Thread Thomas Monjalon
> > Currently, when using IPsec-mb 1.4+, the process ID is obtained for each > > job in > > a burst with a call to getpid(). > > This system call uses too many CPU cycles, and is unnecessary per job. > > > > Instead, set the process ID value per lcore. > > This is read when processing the burst,

[PATCH v2] eal/linux: force iova-mode va without pa available

2023-11-24 Thread christian . ehrhardt
From: David Wilder When using --no-huge option physical address are not guaranteed to be persistent. This change effectively makes "--no-huge" the same as "--no-huge --iova-mode=va". When --no-huge is used (or any other condition making physical addresses unavailable) setting --iova-mode=pa wil

RE: [PATCH v7] app/test: secondary process passes allow parameters

2023-11-24 Thread Ye, MingjinX
Hi, Thanks for the ack. would like to change the state of the patch, which will be merged into the dpdk. Change: The "--allow" parameter is added when the number of allow is greater than zero. Thanks, Mingjin > -Original Message- > From: Richardson, Bruce > Sent: Friday, November 17

Re: [PATCH v2] eal/linux: force iova-mode va without pa available

2023-11-24 Thread Dmitry Kozlyuk
2023-11-24 11:09 (UTC+0100), christian.ehrha...@canonical.com: [...] > diff --git a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c > index 57da058cec..2f1fce3c54 100644 > --- a/lib/eal/linux/eal.c > +++ b/lib/eal/linux/eal.c > @@ -1067,6 +1067,16 @@ rte_eal_init(int argc, char **argv) > > phys_a

RE: [PATCH v7 0/2] fix legacy device missing region info

2023-11-24 Thread Ye, MingjinX
Hi, can you please take a look at this patch. Thanks, Mingjin > -Original Message- > From: Ye, MingjinX > Sent: Wednesday, November 22, 2023 6:23 PM > To: dev@dpdk.org > Cc: Yang, Qiming ; Ye, MingjinX > > Subject: [PATCH v7 0/2] fix legacy device missing region info > > Fill in missi

Re: net/virtio: duplicated xstats

2023-11-24 Thread Maxime Coquelin
Hi Edwin, Thanks for reporting the issue. On 11/24/23 10:26, Olivier Matz wrote: Fix Maxime's mail. Thanks Olivier. On Fri, Nov 24, 2023 at 10:18:27AM +0100, Edwin Brossette wrote: Hello, I noticed a small inconsistency in the virtio pmd's xstats. The stat "rx_q0_errors" appears twice. I

Re: [PATCH v7 2/2] bus/pci: fix legacy device missing region info

2023-11-24 Thread Gupta, Nipun
On 11/22/2023 3:52 PM, Mingjin Ye wrote: If the legacy device in the primary process does not support mapping the io port bar, the secondary process needs to proactively get the device information and fil the region information. Fixes: 4b741542ecde ("bus/pci: avoid depending on private kernel

[PATCH v1] doc: update release notes for 23.11

2023-11-24 Thread John McNamara
Fix grammar, spelling and formatting of DPDK 23.11 release notes. Signed-off-by: John McNamara --- doc/guides/rel_notes/release_23_11.rst | 30 ++ 1 file changed, 16 insertions(+), 14 deletions(-) diff --git a/doc/guides/rel_notes/release_23_11.rst b/doc/guides/rel_note

RE: [EXT] [PATCH v1] doc: update release notes for 23.11

2023-11-24 Thread Anoob Joseph
Hi John, Please see inline. Thanks, Anoob > -Original Message- > From: John McNamara > Sent: Friday, November 24, 2023 5:35 PM > To: dev@dpdk.org > Cc: tho...@monjalon.net; John McNamara > Subject: [EXT] [PATCH v1] doc: update release notes for 23.11 > > External Email > > --

Re: [PATCH v1] doc: update release notes for 23.11

2023-11-24 Thread David Marchand
Hello John, On Fri, Nov 24, 2023 at 1:05 PM John McNamara wrote: > @@ -92,9 +92,11 @@ New Features > > * **Added support for power intrinsics with AMD processors.** You forgot to remove this line above, before adding the rewording below. > > -* **Added support for allow/block list in vmbus bus

Re: [PATCH 0/5] Some documentation fixes

2023-11-24 Thread David Marchand
On Thu, Nov 23, 2023 at 12:44 PM David Marchand wrote: > > Not urgent for the release (especially the last patch which is scary by > its size) but here are some cleanups in the documentation. > > > -- > David Marchand > > David Marchand (5): > doc: remove restriction on ixgbe vector support >

Re: [PATCH] doc/guides: refer to generic binding devices section

2023-11-24 Thread David Marchand
On Wed, Nov 15, 2023 at 11:10 AM Maxime Coquelin wrote: > On 10/6/23 14:55, David Marchand wrote: > > Rather than copy/paste everywhere how to bind a device and create VF > > devices, refer to the Linux GSG section about it. > > > > Signed-off-by: David Marchand > Reviewed-by: Maxime Coquelin A

Re: net/virtio: duplicated xstats

2023-11-24 Thread Edwin Brossette
Hello again, The flag is already set during the device init, so it should be removed, not added. I can confirm removing it fixed my issue. I will submit a patch for this bug. Regards, Edwin Brossette. On Fri, Nov 24, 2023 at 11:39 AM Maxime Coquelin wrote: > Hi Edwin, > > Thanks for reporting

Re: net/virtio: duplicated xstats

2023-11-24 Thread Maxime Coquelin
On 11/24/23 14:13, Edwin Brossette wrote: Hello again, The flag is already set during the device init, so it should be removed, not added. I can confirm removing it fixed my issue. I will submit a patch for this bug. g Great, thanks Edwin! Don't forget to add the Fixes: tag and cc sta..

Re: [PATCH] lib/ethdev: modified the definition of 'NVGRE_ENCAP'

2023-11-24 Thread David Marchand
On Fri, Nov 24, 2023 at 4:31 AM Sunyang Wu wrote: > > Fix the issue of incorrect definition of 'NVGRE_ENCAP', and > modified the error comments of 'rte_flow_action_nvgre_encap'. > > Fixes: c2beb1d ("ethdev: add missing items/actions to flow object converter") > Fixes: 3850cf0 ("ethdev: add tunnel

Re: [PATCH] doc/rel_notes: add note on libarchive dependencies

2023-11-24 Thread David Marchand
On Thu, Nov 9, 2023 at 11:52 AM Bruce Richardson wrote: > > Since DPDK now registers an explicit dependency on libarchive, rather > than just putting -larchive in link args, we need to add a documentation > note about potential missing dependencies when static linking. > > Signed-off-by: Bruce Ric

Re: [PATCH] doc/contributing: update RST text-wrapping guidelines

2023-11-24 Thread David Marchand
On Fri, Nov 3, 2023 at 2:29 PM Bruce Richardson wrote: > > Update and clarify the guidelines on how to wrap lines in our RST docs. > We no longer limit lines to just 80 characters, and what is more > important that line length is the wrapping of sentences, starting a new > sentence on a new line,

Re: [PATCH] docs: add note about experimental API in LTS

2023-11-24 Thread David Marchand
On Fri, Oct 20, 2023 at 4:19 PM Kevin Traynor wrote: > > The justification and impact for changing experimental API on LTS > branches is different from the main branch. So the policy that is > being used for allowing experimental APIs to change is stricter on > the LTS branches. > > This was not d

[PATCH] net/virtio: fix duplicated rxq xstats

2023-11-24 Thread edwin . brossette
From: Edwin Brossette The flag RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS was temporarily set while moving queue stats from 'struct rte_eth_stats' to the individual pmds, as explained in commit f30e69b41f94 ("ethdev: add device flag to bypass auto-filled queue xstats"). This flag was added so every pmd w

Re: [PATCH] doc: relax requirement on commit messages of security fixes

2023-11-24 Thread David Marchand
On Thu, Mar 10, 2022 at 7:00 PM wrote: > > From: Luca Boccassi > > Allow more flexibility with embargo lifting by not requiring > mentions of CVEs in commit messages if the lift date allows > it. > > Signed-off-by: Luca Boccassi Applied, thanks Luca. -- David Marchand

Re: [PATCH] vfio: add get device info API

2023-11-24 Thread Burakov, Anatoly
On 11/14/2023 11:48 AM, Mingjin Ye wrote: This patch adds an API to support getting device information. The driver can use the "rte_vfio_get_device_info" helper to get device information from EAL. Cc: sta...@dpdk.org Signed-off-by: Mingjin Ye --- lib/eal/include/rte_vfio.h | 26

Re: [PATCH V1] doc: add tested Intel platforms with Intel NICs

2023-11-24 Thread David Marchand
On Thu, Nov 23, 2023 at 7:34 AM Lingli Chen wrote: > > Add tested Intel platforms with Intel NICs to v23.11 release note. > > Signed-off-by: Lingli Chen Applied, thanks. -- David Marchand

Re: [PATCH] doc: add tested platforms with NVIDIA NICs

2023-11-24 Thread David Marchand
On Thu, Nov 23, 2023 at 11:19 AM Raslan Darawsheh wrote: > > Add tested platforms with NVIDIA NICs to the 23.11 release notes. > > Signed-off-by: Raslan Darawsheh Removed spurious : in the middle of the patch. Applied, thanks. -- David Marchand

RE: [PATCH v1] doc: update release notes for 23.11

2023-11-24 Thread Mcnamara, John
> -Original Message- > From: David Marchand > Sent: Friday, November 24, 2023 12:40 PM > To: Mcnamara, John > Cc: dev@dpdk.org; tho...@monjalon.net > Subject: Re: [PATCH v1] doc: update release notes for 23.11 > > Hello John, > > On Fri, Nov 24, 2023 at 1:05 PM John McNamara > wrote:

[PATCH v2] doc: update release notes for 23.11

2023-11-24 Thread John McNamara
Fix grammar, spelling and formatting of DPDK 23.11 release notes. Signed-off-by: John McNamara --- v2: fix accidental deletion and typo doc/guides/rel_notes/release_23_11.rst | 28 ++ 1 file changed, 15 insertions(+), 13 deletions(-) diff --git a/doc/guides/rel_notes/r

Re: [PATCH v2] maintainers: add mlx5 driver platform guides

2023-11-24 Thread Thomas Monjalon
24/11/2023 10:35, Dariusz Sosnowski: > Add NVIDIA's platform specific guides to files maintained by networking > mlx5 driver maintainers. > > Signed-off-by: Dariusz Sosnowski Applied, thanks.

Re: [PATCH v4 10/10] common/dpaxx: remove zero length array

2023-11-24 Thread Stephen Hemminger
This is a better alternative. From 52c805b9526dbef62377276c4499c997fbc96268 Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Thu, 23 Nov 2023 11:12:02 -0800 Subject: [PATCH] common/dpaxx: replace zero length array The zero length ip_header is used as an overlay to the encap IP header. Sinc

RE: [EXT] [PATCH 2/2] devtools: remove ABI exception for crypto asym operations

2023-11-24 Thread Akhil Goyal
> Those API are now stable. > > Fixes: 79a4c2cda131 ("cryptodev: promote some functions as stable") > > Signed-off-by: David Marchand > --- Acked-by: Akhil Goyal

[PATCH v3 0/6] doc/features: fix some features and add new features

2023-11-24 Thread Huisong Li
The support for setting RSS hash algorithm has been introduced to 23.11, but doesn't add feature for it. So this series add this feature and perfect RSS other features by the way. In addition, serval features, like "set link up/down", "TM", "dump device private information" and "loopback mode", ha

[PATCH v3 3/6] doc: add features for link speeds

2023-11-24 Thread Huisong Li
Add features for link speeds. Fixes: 82113036e4e5 ("ethdev: redesign link speed config") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Acked-by: Chengwen Feng --- doc/guides/nics/features.rst | 11 +++ 1 file changed, 11 insertions(+) diff --git a/doc/guides/nics/features.rst b/doc/gu

[PATCH v3 2/6] doc: add link up/down feature

2023-11-24 Thread Huisong Li
Add link up/down feature for features.rst. Fixes: 915e67837586 ("ethdev: API for link up and down") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Acked-by: Chengwen Feng --- doc/guides/nics/features.rst | 4 1 file changed, 4 insertions(+) diff --git a/doc/guides/nics/features.rst b/doc/

[PATCH v3 4/6] doc: add Traffic Manager feature

2023-11-24 Thread Huisong Li
Add Traffic Manager feature. Fixes: 5d109deffa87 ("ethdev: add traffic management API") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Acked-by: Chengwen Feng --- doc/guides/nics/features.rst | 13 + 1 file changed, 13 insertions(+) diff --git a/doc/guides/nics/features.rst b/doc/g

[PATCH v3 1/6] doc: add RSS hash algorithm feature

2023-11-24 Thread Huisong Li
Add hash algorithm feature introduced by 23.11 and fix some RSS features description. Fixes: 34ff088cc241 ("ethdev: set and query RSS hash algorithm") Signed-off-by: Huisong Li Acked-by: Chengwen Feng --- doc/guides/nics/features.rst | 26 ++ 1 file changed, 22 insertio

[PATCH v3 5/6] doc: add dump device private information feature

2023-11-24 Thread Huisong Li
Add dump device private information feature. Fixes: edcf22c6d389 ("ethdev: introduce dump API") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Acked-by: Chengwen Feng --- doc/guides/nics/features.rst | 12 1 file changed, 12 insertions(+) diff --git a/doc/guides/nics/features.rst

[PATCH v3 6/6] doc: add feature for loopback mode

2023-11-24 Thread Huisong Li
Add feature for loopback mode. Fixes: db0359256170 ("ixgbe: add Tx->Rx loopback mode for 82599") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Acked-by: Chengwen Feng --- doc/guides/nics/features.rst | 12 1 file changed, 12 insertions(+) diff --git a/doc/guides/nics/features.rst