RE: [PATCH] doc: update matching list recommendations

2023-11-15 Thread Zhang, Qi Z
> -Original Message- > From: Kevin Traynor > Sent: Friday, November 10, 2023 8:14 PM > To: Zhang, Yuying ; Xing, Beilei > ; Yang, Qiming ; Zhang, Qi Z > > Cc: dev@dpdk.org; Kevin Traynor ; sta...@dpdk.org > Subject: [PATCH] doc: update matching list recommendations > > Update document

RE: [PATCH] net/iavf: fix error devargs parsing

2023-11-15 Thread Zhang, Qi Z
> -Original Message- > From: Mingjin Ye > Sent: Monday, November 13, 2023 6:45 PM > To: dev@dpdk.org > Cc: Yang, Qiming ; Ye, MingjinX > ; sta...@dpdk.org; Wu, Jingjing > ; Xing, Beilei > Subject: [PATCH] net/iavf: fix error devargs parsing > > This patch fixes an unknown parsing resu

RE: [PATCH 15/21] bus/fslmc: replace strtok with strtok_r

2023-11-15 Thread Sachin Saxena
Acked-by: Sachin Saxena > -Original Message- > From: Jie Hai > Sent: 13 November 2023 04:16 PM > To: dev@dpdk.org; Hemant Agrawal ; Sachin > Saxena > Cc: haij...@huawei.com; lihuis...@huawei.com; fengcheng...@huawei.com > Subject: [PATCH 15/21] bus/fslmc: replace strtok with strtok_r >

RE: [PATCH v2 03/16] bus/fslmc: verify strdup return value

2023-11-15 Thread Sachin Saxena
Acked-by: Sachin Saxena > -Original Message- > From: Chengwen Feng > Sent: 10 November 2023 03:31 PM > To: tho...@monjalon.net; ferruh.yi...@amd.com; Hemant Agrawal > ; Sachin Saxena ; > Shreyansh Jain > Cc: dev@dpdk.org > Subject: [PATCH v2 03/16] bus/fslmc: verify strdup return value

RE: [PATCH v2 02/16] bus/dpaa: verify strdup return value

2023-11-15 Thread Sachin Saxena
Acked-by: Sachin Saxena > -Original Message- > From: Chengwen Feng > Sent: 10 November 2023 03:31 PM > To: tho...@monjalon.net; ferruh.yi...@amd.com; Hemant Agrawal > ; Sachin Saxena ; > Shreyansh Jain > Cc: dev@dpdk.org > Subject: [PATCH v2 02/16] bus/dpaa: verify strdup return value >

[Bug 1324] ovokorg

2023-11-15 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1324 Bug ID: 1324 Summary: ovokorg Product: DPDK Version: 22.11 Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: Normal Componen

Re: [PATCH v6 22/23] dts: add doc generation dependencies

2023-11-15 Thread Juraj Linkeš
> I do get some warning while I build the doc: > > $ poetry install --with docs > > [...] > > Installing dependencies from lock file > Warning: poetry.lock is not consistent with pyproject.toml. You may be > getting improper dependencies. Run `poetry lock [--no-update]` to fix it. Looks like my ve

Re: [PATCH v6 05/23] dts: settings docstring update

2023-11-15 Thread Juraj Linkeš
On Wed, Nov 8, 2023 at 5:17 PM Yoan Picchi wrote: > > On 11/8/23 12:53, Juraj Linkeš wrote: > > Format according to the Google format and PEP257, with slight > > deviations. > > > > Signed-off-by: Juraj Linkeš > > --- > > dts/framework/settings.py | 101 +- >

Re: [PATCH] doc/guides: refer to generic binding devices section

2023-11-15 Thread Maxime Coquelin
On 10/6/23 14:55, David Marchand wrote: Rather than copy/paste everywhere how to bind a device and create VF devices, refer to the Linux GSG section about it. Signed-off-by: David Marchand --- doc/guides/bbdevs/acc100.rst| 73 ++--- doc/guides/bbdevs/fpga_5

[Bug 1325] nerdtifix

2023-11-15 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1325 Bug ID: 1325 Summary: nerdtifix Product: DPDK Version: 22.11 Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: Normal Compon

Re: [PATCH v6 06/23] dts: logger and settings docstring update

2023-11-15 Thread Juraj Linkeš
On Wed, Nov 8, 2023 at 6:14 PM Yoan Picchi wrote: > > On 11/8/23 12:53, Juraj Linkeš wrote: > > Format according to the Google format and PEP257, with slight > > deviations. > > > > Signed-off-by: Juraj Linkeš > > --- > > dts/framework/logger.py | 72 +-- > > dts/fr

[PATCH v2] net/iavf: fix error devargs parsing

2023-11-15 Thread Mingjin Ye
This patch fixes unknown parsing results in the absence of devarg "no-poll-on-link-down" and fixes the devarg variable type. Fixes: 5b3124a0a6ef ("net/iavf: support no polling when link down") Fixes: 3e6a5d2d310a ("net/iavf: add devargs to enable VF auto-reset") Cc: sta...@dpdk.org Signed-off-by:

[PATCH] app/testpmd: add the check for port and queue Rx/Tx offload

2023-11-15 Thread Huisong Li
This patch adds the check for port and per queue Rx/Tx offload to avoid the failure of "port start all" when config a offload driver didn't support. Signed-off-by: Huisong Li --- app/test-pmd/cmdline.c | 20 1 file changed, 20 insertions(+) diff --git a/app/test-pmd/cmdline

[PATCH v5 1/2] devtools: add check on symbol maps format

2023-11-15 Thread David Marchand
Add a check on symbol maps format. This will be required by a next commit. Signed-off-by: David Marchand --- Changes since v4: - rebased, - handled next abi version in the check, Changes since v3: - fixed Alpine build (same issue with { in awk expression than commit e1ab26df4862 ("buildtools:

[PATCH v5 2/2] devtools: list symbols by version

2023-11-15 Thread David Marchand
Make it easier to list experimental symbols added in a certain version. Example: $ ./buildtools/map-list-symbol.sh -V 18.11 lib/eal/version.map lib/eal/version.map EXPERIMENTAL rte_dev_event_callback_process lib/eal/version.map EXPERIMENTAL rte_dev_hotplug_handle_disable lib/eal/version.map EXPERI

RE: [PATCH] maintainers: Adding new maintainer to Nvidia mlx5

2023-11-15 Thread Dariusz Sosnowski
Hi, > -Original Message- > From: Matan Azrad > Sent: Tuesday, November 14, 2023 11:56 > To: Suanming Mou ; Slava Ovsiienko > ; Maayan Kashani ; > dev@dpdk.org > Cc: Maayan Kashani ; Raslan Darawsheh > ; NBU-Contact-Thomas Monjalon (EXTERNAL) > > Subject: RE: [PATCH] maintainers: Adding n

[Bug 1324] ovokorg

2023-11-15 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1324 Thomas Monjalon (tho...@monjalon.net) changed: What|Removed |Added Resolution|--- |INVALID C

[Bug 1325] nerdtifix

2023-11-15 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1325 Thomas Monjalon (tho...@monjalon.net) changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resoluti

RE: [PATCH 02/43] eal: use rte strerror

2023-11-15 Thread Morten Brørup
> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Wednesday, 15 November 2023 01.18 > > On Tue, 14 Nov 2023 16:24:58 +0800 > Dengdui Huang wrote: > > > The function strerror() is insecure in a multi-thread environment. > > This patch uses rte_strerror() to replace it. > > > >

Re: Reminder - DPDK Tech Board Meeting Tomorrow - Wed. 11/15/23 - 8am Pacific/10am Central/11am Eastern/1600h UTC

2023-11-15 Thread Bruce Richardson
Techboard meeting will be at 3PM UTC Wednesday 15th. Current agenda items are (time permitting): 1. Any urgent items related to upcoming release. 2. Discussion of policy surrounding experimental APIs and moving them to stable/non-experimental 3. Scheduling of the review of Lab work plan for

RE: [PATCH 02/43] eal: use rte strerror

2023-11-15 Thread Morten Brørup
> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Wednesday, 15 November 2023 01.23 > > On Tue, 14 Nov 2023 16:24:58 +0800 > Dengdui Huang wrote: > > > The function strerror() is insecure in a multi-thread environment. > > This patch uses rte_strerror() to replace it. > > > >

Re: [PATCH v6] bus/pci: fix legacy device IO port map

2023-11-15 Thread Gupta, Nipun
On 11/14/2023 3:54 PM, Mingjin Ye wrote: When doing IO port mapping for legacy device in secondary process, the region information is missing, so, we need to refill it. Fixes: 4b741542ecde ("bus/pci: avoid depending on private kernel value") Cc: sta...@dpdk.org Signed-off-by: Mingjin Ye ---

RE: [PATCH 00/21] replace strtok with strtok_r

2023-11-15 Thread Morten Brørup
> From: fengchengwen [mailto:fengcheng...@huawei.com] > Sent: Wednesday, 15 November 2023 04.03 > > On 2023/11/15 1:49, Tyler Retzlaff wrote: > > On Tue, Nov 14, 2023 at 09:34:33AM -0800, Tyler Retzlaff wrote: > >> On Tue, Nov 14, 2023 at 09:32:48AM -0800, Tyler Retzlaff wrote: > >>> On Tue, Nov 1

Re: Reminder - DPDK Tech Board Meeting Tomorrow - Wed. 11/15/23 - 1500h UTC

2023-11-15 Thread Bruce Richardson
[Re-send with updated time in subject] On Wed, Nov 15, 2023 at 11:22:21AM +, Bruce Richardson wrote: > Techboard meeting will be at 3PM UTC Wednesday 15th. > > Current agenda items are (time permitting): > > 1. Any urgent items related to upcoming release. > > 2. Discussion of policy surrou

Re: [PATCH v3] net/axgbe: invoke correct API when offloads enabled

2023-11-15 Thread Ferruh Yigit
On 11/15/2023 5:56 AM, Jesna K E wrote: > A bug was introduced with the recent fix that when > an offload feature is enabled axgbe_xmit_pkts_vec API is called > rather than axgbe_xmit_pkts API.This patch fixes it. > > Fixes: 9963b5131af8 ("net/axgbe: support multi-process") > > Signed-off-by: Jes

[PATCH] examples/ipsec-secgw: fix partial overflow

2023-11-15 Thread Brian Dooley
Case of partial overflow detected with ASan. Added extra padding to cdev_key structure. This structure is used for the key in hash table. Padding is added to force the struct to use 8 bytes, to ensure memory is notread past this structs boundary (the hash key calculation reads 8 bytes if this stru

Re: [PATCH] app/testpmd: add the check for port and queue Rx/Tx offload

2023-11-15 Thread Ferruh Yigit
On 11/15/2023 10:33 AM, Huisong Li wrote: > This patch adds the check for port and per queue Rx/Tx offload to avoid the > failure of "port start all" when config a offload driver didn't support. > > Signed-off-by: Huisong Li > Reviewed-by: Ferruh Yigit Applied to dpdk-next-net/main, thanks.

RE: [PATCH v3] net/axgbe: invoke correct API when offloads enabled

2023-11-15 Thread Sebastian, Selwin
[Public] Acked-by: Selwin Sebastian -Original Message- From: K.E., Jesna Sent: Wednesday, November 15, 2023 11:26 AM To: dev@dpdk.org Cc: Yigit, Ferruh ; Sebastian, Selwin ; K.E., Jesna Subject: [PATCH v3] net/axgbe: invoke correct API when offloads enabled A bug was introduced with t

Re: [PATCH v3] net/axgbe: invoke correct API when offloads enabled

2023-11-15 Thread Ferruh Yigit
On 11/15/2023 12:54 PM, Sebastian, Selwin wrote: > -Original Message- > From: K.E., Jesna > Sent: Wednesday, November 15, 2023 11:26 AM > To: dev@dpdk.org > Cc: Yigit, Ferruh ; Sebastian, Selwin > ; K.E., Jesna > Subject: [PATCH v3] net/axgbe: invoke correct API when offloads enabled >

[PATCH v7 00/21] dts: docstrings update

2023-11-15 Thread Juraj Linkeš
The first commit makes changes to the code. These code changes mainly change the structure of the code so that the actual API docs generation works. There are also some code changes which get reflected in the documentation, such as making functions/methods/attributes private or public. The rest of

[PATCH v7 01/21] dts: code adjustments for doc generation

2023-11-15 Thread Juraj Linkeš
The standard Python tool for generating API documentation, Sphinx, imports modules one-by-one when generating the documentation. This requires code changes: * properly guarding argument parsing in the if __name__ == '__main__' block, * the logger used by DTS runner underwent the same treatment so

[PATCH v7 02/21] dts: add docstring checker

2023-11-15 Thread Juraj Linkeš
Python docstrings are the in-code way to document the code. The docstring checker of choice is pydocstyle which we're executing from Pylama, but the current latest versions are not complatible due to [0], so pin the pydocstyle version to the latest working version. [0] https://github.com/klen/pyla

[PATCH v7 03/21] dts: add basic developer docs

2023-11-15 Thread Juraj Linkeš
Expand the framework contribution guidelines and add how to document the code with Python docstrings. Signed-off-by: Juraj Linkeš --- doc/guides/tools/dts.rst | 73 1 file changed, 73 insertions(+) diff --git a/doc/guides/tools/dts.rst b/doc/guides/tools

[PATCH v7 04/21] dts: exceptions docstring update

2023-11-15 Thread Juraj Linkeš
Format according to the Google format and PEP257, with slight deviations. Signed-off-by: Juraj Linkeš --- dts/framework/__init__.py | 12 - dts/framework/exception.py | 106 + 2 files changed, 83 insertions(+), 35 deletions(-) diff --git a/dts/framework

[PATCH v7 05/21] dts: settings docstring update

2023-11-15 Thread Juraj Linkeš
Format according to the Google format and PEP257, with slight deviations. Signed-off-by: Juraj Linkeš --- dts/framework/settings.py | 103 +- 1 file changed, 102 insertions(+), 1 deletion(-) diff --git a/dts/framework/settings.py b/dts/framework/settings.py i

[PATCH v7 06/21] dts: logger and utils docstring update

2023-11-15 Thread Juraj Linkeš
Format according to the Google format and PEP257, with slight deviations. Signed-off-by: Juraj Linkeš --- dts/framework/logger.py | 72 ++--- dts/framework/utils.py | 88 + 2 files changed, 113 insertions(+), 47 deletions(-) d

[PATCH v7 07/21] dts: dts runner and main docstring update

2023-11-15 Thread Juraj Linkeš
Format according to the Google format and PEP257, with slight deviations. Signed-off-by: Juraj Linkeš --- dts/framework/dts.py | 128 --- dts/main.py | 8 ++- 2 files changed, 112 insertions(+), 24 deletions(-) diff --git a/dts/framework/dts.py

[PATCH v7 08/21] dts: test suite docstring update

2023-11-15 Thread Juraj Linkeš
Format according to the Google format and PEP257, with slight deviations. Signed-off-by: Juraj Linkeš --- dts/framework/test_suite.py | 223 +++- 1 file changed, 168 insertions(+), 55 deletions(-) diff --git a/dts/framework/test_suite.py b/dts/framework/test_suit

[PATCH v7 09/21] dts: test result docstring update

2023-11-15 Thread Juraj Linkeš
Format according to the Google format and PEP257, with slight deviations. Signed-off-by: Juraj Linkeš --- dts/framework/test_result.py | 292 --- 1 file changed, 234 insertions(+), 58 deletions(-) diff --git a/dts/framework/test_result.py b/dts/framework/test_res

[PATCH v7 10/21] dts: config docstring update

2023-11-15 Thread Juraj Linkeš
Format according to the Google format and PEP257, with slight deviations. Signed-off-by: Juraj Linkeš --- dts/framework/config/__init__.py | 371 ++- dts/framework/config/types.py| 132 +++ 2 files changed, 446 insertions(+), 57 deletions(-) create mode 1

[PATCH v7 11/21] dts: remote session docstring update

2023-11-15 Thread Juraj Linkeš
Format according to the Google format and PEP257, with slight deviations. Signed-off-by: Juraj Linkeš --- dts/framework/remote_session/__init__.py | 39 +- .../remote_session/remote_session.py | 128 +- dts/framework/remote_session/ssh_session.py | 16 +-- 3

[PATCH v7 12/21] dts: interactive remote session docstring update

2023-11-15 Thread Juraj Linkeš
Format according to the Google format and PEP257, with slight deviations. Signed-off-by: Juraj Linkeš --- .../interactive_remote_session.py | 36 +++ .../remote_session/interactive_shell.py | 99 +++ dts/framework/remote_session/python_shell.py | 26 -

[PATCH v7 13/21] dts: port and virtual device docstring update

2023-11-15 Thread Juraj Linkeš
Format according to the Google format and PEP257, with slight deviations. Signed-off-by: Juraj Linkeš --- dts/framework/testbed_model/__init__.py | 16 -- dts/framework/testbed_model/port.py | 53 +++ dts/framework/testbed_model/virtual_device.py | 17 +-

[PATCH v7 14/21] dts: cpu docstring update

2023-11-15 Thread Juraj Linkeš
Format according to the Google format and PEP257, with slight deviations. Signed-off-by: Juraj Linkeš --- dts/framework/testbed_model/cpu.py | 196 + 1 file changed, 144 insertions(+), 52 deletions(-) diff --git a/dts/framework/testbed_model/cpu.py b/dts/framework/t

[PATCH v7 15/21] dts: os session docstring update

2023-11-15 Thread Juraj Linkeš
Format according to the Google format and PEP257, with slight deviations. Signed-off-by: Juraj Linkeš --- dts/framework/testbed_model/os_session.py | 275 -- 1 file changed, 208 insertions(+), 67 deletions(-) diff --git a/dts/framework/testbed_model/os_session.py b/dts/fram

[PATCH v7 16/21] dts: posix and linux sessions docstring update

2023-11-15 Thread Juraj Linkeš
Format according to the Google format and PEP257, with slight deviations. Signed-off-by: Juraj Linkeš --- dts/framework/testbed_model/linux_session.py | 63 ++- dts/framework/testbed_model/posix_session.py | 81 +--- 2 files changed, 113 insertions(+), 31 deletions(-)

[PATCH v7 17/21] dts: node docstring update

2023-11-15 Thread Juraj Linkeš
Format according to the Google format and PEP257, with slight deviations. Signed-off-by: Juraj Linkeš --- dts/framework/testbed_model/node.py | 191 +++- 1 file changed, 131 insertions(+), 60 deletions(-) diff --git a/dts/framework/testbed_model/node.py b/dts/framework/

[PATCH v7 18/21] dts: sut and tg nodes docstring update

2023-11-15 Thread Juraj Linkeš
Format according to the Google format and PEP257, with slight deviations. Signed-off-by: Juraj Linkeš --- dts/framework/testbed_model/sut_node.py | 224 dts/framework/testbed_model/tg_node.py | 42 +++-- 2 files changed, 173 insertions(+), 93 deletions(-) diff --git a

[PATCH v7 19/21] dts: base traffic generators docstring update

2023-11-15 Thread Juraj Linkeš
Format according to the Google format and PEP257, with slight deviations. Signed-off-by: Juraj Linkeš --- .../traffic_generator/__init__.py | 22 - .../capturing_traffic_generator.py| 46 +++ .../traffic_generator/traffic_generator.py| 33 +

[PATCH v7 20/21] dts: scapy tg docstring update

2023-11-15 Thread Juraj Linkeš
Format according to the Google format and PEP257, with slight deviations. Signed-off-by: Juraj Linkeš --- .../testbed_model/traffic_generator/scapy.py | 91 +++ 1 file changed, 54 insertions(+), 37 deletions(-) diff --git a/dts/framework/testbed_model/traffic_generator/scapy.py

[PATCH v7 21/21] dts: test suites docstring update

2023-11-15 Thread Juraj Linkeš
Format according to the Google format and PEP257, with slight deviations. Signed-off-by: Juraj Linkeš --- dts/tests/TestSuite_hello_world.py | 16 + dts/tests/TestSuite_os_udp.py | 19 +++ dts/tests/TestSuite_smoke_tests.py | 53 +++--- 3 files change

[PATCH v1 0/2] dts: api docs generation

2023-11-15 Thread Juraj Linkeš
The generation is done with Sphinx, which DPDK already uses, with slightly modified configuration (the sidebar: unlimited depth and better collapsing - I need comment on this). Dependencies are installed using Poetry from the dts directory: poetry install --with docs After installing, enter the

[PATCH v1 1/2] dts: add doc generation dependencies

2023-11-15 Thread Juraj Linkeš
Sphinx imports every Python module when generating documentation from docstrings, meaning all dts dependencies, including Python version, must be satisfied. By adding Sphinx to dts dependencies we make sure that the proper Python version and dependencies are used when Sphinx is executed. Signed-of

[PATCH v1 2/2] dts: add doc generation

2023-11-15 Thread Juraj Linkeš
The tool used to generate developer docs is Sphinx, which is already used in DPDK. The same configuration is used to preserve style, but it's been augmented with doc-generating configuration and a change to how the sidebar displays the content hierarchy. Sphinx generates the documentation from Pyt

Re: Reminder - DPDK Tech Board Meeting Tomorrow - Wed. 11/15/23 - 8am Pacific/10am Central/11am Eastern/1600h UTC

2023-11-15 Thread Patrick Robb
On Wed, Nov 15, 2023 at 6:22 AM Bruce Richardson wrote: > 3. Scheduling of the review of Lab work plan for 2024. > > I'm glad this is getting scheduled. I have to miss the first 30 minutes, because the DTS group has a call which overlaps, but I'll be there for the second half. I'll have Slack ope

Re: Reminder - DPDK Tech Board Meeting Tomorrow - Wed. 11/15/23 - 8am Pacific/10am Central/11am Eastern/1600h UTC

2023-11-15 Thread Ferruh Yigit
On 11/15/2023 11:22 AM, Bruce Richardson wrote: > Techboard meeting will be at 3PM UTC Wednesday 15th. > > Current agenda items are (time permitting): > > 1. Any urgent items related to upcoming release. > > 2. Discussion of policy surrounding experimental APIs and moving them to >stable/non

Re: [PATCH 02/43] eal: use rte strerror

2023-11-15 Thread Stephen Hemminger
On Wed, 15 Nov 2023 12:23:13 +0100 Morten Brørup wrote: > > From: Stephen Hemminger [mailto:step...@networkplumber.org] > > Sent: Wednesday, 15 November 2023 01.23 > > > > On Tue, 14 Nov 2023 16:24:58 +0800 > > Dengdui Huang wrote: > > > > > The function strerror() is insecure in a multi-thr

Re: [PATCH 00/21] replace strtok with strtok_r

2023-11-15 Thread Stephen Hemminger
On Wed, 15 Nov 2023 12:27:37 +0100 Morten Brørup wrote: > > > just a final follow up, i can see that we already have a rte_strerror > > > here to do the replace with reentrant dance. it is probably good to > > > follow the already established pattern for this and have a > > rte_strtok. > > > >

Re: [PATCH] vfio: add get device info API

2023-11-15 Thread Stephen Hemminger
On Wed, 15 Nov 2023 07:54:20 + "Ye, MingjinX" wrote: > > > +int > > > +rte_vfio_get_device_info(const char *sysfs_base, const char *dev_addr, > > > + int *vfio_dev_fd, struct vfio_device_info > > *device_info); > > > > New api's must be experimental. > > Or is this just int

DTS Working Group Meeting Minutes - November 15, 2023

2023-11-15 Thread Patrick Robb
November 15, 2023 - Attendees * Patrick Robb * Jeremy Spewock * Juraj Linkeš * Paul Szczepanek * Honnappa Nagarahalli * Luca Vizzarro - Agenda * Additions to the agenda * Patch discussions * DTS Developer documentation * 24.03 roadmap -

Re: [PATCH v4 0/6] Enhance the bond framework to support offload

2023-11-15 Thread Ferruh Yigit
On 10/18/2023 8:48 AM, Chaoyong He wrote: > This patch series try to enhance the bond framework to support the > offload feature better: > * Add new API to make the member port can access some information of the > bond port which belongs. > * Add new API to get the result of whether bond port is

[PATCH] crypto/qat: fix gen3 legacy capabilities

2023-11-15 Thread Brian Dooley
From: Ciara Power When the legacy capability flag was enabled for QAT GEN3, in the case of the last legacy capability in the list being SM3 or SM4, when no slice is on the device, the loop continues instead of checking if the end of the legacy capbilities list has been met. To fix this, the chec

[PATCH v2] crypto/qat: fix gen3 legacy capabilities

2023-11-15 Thread Ciara Power
When the legacy capability flag was enabled for QAT GEN3, in the case of the last legacy capability in the list being SM3 or SM4, when no slice is on the device, the loop continues instead of checking if the end of the legacy capbilities list has been met. To fix this, the check for the end of the

RE: [PATCH] examples/ipsec-secgw: fix partial overflow

2023-11-15 Thread Power, Ciara
> -Original Message- > From: Brian Dooley > Sent: Wednesday, November 15, 2023 12:31 PM > To: dev@dpdk.org > Cc: Dooley, Brian ; > sergio.gonzalez.mon...@intel.com; sta...@dpdk.org; Nicolau, Radu > ; Akhil Goyal > Subject: [PATCH] examples/ipsec-secgw: fix partial overflow > > Case of

Re: [PATCH v2] crypto/qat: fix gen3 legacy capabilities

2023-11-15 Thread Ji, Kai
Acked-by: Kai Ji From: Power, Ciara Sent: 15 November 2023 16:14 To: dev@dpdk.org Cc: Kusztal, ArkadiuszX ; Power, Ciara ; sta...@dpdk.org ; Ji, Kai Subject: [PATCH v2] crypto/qat: fix gen3 legacy capabilities When the legacy capability flag was enabled for Q

[PATCH] RFC: use C11 alignas instead of GCC attribute aligned

2023-11-15 Thread Tyler Retzlaff
Now that we require a C11 conformant toolchain we are able to improve portability by further adoption of C11 features. Adapt EAL to use C11 alignas replacing __rte_cache_aligned and __rte_aligned(a) that expand to __attribute__((__aligned__(a))). Note: it appears that use of alignas has exposed a

[PATCH] eal: use C11 alignas instead of GCC attribute aligned

2023-11-15 Thread Tyler Retzlaff
Now that we have enabled C11 replace the use of __rte_cache_aligned and __rte_aligned(n) with alignas(RTE_CACHE_LINE_SIZE) and __rte_aligned(n) respectively. Signed-off-by: Tyler Retzlaff --- lib/eal/arm/include/rte_vect.h | 4 +++- lib/eal/common/malloc_elem.h | 4 +++- lib/eal/co

Re: [PATCH] eal: use C11 alignas instead of GCC attribute aligned

2023-11-15 Thread Bruce Richardson
On Wed, Nov 15, 2023 at 09:39:57AM -0800, Tyler Retzlaff wrote: > Now that we have enabled C11 replace the use of __rte_cache_aligned > and __rte_aligned(n) with alignas(RTE_CACHE_LINE_SIZE) and > __rte_aligned(n) respectively. alignas(n) > > Signed-off-by: Tyler Retzlaff > --- > lib/eal/arm/i

Re: [PATCH] eal: use C11 alignas instead of GCC attribute aligned

2023-11-15 Thread Tyler Retzlaff
On Wed, Nov 15, 2023 at 06:13:55PM +, Bruce Richardson wrote: > On Wed, Nov 15, 2023 at 09:39:57AM -0800, Tyler Retzlaff wrote: > > Now that we have enabled C11 replace the use of __rte_cache_aligned > > and __rte_aligned(n) with alignas(RTE_CACHE_LINE_SIZE) and > > __rte_aligned(n) respectivel

Re: [PATCH v1 3/3] net/axgbe: support TSO Implementation

2023-11-15 Thread Ferruh Yigit
On 11/11/2023 4:00 PM, Jesna K E wrote: > Signed-off-by: Jesna K E > Hi Jesna, There are some reported build errors [1], can you please check them? Also please provide some commit log, event it is brief. [1] https://mails.dpdk.org/archives/test-report/2023-November/508540.html > --- > drive

RE: [PATCH] eal: use C11 alignas instead of GCC attribute aligned

2023-11-15 Thread Morten Brørup
> From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > Sent: Wednesday, 15 November 2023 18.40 > > Now that we have enabled C11 replace the use of __rte_cache_aligned > and __rte_aligned(n) with alignas(RTE_CACHE_LINE_SIZE) and > __rte_aligned(n) respectively. > [...] > typedef union r

Re: [PATCH] eal: use C11 alignas instead of GCC attribute aligned

2023-11-15 Thread Tyler Retzlaff
On Wed, Nov 15, 2023 at 09:08:05PM +0100, Morten Brørup wrote: > > From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > > Sent: Wednesday, 15 November 2023 18.40 > > > > Now that we have enabled C11 replace the use of __rte_cache_aligned > > and __rte_aligned(n) with alignas(RTE_CACHE_LINE

[PATCH] eal: fix alignment of RISCV xmm vector type

2023-11-15 Thread Tyler Retzlaff
Fix the alignment for rte_xmm_t it should be 16 instead of 8 bytes. Fixes: f22e705ebf12 ("eal/riscv: support RISC-V architecture") Cc: m...@semihalf.com Cc: sta...@dpdk.org Signed-off-by: Tyler Retzlaff --- lib/eal/riscv/include/rte_vect.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) d

RE: [PATCH] eal: fix alignment of RISCV xmm vector type

2023-11-15 Thread Morten Brørup
> From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > Sent: Wednesday, 15 November 2023 22.17 > > Fix the alignment for rte_xmm_t it should be 16 instead of 8 bytes. > > Fixes: f22e705ebf12 ("eal/riscv: support RISC-V architecture") > Cc: m...@semihalf.com > Cc: sta...@dpdk.org > Signed-

Re: [PATCH] eal: use C11 alignas instead of GCC attribute aligned

2023-11-15 Thread Stanisław Kardach
On Wed, Nov 15, 2023 at 10:03 PM Tyler Retzlaff wrote: > > On Wed, Nov 15, 2023 at 09:08:05PM +0100, Morten Brørup wrote: > > > From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > > > Sent: Wednesday, 15 November 2023 18.40 > > > > > > Now that we have enabled C11 replace the use of __rte

[PATCH 0/4] add __extension__ keyword to statement expressions

2023-11-15 Thread Tyler Retzlaff
As requested from previous rejected series this series applies the __extension__ keyword to all statement expressionsin DPDK. Tyler Retzlaff (4): lib: add extension keyword to statement expressions app: add extension keyword to statement expressions drivers: add extension keyword to statemen

[PATCH 1/4] lib: add extension keyword to statement expressions

2023-11-15 Thread Tyler Retzlaff
Add __extension__ keyword to gcc statement expression extensions. Signed-off-by: Tyler Retzlaff --- lib/ethdev/rte_mtr.c | 10 +- lib/ethdev/rte_tm.c | 6 +++--- lib/pipeline/rte_pipeline.c | 8 lib/pipeline/rte_swx_pipelin

[PATCH 2/4] app: add extension keyword to statement expressions

2023-11-15 Thread Tyler Retzlaff
Add __extension__ keyword to gcc statement expression extensions. Signed-off-by: Tyler Retzlaff --- app/graph/utils.c | 2 +- app/test-eventdev/parser.h | 2 +- app/test-mldev/parser.h| 2 +- app/test-pmd/cmdline_tm.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff -

[PATCH 3/4] drivers: add extension keyword to statement expressions

2023-11-15 Thread Tyler Retzlaff
Add __extension__ keyword to gcc statement expression extensions. Signed-off-by: Tyler Retzlaff --- drivers/bus/fslmc/mc/fsl_mc_sys.h| 6 ++--- drivers/common/cnxk/roc_io.h | 6 ++--- drivers/common/cnxk/roc_platform.h | 2 +- drivers/common/d

[PATCH 4/4] examples: add extension keyword to statement expressions

2023-11-15 Thread Tyler Retzlaff
Add __extension__ keyword to gcc statement expression extensions. Signed-off-by: Tyler Retzlaff --- examples/fips_validation/fips_validation.c | 2 +- examples/ip_pipeline/parser.h | 2 +- examples/pipeline/cli.c| 2 +- examples/qos_meter/main.h

Re: [PATCH] eal: fix alignment of RISCV xmm vector type

2023-11-15 Thread Stanisław Kardach
On Wed, Nov 15, 2023 at 10:31 PM Morten Brørup wrote: > > > From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > > Sent: Wednesday, 15 November 2023 22.17 > > > > Fix the alignment for rte_xmm_t it should be 16 instead of 8 bytes. > > > > Fixes: f22e705ebf12 ("eal/riscv: support RISC-V ar

Re: [PATCH v3 5/7] Section 5: Appendix

2023-11-15 Thread Dave Young
Bruce, Is the following Linux update correct per your feedback? Linux - To run DPDK applications without root privileges on Linux, perform the following steps: 1. **Create a DPDK User Group**: Create a new user group for DPDK and add the desired user to this group. 2. **Set Up Hugepages**:

RE: [PATCH v4 0/6] Enhance the bond framework to support offload

2023-11-15 Thread Chaoyong He
> On 10/18/2023 8:48 AM, Chaoyong He wrote: > > This patch series try to enhance the bond framework to support the > > offload feature better: > > * Add new API to make the member port can access some information of the > > bond port which belongs. > > * Add new API to get the result of whether b

RE: [PATCH v2] net/iavf: fix error devargs parsing

2023-11-15 Thread Zhang, Qi Z
> -Original Message- > From: Mingjin Ye > Sent: Wednesday, November 15, 2023 6:13 PM > To: dev@dpdk.org > Cc: Yang, Qiming ; Ye, MingjinX > ; sta...@dpdk.org; Wu, Jingjing > ; Xing, Beilei > Subject: [PATCH v2] net/iavf: fix error devargs parsing > > This patch fixes unknown parsing r

RE: [PATCH] app/test-pmd: fix L4 checksum with padding data

2023-11-15 Thread Deng, KaiwenX
> -Original Message- > From: Ferruh Yigit > Sent: Wednesday, November 15, 2023 3:10 AM > To: Deng, KaiwenX ; dev@dpdk.org > Cc: sta...@dpdk.org; Yang, Qiming ; Zhou, YidingX > ; Singh, Aman Deep ; > Zhang, Yuying ; Matz, Olivier > ; De Lara Guarch, Pablo > > Subject: Re: [PATCH] app/tes

Re: [PATCH v4 0/3] test/dma: add vchan reconfig and SG tests

2023-11-15 Thread fengchengwen
LGTM Series-acked-by: Chengwen Feng PS: since 'test/dma: fix for buffer auto free' already merged, I think you should resend v5 to fix the apply error. On 2023/11/13 20:53, Gowrishankar Muthukrishnan wrote: > This patch series reworks DMA tests to follow unit test framework > followed by new vc

RE: [PATCH] eal: fix alignment of RISCV xmm vector type

2023-11-15 Thread Morten Brørup
> From: Stanisław Kardach [mailto:k...@semihalf.com] > Sent: Thursday, 16 November 2023 00.21 > > On Wed, Nov 15, 2023 at 10:31 PM Morten Brørup > wrote: > > > > > From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > > > Sent: Wednesday, 15 November 2023 22.17 > > > > > > Fix the alignmen