> -----Original Message-----
> From: Mingjin Ye <mingjinx...@intel.com>
> Sent: Monday, November 13, 2023 6:45 PM
> To: dev@dpdk.org
> Cc: Yang, Qiming <qiming.y...@intel.com>; Ye, MingjinX
> <mingjinx...@intel.com>; sta...@dpdk.org; Wu, Jingjing
> <jingjing...@intel.com>; Xing, Beilei <beilei.x...@intel.com>
> Subject: [PATCH] net/iavf: fix error devargs parsing
>
> This patch fixes an unknown parsing result without devarg "no-poll-on-link-
> down".
>
> Fixes: 5b3124a0a6ef ("net/iavf: support no polling when link down")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Mingjin Ye <mingjinx...@intel.com>
> ---
> drivers/net/iavf/iavf_ethdev.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c
> index 0c6ab4ac5a..d1edb0dd5c 100644
> --- a/drivers/net/iavf/iavf_ethdev.c
> +++ b/drivers/net/iavf/iavf_ethdev.c
> @@ -2294,7 +2294,6 @@ static int iavf_parse_devargs(struct rte_eth_dev
> *dev)
> struct rte_kvargs *kvlist;
> int ret;
> int watchdog_period = -1;
> - uint16_t no_poll_on_link_down;
>
> if (!devargs)
> return 0;
> @@ -2329,13 +2328,9 @@ static int iavf_parse_devargs(struct rte_eth_dev
> *dev)
> ad->devargs.watchdog_period = watchdog_period;
>
> ret = rte_kvargs_process(kvlist,
> IAVF_NO_POLL_ON_LINK_DOWN_ARG,
> - &parse_u16, &no_poll_on_link_down);
> + &parse_bool, &ad-
> >devargs.no_poll_on_link_down);
This will be a problem, the parse_bool accept an argument as size of int , but
no_poll_on_link_down is a uint16_t
Please also fix the issue for auto_reset ....
