On 11/11/2023 4:00 PM, Jesna K E wrote: > Signed-off-by: Jesna K E <jesna....@amd.com> >
Hi Jesna, There are some reported build errors [1], can you please check them? Also please provide some commit log, event it is brief. [1] https://mails.dpdk.org/archives/test-report/2023-November/508540.html > --- > drivers/net/axgbe/axgbe_common.h | 11 + > drivers/net/axgbe/axgbe_dev.c | 19 ++ > drivers/net/axgbe/axgbe_ethdev.c | 1 + > drivers/net/axgbe/axgbe_ethdev.h | 1 + > drivers/net/axgbe/axgbe_rxtx.c | 305 +++++++++++++++---------- > drivers/net/axgbe/axgbe_rxtx_vec_sse.c | 1 + > 6 files changed, 223 insertions(+), 115 deletions(-) > 'doc/guides/nics/features/axgbe.ini' needs to be updated > diff --git a/drivers/net/axgbe/axgbe_common.h > b/drivers/net/axgbe/axgbe_common.h > index a5d11c5832..1face6f361 100644 > --- a/drivers/net/axgbe/axgbe_common.h > +++ b/drivers/net/axgbe/axgbe_common.h > @@ -162,6 +162,9 @@ > #define DMA_CH_SR 0x60 > > /* DMA channel register entry bit positions and sizes */ > +//TSO > Please prefer /* */ comments > +#define DMA_CH_CR_MSS_INDEX 0 > +#define DMA_CH_CR_MSS_WIDTH 14 > #define DMA_CH_CR_PBLX8_INDEX 16 > #define DMA_CH_CR_PBLX8_WIDTH 1 > #define DMA_CH_CR_SPH_INDEX 24 > @@ -1232,6 +1235,14 @@ > #define TX_CONTEXT_DESC3_VT_INDEX 0 > #define TX_CONTEXT_DESC3_VT_WIDTH 16 > > +//TSO > +#define TX_NORMAL_DESC3_TPL_INDEX 0 > +#define TX_NORMAL_DESC3_TPL_WIDTH 18 > +#define TX_NORMAL_DESC3_THL_INDEX 19 > +#define TX_NORMAL_DESC3_THL_WIDTH 4 > +#define TX_CONTEXT_DESC3_OSTC_INDEX 27 > +#define TX_CONTEXT_DESC3_OSTC_WIDTH 1 > + > #define TX_NORMAL_DESC2_HL_B1L_INDEX 0 > #define TX_NORMAL_DESC2_HL_B1L_WIDTH 14 > #define TX_NORMAL_DESC2_IC_INDEX 31 > diff --git a/drivers/net/axgbe/axgbe_dev.c b/drivers/net/axgbe/axgbe_dev.c > index 6a7fddffca..7e0d387fc3 100644 > --- a/drivers/net/axgbe/axgbe_dev.c > +++ b/drivers/net/axgbe/axgbe_dev.c > @@ -808,6 +808,24 @@ int axgbe_write_rss_lookup_table(struct axgbe_port > *pdata) > return 0; > } > > + > here adds extra empty line <...> > @@ -843,7 +847,7 @@ static int axgbe_xmit_hw(struct axgbe_tx_queue *txq, > > idx = AXGBE_GET_DESC_IDX(txq, txq->cur); > desc = &txq->desc[idx]; > - > + printf("tso::Inside axgbe_xmit_hw \n"); > We are not allowed to use 'printf' for logging, but need to use logging macros. There are other instances of 'printf' usage in this patch. <...> > + } else { > + /* Enable CRC and Pad Insertion */ > + AXGMAC_SET_BITS_LE(desc->desc3, TX_NORMAL_DESC3, CPC, 0); > + /* Total msg length to transmit */ > + AXGMAC_SET_BITS_LE(desc->desc3, TX_NORMAL_DESC3, FL, > + mbuf->pkt_len); > + } > +#if 0 > Please remove unused code for upstreaming.
