Re: [PATCH v5 1/1] build: add libarchive to external deps

On Sun, Nov 05, 2023 at 08:12:43PM -0800, Srikanth Yalavarthi wrote: > In order to avoid linking with Libs.private, libarchive > is not added to ext_deps during the meson setup stage. > > Since libarchive is not added to ext_deps, cross-compilation > or native compilation with libarchive installed

Re: [PATCH] doc: add prog action into default ini

06/11/2023 10:14, Qi Zhang: > Added prog action into nic feature default.ini. > > Fixes: 8f1953f1914d ("ethdev: add flow API for P4-programmable devices") > > Signed-off-by: Qi Zhang Applied, thanks.

Re: [PATCH v2 7/7] doc: testpmd support event handling section

在 2023/10/20 18:07, Chengwen Feng 写道: Add new section of event handling, which documented the ethdev and device events. Signed-off-by: Chengwen Feng --- doc/guides/testpmd_app_ug/event_handling.rst | 80 doc/guides/testpmd_app_ug/index.rst | 1 + 2 files cha

Re: [RFC] mempool: CPU cache aligning mempool driver accesses

On Sat, Nov 04, 2023 at 06:29:40PM +0100, Morten Brørup wrote: > I tried a little experiment, which gave a 25 % improvement in mempool > perf tests for long bursts (n_get_bulk=32 n_put_bulk=32 n_keep=512 > constant_n=0) on a Xeon E5-2620 v4 based system. > > This is the concept: > > If all access

[PATCH] net/cpfl: fix coverity issues

From: Wenjing Qiao Fix integer handling issues, tainted_scalar issues, uninit issues, overrun issues and control flow issues reported by coverity scan. Coverity issue: 403259 Coverity issue: 403261 Coverity issue: 403266 Coverity issue: 403267 Coverity issue: 403271 Coverity issue: 403274 Fixes:

Re: [PATCH v2] app/testpmd: fix UDP cksum error for UFO enable

On 11/6/2023 4:13 AM, lihuisong (C) wrote: > > 在 2023/11/3 18:42, Ferruh Yigit 写道: >> On 11/3/2023 9:09 AM, lihuisong (C) wrote: >>> Hi Ferruh, >>> >>> Thanks for you review. >>> >>> >>> 在 2023/11/3 9:31, Ferruh Yigit 写道: On 8/2/2023 3:55 AM, Huisong Li wrote: > The command "tso set " is

[PATCH v5] net/ice: fix crash on closing representor ports

The data resource in struct rte_eth_dev is cleared and points to NULL when the DCF port is closed. If the DCF representor port is closed after the DCF port is closed, a segmentation fault occurs because the representor port accesses the data resource released by the DCF port. This patch fixes thi

[PATCH] net/iavf: MDD fault diagnostics support on TX paths

When an MDD packet is detected, hardware will shutdown the queue. In a Tx path troubleshooting scenario, modifying the application code to reselect the Tx path is the only way to enable mbuf legitimacy check, which makes troubleshooting difficult. In this patch, the devargs option "mbuf_check" is

Re: [PATCH v5 2/5] net/sfc: use new API to parse kvargs

On 11/6/23 10:31, Chengwen Feng wrote: The sfc_kvargs_process() and sfc_efx_dev_class_get() function could handle both key=value and only-key, so they should use rte_kvargs_process_opt() instead of rte_kvargs_process() to parse. Signed-off-by: Chengwen Feng --- drivers/common/sfc_efx/sfc_efx.

Re: [PATCH 24.03 v2] build: track mandatory rather than optional libs

On Fri, Nov 03, 2023 at 09:19:53PM +0100, Morten Brørup wrote: > > From: Bruce Richardson [mailto:bruce.richard...@intel.com] > > Sent: Friday, 3 November 2023 19.09 > > > > On Fri, Nov 03, 2023 at 06:31:30PM +0100, Morten Brørup wrote: > > > > From: Bruce Richardson [mailto:bruce.richard...@intel

RE: [RFC] mempool: CPU cache aligning mempool driver accesses

> From: Bruce Richardson [mailto:bruce.richard...@intel.com] > Sent: Monday, 6 November 2023 10.45 > > On Sat, Nov 04, 2023 at 06:29:40PM +0100, Morten Brørup wrote: > > I tried a little experiment, which gave a 25 % improvement in mempool > > perf tests for long bursts (n_get_bulk=32 n_put_bulk=3

Re: [PATCH v9 7/9] ethdev: add API to get RSS algorithm names

On 11/2/23 11:20, Jie Hai wrote: This patch adds new API rte_eth_dev_rss_algo_name() to get name of a RSS algorithm and document it. Signed-off-by: Jie Hai Acked-by: Huisong Li Acked-by: Chengwen Feng @@ -4791,6 +4802,20 @@ rte_eth_dev_rss_hash_conf_get(uint16_t port_id, return r

RE: [PATCH v2 1/1] ml/cnxk: fix updating internal I/O info

> -Original Message- > From: Srikanth Yalavarthi > Sent: Friday, November 3, 2023 10:10 PM > To: Srikanth Yalavarthi > Cc: dev@dpdk.org; Shivah Shankar Shankar Narayan Rao > ; Anup Prabhu ; > Prince Takkar ; Jerin Jacob Kollanukkaran > > Subject: [PATCH v2 1/1] ml/cnxk: fix updating in

Re: [PATCH v9 1/9] ethdev: overwrite some comment related to RSS

On 11/2/23 11:20, Jie Hai wrote: In rte_eth_dev_rss_hash_conf_get(), the "rss_key_len" should be greater than or equal to the "hash_key_size" which get from rte_eth_dev_info_get() API. And the "rss_key" should contain at least "hash_key_size" bytes. If these requirements are not met, the query un

RE: [PATCH 24.03 v2] build: track mandatory rather than optional libs

> From: Bruce Richardson [mailto:bruce.richard...@intel.com] > Sent: Monday, 6 November 2023 11.29 > > On Fri, Nov 03, 2023 at 09:19:53PM +0100, Morten Brørup wrote: > > > From: Bruce Richardson [mailto:bruce.richard...@intel.com] > > > Sent: Friday, 3 November 2023 19.09 > > > > > > On Fri, Nov 0

Re: [PATCH 24.03 v2] build: track mandatory rather than optional libs

On Mon, Nov 06, 2023 at 12:22:57PM +0100, Morten Brørup wrote: > > From: Bruce Richardson [mailto:bruce.richard...@intel.com] > > Sent: Monday, 6 November 2023 11.29 > > > > On Fri, Nov 03, 2023 at 09:19:53PM +0100, Morten Brørup wrote: > > > > From: Bruce Richardson [mailto:bruce.richard...@intel

Re: [PATCH] doc/contributing: update RST text-wrapping guidelines

03/11/2023 14:42, Ferruh Yigit: > On 11/3/2023 1:29 PM, Bruce Richardson wrote: > > Update and clarify the guidelines on how to wrap lines in our RST docs. > > We no longer limit lines to just 80 characters, and what is more > > important that line length is the wrapping of sentences, starting a ne

RE: [PATCH 24.03 v2] build: track mandatory rather than optional libs

> From: Bruce Richardson [mailto:bruce.richard...@intel.com] > Sent: Monday, 6 November 2023 12.27 > > On Mon, Nov 06, 2023 at 12:22:57PM +0100, Morten Brørup wrote: > > > From: Bruce Richardson [mailto:bruce.richard...@intel.com] > > > Sent: Monday, 6 November 2023 11.29 > > > > > > On Fri, Nov 0

Re: [PATCH] net/sfc: fix null dereference in syslog

On 11/4/2023 7:37 AM, Weiguo Li wrote: > When ctx->sa is null, sfc_err(ctx->sa, ...) will triger a null > dereference in the macro of sfc_err. Use SFC_GENERIC_LOG(ERR, ...) > to avoid that. > > Fixes: 44db08d53be3 ("net/sfc: maintain controller to EFX interface mapping") > Cc: sta...@dpdk.org > >

RE: [PATCH v5] net/ice: fix crash on closing representor ports

> -Original Message- > From: Ye, MingjinX > Sent: Monday, November 6, 2023 6:00 PM > To: dev@dpdk.org > Cc: Yang, Qiming ; Zhou, YidingX > ; Ye, MingjinX ; > sta...@dpdk.org; Zhang, Qi Z > Subject: [PATCH v5] net/ice: fix crash on closing representor ports > > The data resource in str

Re: [PATCH v2 1/2] mempool: fix internal function documentation

On 10/23/23 12:38, Ferruh Yigit wrote: static function `rte_mempool_do_generic_get()` returns zero on success, not >=0 as its function comment documents. Since this function called by public API, the comment causes confusion on the public API return value. Fixing the internal function documenta

Re: [PATCH v5 2/5] net/sfc: use new API to parse kvargs

Hi Andrew, On 2023/11/6 18:28, Andrew Rybchenko wrote: > On 11/6/23 10:31, Chengwen Feng wrote: >> The sfc_kvargs_process() and sfc_efx_dev_class_get() function could >> handle both key=value and only-key, so they should use >> rte_kvargs_process_opt() instead of rte_kvargs_process() to parse. >>

Re: [PATCH v2] app/testpmd: fix UDP cksum error for UFO enable

在 2023/11/6 18:09, Ferruh Yigit 写道: On 11/6/2023 4:13 AM, lihuisong (C) wrote: 在 2023/11/3 18:42, Ferruh Yigit 写道: On 11/3/2023 9:09 AM, lihuisong (C) wrote: Hi Ferruh, Thanks for you review. 在 2023/11/3 9:31, Ferruh Yigit 写道: On 8/2/2023 3:55 AM, Huisong Li wrote: The command "tso set

Re: [PATCH v2 7/7] doc: testpmd support event handling section

Hi Huisong, On 2023/11/6 17:28, lihuisong (C) wrote: > > 在 2023/10/20 18:07, Chengwen Feng 写道: >> Add new section of event handling, which documented the ethdev and >> device events. >> >> Signed-off-by: Chengwen Feng >> --- >>   doc/guides/testpmd_app_ug/event_handling.rst | 80

Re: [PATCH v2 5/7] app/testpmd: add error recovery usage demo

Hi Huisong, On 2023/11/1 12:08, lihuisong (C) wrote: > > 在 2023/10/20 18:07, Chengwen Feng 写道: >> This patch adds error recovery usage demo which will: >> 1. stop packet forwarding when the RTE_ETH_EVENT_ERR_RECOVERING event >>     is received. >> 2. restart packet forwarding when the RTE_ETH_EVE

[PATCH v3 3/7] net/bnxt: fix race-condition when report error recovery

If set data path functions to dummy functions before reports error recovering event, there maybe a race-condition with data path threads, this patch fixes it by setting data path functions to dummy functions only after reports such event. Fixes: e11052f3a46f ("net/bnxt: support proactive error han

[PATCH v3 0/7] fix race-condition of proactive error handling mode

This patch fixes race-condition of proactive error handling mode, the discussion thread [1]. [1] http://patchwork.dpdk.org/project/dpdk/patch/20230220060839.1267349-2-ashok.k.kal...@intel.com/ Chengwen Feng (7): ethdev: fix race-condition of proactive error handling mode net/hns3: replace fp

[PATCH v3 2/7] net/hns3: replace fp ops config function

This patch replace hns3_eth_dev_fp_ops_config() with rte_eth_fp_ops_setup(). Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng Acked-by: Dongdong Liu Acked-by: Konstantin Ananyev Acked-by: Huisong Li --- drivers/net/hns3/hns3_rxtx.c | 21 +++-- 1 file changed, 3 insertions(+),

[PATCH v3 4/7] net/bnxt: use fp ops setup function

Use rte_eth_fp_ops_setup() instead of directly manipulating rte_eth_fp_ops variable. Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng Acked-by: Konstantin Ananyev Acked-by: Ajit Khaparde Acked-by: Huisong Li --- drivers/net/bnxt/bnxt_cpr.c| 5 + drivers/net/bnxt/bnxt_ethdev.c | 5 +--

[PATCH v3 6/7] app/testpmd: extract event handling to event.c

This patch extract event handling (including eth-event and dev-event) to a new file 'event.c'. Signed-off-by: Chengwen Feng Acked-by: Huisong Li --- app/test-pmd/event.c | 390 ++ app/test-pmd/meson.build | 1 + app/test-pmd/parameters.c | 36 +--- a

[PATCH v3 1/7] ethdev: fix race-condition of proactive error handling mode

In the proactive error handling mode, the PMD will set the data path pointers to dummy functions and then try recovery, in this period the application may still invoking data path API. This will introduce a race-condition with data path which may lead to crash [1]. Although the PMD added delay aft

[PATCH v3 5/7] app/testpmd: add error recovery usage demo

This patch adds error recovery usage demo which will: 1. stop packet forwarding when the RTE_ETH_EVENT_ERR_RECOVERING event is received. 2. restart packet forwarding when the RTE_ETH_EVENT_RECOVERY_SUCCESS event is received. 3. prompt the ports that fail to recovery and need to be removed whe

[PATCH v3 7/7] doc: testpmd support event handling section

Add new section of event handling, which documented the ethdev and device events. Signed-off-by: Chengwen Feng --- doc/guides/testpmd_app_ug/event_handling.rst | 81 doc/guides/testpmd_app_ug/index.rst | 1 + 2 files changed, 82 insertions(+) create mode 100644 do

Re: [PATCH] eal/linux: verify mmu type for DPDK support (ppc64le)

23/10/2023 23:59, David Christensen: > > On 10/17/23 5:39 AM, Thomas Monjalon wrote: > > I feel this function should not be implemented in the common EAL. > > What about adding a new function in lib/eal/ppc/ ? > > And add the "return true" for other architectures? > > Would it be more appropriate

Re: [PATCH v3] eal/linux: verify mmu type for DPDK support (ppc64le)

24/10/2023 19:43, David Christensen: > IBM POWER systems support more than one type of memory management unit > (MMU). The Power ISA 3.0 specification, which applies to P9 and later > CPUs, defined a new Radix MMU which, among other things, allows an > anonymous memory page mapping to be converted

Re: [PATCH v1] config/arm: correct cpu arch for cross build

18/10/2023 07:40, Joyce Kong: > > From: Thomas Monjalon > > 22/08/2023 09:47, Joyce Kong: > > > The cn10k cross build file sets cpu to 'armv8.6-a' while > > > N2 is armv8.5-a arch. > > > The cpu field in the cross file doesn't take effect as > > > config/arm/meson.build controls machine_args for m

Re: [PATCH] config/arm: add cortex-A55 part number

30/10/2023 16:51, Hemant Agrawal: > This patch adds the part number for Cortex-A55 ARM Cores > A55 is used in NXP-i.mx93 SoCs. > > Signed-off-by: Hemant Agrawal Applied, thanks.

[PATCH 1/2] crypto/qat: fix block cipher misalignment for AES CBC and 3DES CBC

check cipher length alignment for 3DES CBC and AES CBC to change it to NULL op for buffer misalignment Fixes: a815a04cea05 ("crypto/qat: support symmetric build op request") Fixes: 85fec6fd9674 ("crypto/qat: unify raw data path functions") Fixes: def38073ac90 ("crypto/qat: check cipher buffer alig

[PATCH 2/2] test/crypto: add negative test cases for cipher buffer alignment

add negative test cases for 3DES CBC and AES CBC cipher algorithms for buffer misalignment Signed-off-by: Sivaramakrishnan Venkat --- app/test/test_cryptodev.c | 321 - app/test/test_cryptodev_aes_test_vectors.h | 119 app/test/test_cryptodev_blockci

[PATCH] net/mvpp2: fix null dereference in vmwa release

Pointer 'mrvl_cfg' is dereferenced and then compared to NULL. Move dereference after NULL test to fix this issue. Fixes: 7af10d29a4a0 ("net/mlx5/linux: refactor VLAN") Cc: sta...@dpdk.org Signed-off-by: Weiguo Li --- drivers/net/mlx5/linux/mlx5_vlan_os.c | 3 ++- 1 file changed, 2 insertions(+)

Re: configuration of memseg lists number

Thanks, it makes sense. I'll get around to it "eventually". On Thu, 2023-11-02 at 11:04 +0100, Thomas Monjalon wrote: > Hello, > > While looking at Seastar, I see it uses this patch on top of DPDK: > > build: add meson options of max_memseg_lists > > RTE_MAX_MEMSEG_LISTS = 128 i

Re: [PATCH v3] config/arm: update aarch32 build with gcc13

01/11/2023 13:57, Paul Szczepanek: > > On 25/10/2023 13:57, Juraj Linkeš wrote: > > The aarch32 with gcc13 fails with: > > > > Compiler for C supports arguments -march=armv8-a: NO > > > > ../config/arm/meson.build:714:12: ERROR: Problem encountered: No > > suitable armv8 march version found. > > >

Re: [PATCH v2] config: verify machine arch flag

26/10/2023 20:13, Sivaprasad Tummala: > Added additional checks for compiler support of specific cpu arch > flags to fix incorrect error reporting. > > Without this patch, meson build reports '__SSE4_2__' not defined > error for x86 builds when the compiler does not support the specified > cpu_ins

RE: [PATCH 1/2] pipeline: fix calloc parameters

> -Original Message- > From: Ferruh Yigit > Sent: Thursday, November 2, 2023 1:09 PM > To: Dumitrescu, Cristian ; R, Kamalakannan > > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: [PATCH 1/2] pipeline: fix calloc parameters > > gcc [1] generates warning [2] about calloc usage, because c

RE: [PATCH v1] config/arm: correct cpu arch for cross build

> -Original Message- > From: Thomas Monjalon > Sent: Monday, November 6, 2023 10:10 PM > To: Ruifeng Wang ; Joyce Kong > > Cc: dev@dpdk.org; Bruce Richardson ; > dev@dpdk.org; nd ; Paul Szczepanek > > Subject: Re: [PATCH v1] config/arm: correct cpu arch for cross build > > 18/10/2023 07

RE: [PATCH v1 1/1] ml/cnxk: fix updating internal I/O info

> -Original Message- > From: Srikanth Yalavarthi > Sent: Sunday, October 29, 2023 6:55 PM > To: Srikanth Yalavarthi > Cc: dev@dpdk.org; Shivah Shankar Shankar Narayan Rao > ; Anup Prabhu ; > Prince Takkar ; Jerin Jacob Kollanukkaran > > Subject: [PATCH v1 1/1] ml/cnxk: fix updating inter

Re: [PATCH v5 1/1] build: add libarchive to external deps

06/11/2023 09:53, Bruce Richardson: > On Sun, Nov 05, 2023 at 08:12:43PM -0800, Srikanth Yalavarthi wrote: > > In order to avoid linking with Libs.private, libarchive > > is not added to ext_deps during the meson setup stage. > > > > Since libarchive is not added to ext_deps, cross-compilation > >

Re: [PATCH v5 1/1] build: add libarchive to external deps

06/11/2023 16:24, Thomas Monjalon: > 06/11/2023 09:53, Bruce Richardson: > > On Sun, Nov 05, 2023 at 08:12:43PM -0800, Srikanth Yalavarthi wrote: > > > In order to avoid linking with Libs.private, libarchive > > > is not added to ext_deps during the meson setup stage. > > > > > > Since libarchive

Re: [PATCH v1] config/arm: correct cpu arch for cross build

06/11/2023 15:31, Joyce Kong: > > -Original Message- > > From: Thomas Monjalon > > Sent: Monday, November 6, 2023 10:10 PM > > To: Ruifeng Wang ; Joyce Kong > > > > Cc: dev@dpdk.org; Bruce Richardson ; > > dev@dpdk.org; nd ; Paul Szczepanek > > > > Subject: Re: [PATCH v1] config/arm: cor

RE: [PATCH v6 1/2] bus/pci: add function to enable/disable PASID

>+Is PASID now part of PCIe spec? This APIs should both work for x86/arm? >+Not sure ARM is OK with the naming, previously they are calling it more as >Sub Stream ID (SSID) For reference, Look for PASID definitions in the PCIe spec. The API takes in offset which might be different for other devic

Re: [PATCH] remove unnecessary null check before free/rte_free

25/10/2023 00:58, Stephen Hemminger: > This is the latest round of places that are checking for NULL > pointer before calling free or rte_free. It is result of applying > the nullfree.cocci script. > > Signed-off-by: Stephen Hemminger Applied and re-run with more fixes in new ml/cnxk code, thank

Re: [PATCH v5 1/1] build: add libarchive to external deps

On Mon, Nov 6, 2023 at 5:12 AM Srikanth Yalavarthi wrote: > > In order to avoid linking with Libs.private, libarchive > is not added to ext_deps during the meson setup stage. > > Since libarchive is not added to ext_deps, cross-compilation > or native compilation with libarchive installed in non-s

Re: [PATCH v4 1/5] kvargs: add one new process API

On Mon, 6 Nov 2023 15:13:35 +0800 fengchengwen wrote: > >> + > > > > Looks good but may I suggest some alternatives. > > > > Since this is an API and ABI change as was not announced, maybe a little > > late > > in the process for this release. And since unlikely to go in 23.11 need to > > d

Re: [PATCH v5 1/1] build: add libarchive to external deps

On Mon, Nov 06, 2023 at 05:03:10PM +0100, David Marchand wrote: > On Mon, Nov 6, 2023 at 5:12 AM Srikanth Yalavarthi > wrote: > > > > In order to avoid linking with Libs.private, libarchive is not added to > > ext_deps during the meson setup stage. > > > > Since libarchive is not added to ext_deps

Re: rte_timer_reset related issues in DPDK 20.05

On Mon, 6 Nov 2023 10:31:20 + Nagma Meraj wrote: > TCS Confidential > > Hi, > > We are working on Front Haul Library which is using DPDK internally for data > accleration. > In that we are facing the following issues: > 1.In Front Haul Library, one of the threads xran_timing_source_thread(

Re: [PATCH v3] eal: support lcore usage ratio

23/10/2023 14:51, Chengwen Feng: > Current, the lcore usage only display two key fields: busy_cycles and > total_cycles, which is inconvenient to obtain the usage ratio > immediately. So adds lcore usage ratio field. > > Signed-off-by: Chengwen Feng > Acked-by: Morten Brørup Acked-by: Huisong Li

Re: [PATCH] eal: provide trace point register macro for MSVC

01/11/2023 23:47, Tyler Retzlaff: > Provide an alternate RTE_TRACE_POINT_REGISTER macro when building with > MSVC that allocates segments for the trace point using MSVC specific > features Please could you elaborate what is the improvement? > +#define RTE_TRACE_POINT_REGISTER(trace, name) \ > +rt

Re: [PATCH] eal: add missing extension to statement expression

01/11/2023 23:07, Tyler Retzlaff: > add missing __extension__ keyword to RTE_ALIGN_MUL_NEAR statement > expression to be consistent with other macros using statement > expressions > > Signed-off-by: Tyler Retzlaff Applied, thanks.

Re: [PATCH] eal: stop iteration after lcore info is processed

> > Telemetry iterates on lcore ID to collect info of a specific lcore. > > Since only one lcore is processed at a time, the iteration can stop > > when a matching lcore is found. > > > > Fixes: f2b852d909f9 ("eal: add lcore info in telemetry") > > Cc: rja...@redhat.com > > Cc: sta...@dpdk.org > >

[PATCH v7 0/2] *** Disable PASID for DLB Device ***

This series implement an internal API to disable PASID and calls the api to disable PASID in event/dlb2 device. Abdullah Sevincer (2): bus/pci: support PASID control event/dlb2: fix disable PASID drivers/bus/pci/pci_common.c | 7 +++ drivers/bus/pci/rte_bus_pci.h | 13

Re: [PATCH v2 1/2] bus/cdx: add support for devices without MSI

On 11/3/2023 4:50 PM, Shubham Rohila wrote: From: Nikhil Agarwal Update the cleanup routine for cdx device to support device without MSI. Also, set vfio_dev_fd for such devices This fd can be used for BME reload operations. Signed-off-by: Nikhil Agarwal Signed-off-by: Shubham Rohila ---

[PATCH v7 1/2] bus/pci: support PASID control

Add an internal API to control PASID for a given PCIe device. For kernels when PASID enabled by default it breaks DLB functionality, hence disabling PASID is required for DLB to function properly. PASID capability is not exposed to users hence offset can not be retrieved by rte_pci_find_ext_capab

[PATCH v7 2/2] event/dlb2: fix disable PASID

In vfio-pci driver when PASID is enabled by default DLB hardware puts DLB in SIOV mode. This breaks DLB PF-PMD mode. For DLB PF-PMD mode to function properly PASID needs to be disabled. In this commit this issue is addressed and PASID is disabled by writing a zero to PASID control register. Fixes

[PATCH v5 00/23] dts: add dts api docs

The commits can be split into groups. The first commit makes changes to the code. These code changes mainly change the structure of the code so that the actual API docs generation works. There are also some code changes which get reflected in the documentation, such as making functions/methods/att

[PATCH v5 01/23] dts: code adjustments for doc generation

The standard Python tool for generating API documentation, Sphinx, imports modules one-by-one when generating the documentation. This requires code changes: * properly guarding argument parsing in the if __name__ == '__main__' block, * the logger used by DTS runner underwent the same treatment so

[PATCH v5 03/23] dts: add basic developer docs

Expand the framework contribution guidelines and add how to document the code with Python docstrings. Signed-off-by: Juraj Linkeš --- doc/guides/tools/dts.rst | 73 1 file changed, 73 insertions(+) diff --git a/doc/guides/tools/dts.rst b/doc/guides/tools

[PATCH v5 02/23] dts: add docstring checker

Python docstrings are the in-code way to document the code. The docstring checker of choice is pydocstyle which we're executing from Pylama, but the current latest versions are not complatible due to [0], so pin the pydocstyle version to the latest working version. [0] https://github.com/klen/pyla

[PATCH v5 04/23] dts: exceptions docstring update

Format according to the Google format and PEP257, with slight deviations. Signed-off-by: Juraj Linkeš --- dts/framework/__init__.py | 12 - dts/framework/exception.py | 106 + 2 files changed, 83 insertions(+), 35 deletions(-) diff --git a/dts/framework

[PATCH v5 05/23] dts: settings docstring update

Format according to the Google format and PEP257, with slight deviations. Signed-off-by: Juraj Linkeš --- dts/framework/settings.py | 101 +- 1 file changed, 100 insertions(+), 1 deletion(-) diff --git a/dts/framework/settings.py b/dts/framework/settings.py i

[PATCH v5 07/23] dts: dts runner and main docstring update

Format according to the Google format and PEP257, with slight deviations. Signed-off-by: Juraj Linkeš --- dts/framework/dts.py | 128 --- dts/main.py | 8 ++- 2 files changed, 112 insertions(+), 24 deletions(-) diff --git a/dts/framework/dts.py

[PATCH v5 08/23] dts: test suite docstring update

Format according to the Google format and PEP257, with slight deviations. Signed-off-by: Juraj Linkeš --- dts/framework/test_suite.py | 223 +++- 1 file changed, 168 insertions(+), 55 deletions(-) diff --git a/dts/framework/test_suite.py b/dts/framework/test_suit

[PATCH v5 06/23] dts: logger and settings docstring update

Format according to the Google format and PEP257, with slight deviations. Signed-off-by: Juraj Linkeš --- dts/framework/logger.py | 72 +-- dts/framework/utils.py | 96 ++--- 2 files changed, 121 insertions(+), 47 deletions(-) dif

[PATCH v5 09/23] dts: test result docstring update

Format according to the Google format and PEP257, with slight deviations. Signed-off-by: Juraj Linkeš --- dts/framework/test_result.py | 292 --- 1 file changed, 234 insertions(+), 58 deletions(-) diff --git a/dts/framework/test_result.py b/dts/framework/test_res

[PATCH v5 10/23] dts: config docstring update

Format according to the Google format and PEP257, with slight deviations. Signed-off-by: Juraj Linkeš --- dts/framework/config/__init__.py | 371 ++- dts/framework/config/types.py| 132 +++ 2 files changed, 446 insertions(+), 57 deletions(-) create mode 1

[PATCH v5 11/23] dts: remote session docstring update

Format according to the Google format and PEP257, with slight deviations. Signed-off-by: Juraj Linkeš --- dts/framework/remote_session/__init__.py | 39 +- .../remote_session/remote_session.py | 128 +- dts/framework/remote_session/ssh_session.py | 16 +-- 3

[PATCH v5 12/23] dts: interactive remote session docstring update

Format according to the Google format and PEP257, with slight deviations. Signed-off-by: Juraj Linkeš --- .../interactive_remote_session.py | 36 +++ .../remote_session/interactive_shell.py | 99 +++ dts/framework/remote_session/python_shell.py | 26 -

[PATCH v5 13/23] dts: port and virtual device docstring update

Format according to the Google format and PEP257, with slight deviations. Signed-off-by: Juraj Linkeš --- dts/framework/testbed_model/__init__.py | 16 -- dts/framework/testbed_model/port.py | 53 +++ dts/framework/testbed_model/virtual_device.py | 17 +-

[PATCH v5 14/23] dts: cpu docstring update

Format according to the Google format and PEP257, with slight deviations. Signed-off-by: Juraj Linkeš --- dts/framework/testbed_model/cpu.py | 196 + 1 file changed, 144 insertions(+), 52 deletions(-) diff --git a/dts/framework/testbed_model/cpu.py b/dts/framework/t

[PATCH v5 15/23] dts: os session docstring update

Format according to the Google format and PEP257, with slight deviations. Signed-off-by: Juraj Linkeš --- dts/framework/testbed_model/os_session.py | 275 -- 1 file changed, 208 insertions(+), 67 deletions(-) diff --git a/dts/framework/testbed_model/os_session.py b/dts/fram

[PATCH v5 16/23] dts: posix and linux sessions docstring update

Format according to the Google format and PEP257, with slight deviations. Signed-off-by: Juraj Linkeš --- dts/framework/testbed_model/linux_session.py | 63 ++- dts/framework/testbed_model/posix_session.py | 81 +--- 2 files changed, 113 insertions(+), 31 deletions(-)

[PATCH v5 17/23] dts: node docstring update

Format according to the Google format and PEP257, with slight deviations. Signed-off-by: Juraj Linkeš --- dts/framework/testbed_model/node.py | 191 +++- 1 file changed, 131 insertions(+), 60 deletions(-) diff --git a/dts/framework/testbed_model/node.py b/dts/framework/

[PATCH v5 18/23] dts: sut and tg nodes docstring update

Format according to the Google format and PEP257, with slight deviations. Signed-off-by: Juraj Linkeš --- dts/framework/testbed_model/sut_node.py | 219 dts/framework/testbed_model/tg_node.py | 42 +++-- 2 files changed, 170 insertions(+), 91 deletions(-) diff --git a

[PATCH v5 19/23] dts: base traffic generators docstring update

Format according to the Google format and PEP257, with slight deviations. Signed-off-by: Juraj Linkeš --- .../traffic_generator/__init__.py | 22 - .../capturing_traffic_generator.py| 46 +++ .../traffic_generator/traffic_generator.py| 33 +

[PATCH v5 20/23] dts: scapy tg docstring update

Format according to the Google format and PEP257, with slight deviations. Signed-off-by: Juraj Linkeš --- .../testbed_model/traffic_generator/scapy.py | 91 +++ 1 file changed, 54 insertions(+), 37 deletions(-) diff --git a/dts/framework/testbed_model/traffic_generator/scapy.py

[PATCH v5 21/23] dts: test suites docstring update

Format according to the Google format and PEP257, with slight deviations. Signed-off-by: Juraj Linkeš --- dts/tests/TestSuite_hello_world.py | 16 + dts/tests/TestSuite_os_udp.py | 16 + dts/tests/TestSuite_smoke_tests.py | 53 +++--- 3 files changed,

[PATCH v5 22/23] dts: add doc generation dependencies

Sphinx imports every Python module when generating documentation from docstrings, meaning all dts dependencies, including Python version, must be satisfied. By adding Sphinx to dts dependencies we make sure that the proper Python version and dependencies are used when Sphinx is executed. Signed-of

[PATCH v5 23/23] dts: add doc generation

The tool used to generate developer docs is Sphinx, which is already used in DPDK. The same configuration is used to preserve style, but it's been augmented with doc-generating configuration and a change to how the sidebar displays the content hierarchy. Sphinx generates the documentation from Pyt

Re: [PATCH] eal: provide trace point register macro for MSVC

On Mon, Nov 06, 2023 at 05:40:12PM +0100, Thomas Monjalon wrote: > 01/11/2023 23:47, Tyler Retzlaff: > > Provide an alternate RTE_TRACE_POINT_REGISTER macro when building with > > MSVC that allocates segments for the trace point using MSVC specific > > features > > Please could you elaborate what

Re: [PATCH v7 0/2] *** Disable PASID for DLB Device ***

06/11/2023 18:05, Abdullah Sevincer: > This series implement an internal API to disable > PASID and calls the api to disable PASID in event/dlb2 device. > > Abdullah Sevincer (2): > bus/pci: support PASID control > event/dlb2: fix disable PASID Moved things in the right place/order and added

Re: [PATCH v5 1/1] build: add libarchive to external deps

On Mon, Nov 6, 2023 at 5:24 PM Bruce Richardson wrote: > > On Mon, Nov 06, 2023 at 05:03:10PM +0100, David Marchand wrote: > > On Mon, Nov 6, 2023 at 5:12 AM Srikanth Yalavarthi > > wrote: > > > > > > In order to avoid linking with Libs.private, libarchive is not added to > > > ext_deps during th

Re: [PATCH v7 1/2] bus/pci: support PASID control

On Mon, Nov 6, 2023 at 6:05 PM Abdullah Sevincer wrote: > > Add an internal API to control PASID for a given PCIe device. > > For kernels when PASID enabled by default it breaks DLB functionality, > hence disabling PASID is required for DLB to function properly. > > PASID capability is not exposed

RE: [PATCH v7 1/2] bus/pci: support PASID control

>+I don't see much point in providing a wrapper that does nothing more than >call rte_pci_write_config() and let the driver pass the right offsets. >+If anything, can't this wrapper find out about the pasid offset itself? >+There is a extended capability for this, so I would expect it can be use

Re: Updating examples which use coremask parameters

On Thu, 2 Nov 2023 16:58:52 + Bruce Richardson wrote: > On Thu, Nov 02, 2023 at 05:28:42PM +0100, Thomas Monjalon wrote: > > 02/11/2023 15:56, Bruce Richardson: > > > Hi all, > > > > > > looking to start a discussion and get some input here. > > > > > > There are a number of our examples

Re: [PATCH] dumpcap: fix mbuf pool ring type

On Mon, 2 Oct 2023 10:42:53 +0200 Morten Brørup wrote: > > Switching to rte_pktmbuf_pool_create() still leaves the user with the > > possibility to shoot himself in the foot (I was thinking of setting > > some --mbuf-pool-ops-name EAL option). > > > > This application has explicit requirements i

Re: [PATCH] dumpcap: fix mbuf pool ring type

On Mon, 2 Oct 2023 09:33:50 +0200 David Marchand wrote: > Switching to rte_pktmbuf_pool_create() still leaves the user with the > possibility to shoot himself in the foot (I was thinking of setting > some --mbuf-pool-ops-name EAL option). > > This application has explicit requirements in terms o

[PATCH v2] dumpcap: fix mbuf pool ring type

The internal buffer pool used for copies of mbufs captured needs to be thread safe. If capturing on multiple interfaces or multiple queues, the same pool will be used (consumers). And if the capture ring gets full, the queues will need to put back the capture buffer which leads to multiple produce

Re: [PATCH] dmadev: add tracepoints at control path APIs

20/10/2023 04:21, Chengwen Feng: > Add tracepoints at control path APIs for tracing support. > > Note: Fast path APIs don't support tracepoints because the APIs contains > struct and enum, if adding tracepints will lead to chkincs failure. > > Signed-off-by: Chengwen Feng > Acked-by: Morten Brør

Re: [PATCH v4] dmadev: add tracepoints

11/10/2023 11:55, fengchengwen: > Hi Thomas, > > Sorry for the late reply. > > On 2023/8/14 22:16, Thomas Monjalon wrote: > > jeudi 3 août 2023, fengchengwen: > >> Hi Thomas, > >> > >> On 2023/7/31 20:48, Thomas Monjalon wrote: > >>> 10/07/2023 09:50, fengchengwen: > Hi Thomas, > > >>

Re: [PATCH] config/x86: config support for AMD EPYC processors

17/10/2023 12:27, Morten Brørup: > > >> From: Tummala, Sivaprasad > > >>> From: David Marchand > > >>> On Mon, Sep 25, 2023 at 5:11 PM Sivaprasad Tummala > > From: Sivaprasad Tummala > > > > By default, max lcores are limited to 128 for x86 platforms. > > On AMD EPYC processo

Re: [PATCH] maintainers: update for mempool library

01/11/2023 17:48, Andrew Rybchenko: > > On November 1, 2023 19:20:29 Morten Brørup wrote: > > > Add co-maintainer for Memory pool. > > > > Suggested-by: Thomas Monjalon > > Signed-off-by: Morten Brørup > > Acked-by: Andrew Rybchenko Applied, thanks Morten for helping.

  1   2   >