> -----Original Message-----
> From: Thomas Monjalon <tho...@monjalon.net>
> Sent: Monday, November 6, 2023 10:10 PM
> To: Ruifeng Wang <ruifeng.w...@arm.com>; Joyce Kong
> <joyce.k...@arm.com>
> Cc: dev@dpdk.org; Bruce Richardson <bruce.richard...@intel.com>;
> dev@dpdk.org; nd <n...@arm.com>; Paul Szczepanek
> <paul.szczepa...@arm.com>
> Subject: Re: [PATCH v1] config/arm: correct cpu arch for cross build
> 
> 18/10/2023 07:40, Joyce Kong:
> > > From: Thomas Monjalon <tho...@monjalon.net>
> > > 22/08/2023 09:47, Joyce Kong:
> > > > The cn10k cross build file sets cpu to 'armv8.6-a' while
> > > > N2 is armv8.5-a arch.
> > > > The cpu field in the cross file doesn't take effect as
> > > > config/arm/meson.build controls machine_args for march.
> > > > Then correct the value in arm cross files to 'auto'.
> > >
> > > I don't get it.
> > > Why setting a value if it has no impact?
> > > Looks like something is overcomplicated.
> > >
> > We still have to declare them here because meson would check the 'cpu'
> line in the config file, otherwise it would report missing {'cpu'}.
> 
> OK
> 
> Then why not all cross files are set to auto?
> 
Actually, I set all the Arm cross files to auto in this patch. Maybe I have to 
figure it out in the commit line?

Reply via email to