RE: [PATCH v3 0/3] introduce maximum Rx buffer size

2023-10-31 Thread Morten Brørup
> From: lihuisong (C) [mailto:lihuis...@huawei.com] > Sent: Tuesday, 31 October 2023 03.58 > > 在 2023/10/31 2:48, Stephen Hemminger 写道: > > On Mon, 30 Oct 2023 09:25:34 +0800 > > "lihuisong (C)" wrote: > > > >>> > The "min_rx_bufsize" in struct rte_eth_dev_info stands for the > minimum

[PATCH v3] net/cpfl: support action prog

2023-10-31 Thread wenjing . qiao
From: Wenjing Qiao Parse JSON file and generate rules that instruct PMD to map an RTE_FLOW_ACTION_TYPE_PROG to a low-level FXP representation, the matching follows below guidelines. Use rte_flow_action_prog->name to match the name of a P4 action type when provided in the JSON file. In cases wher

RE: [PATCH] net/mlx5: fix the E-Switch mirror flow rule validation

2023-10-31 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Jiawei(Jonny) Wang > Sent: Wednesday, October 11, 2023 9:43 AM > To: Suanming Mou ; Slava Ovsiienko > > Cc: dev@dpdk.org; Raslan Darawsheh ; > sta...@dpdk.org > Subject: [PATCH] net/mlx5: fix the E-Switch mirror flow rule validation > > The port action a

RE: [PATCH] net/mlx5: fix missing thread safety flag for flow API

2023-10-31 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Dariusz Sosnowski > Sent: Monday, October 23, 2023 1:23 PM > To: Matan Azrad ; Slava Ovsiienko > ; Ori Kam ; Suanming Mou > > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: [PATCH] net/mlx5: fix missing thread safety flag for flow API > > When mlx5 port wa

RE: [PATCH] net/mlx5/hws: remove csum check from L3 ok check

2023-10-31 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Alexander Kozyrev > Sent: Wednesday, October 25, 2023 11:39 PM > To: dev@dpdk.org > Cc: Ori Kam ; Matan Azrad ; Michael > Baum ; Alex Vesker ; Suanming > Mou ; Slava Ovsiienko ; > Erez Shitrit > Subject: [PATCH] net/mlx5/hws: remove csum check from L3 ok

RE: [PATCH] net/mlx5/hws: fix integrity bits level

2023-10-31 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Alexander Kozyrev > Sent: Wednesday, October 25, 2023 11:41 PM > To: dev@dpdk.org > Cc: Ori Kam ; Matan Azrad ; Alex > Vesker ; Suanming Mou ; Slava > Ovsiienko ; Erez Shitrit > Subject: [PATCH] net/mlx5/hws: fix integrity bits level > > The level field

RE: [PATCH] net/mlx5: fix the workspace double free in Windows

2023-10-31 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Bing Zhao > Sent: Thursday, October 26, 2023 12:15 PM > To: Matan Azrad ; Slava Ovsiienko > ; Raslan Darawsheh ; > Suanming Mou ; Ori Kam > Cc: dev@dpdk.org; Gregory Etelson ; > sta...@dpdk.org > Subject: [PATCH] net/mlx5: fix the workspace double free in

RE: [PATCH v3] net/cpfl: support action prog

2023-10-31 Thread Zhang, Qi Z
> -Original Message- > From: Qiao, Wenjing > Sent: Tuesday, October 31, 2023 3:48 PM > To: Wu, Jingjing ; Xing, Beilei > ; > Zhang, Qi Z > Cc: dev@dpdk.org; Qiao, Wenjing > Subject: [PATCH v3] net/cpfl: support action prog > Support new rte_flow action need to update [rte_flow acti

RE: [PATCH] net/iavf: fix core dump when exiting testpmd

2023-10-31 Thread Zhang, Qi Z
> -Original Message- > From: Kaiwen Deng > Sent: Thursday, October 26, 2023 4:55 PM > To: dev@dpdk.org > Cc: Yang, Qiming ; Zhou, YidingX > ; Deng, KaiwenX ; Wu, > Jingjing ; Xing, Beilei ; Lu, > Wenzhuo ; Richardson, Bruce > > Subject: [PATCH] net/iavf: fix core dump when exiting test

Re: [PATCH v3] event/dlb2: fix disable PASID for kernel 6.2

2023-10-31 Thread Jerin Jacob
On Tue, Oct 31, 2023 at 4:12 AM Abdullah Sevincer wrote: > > vfio-pci driver in Linux kernel 6.2 enables PASID by default. > In DLB hardware, enabling PASID puts DLB in SIOV mode. This > breaks DLB PF-PMD mode. For DLB PF-PMD mode to function properly > PASID needs to be disabled for kernel 6.2. >

RE: [PATCH] crypto/qat: fix build when no openssl exists

2023-10-31 Thread Dooley, Brian
Hi Ciara, > -Original Message- > From: Power, Ciara > Sent: Friday, October 27, 2023 3:23 PM > To: dev@dpdk.org > Cc: Power, Ciara ; Dooley, Brian > ; sta...@dpdk.org; Ji, Kai > Subject: [PATCH] crypto/qat: fix build when no openssl exists > > Previously some compilation errors existed

RE: [PATCH] net/mlx5: reuse reformat and modify header actions in a table

2023-10-31 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Gregory Etelson > Sent: Monday, October 30, 2023 7:43 PM > To: dev@dpdk.org > Cc: Gregory Etelson ; Maayan Kashani > ; Raslan Darawsheh ; Ori Kam > ; Matan Azrad ; Slava Ovsiienko > ; Suanming Mou > Subject: [PATCH] net/mlx5: reuse reformat and modify hea

Re: [PATCH] ipsec: use sym_session_opaque_data for RTE_SECURITY_TYPE_CPU_CRYPTO

2023-10-31 Thread Garry Marshall
Hi Konstantin, Akhil, The patch is based on an issue I encountered when using the CPU_CRYPTO support - I was having problems where the ipsec session lookup was failing / was inconsistent. Examining the code in DPDK and looking for the use of RTE_SECURITY_ACTION_TYPE_CPU_CRYPTO I could see a reaso

[PATCH v2 1/6] net/mlx5: sample the srv6 last segment

2023-10-31 Thread Rongwei Liu
When removing the IPv6 routing extension header from the packets, the destination address should be updated to the last one in the segment list. Enlarge the hardware sample scope to cover the last segment. Signed-off-by: Rongwei Liu Acked-by: Ori Kam Acked-by: Suanming Mou --- drivers/net/mlx

[PATCH v2 0/6] support IPv6 extension push remove

2023-10-31 Thread Rongwei Liu
Support IPv6 extension push/remove in MLX5 PMD. Routing extension is the only supported type. v2: add reparse control and rebase. Rongwei Liu (6): net/mlx5: sample the srv6 last segment net/mlx5/hws: fix potential wrong errno value net/mlx5/hws: add IPv6 routing extension push remove action

[PATCH v2 3/6] net/mlx5/hws: add IPv6 routing extension push remove actions

2023-10-31 Thread Rongwei Liu
Add two dr_actions to implement IPv6 routing extension push and remove, the new actions are multiple actions combination instead of new types. Basically, there are two modify headers plus one reformat action. Action order is the same as encap and decap actions. Signed-off-by: Rongwei Liu Reviewe

[PATCH v2 2/6] net/mlx5/hws: fix potential wrong errno value

2023-10-31 Thread Rongwei Liu
A valid rte_errno is desired when DR layer api returns error and it can't over-write the value set by under-layer. Fixes: 890db3e2b90 ("net/mlx5/hws: support insert header action") Cc: hamd...@nvidia.com Signed-off-by: Rongwei Liu Reviewed-by: Alex Vesker Acked-by: Ori Kam --- drivers/net/mlx

[PATCH v2 6/6] net/mlx5/hws: add stc reparse support for srv6 push pop

2023-10-31 Thread Rongwei Liu
After pushing/popping srv6 into/from IPv6 packets, the checksum needs to be correct. In order to achieve this, there is a need to control each STE' reparse behavior(CX7 and above). Add two more flags enumeration definitions to allow external control of reparse property in stc. 1. Push a. 1st S

[PATCH v2 4/6] net/mlx5/hws: add setter for IPv6 routing push remove

2023-10-31 Thread Rongwei Liu
The rte action will be translated to multiple dr_actions which need different setters to program them. In order to leverage the existing setter logic, there is a new callback introduce which called fetch_opt with unique parameter. For each setter, it may have different reparsing properties. Sette

[PATCH v2 5/6] net/mlx5: implement IPv6 routing push remove

2023-10-31 Thread Rongwei Liu
Reserve the push data buffer for each job and the maximum length is set to 128 for now. Only supports type IPPROTO_ROUTING when translating the rte flow action. Remove actions must be shared globally and only supports next layer as TCP or UDP. Signed-off-by: Rongwei Liu Acked-by: Ori Kam Acked

[PATCH v3 0/6] support IPv6 extension push remove

2023-10-31 Thread Rongwei Liu
Support IPv6 extension push/remove actions in MLX5 PMD. Routing extension is the only supported type. v3: rebase. v2: add reparse control and rebase. Rongwei Liu (6): net/mlx5: sample the srv6 last segment net/mlx5/hws: fix potential wrong errno value net/mlx5/hws: add IPv6 routing extensio

[PATCH v3 1/6] net/mlx5: sample the srv6 last segment

2023-10-31 Thread Rongwei Liu
When removing the IPv6 routing extension header from the packets, the destination address should be updated to the last one in the segment list. Enlarge the hardware sample scope to cover the last segment. Signed-off-by: Rongwei Liu Acked-by: Ori Kam Acked-by: Suanming Mou --- drivers/net/mlx

[PATCH v3 3/6] net/mlx5/hws: add IPv6 routing extension push remove actions

2023-10-31 Thread Rongwei Liu
Add two dr_actions to implement IPv6 routing extension push and remove, the new actions are multiple actions combination instead of new types. Basically, there are two modify headers plus one reformat action. Action order is the same as encap and decap actions. Signed-off-by: Rongwei Liu Reviewe

[PATCH v3 4/6] net/mlx5/hws: add setter for IPv6 routing push remove

2023-10-31 Thread Rongwei Liu
The rte action will be translated to multiple dr_actions which need different setters to program them. In order to leverage the existing setter logic, there is a new callback introduce which called fetch_opt with unique parameter. For each setter, it may have different reparsing properties. Sette

[PATCH v3 2/6] net/mlx5/hws: fix potential wrong errno value

2023-10-31 Thread Rongwei Liu
A valid rte_errno is desired when DR layer api returns error and it can't over-write the value set by under-layer. Fixes: a318b3d54772 ("net/mlx5/hws: support insert header action") Cc: hamd...@nvidia.com Signed-off-by: Rongwei Liu Reviewed-by: Alex Vesker Acked-by: Ori Kam --- drivers/net/ml

[PATCH v3 5/6] net/mlx5: implement IPv6 routing push remove

2023-10-31 Thread Rongwei Liu
Reserve the push data buffer for each job and the maximum length is set to 128 for now. Only supports type IPPROTO_ROUTING when translating the rte flow action. Remove actions must be shared globally and only supports next layer as TCP or UDP. Signed-off-by: Rongwei Liu Acked-by: Ori Kam Acked

[PATCH v3 6/6] net/mlx5/hws: add stc reparse support for srv6 push pop

2023-10-31 Thread Rongwei Liu
After pushing/popping srv6 into/from IPv6 packets, the checksum needs to be correct. In order to achieve this, there is a need to control each STE' reparse behavior(CX7 and above). Add two more flags enumeration definitions to allow external control of reparse property in stc. 1. Push a. 1st S

Re: [PATCH] ethdev: fix flow API support for P4-programmable devices

2023-10-31 Thread Ferruh Yigit
On 10/29/2023 7:17 AM, Ori Kam wrote: > Hi Wenjing, > >> -Original Message- >> From: wenjing.q...@intel.com >> Sent: Friday, October 27, 2023 12:18 PM >> >> From: Wenjing Qiao >> >> "program" action should also be added in structure rte_flow_desc_action. >> >> Fixes: 8f1953f1914d ("ethde

Re: [PATCH] ethdev: fix RTE_FLOW_PORT_FLAG_SHARE_INDIRECT definition

2023-10-31 Thread Ferruh Yigit
On 10/30/2023 6:22 AM, Ori Kam wrote: > > >> -Original Message- >> From: Gregory Etelson >> Sent: Sunday, October 29, 2023 7:54 PM >> To: dev@dpdk.org >> >> Fix value of RTE_FLOW_PORT_FLAG_SHARE_INDIRECT. >> >> Fixes: f5b2846d89d7 ("ethdev: share indirect action between ports") >> Cc: st

Re: [RFC PATCH v4 4/4] dts: format docstrigs to google format

2023-10-31 Thread Yoan Picchi
On 8/31/23 11:04, Juraj Linkeš wrote: WIP: only one module is reformatted to serve as a demonstration. The google format is documented here [0]. [0]: https://google.github.io/styleguide/pyguide.html Signed-off-by: Juraj Linkeš Acked-by: Jeremy Spweock --- dts/framework/testbed_model/node.p

Re: [PATCH 1/2] net/txgbe: add proper memory barriers in Rx

2023-10-31 Thread Ferruh Yigit
On 10/30/2023 10:51 AM, Jiawen Wu wrote: > Refer to commit 85e46c532bc7 ("net/ixgbe: add proper memory barriers in > Rx"). Fix the same issue as ixgbe. > > Segmentation fault has been observed while running the > txgbe_recv_pkts_lro() function to receive packets on the Loongson 3A5000 > processor.

[PATCH 00/10] net/mlx5/hws: IPSEC reparse submission

2023-10-31 Thread Gregory Etelson
IPSEC reparse submission. Alex Vesker (3): net/mlx5/hws: allow jump to TIR over FDB net/mlx5/hws: support dynamic re-parse net/mlx5/hws: dynamic re-parse for modify header Hamdan Igbaria (6): net/mlx5/hws: support IPsec encryption/decryption action net/mlx5/hws: support ASO IPsec action

[PATCH 01/10] net/mlx5/hws: check the rule status on rule update

2023-10-31 Thread Gregory Etelson
From: Itamar Gozlan Only allow rule updates for rules with their status value equal to MLX5DR_RULE_STATUS_CREATED. Otherwise, the rule may be in an unstable stage like deleting and this will result in a faulty unexpected scenario. Signed-off-by: Hamdan Igbaria Reviewed-by: Alex Vesker Acked-by

[PATCH 02/10] net/mlx5/hws: support IPsec encryption/decryption action

2023-10-31 Thread Gregory Etelson
From: Hamdan Igbaria Support crypto action creation, this action allows encryption/decryption of the packet according a specific security crypto protocol. For now we support encryption/decryption according ipsec protocol. ipsec encryption handles the encoding of the data. ipsec decryption handles

[PATCH 04/10] net/mlx5/hws: support reformat trailer action

2023-10-31 Thread Gregory Etelson
From: Hamdan Igbaria Support reformat trailer action, this action allows to insert/remove specific crypto security protocol trailer on the packet. For now support IPsec crypto protocol trailer. The trailer should be added before encrypting the packet in Tx flow, and it can be removed after decryp

[PATCH 03/10] net/mlx5/hws: support ASO IPsec action

2023-10-31 Thread Gregory Etelson
From: Hamdan Igbaria Support ASO IPsec action, this action will allow performing some of ipsec full offload operations, for example replay protection and sequence number incrementation. In Tx flow this action used before encrypting the packet to increase the sequence number. In Rx flow this actio

[PATCH 05/10] net/mlx5/hws: support ASO first hit action

2023-10-31 Thread Gregory Etelson
From: Hamdan Igbaria Support ASO first hit action. This action allows tracking if a rule gets hit by a packet. Signed-off-by: Hamdan Igbaria Reviewed-by: Alex Vesker Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_prm.h | 5 + drivers/net/mlx5/hws/mlx5dr.h| 25 +

[PATCH 06/10] net/mlx5/hws: support insert header action

2023-10-31 Thread Gregory Etelson
From: Hamdan Igbaria Support insert header action, this will allow encap at a specific anchor and offset selected by the user. Signed-off-by: Hamdan Igbaria Reviewed-by: Alex Vesker Acked-by: Matan Azrad --- drivers/net/mlx5/hws/mlx5dr.h | 36 drivers/net/mlx5/hws/mlx5dr_a

[PATCH 07/10] net/mlx5/hws: support remove header action

2023-10-31 Thread Gregory Etelson
From: Hamdan Igbaria Support remove header action, this action will allow the user to execute dynamic decaps by choosing to decap by providing a start anchor and number of words to remove, or providing a start anchor and end anchor. Signed-off-by: Hamdan Igbaria Reviewed-by: Alex Vesker Acked-

[PATCH 08/10] net/mlx5/hws: allow jump to TIR over FDB

2023-10-31 Thread Gregory Etelson
From: Alex Vesker Current TIR action is allowed to be used only for NIC RX, this will allow TIR action over FDB for RX traffic in case of TX traffic packets will be dropped. Signed-off-by: Alex Vesker Reviewed-by: Erez Shitrit Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_prm.h |

[PATCH 09/10] net/mlx5/hws: support dynamic re-parse

2023-10-31 Thread Gregory Etelson
From: Alex Vesker Each steering entry (STE) has a bit called re-parse used for re-parsing the packet in HW, re-parsing is needed after reformat (e.g. push/pop/encapsulate/...) or when modifying the packet headers requiring structure change (e.g. TCP to UDP). Until now we re-parsed the packet in e

[PATCH 10/10] net/mlx5/hws: dynamic re-parse for modify header

2023-10-31 Thread Gregory Etelson
From: Alex Vesker With dynamic re-parse we would always require re-parse but this is not always necessary. Re-parse is only needed when the packet structure is changed. This support will allow dynamically deciding based on the action pattern if re-parse is required or no. Signed-off-by: Alex Ves

[PATCH 2/6] net/hns3: fix LRO offload to report

2023-10-31 Thread Jie Hai
From: Huisong Li Some network engines, like part of HIP09, may not support LRO offload, but this offload capability is also reported to user. So this patch determines whether driver reports this capability based on the capabilities from firmware. In addition, some network engines, like HIP08, al

[PATCH 1/6] net/hns3: fix setting DCB capability

2023-10-31 Thread Jie Hai
From: Huisong Li The "hw->capability" is set after querying firmware and version. But the DCB capability of PF is set in other place. So this patch moves setting DCB capability to the place where all capabilities are set. Fixes: ab2e2e344163 ("net/hns3: get device capability in primary process")

[PATCH 0/6] net/hns3: add some bugfix for hns3

2023-10-31 Thread Jie Hai
This patchset contains some bugfix for hns3 pmd. Huisong Li (2): net/hns3: fix setting DCB capability net/hns3: fix LRO offload to report Jie Hai (4): net/hns3: fix return value net/hns3: fix some error log net/hns3: do not export API for setting and getting algo and key net/hns3: fix

[PATCH 5/6] net/hns3: do not export API for setting and getting algo and key

2023-10-31 Thread Jie Hai
The functions "hns3_rss_set_algo_key()" and "hns3_rss_get_algo_key()" are the inner interfaces to set hardware. Driver already had an API, "hns3_update_rss_algo_key()", to export and to update RSS algo or key. So above two innter interface don't export. Fixes: 7da415d27d88 ("net/hns3: use hardware

[PATCH 6/6] net/hns3: fix uninitialized value

2023-10-31 Thread Jie Hai
This patch initializes "hash_algo" as zero to avoid using it uninitialized. Fixes: e3069658da9f ("net/hns3: reimplement hash flow function" Cc: sta...@dpdk.org Signed-off-by: Jie Hai --- drivers/net/hns3/hns3_rss.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/

[PATCH 3/6] net/hns3: fix return value

2023-10-31 Thread Jie Hai
1. Fix the return value of hns3_get_imissed_stats_num as 'uint16_t'. 2. Add some error check for return value. Fixes: fcba820d9b9e ("net/hns3: support flow director") Cc: sta...@dpdk.org Signed-off-by: Jie Hai --- drivers/net/hns3/hns3_ethdev_vf.c | 5 - drivers/net/hns3/hns3_fdir.c |

[PATCH 4/6] net/hns3: fix some error log

2023-10-31 Thread Jie Hai
This patch fixes some error log. Fixes: 62e3ccc2b94c ("net/hns3: support flow control") Cc: sta...@dpdk.org Signed-off-by: Jie Hai --- drivers/net/hns3/hns3_dcb.c | 2 +- drivers/net/hns3/hns3_flow.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/hns3/hns3_d

Re: [PATCH 0/3] Fix some reconfigure problem

2023-10-31 Thread Ferruh Yigit
On 10/28/2023 7:23 AM, Chaoyong He wrote: > This patch series fix some problems about reconfiguration logic. > > Chaoyong He (3): > net/nfp: fix the reconfigure logic in PF initialization > net/nfp: fix the reconfigure logic in VF initialization > net/nfp: fix the reconfigure logic of set ma

Re: [PATCH v3] eal: support lcore usage ratio

2023-10-31 Thread lihuisong (C)
lgtm, Acked-by: Huisong Li 在 2023/10/23 20:51, Chengwen Feng 写道: Current, the lcore usage only display two key fields: busy_cycles and total_cycles, which is inconvenient to obtain the usage ratio immediately. So adds lcore usage ratio field. Signed-off-by: Chengwen Feng Acked-by: Morten Brør

[PATCH v2] net/mlx5: add global API prefix to public constants

2023-10-31 Thread Thomas Monjalon
The file rte_pmd_mlx5.h is a public API, so its components must be prefixed with RTE_PMD_. Signed-off-by: Thomas Monjalon --- v2: rebase (more substitutions in code and doc) --- doc/guides/nics/mlx5.rst| 4 ++-- drivers/net/mlx5/mlx5.h | 6 +++--- drivers/net/mlx5/mlx5_defs.h

RE: [PATCH v2] test/security: fix buffer leaks in error path

2023-10-31 Thread Hemant Agrawal
Acked-by: Hemant Agrawal > -Original Message- > From: Akhil Goyal > Sent: Tuesday, October 31, 2023 12:15 PM > To: dev@dpdk.org > Cc: step...@networkplumber.org; Hemant Agrawal > ; vattun...@marvell.com; Akhil Goyal > ; sta...@dpdk.org > Subject: [PATCH v2] test/security: fix buffer leak

[PATCH 1/8] net/mlx5/hws: fix leak in FT management

2023-10-31 Thread Dariusz Sosnowski
From: Itamar Gozlan This commit fixes two leaks in flow table management. The first leak was when the default miss table of a flow table was not reset to the default action when setting a new first matcher. The second leak was caused by a missing free for an RTC in the case of disconnecting the l

[PATCH 4/8] net/mlx5: add sysfs check for Multiport E-Switch

2023-10-31 Thread Dariusz Sosnowski
This patch implements checking if Multiport E-Switch is enabled on a given PCI device, using sysfs Linux kernel interface. This facility will be used in follow up commits, which add support for such configuration to mlx5 PMD. MLNX_OFED mlx5_core kernel module versions which support Multiport E-Swi

[PATCH 5/8] net/mlx5: add checking Multiport E-Switch state

2023-10-31 Thread Dariusz Sosnowski
This patch implements checking if Multiport E-Switch is enabled on a given PCI device. mlx5_is_mpesw_enabled() implements this functionality and it will be used in a follow up commit. mlx5_is_mpesw_enabled() first checks if E-Switch state can be probed using Devlink device parameter. If it cannot

[PATCH 0/8] net/mlx5: add Multiport E-Switch support

2023-10-31 Thread Dariusz Sosnowski
This patchset adds support for probing ports of a Multiport E-Switch device to mlx5 PMD. Multiport E-Switch is a configuration of NVIDIA ConnectX/BlueField HCAs where all connected entities (i.e. physical ports, VFs and SFs) share the same switch domain. In this mode, applications are allowed to c

[PATCH 6/8] net/mlx5: support port probing of Multiport E-Switch device

2023-10-31 Thread Dariusz Sosnowski
This patch adds support for probing ports of a Multiport E-Switch device to mlx5 PMD. Multiport E-Switch is a configuration of NVIDIA ConnectX/BlueField HCAs where all connected entities (i.e. physical ports, VFs and SFs) share the same switch domain. In this mode, applications are allowed to crea

[PATCH 2/8] common/mlx5: fix controller index parsing

2023-10-31 Thread Dariusz Sosnowski
When probing the Linux kernel network interfaces attached to E-Switch, mlx5 PMD decides the representor type and represented entity using phys_port_name exposed by the mlx5 kernel driver in sysfs. mlx5 PMD first checks this name for multihost controller index. In multihost scenarios, phys_port_name

[PATCH 3/8] common/mlx5: add Netlink check for Multiport E-Switch

2023-10-31 Thread Dariusz Sosnowski
This patch implements checking if Multiport E-Switch is enabled on a given PCI device using Devlink Linux kernel interface. This facility will be used in follow up commits, which add support for such configuration to mlx5 PMD. If mlx5_core Linux kernel module supports Multiport E-Switch, then it c

[PATCH 8/8] net/mlx5: add support for vport match selection

2023-10-31 Thread Dariusz Sosnowski
From: Bing Zhao A new devarg "vport_match" is introduced for the application to use. If set to 1, then matching using REPRESENTED_PORT items on group 0 will be forced to use "misc.source_port", instead of matching on the vport metadata in HWS mode. It allows the user to match on the traffic from

[PATCH 7/8] net/mlx5: sort port spawn data with uplink ports first

2023-10-31 Thread Dariusz Sosnowski
This patch changes the behavior of the comparator used to sort mlx5_dev_spawn_data structures, to put them in a more user friendly order Before this patch, ports were sorted assuming there is only a single master port. It resulted in an order where master port first comes second, then representors

RE: [PATCH v2] net/mlx5: add global API prefix to public constants

2023-10-31 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Thomas Monjalon > Sent: Tuesday, October 31, 2023 3:38 PM > To: dev@dpdk.org > Cc: Rongwei Liu ; Matan Azrad ; > Slava Ovsiienko ; Ori Kam ; > Suanming Mou > Subject: [PATCH v2] net/mlx5: add global API prefix to public constants > > The file rte_pmd_mlx

Re: [PATCH 2/3] net/bonding: fix illegal memory accesses

2023-10-31 Thread Ferruh Yigit
On 10/10/2023 7:23 AM, Chaoyong He wrote: > From: Long Wu > > CI found that overrunning array of 32 2-byte elements at > element index 65535 (byte offset 131071) by dereferencing > pointer "members + agg_new_idx". > > Coverity issue: 403099 > Fixes: 6d72657ce379 ("net/bonding: add other aggregat

Re: [PATCH 1/3] app/test: fix control flow issue

2023-10-31 Thread Ferruh Yigit
On 10/10/2023 7:23 AM, Chaoyong He wrote: > From: Long Wu > > CI found that execution cannot reach the expression "-1" > inside this statement. > > Coverity issue: 403097 > Fixes: 5e41ab250dfa ("app/test: unit tests for bonding mode 4") > Cc: sta...@dpdk.org > > Signed-off-by: Long Wu > Review

Re: [PATCH 3/3] app/test: fix checking return value

2023-10-31 Thread Ferruh Yigit
On 10/10/2023 7:23 AM, Chaoyong He wrote: > From: Long Wu > > CI found the function without checking return value in this place. > > Coverity issue: 403101 > Fixes: 92073ef961ee ("bond: unit tests") > Cc: sta...@dpdk.org > > Signed-off-by: Long Wu > Reviewed-by: Chaoyong He > Reviewed-by: Pen

Re: [PATCH 0/3] Fix three coverity issues of bond PMD

2023-10-31 Thread Ferruh Yigit
On 10/10/2023 7:23 AM, Chaoyong He wrote: > This patch series fix three coverity issues about bond PMD and test > case, 403097, 403099 and 403101. > > Long Wu (3): > app/test: fix control flow issue > net/bonding: fix illegal memory accesses > app/test: fix checking return value > Except f

[PATCH] vdpa/mlx5: revert event thread to normal priority

2023-10-31 Thread Thomas Monjalon
When converting to rte_thread API, the SCHED_RR policy has been translated into RTE_THREAD_PRIORITY_REALTIME_CRITICAL. But SCHED_RR was not effective prior to this conversion because PTHREAD_EXPLICIT_SCHED attribute was missing initially. Using the default priority RTE_THREAD_PRIORITY_NORMAL shoul

RE: [PATCH v3] event/dlb2: fix disable PASID for kernel 6.2

2023-10-31 Thread Sevincer, Abdullah
> +This patch can be splited as two, > +1) Generic PCIe function to enable/disable PASID > +2) Call generic function to disable PASID in drivers/event/dlb2/. Also > mention which Linux kernel commit is introducing this issue in the git commit > log. Hi Jerrin, I think I need to provide more inf

Re: [PATCH 0/4] add telemetry commands for TM capabilities

2023-10-31 Thread Ferruh Yigit
On 10/18/2023 2:39 AM, Jie Hai wrote: > This patch adds telemetry commands for TM capabilities and make some > bufix for hns3 driver. > > Jie Hai (4): > net/hns3: fix a typo > ethdev: add telemetry command for TM capabilities > ethdev: add telemetry command for TM level capabilities > ethd

Re: [PATCH v3 0/3] introduce maximum Rx buffer size

2023-10-31 Thread Stephen Hemminger
On Tue, 31 Oct 2023 10:57:45 +0800 "lihuisong (C)" wrote: > >> User do decide their implement based on their cases in project. > >> May it be a point for this that user don't want to do memcpy for > >> multi segment packets and just use the first mbuf memory. > >> > >> Now that there is the "min_

Re: [PATCH v2] test/security: fix buffer leaks in error path

2023-10-31 Thread Stephen Hemminger
On Tue, 31 Oct 2023 12:14:46 +0530 Akhil Goyal wrote: > From: Akhil Goyal > To: > CC: , , > , Akhil Goyal , > > Subject: [PATCH v2] test/security: fix buffer leaks in error path > Date: Tue, 31 Oct 2023 12:14:46 +0530 > X-Mailer: git-send-email 2.25.1 > > In case of failure

Re: [PATCH 4/8] net/mlx5: add sysfs check for Multiport E-Switch

2023-10-31 Thread Stephen Hemminger
On Tue, 31 Oct 2023 16:27:29 +0200 Dariusz Sosnowski wrote: > + MKSTR(sysfs_if_path, "/sys/class/net/%s", ifname); > + if (mlx5_get_pci_addr(sysfs_if_path, &if_pci_addr)) > + continue; > + if (pci_addr->domain != if_pci_addr.domain || > +

Re: [PATCH] app/testpmd: support config all offload

2023-10-31 Thread Ferruh Yigit
On 10/24/2023 3:45 AM, lihuisong (C) wrote: ... > > 在 2023/10/23 10:29, Chengwen Feng 写道: >> Extend supports all offload configuration in following commands: >> 1. port config 0 rx_offload all on/off >> 2. port config 0 tx_offload all on/off >> 3. port 0 rxq 0 rx_offload all on/off >> 4. port 0

Re: [PATCH] linux/igb_uio: make module parameters visible in sysfs

2023-10-31 Thread Stephen Hemminger
On Sun, 21 Aug 2022 16:19:50 -0700 Shinae Woo wrote: > diff --git a/linux/igb_uio/igb_uio.c b/linux/igb_uio/igb_uio.c > index 33e0e02..c927ae6 100644 > --- a/linux/igb_uio/igb_uio.c > +++ b/linux/igb_uio/igb_uio.c > @@ -44,7 +44,7 @@ struct rte_uio_pci_dev { > }; > > static int wc_activate; >

Re: [PATCH v3] event/dlb2: fix disable PASID for kernel 6.2

2023-10-31 Thread Jerin Jacob
On Tue, Oct 31, 2023 at 8:43 PM Sevincer, Abdullah wrote: > > > > +This patch can be splited as two, > > +1) Generic PCIe function to enable/disable PASID > > +2) Call generic function to disable PASID in drivers/event/dlb2/. Also > > mention which Linux kernel commit is introducing this issue in

Re: [PATCH v3] event/dlb2: fix disable PASID for kernel 6.2

2023-10-31 Thread Bruce Richardson
On Tue, Oct 31, 2023 at 10:36:04PM +0530, Jerin Jacob wrote: > On Tue, Oct 31, 2023 at 8:43 PM Sevincer, Abdullah > wrote: > > > > > > > +This patch can be splited as two, > > > +1) Generic PCIe function to enable/disable PASID > > > +2) Call generic function to disable PASID in drivers/event/dlb2

Re: [PATCH] eal/interrupts: Allow UIO interrupts when using igb_uio

2023-10-31 Thread Stephen Hemminger
On Tue, 4 Jul 2023 20:19:05 +0200 Vladimir Ratnikov wrote: > On systems with I225 interfaces it works in interrupt mode(rx), so not only > LSE interrupts are supported. > I could try add rte_intr_cap_single functionality and recheck it twice(if > several interfaces works in rx_mode=interrupt) >

Re: [PATCH v3 1/5] failsafe: fix segfault on hotplug event

2023-10-31 Thread Stephen Hemminger
On Tue, 29 Nov 2022 09:48:29 -0500 Luc Pelletier wrote: > When the failsafe PMD encounters a hotplug event, it switches its rx/tx > functions to "safe" ones that validate the sub-device's rx/tx functions > before calling them. It switches the rx/tx functions by changing the > function pointers in

RE: [PATCH 4/8] net/mlx5: add sysfs check for Multiport E-Switch

2023-10-31 Thread Dariusz Sosnowski
Hi Stephen, Thank you for your comment. > -Original Message- > From: Stephen Hemminger > Sent: Tuesday, October 31, 2023 17:09 > To: Dariusz Sosnowski > Cc: Matan Azrad ; Slava Ovsiienko > ; Ori Kam ; Suanming Mou > ; dev@dpdk.org; Raslan Darawsheh > > Subject: Re: [PATCH 4/8] net/mlx5

RE: [PATCH] ipsec: use sym_session_opaque_data for RTE_SECURITY_TYPE_CPU_CRYPTO

2023-10-31 Thread Konstantin Ananyev
Hi Garry, > Hi Konstantin, Akhil, > > The patch is based on an issue I encountered when using the CPU_CRYPTO > support - I was having problems where the ipsec session lookup was > failing / was inconsistent. > > Examining the code in DPDK and looking for the use of > RTE_SECURITY_ACTION_TYPE_CP

RE: [EXT] Re: [PATCH v2] test/security: fix buffer leaks in error path

2023-10-31 Thread Akhil Goyal
> > Subject: [PATCH v2] test/security: fix buffer leaks in error path > > Date: Tue, 31 Oct 2023 12:14:46 +0530 > > X-Mailer: git-send-email 2.25.1 > > > > In case of failure of a test in macsec autotest, > > the buffers were not getting cleaned. > > Added appropriate code to clean the buffers. >

[PATCH v3 0/3] add pointer compression API

2023-10-31 Thread Paul Szczepanek
This patchset is proposing adding a new EAL header with utility functions that allow compression of arrays of pointers. When passing caches full of pointers between threads, memory containing the pointers is copied multiple times which is especially costly between cores. A compression method will

[PATCH v3 3/3] docs: add pointer compression to the EAL guide

2023-10-31 Thread Paul Szczepanek
Documentation added in the EAL guide for the new utility functions for pointer compression showing example code and potential usecases Signed-off-by: Paul Szczepanek Reviewed-by: Honnappa Nagarahalli --- .../prog_guide/env_abstraction_layer.rst | 142 ++ 1 file changed, 142

[PATCH v3 2/3] test: add pointer compress tests to ring perf test

2023-10-31 Thread Paul Szczepanek
Add a test that runs a zero copy burst enqueue and dequeue on a ring of raw pointers and compressed pointers at different burst sizes to showcase performance benefits of newly added pointer compression APIs. Refactored threading code to pass more parameters to threads to reuse existing code. Added

[PATCH v3 1/3] eal: add pointer compression functions

2023-10-31 Thread Paul Szczepanek
Add a new utility header for compressing pointers. The provided functions can store pointers in 32-bit offsets. The compression takes advantage of the fact that pointers are usually located in a limited memory region (like a mempool). We can compress them by converting them to offsets from a base

Re: [PATCH v3] usertools: add check for IOMMU support in dpdk-devbind

2023-10-31 Thread Stephen Hemminger
On Mon, 21 Mar 2022 17:27:27 +0500 Fidaullah Noonari wrote: > + > +def check_noiommu_mode(): > +"""checks and enables the noiommu mode for vfio drivers""" > +global noiommu_flag > +filename = "/sys/module/vfio/parameters/enable_unsafe_noiommu_mode" > + > +try: > +with open

Re: [PATCH v2 0/2] make dpdk buildable with latest msvc

2023-10-31 Thread David Marchand
On Tue, Oct 17, 2023 at 3:49 PM Tyler Retzlaff wrote: > > This series makes some minor temporary modifications to the MSVC build > to allow DPDK to be buildable. The changes are only temporary to allow > Windows/MSVC CI pipeline to be established. > > Warnings will be made clean in a future series

Re: [PATCH v3] event/dlb2: fix disable PASID for kernel 6.2

2023-10-31 Thread Jerin Jacob
On Tue, Oct 31, 2023 at 10:45 PM Bruce Richardson wrote: > > On Tue, Oct 31, 2023 at 10:36:04PM +0530, Jerin Jacob wrote: > > On Tue, Oct 31, 2023 at 8:43 PM Sevincer, Abdullah > > wrote: > > > > > > > > > > +This patch can be splited as two, > > > > +1) Generic PCIe function to enable/disable PA

[PATCH v2] examples/l2fwd-macsec: add MACsec forwarding application

2023-10-31 Thread Akhil Goyal
Added a new application based on l2fwd to demonstrate inline protocol offload MACsec performance using rte_security APIs. Example command: ./dpdk-l2fwd-macsec -a 0002:04:00.0 -a 0002:05:00.0 -c 0x6 -- -p 0x3 \ --mcs-tx-portmask 0x1 --mcs-rx-portmask 0x2 --mcs-port-config \ '(0,02:03:04:05:06:07,01:

Re: [PATCH] gro : fix pkt length when extra bytes are padded to ethernet frame

2023-10-31 Thread Stephen Hemminger
On Mon, 17 Oct 2022 18:57:44 +0530 kumaraparameshwaran rathinavel wrote: > From: kumaraparameshwaran rathinavel > To: "Hu, Jiayu" > Cc: Jun Qiu , "dev@dpdk.org" , David > Marchand > Subject: Re: [PATCH] gro : fix pkt length when extra bytes are padded to > ethernet frame > Date: Mon, 17 O

Re: [PATCH] TCP data length is incorrectly calculated in the gro_tcp4_reassemble function.

2023-10-31 Thread Stephen Hemminger
On Wed, 28 Sep 2022 14:10:52 + "jiangheng (G)" wrote: > Hello: > In gro_tcp4_reassemble function, tcp data len is calculated: > tcp_dl = pkt->pkt_len - hdr_len; > https://github.com/DPDK/dpdk/blob/v22.07/lib/gro/gro_tcp4.c#L232 > > if packets < 60 bytes, pkt_len will contain padding bytes, t

Re: [PATCH] sched:In rte_sched_subport_config() API, subport_profile_id is not set correctly.

2023-10-31 Thread Stephen Hemminger
On Thu, 18 Aug 2022 05:41:51 + Megha Ajmera wrote: > --- > lib/sched/rte_sched.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/lib/sched/rte_sched.c b/lib/sched/rte_sched.c > index 599c7e9536..09f855a04b 100644 > --- a/lib/sched/rte_sched.c > +++ b/lib/sched/rte_sched.c > @@ -12

Re: [v2 1/2] doc: add policy for adding vendor PMD specific examples

2023-10-31 Thread Stephen Hemminger
On Thu, 6 Jul 2023 10:30:14 +0530 Jerin Jacob wrote: > From: Jerin Jacob > To: Hemant Agrawal > Cc: tho...@monjalon.net, dev@dpdk.org, step...@networkplumber.org > Subject: Re: [v2 1/2] doc: add policy for adding vendor PMD specific examples > Date: Thu, 6 Jul 2023 10:30:14 +0530 > > On Wed, J

Re: [PATCH v2 3/3] doc: add a relax rx mode requirement option

2023-10-31 Thread Stephen Hemminger
On Fri, 13 Oct 2023 04:27:22 + Trevor Tao wrote: > From: Trevor Tao > To: dev@dpdk.org > Cc: Trevor Tao > Subject: [PATCH v2 3/3] doc: add a relax rx mode requirement option > Date: Fri, 13 Oct 2023 04:27:22 + > X-Mailer: git-send-email 2.34.1 > > Add an option to enable the RX mode re

Re: [PATCH v3] event/dlb2: fix disable PASID for kernel 6.2

2023-10-31 Thread Bruce Richardson
On Wed, Nov 01, 2023 at 12:12:02AM +0530, Jerin Jacob wrote: > On Tue, Oct 31, 2023 at 10:45 PM Bruce Richardson > wrote: > > > > On Tue, Oct 31, 2023 at 10:36:04PM +0530, Jerin Jacob wrote: > > > On Tue, Oct 31, 2023 at 8:43 PM Sevincer, Abdullah > > > wrote: > > > > > > > > > > > > > +This patc

Re: [PATCH v2 00/44] fix segment fault when parse args

2023-10-31 Thread Stephen Hemminger
On Mon, 17 Apr 2023 17:37:46 +0100 Ferruh Yigit wrote: > From: Ferruh Yigit > To: fengchengwen , tho...@monjalon.net > Cc: dev@dpdk.org > Subject: Re: [PATCH v2 00/44] fix segment fault when parse args > Date: Mon, 17 Apr 2023 17:37:46 +0100 > User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64

[RFC] kvargs: don't pass parse handler a NULL pointer

2023-10-31 Thread Stephen Hemminger
There is class of problems in current DPDK where rte_kvargs is used a key/value pair is passed without an associated value. Currently, this can cause a NULL dereference in the rte_kvargs_process handler. Reported-by: Chengwen Feng Signed-off-by: Stephen Hemminger --- lib/kvargs/rte_kvargs.c | 3

[PATCH v2] crypto/qat: add sm2 ecdsa

2023-10-31 Thread Arkadiusz Kusztal
Added SM2 ECDSA feature to the Intel QuickAssist Technology symmetric crypto PMD. Signed-off-by: Arkadiusz Kusztal --- v2: - fixed build issues doc/guides/cryptodevs/features/qat.ini| 1 + doc/guides/cryptodevs/qat.rst | 1 + doc/guides/rel_notes/release_23_11.rst

Re: [dpdk-dev] [PATCH 2/2] net/bonding: ensure device is started for dedicated queues setup

2023-10-31 Thread Stephen Hemminger
On Tue, 5 Oct 2021 19:19:39 +0200 Martin Havlik wrote: > The flow rule governing dedicated queues is now created > when the slave allows it. That is before or after the start > of the slave device, as the PMD is able to. > > Signed-off-by: Martin Havlik This patch no longer applies because of

  1   2   >