[PATCH] net/virtio: fixed missing next flag when sending packets in packed mode

2023-10-17 Thread Fengjiang Liu
From: "liufengjiang.0426" When the packets is sent in packed mode, and the packets data and virtio-header are divided into two desc, set the next flag of virtio-header desc Bugzilla ID: 1295 Fixes: 892dc798fa9c ("net/virtio: implement Tx path for packed queues") Signed-off-by: Fengjiang Liu --

Re: [PATCH v4 0/7] document and simplify use of cmdline

2023-10-17 Thread David Marchand
Hi Bruce, On Mon, Oct 16, 2023 at 4:06 PM Bruce Richardson wrote: > > The DPDK commandline library is widely used by apps and examples within > DPDK, but it is not documented in our programmers guide and it requires > a lot of boilerplate code definitions in order to used. We can improve > this s

[PATCH] net/virtio: fixed missing next flag when sending packets in packed mode

2023-10-17 Thread Fengjiang Liu
From: "liufengjiang.0426" When the packets is sent in packed mode, and the packets data and virtio-header are divided into two desc, set the next flag of virtio-header desc Bugzilla ID: 1295 Fixes: 892dc798fa9c ("net/virtio: implement Tx path for packed queues") Signed-off-by: Fengjiang Liu --

[PATCH v2] ci: test stdatomic API

2023-10-17 Thread David Marchand
Add some compilation tests with C11 atomics enabled. The headers check can't be enabled (as gcc and clang don't provide stdatomic before C++23). Signed-off-by: David Marchand Reviewed-by: Aaron Conole --- Changelog from v1: - following Thomas offlist review, tweaked coverage in test-meson-buil

[PATCH] net/virtio: fixed missing next flag when sending packets in packed mode

2023-10-17 Thread Fengjiang Liu
When the packets is sent in packed mode, and the packets data and virtio-header are divided into two desc, set the next flag of virtio-header desc Bugzilla ID: 1295 Fixes: 892dc798fa9c ("net/virtio: implement Tx path for packed queues") Signed-off-by: Fengjiang Liu --- drivers/net/virtio/virtqu

[PATCH v2 00/16] net/mlx5: support indirect actions list

2023-10-17 Thread Gregory Etelson
Erez Shitrit (1): net/mlx5/hws: allow destination into default miss FT Gregory Etelson (10): net/mlx5: reformat HWS code net/mlx5: support HWS mirror action net/mlx5: fix mirror action validation net/mlx5: fix in shared counter and age template action create net/mlx5: fix modify field

Re: [PATCH] net/virtio: fixed missing next flag when sending packets in packed mode

2023-10-17 Thread Maxime Coquelin
Hi, On 10/17/23 09:26, Fengjiang Liu wrote: When the packets is sent in packed mode, and the packets data and virtio-header are divided into two desc, set the next flag of virtio-header desc Bugzilla ID: 1295 Fixes: 892dc798fa9c ("net/virtio: implement Tx path for packed queues") Signed-off-by

RE: [PATCH v2 01/16] net/mlx5/hws: add support for reformat DevX object

2023-10-17 Thread Suanming Mou
Hi, > -Original Message- > From: Gregory Etelson > Sent: Tuesday, October 17, 2023 2:42 AM > To: dev@dpdk.org > Cc: Gregory Etelson ; Maayan Kashani > ; Raslan Darawsheh ; Hamdan > Igbaria ; Matan Azrad ; Slava > Ovsiienko ; Ori Kam ; Suanming > Mou > Subject: [PATCH v2 01/16] net/mlx5/h

[PATCH v3 00/16] net/mlx5: support indirect actions list

2023-10-17 Thread Gregory Etelson
Add MLX5 PMD support for indirect actions list. Erez Shitrit (1): net/mlx5/hws: allow destination into default miss FT Gregory Etelson (10): net/mlx5: reformat HWS code net/mlx5: support HWS mirror action net/mlx5: fix mirror action validation net/mlx5: fix in shared counter and age tem

[PATCH v3 01/16] net/mlx5/hws: add support for reformat DevX object

2023-10-17 Thread Gregory Etelson
From: Hamdan Igbaria Add support for creation of packet reformat object, via the ALLOC_PACKET_REFORMAT_CONTEXT command. Signed-off-by: Hamdan Igbaria Acked-by: Suanming Mou --- drivers/common/mlx5/mlx5_prm.h | 39 + drivers/net/mlx5/hws/mlx5dr_cmd.c | 60 +

[PATCH v3 02/16] net/mlx5/hws: support creating of dynamic forward table and FTE

2023-10-17 Thread Gregory Etelson
From: Hamdan Igbaria Add the ability to create forward table and FTE. Signed-off-by: Hamdan Igbaria Acked-by: Suanming Mou --- drivers/common/mlx5/mlx5_prm.h| 4 drivers/net/mlx5/hws/mlx5dr_cmd.c | 13 + drivers/net/mlx5/hws/mlx5dr_cmd.h | 19 +++ 3 files

[PATCH v3 03/16] net/mlx5/hws: add mlx5dr DevX object struct to mlx5dr action

2023-10-17 Thread Gregory Etelson
From: Hamdan Igbaria Add mlx5dr_devx_obj struct to mlx5dr_action, so we could hold the FT obj in dest table action. Signed-off-by: Hamdan Igbaria Acked-by: Suanming Mou --- drivers/net/mlx5/hws/mlx5dr_action.c | 4 drivers/net/mlx5/hws/mlx5dr_action.h | 3 +++ drivers/net/mlx5/hws/mlx5dr

[PATCH v3 04/16] net/mlx5/hws: add support for mirroring

2023-10-17 Thread Gregory Etelson
From: Shun Hao This patch supports mirroring by adding an dest_array action. The action accecpts a list containing multiple destination actions, and can duplicate packet and forward to each destination in the list. Signed-off-by: Shun Hao Acked-by: Alex Vesker Acked-by: Suanming Mou --- driv

[PATCH v3 05/16] net/mlx5/hws: allow destination into default miss FT

2023-10-17 Thread Gregory Etelson
From: Erez Shitrit In FDB it will direct the packet into the hypervisor vport. That allows the user to mirror packets into the default-miss vport. Signed-off-by: Erez Shitrit Acked-by: Suanming Mou --- drivers/net/mlx5/hws/mlx5dr_action.c | 11 +++ 1 file changed, 11 insertions(+) di

[PATCH v3 07/16] net/mlx5: reformat HWS code

2023-10-17 Thread Gregory Etelson
Replace if() with switch(). Signed-off-by: Gregory Etelson Acked-by: Suanming Mou --- drivers/net/mlx5/mlx5_flow_hw.c | 70 ++--- 1 file changed, 39 insertions(+), 31 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow_hw.c b/drivers/net/mlx5/mlx5_flow_hw.c index 6

[PATCH v3 06/16] net/mlx5/hws: support reformat for hws mirror

2023-10-17 Thread Gregory Etelson
From: Haifei Luo In dest_array action, an optional reformat action can be applied to each destination. This patch supports this by using the extended destination entry. Signed-off-by: Haifei Luo Signed-off-by: Shun Hao Acked-by: Suanming Mou --- drivers/common/mlx5/mlx5_prm.h | 15

[PATCH v3 08/16] net/mlx5: support HWS mirror action

2023-10-17 Thread Gregory Etelson
HWS mirror clones original packet to one or two destinations and proceeds with the original packet path. The mirror has no dedicated RTE flow action type. Mirror object is referenced by INDIRECT_LIST action. INDIRECT_LIST for a mirror built from actions list: SAMPLE [/ SAMPLE] / / END Mirro

[PATCH v3 09/16] net/mlx5: fix mirror action validation

2023-10-17 Thread Gregory Etelson
HWS mirror flow action validation rejected flows in NIC domain, if PMD FDB mode was active. The patch allows NIC mirror action in FDB mode. Fixes: 0284c9b82ee8 ("net/mlx5: support HWS mirror action") Signed-off-by: Gregory Etelson Acked-by: Suanming Mou --- drivers/net/mlx5/mlx5_flow_hw.c | 20

[PATCH v3 10/16] net/mlx5: fix in shared counter and age template action create

2023-10-17 Thread Gregory Etelson
Count and age actions in HWS template are translated into the same DR5 action. PMD maintains dedicated variable - `cnt_off`, that points action location in DR5 array. Currnet PMD did not initialize the `cnt_off` variable during shared counter / age actions initialization. Fixes: feb1f2fe2b76 ("ne

[PATCH v3 12/16] net/mlx5: refactor HWS code

2023-10-17 Thread Gregory Etelson
1. In `rte_flow_actions_template`, rename `actions_off` into `dr_off`. 2. Remove duplicated code in template table creation. Signed-off-by: Gregory Etelson Acked-by: Suanming Mou --- drivers/net/mlx5/mlx5_flow.h| 2 +- drivers/net/mlx5/mlx5_flow_hw.c | 117 ++--

[PATCH v3 11/16] net/mlx5: fix modify field expansion for raw DECAP / ENCAP

2023-10-17 Thread Gregory Etelson
Flow actions in HWS actions template must be arranged according to pre-defined order. MLX5 PMD handles RAW_DECAP / RAW_ENCAP actions sequence as a single RAW ENCAP or DECAP flow action. When the PMD scanned flow actions to locate position where MODIFY_FIELD action could be inserted it processed t

[PATCH v3 13/16] net/mlx5: fix RTE action location tracking in a template

2023-10-17 Thread Gregory Etelson
PMD can implicitly add flow actions to application actions template. If PMD added actions to a template is must track location of the original application actions in modified template. The patch adds tracking ability for the orignal acton in a template. Fixes: ddb68e4 ("net/mlx5: add extended met

[PATCH v3 14/16] net/mlx5: fix mirror redirect action

2023-10-17 Thread Gregory Etelson
PMD used a buffer located on expired stack to store mirror reformat data. The patch moves reformat buffer to the same context as the mirror action creation. Fixes: 0284c9b82ee8 ("net/mlx5: support HWS mirror action") Signed-off-by: Gregory Etelson Acked-by: Suanming Mou --- drivers/net/mlx5/ml

[PATCH v3 15/16] net/mlx5: support indirect list METER_MARK action

2023-10-17 Thread Gregory Etelson
Signed-off-by: Gregory Etelson Acked-by: Suanming Mou --- drivers/net/mlx5/mlx5_flow.c| 69 +- drivers/net/mlx5/mlx5_flow.h| 67 - drivers/net/mlx5/mlx5_flow_hw.c | 427 +++- 3 files changed, 482 insertions(+), 81 deletions(-) diff --git a/drivers/n

[PATCH v3 16/16] net/mlx5: fix METER_MARK indirection list callback

2023-10-17 Thread Gregory Etelson
Indirect action list METER_MARK handle and configuration parameters can be independently masked or non-masked in actions template. Non-masked configuration state is saved in the `mlx5_action_construct_data::shared_meter` object. The patch moves indirect action list callback from `mlx5_action_const

Re: [PATCH v2 1/2] power: refactor uncore power management interfaces

2023-10-17 Thread David Marchand
On Wed, Aug 16, 2023 at 12:10 PM Sivaprasad Tummala wrote: > > currently the uncore power management implementation is vendor specific. > Added new vendor agnostic uncore power interface similar to rte_power > and rename specific implementations ("rte_power_intel_uncore") to > "power_intel_uncore"

[PATCH] ethdev: fix flow action async query coverity

2023-10-17 Thread Suanming Mou
This commit adds the ops chcek to fix the coverity issue. Coverity issue: 403258 Fixes: c9dc03840873 ("ethdev: add indirect action async query") Signed-off-by: Suanming Mou --- lib/ethdev/rte_flow.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/ethdev/rte_flow.c b/lib/ethdev/rte_flo

Re: [PATCH v3 1/8] ethdev: add member notification for bonding port

2023-10-17 Thread lihuisong (C)
在 2023/10/9 11:11, Long Wu 写道: Hi Chaoyong, some comments as below. 在 2023/10/8 9:50, Chaoyong He 写道: From: Long Wu Bonding PMD does not let member ports know the bonding port's information, like how many member ports the bonding port has, what mode the bonding port is in and so on. Add

Re: [PATCH v4 0/7] document and simplify use of cmdline

2023-10-17 Thread Bruce Richardson
On Tue, Oct 17, 2023 at 09:10:51AM +0200, David Marchand wrote: > Hi Bruce, > > On Mon, Oct 16, 2023 at 4:06 PM Bruce Richardson > wrote: > > > > The DPDK commandline library is widely used by apps and examples within > > DPDK, but it is not documented in our programmers guide and it requires > >

Re: [PATCH v3 7/8] net/bonding: support checking valid bonding port ID

2023-10-17 Thread lihuisong (C)
Hi Chaoyong, It is better to separate patch 3/8 and patch 6/8 from this series. 在 2023/10/8 9:50, Chaoyong He 写道: From: Long Wu Add API to support checking if the port id is a bonding port id. Signed-off-by: Long Wu Reviewed-by: James Hershaw Reviewed-by: Chaoyong He --- drivers/net/bon

Re: [PATCH v4 0/2] offload support to auto free dma buffer

2023-10-17 Thread Thomas Monjalon
09/10/2023 14:02, Amit Prakash Shukla: > This series adds offload support to auto free buffer in dma library > and adds a test support in dmadev_autotest to validate the functionality. > > Amit Prakash Shukla (2): > dmadev: offload to auto free DMA buffer > test/dma: auto free offload test to

Re: [PATCH v1] dma/cnxk: offload source buffer free

2023-10-17 Thread Thomas Monjalon
07/09/2023 10:24, Amit Prakash Shukla: > Added support in driver, to offload source buffer free to hardware > on completion of DMA transfer. > > Signed-off-by: Amit Prakash Shukla > --- > Depends-on: series-29427 ("use mempool for DMA chunk pool") > Depends-on: series-29442 ("offload support to f

[PATCH] ci: test manuals generation in GHA

2023-10-17 Thread David Marchand
Add missing package so manuals are generated as part of the docs check. Signed-off-by: David Marchand --- .github/workflows/build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 7a2ac0ceee..e6c6267eb4 100644

Re: [PATCH] dma/skeleton: fix pthread set affinity

2023-10-17 Thread Thomas Monjalon
15/08/2023 14:21, David Marchand: > On Mon, Aug 14, 2023 at 6:24 PM Tyler Retzlaff > wrote: > > > > On Sat, Aug 12, 2023 at 07:27:38AM +0530, Vipin Varghese wrote: > > > In skeleton dma driver, the user can pin the dma thread to desired > > > cpu core. The previous commit changed the api from set-

Re: [PATCH v2] ci: test stdatomic API

2023-10-17 Thread David Marchand
On Tue, Oct 17, 2023 at 9:15 AM David Marchand wrote: > > Add some compilation tests with C11 atomics enabled. > The headers check can't be enabled (as gcc and clang don't provide > stdatomic before C++23). > > Signed-off-by: David Marchand > Reviewed-by: Aaron Conole Applied, thanks. -- Dav

RE: [PATCH v3 7/8] net/bonding: support checking valid bonding port ID

2023-10-17 Thread Chaoyong He
> Hi Chaoyong, > > It is better to separate patch 3/8 and patch 6/8 from this series. The patch 3/8 is okay to separate, there is no problem. But if patch 6/8 be a separate patch, this patch series will need depend on it. I'm not sure if that is okay? > > 在 2023/10/8 9:50, Chaoyong He 写道: > > F

Re: [PATCH] dma/idxd: add reset in the init routine

2023-10-17 Thread Thomas Monjalon
14/08/2023 17:37, Bruce Richardson: > On Fri, Aug 11, 2023 at 10:10:54AM +0800, Frank Du wrote: > > Fix for windows, no one reset the dev to a clear status. In Linux, > > kernel driver will reset during the prob. > > > > Signed-off-by: Frank Du > > --- > > drivers/dma/idxd/idxd_pci.c | 8 +++

Re: [PATCH] config/x86: config support for AMD EPYC processors

2023-10-17 Thread Kevin Traynor
On 16/10/2023 06:20, Tummala, Sivaprasad wrote: [AMD Official Use Only - General] Hi DPDK Techboard, Request to add this topic for discussion in the next techboard meeting. Hi Sivaprasad, Are you or a representative (Ferruh?) able to attend the techboard meeting (3pm UTC Wednesday) to disc

[PATCH] net/cpfl: remove devargs from adapter

2023-10-17 Thread beilei . xing
From: Beilei Xing Member devargs can be removed from struct cpfl_adapter_ext since it's not a global parameter, it should be local. Signed-off-by: Beilei Xing --- drivers/net/cpfl/cpfl_ethdev.c | 43 +++-- drivers/net/cpfl/cpfl_ethdev.h | 1 - drivers/net/cpf

Re: [PATCH v1] dma/cnxk: offload source buffer free

2023-10-17 Thread Jerin Jacob
On Thu, Sep 7, 2023 at 7:50 PM Amit Prakash Shukla wrote: > > Added support in driver, to offload source buffer free to hardware > on completion of DMA transfer. > > Signed-off-by: Amit Prakash Shukla > --- > Depends-on: series-29427 ("use mempool for DMA chunk pool") > Depends-on: series-29442 (

RE: [PATCH] config/x86: config support for AMD EPYC processors

2023-10-17 Thread Morten Brørup
> From: Kevin Traynor [mailto:ktray...@redhat.com] > Sent: Tuesday, 17 October 2023 11.45 > > On 16/10/2023 06:20, Tummala, Sivaprasad wrote: > > [AMD Official Use Only - General] > > > > Hi DPDK Techboard, > > > > Request to add this topic for discussion in the next techboard > meeting. > > > >

Re: [PATCH] config/x86: config support for AMD EPYC processors

2023-10-17 Thread Ferruh Yigit
On 10/17/2023 10:45 AM, Kevin Traynor wrote: > On 16/10/2023 06:20, Tummala, Sivaprasad wrote: >> [AMD Official Use Only - General] >> >> Hi DPDK Techboard, >> >> Request to add this topic for discussion in the next techboard meeting. >> > > Hi Sivaprasad, > > Are you or a representative (Ferruh?

Re: [PATCH v3 1/1] node: remove MAX macro from all nodes

2023-10-17 Thread Thomas Monjalon
28/09/2023 11:14, Rakesh Kudurumalla: > Removed MAX macro from all graph nodes to extend > edges to nodes at ease > > Signed-off-by: Rakesh Kudurumalla > Acked-by: Nithin Dabilpuram Applied, thanks.

Re: [PATCH v4] node: add IPv4 reassembly node

2023-10-17 Thread Thomas Monjalon
08/09/2023 07:37, Nithin Dabilpuram: > On Thu, Jul 27, 2023 at 8:07 PM wrote: > > > > From: Pavan Nikhilesh > > > > Add IPv4 reassembly node. > > > > Signed-off-by: Pavan Nikhilesh > Acked-by: Nithin Dabilpuram [...] > > --- a/lib/node/meson.build > > +++ b/lib/node/meson.build > > @@ -13,6 +13

[PATCH v1] common/cnxk: fix flow add in age flow list

2023-10-17 Thread Ankur Dwivedi
While adding flow in npc_flow_list, the flow can be added before the current flow iterator. The function returns after adding this flow. This prevents flow to be added in age flow list correctly. This patch moves the addition of age flow list before npc_flow_list add to prevent the error. Also the

[PATCH] devtools: extend check on compiler builtin atomics

2023-10-17 Thread David Marchand
rte_memory_order_* should be used when calling the new stdatomic API. Add a check on __ATOMIC_* tokens. Signed-off-by: David Marchand --- devtools/checkpatches.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh index 263

Re: [PATCH] devtools: extend check on compiler builtin atomics

2023-10-17 Thread Tyler Retzlaff
On Tue, Oct 17, 2023 at 01:31:25PM +0200, David Marchand wrote: > rte_memory_order_* should be used when calling the new stdatomic API. > Add a check on __ATOMIC_* tokens. > > Signed-off-by: David Marchand > --- Acked-by: Tyler Retzlaff > devtools/checkpatches.sh | 4 ++-- > 1 file changed, 2

Re: [PATCH v3 7/8] net/bonding: support checking valid bonding port ID

2023-10-17 Thread lihuisong (C)
在 2023/10/17 17:25, Chaoyong He 写道: Hi Chaoyong, It is better to separate patch 3/8 and patch 6/8 from this series. The patch 3/8 is okay to separate, there is no problem. But if patch 6/8 be a separate patch, this patch series will need depend on it. I'm not sure if that is okay? I doesn't

Re: [PATCH v6 2/2] node: add UDP v4 support

2023-10-17 Thread Thomas Monjalon
29/09/2023 12:58, Nithin Dabilpuram: > On Thu, Sep 28, 2023 at 4:06 PM Rakesh Kudurumalla > wrote: > > > > IPv4 UDP packets are given to application > > with specified UDP destination port given > > by user. > > > > Signed-off-by: Rakesh Kudurumalla > Acked-by: Nithin Dabilpuram Series applied,

Re: [PATCH v1] test/graph: fix unused return value

2023-10-17 Thread Thomas Monjalon
21/07/2023 14:50, Jerin Jacob: > On Fri, Jul 21, 2023 at 8:12 AM Zhirun Yan wrote: > > > > Return value stored in "ret" but it may be overwritten before use. > > Add goto to return when meet an error. Issue reported by coverity scan. > > > > Coverity issue: 395532 > > Fixes: 15f483feec65 ("graph:

Re: [PATCH v2 1/1] usertools/rss: add CNXK RSS key

2023-10-17 Thread Thomas Monjalon
Adding the script author, Robin. 09/10/2023 18:36, sk...@marvell.com: > From: Sunil Kumar Kori > > This patch adds RSS key for CNXK platforms. CNXK platform uses > 48 bytes long key for hash calculations. > > For the same patch also updates help mesaages to provide range > information for suppo

[PATCH v5 0/9] document and simplify use of cmdline

2023-10-17 Thread Bruce Richardson
The DPDK commandline library is widely used by apps and examples within DPDK, but it is not documented in our programmers guide and it requires a lot of boilerplate code definitions in order to used. We can improve this situation by creating a simple python script to automatically generate the boil

[PATCH v5 1/9] doc/prog_guide: new chapter on cmdline library

2023-10-17 Thread Bruce Richardson
The cmdline library was not documented in our programmers guide, so add a new chapter on it. This chapter covers step-by-step how to use the library, rather than focusing on the library internals. This complements the existing cmdline example app document, providing more details on the process of u

[PATCH v5 2/9] buildtools: script to generate cmdline boilerplate

2023-10-17 Thread Bruce Richardson
Provide a "dpdk-cmdline-gen.py" script for application developers to quickly generate the boilerplate code necessary for using the cmdline library. Example of use: The script takes an input file with a list of commands the user wants in the app, where the parameter variables are tagged with the ty

[PATCH v5 3/9] ci: allow use of DPDK tools when building examples

2023-10-17 Thread Bruce Richardson
To allow use of the DPDK python scripts (installed in $(prefix)/bin) from within the makefiles of our examples, we need to export the PATH variable with the location of our installed scripts from within our CI scripts. This matches what is already done for other paths e.g. the PKG_CONFIG_PATH varia

[PATCH v5 4/9] examples/simple_mp: auto-generate cmdline boilerplate

2023-10-17 Thread Bruce Richardson
Use the dpdk-cmdline-gen script to autogenerate all the boilerplate structs and defines for the commandline part of the app. Signed-off-by: Bruce Richardson --- examples/multi_process/simple_mp/Makefile | 12 +- examples/multi_process/simple_mp/meson.build | 9 ++ .../multi_process/simpl

[PATCH v5 5/9] examples/hotplug_mp: auto-generate cmdline boilerplate

2023-10-17 Thread Bruce Richardson
Use the dpdk-cmdline-gen script to autogenerate all the boilerplate structs and defines for the commandline part of the app. Signed-off-by: Bruce Richardson --- examples/multi_process/hotplug_mp/Makefile| 12 +- examples/multi_process/hotplug_mp/commands.c | 147 ++ example

[PATCH v5 6/9] examples/bond: auto-generate cmdline boilerplate

2023-10-17 Thread Bruce Richardson
Use the dpdk-cmdline-gen script to autogenerate all the boilerplate structs and defines for the commandline part of the app. Signed-off-by: Bruce Richardson --- Note: the original help text on some of the commands in this example were not useful "this command do not handle any arguments". Ther

[PATCH v5 7/9] examples/vdpa: auto-generate cmdline boilerplate

2023-10-17 Thread Bruce Richardson
Use the dpdk-cmdline-gen script to autogenerate all the boilerplate structs and defines for the commandline part of the app. Signed-off-by: Bruce Richardson --- examples/vdpa/Makefile | 12 ++-- examples/vdpa/commands.list | 8 +++ examples/vdpa/main.c| 131 ++

[PATCH v5 8/9] buildtools/dpdk-cmdline-gen: support option strings

2023-10-17 Thread Bruce Richardson
Add support to the commandline generator for option strings, where there are only a limited number of acceptable values to be passed as a parameter. Signed-off-by: Bruce Richardson --- buildtools/dpdk-cmdline-gen.py| 7 +++ doc/guides/prog_guide/cmdline.rst | 6 +- 2 files changed, 1

[PATCH v5 9/9] examples/ntb: auto-generate cmdline boilerplate

2023-10-17 Thread Bruce Richardson
Use the dpdk-cmdline-gen script to autogenerate all the boilerplate structs and defines for the commandline part of the app. Signed-off-by: Bruce Richardson --- examples/ntb/Makefile | 12 ++- examples/ntb/commands.list | 11 ++ examples/ntb/meson.build | 7 ++ examples/ntb/ntb_fwd.c

Re: [PATCH v4 0/7] document and simplify use of cmdline

2023-10-17 Thread Bruce Richardson
On Tue, Oct 17, 2023 at 09:29:34AM +0100, Bruce Richardson wrote: > On Tue, Oct 17, 2023 at 09:10:51AM +0200, David Marchand wrote: > > > > - Multi choice fixed strings is something that is often used in > > testpmd, like here, in the help command. Here is my quick > > hack: > > > > diff --g

Re: [PATCH v2 1/1] usertools/rss: add CNXK RSS key

2023-10-17 Thread Robin Jarry
, Oct 09, 2023 at 18:36: From: Sunil Kumar Kori This patch adds RSS key for CNXK platforms. CNXK platform uses 48 bytes long key for hash calculations. For the same patch also updates help mesaages to provide range information for supporting NICs/platforms. Also CNXK uses reta size as 64 so t

RE: [PATCH] ethdev: fix flow action async query coverity

2023-10-17 Thread Ori Kam
Hi Suanming, > -Original Message- > From: Suanming Mou > Sent: Tuesday, October 17, 2023 11:23 AM > > This commit adds the ops chcek to fix the coverity issue. > > Coverity issue: 403258 > Fixes: c9dc03840873 ("ethdev: add indirect action async query") > > Signed-off-by: Suanming Mou

Re: [PATCH v4 3/7] ci: allow use of DPDK tools when building examples

2023-10-17 Thread Aaron Conole
Bruce Richardson writes: > To allow use of the DPDK python scripts (installed in $(prefix)/bin) > from within the makefiles of our examples, we need to export the PATH > variable with the location of our installed scripts from within our CI > scripts. This matches what is already done for other p

Re: [PATCH v4 3/7] ci: allow use of DPDK tools when building examples

2023-10-17 Thread Bruce Richardson
On Tue, Oct 17, 2023 at 08:24:36AM -0400, Aaron Conole wrote: > Bruce Richardson writes: > > > To allow use of the DPDK python scripts (installed in $(prefix)/bin) > > from within the makefiles of our examples, we need to export the PATH > > variable with the location of our installed scripts fro

Re: [PATCH] ci: test manuals generation in GHA

2023-10-17 Thread Aaron Conole
David Marchand writes: > Add missing package so manuals are generated as part of the docs check. > > Signed-off-by: David Marchand > --- Good catch! Reviewed-by: Aaron Conole

[PATCH] event/cnxk: fix symbol map

2023-10-17 Thread David Marchand
Caught while rebasing a series that check map files. Remove superfluous whitespace. Current ABI number is 24. Sort experimental symbols and annotate them with the version they are introduced in. Fixes: 03714a41bd26 ("event/cnxk: add event port flow context API") Signed-off-by: David Marchand --

RE: [EXT] [PATCH] event/cnxk: fix symbol map

2023-10-17 Thread Pavan Nikhilesh Bhagavatula
> Caught while rebasing a series that check map files. > > Remove superfluous whitespace. > Current ABI number is 24. > Sort experimental symbols and annotate them with the version they are > introduced in. > > Fixes: 03714a41bd26 ("event/cnxk: add event port flow context API") > > Signed-off-by

Re: [PATCH] eal/linux: verify mmu type for DPDK support (ppc64le)

2023-10-17 Thread Thomas Monjalon
11/10/2023 00:51, David Christensen: > IBM POWER systems support more than one type of memory management unit > (MMU). The Power ISA 3.0 specification, which applies to P9 and later > CPUs, defined a new Radix MMU which, among other things, allows an > anonymous memory page mapping to be converted

RE: [PATCH] event/sw: fix missing device pointer

2023-10-17 Thread Van Haaren, Harry
> -Original Message- > From: Richardson, Bruce > Sent: Monday, October 16, 2023 4:17 PM > To: dev@dpdk.org > Cc: Richardson, Bruce ; sta...@dpdk.org; Van > Haaren, Harry ; Jerin Jacob > > Subject: [PATCH] event/sw: fix missing device pointer > > After calling rte_event_dev_info_get() the

Re: [PATCH v3 3/4] baseband/fpga_5gnr_fec: add AGX100 support

2023-10-17 Thread Maxime Coquelin
On 9/18/23 18:31, Hernan Vargas wrote: Add support for new FPGA variant AGX100 (on Arrow Creek N6000). Signed-off-by: Hernan Vargas --- doc/guides/bbdevs/fpga_5gnr_fec.rst | 72 +- drivers/baseband/fpga_5gnr_fec/agx100_pmd.h | 273 .../baseband/fpga_5gnr_fec/fpga_5gnr

Re: [PATCH v3 4/4] baseband/fpga_5gnr_fec: cosmetic comment changes

2023-10-17 Thread Maxime Coquelin
On 9/18/23 18:31, Hernan Vargas wrote: Cosmetic changes for comments. No functional impact. Signed-off-by: Hernan Vargas --- .../baseband/fpga_5gnr_fec/fpga_5gnr_fec.h| 49 ++-- .../fpga_5gnr_fec/rte_fpga_5gnr_fec.c | 246 +- .../fpga_5gnr_fec/rte_pmd_fpga_5g

Re: [PATCH v3 2/4] baseband/fpga_5gnr_fec: add Vista Creek variant

2023-10-17 Thread Maxime Coquelin
On 9/18/23 18:31, Hernan Vargas wrote: Create a new file vc_5gnr_pmd.h to store structures and macros specific to Vista Creek 5G FPGA implementation and rename functions specific to the Vista Creek variant. Signed-off-by: Hernan Vargas --- .../baseband/fpga_5gnr_fec/fpga_5gnr_fec.h| 18

Re: [PATCH v2] eal: use abstracted bit count functions

2023-10-17 Thread Thomas Monjalon
16/10/2023 04:06, Tyler Retzlaff: > Use DPDK abstracted bitcount functions instead of gcc __builtin_'s > > Signed-off-by: Tyler Retzlaff Applied, thanks.

[PATCH] eal: remove return from functions declared void return type

2023-10-17 Thread Tyler Retzlaff
Remove return from rte_free and eal_free_no_trace both functions are declared to have a return type of void so they shouldn't return a value. Signed-off-by: Tyler Retzlaff --- lib/eal/common/rte_malloc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/eal/common/rte_m

[PATCH 2/2] eal: temporarily disable standard c atomics support for MSVC

2023-10-17 Thread Tyler Retzlaff
MSVC will define __STDC_NO_ATOMICS__ until versions of the compiler that support atomics is released. Currently we use the Preview version of the compiler so skip the test of __STDC_NO_ATOMICS__ avoiding failure. This is a temporary change until the required compiler is released publicly but allow

[PATCH 1/2] build: temporarily disable MSVC warnings

2023-10-17 Thread Tyler Retzlaff
Temporarily disable integer truncation and conversion warnings for MSVC to allow CI pipeline to be established. Signed-off-by: Tyler Retzlaff --- config/meson.build | 3 +++ 1 file changed, 3 insertions(+) diff --git a/config/meson.build b/config/meson.build index d56b0f9..6e8320e 100644 --- a/

[PATCH 0/2] make dpdk buildable with latest msvc

2023-10-17 Thread Tyler Retzlaff
This series makes some minor temporary modifications to the MSVC build to allow DPDK to be buildable. The changes are only temporary to allow Windows/MSVC CI pipeline to be established. Warnings will be made clean in a future series and avoidance of STDC atomics check will be removed when the publ

RE: [PATCH] eal: remove return from functions declared void return type

2023-10-17 Thread Morten Brørup
> From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > Sent: Tuesday, 17 October 2023 15.04 > > Remove return from rte_free and eal_free_no_trace both functions are > declared to have a return type of void so they shouldn't return a value. > > Signed-off-by: Tyler Retzlaff > --- Reviewe

Re: [PATCH] ethdev: fix flow action async query coverity

2023-10-17 Thread Ferruh Yigit
On 10/17/2023 1:21 PM, Ori Kam wrote: > Hi Suanming, > >> -Original Message- >> From: Suanming Mou >> Sent: Tuesday, October 17, 2023 11:23 AM >> >> This commit adds the ops chcek to fix the coverity issue. >> >> Coverity issue: 403258 >> Fixes: c9dc03840873 ("ethdev: add indirect action

Re: [PATCH v2 1/1] app/test: resolve mbuf_test application failure

2023-10-17 Thread Olivier Matz
Hi Rakesh, Sorry for the delay. On Tue, Oct 03, 2023 at 04:20:57AM +, Rakesh Kudurumalla wrote: > Hi Olivier, > > Let me know if you have any comments on this patch. > > Regards, > Rakesh > > > -Original Message- > > From: Rakesh Kudurumalla > > Sent: Wednesday, July 26, 2023 11:2

Re: [PATCH] fib: fix adding default route overwriting entire table

2023-10-17 Thread Thomas Monjalon
02/10/2023 17:11, Vladimir Medvedkin: > When FIB contains any route covering last ip address > (255.255.255.255), upon adding a new default route > the entire fib table will be overwritten with corresponding > default route next hop. > > Previous fix added check for ledge against 0 for case > if d

Re: [PATCH] fib6: fix adding default route as first route

2023-10-17 Thread Thomas Monjalon
02/10/2023 17:12, Vladimir Medvedkin: > Currently when adding default route as first route > it is not added and no error is reported. > When we enter the loop over an address range in > the general case we will eventually reach the check > for when the range has ended, and exit the loop. > However

Re: [PATCH 1/2] build: temporarily disable MSVC warnings

2023-10-17 Thread Bruce Richardson
On Tue, Oct 17, 2023 at 06:13:46AM -0700, Tyler Retzlaff wrote: > Temporarily disable integer truncation and conversion warnings for MSVC > to allow CI pipeline to be established. > > Signed-off-by: Tyler Retzlaff > --- > config/meson.build | 3 +++ > 1 file changed, 3 insertions(+) > > diff --

Re: [PATCH] eal: fix modify data area after memset

2023-10-17 Thread Thomas Monjalon
We need a careful review here, please. 12/09/2023 11:04, Fengnan Chang: > Let's look at this path: > malloc_elem_free >->malloc_elem_join_adjacent_free > ->join_elem(elem, elem->next) > > 0. cur elem's pad > 0 > 1. data area memset in malloc_elem_free first. > 2. next elem is free, try

Re: [PATCH 2/6] Section 2: Install and Build DPDK

2023-10-17 Thread Tyler Retzlaff
On Thu, Oct 12, 2023 at 02:08:46PM -0400, Dave Young wrote: > Tyler, can you provide an example of the OS specific section/title you're > thinking would make sense to use? I think what is below is okay, but it probably just needs a Windows section? Right now there is, so just adding Windows into

[PATCH v2 2/2] eal: disable standard c atomics support check for MSVC

2023-10-17 Thread Tyler Retzlaff
MSVC will define __STDC_NO_ATOMICS__ until versions of the compiler that support atomics is released. Currently we use the Preview version of the compiler so skip the test of __STDC_NO_ATOMICS__ avoiding failure. This is a temporary change until the required compiler is released publicly but allow

[PATCH v2 0/2] make dpdk buildable with latest msvc

2023-10-17 Thread Tyler Retzlaff
This series makes some minor temporary modifications to the MSVC build to allow DPDK to be buildable. The changes are only temporary to allow Windows/MSVC CI pipeline to be established. Warnings will be made clean in a future series and avoidance of STDC atomics check will be removed when the publ

[PATCH v2 1/2] build: temporarily disable MSVC warnings

2023-10-17 Thread Tyler Retzlaff
Temporarily disable integer truncation and conversion warnings for MSVC to allow CI pipeline to be established. Signed-off-by: Tyler Retzlaff Acked-by: Bruce Richardson --- config/meson.build | 5 + 1 file changed, 5 insertions(+) diff --git a/config/meson.build b/config/meson.build index

Re: [PATCH v1] dts: add Dockerfile

2023-10-17 Thread Paul Szczepanek
On 03/11/2022 13:46, Juraj Linkeš wrote: The Dockerfile defines development and CI runner images. Signed-off-by: Juraj Linkeš Acked-by: Jeremy Spweock --- dts/.devcontainer/devcontainer.json | 30 dts/Dockerfile | 38 dts/README.

Re: [PATCH] net/nfp: fix coredump problem when testpmd exit

2023-10-17 Thread Ferruh Yigit
On 10/17/2023 3:37 AM, Chaoyong He wrote: > The ".dev_close" should not call rte_eth_dev_release_port() API > directly, the rte_eth_dev_close() API will do it. > > Fixes: 831c44ab7869 ("net/nfp: add flower PF related routines") > Cc: chaoyong...@corigine.com > Cc: sta...@dpdk.org > > Signed-off-b

[PATCH] eal: fix compile failure of asm on MSVC toolchain

2023-10-17 Thread Tyler Retzlaff
Most MSVC targets do not support inline asm and __MWAITX__ is a GCC implementation detail. Use a test of defined(RTE_TOOLCHAIN_MSVC) to avoid conditional compilation of inline asm and instead use intrinsics instead. Fixes: c7ed1ce04704 ("eal/x86: add power intrinsics for AMD") Cc: sivaprasad.tumm.

Re: [PATCH v5 00/40] support setting and querying RSS algorithms

2023-10-17 Thread Thomas Monjalon
Hello, 11/10/2023 11:27, Jie Hai: > app/proc-info/main.c | 32 ++- > app/test-pmd/cmdline.c | 29 ++--- > app/test-pmd/config.c | 38 - > app/test-pmd/testpmd.h | 2 +- > doc/guides/rel_notes/r

Re: [PATCH v5 3/9] ci: allow use of DPDK tools when building examples

2023-10-17 Thread Aaron Conole
Bruce Richardson writes: > To allow use of the DPDK python scripts (installed in $(prefix)/bin) > from within the makefiles of our examples, we need to export the PATH > variable with the location of our installed scripts from within our CI > scripts. This matches what is already done for other p

Re: [PATCH 00/36] fix Rx and Tx queue state

2023-10-17 Thread Thomas Monjalon
16/10/2023 13:51, Ferruh Yigit: > On 9/8/2023 12:28 PM, Jie Hai wrote: > > The DPDK framework reports the queue state, which is stored in > > dev->data->tx_queue_state and dev->data->rx_queue_state. The > > state is maintained by the driver. Users may determine whether > > a queue participates in p

[RFC v2 0/2] vduse: Add support for reconnection

2023-10-17 Thread Cindy Lu
This patch changes based on Maxime's patch https://gitlab.com/mcoquelin/dpdk-next-virtio/-/commit/a89dc311f2d03e99b8180f377b4a60a0e94 The biggest change is sync the information with kernel by mmap the kernel branch is https://gitlab.com/lulu6/vhost/tree/vduse5 the dpdk branch is https://gitlab.com

[RFC v2 1/2] vduse: add mapping process in vduse create and destroy

2023-10-17 Thread Cindy Lu
the change in the creation process is add 1> check if we need to do reconnect 2> Use ioctl get the reconnect info (size and max page number) from kernel 3> mapping 1 page for reconnect  status + vq_numbers pages for every vqs, The change in the destroy process is the add the related unmap process

[RFC v2 2/2] vhost: add reconnection support to VDUSE (WIP)

2023-10-17 Thread Cindy Lu
From: Maxime Coquelin this patch is changed from https://gitlab.com/mcoquelin/dpdk-next-virtio/-/commit/a89dc311f2d03e99b8180f377b4a60a0e94 the biggest change is moving the mmaping-related process to the Previous patch Signed-off-by: Cindy Lu --- lib/vhost/vduse.c | 43 ++

Re: [PATCH v5 00/40] support setting and querying RSS algorithms

2023-10-17 Thread Ferruh Yigit
On 10/17/2023 3:06 PM, Thomas Monjalon wrote: > Hello, > > 11/10/2023 11:27, Jie Hai: >> app/proc-info/main.c | 32 ++- >> app/test-pmd/cmdline.c | 29 ++--- >> app/test-pmd/config.c | 38 - >> app/test-pmd/tes

  1   2   3   >