16/10/2023 13:51, Ferruh Yigit:
> On 9/8/2023 12:28 PM, Jie Hai wrote:
> > The DPDK framework reports the queue state, which is stored in
> > dev->data->tx_queue_state and dev->data->rx_queue_state. The
> > state is maintained by the driver. Users may determine whether
> > a queue participates in packet forwarding based on the state,
> > for example,
> >
> > [1] 5028f207a4fa ("app/testpmd: fix secondary process packet forwarding"
> > [2] 141a520b35f7 ("app/testpmd: fix primary process not polling all queues")
> >
> > Therefore, the drivers need to modify the queue state in time
> > according to the actual situation, especially when dev_start
> > and dev_stop are called. see [3] for more information.
> >
> > [3]
> > https://inbox.dpdk.org/dev/20230721160422.3848154-1-ferruh.yi...@amd.com/
> >
> > This patchset also resubmit the patch [2] and makes some fixes on the patch.
> >
> > Jie Hai (36):
> > net/axgbe: fix Rx and Tx queue state
> > net/af_packet: fix Rx and Tx queue state
> > net/af_xdp: fix Rx and Tx queue state
> > net/avp: fix Rx and Tx queue state
> > net/bnx2x: fix Rx and Tx queue state
> > net/bnxt: fix Rx and Tx queue state
> > net/bonding: fix Rx and Tx queue state
> > net/cxgbe: fix Rx and Tx queue state
> > net/dpaa: fix Rx and Tx queue state
> > net/dpaa2: fix Rx and Tx queue state
> > net/e1000: fix Rx and Tx queue state
> > net/ena: fix Rx and Tx queue state
> > net/enetc: fix Rx and Tx queue state
> > net/enic: fix Rx and Tx queue state
> > net/hinic: fix Rx and Tx queue state
> > net/ipn3ke: fix Rx and Tx queue state
> > net/memif: fix Rx and Tx queue state
> > net/mana: fix Rx and Tx queue state
> > net/mlx4: fix Rx and Tx queue state
> > net/mvneta: fix Rx and Tx queue state
> > net/mvpp2: fix Rx and Tx queue state
> > net/netvsc: fix Rx and Tx queue state
> > net/nfp: fix Rx and Tx queue state
> > net/ngbe: fix Rx and Tx queue state
> > net/null: fix Rx and Tx queue state
> > net/octeon_ep: fix Rx and Tx queue state
> > net/octeontx: fix Rx and Tx queue state
> > net/pfe: fix Rx and Tx queue state
> > net/ring: fix Rx and Tx queue state
> > net/sfc: fix Rx and Tx queue state
> > net/softnic: fix Rx and Tx queue state
> > net/txgbe: fix Rx and Tx queue state
> > net/vhost: fix Rx and Tx queue state
> > net/virtio: fix Rx and Tx queue state
> > net/vmxnet3: fix Rx and Tx queue state
> > app/testpmd: fix primary process not polling all queues
> >
>
> For series,
> Acked-by: Ferruh Yigit <ferruh.yi...@amd.com>
I see this series as a failure in having common code in ethdev.
I hope we can revert it later to have a better ethdev code
which update queue states taking deferred start into account.
It may require to rework all drivers to have a common behaviour,
but it would be a better improvement.
