Re: [PATCH v3 2/4] baseband/fpga_5gnr_fec: add Vista Creek variant

[Maxime Coquelin]

On 9/18/23 18:31, Hernan Vargas wrote:
Create a new file vc_5gnr_pmd.h to store structures and macros specific
to Vista Creek 5G FPGA implementation and rename functions specific to
the Vista Creek variant.

Signed-off-by: Hernan Vargas <hernan.var...@intel.com>
---
  .../baseband/fpga_5gnr_fec/fpga_5gnr_fec.h    | 183 +-----
  .../fpga_5gnr_fec/rte_fpga_5gnr_fec.c         | 531 +++++++++---------
  drivers/baseband/fpga_5gnr_fec/vc_5gnr_pmd.h  | 140 +++++
  3 files changed, 426 insertions(+), 428 deletions(-)
  create mode 100644 drivers/baseband/fpga_5gnr_fec/vc_5gnr_pmd.h


Overall looks good, but I'll wait for the reworks I asked in patch 3 to 
give my R-by.

Thanks,
Maxime