[PATCH v4 2/2] devtools: list symbols by version

Make it easier to list experimental symbols added in a certain version. Example: $ ./buildtools/map-list-symbol.sh -V 18.11 lib/eal/version.map lib/eal/version.map EXPERIMENTAL rte_dev_event_callback_process lib/eal/version.map EXPERIMENTAL rte_dev_hotplug_handle_disable lib/eal/version.map EXPERI

[PATCH v4 1/2] devtools: add check on symbol maps format

Add a check on symbol maps format (fixing ethdev at the same time). This will be required by a next commit. Signed-off-by: David Marchand --- Changes since v3: - fixed Alpine build (same issue with { in awk expression than commit e1ab26df4862 ("buildtools: fix build with busybox")), Changes si

[PATCH] app/dma-perf: fix physical address seg-fault

do_cpu_mem_copy uses DPDK API rte_mbuf_data_iova to return the start of the virtual address for both src and dst. But in case of iova mode set as PA, this results in seg-fault. This is because rte_memcpy VA address and not PA. this fix checks the iova mode and invokes rte_memcpy with the right arg

RE: [PATCH] app/dma-perf: fix physical address seg-fault

[AMD Official Use Only - General] Hi Anoob, > -Original Message- > From: Anoob Joseph > Sent: Wednesday, August 16, 2023 11:38 AM > To: Varghese, Vipin > Cc: Yigit, Ferruh ; cheng1.ji...@intel.com; > sta...@dpdk.org; tho...@monjalon.net; dev@dpdk.org; Jerin Jacob > Kollanukkaran > Subj

RE: [EXT] [PATCH] app/dma-perf: fix physical address seg-fault

Hi Vipin, Thanks for the update. Please see inline. Thanks, Anoob > -Original Message- > From: Vipin Varghese > Sent: Wednesday, August 16, 2023 12:48 PM > To: tho...@monjalon.net; dev@dpdk.org > Cc: ferruh.yi...@amd.com; cheng1.ji...@intel.com; sta...@dpdk.org > Subject: [EXT] [PATCH]

RE: [EXT] [PATCH] app/dma-perf: fix physical address seg-fault

[AMD Official Use Only - General] > -Original Message- > From: Anoob Joseph > Sent: Wednesday, August 16, 2023 12:57 PM > To: Varghese, Vipin > Cc: Yigit, Ferruh ; cheng1.ji...@intel.com; > sta...@dpdk.org; tho...@monjalon.net; dev@dpdk.org; Jerin Jacob > Kollanukkaran > Subject: RE: [E

Re: [PATCH v2 1/7] drivers: changes for dmadev driver

On Mon, Jul 31, 2023 at 5:50 PM Amit Prakash Shukla wrote: > > Dmadev driver changes to align with dpdk spec. 1) Change the subject to dma/cnxk: ... 2) Tell what is changed and why changed? 3) Across the series and this patches, if something is "fix" change as dma/cnxk: fix and add Fixes: 4

RE: [EXT] [PATCH v8 2/6] reorder: use a dynamic logtype

> -Original Message- > From: Stephen Hemminger > Sent: Monday, August 14, 2023 6:31 PM > To: dev@dpdk.org > Cc: Stephen Hemminger ; > sergio.gonzalez.mon...@intel.com; > Volodymyr Fialko ; Reshma Pattan > ; Neil Horman > ; Richardson Bruce ; > Declan Doherty > > Subject: [EXT] [PATCH v

[PATCH v2] app/dma-perf: fix physical address seg-fault

do_cpu_mem_copy uses DPDK API rte_mbuf_data_iova to return the start of the virtual address for both src and dst. But in case of iova mode set as PA, this results in seg-fault. This is because rte_memcpy uses VA address and not PA. This fix invokes `rte_pktmbuf_mtod` for both src and dst. Bugzill

[PATCH v2] app/dma-perf: fix physical address seg-fault

do_cpu_mem_copy uses DPDK API rte_mbuf_data_iova to return the start of the virtual address for both src and dst. But in case of iova mode set as PA, this results in seg-fault. This is because rte_memcpy uses VA address and not PA. This fix invokes `rte_pktmbuf_mtod` for both src and dst. Bugzill

[PATCH v2] app/dma-perf: fix physical address seg-fault

do_cpu_mem_copy uses DPDK API rte_mbuf_data_iova to return the start of the virtual address for both src and dst. But in case of iova mode set as PA, this results in seg-fault. This is because rte_memcpy uses VA address and not PA. This fix invokes `rte_pktmbuf_mtod` for both src and dst. Bugzill

RE: [EXT] Re: [PATCH v2 1/7] drivers: changes for dmadev driver

Thanks Jerin for the feedback. I will send the next version of patch with suggested changes. > -Original Message- > From: Jerin Jacob > Sent: Wednesday, August 16, 2023 1:44 PM > To: Amit Prakash Shukla > Cc: Vamsi Krishna Attunuru ; dev@dpdk.org; Jerin > Jacob Kollanukkaran > Subject

[PATCH v2 1/2] power: refactor uncore power management interfaces

currently the uncore power management implementation is vendor specific. Added new vendor agnostic uncore power interface similar to rte_power and rename specific implementations ("rte_power_intel_uncore") to "power_intel_uncore" along with functions. Signed-off-by: Sivaprasad Tummala --- lib/po

[PATCH v2 2/2] power: refactor uncore power management implementation

currently the uncore power management implementation is vendor specific. Added new vendor agnostic uncore power management implementation similar to rte_power and rename specific implementations ("rte_power_intel_uncore") to "power_intel_uncore" along with functions. Signed-off-by: Sivaprasad Tumm

Re: [PATCH v2] app/dma-perf: fix physical address seg-fault

On Wed, Aug 16, 2023 at 3:21 PM Vipin Varghese wrote: > > do_cpu_mem_copy uses DPDK API rte_mbuf_data_iova to return > the start of the virtual address for both src and dst. > But in case of iova mode set as PA, this results in seg-fault. > This is because rte_memcpy uses VA address and not PA. >

RE: [EXT] [PATCH v2] app/dma-perf: fix physical address seg-fault

> do_cpu_mem_copy uses DPDK API rte_mbuf_data_iova to return the start > of the virtual address for both src and dst. > But in case of iova mode set as PA, this results in seg-fault. > This is because rte_memcpy uses VA address and not PA. > > This fix invokes `rte_pktmbuf_mtod` for both src and d

Re: [PATCH v5 04/10] app/test: build using per-file dependency matrix

On Tue, Aug 15, 2023 at 03:05:08PM -0400, Patrick Robb wrote: >Adam from our team just raised something important about this patch and >UNH CI which I missed during the RFC discussion. >Presently, eal_flags_file_prefix_autotest fails on arm tx2 systems (arm >people are aware of this

Re: [PATCH v5 05/10] app/test: define unit tests suites based on test macros

On Tue, Aug 15, 2023 at 04:10:49PM +0100, Bruce Richardson wrote: > Rather than having the test suites listed out in the meson.build files > and having to have them enabled/disabled selectively based on what libs > are being built, pull the tests to run from the source files which were > added to t

Re: [PATCH v5 05/10] app/test: define unit tests suites based on test macros

On Wed, Aug 16, 2023 at 1:02 PM Bruce Richardson wrote: > These lines here seem to be exposing a bug in the mempool unit tests for > shared builds, which is why we have a CI failure. > > The mempool unit tests use the mempool "create_empty" API, and then call > the populate APIs to finish setting

Re: [PATCH v5 05/10] app/test: define unit tests suites based on test macros

On Wed, Aug 16, 2023 at 1:15 PM David Marchand wrote: > > On Wed, Aug 16, 2023 at 1:02 PM Bruce Richardson > wrote: > > These lines here seem to be exposing a bug in the mempool unit tests for > > shared builds, which is why we have a CI failure. > > > > The mempool unit tests use the mempool "cr

Re: [PATCH v5 05/10] app/test: define unit tests suites based on test macros

On Wed, Aug 16, 2023 at 01:40:41PM +0200, David Marchand wrote: > On Wed, Aug 16, 2023 at 1:15 PM David Marchand > wrote: > > > > On Wed, Aug 16, 2023 at 1:02 PM Bruce Richardson > > wrote: > > > These lines here seem to be exposing a bug in the mempool unit tests for > > > shared builds, which i

Re: [PATCH v5 04/10] app/test: build using per-file dependency matrix

On Tue, Aug 15, 2023 at 03:05:08PM -0400, Patrick Robb wrote: >Adam from our team just raised something important about this patch and >UNH CI which I missed during the RFC discussion. >Presently, eal_flags_file_prefix_autotest fails on arm tx2 systems (arm >people are aware of this

RE: [PATCH] ethdev: introduce generic flow item and action

Hi Ori, > > > Can you show me what items/actions are missing in rte_flow? > > > > The number of flow items (protocol headers, but also metadata) and flow > > actions > > that users can define in their P4 programs is infinite, so unfortunately > > Ori, as > > much > > as I want to grant you this

Re: [PATCH v5 05/10] app/test: define unit tests suites based on test macros

Hi, On Wed, Aug 16, 2023 at 01:33:46PM +0100, Bruce Richardson wrote: > On Wed, Aug 16, 2023 at 01:40:41PM +0200, David Marchand wrote: > > On Wed, Aug 16, 2023 at 1:15 PM David Marchand > > wrote: > > > > > > On Wed, Aug 16, 2023 at 1:02 PM Bruce Richardson > > > wrote: > > > > These lines here

RE: [PATCH] ethdev: introduce generic flow item and action

Hi Morten, > > > > > > In order to avoid conflicts between P4 and non-P4 generic flow > > items/actions, > > > the generic type should include information about how to interpret the > > > information, which is why I suggest making it a Vendor-Specific type, with > > > vendor-specific TLV's (mana

Re: [PATCH v5 05/10] app/test: define unit tests suites based on test macros

On Wed, Aug 16, 2023 at 03:35:47PM +0200, Morten Brørup wrote: > > From: Olivier Matz [mailto:olivier.m...@6wind.com] > > Sent: Wednesday, 16 August 2023 15.17 > > > > Hi, > > > > On Wed, Aug 16, 2023 at 01:33:46PM +0100, Bruce Richardson wrote: > > > On Wed, Aug 16, 2023 at 01:40:41PM +0200, Dav

RE: [PATCH v5 05/10] app/test: define unit tests suites based on test macros

> From: Olivier Matz [mailto:olivier.m...@6wind.com] > Sent: Wednesday, 16 August 2023 15.17 > > Hi, > > On Wed, Aug 16, 2023 at 01:33:46PM +0100, Bruce Richardson wrote: > > On Wed, Aug 16, 2023 at 01:40:41PM +0200, David Marchand wrote: > > > On Wed, Aug 16, 2023 at 1:15 PM David Marchand > > >

RE: [PATCH] ethdev: introduce generic flow item and action

> From: Dumitrescu, Cristian [mailto:cristian.dumitre...@intel.com] > Sent: Wednesday, 16 August 2023 15.23 > > Hi Morten, > > > > > > > > > > > In order to avoid conflicts between P4 and non-P4 generic flow > > > items/actions, > > > > the generic type should include information about how to i

Re: [PATCH v5 04/10] app/test: build using per-file dependency matrix

Patrick, Bruce, On Wed, Aug 16, 2023 at 2:57 PM Bruce Richardson wrote: > > On Tue, Aug 15, 2023 at 03:05:08PM -0400, Patrick Robb wrote: > >Adam from our team just raised something important about this patch and > >UNH CI which I missed during the RFC discussion. > >Presently, eal_fl

Re: [PATCH v5 02/10] app/test: tag tests with the test type

On Tue, Aug 15, 2023 at 5:23 PM Bruce Richardson wrote: > diff --git a/app/test/test_acl.c b/app/test/test_acl.c > index 623f34682e..bf1466fe11 100644 > --- a/app/test/test_acl.c > +++ b/app/test/test_acl.c > @@ -1749,4 +1749,4 @@ test_acl(void) > > #endif /* !RTE_EXEC_ENV_WINDOWS */ > > -REGISTE

Re: [PATCH v5 05/10] app/test: define unit tests suites based on test macros

On Tue, Aug 15, 2023 at 5:24 PM Bruce Richardson wrote: > > Rather than having the test suites listed out in the meson.build files > and having to have them enabled/disabled selectively based on what libs > are being built, pull the tests to run from the source files which were > added to the buil

Re: [PATCH v5 02/10] app/test: tag tests with the test type

On Wed, Aug 16, 2023 at 04:56:23PM +0200, David Marchand wrote: > On Tue, Aug 15, 2023 at 5:23 PM Bruce Richardson > wrote: > > diff --git a/app/test/test_acl.c b/app/test/test_acl.c > > index 623f34682e..bf1466fe11 100644 > > --- a/app/test/test_acl.c > > +++ b/app/test/test_acl.c > > @@ -1749,4

Re: [PATCH v5 05/10] app/test: define unit tests suites based on test macros

On Wed, Aug 16, 2023 at 04:57:07PM +0200, David Marchand wrote: > On Tue, Aug 15, 2023 at 5:24 PM Bruce Richardson > wrote: > > > > Rather than having the test suites listed out in the meson.build files > > and having to have them enabled/disabled selectively based on what libs > > are being built

[PATCH v6 00/11] expand list of optional libraries

This patchset contains changes to DPDK to make the build more configurable overall. The changes can be grouped into two areas: * Firstly, there are changes to make the build of the unit tests more flexible and maintainable. These 7 patches switch the unit tests from having separate hard-coded

[PATCH v6 01/11] mempool: fix default ops for an empty mempool

From: David Marchand An empty mempool's ops were not initialised to a default value wrt to what the application requested via the flags parameter. As rte_mempool_create() relies on rte_mempool_create_empty(), simply move this ops initialisation to rte_mempool_create_empty(). Fixes: aa10457eb4c2

[PATCH v6 02/11] app/test: add new macros for various test types

Rather than just registering all tests using a single generic macro, add macros which identify the test as being of a particular type. Signed-off-by: Bruce Richardson Acked-by: Morten Brørup --- app/test/test.h | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/app/test

[PATCH v6 03/11] app/test: tag tests with the test type

Rather than having the test types called out in the meson.build file, we can use macros to identify the test type in the C file itself and then dynamically build up the tests lists at config time. Signed-off-by: Bruce Richardson Acked-by: Morten Brørup --- app/test/test_acl.c

[PATCH v6 04/11] app/test: make telemetry data test buildable on windows

To enable the building of the telemetry data tests file when building on windows, we need to provide a stub implementation. That way, the test file is buildable any time the library itself is built. Signed-off-by: Bruce Richardson Acked-by: Morten Brørup --- app/test/test_telemetry_data.c | 14

[PATCH v6 06/11] app/test: define unit tests suites based on test macros

Rather than having the test suites listed out in the meson.build files and having to have them enabled/disabled selectively based on what libs are being built, pull the tests to run from the source files which were added to the build. Most test suites require no additional info other than the list

[PATCH v6 07/11] app/test: add test case for scripted telemetry commands

The test script for calling all telemetry commands is not discoverable by checking the C files for the build. Therefore we need to add it in as a special-case test in the fast-tests group. Signed-off-by: Bruce Richardson --- app/test/suites/meson.build | 30 +

[PATCH v6 08/11] app/test: add debug test suite

Add in for all platforms, the suite of tests to dump out the structure information available. Since the commands are defined in commands.c on all OS's, do not limit their presence to just the non-windows OS's. Signed-off-by: Bruce Richardson --- app/test/suites/meson.build | 20 +

[PATCH v6 09/11] examples/l3fwd: make eventdev an optional dependency

With l3fwd being a very commonly used example app, and built as part of our CI tests, we need to ensure it's buildable with just about all supported DPDK configurations. To enable l3fwd application to be built when the eventdev library is disabled, we need to compile in the eventdev support condit

[PATCH v6 10/11] build: make most device classes optional

Apart from ethdev and cryptodev, which have lots of components and tests which depend on them, we can make the device class libraries optional without too much work. This patch marks: * bbdev, * compressdev, * dmadev, * eventdev, * mldev, * rawdev, * regexdev optional, and ensures that DPDK - incl

[PATCH v6 11/11] build: expand list of optional libraries

With the unit test build now with individual per-file dependencies, we can more easily expand the list of optional libraries. Add 8 new libraries to the optional list. Signed-off-by: Bruce Richardson Acked-by: Morten Brørup --- lib/meson.build | 8 1 file changed, 8 insertions(+) diff

[PATCH v6 05/11] app/test: build using per-file dependency matrix

Rather than using if-else constructs to selectively add or remove files from the UT build, switch to a table-based approach where each file lists out what libs or drivers it depends upon. Initial version of this table was generated via analysis of the header files included in each C file. The basi

DPDK 20.11.9 released

Hi all, Here is a new stable release: https://fast.dpdk.org/rel/dpdk-20.11.9.tar.xz The git tree is at: https://dpdk.org/browse/dpdk-stable/?h=20.11 Luca Boccassi --- VERSION| 2 +- app/test-crypto-perf/main.c

DPDK community: RTE_FLOW support for P4-programmable devices

Hi folks, We just set up a community call for next week to discuss in more details the proposal for RTE_FLOW extensions to support P4-programmable devices https://mails.dpdk.org/archives/dev/2023-August/273703.html and look for ways to converge and make progress. All the people from To: and CC

RE: [PATCH v6 01/11] mempool: fix default ops for an empty mempool

> From: Bruce Richardson [mailto:bruce.richard...@intel.com] > Sent: Wednesday, 16 August 2023 17.34 > > From: David Marchand > > An empty mempool's ops were not initialised to a default value wrt to > what the application requested via the flags parameter. As > rte_mempool_create() relies on r

Re: [PATCH 00/32] Remove use and definition of RTE_STD_C11 macro

On Sat, Aug 12, 2023 at 12:23 AM Tyler Retzlaff wrote: > > We now document C11 conformant compiler as a minimum, it's not necessary > to mark C11 feature use with __extension__ to avoid warnings. > > Tyler Retzlaff (32): > timer: remove use of RTE STD C11 macro > stack: remove use of RTE STD C

Re: [PATCH] ethdev: introduce generic flow item and action

On 8/16/2023 3:20 PM, Morten Brørup wrote: >> From: Dumitrescu, Cristian [mailto:cristian.dumitre...@intel.com] >> Sent: Wednesday, 16 August 2023 15.23 >> >> Hi Morten, >> >> >> > > In order to avoid conflicts between P4 and non-P4 generic flow items/actions, > the generic type s

RE: [PATCH] ethdev: introduce generic flow item and action

> -Original Message- > From: Ferruh Yigit > Sent: Wednesday, August 16, 2023 6:08 PM > To: Morten Brørup ; Dumitrescu, Cristian > ; Zhang, Qi Z ; Ori > Kam ; Jerin Jacob > Cc: NBU-Contact-Thomas Monjalon (EXTERNAL) ; > david.march...@redhat.com; Richardson, Bruce > ; jer...@marvell.com;

Re: C11 atomics adoption blocked

On Mon, Aug 14, 2023 at 05:13:04PM +0200, Morten Brørup wrote: > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > Sent: Monday, 14 August 2023 15.46 > > > > mercredi 9 août 2023, Morten Brørup: > > > > From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > > > > Sent: Tuesday, 8 Augu

Re: [PATCH v5 04/10] app/test: build using per-file dependency matrix

On Wed, Aug 16, 2023 at 10:40 AM David Marchand wrote: > Patrick, Bruce, > > If it was reported, I either missed it or forgot about it, sorry. > Can you (re)share the context? > > > > Does the test suite pass if the mlx5 driver is disabled in the build? > That > > could confirm or refute the su

[PATCH v5 1/3] eal: add x86 cpuid support for monitorx

Add a new CPUID flag to indicate support for monitorx instruction on AMD EPYC processors. Signed-off-by: Sivaprasad Tummala Acked-by: Anatoly Burakov --- Depends-on: series-29173 ("test/cpuflags: removed test for NUMFLAGS") --- lib/eal/x86/include/rte_cpuflags.h | 2 +- lib/eal/x86/rte_cpuflags

[PATCH v5 2/3] eal: removed unnecessary checks in x86 power monitor APIs

current x86 power monitor implementation fails on platforms with only monitor supported and not power_pause. Signed-off-by: Sivaprasad Tummala Acked-by: Anatoly Burakov --- lib/eal/x86/rte_power_intrinsics.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/lib/eal/x86/

[PATCH v5 3/3] power: amd power monitor support

mwaitx allows EPYC processors to enter a implementation dependent power/performance optimized state (C1 state) for a specific period or until a store to the monitored address range. Signed-off-by: Sivaprasad Tummala Acked-by: Anatoly Burakov --- lib/eal/x86/rte_power_intrinsics.c | 77 +

[PATCH v3 0/6] RFC optional rte optional stdatomics API

This series introduces API additions prefixed in the rte namespace that allow the optional use of stdatomics.h from C11 using enable_stdatomics=true for targets where enable_stdatomics=false no functional change is intended. Be aware this does not contain all changes to use stdatomics across the D

[PATCH v3 1/6] eal: provide rte stdatomics optional atomics API

Provide API for atomic operations in the rte namespace that may optionally be configured to use C11 atomics with meson option enable_stdatomics=true Signed-off-by: Tyler Retzlaff Reviewed-by: Morten Brørup --- config/meson.build | 1 + lib/eal/include/generic/rte_atomic.h

[PATCH v3 3/6] eal: add rte atomic qualifier with casts

Introduce __rte_atomic qualifying casts in rte_optional atomics inline functions to prevent cascading the need to pass __rte_atomic qualified arguments. Warning, this is really implementation dependent and being done temporarily to avoid having to convert more of the libraries and tests in DPDK in

[PATCH v3 4/6] distributor: adapt for EAL optional atomics API changes

Adapt distributor for EAL optional atomics API changes Signed-off-by: Tyler Retzlaff Reviewed-by: Morten Brørup --- lib/distributor/distributor_private.h| 2 +- lib/distributor/rte_distributor_single.c | 44 2 files changed, 23 insertions(+), 23 deletions(-

[PATCH v3 6/6] devtools: forbid new direct use of GCC atomic builtins

Refrain from using compiler __atomic_xxx builtins DPDK now requires the use of rte_atomic__explicit macros when operating on DPDK atomic variables. Signed-off-by: Tyler Retzlaff Suggested-by: Morten Brørup Acked-by: Bruce Richardson Acked-by: Morten Brørup --- devtools/checkpatches.sh | 6 +++

[PATCH v3 2/6] eal: adapt EAL to present rte optional atomics API

Adapt the EAL public headers to use rte optional atomics API instead of directly using and exposing toolchain specific atomic builtin intrinsics. Signed-off-by: Tyler Retzlaff Reviewed-by: Morten Brørup --- app/test/test_mcslock.c| 6 ++-- lib/eal/arm/include/rte_atomic_32.h

[PATCH v3 5/6] bpf: adapt for EAL optional atomics API changes

Adapt bpf for EAL optional atomics API changes Signed-off-by: Tyler Retzlaff Reviewed-by: Morten Brørup --- lib/bpf/bpf_pkt.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/bpf/bpf_pkt.c b/lib/bpf/bpf_pkt.c index ffd2db7..7a8e4a6 100644 --- a/lib/bpf/bpf_pkt.c +++

Re: [PATCH v5 04/10] app/test: build using per-file dependency matrix

On Wed, Aug 16, 2023 at 8:30 PM Patrick Robb wrote: > On Wed, Aug 16, 2023 at 10:40 AM David Marchand > wrote: >> >> Patrick, Bruce, >> >> If it was reported, I either missed it or forgot about it, sorry. >> Can you (re)share the context? >> >> >> > >> > Does the test suite pass if the mlx5 driv

Re: [PATCH v5 3/3] power: amd power monitor support

On Wed, Aug 16, 2023 at 11:59:59AM -0700, Sivaprasad Tummala wrote: > mwaitx allows EPYC processors to enter a implementation dependent > power/performance optimized state (C1 state) for a specific period > or until a store to the monitored address range. > > Signed-off-by: Sivaprasad Tummala > A

RE: [PATCH v2 2/6] eal: adapt EAL to present rte optional atomics API

> From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > Sent: Monday, 14 August 2023 19.47 > > On Mon, Aug 14, 2023 at 10:00:49AM +0200, Morten Brørup wrote: > > > From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > > > Sent: Friday, 11 August 2023 19.32 > > > > > > Adapt the EAL p

RE: C11 atomics adoption blocked

> From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > Sent: Wednesday, 16 August 2023 19.26 > > On Mon, Aug 14, 2023 at 05:13:04PM +0200, Morten Brørup wrote: > > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > Sent: Monday, 14 August 2023 15.46 > > > > > > mercredi 9 août 2023

Re: [PATCH v2 2/6] eal: adapt EAL to present rte optional atomics API

On Wed, Aug 16, 2023 at 10:13:22PM +0200, Morten Brørup wrote: > > From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > > Sent: Monday, 14 August 2023 19.47 > > > > On Mon, Aug 14, 2023 at 10:00:49AM +0200, Morten Brørup wrote: > > > > From: Tyler Retzlaff [mailto:roret...@linux.microsoft.

Re: [PATCH v5 04/10] app/test: build using per-file dependency matrix

On Wed, Aug 16, 2023 at 3:26 PM David Marchand wrote: > On Wed, Aug 16, 2023 at 8:30 PM Patrick Robb wrote: > > On Wed, Aug 16, 2023 at 10:40 AM David Marchand < > david.march...@redhat.com> wrote: > >> > >> Patrick, Bruce, > >> > >> If it was reported, I either missed it or forgot about it, sor

RE: [PATCH v3 1/6] eal: provide rte stdatomics optional atomics API

> From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > Sent: Wednesday, 16 August 2023 21.19 > > Provide API for atomic operations in the rte namespace that may > optionally be configured to use C11 atomics with meson > option enable_stdatomics=true > > Signed-off-by: Tyler Retzlaff > Re

Re: [PATCH v3 1/6] eal: provide rte stdatomics optional atomics API

On Wed, Aug 16, 2023 at 10:55:51PM +0200, Morten Brørup wrote: > > From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > > Sent: Wednesday, 16 August 2023 21.19 > > > > Provide API for atomic operations in the rte namespace that may > > optionally be configured to use C11 atomics with meson

RE: [PATCH v3 1/6] eal: provide rte stdatomics optional atomics API

> From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > Sent: Wednesday, 16 August 2023 23.04 > > On Wed, Aug 16, 2023 at 10:55:51PM +0200, Morten Brørup wrote: > > > From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > > > Sent: Wednesday, 16 August 2023 21.19 > > > > > > Provide A

Re: [PATCH v3 1/6] eal: provide rte stdatomics optional atomics API

On Wed, Aug 16, 2023 at 02:04:06PM -0700, Tyler Retzlaff wrote: > On Wed, Aug 16, 2023 at 10:55:51PM +0200, Morten Brørup wrote: > > > From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > > > Sent: Wednesday, 16 August 2023 21.19 > > > > > > Provide API for atomic operations in the rte nam

[PATCH v4 1/6] eal: provide rte stdatomics optional atomics API

Provide API for atomic operations in the rte namespace that may optionally be configured to use C11 atomics with meson option enable_stdatomics=true Signed-off-by: Tyler Retzlaff Reviewed-by: Morten Brørup --- config/meson.build | 1 + lib/eal/include/generic/rte_atomic.h

[PATCH v4 3/6] eal: add rte atomic qualifier with casts

Introduce __rte_atomic qualifying casts in rte_optional atomics inline functions to prevent cascading the need to pass __rte_atomic qualified arguments. Warning, this is really implementation dependent and being done temporarily to avoid having to convert more of the libraries and tests in DPDK in

[PATCH v4 0/6] RFC optional rte optional stdatomics API

This series introduces API additions prefixed in the rte namespace that allow the optional use of stdatomics.h from C11 using enable_stdatomics=true for targets where enable_stdatomics=false no functional change is intended. Be aware this does not contain all changes to use stdatomics across the D

[PATCH v4 4/6] distributor: adapt for EAL optional atomics API changes

Adapt distributor for EAL optional atomics API changes Signed-off-by: Tyler Retzlaff Reviewed-by: Morten Brørup --- lib/distributor/distributor_private.h| 2 +- lib/distributor/rte_distributor_single.c | 44 2 files changed, 23 insertions(+), 23 deletions(-

[PATCH v4 2/6] eal: adapt EAL to present rte optional atomics API

Adapt the EAL public headers to use rte optional atomics API instead of directly using and exposing toolchain specific atomic builtin intrinsics. Signed-off-by: Tyler Retzlaff Reviewed-by: Morten Brørup --- app/test/test_mcslock.c| 6 ++-- lib/eal/arm/include/rte_atomic_32.h

[PATCH v4 5/6] bpf: adapt for EAL optional atomics API changes

Adapt bpf for EAL optional atomics API changes Signed-off-by: Tyler Retzlaff Reviewed-by: Morten Brørup --- lib/bpf/bpf_pkt.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/bpf/bpf_pkt.c b/lib/bpf/bpf_pkt.c index ffd2db7..7a8e4a6 100644 --- a/lib/bpf/bpf_pkt.c +++

[PATCH v4 6/6] devtools: forbid new direct use of GCC atomic builtins

Refrain from using compiler __atomic_xxx builtins DPDK now requires the use of rte_atomic__explicit macros when operating on DPDK atomic variables. Signed-off-by: Tyler Retzlaff Suggested-by: Morten Brørup Acked-by: Bruce Richardson Acked-by: Morten Brørup --- devtools/checkpatches.sh | 6 +++

[PATCH v5 2/4] build: determine execution environment at config time

Move execution environment determination and definitions to config. The RTE_EXEC_ENV macros are actually used by libraries built before EAL. Currently it does not matter that this is determined in lib/eal since the definitions are consumed before anything is built including libs built before lib/e

[PATCH v5 0/4] enable use of the MSVC compiler

Introduce minimum changes to the build system to allow use of the MSVC compiler. This change is intended to enable a phased approach to allowing DPDK to built with MSVC. Building with MSVC removes barriers to enterprise customers use of DPDK who have constraints around security policy, compliance

[PATCH v5 3/4] build: limit what is built when using MSVC compiler

Build only kvargs and telemetry when is_ms_compiler. Signed-off-by: Tyler Retzlaff Acked-by: Bruce Richardson --- app/meson.build | 4 drivers/meson.build | 4 lib/meson.build | 8 usertools/meson.build | 4 4 files changed, 20 insertions(+) diff --git a/a

[PATCH v5 4/4] build: enable MSVC specific compiler options

* Enable optional use of C11 atomics support. * Enable use of C23 typeof operator. * Explicitly force intrinsics when building with MSVC. * Disable MSVC C runtime checks. Signed-off-by: Tyler Retzlaff --- config/meson.build | 16 1 file changed, 16 insertions(+) diff --git a/co

[PATCH v5 1/4] build: unblock the use of the MSVC compiler

Detect when MSVC toolset is available and tweak toolchain arguments where the meson build system offers no abstraction. Signed-off-by: Tyler Retzlaff Acked-by: Bruce Richardson --- config/meson.build | 23 +++ config/x86/meson.build | 10 ++ lib/meson.build

Re: [PATCH v5 1/2] ethdev: remove bonding deprecated macro

在 2023/8/16 14:27, Chaoyong He 写道: From: Long Wu The macro RTE_ETH_DEV_BONDED_SLAVE was marked as deprecated in v23.07, we can remove it. Signed-off-by: Long Wu Reviewed-by: Chaoyong He --- doc/guides/rel_notes/deprecation.rst | 5 + doc/guides/rel_notes/release_23_11.rst | 2 ++

RE: [PATCH] net/virtio: fix the setting of the vector for link state interrupt

> -Original Message- > From: Ma, WenwuX > Sent: Monday, August 7, 2023 11:15 AM > To: maxime.coque...@redhat.com; dev@dpdk.org > Cc: Xia, Chenbo ; Ling, WeiX ; > Ma, WenwuX ; sta...@dpdk.org > Subject: [PATCH] net/virtio: fix the setting of the vector for link state > interrupt > > The se

[PATCH v5 00/10] support reinit flow

From: Sinan Kaya We want to be able to call rte_eal_init() and rte_eal_cleanup() APIs back to back for maintanance reasons. Here is a summary of the code we have seen so far: 1. some code support getting called multiple times by keeping a static variable. 2. some code initializes once but never

[PATCH v5 01/10] eal: cleanup plugins data

From: Stephen Hemminger When rte_eal_cleanup is called walk through the list of shared objects loaded, and close them and free the data structure. Signed-off-by: Stephen Hemminger Signed-off-by: Sinan Kaya --- lib/eal/common/eal_common_options.c | 14 ++ lib/eal/common/eal_options

[PATCH v5 02/10] eal: fixes for re-initialization issues

From: Graham Whyte reinitialize the solib link list and clean the globals holding state for parsing. Signed-off-by: Sinan Kaya Signed-off-by: Graham Whyte --- lib/eal/common/eal_common_options.c | 7 +++ lib/eal/linux/eal.c | 4 +++- 2 files changed, 10 insertions(+), 1 de

[PATCH v5 03/10] tailq: skip init if already initialized

From: Sinan Kaya Allows tailq to be reinitialied multiple times by looking up previously registered tailqs Signed-off-by: Sinan Kaya --- lib/eal/common/eal_common_tailqs.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/lib/eal/common/eal_common_tailqs

[PATCH v5 04/10] eal_memzone: bail out on initialized

From: Sinan Kaya Initialize memzone once and bail out if someone calls init multiple times. Signed-off-by: Sinan Kaya --- lib/eal/common/eal_common_memzone.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/lib/eal/common/eal_common_memzone.c b/lib/eal/common/eal_common_memzone.c ind

[PATCH v5 05/10] memseg: init once

From: Sinan Kaya Initialize memory segments just once and bail out if called multiple times. Signed-off-by: Sinan Kaya --- lib/eal/linux/eal_memory.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/lib/eal/linux/eal_memory.c b/lib/eal/linux/eal_memory.c index 9

[PATCH v5 06/10] eal_memory: skip initialization

From: Sinan Kaya Initialize heap area just once. Signed-off-by: Sinan Kaya --- lib/eal/common/eal_common_memory.c | 6 ++ lib/eal/common/malloc_heap.c | 7 +++ 2 files changed, 13 insertions(+) diff --git a/lib/eal/common/eal_common_memory.c b/lib/eal/common/eal_common_memory.c

[PATCH v5 07/10] eal_interrupts: don't reinitialize threads

From: Sinan Kaya Initialize interrupt thread once and keep a flag for further init. Signed-off-by: Sinan Kaya --- lib/eal/linux/eal_interrupts.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/lib/eal/linux/eal_interrupts.c b/lib/eal/linux/eal_interrupts.c index c9881143be..7adf4076a

[PATCH v5 08/10] eal: initialize worker threads once

From: Sinan Kaya Initialize worker threads once and keep a flag for other init calls. Signed-off-by: Sinan Kaya --- lib/eal/linux/eal.c | 60 - 1 file changed, 32 insertions(+), 28 deletions(-) diff --git a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c

[PATCH v5 09/10] eal: declare the reinit via cleanup/init feature unsupported

From: Sinan Kaya Call of rte_eal_init() api after rte_eal_cleanup() possible for certain application types but this is not an officially supported feature. Signed-off-by: Sinan Kaya --- lib/eal/include/rte_eal.h | 5 + 1 file changed, 5 insertions(+) diff --git a/lib/eal/include/rte_eal.h

[PATCH v5 10/10] test: remove double registration check

From: Sinan Kaya Code will fetch the existing registration when called for second time as part of the reinit changes. Registration will still succeed. Signed-off-by: Sinan Kaya --- app/test/test_tailq.c | 5 - 1 file changed, 5 deletions(-) diff --git a/app/test/test_tailq.c b/app/test/te

MLX5 PMD access ring library private data

Hi Matan, Viacheslav, Tyler pointed out that the function __mlx5_hws_cnt_pool_enqueue_revert is accessing the ring private structure members (prod.head and prod.tail) directly. Even though ' struct rte_ring' is a public structure (mainly because the library provides inline functions), th

[PATCH] eventdev/eth_rx: add new adapter create API

Add new API "rte_event_eth_rx_adapter_create_ext_with_params()" for creating Rx adapter instance. This API is similar to rte_event_eth_rx_adapter_create_ext() with an additional input argument for adapter configuration parameters of type "struct rte_event_eth_rx_adapter_params". Signed-off-by: Nag

  1   2   >