Patrick, Bruce, On Wed, Aug 16, 2023 at 2:57 PM Bruce Richardson <bruce.richard...@intel.com> wrote: > > On Tue, Aug 15, 2023 at 03:05:08PM -0400, Patrick Robb wrote: > > Adam from our team just raised something important about this patch and > > UNH CI which I missed during the RFC discussion. > > Presently, eal_flags_file_prefix_autotest fails on arm tx2 systems (arm > > people are aware of this, they think it might be a memory leak from
That's sad to read. > > mlx5 driver), so at their request we are disabling this unit test (on > > arm only) for them for the time being. If it was reported, I either missed it or forgot about it, sorry. Can you (re)share the context? There was a couple of mem leak fixes for mlx5 in v23.07. It may be worth running this test again and providing fresh traces. > > Does the test suite pass if the mlx5 driver is disabled in the build? That > could confirm or refute the suspicion of where the issue is, and also > provide a temporary workaround while this set is merged (possibly including > support for disabling specific tests, as I suggested in my other email). Or disabling the driver as Bruce proposes. > > /Bruce > > PS: Are there any other workarounds inside the test/DTS/CI systems that > involve patching sources? If so, it would be good to get a list that we can > work through removing by putting place proper fixes or workarounds, as > changing sources for testing like this blocks future patch acceptance. Patching sources from the test tool is a poor solution. In general, developers won't be aware of source patching and will waste time trying to understand why they can't reproduce what the CI reports (it happened to me with DTS on the interrupt stuff with vhost, at least). For this specific case of skipping a test, if nobody can fix the issue, I prefer if the CI can skip some "known broken in my lab" tests via some meson configuration. And, such configuration should be easy to catch in the test report. -- David Marchand
