[PATCH v3 00/15] net/cnxk: add MACsec support

2023-06-13 Thread Akhil Goyal
Added MACsec support in Marvell cnxk PMD. The patchset is pending from last release [1] Sending as a new series as the functionality is now complete and tested on hardware. [1] https://patches.dpdk.org/project/dpdk/cover/20220928124516.93050-1-gak...@marvell.com/ Changes in v3: - rebased - fixed

[PATCH v3 01/15] common/cnxk: add ROC MACsec initialization

2023-06-13 Thread Akhil Goyal
Added ROC init and fini APIs for supporting MACsec. Signed-off-by: Ankur Dwivedi Signed-off-by: Vamsi Attunuru Signed-off-by: Akhil Goyal --- drivers/common/cnxk/meson.build | 1 + drivers/common/cnxk/roc_api.h | 3 + drivers/common/cnxk/roc_features.h | 12 ++ drivers/common/c

[PATCH v3 02/15] common/cnxk: add MACsec SA configuration

2023-06-13 Thread Akhil Goyal
Added ROC APIs to allocate/free MACsec resources and APIs to write SA policy. Signed-off-by: Ankur Dwivedi Signed-off-by: Vamsi Attunuru Signed-off-by: Akhil Goyal --- drivers/common/cnxk/meson.build | 1 + drivers/common/cnxk/roc_mbox.h| 12 ++ drivers/common/cnxk/roc_mcs.h

[PATCH v3 03/15] common/cnxk: add MACsec SC configuration APIs

2023-06-13 Thread Akhil Goyal
Added ROC APIs to configure MACsec secure channel(SC) and its mapping with SAs for both Rx and Tx. Signed-off-by: Ankur Dwivedi Signed-off-by: Vamsi Attunuru Signed-off-by: Akhil Goyal --- drivers/common/cnxk/roc_mbox.h| 37 ++ drivers/common/cnxk/roc_mcs.h | 41 ++ d

[PATCH v3 04/15] common/cnxk: add MACsec secy and flow configuration

2023-06-13 Thread Akhil Goyal
Added ROC APIs to configure MACsec secy policy and flow entries. Signed-off-by: Ankur Dwivedi Signed-off-by: Vamsi Attunuru Signed-off-by: Akhil Goyal --- drivers/common/cnxk/roc_mbox.h| 38 + drivers/common/cnxk/roc_mcs.h | 37 + drivers/common/cnxk/roc_mcs_s

[PATCH v3 05/15] common/cnxk: add MACsec PN and LMAC mode configuration

2023-06-13 Thread Akhil Goyal
Added ROC APIs for setting packet number and LMAC related configurations. Signed-off-by: Ankur Dwivedi Signed-off-by: Vamsi Attunuru Signed-off-by: Akhil Goyal --- drivers/common/cnxk/roc_mbox.h| 56 + drivers/common/cnxk/roc_mcs.c | 71 +

[PATCH v3 06/15] common/cnxk: add MACsec stats

2023-06-13 Thread Akhil Goyal
Added ROC APIs for MACsec stats for SC/SECY/FLOW/PORT Signed-off-by: Ankur Dwivedi Signed-off-by: Vamsi Attunuru Signed-off-by: Akhil Goyal --- drivers/common/cnxk/meson.build | 1 + drivers/common/cnxk/roc_mbox.h | 93 ++ drivers/common/cnxk/roc_mcs.h | 85 +

[PATCH v3 07/15] common/cnxk: add MACsec interrupt APIs

2023-06-13 Thread Akhil Goyal
Added ROC APIs to support various MACsec interrupts. Signed-off-by: Ankur Dwivedi Signed-off-by: Vamsi Attunuru Signed-off-by: Akhil Goyal --- drivers/common/cnxk/roc_dev.c | 86 + drivers/common/cnxk/roc_mbox.h | 37 +++- drivers/common/cnxk/roc_mcs.c | 117

[PATCH v3 08/15] common/cnxk: add MACsec port configuration

2023-06-13 Thread Akhil Goyal
Added ROC APIs for MACsec port configurations Signed-off-by: Ankur Dwivedi Signed-off-by: Vamsi Attunuru Signed-off-by: Akhil Goyal --- drivers/common/cnxk/roc_mbox.h | 40 drivers/common/cnxk/roc_mcs.c | 346 drivers/common/cnxk/roc_mcs.h | 48

[PATCH v3 09/15] common/cnxk: add MACsec control port configuration

2023-06-13 Thread Akhil Goyal
Added ROC APIs to configure MACsec control port. Signed-off-by: Ankur Dwivedi Signed-off-by: Vamsi Attunuru Signed-off-by: Akhil Goyal --- drivers/common/cnxk/roc_mbox.h | 72 drivers/common/cnxk/roc_mcs.c | 117 drivers/common/cnxk/roc

[PATCH v3 10/15] common/cnxk: add MACsec FIPS mbox

2023-06-13 Thread Akhil Goyal
Added MACsec FIPS configuration mbox Signed-off-by: Ankur Dwivedi Signed-off-by: Vamsi Attunuru Signed-off-by: Akhil Goyal --- drivers/common/cnxk/roc_mbox.h | 74 ++ drivers/common/cnxk/roc_mcs.h | 69 +++ 2 files changed, 143 inser

[PATCH v3 11/15] common/cnxk: derive hash key for MACsec

2023-06-13 Thread Akhil Goyal
MACsec hardware configuration need hash key to be generated from the cipher key of AES-GCM-128/256. Added an ROC API to derive the hash key and extend the case for AES-256 as well. Signed-off-by: Akhil Goyal --- drivers/common/cnxk/roc_aes.c | 86 ++--- drivers/comm

[PATCH v3 12/15] net/cnxk: add MACsec initialization

2023-06-13 Thread Akhil Goyal
Added initialization routines for MACsec for cn10kb platform. Signed-off-by: Akhil Goyal --- drivers/net/cnxk/cn10k_ethdev_sec.c | 6 ++ drivers/net/cnxk/cnxk_ethdev.c | 13 +++ drivers/net/cnxk/cnxk_ethdev.h | 14 +++ drivers/net/cnxk/cnxk_ethdev_mcs.c | 151 +

[PATCH v3 13/15] net/cnxk: create/destroy MACsec SC/SA

2023-06-13 Thread Akhil Goyal
Added support to create/destroy MACsec SA and SC. Signed-off-by: Akhil Goyal --- drivers/net/cnxk/cn10k_ethdev_sec.c | 9 +- drivers/net/cnxk/cnxk_ethdev_mcs.c | 250 drivers/net/cnxk/cnxk_ethdev_mcs.h | 16 ++ 3 files changed, 271 insertions(+), 4 deletions(-)

[PATCH v3 14/15] net/cnxk: add MACsec session and flow configuration

2023-06-13 Thread Akhil Goyal
Added support for MACsec session/flow create/destroy. Signed-off-by: Akhil Goyal --- drivers/net/cnxk/cn10k_ethdev_sec.c | 11 +- drivers/net/cnxk/cn10k_flow.c | 23 ++- drivers/net/cnxk/cnxk_ethdev.c | 2 + drivers/net/cnxk/cnxk_ethdev.h | 16 ++ drivers/net/cnxk/cnxk_ethde

[PATCH v3 15/15] net/cnxk: add MACsec stats

2023-06-13 Thread Akhil Goyal
Added support for MACsec SC/flow/session stats. Signed-off-by: Akhil Goyal --- doc/guides/rel_notes/release_23_07.rst | 5 ++ drivers/net/cnxk/cn10k_ethdev_sec.c| 11 +++-- drivers/net/cnxk/cnxk_ethdev_mcs.c | 64 ++ drivers/net/cnxk/cnxk_ethdev_mcs.h | 9 ++

[PATCH] maintainers: update for PCI bus driver and library

2023-06-13 Thread Chenbo Xia
Add myself as maintainer of PCI bus driver and co-maintainer of PCI library. Signed-off-by: Chenbo Xia --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 906b31f97c..fea84b8cb9 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -586,6 +586,7 @@ F: dr

RE: [PATCH 1/2] net/mlx5/hws: removing the table name from dest root table

2023-06-13 Thread Slava Ovsiienko
> -Original Message- > From: Bar Neuman > Sent: Tuesday, June 13, 2023 8:28 AM > To: dev@dpdk.org > Cc: Ori Kam ; Raslan Darawsheh ; > Matan Azrad ; Slava Ovsiienko > ; Maayan Kashani ; Itamar > Gozlan > Subject: [PATCH 1/2] net/mlx5/hws: removing the table name from dest root > table >

RE: [PATCH 2/2] net/mlx5: add support for send to kernel over HWS

2023-06-13 Thread Slava Ovsiienko
> -Original Message- > From: Bar Neuman > Sent: Tuesday, June 13, 2023 8:28 AM > To: dev@dpdk.org > Cc: Ori Kam ; Raslan Darawsheh ; > Matan Azrad ; Slava Ovsiienko > ; Maayan Kashani > Subject: [PATCH 2/2] net/mlx5: add support for send to kernel over HWS > > Added hws send to kernel ac

RE: [EXT] [PATCH v5] app/dma-perf: introduce dma-perf application

2023-06-13 Thread Amit Prakash Shukla
Hi Cheng, My replies are inline. Thanks, Amit Shukla > -Original Message- > From: Jiang, Cheng1 > Sent: Tuesday, June 13, 2023 10:21 AM > To: Amit Prakash Shukla ; > tho...@monjalon.net; Richardson, Bruce ; > m...@smartsharesystems.com; Xia, Chenbo > Cc: dev@dpdk.org; Hu, Jiayu ; Ding

RE: [PATCH v11 00/16] graph enhancement for multi-core dispatch

2023-06-13 Thread Yan, Zhirun
> -Original Message- > From: David Marchand > Sent: Monday, June 12, 2023 10:56 PM > To: Yan, Zhirun > Cc: Jerin Jacob ; Thomas Monjalon > ; dev@dpdk.org; jer...@marvell.com; > kirankum...@marvell.com; ndabilpu...@marvell.com; > step...@networkplumber.org; pbhagavat...@marvell.com; Lian

[PATCH] net/e1000: fixed initialize queue number

2023-06-13 Thread Qiming Yang
The initialized queue number is not match the description in HW datasheet. Fixes: 805803445a02 ("e1000: support EM devices (also known as e1000/e1000e)") Cc: sta...@dpdk.org Signed-off-by: Qiming Yang --- drivers/net/e1000/em_ethdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) d

[PATCH] doc: add release note for new e1000 device

2023-06-13 Thread Qiming Yang
Signed-off-by: Qiming Yang --- doc/guides/rel_notes/release_23_07.rst | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/guides/rel_notes/release_23_07.rst b/doc/guides/rel_notes/release_23_07.rst index 027ae7bd2d..382dbfbe37 100644 --- a/doc/guides/rel_notes/release_23_07.rst +++ b/doc/

Re: [PATCH v1 1/1] doc: announce change in bbdev api related to operation extension

2023-06-13 Thread Maxime Coquelin
On 6/12/23 22:53, Chautru, Nicolas wrote: Hi Maxime, David, -Original Message- From: Maxime Coquelin On 6/6/23 23:01, Chautru, Nicolas wrote: Hi David, -Original Message- From: David Marchand > >> On Mon, Jun 5, 2023 at 10:08 PM Chautru, Nicolas wrote: Wrt the MLD func

[PATCH 0/4] Test examples compilation externally

2023-06-13 Thread David Marchand
As DPDK provides examples compiled with makefiles, we need some tests in the CI. So far, a few maintainers have been testing them but a simple issue has been missed for some time and there was no way to try to build all examples that were built with meson. Additionnally, this series can help in id

[PATCH 1/4] examples/fips_validation: fix external build

2023-06-13 Thread David Marchand
Added sources were not referenced in the makefile used when compiling this example externally. Fixes: 36128a67c27e ("examples/fips_validation: add asymmetric validation") Fixes: b455d261eb89 ("examples/fips_validation: validate ECDSA") Cc: sta...@dpdk.org Signed-off-by: David Marchand --- examp

[PATCH 2/4] examples/server_node_efd: simplify build configuration

2023-06-13 Thread David Marchand
Rename sub directories in this example. This removes the only special case in examples and will ease a next change. Signed-off-by: David Marchand --- doc/guides/sample_app_ug/server_node_efd.rst | 14 +++--- examples/meson.build | 4 ++-- examples/ser

[PATCH 3/4] devtools: build all examples externally

2023-06-13 Thread David Marchand
So far, users of test-meson-builds.sh had to define their own set of examples to build externally. This is not that great because users need to maintain this list when examples are removed/added. Rework the script so that the 'all' value triggers an automatic discovery based on what was configured

[PATCH 4/4] ci: build examples externally

2023-06-13 Thread David Marchand
Enhance our CI coverage by building examples against an installed DPDK. Signed-off-by: David Marchand --- .ci/linux-build.sh | 25 - .github/workflows/build.yml | 6 +++--- 2 files changed, 27 insertions(+), 4 deletions(-) diff --git a/.ci/linux-build.sh b/.ci/

RE: [PATCH] config/arm: add Ampere Altra/AltraMax/AmpereOne platform

2023-06-13 Thread Ruifeng Wang
> -Original Message- > From: Yutang Jiang > Sent: Monday, June 12, 2023 10:48 PM > To: Ruifeng Wang > Cc: Open Source Submission ; dev@dpdk.org; > Yutang Jiang OS > > Subject: RE: [PATCH] config/arm: add Ampere Altra/AltraMax/AmpereOne platform > > Hi Ruifeng, > > Please help me r

Re: [dpdk-dev] [PATCH v2] drivers/cnxk: improve the build time for non arm64 build

2023-06-13 Thread Jerin Jacob
On Mon, Jun 12, 2023 at 9:36 PM wrote: > > From: Jerin Jacob > > Specialized fast path routines are not applicable to non > arm64 build, removing those function contained > files to improve the build time on non arm64 build. > > Signed-off-by: Jerin Jacob > Acked-by: Nithin Dabilpuram Applied

[PATCH] net/cpfl: release memzone for rxq

2023-06-13 Thread beilei . xing
From: Beilei Xing Memzone of split Rx queue is not released, this commit fixes this issue. Fixes: c3f4af354506 ("net/cpfl: refine structures") Signed-off-by: Beilei Xing --- drivers/net/cpfl/cpfl_rxtx.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/cpfl/cpfl_rxtx.c b/drivers

Re: [PATCH] doc: add release note for new e1000 device

2023-06-13 Thread David Marchand
On Tue, Jun 13, 2023 at 10:13 AM Qiming Yang wrote: > > Signed-off-by: Qiming Yang > --- > doc/guides/rel_notes/release_23_07.rst | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/doc/guides/rel_notes/release_23_07.rst > b/doc/guides/rel_notes/release_23_07.rst > index 027ae7bd2d..382

Re: [PATCH v3] eal: add tracepoints to track lcores and services

2023-06-13 Thread David Marchand
Hello, On Fri, May 12, 2023 at 4:30 PM Arnaud Fiorini wrote: > > The tracepoints added are used to track lcore role and status, > as well as service mapping and service runstates. These > tracepoints are then used in analyses in Trace Compass. > > Signed-off-by: Arnaud Fiorini Harry, the majori

Re: [PATCH 3/4] devtools: build all examples externally

2023-06-13 Thread Bruce Richardson
On Tue, Jun 13, 2023 at 10:17:40AM +0200, David Marchand wrote: > So far, users of test-meson-builds.sh had to define their own set of > examples to build externally. This is not that great because users need > to maintain this list when examples are removed/added. > > Rework the script so that th

Re: [PATCH 0/4] Test examples compilation externally

2023-06-13 Thread Bruce Richardson
On Tue, Jun 13, 2023 at 10:17:37AM +0200, David Marchand wrote: > As DPDK provides examples compiled with makefiles, we need some tests in > the CI. So far, a few maintainers have been testing them but a simple > issue has been missed for some time and there was no way to try to build > all example

Re: [PATCH 3/4] devtools: build all examples externally

2023-06-13 Thread Bruce Richardson
On Tue, Jun 13, 2023 at 10:17:40AM +0200, David Marchand wrote: > So far, users of test-meson-builds.sh had to define their own set of > examples to build externally. This is not that great because users need > to maintain this list when examples are removed/added. > > Rework the script so that th

RE: [PATCH v3] net/ixgbe: add proper memory barriers for some Rx functions

2023-06-13 Thread Ruifeng Wang
> -Original Message- > From: Thomas Monjalon > Sent: Monday, June 12, 2023 8:45 PM > To: Ruifeng Wang ; Zhang, Qi Z ; > zhoumin > > Cc: dev@dpdk.org; m...@smartsharesystems.com; konstantin.v.anan...@yandex.ru; > Yang, Qiming > ; Wu, Wenjun1 ; > d...@linux.vnet.ibm.com; > roret...@linux

[PATCH v2 1/3] event/cnxk: align TX queue buffer adjustment

2023-06-13 Thread pbhagavatula
From: Pavan Nikhilesh Remove recalculating SQB thresholds in Tx queue buffer adjustment. The adjustment is already done during Tx queue setup. Signed-off-by: Pavan Nikhilesh --- v2 Changes: - Rebase on ToT. drivers/event/cnxk/cn10k_eventdev.c | 9 + drivers/event/cnxk/cn10k_tx_wor

[PATCH v2 2/3] event/cnxk: use local labels in asm intrinsic

2023-06-13 Thread pbhagavatula
From: Pavan Nikhilesh Using labels in asm generates them as regular function and shades callstack in tools like gdb or perf. Use local label instead for better visibility. Signed-off-by: Pavan Nikhilesh --- drivers/event/cnxk/cn10k_worker.h| 8 ++--- drivers/event/cnxk/cn9k_worker.h |

[PATCH v2 3/3] event/cnxk: use WFE in Tx fc wait

2023-06-13 Thread pbhagavatula
From: Pavan Nikhilesh Use WFE is Tx path when waiting for space in the Tx queue. Depending upon the Tx queue contention and size, WFE will reduce the cache pressure and power consumption. In multi-core scenarios we have observed up to 8W power reduction. Signed-off-by: Pavan Nikhilesh --- driv

Re: [PATCH 3/4] devtools: build all examples externally

2023-06-13 Thread David Marchand
On Tue, Jun 13, 2023 at 11:21 AM Bruce Richardson wrote: > > On Tue, Jun 13, 2023 at 10:17:40AM +0200, David Marchand wrote: > > So far, users of test-meson-builds.sh had to define their own set of > > examples to build externally. This is not that great because users need > > to maintain this lis

[PATCH v4] net/ixgbe: add proper memory barriers for some Rx functions

2023-06-13 Thread Min Zhou
Segmentation fault has been observed while running the ixgbe_recv_pkts_lro() function to receive packets on the Loongson 3C5000 processor which has 64 cores and 4 NUMA nodes. >From the ixgbe_recv_pkts_lro() function, we found that as long as the first packet has the EOP bit set, and the length of

Re: [dpdk-dev] [PATCH v3] net/cnxk: support port ID flow action item

2023-06-13 Thread Jerin Jacob
On Tue, Jun 13, 2023 at 10:27 AM wrote: > > From: Satheesh Paul > > Currently PORT_ID action can redirect traffic only between > VFs of a PF. This patch extends PORT_ID action to redirect > traffic from one PF port to another PF port also. > > Signed-off-by: Satheesh Paul > Reviewed-by: Kiran Ku

Re: [PATCH 15/15] net/cnxk: add MACsec stats

2023-06-13 Thread Jerin Jacob
On Wed, May 24, 2023 at 1:35 AM Akhil Goyal wrote: > > Added support for MACsec SC/flow/session stats. > > Signed-off-by: Akhil Goyal # Please fix the the build issue http://mails.dpdk.org/archives/test-report/2023-June/410104.html # Please rebase to dpdk-next-mrvl as doc is updated in https://

Re: [PATCH v14 0/6] introduce memarea library

2023-06-13 Thread fengchengwen
Hi Ferruh, On 2023/6/12 21:53, Ferruh Yigit wrote: > On 2/9/2023 6:36 AM, Chengwen Feng wrote: >> The memarea library is an allocator of variable-size object which based >> on a memory region. The main features are as follows: >> >> - The memory region can be initialized from the following memory

Re: [Bug 1249] [dpdk-23.07] ixgbe port stop failed after launch testpmd

2023-06-13 Thread David Marchand
Hello, On Mon, Jun 12, 2023 at 6:32 PM Tyler Retzlaff wrote: > If there has been a broad regression here could I ask for your help in > either reverting it until I can look at it properly or if you see the > obvious problem fixing it. > > There were multiple instances of flags being converted to

RE: [PATCH v3] eal: add tracepoints to track lcores and services

2023-06-13 Thread Van Haaren, Harry
> -Original Message- > From: David Marchand > Sent: Tuesday, June 13, 2023 9:39 AM > To: Arnaud Fiorini ; Van Haaren, Harry > > Cc: Thomas Monjalon ; Jerin Jacob > ; Sunil Kumar Kori ; dev@dpdk.org > Subject: Re: [PATCH v3] eal: add tracepoints to track lcores and services > > Hello, Hi

Re: [PATCH v3] net/ixgbe: add proper memory barriers for some Rx functions

2023-06-13 Thread zhoumin
Hi Jiawen, On Tues, June 13, 2023 at 11:30PM, Jiawen Wu wrote: On Tuesday, June 13, 2023 9:43 AM, zhoumin wrote: On Mon, June 12, 2023 at 8:44PM, Thomas Monjalon wrote: 12/06/2023 13:58, zhoumin: On Mon, June 12, 2023 at 6:26PM, Thomas Monjalon wrote: 15/05/2023 04:10, Zhang, Qi Z: From: Ru

[PATCH v4 00/15] net/cnxk: add MACsec support

2023-06-13 Thread Akhil Goyal
Added MACsec support in Marvell cnxk PMD. The patchset is pending from last release [1] Sending as a new series as the functionality is now complete and tested on hardware. [1] https://patches.dpdk.org/project/dpdk/cover/20220928124516.93050-1-gak...@marvell.com/ Changes in v4: Fix build with RH

[PATCH v4 01/15] common/cnxk: add ROC MACsec initialization

2023-06-13 Thread Akhil Goyal
Added ROC init and fini APIs for supporting MACsec. Signed-off-by: Ankur Dwivedi Signed-off-by: Vamsi Attunuru Signed-off-by: Akhil Goyal --- drivers/common/cnxk/meson.build | 1 + drivers/common/cnxk/roc_api.h | 3 + drivers/common/cnxk/roc_features.h | 12 ++ drivers/common/c

[PATCH v4 02/15] common/cnxk: add MACsec SA configuration

2023-06-13 Thread Akhil Goyal
Added ROC APIs to allocate/free MACsec resources and APIs to write SA policy. Signed-off-by: Ankur Dwivedi Signed-off-by: Vamsi Attunuru Signed-off-by: Akhil Goyal --- drivers/common/cnxk/meson.build | 1 + drivers/common/cnxk/roc_mbox.h| 12 ++ drivers/common/cnxk/roc_mcs.h

[PATCH v4 03/15] common/cnxk: add MACsec SC configuration APIs

2023-06-13 Thread Akhil Goyal
Added ROC APIs to configure MACsec secure channel(SC) and its mapping with SAs for both Rx and Tx. Signed-off-by: Ankur Dwivedi Signed-off-by: Vamsi Attunuru Signed-off-by: Akhil Goyal --- drivers/common/cnxk/roc_mbox.h| 37 ++ drivers/common/cnxk/roc_mcs.h | 41 ++ d

[PATCH v4 04/15] common/cnxk: add MACsec secy and flow configuration

2023-06-13 Thread Akhil Goyal
Added ROC APIs to configure MACsec secy policy and flow entries. Signed-off-by: Ankur Dwivedi Signed-off-by: Vamsi Attunuru Signed-off-by: Akhil Goyal --- drivers/common/cnxk/roc_mbox.h| 38 + drivers/common/cnxk/roc_mcs.h | 37 + drivers/common/cnxk/roc_mcs_s

[PATCH v4 05/15] common/cnxk: add MACsec PN and LMAC mode configuration

2023-06-13 Thread Akhil Goyal
Added ROC APIs for setting packet number and LMAC related configurations. Signed-off-by: Ankur Dwivedi Signed-off-by: Vamsi Attunuru Signed-off-by: Akhil Goyal --- drivers/common/cnxk/roc_mbox.h| 56 + drivers/common/cnxk/roc_mcs.c | 71 +

[PATCH v4 06/15] common/cnxk: add MACsec stats

2023-06-13 Thread Akhil Goyal
Added ROC APIs for MACsec stats for SC/SECY/FLOW/PORT Signed-off-by: Ankur Dwivedi Signed-off-by: Vamsi Attunuru Signed-off-by: Akhil Goyal --- drivers/common/cnxk/meson.build | 1 + drivers/common/cnxk/roc_mbox.h | 93 ++ drivers/common/cnxk/roc_mcs.h | 85 +

RE: [PATCH v4] net/ixgbe: add proper memory barriers for some Rx functions

2023-06-13 Thread Ruifeng Wang
> -Original Message- > From: Min Zhou > Sent: Tuesday, June 13, 2023 5:44 PM > To: tho...@monjalon.net; qi.z.zh...@intel.com; m...@smartsharesystems.com; > konstantin.v.anan...@yandex.ru; Ruifeng Wang ; > d...@linux.vnet.ibm.com; roret...@linux.microsoft.com; qiming.y...@intel.com; > wenju

[PATCH v4 07/15] common/cnxk: add MACsec interrupt APIs

2023-06-13 Thread Akhil Goyal
Added ROC APIs to support various MACsec interrupts. Signed-off-by: Ankur Dwivedi Signed-off-by: Vamsi Attunuru Signed-off-by: Akhil Goyal --- drivers/common/cnxk/roc_dev.c | 86 + drivers/common/cnxk/roc_mbox.h | 37 +++- drivers/common/cnxk/roc_mcs.c | 117

[PATCH v4 08/15] common/cnxk: add MACsec port configuration

2023-06-13 Thread Akhil Goyal
Added ROC APIs for MACsec port configurations Signed-off-by: Ankur Dwivedi Signed-off-by: Vamsi Attunuru Signed-off-by: Akhil Goyal --- drivers/common/cnxk/roc_mbox.h | 40 drivers/common/cnxk/roc_mcs.c | 346 drivers/common/cnxk/roc_mcs.h | 48

[PATCH v4 09/15] common/cnxk: add MACsec control port configuration

2023-06-13 Thread Akhil Goyal
Added ROC APIs to configure MACsec control port. Signed-off-by: Ankur Dwivedi Signed-off-by: Vamsi Attunuru Signed-off-by: Akhil Goyal --- drivers/common/cnxk/roc_mbox.h | 72 drivers/common/cnxk/roc_mcs.c | 117 drivers/common/cnxk/roc

[PATCH v4 10/15] common/cnxk: add MACsec FIPS mbox

2023-06-13 Thread Akhil Goyal
Added MACsec FIPS configuration mbox Signed-off-by: Ankur Dwivedi Signed-off-by: Vamsi Attunuru Signed-off-by: Akhil Goyal --- drivers/common/cnxk/roc_mbox.h | 74 ++ drivers/common/cnxk/roc_mcs.h | 69 +++ 2 files changed, 143 inser

[PATCH v4 11/15] common/cnxk: derive hash key for MACsec

2023-06-13 Thread Akhil Goyal
MACsec hardware configuration need hash key to be generated from the cipher key of AES-GCM-128/256. Added an ROC API to derive the hash key and extend the case for AES-256 as well. Signed-off-by: Akhil Goyal --- drivers/common/cnxk/roc_aes.c | 86 ++--- drivers/comm

[PATCH v4 12/15] net/cnxk: add MACsec initialization

2023-06-13 Thread Akhil Goyal
Added initialization routines for MACsec for cn10kb platform. Signed-off-by: Akhil Goyal --- drivers/net/cnxk/cn10k_ethdev_sec.c | 6 ++ drivers/net/cnxk/cnxk_ethdev.c | 13 +++ drivers/net/cnxk/cnxk_ethdev.h | 14 +++ drivers/net/cnxk/cnxk_ethdev_mcs.c | 151 +

[PATCH v4 13/15] net/cnxk: create/destroy MACsec SC/SA

2023-06-13 Thread Akhil Goyal
Added support to create/destroy MACsec SA and SC. Signed-off-by: Akhil Goyal --- drivers/net/cnxk/cn10k_ethdev_sec.c | 9 +- drivers/net/cnxk/cnxk_ethdev_mcs.c | 253 drivers/net/cnxk/cnxk_ethdev_mcs.h | 16 ++ 3 files changed, 274 insertions(+), 4 deletions(-)

[PATCH v4 14/15] net/cnxk: add MACsec session and flow configuration

2023-06-13 Thread Akhil Goyal
Added support for MACsec session/flow create/destroy. Signed-off-by: Akhil Goyal --- drivers/net/cnxk/cn10k_ethdev_sec.c | 11 +- drivers/net/cnxk/cn10k_flow.c | 23 ++- drivers/net/cnxk/cnxk_ethdev.c | 2 + drivers/net/cnxk/cnxk_ethdev.h | 16 ++ drivers/net/cnxk/cnxk_ethde

[PATCH v4 15/15] net/cnxk: add MACsec stats

2023-06-13 Thread Akhil Goyal
Added support for MACsec SC/flow/session stats. Signed-off-by: Akhil Goyal --- doc/guides/rel_notes/release_23_07.rst | 5 ++ drivers/net/cnxk/cn10k_ethdev_sec.c| 11 +++-- drivers/net/cnxk/cnxk_ethdev_mcs.c | 64 ++ drivers/net/cnxk/cnxk_ethdev_mcs.h | 9 ++

[PATCH v13 00/16] graph enhancement for multi-core dispatch

2023-06-13 Thread Zhirun Yan
V13: Add sub header into meson indirect_headers list to export.(change meson.build in patch02, 05) V12: Fix compilation broken at patch 1.(keep renamed header align with patch 1,2) V11: Update comments and fix to add experimental flags for rte_graph_model_is_valid() in patch 04. Update added sy

[PATCH v13 01/16] graph: rename rte_graph_work as common

2023-06-13 Thread Zhirun Yan
Rename rte_graph_work.h to rte_graph_work_common.h for supporting multiple graph worker model. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan Acked-by: Jerin Jacob --- MAINTAINERS | 3 ++- app/test/test_graph.c

[PATCH v13 02/16] graph: split graph worker into common and default model

2023-06-13 Thread Zhirun Yan
To support multiple graph worker model, split graph into common and default. Naming the current walk function as rte_graph_model_rtc cause the default model is RTC(Run-to-completion). Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan Acked-by: Jerin Jacob --- a

[PATCH v13 03/16] graph: move node process into inline function

2023-06-13 Thread Zhirun Yan
Node process is a single and reusable block, move the code into an inline function. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan Acked-by: Jerin Jacob --- lib/graph/rte_graph_model_rtc.h | 20 ++--- lib/graph/rte_graph_worker_common.h | 33

[PATCH v13 04/16] graph: add get/set graph worker model APIs

2023-06-13 Thread Zhirun Yan
Add new get/set APIs to configure graph worker model which is used to determine which model will be chosen. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan Acked-by: Jerin Jacob --- lib/graph/meson.build | 1 + lib/graph/rte_graph_worker.c

[PATCH v13 05/16] graph: introduce graph node core affinity API

2023-06-13 Thread Zhirun Yan
Add lcore_id for node to hold affinity core id and impl rte_graph_model_mcore_dispatch_lcore_affinity_set to set node affinity with specific lcore. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan Acked-by: Jerin Jacob --- lib/graph/graph_private.h

[PATCH v13 06/16] graph: introduce graph bind unbind API

2023-06-13 Thread Zhirun Yan
Add lcore_id for graph to hold affinity core id where graph would run on. Add bind/unbind API to set/unset graph affinity attribute. lcore_id will be set as MAX by default, it means not enable this attribute. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan Acke

[PATCH v13 07/16] graph: move node clone name func into private as common

2023-06-13 Thread Zhirun Yan
Move clone_name() into graph_private.h as a common function for both node and graph to naming a new cloned object. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan Acked-by: Jerin Jacob --- lib/graph/graph_private.h | 41 +++

[PATCH v13 08/16] graph: introduce graph clone API for other worker core

2023-06-13 Thread Zhirun Yan
This patch adds graph API for supporting to clone the graph object for a specified worker core. The new graph will also clone all nodes. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan Acked-by: Jerin Jacob --- lib/graph/graph.c | 89 +

[PATCH v13 09/16] graph: add structure for stream moving between cores

2023-06-13 Thread Zhirun Yan
Add graph_mcore_dispatch_wq_node to hold graph scheduling workqueue node. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan --- lib/graph/graph.c | 2 ++ lib/graph/graph_populate.c | 1 + lib/graph/graph_private.h | 12

[PATCH v13 10/16] graph: introduce stream moving cross cores

2023-06-13 Thread Zhirun Yan
This patch introduces key functions to allow a worker thread to enable enqueue and move streams of objects to the next nodes over different cores for mcore dispatch model. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan Acked-by: Pavan Nikhilesh --- lib/graph

[PATCH v13 11/16] graph: enable create and destroy graph scheduling workqueue

2023-06-13 Thread Zhirun Yan
This patch enables to create and destroy scheduling workqueue into common graph operations. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan Acked-by: Pavan Nikhilesh --- lib/graph/graph.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/lib/gra

[PATCH v13 12/16] graph: introduce graph walk by cross-core dispatch

2023-06-13 Thread Zhirun Yan
This patch introduces the task scheduler mechanism to enable dispatching tasks to another worker cores. Currently, there is only a local work queue for one graph to walk. We introduce a scheduler worker queue in each worker core for dispatching tasks. It will perform the walk on scheduler work queu

[PATCH v13 13/16] graph: enable graph multicore dispatch scheduler model

2023-06-13 Thread Zhirun Yan
This patch enables to chose new scheduler model. Must define RTE_GRAPH_MODEL_SELECT before including rte_graph_worker.h to enable specific model choosing. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan Acked-by: Jerin Jacob Acked-by: Pavan Nikhilesh --- doc

[PATCH v13 14/16] graph: add stats for mcore dispatch model

2023-06-13 Thread Zhirun Yan
Add stats for mcore dispatch model if stats collection is enabled. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan Acked-by: Jerin Jacob Acked-by: Pavan Nikhilesh --- lib/graph/graph_debug.c| 6 ++ lib/graph/graph_stats.c

[PATCH v13 15/16] test/graph: add functional tests for mcore dispatch model

2023-06-13 Thread Zhirun Yan
Add functional test for mcore dispatch model including graph clone, graph model set/get, node worker affinity, graph worker binding/unbinding. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan Acked-by: Pavan Nikhilesh --- app/test/test_graph.c | 130 ++

[PATCH v13 16/16] examples/l3fwd-graph: introduce mcore dispatch worker model

2023-06-13 Thread Zhirun Yan
Add new parameter "model" to choose mcore dispatch or rtc model. And in dispatch model, the node will affinity to worker core successively. RTE_GRAPH_MODEL_SELECT is set to RTE_GRAPH_MODEL_RTC by default. Must set model the same as RTE_GRAPH_MODEL_SELECT if set it as rtc or mcore dispatch explicit

Re: [PATCH] eal: fix prompt info when remap_segment failed

2023-06-13 Thread Burakov, Anatoly
On 5/29/2023 12:21 PM, Fengnan Chang wrote: when there is enough space for memseg, we should pormpt which config to modify, not just print numbers. Signed-off-by: Fengnan Chang --- lib/eal/linux/eal_memory.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/lib/eal/lin

Re: [PATCH v14 0/6] introduce memarea library

2023-06-13 Thread Burakov, Anatoly
On 6/13/2023 10:50 AM, fengchengwen wrote: Hi Ferruh, On 2023/6/12 21:53, Ferruh Yigit wrote: On 2/9/2023 6:36 AM, Chengwen Feng wrote: The memarea library is an allocator of variable-size object which based on a memory region. The main features are as follows: - The memory region can be init

Re: [PATCH 2/4] examples/server_node_efd: simplify build configuration

2023-06-13 Thread David Marchand
On Tue, Jun 13, 2023 at 10:18 AM David Marchand wrote: > diff --git a/doc/guides/sample_app_ug/server_node_efd.rst > b/doc/guides/sample_app_ug/server_node_efd.rst > index c6cbc3def6..7253b38da7 100644 > --- a/doc/guides/sample_app_ug/server_node_efd.rst > +++ b/doc/guides/sample_app_ug/server_no

Re: [PATCH v13 00/16] graph enhancement for multi-core dispatch

2023-06-13 Thread Jerin Jacob
On Tue, Jun 13, 2023 at 3:53 PM Zhirun Yan wrote: > > V13: > Add sub header into meson indirect_headers list to export.(change meson.build > in patch02, 05) Please rebase with dpdk.org/main. There are build issues now also make sure monitor CI after pushing the patches. [569/2998] Compiling C

RE: [PATCH v13 00/16] graph enhancement for multi-core dispatch

2023-06-13 Thread Yan, Zhirun
> -Original Message- > From: Jerin Jacob > Sent: Tuesday, June 13, 2023 7:13 PM > To: Yan, Zhirun > Cc: dev@dpdk.org; jer...@marvell.com; kirankum...@marvell.com; > ndabilpu...@marvell.com; step...@networkplumber.org; > pbhagavat...@marvell.com; david.march...@redhat.com; Liang, Cunming

RE: [PATCH v4] net/ixgbe: add proper memory barriers for some Rx functions

2023-06-13 Thread Zhang, Qi Z
> -Original Message- > From: Ruifeng Wang > Sent: Tuesday, June 13, 2023 6:20 PM > To: Min Zhou ; tho...@monjalon.net; Zhang, Qi Z > ; m...@smartsharesystems.com; > konstantin.v.anan...@yandex.ru; d...@linux.vnet.ibm.com; > roret...@linux.microsoft.com; Yang, Qiming ; Wu, > Wenjun1 > C

Re: [PATCH v14 0/6] introduce memarea library

2023-06-13 Thread fengchengwen
On 2023/6/13 19:04, Burakov, Anatoly wrote: > On 6/13/2023 10:50 AM, fengchengwen wrote: >> Hi Ferruh, >> >> On 2023/6/12 21:53, Ferruh Yigit wrote: >>> On 2/9/2023 6:36 AM, Chengwen Feng wrote: The memarea library is an allocator of variable-size object which based on a memory region. Th

Re: [PATCH v6] app/dma-perf: introduce dma-perf application

2023-06-13 Thread huangdengdui
Hi Cheng, Few comments inline. Please check. Thanks, Dengdui On 2023/6/13 12:31, Cheng Jiang wrote: > There are many high-performance DMA devices supported in DPDK now, and > these DMA devices can also be integrated into other modules of DPDK as > accelerators, such as Vhost. Before integrating

Re: [PATCH] ethdev: prefer offload names in logs

2023-06-13 Thread David Marchand
On Wed, May 17, 2023 at 4:53 PM Ferruh Yigit wrote: > > On 3/9/2023 4:21 PM, Stephen Hemminger wrote: > > On Thu, 9 Mar 2023 09:16:33 +0100 > > David Marchand wrote: > > > >> +RTE_ETHDEV_LOG(ERR, "Ethdev port_id=%u requested Rx offloads > >> '%s' in %s(). " > >> +

[PATCH v2] ethdev: prefer offload names in logs

2023-06-13 Thread David Marchand
Displaying a bitmask is terrible for users. Prefer offload names when refusing some offloads in rte_eth_dev_configure. Before: Ethdev port_id=0 requested Rx offloads 0x621 doesn't match Rx offloads capabilities 0x0 in rte_eth_dev_configure() After: Ethdev port_id=0 does not support Rx off

Re: [PATCH v2 1/2] build: change flag variable type to boolean

2023-06-13 Thread David Marchand
On Mon, Jun 12, 2023 at 7:15 PM Bruce Richardson wrote: > > The has_libnuma flag was using 0 and 1 integer values, instead of the > more appropriate boolean type. Change to use true/false instead. > > Signed-off-by: Bruce Richardson This patch lgtm (with or without the suggestion on config/arm b

Re: [PATCH v2 2/2] build: prevent accidentally building without NUMA support

2023-06-13 Thread David Marchand
On Mon, Jun 12, 2023 at 7:59 PM Bruce Richardson wrote: > > On Mon, Jun 12, 2023 at 06:14:56PM +0100, Bruce Richardson wrote: > > When libnuma development package is missing on a system, DPDK can still > > be built but will be missing much-needed support for NUMA memory > > management. This may la

Re: [PATCH v2 1/2] build: change flag variable type to boolean

2023-06-13 Thread Bruce Richardson
On Tue, Jun 13, 2023 at 03:43:34PM +0200, David Marchand wrote: > On Mon, Jun 12, 2023 at 7:15 PM Bruce Richardson > wrote: > > > > The has_libnuma flag was using 0 and 1 integer values, instead of the > > more appropriate boolean type. Change to use true/false instead. > > > > Signed-off-by: Bruc

[PATCH] mailmap: update contributor entry

2023-06-13 Thread Ivan Malov
Signed-off-by: Ivan Malov --- .mailmap | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.mailmap b/.mailmap index 8e3940a253..d97cdc670c 100644 --- a/.mailmap +++ b/.mailmap @@ -105,7 +105,7 @@ Andriy Berestovskyy Andrzej Ostruszka Andy Gospodarek Andy Green -Andy Mo

[PATCH v2 0/4] Test examples compilation externally

2023-06-13 Thread David Marchand
As DPDK provides examples compiled with makefiles, we need some tests in the CI. So far, a few maintainers have been testing them but a simple issue has been missed for some time and there was no way to try to build all examples that were built with meson. Additionnally, this series can help in id

[PATCH v2 3/4] devtools: build all examples externally

2023-06-13 Thread David Marchand
So far, users of test-meson-builds.sh had to define their own set of examples to build externally. This is not that great because users need to maintain this list when examples are removed/added. Rework the script so that the 'all' value triggers an automatic discovery based on what was configured

[PATCH v2 4/4] ci: build examples externally

2023-06-13 Thread David Marchand
Enhance our CI coverage by building examples against an installed DPDK. Signed-off-by: David Marchand Acked-by: Bruce Richardson --- Changes since v1: - reworked built examples discovery, - added comment for people who are not sed fluent, --- .ci/linux-build.sh | 27 ++

  1   2   >