On Mon, Jun 12, 2023 at 7:15 PM Bruce Richardson
<bruce.richard...@intel.com> wrote:
>
> The has_libnuma flag was using 0 and 1 integer values, instead of the
> more appropriate boolean type. Change to use true/false instead.
>
> Signed-off-by: Bruce Richardson <bruce.richard...@intel.com>
This patch lgtm (with or without the suggestion on config/arm below).
Reviewed-by: David Marchand <david.march...@redhat.com>
[snip]
> diff --git a/config/arm/meson.build b/config/arm/meson.build
> index 43f6a551a2..faba5e38cf 100644
> --- a/config/arm/meson.build
> +++ b/config/arm/meson.build
> @@ -592,7 +592,7 @@ if update_flags
> part_number = soc_config['part_number']
> soc_flags = soc_config.get('flags', [])
> if not soc_config.get('numa', true)
> - has_libnuma = 0
> + has_libnuma = false
> endif
Maybe has_libnuma = soc_config.get('numa', true) ?
>
> disable_drivers += ',' + soc_config.get('disable_drivers', '')
The same cleanup could be done to has_libfdt.
Additionnally, I wonder if we could remove those "== true" or "==
false" checks here and there in meson.build files.
--
David Marchand
