Re: [PATCH v4 0/4] Support VFIO sparse mmap in PCI bus

2023-06-08 Thread David Marchand
Hello Chenbo, Patrick, On Thu, Jun 8, 2023 at 8:50 AM Xia, Chenbo wrote: > > > This series introduces a VFIO standard capability, called sparse > > > mmap to PCI bus. In linux kernel, it's defined as > > > VFIO_REGION_INFO_CAP_SPARSE_MMAP. Sparse mmap means instead of > > > mmap whole BAR region

RE: [PATCH v9 13/17] graph: enable graph multicore dispatch scheduler model

2023-06-08 Thread Yan, Zhirun
> -Original Message- > From: Jerin Jacob > Sent: Thursday, June 8, 2023 1:34 PM > To: Yan, Zhirun > Cc: dev@dpdk.org; jer...@marvell.com; kirankum...@marvell.com; > ndabilpu...@marvell.com; step...@networkplumber.org; > pbhagavat...@marvell.com; Liang, Cunming ; Wang, > Haiyue ; mattias

Re: [PATCH v1] event/dlb2: add support for disabling PASID

2023-06-08 Thread Thomas Monjalon
08/06/2023 07:38, Jerin Jacob: > On Thu, Jun 8, 2023 at 2:31 AM Abdullah Sevincer > wrote: > > > > vfio-pci driver in Linux kernel 6.2 enables PASID by default. > > In DLB hardware, enabling PASID puts DLB in SIOV mode. This > > breaks DLB PF-PMD mode. For DLB PF-PMD mode to function properly > >

[PATCH v2] eal/linux: register mp hotplug callback after memory init

2023-06-08 Thread Zhihong Wang
Secondary would crash if it tries to handle mp requests before memory init, since globals such as eth_dev_shared_data_lock are not accessible to it at this moment. v2: add signed-off-by Signed-off-by: Zhihong Wang Acked-by: Anatoly Burakov --- lib/eal/linux/eal.c | 12 ++-- 1 file chan

[PATCH] config/arm: fix Neoverse N2 march flag

2023-06-08 Thread pbhagavatula
From: Pavan Nikhilesh The -march flag of Neoverse N2 should be `armv9-a` when used along with -mcpu=neoverse-n2. Fixes: ea85ed1f6882 ("config/arm: increase nodes and cores for Neoverse N2") Signed-off-by: Pavan Nikhilesh --- config/arm/meson.build | 4 ++-- 1 file changed, 2 insertions(+), 2

Re: [PATCH v1] event/dlb2: add support for disabling PASID

2023-06-08 Thread David Marchand
On Thu, Jun 8, 2023 at 7:38 AM Jerin Jacob wrote: > > On Thu, Jun 8, 2023 at 2:31 AM Abdullah Sevincer > wrote: > > > > vfio-pci driver in Linux kernel 6.2 enables PASID by default. > > In DLB hardware, enabling PASID puts DLB in SIOV mode. This > > breaks DLB PF-PMD mode. For DLB PF-PMD mode to

Re: [External] Re: [PATCH] eal/linux: register mp hotplug callback after memory init

2023-06-08 Thread 王志宏
Done. Thanks :) From: "David Marchand" Date: Thu, Jun 8, 2023, 04:21 Subject: [External] Re: [PATCH] eal/linux: register mp hotplug callback after memory init To: "Zhihong Wang" Cc: , , Hello Zhihong, On Wed, May 31, 2023 at 8:55 AM Zhihong Wang wrote: > > Secondary would crash if it tries to

[PATCH] cryptodev: avoid algorithm strings null pointers

2023-06-08 Thread xixin.liu
The crypto algorithm strings identifiers that are Continuous may be null, so there is needed to add null judgment. When testing with dpdk-test-crypto-perf and passing in the parameter --auth-algo sm3-hmac, The program caused a segfault due to a null pointer passed in by strcmp. Adding this patch ca

[PATCH] bus/pci: fix missing MMIO APIs in Windows

2023-06-08 Thread Chenbo Xia
MMIO read and write APIs were defined in PCI bus. But the corresponding implementations are not done in windows. This patch fixes this. Bugzilla ID: 1245 Fixes: 095cf6e68b28 ("bus/pci: introduce MMIO read/write") Cc: sta...@dpdk.org Signed-off-by: Chenbo Xia --- drivers/bus/pci/windows/pci.c |

Re: [PATCH v2] eal/linux: register mp hotplug callback after memory init

2023-06-08 Thread David Marchand
On Thu, Jun 8, 2023 at 9:26 AM Zhihong Wang wrote: > > Secondary would crash if it tries to handle mp requests before memory > init, since globals such as eth_dev_shared_data_lock are not accessible > to it at this moment. > > Signed-off-by: Zhihong Wang > Acked-by: Anatoly Burakov Forgot to me

[PATCH] net/bonding: fix iavf bond device query stats

2023-06-08 Thread Kaiwen Deng
If the rte_eth_stats_get function does not work properly, the update function of the slave device does not work properly When device is bonded as BONDING_MODE_TLB mode. This commit adds handling for functions that do not get stats properly. Fixes: 7c76a747e68c ("bond: add mode 5") Cc: sta...@dpdk

[PATCH] net/iavf: fix virtchnl cmd called in intr thread

2023-06-08 Thread Kaiwen Deng
When iavf send virtchnl command in eal-intr-thread, there will be no response received from iavf_dev_virtchnl_handler for this command during block and wait. Because iavf_dev_virtchnl_handler is also registered in eal-intr-thread. This commit add to poll the response for virtchnl command when it i

RE: [PATCH v4] app/dma-perf: introduce dma-perf application

2023-06-08 Thread Xia, Chenbo
> -Original Message- > From: Jiang, Cheng1 > Sent: Thursday, June 8, 2023 1:03 PM > To: tho...@monjalon.net; Richardson, Bruce ; > m...@smartsharesystems.com; Xia, Chenbo > Cc: dev@dpdk.org; Hu, Jiayu ; Ding, Xuan > ; Ma, WenwuX ; Wang, YuanX > ; He, Xingguang ; Jiang, > Cheng1 > Subject

[PATCH v2] cryptodev: avoid algorithm strings null pointers

2023-06-08 Thread xixin.liu
The crypto algorithm strings identifiers that are Continuous may be null, so there is needed to add null judgment. When testing with dpdk-test-crypto-perf and passing in the parameter --auth-algo sm3-hmac, The program caused a segfault due to a null pointer passed in by strcmp. Adding this patch ca

[PATCH v4 0/3] SM2 crypto algorithm support

2023-06-08 Thread Gowrishankar Muthukrishnan
This patch series adds SM2 crypto algorithm support, along with tests verified using Openssl. v4: - minor correction in comments Gowrishankar Muthukrishnan (3): cryptodev: add SM2 asymmetric crypto algorithm test/crypto: add asymmetric SM2 test cases crypto/openssl: add SM2 asymmetric cryp

[PATCH v4 1/3] cryptodev: add SM2 asymmetric crypto algorithm

2023-06-08 Thread Gowrishankar Muthukrishnan
ShangMi 2 (SM2) is set of public-key cryptography algorithms based on elliptic curves. Added support for asymmetric SM2 in cryptodev along with prime field curve, as referenced in RFC: https://datatracker.ietf.org/doc/html/draft-shen-sm2-ecdsa-02 Signed-off-by: Gowrishankar Muthukrishnan --- do

[PATCH v4 2/3] test/crypto: add asymmetric SM2 test cases

2023-06-08 Thread Gowrishankar Muthukrishnan
Added test cases for asymmetric SM2 crypto validation. Test cases are added for sign/verify/encrypt/decrypt. Signed-off-by: Gowrishankar Muthukrishnan --- app/test/test_cryptodev_asym.c | 581 + app/test/test_cryptodev_sm2_test_vectors.h | 129 + 2 files chang

[PATCH v4 3/3] crypto/openssl: add SM2 asymmetric crypto support

2023-06-08 Thread Gowrishankar Muthukrishnan
Add SM2 asymmetric algorithm support in openssl PMD. Signed-off-by: Gowrishankar Muthukrishnan --- doc/guides/cryptodevs/features/openssl.ini | 1 + doc/guides/cryptodevs/openssl.rst| 1 + doc/guides/rel_notes/release_23_07.rst | 4 + drivers/crypto/openssl/openssl_pmd_

RE: [PATCH v4] app/dma-perf: introduce dma-perf application

2023-06-08 Thread Jiang, Cheng1
Hi Chenbo, > -Original Message- > From: Xia, Chenbo > Sent: Thursday, June 8, 2023 4:28 PM > To: Jiang, Cheng1 ; tho...@monjalon.net; > Richardson, Bruce ; m...@smartsharesystems.com > Cc: dev@dpdk.org; Hu, Jiayu ; Ding, Xuan > ; Ma, WenwuX ; Wang, YuanX > ; He, Xingguang > Subject: RE:

Re: [PATCH v1 1/1] doc: announce change in bbdev api related to operation extension

2023-06-08 Thread Maxime Coquelin
On 6/6/23 23:01, Chautru, Nicolas wrote: Hi David, -Original Message- From: David Marchand Sent: Tuesday, June 6, 2023 2:21 AM To: Chautru, Nicolas Cc: Maxime Coquelin ; Stephen Hemminger ; dev@dpdk.org; Rix, Tom ; hemant.agra...@nxp.com; Vargas, Hernan Subject: Re: [PATCH v1 1/1]

RE: [PATCH] bus/pci: fix missing MMIO APIs in Windows

2023-06-08 Thread Ali Alnubani
> -Original Message- > From: Chenbo Xia > Sent: Thursday, June 8, 2023 10:43 AM > To: dev@dpdk.org > Cc: david.march...@redhat.com; NBU-Contact-Thomas Monjalon > (EXTERNAL) ; Ali Alnubani ; > pr...@iol.unh.edu; miao...@intel.com; sta...@dpdk.org; Yahui Cao > ; Sunil Kumar Kori > Subject:

RE: [PATCH] bus/pci: fix missing MMIO APIs in Windows

2023-06-08 Thread Xia, Chenbo
> -Original Message- > From: Ali Alnubani > Sent: Thursday, June 8, 2023 4:55 PM > To: Xia, Chenbo ; dev@dpdk.org > Cc: david.march...@redhat.com; NBU-Contact-Thomas Monjalon (EXTERNAL) > ; pr...@iol.unh.edu; Li, Miao ; > sta...@dpdk.org; Cao, Yahui ; Sunil Kumar Kori > > Subject: RE: [PA

Re: [PATCH v5 00/26] Add VDUSE support to Vhost library

2023-06-08 Thread Maxime Coquelin
On 6/7/23 10:05, David Marchand wrote: On Tue, Jun 6, 2023 at 10:19 AM Maxime Coquelin wrote: This series introduces a new type of backend, VDUSE, to the Vhost library. VDUSE stands for vDPA device in Userspace, it enables implementing a Virtio device in userspace and have it attached to t

[PATCH v5] app/dma-perf: introduce dma-perf application

2023-06-08 Thread Cheng Jiang
There are many high-performance DMA devices supported in DPDK now, and these DMA devices can also be integrated into other modules of DPDK as accelerators, such as Vhost. Before integrating DMA into applications, developers need to know the performance of these DMA devices in various scenarios and

RE: [PATCH v4 0/3] SM2 crypto algorithm support

2023-06-08 Thread Akhil Goyal
> Subject: [PATCH v4 0/3] SM2 crypto algorithm support > > This patch series adds SM2 crypto algorithm support, along with tests > verified using Openssl. > > v4: > - minor correction in comments Series Acked-by: Akhil Goyal Applied to dpdk-next-crypto

Re: [PATCH] config/arm: fix Neoverse N2 march flag

2023-06-08 Thread Srikanth Yalavarthi
On Thu, Jun 8, 2023 at 12:58 PM wrote: > > From: Pavan Nikhilesh > > The -march flag of Neoverse N2 should be `armv9-a` when > used along with -mcpu=neoverse-n2. > > Fixes: ea85ed1f6882 ("config/arm: increase nodes and cores for Neoverse N2") > > Signed-off-by: Pavan Nikhilesh Tested-by: Srikant

[PATCH v6] app/testpmd: expand noisy neighbour forward mode support

2023-06-08 Thread Mike Pattrick
Previously the noisy neighbour vnf simulation would only operate in io mode, forwarding packets as is. However, this limited the usefulness of noisy neighbour simulation. This feature has now been expanded to supporting mac, macswap, and 5tswap modes. To facilitate adding this support, some new he

Re: [PATCH] bus/pci: fix missing MMIO APIs in Windows

2023-06-08 Thread Thomas Monjalon
08/06/2023 10:58, Xia, Chenbo: > From: Ali Alnubani > > From: Chenbo Xia > > > > > > MMIO read and write APIs were defined in PCI bus. But the corresponding > > > implementations are not done in windows. This patch fixes this. > > > > > > Bugzilla ID: 1245 > > > Fixes: 095cf6e68b28 ("bus/pci: int

[PATCH v10 00/16] graph enhancement for multi-core dispatch

2023-06-08 Thread Zhirun Yan
V10: Add rte_graph_worker_model_no_check_get() for fast path, extract rte_graph_model_is_valid() in patch 04. Change RTE_ASSERT to return in patch 06. Change to treat not defined RTE_GRAPH_MODEL_SELECT as runtime pick in patch 13. Move stats into dispatch union in patch 14. Change example to align

[PATCH v10 01/16] graph: rename rte_graph_work as common

2023-06-08 Thread Zhirun Yan
Rename rte_graph_work.h to rte_graph_work_common.h for supporting multiple graph worker model. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan Acked-by: Jerin Jacob --- MAINTAINERS | 3 ++- lib/graph/graph_pcap.

[PATCH v10 02/16] graph: split graph worker into common and default model

2023-06-08 Thread Zhirun Yan
To support multiple graph worker model, split graph into common and default. Naming the current walk function as rte_graph_model_rtc cause the default model is RTC(Run-to-completion). Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan Acked-by: Jerin Jacob --- l

[PATCH v10 03/16] graph: move node process into inline function

2023-06-08 Thread Zhirun Yan
Node process is a single and reusable block, move the code into an inline function. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan Acked-by: Jerin Jacob --- lib/graph/rte_graph_model_rtc.h | 20 ++--- lib/graph/rte_graph_worker_common.h | 33

[PATCH v10 04/16] graph: add get/set graph worker model APIs

2023-06-08 Thread Zhirun Yan
Add new get/set APIs to configure graph worker model which is used to determine which model will be chosen. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan --- lib/graph/meson.build | 1 + lib/graph/rte_graph_worker.c| 39 +++

[PATCH v10 05/16] graph: introduce graph node core affinity API

2023-06-08 Thread Zhirun Yan
Add lcore_id for node to hold affinity core id and impl rte_graph_model_mcore_dispatch_lcore_affinity_set to set node affinity with specific lcore. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan Acked-by: Jerin Jacob --- lib/graph/graph_private.h

[PATCH v10 06/16] graph: introduce graph bind unbind API

2023-06-08 Thread Zhirun Yan
Add lcore_id for graph to hold affinity core id where graph would run on. Add bind/unbind API to set/unset graph affinity attribute. lcore_id will be set as MAX by default, it means not enable this attribute. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan Acke

[PATCH v10 07/16] graph: move node clone name func into private as common

2023-06-08 Thread Zhirun Yan
Move clone_name() into graph_private.h as a common function for both node and graph to naming a new cloned object. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan Acked-by: Jerin Jacob --- lib/graph/graph_private.h | 41 +++

[PATCH v10 08/16] graph: introduce graph clone API for other worker core

2023-06-08 Thread Zhirun Yan
This patch adds graph API for supporting to clone the graph object for a specified worker core. The new graph will also clone all nodes. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan Acked-by: Jerin Jacob --- lib/graph/graph.c | 89 +

[PATCH v10 09/16] graph: add structure for stream moving between cores

2023-06-08 Thread Zhirun Yan
Add graph_mcore_dispatch_wq_node to hold graph scheduling workqueue node. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan --- lib/graph/graph.c | 2 ++ lib/graph/graph_populate.c | 1 + lib/graph/graph_private.h | 12

[PATCH v10 10/16] graph: introduce stream moving cross cores

2023-06-08 Thread Zhirun Yan
This patch introduces key functions to allow a worker thread to enable enqueue and move streams of objects to the next nodes over different cores for mcore dispatch model. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan --- lib/graph/graph.c

[PATCH v10 13/16] graph: enable graph multicore dispatch scheduler model

2023-06-08 Thread Zhirun Yan
This patch enables to chose new scheduler model. Must define RTE_GRAPH_MODEL_SELECT before including rte_graph_worker.h to enable specific model choosing. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan --- doc/guides/prog_guide/graph_lib.rst | 71

[PATCH v10 11/16] graph: enable create and destroy graph scheduling workqueue

2023-06-08 Thread Zhirun Yan
This patch enables to create and destroy scheduling workqueue into common graph operations. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan --- lib/graph/graph.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/lib/graph/graph.c b/lib/graph/grap

[PATCH v10 12/16] graph: introduce graph walk by cross-core dispatch

2023-06-08 Thread Zhirun Yan
This patch introduces the task scheduler mechanism to enable dispatching tasks to another worker cores. Currently, there is only a local work queue for one graph to walk. We introduce a scheduler worker queue in each worker core for dispatching tasks. It will perform the walk on scheduler work queu

[PATCH v10 14/16] graph: add stats for mcore dispatch model

2023-06-08 Thread Zhirun Yan
Add stats for mcore dispatch model if stats collection is enabled. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan Acked-by: Jerin Jacob --- lib/graph/graph_debug.c| 6 ++ lib/graph/graph_stats.c| 76 ++

[PATCH v10 15/16] test/graph: add functional tests for mcore dispatch model

2023-06-08 Thread Zhirun Yan
Add functional test for mcore dispatch model including graph clone, graph model set/get, node worker affinity, graph worker binding/unbinding. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan --- app/test/test_graph.c | 130 +

[PATCH v10 16/16] examples/l3fwd-graph: introduce mcore dispatch worker model

2023-06-08 Thread Zhirun Yan
Add new parameter "model" to choose mcore dispatch or rtc model. And in dispatch model, the node will affinity to worker core successively. Note: RTE_GRAPH_MODEL_SELECT is set to GRAPH_MODEL_RTC by default. Must set model the same as RTE_GRAPH_MODEL_SELECT If set it as rtc or mcore dispatch explic

Re: [PATCH v6] app/testpmd: expand noisy neighbour forward mode support

2023-06-08 Thread Ferruh Yigit
On 6/8/2023 10:59 AM, Mike Pattrick wrote: > Previously the noisy neighbour vnf simulation would only operate in io > mode, forwarding packets as is. However, this limited the usefulness of > noisy neighbour simulation. > > This feature has now been expanded to supporting mac, macswap, and > 5tswa

Re: [PATCH v10 04/16] graph: add get/set graph worker model APIs

2023-06-08 Thread Jerin Jacob
On Thu, Jun 8, 2023 at 3:35 PM Zhirun Yan wrote: > > Add new get/set APIs to configure graph worker model which is used to > determine which model will be chosen. > > Signed-off-by: Haiyue Wang > Signed-off-by: Cunming Liang > Signed-off-by: Zhirun Yan > > +/** Graph worker models */ > +/* If a

Re: [PATCH v10 06/16] graph: introduce graph bind unbind API

2023-06-08 Thread Jerin Jacob
On Thu, Jun 8, 2023 at 3:35 PM Zhirun Yan wrote: > > Add lcore_id for graph to hold affinity core id where graph would run on. > Add bind/unbind API to set/unset graph affinity attribute. lcore_id will > be set as MAX by default, it means not enable this attribute. > > diff --git a/lib/graph/vers

RE: [PATCH] config/arm: fix Neoverse N2 march flag

2023-06-08 Thread Ruifeng Wang
> -Original Message- > From: pbhagavat...@marvell.com > Sent: Thursday, June 8, 2023 3:28 PM > To: jer...@marvell.com; Ruifeng Wang ; Bruce Richardson > > Cc: dev@dpdk.org; Pavan Nikhilesh > Subject: [PATCH] config/arm: fix Neoverse N2 march flag > > From: Pavan Nikhilesh > > The -mar

Re: [PATCH v10 13/16] graph: enable graph multicore dispatch scheduler model

2023-06-08 Thread Jerin Jacob
On Thu, Jun 8, 2023 at 3:35 PM Zhirun Yan wrote: > > This patch enables to chose new scheduler model. Must define > RTE_GRAPH_MODEL_SELECT before including rte_graph_worker.h > to enable specific model choosing. > > Signed-off-by: Haiyue Wang > Signed-off-by: Cunming Liang > Signed-off-by: Zhiru

Re: [PATCH v6] app/testpmd: expand noisy neighbour forward mode support

2023-06-08 Thread Mike Pattrick
On Thu, Jun 8, 2023 at 6:25 AM Ferruh Yigit wrote: > > On 6/8/2023 10:59 AM, Mike Pattrick wrote: > > Previously the noisy neighbour vnf simulation would only operate in io > > mode, forwarding packets as is. However, this limited the usefulness of > > noisy neighbour simulation. > > > > This feat

Re: [PATCH v10 16/16] examples/l3fwd-graph: introduce mcore dispatch worker model

2023-06-08 Thread Jerin Jacob
On Thu, Jun 8, 2023 at 3:36 PM Zhirun Yan wrote: > > Add new parameter "model" to choose mcore dispatch or rtc model. > And in dispatch model, the node will affinity to worker core successively. > > Note: Remove just the "Note" text. > RTE_GRAPH_MODEL_SELECT is set to GRAPH_MODEL_RTC by defaul

Re: [PATCH v4 2/3] common/sfc_efx/base: add support to enable VLAN stripping

2023-06-08 Thread Artemii Morozov
Hello, On 6/2/23 12:32, Andrew Rybchenko wrote: On 6/1/23 18:30, Artemii Morozov wrote: To enable VLAN stripping, two conditions must be met: the corresponding flag must be set and the appropriate RX prefix should be requested. RX -> Rx VLAN stripping is supported for ef100 datapath only.

Re: [PATCH v1] event/dlb2: add support for disabling PASID

2023-06-08 Thread Jerin Jacob
On Thu, Jun 8, 2023 at 12:59 PM David Marchand wrote: > > On Thu, Jun 8, 2023 at 7:38 AM Jerin Jacob wrote: > > > > On Thu, Jun 8, 2023 at 2:31 AM Abdullah Sevincer > > wrote: > > > > > > vfio-pci driver in Linux kernel 6.2 enables PASID by default. > > > In DLB hardware, enabling PASID puts DLB

Re: [PATCH v6] app/testpmd: expand noisy neighbour forward mode support

2023-06-08 Thread Ferruh Yigit
On 6/8/2023 11:43 AM, Mike Pattrick wrote: > On Thu, Jun 8, 2023 at 6:25 AM Ferruh Yigit wrote: >> >> On 6/8/2023 10:59 AM, Mike Pattrick wrote: >>> Previously the noisy neighbour vnf simulation would only operate in io >>> mode, forwarding packets as is. However, this limited the usefulness of >>

Re: [PATCH v2 0/6] changes for 23.07

2023-06-08 Thread Maxime Coquelin
Hi Hernan, On 6/6/23 16:31, Vargas, Hernan wrote: Hi Maxime, Kind reminder to review this series when you have a chance: https://patchwork.dpdk.org/project/dpdk/list/?series=28189 As mentioned on V1, I plan to only pick the fixes I for which I gave my R-by in v23.07. The other patches will be

RE: [EXT] [PATCH v10 16/16] examples/l3fwd-graph: introduce mcore dispatch worker model

2023-06-08 Thread Pavan Nikhilesh Bhagavatula
> Add new parameter "model" to choose mcore dispatch or rtc model. > And in dispatch model, the node will affinity to worker core successively. > > Note: > RTE_GRAPH_MODEL_SELECT is set to GRAPH_MODEL_RTC by default. Must Should be RTE_GRAPH_MODEL_RTC > set > model the same as RTE_GRAPH_MODEL_SE

[PATCH] net/mlx5: fix actions template expansion

2023-06-08 Thread Gregory Etelson
Static actions definitions used in template expansion were defined in conditional context. That context was destroyed by the time it's memory was accessed. Fixes: cf7f458b05f3 ("net/mlx5: add indirect QUOTA create/query/modify") Signed-off-by: Gregory Etelson --- drivers/net/mlx5/mlx5_flow_hw.c

RE: [PATCH v5] crypto/qat: default to IPsec MB for computations

2023-06-08 Thread Power, Ciara
> -Original Message- > From: Brian Dooley > Sent: Tuesday 6 June 2023 11:28 > To: Ji, Kai > Cc: dev@dpdk.org; gak...@marvell.com; De Lara Guarch, Pablo > ; Dooley, Brian > Subject: [PATCH v5] crypto/qat: default to IPsec MB for computations > > Pre and post computations currently use

RE: [EXT] [PATCH v10 15/16] test/graph: add functional tests for mcore dispatch model

2023-06-08 Thread Pavan Nikhilesh Bhagavatula
> Add functional test for mcore dispatch model including graph clone, > graph model set/get, node worker affinity, graph worker binding/unbinding. > > Signed-off-by: Haiyue Wang > Signed-off-by: Cunming Liang > Signed-off-by: Zhirun Yan Acked-by: Pavan Nikhilesh > --- > app/test/test_graph.c

Re: [PATCH v4 00/34] net/sfc: support HW conntrack assistance

2023-06-08 Thread Andrew Rybchenko
On 6/7/23 16:02, Ivan Malov wrote: On EF100 hardware, match-action engine (MAE) can be equipped with an assistance table for connection tracking (CT). In it, an entry key is a set of exact match fields: an EtherType, a pair of IP addresses, a L4 protocol ID and a pair of L4 port numbers. An entry

Re: [PATCH v4 2/3] common/sfc_efx/base: add support to enable VLAN stripping

2023-06-08 Thread Andrew Rybchenko
On 6/8/23 14:16, Artemii Morozov wrote: Hello, On 6/2/23 12:32, Andrew Rybchenko wrote: On 6/1/23 18:30, Artemii Morozov wrote: To enable VLAN stripping, two conditions must be met: the corresponding flag must be set and the appropriate RX prefix should be requested. RX -> Rx VLAN strippin

Re: [PATCH v5 00/26] Add VDUSE support to Vhost library

2023-06-08 Thread David Marchand
On Thu, Jun 8, 2023 at 11:17 AM Maxime Coquelin wrote: > On 6/7/23 10:05, David Marchand wrote: > > On Tue, Jun 6, 2023 at 10:19 AM Maxime Coquelin > > wrote: > >> > >> This series introduces a new type of backend, VDUSE, > >> to the Vhost library. > >> > >> VDUSE stands for vDPA device in Usersp

Re: [PATCH v4 0/4] Support VFIO sparse mmap in PCI bus

2023-06-08 Thread Patrick Robb
On Thu, Jun 8, 2023 at 3:03 AM David Marchand wrote: > Hello Chenbo, Patrick, > > > On Thu, Jun 8, 2023 at 8:50 AM Xia, Chenbo wrote: > > > > This series introduces a VFIO standard capability, called sparse > > > > mmap to PCI bus. In linux kernel, it's defined as > > > > VFIO_REGION_INFO_CAP_SP

RE: [PATCH] config/arm: fix Neoverse N2 march flag

2023-06-08 Thread Pavan Nikhilesh Bhagavatula
> -Original Message- > From: Ruifeng Wang > Sent: Thursday, June 8, 2023 4:12 PM > To: Pavan Nikhilesh Bhagavatula ; Jerin Jacob > Kollanukkaran ; Bruce Richardson > > Cc: dev@dpdk.org; Juraj Linkeš ; nd > > Subject: [EXT] RE: [PATCH] config/arm: fix Neoverse N2 march flag > > Extern

RE: [PATCH v1] common/qat: fix qat_dev_cmd_param corruption

2023-06-08 Thread Power, Ciara
> -Original Message- > From: Vikash Poddar > Sent: Tuesday 23 May 2023 10:07 > To: Ji, Kai > Cc: dev@dpdk.org; Poddar, Vikash ChandraX > ; Kusztal, ArkadiuszX > > Subject: [PATCH v1] common/qat: fix qat_dev_cmd_param corruption > > Adding fix to address the memory corruption issue fo

RE: [EXT] [PATCH v10 14/16] graph: add stats for mcore dispatch model

2023-06-08 Thread Pavan Nikhilesh Bhagavatula
> Add stats for mcore dispatch model if stats collection is > enabled. > > Signed-off-by: Haiyue Wang > Signed-off-by: Cunming Liang > Signed-off-by: Zhirun Yan > Acked-by: Jerin Jacob Acked-by: Pavan Nikhilesh > --- > lib/graph/graph_debug.c| 6 ++ > lib/graph/graph_s

RE: [PATCH v6] crypto/qat: support to enable insecure algorithms

2023-06-08 Thread Power, Ciara
> -Original Message- > From: Vikash Poddar > Sent: Monday 29 May 2023 11:45 > To: Akhil Goyal ; Fan Zhang > ; Ji, Kai > Cc: dev@dpdk.org; Poddar, Vikash ChandraX > > Subject: [PATCH v6] crypto/qat: support to enable insecure algorithms > > All the insecure algorithms are default disa

RE: [RFC] ring: improve ring performance with C11 atomics

2023-06-08 Thread Wathsala Wathawana Vithanage
The solution presented in this RFC is not C11 compliant. C11 __atomic_compare_exchange_n updates "expected" only when CAS instruction fails. Therefore, the assumption that there is an address dependency from CAS instructions in both producer/consumer head update to the ring element accesses fa

[PATCH v7] app/testpmd: expand noisy neighbour forward mode support

2023-06-08 Thread Mike Pattrick
Previously the noisy neighbour vnf simulation would only operate in io mode, forwarding packets as is. However, this limited the usefulness of noisy neighbour simulation. This feature has now been expanded to supporting mac, macswap, and 5tswap modes. To facilitate adding this support, some new he

RE: [EXT] [PATCH v10 10/16] graph: introduce stream moving cross cores

2023-06-08 Thread Pavan Nikhilesh Bhagavatula
> This patch introduces key functions to allow a worker thread to > enable enqueue and move streams of objects to the next nodes over > different cores for mcore dispatch model. > > Signed-off-by: Haiyue Wang > Signed-off-by: Cunming Liang > Signed-off-by: Zhirun Yan Acked-by: Pavan Nikhilesh

RE: [EXT] [PATCH v10 11/16] graph: enable create and destroy graph scheduling workqueue

2023-06-08 Thread Pavan Nikhilesh Bhagavatula
> This patch enables to create and destroy scheduling workqueue into > common graph operations. > > Signed-off-by: Haiyue Wang > Signed-off-by: Cunming Liang > Signed-off-by: Zhirun Yan Acked-by: Pavan Nikhilesh > --- > lib/graph/graph.c | 10 ++ > 1 file changed, 10 insertions(+) >

RE: [EXT] [PATCH v10 12/16] graph: introduce graph walk by cross-core dispatch

2023-06-08 Thread Pavan Nikhilesh Bhagavatula
> This patch introduces the task scheduler mechanism to enable dispatching > tasks to another worker cores. Currently, there is only a local work > queue for one graph to walk. We introduce a scheduler worker queue in > each worker core for dispatching tasks. It will perform the walk on > scheduler

RE: [PATCH] net/mlx5: fix actions template expansion

2023-06-08 Thread Raslan Darawsheh
Hello, > -Original Message- > From: Gregory Etelson > Sent: Thursday, June 8, 2023 3:16 PM > To: dev@dpdk.org > Cc: Gregory Etelson ; Raslan Darawsheh > > Subject: [PATCH] net/mlx5: fix actions template expansion > > Static actions definitions used in template expansion were defined in

RE: [PATCH v10 06/16] graph: introduce graph bind unbind API

2023-06-08 Thread Yan, Zhirun
> -Original Message- > From: Jerin Jacob > Sent: Thursday, June 8, 2023 6:41 PM > To: Yan, Zhirun > Cc: dev@dpdk.org; jer...@marvell.com; kirankum...@marvell.com; > ndabilpu...@marvell.com; step...@networkplumber.org; > pbhagavat...@marvell.com; Liang, Cunming ; Wang, > Haiyue ; mattias

RE: [EXT] [PATCH v10 16/16] examples/l3fwd-graph: introduce mcore dispatch worker model

2023-06-08 Thread Yan, Zhirun
> -Original Message- > From: Pavan Nikhilesh Bhagavatula > Sent: Thursday, June 8, 2023 8:09 PM > To: Yan, Zhirun ; dev@dpdk.org; Jerin Jacob > Kollanukkaran ; Kiran Kumar Kokkilagadda > ; Nithin Kumar Dabilpuram > ; step...@networkplumber.org; > jerinjac...@gmail.com > Cc: Liang, Cunmi

RE: [PATCH] config/arm: fix Neoverse N2 march flag

2023-06-08 Thread Ruifeng Wang
> -Original Message- > From: Pavan Nikhilesh Bhagavatula > Sent: Thursday, June 8, 2023 8:59 PM > To: Ruifeng Wang ; jer...@marvell.com; Bruce Richardson > > Cc: dev@dpdk.org; Juraj Linkeš ; nd > Subject: RE: [PATCH] config/arm: fix Neoverse N2 march flag > > > > > -Original Messa

RE: [PATCH] bitmap: add scan init at given position

2023-06-08 Thread Dumitrescu, Cristian
Hi Volodymyr, Thanks for your patch, comments below under your code: > -Original Message- > From: Thomas Monjalon > Sent: Thursday, June 1, 2023 4:26 PM > To: Dumitrescu, Cristian ; Volodymyr Fialko > > Cc: dev@dpdk.org; jer...@marvell.com; ano...@marvell.com > Subject: Re: [PATCH] bitm

RE: [EXT] [PATCH v10 13/16] graph: enable graph multicore dispatch scheduler model

2023-06-08 Thread Pavan Nikhilesh Bhagavatula
> This patch enables to chose new scheduler model. Must define > RTE_GRAPH_MODEL_SELECT before including rte_graph_worker.h > to enable specific model choosing. > > Signed-off-by: Haiyue Wang > Signed-off-by: Cunming Liang > Signed-off-by: Zhirun Yan Acked-by: Pavan Nikhilesh > --- > doc/gui

Re: [PATCH v5 00/26] Add VDUSE support to Vhost library

2023-06-08 Thread Maxime Coquelin
On 6/6/23 10:18, Maxime Coquelin wrote: This series introduces a new type of backend, VDUSE, to the Vhost library. VDUSE stands for vDPA device in Userspace, it enables implementing a Virtio device in userspace and have it attached to the Kernel vDPA bus. Once attached to the vDPA bus, it ca

Re: [PATCH v7] app/testpmd: expand noisy neighbour forward mode support

2023-06-08 Thread Ferruh Yigit
On 6/8/2023 2:31 PM, Mike Pattrick wrote: > Previously the noisy neighbour vnf simulation would only operate in io > mode, forwarding packets as is. However, this limited the usefulness of > noisy neighbour simulation. > > This feature has now been expanded to supporting mac, macswap, and > 5tswap

RE: [PATCH v1] event/dlb2: add support for disabling PASID

2023-06-08 Thread Chen, Mike Ximing
> From: Jerin Jacob > Sent: Thursday, June 8, 2023 7:32 AM > To: David Marchand > Cc: Sevincer, Abdullah ; Gaetan Rivet > ; Thomas Monjalon > ; dev@dpdk.org; jer...@marvell.com; Chen, Mike Ximing > > Subject: Re: [PATCH v1] event/dlb2: add support for disabling PASID > > On Thu, Jun 8, 2023 at

Re: [PATCH] net/nfp: fix callback function pointer of disabling promisc

2023-06-08 Thread Ferruh Yigit
On 6/8/2023 4:07 AM, Chaoyong He wrote: > From: Qin Ke > > The callback function of promiscuous_disable in nfp_flower_pf_repr_dev_ops > and nfp_flower_repr_dev_ops should be nfp_net_promisc_disable, not > nfp_net_promisc_enable, fix it. > > Fixes: 39d82d2 ("net/nfp: fix promiscuous mode for repr

Re: [PATCH] bitmap: add scan init at given position

2023-06-08 Thread Bruce Richardson
On Thu, Jun 08, 2023 at 02:20:13PM +, Dumitrescu, Cristian wrote: > Hi Volodymyr, > > Thanks for your patch, comments below under your code: > > > -Original Message- > > From: Thomas Monjalon > > Sent: Thursday, June 1, 2023 4:26 PM > > To: Dumitrescu, Cristian ; Volodymyr Fialko > >

[PATCH v11 00/16] graph enhancement for multi-core dispatch

2023-06-08 Thread Zhirun Yan
V11: Update comments and fix to add experimental flags for rte_graph_model_is_valid() in patch 04. Update added symbols in alphabetical order in version.map with patch 04,05,06,08,10. Update commit message in patch 16. V10: Add rte_graph_worker_model_no_check_get() for fast path, extract rte_gr

[PATCH v11 01/16] graph: rename rte_graph_work as common

2023-06-08 Thread Zhirun Yan
Rename rte_graph_work.h to rte_graph_work_common.h for supporting multiple graph worker model. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan Acked-by: Jerin Jacob --- MAINTAINERS | 3 ++- lib/graph/graph_pcap.

[PATCH v11 02/16] graph: split graph worker into common and default model

2023-06-08 Thread Zhirun Yan
To support multiple graph worker model, split graph into common and default. Naming the current walk function as rte_graph_model_rtc cause the default model is RTC(Run-to-completion). Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan Acked-by: Jerin Jacob --- l

[PATCH v11 03/16] graph: move node process into inline function

2023-06-08 Thread Zhirun Yan
Node process is a single and reusable block, move the code into an inline function. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan Acked-by: Jerin Jacob --- lib/graph/rte_graph_model_rtc.h | 20 ++--- lib/graph/rte_graph_worker_common.h | 33

[PATCH v11 05/16] graph: introduce graph node core affinity API

2023-06-08 Thread Zhirun Yan
Add lcore_id for node to hold affinity core id and impl rte_graph_model_mcore_dispatch_lcore_affinity_set to set node affinity with specific lcore. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan Acked-by: Jerin Jacob --- lib/graph/graph_private.h

[PATCH v11 04/16] graph: add get/set graph worker model APIs

2023-06-08 Thread Zhirun Yan
Add new get/set APIs to configure graph worker model which is used to determine which model will be chosen. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan Acked-by: Jerin Jacob --- lib/graph/meson.build | 1 + lib/graph/rte_graph_worker.c

[PATCH v11 06/16] graph: introduce graph bind unbind API

2023-06-08 Thread Zhirun Yan
Add lcore_id for graph to hold affinity core id where graph would run on. Add bind/unbind API to set/unset graph affinity attribute. lcore_id will be set as MAX by default, it means not enable this attribute. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan Acke

[PATCH v11 07/16] graph: move node clone name func into private as common

2023-06-08 Thread Zhirun Yan
Move clone_name() into graph_private.h as a common function for both node and graph to naming a new cloned object. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan Acked-by: Jerin Jacob --- lib/graph/graph_private.h | 41 +++

[PATCH v11 09/16] graph: add structure for stream moving between cores

2023-06-08 Thread Zhirun Yan
Add graph_mcore_dispatch_wq_node to hold graph scheduling workqueue node. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan --- lib/graph/graph.c | 2 ++ lib/graph/graph_populate.c | 1 + lib/graph/graph_private.h | 12

[PATCH v11 08/16] graph: introduce graph clone API for other worker core

2023-06-08 Thread Zhirun Yan
This patch adds graph API for supporting to clone the graph object for a specified worker core. The new graph will also clone all nodes. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan Acked-by: Jerin Jacob --- lib/graph/graph.c | 89 +

[PATCH v11 10/16] graph: introduce stream moving cross cores

2023-06-08 Thread Zhirun Yan
This patch introduces key functions to allow a worker thread to enable enqueue and move streams of objects to the next nodes over different cores for mcore dispatch model. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan Acked-by: Pavan Nikhilesh --- lib/graph

[PATCH v11 11/16] graph: enable create and destroy graph scheduling workqueue

2023-06-08 Thread Zhirun Yan
This patch enables to create and destroy scheduling workqueue into common graph operations. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan Acked-by: Pavan Nikhilesh --- lib/graph/graph.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/lib/gra

[PATCH v11 12/16] graph: introduce graph walk by cross-core dispatch

2023-06-08 Thread Zhirun Yan
This patch introduces the task scheduler mechanism to enable dispatching tasks to another worker cores. Currently, there is only a local work queue for one graph to walk. We introduce a scheduler worker queue in each worker core for dispatching tasks. It will perform the walk on scheduler work queu

[PATCH v11 13/16] graph: enable graph multicore dispatch scheduler model

2023-06-08 Thread Zhirun Yan
This patch enables to chose new scheduler model. Must define RTE_GRAPH_MODEL_SELECT before including rte_graph_worker.h to enable specific model choosing. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan Acked-by: Jerin Jacob Acked-by: Pavan Nikhilesh --- doc

[PATCH v11 14/16] graph: add stats for mcore dispatch model

2023-06-08 Thread Zhirun Yan
Add stats for mcore dispatch model if stats collection is enabled. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan Acked-by: Jerin Jacob Acked-by: Pavan Nikhilesh --- lib/graph/graph_debug.c| 6 ++ lib/graph/graph_stats.c

[PATCH v11 15/16] test/graph: add functional tests for mcore dispatch model

2023-06-08 Thread Zhirun Yan
Add functional test for mcore dispatch model including graph clone, graph model set/get, node worker affinity, graph worker binding/unbinding. Signed-off-by: Haiyue Wang Signed-off-by: Cunming Liang Signed-off-by: Zhirun Yan Acked-by: Pavan Nikhilesh --- app/test/test_graph.c | 130 ++

  1   2   >