Hi Chenbo, > -----Original Message----- > From: Xia, Chenbo <chenbo....@intel.com> > Sent: Thursday, June 8, 2023 4:28 PM > To: Jiang, Cheng1 <cheng1.ji...@intel.com>; tho...@monjalon.net; > Richardson, Bruce <bruce.richard...@intel.com>; m...@smartsharesystems.com > Cc: dev@dpdk.org; Hu, Jiayu <jiayu...@intel.com>; Ding, Xuan > <xuan.d...@intel.com>; Ma, WenwuX <wenwux...@intel.com>; Wang, YuanX > <yuanx.w...@intel.com>; He, Xingguang <xingguang...@intel.com> > Subject: RE: [PATCH v4] app/dma-perf: introduce dma-perf application > > > -----Original Message----- > > From: Jiang, Cheng1 <cheng1.ji...@intel.com> > > Sent: Thursday, June 8, 2023 1:03 PM > > To: tho...@monjalon.net; Richardson, Bruce > > <bruce.richard...@intel.com>; m...@smartsharesystems.com; Xia, Chenbo > > <chenbo....@intel.com> > > Cc: dev@dpdk.org; Hu, Jiayu <jiayu...@intel.com>; Ding, Xuan > > <xuan.d...@intel.com>; Ma, WenwuX <wenwux...@intel.com>; Wang, > YuanX > > <yuanx.w...@intel.com>; He, Xingguang <xingguang...@intel.com>; Jiang, > > Cheng1 <cheng1.ji...@intel.com> > > Subject: [PATCH v4] app/dma-perf: introduce dma-perf application > > > > There are many high-performance DMA devices supported in DPDK now, and > > these DMA devices can also be integrated into other modules of DPDK as > > accelerators, such as Vhost. Before integrating DMA into applications, > > developers need to know the performance of these DMA devices in > > various scenarios and the performance of CPUs in the same scenario, > > such as different buffer lengths. Only in this way can we know the > > target performance of the application accelerated by using them. This > > patch introduces a high-performance testing tool, which supports > > comparing the performance of CPU and DMA in different scenarios > > automatically with a pre-set config file. Memory Copy performance test are > supported for now. > > > > Signed-off-by: Cheng Jiang <cheng1.ji...@intel.com> > > Signed-off-by: Jiayu Hu <jiayu...@intel.com> > > Signed-off-by: Yuan Wang <yuanx.w...@intel.com> > > Acked-by: Morten Brørup <m...@smartsharesystems.com> > > Some LONG_LINE warning could be fixed if it's friendly for searching logs. > > I didn't look into all details but overall it seems good. > > Acked-by: Chenbo Xia <chenbo....@intel.com>
Sure, I will fix it in the next version. Thanks a lot. Cheng > > > --- > > v4: > > fixed inaccuracy of the memory footprint display; > > v3: > > fixed some typos; > > v2: > > added lcore/dmadev designation; > > added error case process; > > removed worker_threads parameter from config.ini; > > improved the logs; > > improved config file; > > > > app/meson.build | 1 + > > app/test-dma-perf/benchmark.c | 471 ++++++++++++++++++++++++++++ > > app/test-dma-perf/config.ini | 59 ++++ > > app/test-dma-perf/main.c | 567 ++++++++++++++++++++++++++++++++++ > > app/test-dma-perf/main.h | 69 +++++ > > app/test-dma-perf/meson.build | 17 + > > 6 files changed, 1184 insertions(+) > > create mode 100644 app/test-dma-perf/benchmark.c create mode 100644 > > app/test-dma-perf/config.ini create mode 100644 > > app/test-dma-perf/main.c create mode 100644 app/test-dma-perf/main.h > > create mode 100644 app/test-dma-perf/meson.build > >
