Re: [PATCH 1/5] ethdev: fix race-condition of proactive error handling mode

2023-03-07 Thread fengchengwen
On 2023/3/6 19:13, Konstantin Ananyev wrote: > > > In the proactive error handling mode, the PMD will set the data path > pointers to dummy functions and then try recovery, in this period the > application may still invoking data path API. This will introduce a

RE: [PATCH v1 04/13] graph: add get/set graph worker model APIs

2023-03-07 Thread Yan, Zhirun
> -Original Message- > From: Jerin Jacob > Sent: Thursday, March 2, 2023 9:58 PM > To: Yan, Zhirun > Cc: dev@dpdk.org; jer...@marvell.com; kirankum...@marvell.com; > ndabilpu...@marvell.com; Liang, Cunming ; Wang, > Haiyue > Subject: Re: [PATCH v1 04/13] graph: add get/set graph worker

Re: [PATCH 1/5] ethdev: fix race-condition of proactive error handling mode

2023-03-07 Thread fengchengwen
On 2023/3/7 13:34, Honnappa Nagarahalli wrote: > > >> -Original Message- >> From: Konstantin Ananyev >> Sent: Sunday, March 5, 2023 9:24 AM >> To: Honnappa Nagarahalli ; >> dev@dpdk.org; Chengwen Feng ; >> tho...@monjalon.net; Ferruh Yigit ; Andrew >> Rybchenko ; Kalesh AP > anakkur.p

Re: [PATCH 4/4] doc: note that testpmd on mlx5 has dedicated queues problem

2023-03-07 Thread Havlík Martin
Hi Slava, as I no longer work on the DPDK centered project which led me to encounter said issue, I am no longer in touch with changes made to net/bonding and moreover I don't have access to resources to test the current state of things. But that aside, the linked commit seems to fix the issu

RE: [PATCH v2] net/mlx5: enable hint in async table

2023-03-07 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Rongwei Liu > Sent: Monday, March 6, 2023 1:37 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Slava Ovsiienko > > Subject: [PATCH v2] net/mlx5: enable hint in async table > > Driver gets the hint value from rte_table_attr for async flow. > Parse the value and

RE: [PATCH 0/5] net/mlx5: enhanced CQE compression layout

2023-03-07 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Alexander Kozyrev > Sent: Tuesday, February 28, 2023 6:43 PM > To: dev@dpdk.org > Cc: Raslan Darawsheh ; Slava Ovsiienko > ; Matan Azrad > Subject: [PATCH 0/5] net/mlx5: enhanced CQE compression layout > > Support Enhanced CQE Compression Layout in mlx5

Re: [PATCH v2 0/2] Add option to timestamp console log

2023-03-07 Thread Bruce Richardson
On Mon, Mar 06, 2023 at 10:18:14AM -0800, Stephen Hemminger wrote: > This is a reprise of earlier patch to add timestamp to console > messages. > > Example: > # dpdk-testpmd -l 1-4 -n 4 --vdev net_null0 --log-timestamp -- -i > EAL: Detected CPU lcores: 16 > EAL: Detected NUMA nodes: 1 > EAL: Detec

Re: [PATCH v3 0/2] Add option to timestamp console log

2023-03-07 Thread Bruce Richardson
On Tue, Mar 07, 2023 at 08:33:17AM +0100, Morten Brørup wrote: > > From: Stephen Hemminger [mailto:step...@networkplumber.org] > > Sent: Monday, 6 March 2023 20.28 > > > > This is a reprise of earlier patch to add timestamp to console > > messages. > > > > Example: > > # dpdk-testpmd -l 1-4 -n 4

Re: [PATCH v3 2/2] eal: add option to put timestamp on console output

2023-03-07 Thread fengchengwen
On 2023/3/7 3:28, Stephen Hemminger wrote: > When debugging driver or startup issues, it is useful to have > a timestamp on each message printed. The messages in syslog > already have a timestamp, but often syslog is not available > during testing. The timestamp format is chosen to look > like the

Re: [PATCH 4/4] doc: note that testpmd on mlx5 has dedicated queues problem

2023-03-07 Thread Jan Viktorin
Hello all, Mario (CC) will look at this. H. On Tue, 07 Mar 2023 10:00:35 +0100 Havlík Martin wrote: > Hi Slava, > > as I no longer work on the DPDK centered project which led me to > encounter said issue, I am no longer in touch with changes made to > net/bonding and moreover I don't have a

RE: [PATCH v2 2/3] examples/l3fwd: removed hash entry number

2023-03-07 Thread Konstantin Ananyev
> Fixes: e7e6dd643092 ("examples/l3fwd: support config file for EM") > Cc: sta...@dpdk.org > > Signed-off-by: Kamalakshitha Aligeri > Reviewed-by: Honnappa Nagarahalli > --- > examples/l3fwd/l3fwd.h | 1 - > examples/l3fwd/main.c | 37 + > 2 files change

RE: [PATCH v2 3/3] doc/l3fwd: lpm supports IPv4 and IPv6 forwarding

2023-03-07 Thread Konstantin Ananyev
> -Original Message- > From: Kamalakshitha Aligeri > Sent: Monday, March 6, 2023 4:25 PM > To: jer...@marvell.com; tho...@monjalon.net; david.march...@redhat.com; > sean.morris...@intel.com; Konstantin Ananyev > ; ruifeng.w...@arm.com; > honnappa.nagaraha...@arm.com > Cc: dev@dpdk.org

RE: [PATCH 1/5] ethdev: fix race-condition of proactive error handling mode

2023-03-07 Thread Konstantin Ananyev
> > > > In the proactive error handling mode, the PMD will set the data path > > pointers to dummy functions and then try recovery, in this period > > the > > application may still invoking data path API. This will introduce a > > race-condition with data

RE: [PATCH 1/5] ethdev: fix race-condition of proactive error handling mode

2023-03-07 Thread Konstantin Ananyev
> > > > > > > > In the proactive error handling mode, the PMD will set the data > > path pointers to dummy functions and then try recovery, in this > > period the application may still invoking data path API. This will > > introduce a race-condition with data path which m

RE: [PATCH 1/5] ethdev: fix race-condition of proactive error handling mode

2023-03-07 Thread Konstantin Ananyev
> > > In the proactive error handling mode, the PMD will set the data > > > path > > > pointers to dummy functions and then try recovery, in this period > > > the > > > application may still invoking data path API. This will introduce > > > a > >

Re: [PATCH 4/4] doc: note that testpmd on mlx5 has dedicated queues problem

2023-03-07 Thread Mário Kuka
Hello Slava, I confirm that the patch http://git.dpdk.org/dpdk/commit/?id=f66323717e has resolved this issue. I have tested that after applying the patch, the problem no longer occurs. With best regards, Mário On 07/03/2023 10:37, Jan Viktorin wrote: Hello all, Mario (CC) will look at this.

RE: [PATCH 4/4] doc: note that testpmd on mlx5 has dedicated queues problem

2023-03-07 Thread Slava Ovsiienko
Hi, Thank you, Mario, for confirming. So, patch is not actual anymore. With best regards, Slava > -Original Message- > From: Mário Kuka > Sent: вторник, 7 марта 2023 г. 12:26 > To: Jan Viktorin ; Slava Ovsiienko > > Cc: Havlík Martin ; Xiaoyun Li > ; Ferruh Yigit ; Andrew > Rybchenko ;

[PATCH] net/mlx5: fix the hairpin Tx queue reference count

2023-03-07 Thread Bing Zhao
When calling the haipin unbind interface, all the hairpin Tx queues of the port will be unbound from the peer Rx queues. If one of the Tx queue is working in the auto bind mode, the interface will return directly. Only when the Tx and peer Rx ports are the same, the auto bind mode is supported. In

[PATCH v2 1/1] drivers: remove implementation of Rx metadata negotiation

2023-03-07 Thread Hanumanth Pothula
Presently, Rx metadata is sent to PMD by default, leading to a performance drop as processing for the same in Rx path takes extra cycles. Hence, removing driver implementation of Rx metadata negotiation and falling back to old implementation where mark actions are tracked as part of the flow rule.

RE: [PATCH v3 1/3] ethdev: enable direct rearm with separate API

2023-03-07 Thread Konstantin Ananyev
> > On 3/6/2023 1:26 PM, Morten Brørup wrote: > > >> From: Ferruh Yigit [mailto:ferruh.yi...@amd.com] > > >> Sent: Monday, 6 March 2023 13.49 > > >> > > >> On 1/4/2023 8:21 AM, Morten Brørup wrote: > > From: Feifei Wang [mailto:feifei.wa...@arm.com] > > Sent: Wednesday, 4 January 2023 0

RE: [PATCH v3 2/3] net/i40e: enable direct rearm with separate API

2023-03-07 Thread Konstantin Ananyev
> > -邮件原件- > > 发件人: Konstantin Ananyev > > 发送时间: Tuesday, February 28, 2023 3:36 AM > > 收件人: Feifei Wang ; Konstantin Ananyev > > ; Yuying Zhang > > ; Beilei Xing ; Ruifeng > > Wang > > 抄送: dev@dpdk.org; nd ; Honnappa Nagarahalli > > ; nd > > 主题: RE: [PATCH v3 2/3] net/i40e: enable dir

RE: [PATCH 0/4] net/mlx5: add template table insertion and matching types

2023-03-07 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Alexander Kozyrev > Sent: Friday, January 27, 2023 1:41 AM > To: dev@dpdk.org > Cc: NBU-Contact-Thomas Monjalon (EXTERNAL) ; > Ori Kam ; Raslan Darawsheh ; > Matan Azrad ; Slava Ovsiienko > > Subject: [PATCH 0/4] net/mlx5: add template table insertion and

RE: [PATCH v2] doc: update recipe for static rdma-core in mlx guides

2023-03-07 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Thomas Monjalon > Sent: Wednesday, January 11, 2023 10:45 AM > To: dev@dpdk.org > Cc: Ali Alnubani ; bruce.richard...@intel.com; Matan > Azrad ; Slava Ovsiienko > Subject: [PATCH v2] doc: update recipe for static rdma-core in mlx guides > > With recent v

Re: [PATCH v3] app/testpmd: fix secondary process not forwarding

2023-03-07 Thread Ferruh Yigit
On 3/7/2023 3:25 AM, He, ShiyangX wrote: > > >> -Original Message- >> From: Ferruh Yigit >> Sent: Monday, March 6, 2023 11:06 PM >> To: He, ShiyangX ; dev@dpdk.org >> Cc: Zhou, YidingX ; sta...@dpdk.org; Zhang, Yuying >> ; Singh, Aman Deep >> ; Burakov, Anatoly >> ; Matan Azrad ; Dmitry

[PATCH v5 0/1] devtools: add tracepoint check in checkpatch

2023-03-07 Thread Ankur Dwivedi
This patch series adds a validation in checkpatch tool to check if tracepoint is present in any new function added in ethdev, eventdev cryptodev and mempool library. v5: - Copied the build_map_changes function from check-symbol-change.sh to check-tracepoint.sh. - Added eventdev, cryptodev and

[PATCH v5 1/1] devtools: add tracepoint check in checkpatch

2023-03-07 Thread Ankur Dwivedi
This patch adds a validation in checkpatch tool, to check if a tracepoint is present in any new function added in cryptodev, ethdev, eventdev and mempool library. In this patch, the build_map_changes function is copied from check-symbol-change.sh to check-tracepoint.sh. The check-tracepoint.sh scr

Re: [PATCH 1/5] ethdev: fix race-condition of proactive error handling mode

2023-03-07 Thread Ferruh Yigit
On 3/7/2023 8:25 AM, fengchengwen wrote: > > > On 2023/3/6 19:13, Konstantin Ananyev wrote: >> >> >> In the proactive error handling mode, the PMD will set the data path >> pointers to dummy functions and then try recovery, in this period the >> application may still invok

Re: [PATCH 1/5] ethdev: fix race-condition of proactive error handling mode

2023-03-07 Thread fengchengwen
On 2023/3/7 20:07, Ferruh Yigit wrote: > On 3/7/2023 8:25 AM, fengchengwen wrote: >> >> >> On 2023/3/6 19:13, Konstantin Ananyev wrote: >>> >>> >>> In the proactive error handling mode, the PMD will set the data path >>> pointers to dummy functions and then try recovery, in this per

RE: [PATCH 1/5] ethdev: fix race-condition of proactive error handling mode

2023-03-07 Thread Konstantin Ananyev
> >>> In the proactive error handling mode, the PMD will set the data > >>> path > >>> pointers to dummy functions and then try recovery, in this period > >>> the > >>> application may still invoking data path API. This will introduce > >>> a > >

RE: [PATCH 2/2] net/mlx5: add MPLS tunnel support for HWS

2023-03-07 Thread Slava Ovsiienko
> -Original Message- > From: Michael Baum > Sent: среда, 8 февраля 2023 г. 08:19 > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Slava Ovsiienko ; Ori Kam > > Subject: [PATCH 2/2] net/mlx5: add MPLS tunnel support for HWS > > Add support for MPLS tunnel item in HWS. > > Sign

RE: [PATCH v3 1/2] net/mlx5/hws: support matching on MPLSoUDP

2023-03-07 Thread Slava Ovsiienko
> -Original Message- > From: Michael Baum > Sent: четверг, 23 февраля 2023 г. 09:48 > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Slava Ovsiienko ; Erez Shitrit > > Subject: [PATCH v3 1/2] net/mlx5/hws: support matching on MPLSoUDP > > From: Erez Shitrit > > Add support f

Re: [PATCH] net/nfp: write link speed to control BAR

2023-03-07 Thread Ferruh Yigit
On 3/6/2023 7:06 AM, Chaoyong He wrote: >> On 2/21/2023 6:29 AM, Chaoyong He wrote: >>> From: James Hershaw >>> >>> Due to changes in the firmware for NFPs, firmware will no longer write >>> the link speed of a port to the control BAR. In line with the >>> behaviour of the kernel NFP driver, this

Re: [PATCH] service: split tests to perf and autotest to avoid spurious CI failures

2023-03-07 Thread David Marchand
On Fri, Mar 3, 2023 at 11:59 AM Van Haaren, Harry wrote: > > > + .setup = testsuite_setup, > > > + .teardown = testsuite_teardown, > > > + .unit_test_cases = { > > > + TEST_CASE_ST(dummy_register, NULL, service_attr_get), > > > + TEST_CASE_ST(dummy_reg

Re: [PATCH v2] service: split tests to perf and autotest to avoid spurious CI failures

2023-03-07 Thread David Marchand
On Fri, Mar 3, 2023 at 2:01 PM Harry van Haaren wrote: > > On some CI runs, some service-cores tests spuriously fail as the > service lcore thread is not actually scheduled by the OS in the > given amount of time. > > Increasing timeouts has not resolved the issue in the CI, so the > solution in t

Re: [PATCH v2] eal: fix thread race in control thread creation

2023-03-07 Thread David Marchand
On Thu, Mar 2, 2023 at 5:18 AM Honnappa Nagarahalli wrote: > > > > if (ctrl_thread_init(arg) != 0) > > > > return NULL; > > > > > > > > - return start_routine(params->arg); > > > > + return start_routine(start_arg); > > > We can free 'params' here after 'start_routine' returns. > > > >

Re: [PATCH v9 01/21] net/cpfl: support device initialization

2023-03-07 Thread Ferruh Yigit
On 3/2/2023 9:20 PM, Mingxia Liu wrote: > Support device init and add the following dev ops: > - dev_configure > - dev_close > - dev_infos_get > - link_update > - dev_supported_ptypes_get > > Signed-off-by: Mingxia Liu <...> > +static void > +cpfl_handle_virtchnl_msg(struct cpfl_adapter_ex

Re: [PATCH] net/nfp: reset profile config while modify profile

2023-03-07 Thread Ferruh Yigit
On 2/28/2023 8:56 AM, Chaoyong He wrote: > From: Jin Liu > > While changing meter profile from pps rate limit mode to bps, > the profile configuration was not reset, leaving the profile > in pps mode. This lead to incorrect operation. > > Fix this by clearing the profile before configuring it. >

Re: [PATCH 1/2] eal: fix failure race and behavior of thread create

2023-03-07 Thread David Marchand
On Thu, Mar 2, 2023 at 7:44 PM Tyler Retzlaff wrote: > > In rte_thread_create setting affinity after pthread_create may fail. > Such a failure should result in the entire rte_thread_create failing > but doesn't. > > Additionally if there is a failure to set affinity a race exists where > the creat

Re: [PATCH v9 01/21] net/cpfl: support device initialization

2023-03-07 Thread Ferruh Yigit
On 3/7/2023 2:11 PM, Ferruh Yigit wrote: > On 3/2/2023 9:20 PM, Mingxia Liu wrote: >> Support device init and add the following dev ops: >> - dev_configure >> - dev_close >> - dev_infos_get >> - link_update >> - dev_supported_ptypes_get >> >> Signed-off-by: Mingxia Liu > > <...> > >> +stati

[PATCH] doc: fix naming of NVIDIA devices

2023-03-07 Thread Thomas Monjalon
The networking NVIDIA devices may be named as the following, using 0 and Ax as fake suffixes: - ConnectX-0 - ConnectX-0 Ax - BlueField-0 Casing and missing hyphens are fixed to avoid future wrong copy/paste. Signed-off-by: Thomas Monjalon --- doc/guides/nics/mlx5.rst

Re: [PATCH] net/nfp: fix the offload of multiple output actions

2023-03-07 Thread Ferruh Yigit
On 2/28/2023 9:03 AM, Chaoyong He wrote: > When offload the flow with multiple output actions, the > original logic add a flag to every output action wrongly, > and this cause only the first output action can take effect. > Fix it by only add the flag to the last output action. > > Fixes: 4d946034

Re: [PATCH v3 0/2] Add option to timestamp console log

2023-03-07 Thread Stephen Hemminger
On Tue, 7 Mar 2023 08:33:17 +0100 Morten Brørup wrote: > Here's some feature creep: Since the timestamp output is configurable, there > is no need to settle on one specific timestamp format. The option could allow > a choice between MONOTONIC and REALTIME, with an option for REALTIME to > incl

Re: [PATCH v3 2/2] eal: add option to put timestamp on console output

2023-03-07 Thread Stephen Hemminger
On Tue, 7 Mar 2023 17:35:32 +0800 fengchengwen wrote: > On 2023/3/7 3:28, Stephen Hemminger wrote: > > When debugging driver or startup issues, it is useful to have > > a timestamp on each message printed. The messages in syslog > > already have a timestamp, but often syslog is not available > >

Re: [PATCH v3 2/2] eal: add option to put timestamp on console output

2023-03-07 Thread Stephen Hemminger
On Tue, 7 Mar 2023 17:35:32 +0800 fengchengwen wrote: > The syslog will add timestamp, but the syslog backend will re-write > timestamp, so > in the last, you can't find the real-timestamp of this log print. sometimes > it requires > to get real log time. > PS: we found it in our test environme

RE: [PATCH v2] net/mlx5: use just sufficient barrier for Arm platforms

2023-03-07 Thread Slava Ovsiienko
Hi, Honnappa I'm sorry for delay - I had to play with patch, to compile this one with assembly listings and check what code is actually generated on x86/ARM. On x86 there is no difference at all (with and w/o patch), so no objection from my side. On ARM we have: w/o patch: dmb oshld with patch:

RE: [PATCH] mlx5: initially reading xstats does not cause seg fault

2023-03-07 Thread Slava Ovsiienko
Hi, Huzaifa Could you, please, format commit message with capitals in the sentence beginnings? And explanation can be less wordy a little bit. With best regards, Slava > -Original Message- > From: huzaifa.rahman > Sent: четверг, 18 августа 2022 г. 15:30 > To: Matan Azrad > Cc: dev@dpdk

RE: [PATCH] mlx5: initially reading xstats does not cause seg fault

2023-03-07 Thread Slava Ovsiienko
Hi, Huzaifa "n" - is the parameter of the mlx5_xstats_get() routine, provided by caller. We should not change this - it specified the size of "struct rte_eth_xstat *stats " array. With best regards, Slava > -Original Message- > From: huzaifa.rahman > Sent: четверг, 18 августа 2022 г. 1

[PATCH] eal: use program_invocation_short_name

2023-03-07 Thread Stephen Hemminger
Glibc already has a documented variable with the program name so use it instead of computing the value. Signed-off-by: Stephen Hemminger --- lib/eal/linux/eal.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c index fabafbc39bd

RE: [PATCH] net/mlx5: fix risk in Rx descriptor read in NEON vector path

2023-03-07 Thread Slava Ovsiienko
> -Original Message- > From: Ruifeng Wang > Sent: четверг, 29 сентября 2022 г. 09:51 > To: Slava Ovsiienko ; Ali Alnubani > ; Matan Azrad > Cc: dev@dpdk.org; Honnappa Nagarahalli > ; sta...@dpdk.org; nd ; nd > > Subject: RE: [PATCH] net/mlx5: fix risk in Rx descriptor read in NEON vector

[PATCH 0/3] cryptodev test improvements

2023-03-07 Thread Ciara Power
The meson driver-tests suite was missing some QAT and SW PMD crypto tests, which are now added. Some issues were highlighted after adding to the driver-tests suite, which are also addressed in this patchset. Ciara Power (3): test/crypto: fix skip condition for CPU crypto SGL test/crypto: skip

[PATCH 2/3] test/crypto: skip asym test if driver or device missing

2023-03-07 Thread Ciara Power
Asym crypto tests returned FAILED if the required driver wasn't loaded, or no suitable device was found. This is now updated to return SKIPPED in these cases, which better reflects the status of the test, and follows the convention set in the sym crypto tests in similar circumstances. Signed-off-

[PATCH 1/3] test/crypto: fix skip condition for CPU crypto SGL

2023-03-07 Thread Ciara Power
When SGL support was added to AESNI_MB PMD, the feature flag was enabled. This meant SGL testcases were incorrectly running for the cryptodev_cpu_aesni_mb_autotest, and SGL support was not added for CPU crypto. Now skipping the ZUC auth cipher SGL tests for CPU crypto, and GCM authenticated encryp

[PATCH 3/3] app/test: add more cryptodev tests to meson suite

2023-03-07 Thread Ciara Power
The meson driver-tests suite did not include some ipsec_mb SW Crypto PMD tests, and QAT tests. These are now added to avoid them being missed if the user runs tests only using the meson suite infrastructure. Signed-off-by: Ciara Power --- app/test/meson.build | 5 + 1 file changed, 5 inserti

RE: [EXT] [PATCH 3/3] app/test: add more cryptodev tests to meson suite

2023-03-07 Thread Akhil Goyal
> Subject: [EXT] [PATCH 3/3] app/test: add more cryptodev tests to meson suite > > The meson driver-tests suite did not include some ipsec_mb SW Crypto > PMD tests, and QAT tests. These are now added to avoid them being missed > if the user runs tests only using the meson suite infrastructure. >

RE: [EXT] [PATCH 3/3] app/test: add more cryptodev tests to meson suite

2023-03-07 Thread Power, Ciara
Hi Akhil, > -Original Message- > From: Akhil Goyal > Sent: Tuesday 7 March 2023 17:23 > To: Power, Ciara ; dev@dpdk.org > Cc: Ji, Kai > Subject: RE: [EXT] [PATCH 3/3] app/test: add more cryptodev tests to meson > suite > > > Subject: [EXT] [PATCH 3/3] app/test: add more cryptodev tests

RE: [PATCH 1/3] test/crypto: fix skip condition for CPU crypto SGL

2023-03-07 Thread Ji, Kai
Acked-by: Kai Ji > -Original Message- > From: Power, Ciara > Sent: Tuesday, March 7, 2023 5:18 PM > To: dev@dpdk.org > Cc: Ji, Kai ; Power, Ciara ; > Akhil Goyal ; Fan Zhang > Subject: [PATCH 1/3] test/crypto: fix skip condition for CPU crypto SGL > > When SGL support was added to AESN

RE: [PATCH 0/3] cryptodev test improvements

2023-03-07 Thread Ji, Kai
Acked-by: Kai Ji > -Original Message- > From: Power, Ciara > Sent: Tuesday, March 7, 2023 5:18 PM > To: dev@dpdk.org > Cc: Ji, Kai ; Power, Ciara > Subject: [PATCH 0/3] cryptodev test improvements > > The meson driver-tests suite was missing some QAT and SW PMD crypto > tests, which ar

RE: [PATCH 0/3] cryptodev test improvements

2023-03-07 Thread Ji, Kai
Series-acked-by: Kai Ji > -Original Message- > From: Power, Ciara > Sent: Tuesday, March 7, 2023 5:18 PM > To: dev@dpdk.org > Cc: Ji, Kai ; Power, Ciara > Subject: [PATCH 0/3] cryptodev test improvements > > The meson driver-tests suite was missing some QAT and SW PMD crypto > tests, w

RE: [EXT] [PATCH 3/3] app/test: add more cryptodev tests to meson suite

2023-03-07 Thread Akhil Goyal
Hi Ciara, > Hi Akhil, > > > -Original Message- > > From: Akhil Goyal > > Sent: Tuesday 7 March 2023 17:23 > > To: Power, Ciara ; dev@dpdk.org > > Cc: Ji, Kai > > Subject: RE: [EXT] [PATCH 3/3] app/test: add more cryptodev tests to meson > > suite > > > > > Subject: [EXT] [PATCH 3/3] app/

Re: [PATCH v2] eal: fix thread race in control thread creation

2023-03-07 Thread Tyler Retzlaff
On Tue, Mar 07, 2023 at 02:53:34PM +0100, David Marchand wrote: > On Thu, Mar 2, 2023 at 5:18 AM Honnappa Nagarahalli > wrote: > > > > > if (ctrl_thread_init(arg) != 0) > > > > > return NULL; > > > > > > > > > > - return start_routine(params->arg); > > > > > + return start_routine(star

ixgbe rxq interrupt not working

2023-03-07 Thread Rajasekhar Pulluru
Hi Team, Bringing-up dpdk-22.07 on an intel machine with 8 ports, 4 of them driven by igb and the rest of the 4 ports driven by ixgbe. I am following the below sequence to initialize these ports: dev_conf.intr_conf.lsc = 1; //Enable link state change interrupt dev_conf.intr_conf.rxq = 1; //Enabl

[PATCH] net/i40e: avx512 fast-free path bug fix

2023-03-07 Thread Kamalakshitha Aligeri
In i40e_tx_free_bufs_avx512 fast-free path, when cache is NULL, non fast-free path is being executed. Fixed the bug by calling rte_mempool_generic_put API that handles the cache==NULL case. Fixes: 5171b4ee6b6b ("net/i40e: optimize Tx by using AVX512") Cc: leyi.r...@intel.com Cc: sta...@dpdk.org S

RE: [PATCH] net/i40e: avx512 fast-free path bug fix

2023-03-07 Thread Morten Brørup
> From: Kamalakshitha Aligeri [mailto:kamalakshitha.alig...@arm.com] > Sent: Tuesday, 7 March 2023 20.32 > > In i40e_tx_free_bufs_avx512 fast-free path, when cache is NULL, > non fast-free path is being executed. Fixed the bug by calling > rte_mempool_generic_put API that handles the cache==NULL c

Re: [PATCH v3 1/3] ethdev: enable direct rearm with separate API

2023-03-07 Thread Ferruh Yigit
On 3/7/2023 6:12 AM, Honnappa Nagarahalli wrote: > > >> >> On 3/6/2023 1:26 PM, Morten Brørup wrote: From: Ferruh Yigit [mailto:ferruh.yi...@amd.com] Sent: Monday, 6 March 2023 13.49 On 1/4/2023 8:21 AM, Morten Brørup wrote: >> From: Feifei Wang [mailto:feifei.wa...@arm.co

Re: ixgbe rxq interrupt not working

2023-03-07 Thread Stephen Hemminger
On Wed, 8 Mar 2023 00:22:10 +0530 Rajasekhar Pulluru wrote: > Hi Team, > > Bringing-up dpdk-22.07 on an intel machine with 8 ports, 4 of them driven > by igb and the rest of the 4 ports driven by ixgbe. FYI - 22.07 is not a supported release, only LTS releases like 22.11 are supported.

RE: ixgbe rxq interrupt not working

2023-03-07 Thread Honnappa Nagarahalli
From: Rajasekhar Pulluru Sent: Tuesday, March 7, 2023 12:52 PM To: dev@dpdk.org Subject: ixgbe rxq interrupt not working Hi Team, Bringing-up dpdk-22.07 on an intel machine with 8 ports, 4 of them driven by igb and the rest of the 4 ports driven by ixgbe. [Honnappa] Do you have packets cro

Re: [PATCH v3 2/2] eal: add option to put timestamp on console output

2023-03-07 Thread fengchengwen
On 2023/3/8 0:06, Stephen Hemminger wrote: > On Tue, 7 Mar 2023 17:35:32 +0800 > fengchengwen wrote: > >> The syslog will add timestamp, but the syslog backend will re-write >> timestamp, so >> in the last, you can't find the real-timestamp of this log print. sometimes >> it requires >> to g

RE: [PATCH 1/5] ethdev: fix race-condition of proactive error handling mode

2023-03-07 Thread Honnappa Nagarahalli
> > > >>> > >>> Is there any reason not to design this in the same way as > >> 'rte_eth_dev_reset'? Why does the PMD have to recover by itself? > >> > >> I suppose it is a question for the authors of original patch... > > Appreciate if the authors could comment on this. > > The main cause is

Re: [PATCH v3 2/2] eal: add option to put timestamp on console output

2023-03-07 Thread Stephen Hemminger
On Wed, 8 Mar 2023 08:36:48 +0800 fengchengwen wrote: > On 2023/3/8 0:06, Stephen Hemminger wrote: > > On Tue, 7 Mar 2023 17:35:32 +0800 > > fengchengwen wrote: > > > >> The syslog will add timestamp, but the syslog backend will re-write > >> timestamp, so > >> in the last, you can't find th

RE: [PATCH v3] app/testpmd: fix secondary process not forwarding

2023-03-07 Thread He, ShiyangX
>-Original Message- >From: Ferruh Yigit >Sent: Tuesday, March 7, 2023 7:41 PM >To: He, ShiyangX ; dev@dpdk.org >Cc: Zhou, YidingX ; sta...@dpdk.org; Zhang, Yuying >; Singh, Aman Deep >; Burakov, Anatoly >; Matan Azrad ; Dmitry >Kozlyuk >Subject: Re: [PATCH v3] app/testpmd: fix secondary

[PATCH] net/nfp: fix MTU configuration order

2023-03-07 Thread Chaoyong He
From: Peng Zhang If rte_eth_dev_set_mtu() is called before rte_eth_rx_queue_setup() the NFP driver setup fails. This is because the default values evaluated when setting the MTU are initialized in the rte_eth_rx_queue_setup() code path. Fix this by instead initializing the MTU default values in t

Reminder - DPDK Tech Board Call - Tomorrow Wed. 3/8 at 7am PT/10am ET/1600h CET

2023-03-07 Thread Nathan Southern
Good evening, Tomorrow, Wed. Mar. 8, 2023, the DPDK Project will hold its biweekly tech board meeting, at 7am PT/10am ET/1600h CET. You may connect to the meeting here: https://meet.jit.si/dpdk

Re: [PATCH] net/nfp: fix MTU configuration order

2023-03-07 Thread Stephen Hemminger
On Wed, 8 Mar 2023 10:33:18 +0800 Chaoyong He wrote: > diff --git a/drivers/net/nfp/nfp_common.c b/drivers/net/nfp/nfp_common.c > index 5922bfea8e..5d92b476e2 100644 > --- a/drivers/net/nfp/nfp_common.c > +++ b/drivers/net/nfp/nfp_common.c > @@ -1126,9 +1126,9 @@ nfp_net_dev_mtu_set(struct rte_e

Re: [PATCH v3 2/2] eal: add option to put timestamp on console output

2023-03-07 Thread Stephen Hemminger
On Wed, 8 Mar 2023 08:36:48 +0800 fengchengwen wrote: > > Never, never configure a DPDK application with real-time process priority. > > Polling model and RT don't mix. > > Maybe we should document them ? LOL - ChatGPT is amusing if you ask it. The answer is pro grammatically correct, but wi

Re: [PATCH v3] app/testpmd: fix secondary process not forwarding

2023-03-07 Thread lihuisong (C)
在 2023/3/8 10:05, He, ShiyangX 写道: -Original Message- From: Ferruh Yigit Sent: Tuesday, March 7, 2023 7:41 PM To: He, ShiyangX ; dev@dpdk.org Cc: Zhou, YidingX ; sta...@dpdk.org; Zhang, Yuying ; Singh, Aman Deep ; Burakov, Anatoly ; Matan Azrad ; Dmitry Kozlyuk Subject: Re: [PATCH v

RE: [PATCH 0/5] net/mlx5: add indirect QUOTA create/query/modify

2023-03-07 Thread Suanming Mou
Hi Gregory, The code looks good to me. But I assume doc update is missing here. Can you please update the relevant doc and release notes? BR, Suanming Mou > -Original Message- > From: Gregory Etelson > Sent: Wednesday, January 18, 2023 8:56 PM > To: dev@dpdk.org > Cc: Gregory Etelson ;

RE: [PATCH] net/mlx5: reject flow template API reconfiguration

2023-03-07 Thread Suanming Mou
> -Original Message- > From: Dariusz Sosnowski > Sent: Sunday, February 26, 2023 3:58 AM > To: Matan Azrad ; Slava Ovsiienko > > Cc: dev@dpdk.org > Subject: [PATCH] net/mlx5: reject flow template API reconfiguration > > Flow Template API allows rte_flow_configure() to be called more t

RE: [PATCH 1/2] net/mlx5: fix egress group translation in HWS

2023-03-07 Thread Suanming Mou
> -Original Message- > From: Dariusz Sosnowski > Sent: Sunday, February 26, 2023 4:18 AM > To: Matan Azrad ; Slava Ovsiienko > > Cc: dev@dpdk.org; sta...@dpdk.org; Ori Kam > Subject: [PATCH 1/2] net/mlx5: fix egress group translation in HWS > > With HW Steering enabled creating egres

RE: [PATCH 2/2] net/mlx5: fix isolated mode when repr matching is disabled

2023-03-07 Thread Suanming Mou
> -Original Message- > From: Dariusz Sosnowski > Sent: Sunday, February 26, 2023 4:18 AM > To: Matan Azrad ; Slava Ovsiienko > > Cc: dev@dpdk.org; sta...@dpdk.org; Ori Kam > Subject: [PATCH 2/2] net/mlx5: fix isolated mode when repr matching is > disabled > > In HW steering mode, wh

RE: [PATCH v3 2/2] net/mlx5: add MPLS tunnel support for HWS

2023-03-07 Thread Suanming Mou
> -Original Message- > From: Michael Baum > Sent: Thursday, February 23, 2023 3:48 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Slava Ovsiienko ; Ori Kam > > Subject: [PATCH v3 2/2] net/mlx5: add MPLS tunnel support for HWS > > Add support for MPLS tunnel item in HWS

[PATCH v2] net/ice: fix incorrect Rx timestamp

2023-03-07 Thread Simei Su
For E822, the time value in Rx Flex Descriptors is 0 due to the missing PHY clock timer setup. Also, the source clock index in use is based on device capabilities instead of always being zero. Fixes: 953e74e6b73a ("net/ice: enable Rx timestamp on flex descriptor") Fixes: 646dcbe6c701 ("net/ice: su

RE: [PATCH v2] net/ice: fix incorrect Rx timestamp

2023-03-07 Thread Wu, Wenjun1
> -Original Message- > From: Su, Simei > Sent: Wednesday, March 8, 2023 12:37 PM > To: Zhang, Qi Z ; Yang, Qiming > > Cc: dev@dpdk.org; Wu, Wenjun1 ; Su, Simei > ; sta...@dpdk.org > Subject: [PATCH v2] net/ice: fix incorrect Rx timestamp > > For E822, the time value in Rx Flex Descrip

Re: Testpmd/l3fwd port shutdown failure on Arm Altra systems

2023-03-07 Thread Juraj Linkeš
Hello Qiming, Beilei, Another reminder - are you looking at this by any chance? The high level short description is that testpmd/l3fwd breaks a link between two servers while VPP (using DPDK) doesn't. This leads us to believe there's a problem with testpmd/l3fwd/i40e driver in DPDK. Thanks, Jura

RE: [PATCH v2] net/ice: fix incorrect Rx timestamp

2023-03-07 Thread Zhang, Qi Z
> -Original Message- > From: Wu, Wenjun1 > Sent: Wednesday, March 8, 2023 2:00 PM > To: Su, Simei ; Zhang, Qi Z ; > Yang, Qiming > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: RE: [PATCH v2] net/ice: fix incorrect Rx timestamp > > > > > -Original Message- > > From: Su, Simei

Re: [PATCH 6/9] net/hns3: fix segment fault when parse runtime config

2023-03-07 Thread Dongdong Liu
On 2023/3/2 15:50, Chengwen Feng wrote: The rte_kvargs_process() was used to parse KV pairs, it also supports to parse 'only keys' (e.g. socket_id) type. And the callback function parameter 'value' is NULL when parsed 'only keys'. This patch fixes segment fault when parse input args with 'only