Hi Akhil, > -----Original Message----- > From: Akhil Goyal <gak...@marvell.com> > Sent: Tuesday 7 March 2023 17:23 > To: Power, Ciara <ciara.po...@intel.com>; dev@dpdk.org > Cc: Ji, Kai <kai...@intel.com> > Subject: RE: [EXT] [PATCH 3/3] app/test: add more cryptodev tests to meson > suite > > > Subject: [EXT] [PATCH 3/3] app/test: add more cryptodev tests to meson > > suite > > > > The meson driver-tests suite did not include some ipsec_mb SW Crypto > > PMD tests, and QAT tests. These are now added to avoid them being > > missed if the user runs tests only using the meson suite infrastructure. > > > > Signed-off-by: Ciara Power <ciara.po...@intel.com> > > --- > This patch is ok for now, but it is not scalable. > We should look for a way to consolidate all cryptodev autotests under one > name.
I actually had started out to add all the missing cryptodev tests (bcmfs, caam_jr, ccp, nitrox etc.), But the docs mention it's up to the maintainer/developer to decide whether the tests should be included in the meson test suite or not. So, because I was unaware of the reasoning behind leaving them out, I just stuck to adding QAT + ipsec_mb ones in. I guess, if we have them all under one name, it would remove that level of granularity for which tests are added. Not sure if that is needed or not? Thanks, Ciara