Re: [PATCH v3] app/testpmd: fix secondary process not forwarding

2023-02-23 Thread lihuisong (C)
在 2023/2/23 22:41, Shiyang He 写道: Under multi-process scenario, the secondary process gets queue state from the wrong location (the global variable 'ports'). Therefore, the secondary process can not forward since "stream_init" is not called. This commit fixes the issue by calling 'rte_eth_rx/t

RE: [PATCH] net/iavf: fix avx512 Tx path

2023-02-23 Thread Xu, Ke1
> -Original Message- > From: Zeng, ZhichaoX > Sent: Wednesday, February 22, 2023 4:13 PM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Xu, Ke1 ; Chu, > Haijun ; Zeng, ZhichaoX ; > Wu, Jingjing ; Xing, Beilei ; > Richardson, Bruce ; Konstantin Ananyev > ; Zhou, YidingX > Subject: [PATCH] net/ia

Re: [PATCH 2/2] ethdev: fix race condition in fast-path ops setup

2023-02-23 Thread fengchengwen
On 2023/2/23 12:40, Honnappa Nagarahalli wrote: > > >> >> On 2023/2/20 14:08, Ashok Kaladi wrote: >>> If ethdev enqueue or dequeue function is called during >>> eth_dev_fp_ops_setup(), it may get pre-empted after setting the >>> function pointers, but before setting the pointe

Re: [PATCH v1 07/13] test/bbdev: add support for BLER for 4G

2023-02-23 Thread Maxime Coquelin
Hi Hernan, On 2/22/23 22:55, Vargas, Hernan wrote: Hi Maxime, -Original Message- From: Maxime Coquelin Sent: Monday, February 20, 2023 9:44 AM To: Vargas, Hernan ; dev@dpdk.org; gak...@marvell.com; Rix, Tom Cc: Chautru, Nicolas ; Zhang, Qi Z Subject: Re: [PATCH v1 07/13] test/bbdev:

Re: [PATCH v4 00/10] dts: add hello world testcase

2023-02-23 Thread Juraj Linkeš
On Wed, Feb 22, 2023 at 5:43 PM Bruce Richardson wrote: > > On Mon, Feb 20, 2023 at 11:13:45AM +0100, Juraj Linkeš wrote: > > Thanks for the comments, Bruce. > > > > On Fri, Feb 17, 2023 at 6:26 PM Bruce Richardson > > wrote: > > > > > > On Mon, Feb 13, 2023 at 04:28:36PM +0100, Juraj Linkeš wrot

Re: [PATCH v2 04/16] test/bbdev: add timeout for latency tests

2023-02-23 Thread Maxime Coquelin
On 2/22/23 22:13, Vargas, Hernan wrote: Hi Maxime, -Original Message- From: Maxime Coquelin Sent: Monday, February 20, 2023 10:33 AM To: Vargas, Hernan ; dev@dpdk.org; gak...@marvell.com; Rix, Tom Cc: Chautru, Nicolas ; Zhang, Qi Z Subject: Re: [PATCH v2 04/16] test/bbdev: add tim

RE: release candidate 23.03-rc1

2023-02-23 Thread Jiang, YuX
> -Original Message- > From: Thomas Monjalon > Sent: Tuesday, February 21, 2023 12:49 AM > To: annou...@dpdk.org > Subject: release candidate 23.03-rc1 > > A new DPDK release candidate is ready for testing: > https://git.dpdk.org/dpdk/tag/?id=v23.03-rc1 > > There are 566 new patches

Re: [PATCH v2 1/9] baseband/acc: protection for TB negative scenario

2023-02-23 Thread Maxime Coquelin
On 2/10/23 18:58, Nicolas Chautru wrote: Adding handling of negative scenario for malformed Transport Block mode operations. Fixes: bec597b78a0 ("baseband/acc200: add LTE processing") The format is invalid, the sha-1 should be 12B long, checkpatch complains about it: WARNING:BAD_FIXES_TAG:

Re: unable to bind to vfio-pci

2023-02-23 Thread Nagendra Prabhu A T
These are the messages i am seeing dmesg [16588.298660] vfio-pci: probe of :8a:00.2 failed with error -22 [16591.574630] i40e :8a:00.3: i40e_ptp_stop: removed PHC on enp138s0f3 [16593.138613] vfio-pci: probe of :8a:00.3 failed with error -22 [16593.138674] vfio-pci: probe of :8a:00

Re: unable to bind to vfio-pci

2023-02-23 Thread Nagendra Prabhu A T
HI Bruce, Thanks for your reply. I have removed the binding of all other ports. So , i can confirm that #2 is taken care of. I tried using a different driver "uio_pci_generic". I still see the same issue for that driver as well. The problem seems to be because the write operation is not happeni

Re: unable to bind to vfio-pci

2023-02-23 Thread Nagendra Prabhu A T
On Tue, Feb 21, 2023 at 9:57 PM Bruce Richardson wrote: > On Tue, Feb 21, 2023 at 09:46:30PM +0530, Nagendra Prabhu A T wrote: > >These are the messages i am seeing dmesg > >[16588.298660] vfio-pci: probe of :8a:00.2 failed with error -22 > >[16591.574630] i40e :8a:00.3: i40e_

RE: [PATCH v4 02/12] app/mldev: add common test functions

2023-02-23 Thread Anup Prabhu
> -Original Message- > From: Srikanth Yalavarthi > Sent: Tuesday, February 7, 2023 9:20 PM > To: Srikanth Yalavarthi > Cc: dev@dpdk.org; Shivah Shankar Shankar Narayan Rao > ; Jerin Jacob Kollanukkaran > ; Anup Prabhu ; Prince Takkar > ; Parijat Shukla > Subject: [PATCH v4 02/12] app/m

Re: [PATCH v4 00/10] dts: add hello world testcase

2023-02-23 Thread Bruce Richardson
On Thu, Feb 23, 2023 at 09:27:05AM +0100, Juraj Linkeš wrote: > On Wed, Feb 22, 2023 at 5:43 PM Bruce Richardson > wrote: > > > > On Mon, Feb 20, 2023 at 11:13:45AM +0100, Juraj Linkeš wrote: > > > Thanks for the comments, Bruce. > > > > > > On Fri, Feb 17, 2023 at 6:26 PM Bruce Richardson > > >

Re: [PATCH v2 0/9] baseband/acc: VRB PMD fixes

2023-02-23 Thread Maxime Coquelin
On 2/10/23 18:58, Nicolas Chautru wrote: Hi, v2: updated based on Maxime's review (commit messages and adding unlikely statement). Thanks. Let me know if further change is required. Series of mainly fixes for corner-cases and protection in the VRB PMD. The last 2 commits are not fixes but ad

Re: [PATCH v3 0/3] DPDK Coverity issue 381631, 381646

2023-02-23 Thread Maxime Coquelin
On 2/22/23 17:40, Hernan Vargas wrote: v3: Split commits further for clarity. v2: Split code unrelated to coverity fix in separate commit. v1: Upstream fix to 23.03 for potential issue of dereferencing a pointer before null check. Hernan Vargas (3): baseband/acc: fix check after deref and

Re: [RFC PATCH 0/1] Specify C-standard requirement for DPDK builds

2023-02-23 Thread Bruce Richardson
On Wed, Feb 22, 2023 at 10:53:44AM -0800, Tyler Retzlaff wrote: > On Thu, Jan 12, 2023 at 11:35:55AM +, Bruce Richardson wrote: > > Traditionally, DPDK has never specified a minimum C standard used either > > in DPDK builds or for applications using DPDK. Following discussion > > on-list about

Re: [PATCH v5] net/gve: add Rx/Tx queue stats as extended stats

2023-02-23 Thread Ferruh Yigit
On 2/23/2023 2:49 AM, Guo, Junfeng wrote: >> -Original Message- >> From: Levend Sayar >> Sent: Wednesday, February 22, 2023 00:44 >> To: Ferruh Yigit >> Cc: Guo, Junfeng ; dev@dpdk.org >> Subject: Re: [PATCH v5] net/gve: add Rx/Tx queue stats as extended stats >> >> Thanks Ferruh for the

Re: [PATCH v3 1/2] net/gve: fix Rx no mbufs stats counter update

2023-02-23 Thread Ferruh Yigit
On 2/23/2023 4:34 AM, Guo, Junfeng wrote: On 2/20/2023 9:11 PM, Levend Sayar wrote: > rx no_mbufs stats counter update is added for another error case. > > Fixes: 4f6b1dd8240c ("net/gve: support basic statistics") > Cc: junfeng@intel.com > > Signed-off-by: Levend S

Re: [PATCH v3 1/2] net/gve: fix Rx no mbufs stats counter update

2023-02-23 Thread Levend Sayar
Thanks Ferruh For applying. > On 23 Feb 2023, at 14:10, Ferruh Yigit wrote: > > On 2/23/2023 4:34 AM, Guo, Junfeng wrote: > > On 2/20/2023 9:11 PM, Levend Sayar wrote: >> rx no_mbufs stats counter update is added for another error case. >> >> Fixes: 4f6b1dd8240c ("net/gve: supp

Re: [PATCH v5] net/gve: add Rx/Tx queue stats as extended stats

2023-02-23 Thread Levend Sayar
Thanks Ferruh for applying. > On 23 Feb 2023, at 14:09, Ferruh Yigit wrote: > > On 2/23/2023 2:49 AM, Guo, Junfeng wrote: > >>> -Original Message- >>> From: Levend Sayar >>> Sent: Wednesday, February 22, 2023 00:44 >>> To: Ferruh Yigit >>> Cc: Guo, Junfeng ; dev@dpdk.org >>> Subject:

[PATCH v1 0/2] bug fix in ethdev trace

2023-02-23 Thread Ankur Dwivedi
The first patch in this series adds fix for bug and coverity. The second patch makes change to pass structure pointer instead of the structure value, to avoid 64 bytes copy in function call stack for rte_eth_trace_xstats_get_names. Ankur Dwivedi (2): ethdev: fix null pointer dereference ethdev

[PATCH v1 1/2] ethdev: fix null pointer dereference

2023-02-23 Thread Ankur Dwivedi
The speed_fec_capa pointer can be null. So dereferencing the pointer is removed and only the pointer is captured in trace function. Fixed few more trace functions in which null pointer can be dereferenced. Coverity issue: 383238 Bugzilla ID: 1162 Fixes: 6679cf21d608 ("ethdev: add trace points") Fi

[PATCH v1 2/2] ethdev: pass structure pointer

2023-02-23 Thread Ankur Dwivedi
The rte_eth_xstat_name structure is of size 64 bytes. Instead of passing the structure as value it is passed as a pointer, to avoid copy of 64 bytes in function call stack. Signed-off-by: Ankur Dwivedi --- lib/ethdev/ethdev_trace.h | 4 ++-- lib/ethdev/rte_ethdev.c | 2 +- 2 files changed, 3 i

[Bug 1164] iperf3 traffic stalls when using memif driver to interconnect l2fwd in zero-copy mode with test-pmd app

2023-02-23 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1164 Bug ID: 1164 Summary: iperf3 traffic stalls when using memif driver to interconnect l2fwd in zero-copy mode with test-pmd app Product: DPDK Version: 22.11 Hardware: All

Re: [PATCH v3 6/7] doc/mlx5: update mlx5 doc

2023-02-23 Thread Thomas Monjalon
23/02/2023 08:06, Rongwei Liu: > Add flex item matching and modify field feature into > mlx5 documents. > > Signed-off-by: Rongwei Liu > Acked-by: Viacheslav Ovsiienko Please don't do a separate commit for doc update. The doc should be updated with the related code in the same patch.

[PATCH v4 0/6] add flex item implementation

2023-02-23 Thread Rongwei Liu
Implement the flex item matching and modify field in HWS. v4: squash doc commit. v3: add error message for testpmd output. Rongwei Liu (6): net/mlx5: enable hws flex item create net/mlx5: add IPv6 protocol as flex item input net/mlx5/hws: add hws flex item matching support net/mlx5: add f

[PATCH v4 2/6] net/mlx5: add IPv6 protocol as flex item input

2023-02-23 Thread Rongwei Liu
Support IPv6 protocol as new flex item input link. Signed-off-by: Rongwei Liu Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5_flow_flex.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/drivers/net/mlx5/mlx5_flow_flex.c b/drivers/net/mlx5/mlx5_flow_flex.c inde

[PATCH v4 1/6] net/mlx5: enable hws flex item create

2023-02-23 Thread Rongwei Liu
Enable flex item create and destroy with dv_flow_en=2 Signed-off-by: Rongwei Liu Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/linux/mlx5_os.c | 27 +++ drivers/net/mlx5/mlx5_flow_hw.c | 2 ++ 2 files changed, 17 insertions(+), 12 deletions(-) diff --git a/drive

[PATCH v4 3/6] net/mlx5/hws: add hws flex item matching support

2023-02-23 Thread Rongwei Liu
Support flex item matching in hws and syntax follows sws exactly. Flex item should be created in advance and follow current json mapping logic. Signed-off-by: Rongwei Liu Reviewed-by: Alex Vesker Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/hws/mlx5dr_definer.c | 83 ++

[PATCH v4 4/6] net/mlx5: add flex item modify field implementation

2023-02-23 Thread Rongwei Liu
Add flex item modify field HWS implementation. The minimum modify boundary is one byte. Signed-off-by: Rongwei Liu Acked-by: Viacheslav Ovsiienko --- doc/guides/nics/mlx5.rst| 4 +- drivers/common/mlx5/mlx5_prm.h | 1 + drivers/net/mlx5/mlx5_flow.h| 3 + drivers/net/mlx5/mlx5

[PATCH v4 5/6] net/mlx5: return error for sws modify field

2023-02-23 Thread Rongwei Liu
Return unsupported error message when application tries to modify flex item field. Validation of packet modifications actions for SW Steering checked if either source or destination field of MODIFY_FIELD action was a flex item. When DEC_TTL action is used, DEC_TTL action does not have any action c

[PATCH v4 6/6] net/mlx5: add error message

2023-02-23 Thread Rongwei Liu
When pattern/action template creation fails the testpmd expects error details. The driver did not set the error structure and testpmd failed with a segmentation fault. Signed-off-by: Rongwei Liu Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5_flow_hw.c | 15 ++- 1 file chan

[Bug 1165] IPv6 router solicitation and neighbor discovery packets are being sent with no reason.

2023-02-23 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1165 Bug ID: 1165 Summary: IPv6 router solicitation and neighbor discovery packets are being sent with no reason. Product: DPDK Version: 21.08 Hardware: x86 OS: Linux

RE: [PATCH 2/2] ethdev: fix race condition in fast-path ops setup

2023-02-23 Thread Konstantin Ananyev
> >>> If ethdev enqueue or dequeue function is called during > >>> eth_dev_fp_ops_setup(), it may get pre-empted after setting the > >>> function pointers, but before setting the pointer to port data. > >>> In this case the newly registered enqueue/dequeue function will > >>>

Re: [PATCH] net/mana: use RTE_LOG_DP for logs on datapath

2023-02-23 Thread Ferruh Yigit
On 2/21/2023 8:42 PM, lon...@linuxonhyperv.com wrote: > diff --git a/drivers/net/mana/tx.c b/drivers/net/mana/tx.c > index 300bf27cc1..a45b5e289c 100644 > --- a/drivers/net/mana/tx.c > +++ b/drivers/net/mana/tx.c > @@ -183,17 +183,17 @@ mana_tx_burst(void *dpdk_txq, struct rte_mbuf > **tx_pkts, ui

Re: MAC address set requires decision

2023-02-23 Thread Ferruh Yigit
On 2/23/2023 4:32 AM, Hemant Agrawal wrote: > > On 22-Feb-23 11:25 PM, Honnappa Nagarahalli wrote: >> -Original Message- >>> From: Richardson, Bruce >>> Sent: Thursday, February 16, 2023 9:05 AM >>> To: Ferruh Yigit ; techbo...@dpdk.org >>> Cc: Huisong Li ; Chengwen Feng >>> >>> Subject:

Re: [PATCH v4] net/ark: support for single function with multiple port

2023-02-23 Thread Ferruh Yigit
On 2/21/2023 4:30 PM, Ed Czeck wrote: > Support the creation of multiple ports from one ark device via > the use of ark pmd extension, though the assignment of queues > to port. > > Add unique dev_private data for each port. > > This patch repairs a latent issue uncovered during testing. > > Sig

Re: [PATCH] doc: fix reference to event timer header

2023-02-23 Thread Jerin Jacob
On Mon, Feb 20, 2023 at 8:17 PM David Marchand wrote: > > The event timer header is rte_event_timer_adapter.h. > Besides, we don't need to detail the full path to such a header. > > Fixes: 30e7fbd62839 ("doc: add event timer adapter guide") > Cc: sta...@dpdk.org > > Signed-off-by: David Marchand

rte_pktmbuf_alloc() is returning same address on two consecutive calls

2023-02-23 Thread NAGENDRA BALAGANI
Hi Team, In my dpdk application, I am facing an issue where rte_pktmbuf_alloc() is returning same address for two consecutive calls in a single thread context. Following is the code snippet, int Func(struct rte_mbuf *mblk) { struct rte_mbuf *tmpbuf = nullptr;; struct

Re: MAC address set requires decision

2023-02-23 Thread Bruce Richardson
On Thu, Feb 23, 2023 at 02:18:59PM +, Ferruh Yigit wrote: > On 2/23/2023 4:32 AM, Hemant Agrawal wrote: > > > > On 22-Feb-23 11:25 PM, Honnappa Nagarahalli wrote: > >> -Original Message- > >>> From: Richardson, Bruce > >>> Sent: Thursday, February 16, 2023 9:05 AM > >>> To: Ferruh Yig

Re: [PATCH v2 1/2] net/nfp: standardize the use of RSS-related codes

2023-02-23 Thread Ferruh Yigit
On 2/21/2023 3:55 AM, Chaoyong He wrote: > From: Long Wu > > The usage of RTE_ETH_MQ_RX_RSS and RTE_ETH_MQ_RX_RSS_FLAG are mixed in > nfp_net_configure(), use RTE_ETH_MQ_RX_RSS_FLAG uniformly. > > Signed-off-by: Long Wu > Reviewed-by: Chaoyong He > Reviewed-by: Niklas Söderlund > --- > drive

[PATCH v5 00/10] dts: add hello world testcase

2023-02-23 Thread Juraj Linkeš
Add code needed to run the HelloWorld testcase which just runs the hello world dpdk application. The patchset currently heavily refactors this original DTS code needed to run the testcase: * The whole architecture has been redone into more sensible class hierarchy * DPDK build on the System unde

[PATCH v5 01/10] dts: add node and os abstractions

2023-02-23 Thread Juraj Linkeš
The abstraction model in DTS is as follows: Node, defining and implementing methods common to and the base of SUT (system under test) Node and TG (traffic generator) Node. Remote Session, defining and implementing methods common to any remote session implementation, such as SSH Session. OSSession,

[PATCH v5 02/10] dts: add ssh command verification

2023-02-23 Thread Juraj Linkeš
This is a basic capability needed to check whether the command execution was successful or not. If not, raise a RemoteCommandExecutionError. When a failure is expected, the caller is supposed to catch the exception. Signed-off-by: Juraj Linkeš --- dts/framework/exception.py|

[PATCH v5 03/10] dts: add dpdk build on sut

2023-02-23 Thread Juraj Linkeš
Add the ability to build DPDK and apps on the SUT, using a configured target. Signed-off-by: Juraj Linkeš --- dts/framework/config/__init__.py | 2 + dts/framework/exception.py| 17 ++ dts/framework/remote_session/os_session.py| 90 +- dts/framewo

[PATCH v5 04/10] dts: add dpdk execution handling

2023-02-23 Thread Juraj Linkeš
Add methods for setting up and shutting down DPDK apps and for constructing EAL parameters. Signed-off-by: Juraj Linkeš --- dts/conf.yaml | 4 + dts/framework/config/__init__.py | 8 + dts/framework/config/conf_yaml_schema.json| 25 ++ dts/fr

[PATCH v5 05/10] dts: add node memory setup

2023-02-23 Thread Juraj Linkeš
Setup hugepages on nodes. This is useful not only on SUT nodes, but also on TG nodes which use TGs that utilize hugepages. The setup is opt-in, i.e. users need to supply hugepage configuration to instruct DTS to configure them. It not configured, hugepage configuration will be skipped. This is hel

[PATCH v5 06/10] dts: add test suite module

2023-02-23 Thread Juraj Linkeš
The module implements the base class that all test suites inherit from. It implements methods common to all test suites. The derived test suites implement test cases and any particular setup needed for the suite or tests. Signed-off-by: Juraj Linkeš --- dts/conf.yaml

[PATCH v5 07/10] dts: add hello world testsuite

2023-02-23 Thread Juraj Linkeš
The test suite implements test cases defined in the corresponding test plan. Signed-off-by: Juraj Linkeš --- dts/framework/remote_session/__init__.py | 2 +- dts/framework/remote_session/os_session.py| 16 - .../remote_session/remote/__init__.py | 2 +- dts/framework/testb

[PATCH v5 08/10] dts: add test suite config and runner

2023-02-23 Thread Juraj Linkeš
The config allows users to specify which test suites and test cases within test suites to run. Also add test suite running capabilities to dts runner. Signed-off-by: Juraj Linkeš --- dts/conf.yaml | 2 ++ dts/framework/config/__init__.py | 29 +

[PATCH v5 09/10] dts: add test results module

2023-02-23 Thread Juraj Linkeš
The module stores the results and errors from all executions, build targets, test suites and test cases. The result consist of the result of the setup and the teardown of each testing stage (listed above) and the results of the inner stages. The innermost stage is the case, which also contains the

[PATCH v5 10/10] doc: update DTS setup and test suite cookbook

2023-02-23 Thread Juraj Linkeš
Document how to configure and run DTS. Also add documentation related to new features: SUT setup and a brief test suite implementation cookbook. Signed-off-by: Juraj Linkeš --- doc/guides/tools/dts.rst | 165 ++- 1 file changed, 163 insertions(+), 2 deletions(

[PATCH v3] examples/ipsec-secgw: set AES-CTR IV length to 16

2023-02-23 Thread Tejasree Kondoj
Set AES-CTR IV length to 16 which includes 8B per packet IV, 4B nonce and 4B counter as populated in datapath. Signed-off-by: Tejasree Kondoj --- v3: * Changed IV length in initialization. v2: * Rebased v1 examples/ipsec-secgw/sa.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) dif

[RFC PATCH] drivers/net: fix RSS multi-queue mode check

2023-02-23 Thread Ferruh Yigit
'rxmode.mq_mode' is an enum which should be an abstraction over values, instead of mask it with 'RTE_ETH_MQ_RX_RSS_FLAG' to detect if RSS is supported, directly compare with 'RTE_ETH_MQ_RX_RSS' enum element. Most of the time only 'RTE_ETH_MQ_RX_RSS' is requested by user, that is why output is almo

Re: [PATCH v2] vhost: fix madvise arguments alignment

2023-02-23 Thread Maxime Coquelin
Hi Mike, Thanks for looking into this issue. On 2/23/23 05:35, Mike Pattrick wrote: The arguments passed to madvise should be aligned to the alignment of the backing memory. Now we keep track of each regions alignment and use then when setting coredump preferences. To facilitate this, a new me

Re: [PATCH v5 00/10] dts: add hello world testcase

2023-02-23 Thread Bruce Richardson
On Thu, Feb 23, 2023 at 04:28:30PM +0100, Juraj Linkeš wrote: > Add code needed to run the HelloWorld testcase which just runs the hello > world dpdk application. > > The patchset currently heavily refactors this original DTS code needed > to run the testcase: > * The whole architecture has been r

Re: [PATCH] net/nfp: write link speed to control BAR

2023-02-23 Thread Ferruh Yigit
On 2/21/2023 6:29 AM, Chaoyong He wrote: > From: James Hershaw > > Due to changes in the firmware for NFPs, firmware will no longer write > the link speed of a port to the control BAR. In line with the behaviour > of the kernel NFP driver, this is now handled by the PMD by reading the > value pro

Re: [PATCH v2] vhost: fix madvise arguments alignment

2023-02-23 Thread Mike Pattrick
On Thu, Feb 23, 2023 at 11:12 AM Maxime Coquelin wrote: > > Hi Mike, > > Thanks for looking into this issue. > > On 2/23/23 05:35, Mike Pattrick wrote: > > The arguments passed to madvise should be aligned to the alignment of > > the backing memory. Now we keep track of each regions alignment and

Minutes of Technical Board Meeting, 2023-02-22

2023-02-23 Thread Honnappa Nagarahalli
Members Attending: 10 - Aaron Conole - Bruce Richardson - Hemant Agrawal - Honnappa Nagarahalli (Chair) - Jerin Jacob - Kevin Traynor - Konstantin Ananyev - Maxime Coquelin - Thomas Monjalon - Stephen Hemminger NOTE

RE: [PATCH v2 1/9] baseband/acc: protection for TB negative scenario

2023-02-23 Thread Chautru, Nicolas
Thanks Maxime. > -Original Message- > From: Maxime Coquelin > Sent: Thursday, February 23, 2023 12:57 AM > To: Chautru, Nicolas ; Vargas, Hernan > ; dev@dpdk.org > Cc: sta...@dpdk.org > Subject: Re: [PATCH v2 1/9] baseband/acc: protection for TB negative scenario > > > > On 2/10/23 18:

[PATCH] common/mlx5: replace use of PMD logtype

2023-02-23 Thread Stephen Hemminger
The goal to eliminate the generic PMD logtype. One place it is used unnecessarily is in the mlx5 common code. Change the one RTE_LOG() call here to use the same macro as other log messages in same file. Fixes: 9c410b28b27a ("common/mlx5: refactor HCA attributes query") Cc: viachesl...@nvidia.com S

Re: rte_pktmbuf_alloc() is returning same address on two consecutive calls

2023-02-23 Thread Stephen Hemminger
On Thu, 23 Feb 2023 14:54:13 + NAGENDRA BALAGANI wrote: > Hi Team, > > In my dpdk application, I am facing an issue where rte_pktmbuf_alloc() is > returning same address for two consecutive calls in a single thread context. > > Following is the code snippet, > > int Func(struct rte_mbuf *

Re: [PATCH] net/mana: use RTE_LOG_DP for logs on datapath

2023-02-23 Thread Stephen Hemminger
On Thu, 23 Feb 2023 14:07:25 + Ferruh Yigit wrote: > Overall I am not sure if anyone is interested in driver datapath logs > other than driver developers themselves. > > For datapath logging I think there are two concerns, > 1) It should not eat *any* cycles unless explicitly enabled > 2) Ca

Re: [PATCH v2] eal: abstract compiler atomics

2023-02-23 Thread Tyler Retzlaff
On Wed, Feb 22, 2023 at 08:07:44PM +, Honnappa Nagarahalli wrote: > > > > -Original Message- > > From: Tyler Retzlaff > > Sent: Wednesday, February 22, 2023 12:10 PM > > To: dev@dpdk.org > > Cc: david.march...@redhat.com; tho...@monjalon.net; > > m...@smartsharesystems.com; Honnappa

Re: [PATCH v3] test/service: fix spurious failures by extending timeout

2023-02-23 Thread Thomas Monjalon
03/02/2023 16:12, Bruce Richardson: > On Fri, Feb 03, 2023 at 03:03:38PM +, Van Haaren, Harry wrote: > > From: Van Haaren, Harry > > > > > > > > > > The timeout approach just does not have its place in a functional test. > > > > Either this test is rewritten, or it must go to the performance

Re: [PATCH v3] test/service: fix spurious failures by extending timeout

2023-02-23 Thread Thomas Monjalon
03/02/2023 17:09, Van Haaren, Harry: > From: Thomas Monjalon > > 03/02/2023 16:03, Van Haaren, Harry: > > > From: Van Haaren, Harry > > > > > The timeout approach just does not have its place in a functional > > > > > test. > > > > > Either this test is rewritten, or it must go to the performance

Devtool test-meson-build.sh failed

2023-02-23 Thread Tanzeel Ahmed
Hello, devs! I hope you all are doing well! I am currently working on a new patch version for "[PATCH v2] lib/net: add MPLS insert and strip functionality". However, I am facing an error when running the devtools/test-meson-build.sh script. The error is related to unused functions in rte_mpls.h th

Re: Devtool test-meson-build.sh failed

2023-02-23 Thread Ferruh Yigit
On 2/23/2023 10:58 PM, Tanzeel Ahmed wrote: > Hello, devs! > I hope you all are doing well! > > I am currently working on a new patch version for "[PATCH v2] lib/net: > add MPLS insert and strip functionality". However, I am facing an error > when running the devtools/test-meson-build.sh script. T

RE: [PATCH] common/idpf: fix Rx queue configuration

2023-02-23 Thread Zhang, Qi Z
> -Original Message- > From: Wu, Jingjing > Sent: Thursday, February 23, 2023 12:24 PM > To: Xing, Beilei > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: RE: [PATCH] common/idpf: fix Rx queue configuration > > > > > -Original Message- > > From: Xing, Beilei > > Sent: Thursda

RE: [PATCH] net/iavf: fix avx512 Tx path

2023-02-23 Thread Zhang, Qi Z
> -Original Message- > From: Xu, Ke1 > Sent: Thursday, February 23, 2023 4:17 PM > To: Zeng, ZhichaoX ; dev@dpdk.org > Cc: Zhang, Qi Z ; Chu, Haijun ; > Wu, Jingjing ; Xing, Beilei ; > Richardson, Bruce ; Konstantin Ananyev > ; Zhou, YidingX > Subject: RE: [PATCH] net/iavf: fix avx512

Bug in rte_mempool_do_generic_get?

2023-02-23 Thread Harris, James R
Hi, I’ve tracked down a regression in SPDK to DPDK commit a2833ecc5 (“mempool: fix get objects from mempool with cache”). Here’s an example that demonstrates the problem: Allocate mempool with 2048 buffers and cache size 256. Core 0 allocates 512 buffers. Mempool pulls 512 + 256 buffers from b

[PATCH] net/idpf: add hw stats ierrors

2023-02-23 Thread Mingxia Liu
This patch adds hw stats ierrors, when receiving packets with bad csum, ierrors value will increase. Signed-off-by: Mingxia Liu --- drivers/net/idpf/idpf_ethdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/idpf/idpf_ethdev.c b/drivers/net/idpf/idpf_ethdev.c index 38cbbf369d.

[PATCH v2] net/idpf: add hw stats ierrors

2023-02-23 Thread Mingxia Liu
This patch adds hw stats ierrors, when receiving packets with bad csum, ierrors value will increase. Signed-off-by: Mingxia Liu --- drivers/net/idpf/idpf_ethdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/idpf/idpf_ethdev.c b/drivers/net/idpf/idpf_ethdev.c index 38cbbf369d.

RE: [PATCH v2] net/idpf: add hw stats ierrors

2023-02-23 Thread Xing, Beilei
> -Original Message- > From: Liu, Mingxia > Sent: Friday, February 24, 2023 10:43 AM > To: dev@dpdk.org > Cc: Wu, Jingjing ; Xing, Beilei > ; > Liu, Mingxia > Subject: [PATCH v2] net/idpf: add hw stats ierrors > > This patch adds hw stats ierrors, when receiving packets with bad csum

[Bug 1166] [dpdk-23.03][asan]suite/name: AddressSanitizer: stack-buffer-overflow error when quit testpmd

2023-02-23 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1166 Bug ID: 1166 Summary: [dpdk-23.03][asan]suite/name: AddressSanitizer: stack-buffer-overflow error when quit testpmd Product: DPDK Version: 23.03 Hardware: All OS: A

[PATCH 02/11] crypto/cnxk: make sg version check const

2023-02-23 Thread Tejasree Kondoj
Remove sg_ver2 from burst structure and make it as const argument for compiler optimized code. Signed-off-by: Tejasree Kondoj --- drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 26 +++ 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/crypto/cnxk/cn10k_cryp

[PATCH 00/11] fixes and improvements to cnxk crypto PMD

2023-02-23 Thread Tejasree Kondoj
This series adds cn10k scatter gather support and improvements to cnxk crypto PMD. Anoob Joseph (2): crypto/cnxk: use version field directly common/cnxk: ensure flush inval completion with CSR read Gowrishankar Muthukrishnan (2): common/cnxk: fix incorrect auth key length crypto/cnxk: fix

[PATCH 01/11] common/cnxk: fix incorrect auth key length

2023-02-23 Thread Tejasree Kondoj
From: Gowrishankar Muthukrishnan Auth key length is stored as 8 bit value in SE context. It should be larger enough to accommodate supported auth key length of 1024 bytes maximum, as in HMAC. Fixes: a45859312ff ("common/cnxk: add SE definitions for symmetric crypto") Signed-off-by: Gowrishankar

[PATCH 03/11] crypto/cnxk: use version field directly

2023-02-23 Thread Tejasree Kondoj
From: Anoob Joseph As version field is available in rte_ip_hdr, use it directly instead of masking version_ihl. Signed-off-by: Anoob Joseph --- drivers/crypto/cnxk/cn9k_cryptodev_ops.c | 4 ++-- drivers/crypto/cnxk/cn9k_ipsec_la_ops.h | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-)

[PATCH 04/11] crypto/cnxk: use direct mode for zero aad length

2023-02-23 Thread Tejasree Kondoj
Using direct mode if aad length is zero. Signed-off-by: Tejasree Kondoj --- drivers/crypto/cnxk/cnxk_se.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/crypto/cnxk/cnxk_se.h b/drivers/crypto/cnxk/cnxk_se.h index c16027ec75..69cd343eea 100644 --- a/drivers/cryp

[PATCH 05/11] crypto/cnxk: set ctx for AE

2023-02-23 Thread Tejasree Kondoj
Set ctx_val to 1 for asymmetric ops. Signed-off-by: Tejasree Kondoj --- drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 18 - drivers/crypto/cnxk/cn9k_cryptodev_ops.c | 16 +++ drivers/crypto/cnxk/cnxk_ae.h | 19 + drivers/crypto/cnxk/cnxk_cryptodev_ops.c

[PATCH 06/11] common/cnxk: ensure flush inval completion with CSR read

2023-02-23 Thread Tejasree Kondoj
From: Anoob Joseph If a CSR read is issued after a write, the read would block till the write operation is complete. This would help in determining when the FLUSH+INVALIDATE operation is complete. Signed-off-by: Anoob Joseph --- drivers/common/cnxk/hw/cpt.h | 11 +++ driver

[PATCH 07/11] common/cnxk: add errata function for CPT set ctx

2023-02-23 Thread Tejasree Kondoj
Adding function in errata header file for CPT ctx_val and replace CPT revision_id checks with function call. Signed-off-by: Tejasree Kondoj --- drivers/common/cnxk/roc_errata.h | 9 + drivers/crypto/cnxk/cnxk_cryptodev_ops.c | 13 - 2 files changed, 17 insertions(+),

[PATCH 08/11] common/cnxk: replace CPT revision check with caps

2023-02-23 Thread Tejasree Kondoj
Replace SG version revision check with capabilities populated from microcode. Signed-off-by: Tejasree Kondoj --- drivers/common/cnxk/hw/cpt.h | 3 ++- drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 2 +- drivers/event/cnxk/cn10k_eventdev.c | 3 ++- 3 files changed, 5 insertions(+

[PATCH 09/11] crypto/cnxk: support cn10k IPsec SG mode

2023-02-23 Thread Tejasree Kondoj
Adding support for scatter-gather mode in 103XX and 106XX lookaside IPsec. Signed-off-by: Tejasree Kondoj --- drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 21 +- drivers/crypto/cnxk/cn10k_ipsec_la_ops.h | 222 -- drivers/crypto/cnxk/cnxk_sg.h | 23 +++ 3 files c

[PATCH 10/11] crypto/cnxk: fix order of ECFPM params

2023-02-23 Thread Tejasree Kondoj
From: Gowrishankar Muthukrishnan Fix the order of ECFPM parameters according to target board. Fixes: 8e39b133235 ("crypto/cnxk: support fixed point multiplication") Signed-off-by: Gowrishankar Muthukrishnan --- drivers/crypto/cnxk/cnxk_ae.h | 48 --- 1 file cha

[PATCH 11/11] crypto/cnxk: add model check for pdcp chain

2023-02-23 Thread Tejasree Kondoj
Adding cn9k model check for pdcp_chain as it is not supported in cn10k. Signed-off-by: Tejasree Kondoj --- drivers/crypto/cnxk/cnxk_cryptodev_ops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/cnxk/cnxk_cryptodev_ops.c b/drivers/crypto/cnxk/cnxk_cryptodev_o

RE: [PATCH v6 1/3] eal: add rte thread create control API

2023-02-23 Thread Li, WeiyuanX
Hi, Tyler Retzlaff We found an error when ASAN test, AddressSanitizer: stack-buffer-overflow error when quit testpmd. Could you please have a look at it , also submitted a Bugzilla ticket: https://bugs.dpdk.org/show_bug.cgi?id=1166 Thanks. Regards, Li, Weiyuan > -Original Message- > F

[PATCH] app/test: enable SG tests for cn10k

2023-02-23 Thread Tejasree Kondoj
Enabling Scatter Gather tests for cn10k. Signed-off-by: Tejasree Kondoj --- app/test/test_cryptodev.c | 4 1 file changed, 4 deletions(-) diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c index aa831d79a2..10a631dd5f 100644 --- a/app/test/test_cryptodev.c +++ b/app/test/te

RE: [PATCH v1 01/13] graph: split graph worker into common and default model

2023-02-23 Thread Yan, Zhirun
> -Original Message- > From: Jerin Jacob > Sent: Monday, February 20, 2023 9:38 PM > To: Yan, Zhirun > Cc: dev@dpdk.org; jer...@marvell.com; kirankum...@marvell.com; > ndabilpu...@marvell.com; Liang, Cunming ; Wang, > Haiyue > Subject: Re: [PATCH v1 01/13] graph: split graph worker int

RE: [PATCH v1 03/13] graph: add macro to walk on graph circular buffer

2023-02-23 Thread Yan, Zhirun
> -Original Message- > From: Jerin Jacob > Sent: Monday, February 20, 2023 9:45 PM > To: Yan, Zhirun > Cc: dev@dpdk.org; jer...@marvell.com; kirankum...@marvell.com; > ndabilpu...@marvell.com; Liang, Cunming ; Wang, > Haiyue > Subject: Re: [PATCH v1 03/13] graph: add macro to walk on g

RE: [PATCH v1 04/13] graph: add get/set graph worker model APIs

2023-02-23 Thread Yan, Zhirun
> -Original Message- > From: Jerin Jacob > Sent: Monday, February 20, 2023 9:51 PM > To: Yan, Zhirun > Cc: dev@dpdk.org; jer...@marvell.com; kirankum...@marvell.com; > ndabilpu...@marvell.com; Liang, Cunming ; Wang, > Haiyue > Subject: Re: [PATCH v1 04/13] graph: add get/set graph work

RE: [PATCH v1 05/13] graph: introduce core affinity API

2023-02-23 Thread Yan, Zhirun
> -Original Message- > From: Jerin Jacob > Sent: Monday, February 20, 2023 10:05 PM > To: Yan, Zhirun > Cc: dev@dpdk.org; jer...@marvell.com; kirankum...@marvell.com; > ndabilpu...@marvell.com; Liang, Cunming ; Wang, > Haiyue > Subject: Re: [PATCH v1 05/13] graph: introduce core affini

RE: [PATCH v1 06/13] graph: introduce graph affinity API

2023-02-23 Thread Yan, Zhirun
> -Original Message- > From: Jerin Jacob > Sent: Monday, February 20, 2023 10:07 PM > To: Yan, Zhirun > Cc: dev@dpdk.org; jer...@marvell.com; kirankum...@marvell.com; > ndabilpu...@marvell.com; Liang, Cunming ; Wang, > Haiyue > Subject: Re: [PATCH v1 06/13] graph: introduce graph affin

RE: [PATCH v1 08/13] graph: introduce stream moving cross cores

2023-02-23 Thread Yan, Zhirun
> -Original Message- > From: Jerin Jacob > Sent: Monday, February 20, 2023 10:17 PM > To: Yan, Zhirun > Cc: dev@dpdk.org; jer...@marvell.com; kirankum...@marvell.com; > ndabilpu...@marvell.com; Liang, Cunming ; Wang, > Haiyue > Subject: Re: [PATCH v1 08/13] graph: introduce stream movi

RE: [PATCH v1 13/13] examples/l3fwd-graph: introduce generic worker model

2023-02-23 Thread Yan, Zhirun
> -Original Message- > From: Jerin Jacob > Sent: Monday, February 20, 2023 10:20 PM > To: Yan, Zhirun > Cc: dev@dpdk.org; jer...@marvell.com; kirankum...@marvell.com; > ndabilpu...@marvell.com; Liang, Cunming ; Wang, > Haiyue > Subject: Re: [PATCH v1 13/13] examples/l3fwd-graph: introd