RE: [PATCH v6 1/9] eal: annotate spinlock, rwlock and seqlock

2023-02-09 Thread Xia, Chenbo
> -Original Message- > From: David Marchand > Sent: Tuesday, February 7, 2023 6:45 PM > To: dev@dpdk.org > Cc: maxime.coque...@redhat.com; step...@networkplumber.org; Xia, Chenbo > ; Hu, Jiayu ; Wang, YuanX > ; Ding, Xuan ; > m...@smartsharesystems.com; Burakov, Anatoly ; > mattias.ronnblo

RE: [PATCH v6 2/9] vhost: simplify need reply handling

2023-02-09 Thread Xia, Chenbo
> -Original Message- > From: David Marchand > Sent: Tuesday, February 7, 2023 6:45 PM > To: dev@dpdk.org > Cc: maxime.coque...@redhat.com; step...@networkplumber.org; Xia, Chenbo > ; Hu, Jiayu ; Wang, YuanX > ; Ding, Xuan ; > m...@smartsharesystems.com > Subject: [PATCH v6 2/9] vhost: simp

RE: [PATCH v6 3/9] vhost: terminate when access lock is not taken

2023-02-09 Thread Xia, Chenbo
> -Original Message- > From: David Marchand > Sent: Tuesday, February 7, 2023 6:45 PM > To: dev@dpdk.org > Cc: maxime.coque...@redhat.com; step...@networkplumber.org; Xia, Chenbo > ; Hu, Jiayu ; Wang, YuanX > ; Ding, Xuan ; > m...@smartsharesystems.com > Subject: [PATCH v6 3/9] vhost: term

RE: [PATCH v6] ethdev: add flow rule group description

2023-02-09 Thread Ori Kam
Hi Rongwei, > -Original Message- > From: Rongwei Liu > Sent: Thursday, 9 February 2023 9:33 > > Add more sentences to describe the group concepts > and define group 0 as root group for traffic to search a > hit rule. > > Signed-off-by: Rongwei Liu > --- > lib/ethdev/rte_flow.h | 12 ++

RE: [PATCH v6 4/9] vhost: annotate virtqueue access lock

2023-02-09 Thread Xia, Chenbo
> -Original Message- > From: David Marchand > Sent: Tuesday, February 7, 2023 6:45 PM > To: dev@dpdk.org > Cc: maxime.coque...@redhat.com; step...@networkplumber.org; Xia, Chenbo > ; Hu, Jiayu ; Wang, YuanX > ; Ding, Xuan ; > m...@smartsharesystems.com > Subject: [PATCH v6 4/9] vhost: anno

RE: [PATCH v6 5/9] vhost: annotate async accesses

2023-02-09 Thread Xia, Chenbo
> -Original Message- > From: David Marchand > Sent: Tuesday, February 7, 2023 6:45 PM > To: dev@dpdk.org > Cc: maxime.coque...@redhat.com; step...@networkplumber.org; Xia, Chenbo > ; Hu, Jiayu ; Wang, YuanX > ; Ding, Xuan ; > m...@smartsharesystems.com > Subject: [PATCH v6 5/9] vhost: anno

RE: [PATCH v6 6/9] vhost: always take IOTLB lock

2023-02-09 Thread Xia, Chenbo
> -Original Message- > From: David Marchand > Sent: Tuesday, February 7, 2023 6:45 PM > To: dev@dpdk.org > Cc: maxime.coque...@redhat.com; step...@networkplumber.org; Xia, Chenbo > ; Hu, Jiayu ; Wang, YuanX > ; Ding, Xuan ; > m...@smartsharesystems.com > Subject: [PATCH v6 6/9] vhost: alwa

RE: [PATCH v6 7/9] vhost: annotate IOTLB lock

2023-02-09 Thread Xia, Chenbo
> -Original Message- > From: David Marchand > Sent: Tuesday, February 7, 2023 6:46 PM > To: dev@dpdk.org > Cc: maxime.coque...@redhat.com; step...@networkplumber.org; Xia, Chenbo > ; Hu, Jiayu ; Wang, YuanX > ; Ding, Xuan ; > m...@smartsharesystems.com > Subject: [PATCH v6 7/9] vhost: anno

RE: [PATCH v6 8/9] vhost: annotate vDPA device list accesses

2023-02-09 Thread Xia, Chenbo
> -Original Message- > From: David Marchand > Sent: Tuesday, February 7, 2023 6:46 PM > To: dev@dpdk.org > Cc: maxime.coque...@redhat.com; step...@networkplumber.org; Xia, Chenbo > ; Hu, Jiayu ; Wang, YuanX > ; Ding, Xuan ; > m...@smartsharesystems.com > Subject: [PATCH v6 8/9] vhost: anno

RE: [PATCH v2] eal: introduce atomics abstraction

2023-02-09 Thread Morten Brørup
> From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > Sent: Wednesday, 8 February 2023 22.44 > > Introduce atomics abstraction that permits optional use of standard C11 > atomics when meson is provided the new enable_stdatomics=true option. > > Signed-off-by: Tyler Retzlaff > --- Looks

RE: [PATCH v6 9/9] vhost: enable lock check

2023-02-09 Thread Xia, Chenbo
> -Original Message- > From: David Marchand > Sent: Tuesday, February 7, 2023 6:46 PM > To: dev@dpdk.org > Cc: maxime.coque...@redhat.com; step...@networkplumber.org; Xia, Chenbo > ; Hu, Jiayu ; Wang, YuanX > ; Ding, Xuan ; > m...@smartsharesystems.com > Subject: [PATCH v6 9/9] vhost: enab

Re: [PATCH v6 0/9] Lock annotations

2023-02-09 Thread David Marchand
Hello, On Thu, Feb 9, 2023 at 8:59 AM Xia, Chenbo wrote: > > Subject: [PATCH v6 0/9] Lock annotations > > > > vhost internals involves multiple locks to protect data access by > > multiple threads. > > > > This series uses clang thread safety checks [1] to catch issues during > > compilation: EAL

RE: [PATCH v6 0/9] Lock annotations

2023-02-09 Thread Xia, Chenbo
> -Original Message- > From: David Marchand > Sent: Thursday, February 9, 2023 4:08 PM > To: Xia, Chenbo > Cc: dev@dpdk.org; maxime.coque...@redhat.com; step...@networkplumber.org; > Hu, Jiayu ; Wang, YuanX ; Ding, > Xuan ; m...@smartsharesystems.com > Subject: Re: [PATCH v6 0/9] Lock ann

Re: [PATCH v9 1/5] eal: add lcore info in telemetry

2023-02-09 Thread David Marchand
On Thu, Feb 9, 2023 at 3:19 AM lihuisong (C) wrote: > >>> + if (info->lcore_id != lcore_id) > >> Suggest: info->lcore_id != lcore_id -> lcore_id != info->lcore_id > >> Here, info->lcore_id is a target and lcore_id is the variable to be > >> judged, right? > > Yeah that looks better. I didn't pay

Re: [PATCH V8] ethdev: fix one address occupies two entries in MAC addrs

2023-02-09 Thread lihuisong (C)
在 2023/2/4 10:57, lihuisong (C) 写道: 在 2023/2/3 20:58, Ferruh Yigit 写道: On 2/3/2023 1:56 AM, lihuisong (C) wrote: 在 2023/2/3 5:10, Thomas Monjalon 写道: 02/02/2023 19:09, Ferruh Yigit: On 2/2/2023 12:36 PM, Huisong Li wrote: The dev->data->mac_addrs[0] will be changed to a new MAC address wh

RE: [PATCH] eal: introduce atomics abstraction

2023-02-09 Thread Morten Brørup
> From: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@arm.com] > Sent: Thursday, 9 February 2023 01.17 > > > > > > > > > > > > > > > > > > > > > > > For environments where stdatomics are not supported, we > could > > > > have a > > > > > > stdatomic.h in DPDK implementing the same APIs (we h

[PATCH v4 1/3] ethdev: skip congestion management configuration

2023-02-09 Thread Rakesh Kudurumalla
Introduce new flow action to skip congestion management configuration This feature helps to skip the congestion management processing based on per flow or the packet color identified by rte_flow meter object. For example, If one Rx queue configured as RED congestion and application wants tobypass t

[PATCH v4 2/3] app/testpmd: add skip cman support for testpmd

2023-02-09 Thread Rakesh Kudurumalla
added support for testpmd application to accept skip_cman action while configuring policy action Signed-off-by: Rakesh Kudurumalla --- app/test-pmd/cmdline_flow.c | 9 + 1 file changed, 9 insertions(+) diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c index 88108498

[PATCH v4 3/3] net/cnxk: skip red drop for ingress policer

2023-02-09 Thread Rakesh Kudurumalla
Dropping of packets is based on action configured to meter.If both skip_red and drop actions are configured then tail dropping in invoked else if only drop action is configured then RED drop is invoked.This action is supported only when RED is configured using rte_eth_cman_config_set() Signed-off-

Re: [PATCH v9 1/5] eal: add lcore info in telemetry

2023-02-09 Thread David Marchand
On Thu, Feb 9, 2023 at 9:31 AM David Marchand wrote: > > On Thu, Feb 9, 2023 at 3:19 AM lihuisong (C) wrote: > > >>> + if (info->lcore_id != lcore_id) > > >> Suggest: info->lcore_id != lcore_id -> lcore_id != info->lcore_id > > >> Here, info->lcore_id is a target and lcore_id is the variable to

Re: [RESEND PATCH v9 4/5] app/testpmd: report lcore usage

2023-02-09 Thread David Marchand
On Wed, Feb 8, 2023 at 9:49 AM Robin Jarry wrote: > > The --record-core-cycles option already accounts for busy cycles. One > turn of packet_fwd_t is considered "busy" if there was at least one > received or transmitted packet. > > Rename core_cycles to busy_cycles in struct fwd_stream to make it

Re: [RESEND PATCH v9 0/5] lcore telemetry improvements

2023-02-09 Thread David Marchand
Hello Robin, On Wed, Feb 8, 2023 at 9:45 AM Robin Jarry wrote: > > This is a follow up on previous work by Kevin Laatz: > > http://patches.dpdk.org/project/dpdk/list/?series=24658&state=* > > This series is aimed at allowing DPDK applications to expose their CPU > usage stats in the DPDK telemetr

Re: [PATCH v2 16/21] net/virtio-user: allocate shadow control queue

2023-02-09 Thread Maxime Coquelin
On 2/7/23 19:06, Eugenio Perez Martin wrote: On Tue, Feb 7, 2023 at 4:18 PM Maxime Coquelin wrote: If the backends supports control virtqueue, allocate a shadow control virtqueue, and implement the notify callback that writes into the kickfd. Signed-off-by: Maxime Coquelin Reviewed-by: Ch

Re: [PATCH] mem: fix displaying heap ID failed for heap info command

2023-02-09 Thread David Marchand
On Thu, Feb 9, 2023 at 4:24 AM fengchengwen wrote: > > Acked-by: Chengwen Feng > > And, how abort add error log in telemetry valid_name, so so that problems can > be identified as early as possible. > > On 2023/2/9 11:03, Huisong Li wrote: > > The telemetry lib has added a allowed characters set

Re: [PATCH v2 18/21] net/virtio-user: add new callback to enable control queue

2023-02-09 Thread Maxime Coquelin
On 2/7/23 19:10, Eugenio Perez Martin wrote: On Tue, Feb 7, 2023 at 4:18 PM Maxime Coquelin wrote: This patch introduces a new callback that is to be called when the backend supports control virtqueue. Implementation for Vhost-vDPA backend is added in this patch. Signed-off-by: Maxime Coq

Re: [PATCH v6 0/3] eal: deprecate last use of pthread_t in public API

2023-02-09 Thread David Marchand
On Wed, Feb 8, 2023 at 10:26 PM Tyler Retzlaff wrote: > > Announce deprecation of rte_ctrl_thread_create API which is the final > remaining stable API exposing pthread_t. > > Provide an equivalent replacement API rte_thread_create_control that > uses the new rte_thread_t type. > > Provide a unit t

Re: [PATCH v6 3/3] doc: announce deprecation of thread ctrl create function

2023-02-09 Thread Bruce Richardson
On Wed, Feb 08, 2023 at 01:26:35PM -0800, Tyler Retzlaff wrote: > Notify deprecation of rte_ctrl_thread_create API, it will be removed as > it exposes platform-specific thread details. > > Signed-off-by: Tyler Retzlaff > Acked-by: Morten Brørup > Acked-by: David Marchand > Reviewed-by: Mattias

RE: [PATCH v2 01/10] net/ngbe: fix Rx buffer size in configure register

2023-02-09 Thread Jiawen Wu
On Wednesday, February 8, 2023 6:28 PM, Ferruh Yigit wrote: > On 2/2/2023 9:21 AM, Jiawen Wu wrote: > > When buffer size is less than 1K, round down makes it 0, which is an > > error value. > > > > Fixes: 62fc35e63d0e ("net/ngbe: support Rx queue start/stop") > > Cc: sta...@dpdk.org > > > > Signed-

Re: [PATCH v2] eal: introduce atomics abstraction

2023-02-09 Thread Bruce Richardson
On Wed, Feb 08, 2023 at 01:43:38PM -0800, Tyler Retzlaff wrote: > Introduce atomics abstraction that permits optional use of standard C11 > atomics when meson is provided the new enable_stdatomics=true option. > > Signed-off-by: Tyler Retzlaff > --- > config/meson.build | 11

Re: [PATCH 1/2] eal: fix mmap fail regarded as success

2023-02-09 Thread David Marchand
On Mon, Feb 6, 2023 at 11:59 AM Chengwen Feng wrote: > > The map_shared_memory() function should treat mmap MAP_FAILED as NULL > because callers compare it with NULL to determine whether the map is > failed. > > Fixes: 764bf26873b9 ("add FreeBSD support") > Fixes: cb97d93e9d3b ("mem: share hugepag

Re: [PATCH 0/2] fix mmap retcode check fail

2023-02-09 Thread David Marchand
On Mon, Feb 6, 2023 at 11:59 AM Chengwen Feng wrote: > > This patchset contains two patch which fix mmap retcode check fail. > > Chengwen Feng (2): > eal: fix mmap fail regarded as success > raw/ifpga/base: fix mmap retcode check fail > > drivers/raw/ifpga/base/opae_hw_api.c | 4 ++-- > lib/e

Re: [PATCH v1 13/13] test/bbdev: remove iteration count check

2023-02-09 Thread Maxime Coquelin
On 2/8/23 21:38, Vargas, Hernan wrote: Hi Maxime, We would like to keep the same signature for validate_dec_op because there are functions such as latency_test_dec that have vector_mask on their signatures and they pass it to validate_dec_op. Let me know if you'd like to discuss more. I t

Re: [PATCH v5 2/3] graph: pcap capture for graph nodes

2023-02-09 Thread David Marchand
On Fri, Feb 3, 2023 at 9:19 AM Amit Prakash Shukla wrote: > diff --git a/lib/graph/rte_graph.h b/lib/graph/rte_graph.h > index b32c4bc217..c9a77297fc 100644 > --- a/lib/graph/rte_graph.h > +++ b/lib/graph/rte_graph.h > @@ -35,6 +35,7 @@ extern "C" { > > #define RTE_GRAPH_NAMESIZE 64 /**< Max leng

Re: [PATCH v5 1/3] pcapng: comment option support for epb

2023-02-09 Thread David Marchand
Stephen, Reshma, On Fri, Feb 3, 2023 at 9:19 AM Amit Prakash Shukla wrote: > > This change enhances rte_pcapng_copy to have comment in enhanced > packet block. > > Signed-off-by: Amit Prakash Shukla Is this change ok for you? Thanks. -- David Marchand

RE: [PATCH 2/2] test/mempool: add zero-copy API's

2023-02-09 Thread Morten Brørup
> From: Kamalakshitha Aligeri [mailto:kamalakshitha.alig...@arm.com] > Sent: Thursday, 9 February 2023 07.25 > > Added mempool test cases with zero-copy get and put API's > > Signed-off-by: Kamalakshitha Aligeri > Reviewed-by: Ruifeng Wang > Reviewed-by: Feifei Wang > --- > Link: > https://pat

Re: [PATCH v2 0/8] Enable building more libraries on Windows

2023-02-09 Thread David Marchand
Hello Stephen, On Tue, Feb 7, 2023 at 11:13 PM Dmitry Kozlyuk wrote: > > 2023-02-06 16:19 (UTC-0800), Stephen Hemminger: > > While diagnosing some Windows cross build errors; > > noticed that lots of important DPDK libraries are not > > being built on Windows. > > > > Stephen Hemminger (8): > >

[PATCH 00/21] Add control queue & MQ support to Virtio-user vDPA

2023-02-09 Thread Maxime Coquelin
This series introduces control queue support for Vhost-vDPA backend. This is a requirement to support multiqueue, but be usefull for other features like RSS for example. Since the Virtio-user layer of the Virtio PMD must handle some control messages, like the number of queue pairs to be used by th

[PATCH 01/21] net/virtio: move CVQ code into a dedicated file

2023-02-09 Thread Maxime Coquelin
This patch moves Virtio control queue code into a dedicated file, as preliminary rework to support shadow control queue in Virtio-user. Signed-off-by: Maxime Coquelin Reviewed-by: Chenbo Xia --- drivers/net/virtio/meson.build | 1 + drivers/net/virtio/virtio_cvq.c| 230 +++

[PATCH 02/21] net/virtio: introduce notify callback for control queue

2023-02-09 Thread Maxime Coquelin
This patch introduces a notification callback for the control virtqueue as preliminary work to add shadow control virtqueue support. This new callback is required so that the shadow control queue implemented in Virtio-user does not call the notifciation op implemented for the driver layer. Signed

[PATCH 03/21] net/virtio: virtqueue headers alloc refactoring

2023-02-09 Thread Maxime Coquelin
This patch refactors virtqueue initialization by moving its headers allocation and deallocation in dedicated function. While at it, it renames the memzone metadata and address pointers in the virtnet_tx and virtnet_ctl structures to remove redundant virtio_net_ prefix. Signed-off-by: Maxime Coque

[PATCH 05/21] net/virtio: remove unused fields in Tx queue struct

2023-02-09 Thread Maxime Coquelin
The port and queue IDs are not used in virtnet_tx struct, this patch removes them. Signed-off-by: Maxime Coquelin Reviewed-by: Chenbo Xia --- drivers/net/virtio/virtio_ethdev.c | 1 - drivers/net/virtio/virtio_rxtx.c | 1 - drivers/net/virtio/virtio_rxtx.h | 3 --- 3 files changed, 5 deleti

[PATCH 04/21] net/virtio: remove port ID info from Rx queue

2023-02-09 Thread Maxime Coquelin
The port ID information is duplicated in several places. This patch removes it from the virtnet_rx struct as it can be found in virtio_hw struct. Signed-off-by: Maxime Coquelin Reviewed-by: Chenbo Xia --- drivers/net/virtio/virtio_ethdev.c | 1 - drivers/net/virtio/virtio_rxtx.c|

[PATCH 06/21] net/virtio: remove unused queue ID field in Rx queue

2023-02-09 Thread Maxime Coquelin
This patch removes the queue ID field in virtnet_rx struct. Signed-off-by: Maxime Coquelin Reviewed-by: Chenbo Xia --- drivers/net/virtio/virtio_rxtx.c | 1 - drivers/net/virtio/virtio_rxtx.h | 2 -- 2 files changed, 3 deletions(-) diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/vi

[PATCH 07/21] net/virtio: remove unused Port ID in control queue

2023-02-09 Thread Maxime Coquelin
This patch removes the unused port ID information from virtnet_ctl struct. Signed-off-by: Maxime Coquelin Reviewed-by: Chenbo Xia --- drivers/net/virtio/virtio_cvq.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/virtio/virtio_cvq.h b/drivers/net/virtio/virtio_cvq.h index 226561

[PATCH 08/21] net/virtio: move vring memzone to virtqueue struct

2023-02-09 Thread Maxime Coquelin
Whatever its type (Rx, Tx or Ctl), all the virtqueue require a memzone for the vrings. This patch moves its pointer to the virtqueue struct, simplifying the code. Signed-off-by: Maxime Coquelin Reviewed-by: Chenbo Xia --- drivers/net/virtio/virtio_cvq.h| 1 - drivers/net/virtio/virtio_ethd

[PATCH 09/21] net/virtio: refactor indirect desc headers init

2023-02-09 Thread Maxime Coquelin
This patch refactors the indirect descriptors headers initialization in a dedicated function, and makes it used by both queue init and reset functions. Signed-off-by: Maxime Coquelin Reviewed-by: Chenbo Xia --- drivers/net/virtio/virtio_ethdev.c | 30 + drivers/net/virtio/virtqueue.

[PATCH 10/21] net/virtio: alloc Rx SW ring only if vectorized path

2023-02-09 Thread Maxime Coquelin
This patch only allocates the SW ring when vectorized datapath is used. It also moves the SW ring and fake mbuf in the virtnet_rx struct since this is Rx-only. Signed-off-by: Maxime Coquelin Reviewed-by: Chenbo Xia --- drivers/net/virtio/virtio_ethdev.c| 88 --- driv

[PATCH 11/21] net/virtio: extract virtqueue init from virtio queue init

2023-02-09 Thread Maxime Coquelin
This patch extracts the virtqueue initialization out of the Virtio ethdev queue initialization, as preliminary work to provide a way for Virtio-user to allocate its shadow control virtqueue. Signed-off-by: Maxime Coquelin Reviewed-by: Chenbo Xia --- drivers/net/virtio/virtio_ethdev.c | 261 ++--

[PATCH 12/21] net/virtio-user: fix device starting failure handling

2023-02-09 Thread Maxime Coquelin
If the device fails to start, read the status from the device and return early. Fixes: 57912824615f ("net/virtio-user: support vhost status setting") Cc: sta...@dpdk.org Signed-off-by: Maxime Coquelin Reviewed-by: Chenbo Xia --- drivers/net/virtio/virtio_user_ethdev.c | 11 --- 1 file

[PATCH 13/21] net/virtio-user: simplify queues setup

2023-02-09 Thread Maxime Coquelin
The only reason two loops were needed to iterate over queues at setup time was to be able to print whether it was a Tx or Rx queue. This patch changes queues iteration to a single loop. Signed-off-by: Maxime Coquelin Reviewed-by: Chenbo Xia --- drivers/net/virtio/virtio_user/virtio_user_dev.c

[PATCH 14/21] net/virtio-user: use proper type for number of queue pairs

2023-02-09 Thread Maxime Coquelin
The number of queue pairs is specified as a 16 bits unsigned int in the Virtio specification. Signed-off-by: Maxime Coquelin Reviewed-by: Chenbo Xia --- drivers/net/virtio/virtio_user/virtio_user_dev.c | 2 +- drivers/net/virtio/virtio_user/virtio_user_dev.h | 6 +++--- drivers/net/virtio/virti

[PATCH 15/21] net/virtio-user: get max number of queue pairs from device

2023-02-09 Thread Maxime Coquelin
When supported by the backend (only vDPA for now), this patch gets the maximum number of queue pairs supported by the device by querying it in its config space. This is required for adding backend control queue support, as is index equals the maximum number of queues supported by the device as des

[PATCH 16/21] net/virtio-user: allocate shadow control queue

2023-02-09 Thread Maxime Coquelin
If the backends supports control virtqueue, allocate a shadow control virtqueue, and implement the notify callback that writes into the kickfd. Signed-off-by: Maxime Coquelin Reviewed-by: Chenbo Xia Acked-by: Eugenio Pérez --- .../net/virtio/virtio_user/virtio_user_dev.c | 47

[PATCH 17/21] net/virtio-user: send shadow virtqueue info to the backend

2023-02-09 Thread Maxime Coquelin
This patch adds sending the shadow control queue info to the backend. Signed-off-by: Maxime Coquelin Reviewed-by: Chenbo Xia Acked-by: Eugenio Pérez --- .../net/virtio/virtio_user/virtio_user_dev.c | 28 --- 1 file changed, 24 insertions(+), 4 deletions(-) diff --git a/driver

[PATCH 18/21] net/virtio-user: add new callback to enable control queue

2023-02-09 Thread Maxime Coquelin
This patch introduces a new callback that is to be called when the backend supports control virtqueue. Implementation for Vhost-vDPA backend is added in this patch. Signed-off-by: Maxime Coquelin Reviewed-by: Chenbo Xia Acked-by: Eugenio Pérez --- drivers/net/virtio/virtio_user/vhost.h

[PATCH 19/21] net/virtio-user: forward control messages to shadow queue

2023-02-09 Thread Maxime Coquelin
This patch implements control messages forwarding from the regular control queue to the shadow control queue. Signed-off-by: Maxime Coquelin Acked-by: Eugenio Pérez Reviewed-by: Chenbo Xia --- .../net/virtio/virtio_user/virtio_user_dev.c | 35 +++ .../net/virtio/virtio_user/vi

[PATCH 21/21] net/virtio-user: remove max queues limitation

2023-02-09 Thread Maxime Coquelin
This patch removes the limitation of 8 queue pairs by dynamically allocating vring metadata once we know the maximum number of queue pairs supported by the backend. This is especially useful for Vhost-vDPA with physical devices, where the maximum queues supported may be much more than 8 pairs. Si

[PATCH 20/21] net/virtio-user: advertize control VQ support with vDPA

2023-02-09 Thread Maxime Coquelin
This patch advertizes control virtqueue support by the vDPA backend if it supports VIRTIO_NET_F_CTRL_VQ. Signed-off-by: Maxime Coquelin Reviewed-by: Chenbo Xia Acked-by: Eugenio Pérez --- drivers/net/virtio/virtio_user/vhost_vdpa.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) dif

Re: [PATCH] telemetry: fix docstring of RTE_TEL_INT_VAL

2023-02-09 Thread David Marchand
On Tue, Feb 7, 2023 at 9:46 AM Robin Jarry wrote: > > The doc string was left to its previous definition. Make it explicit > that RTE_TEL_INT_VAL is a 64-bit signed integer. > > Fixes: 8e639c7c50cc ("telemetry: use 64-bit signed values in API") > > Signed-off-by: Robin Jarry Applied, thanks. -

Re: [PATCH 00/21] Add control queue & MQ support to Virtio-user vDPA

2023-02-09 Thread Maxime Coquelin
Oups, forgot to set subject prefix to v3. On 2/9/23 10:16, Maxime Coquelin wrote: This series introduces control queue support for Vhost-vDPA backend. This is a requirement to support multiqueue, but be usefull for other features like RSS for example. Since the Virtio-user layer of the Virtio P

RE: [EXT] Re: [PATCH v5 2/3] graph: pcap capture for graph nodes

2023-02-09 Thread Amit Prakash Shukla
Hi David, Sorry for the delayed reply. I will send the next version of the patch, in sometime, after squashing the fix. Thanks, Amit Shukla > -Original Message- > From: David Marchand > Sent: Thursday, February 9, 2023 2:43 PM > To: Amit Prakash Shukla > Cc: Jerin Jacob Kollanukkaran

RE: [PATCH 1/2] net/i40e: replace put function

2023-02-09 Thread Morten Brørup
> From: Kamalakshitha Aligeri [mailto:kamalakshitha.alig...@arm.com] > Sent: Thursday, 9 February 2023 07.25 > > Integrated zero-copy put API in mempool cache in i40e PMD. > On Ampere Altra server, l3fwd single core's performance improves by 5% > with the new API > > Signed-off-by: Kamalakshitha

[PATCH v5 00/21] add support for cpfl PMD in DPDK

2023-02-09 Thread Mingxia Liu
The patchset introduced the cpfl (Control Plane Function Library) PMD for Intel?? IPU E2100???s Configure Physical Function (Device ID: 0x1453) The cpfl PMD inherits all the features from idpf PMD which will follow an ongoing standard data plan function spec https://www.oasis-open.org/committees/t

[PATCH v5 01/21] net/cpfl: support device initialization

2023-02-09 Thread Mingxia Liu
Support device init and add the following dev ops: - dev_configure - dev_close - dev_infos_get - link_update - dev_supported_ptypes_get Signed-off-by: Mingxia Liu --- MAINTAINERS| 9 + doc/guides/nics/cpfl.rst | 66 +++ doc/guides/nics/features/c

[PATCH v5 02/21] net/cpfl: add Tx queue setup

2023-02-09 Thread Mingxia Liu
Add support for tx_queue_setup ops. In the single queue model, the same descriptor queue is used by SW to post buffer descriptors to HW and by HW to post completed descriptors to SW. In the split queue model, "RX buffer queues" are used to pass descriptor buffers from SW to HW while Rx queues are

[PATCH v5 03/21] net/cpfl: add Rx queue setup

2023-02-09 Thread Mingxia Liu
Add support for rx_queue_setup ops. Signed-off-by: Mingxia Liu --- drivers/net/cpfl/cpfl_ethdev.c | 11 ++ drivers/net/cpfl/cpfl_rxtx.c | 232 + drivers/net/cpfl/cpfl_rxtx.h | 6 + 3 files changed, 249 insertions(+) diff --git a/drivers/net/cpfl/cpfl_ethde

[PATCH v5 04/21] net/cpfl: support device start and stop

2023-02-09 Thread Mingxia Liu
Add dev ops dev_start, dev_stop and link_update. Signed-off-by: Mingxia Liu --- drivers/net/cpfl/cpfl_ethdev.c | 35 ++ 1 file changed, 35 insertions(+) diff --git a/drivers/net/cpfl/cpfl_ethdev.c b/drivers/net/cpfl/cpfl_ethdev.c index fb530c7690..423a8dcdcd 1006

[PATCH v5 05/21] net/cpfl: support queue start

2023-02-09 Thread Mingxia Liu
Add support for these device ops: - rx_queue_start - tx_queue_start Signed-off-by: Mingxia Liu --- drivers/net/cpfl/cpfl_ethdev.c | 41 ++ drivers/net/cpfl/cpfl_rxtx.c | 138 + drivers/net/cpfl/cpfl_rxtx.h | 4 + 3 files changed, 183 insertions(+)

[PATCH v5 06/21] net/cpfl: support queue stop

2023-02-09 Thread Mingxia Liu
Add support for these device ops: - rx_queue_stop - tx_queue_stop Signed-off-by: Mingxia Liu --- drivers/net/cpfl/cpfl_ethdev.c | 10 +++- drivers/net/cpfl/cpfl_rxtx.c | 87 ++ drivers/net/cpfl/cpfl_rxtx.h | 3 ++ 3 files changed, 99 insertions(+), 1 deleti

[PATCH v5 07/21] net/cpfl: support queue release

2023-02-09 Thread Mingxia Liu
Add support for queue operations: - rx_queue_release - tx_queue_release Signed-off-by: Mingxia Liu --- drivers/net/cpfl/cpfl_ethdev.c | 2 ++ drivers/net/cpfl/cpfl_rxtx.c | 35 ++ drivers/net/cpfl/cpfl_rxtx.h | 2 ++ 3 files changed, 39 insertions(+) diff

[PATCH v5 08/21] net/cpfl: support MTU configuration

2023-02-09 Thread Mingxia Liu
Add dev ops mtu_set. Signed-off-by: Mingxia Liu --- doc/guides/nics/features/cpfl.ini | 1 + drivers/net/cpfl/cpfl_ethdev.c| 27 +++ 2 files changed, 28 insertions(+) diff --git a/doc/guides/nics/features/cpfl.ini b/doc/guides/nics/features/cpfl.ini index a2d1ca9e1

[PATCH v5 09/21] net/cpfl: support basic Rx data path

2023-02-09 Thread Mingxia Liu
Add basic Rx support in split queue mode and single queue mode. Signed-off-by: Mingxia Liu --- drivers/net/cpfl/cpfl_ethdev.c | 2 ++ drivers/net/cpfl/cpfl_rxtx.c | 18 ++ drivers/net/cpfl/cpfl_rxtx.h | 1 + 3 files changed, 21 insertions(+) diff --git a/drivers/net/cpfl/c

[PATCH v5 10/21] net/cpfl: support basic Tx data path

2023-02-09 Thread Mingxia Liu
Add basic Tx support in split queue mode and single queue mode. Signed-off-by: Mingxia Liu --- drivers/net/cpfl/cpfl_ethdev.c | 3 +++ drivers/net/cpfl/cpfl_rxtx.c | 20 drivers/net/cpfl/cpfl_rxtx.h | 1 + 3 files changed, 24 insertions(+) diff --git a/drivers/net/cpf

[PATCH v5 11/21] net/cpfl: support write back based on ITR expire

2023-02-09 Thread Mingxia Liu
Enable write back on ITR expire, then packets can be received one by Signed-off-by: Mingxia Liu --- drivers/net/cpfl/cpfl_ethdev.c | 45 +- drivers/net/cpfl/cpfl_ethdev.h | 2 ++ 2 files changed, 46 insertions(+), 1 deletion(-) diff --git a/drivers/net/cpfl/cpfl

[PATCH v5 12/21] net/cpfl: support RSS

2023-02-09 Thread Mingxia Liu
Add RSS support. Signed-off-by: Mingxia Liu --- drivers/net/cpfl/cpfl_ethdev.c | 51 ++ drivers/net/cpfl/cpfl_ethdev.h | 15 ++ 2 files changed, 66 insertions(+) diff --git a/drivers/net/cpfl/cpfl_ethdev.c b/drivers/net/cpfl/cpfl_ethdev.c index c02e6c8e58

[PATCH v5 13/21] net/cpfl: support Rx offloading

2023-02-09 Thread Mingxia Liu
Add Rx offloading support: - support CHKSUM and RSS offload for split queue model - support CHKSUM offload for single queue model Signed-off-by: Mingxia Liu --- doc/guides/nics/features/cpfl.ini | 2 ++ drivers/net/cpfl/cpfl_ethdev.c| 6 ++ 2 files changed, 8 insertions(+) diff --git

[PATCH v5 14/21] net/cpfl: support Tx offloading

2023-02-09 Thread Mingxia Liu
Add Tx offloading support: - support TSO for single queue model and split queue model. Signed-off-by: Mingxia Liu --- doc/guides/nics/features/cpfl.ini | 1 + drivers/net/cpfl/cpfl_ethdev.c| 8 +++- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/doc/guides/nics/features/c

[PATCH v5 15/21] net/cpfl: add AVX512 data path for single queue model

2023-02-09 Thread Mingxia Liu
Add support of AVX512 vector data path for single queue model. Signed-off-by: Wenjun Wu Signed-off-by: Mingxia Liu --- doc/guides/nics/cpfl.rst| 24 +- drivers/net/cpfl/cpfl_ethdev.c | 3 +- drivers/net/cpfl/cpfl_rxtx.c| 94 ++ dr

[PATCH v5 16/21] net/cpfl: support timestamp offload

2023-02-09 Thread Mingxia Liu
Add support for timestamp offload. Signed-off-by: Mingxia Liu --- doc/guides/nics/features/cpfl.ini | 1 + drivers/net/cpfl/cpfl_ethdev.c| 3 ++- drivers/net/cpfl/cpfl_rxtx.c | 7 +++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/doc/guides/nics/features/cpfl.ini b

[PATCH v5 17/21] net/cpfl: add AVX512 data path for split queue model

2023-02-09 Thread Mingxia Liu
Add support of AVX512 data path for split queue model. Signed-off-by: Wenjun Wu Signed-off-by: Mingxia Liu --- drivers/net/cpfl/cpfl_rxtx.c| 56 +++-- drivers/net/cpfl/cpfl_rxtx_vec_common.h | 20 - 2 files changed, 71 insertions(+), 5 deletions(-) diff

[PATCH v5 18/21] net/cpfl: add HW statistics

2023-02-09 Thread Mingxia Liu
This patch add hardware packets/bytes statistics. Signed-off-by: Mingxia Liu --- drivers/net/cpfl/cpfl_ethdev.c | 86 ++ 1 file changed, 86 insertions(+) diff --git a/drivers/net/cpfl/cpfl_ethdev.c b/drivers/net/cpfl/cpfl_ethdev.c index 5393b32922..c6ae8039fb 100

[PATCH v5 19/21] net/cpfl: add RSS set/get ops

2023-02-09 Thread Mingxia Liu
Add support for these device ops: - rss_reta_update - rss_reta_query - rss_hash_update - rss_hash_conf_get Signed-off-by: Mingxia Liu --- drivers/net/cpfl/cpfl_ethdev.c | 268 + 1 file changed, 268 insertions(+) diff --git a/drivers/net/cpfl/cpfl_ethdev.c b/drive

[PATCH v5 20/21] net/cpfl: support scalar scatter Rx datapath for single queue model

2023-02-09 Thread Mingxia Liu
This patch add single q recv scatter Rx function. Signed-off-by: Wenjun Wu Signed-off-by: Mingxia Liu --- drivers/net/cpfl/cpfl_ethdev.c | 3 ++- drivers/net/cpfl/cpfl_rxtx.c | 27 +++ drivers/net/cpfl/cpfl_rxtx.h | 2 ++ 3 files changed, 31 insertions(+), 1 deleti

[PATCH v5 21/21] net/cpfl: add xstats ops

2023-02-09 Thread Mingxia Liu
Add support for these device ops: - dev_xstats_get - dev_xstats_get_names - dev_xstats_reset Signed-off-by: Mingxia Liu --- drivers/net/cpfl/cpfl_ethdev.c | 80 ++ 1 file changed, 80 insertions(+) diff --git a/drivers/net/cpfl/cpfl_ethdev.c b/drivers/net/cpfl/cpf

[PATCH v10 0/5] lcore telemetry improvements

2023-02-09 Thread Robin Jarry
This is a follow up on previous work by Kevin Laatz: http://patches.dpdk.org/project/dpdk/list/?series=24658&state=* This series is aimed at allowing DPDK applications to expose their CPU usage stats in the DPDK telemetry under /eal/lcore/info. This is a much more basic and naive approach which l

[PATCH v10 1/5] eal: add lcore info in telemetry

2023-02-09 Thread Robin Jarry
Report the same information than rte_lcore_dump() in the telemetry API into /eal/lcore/list and /eal/lcore/info,ID. Example: --> /eal/lcore/info,3 { "/eal/lcore/info": { "lcore_id": 3, "socket": 0, "role": "RTE", "cpuset": [ 3 ] } } Signed-off-

[PATCH v10 2/5] eal: report applications lcore usage

2023-02-09 Thread Robin Jarry
Allow applications to register a callback that will be invoked in rte_lcore_dump() and when requesting lcore info in the telemetry API. The callback is expected to return the number of TSC cycles that have passed since application start and the number of these cycles that were spent doing busy wor

[PATCH v10 5/5] eal: add lcore usage telemetry endpoint

2023-02-09 Thread Robin Jarry
Allow fetching CPU cycles usage for all lcores with a single request. This endpoint is intended for repeated and frequent invocations by external monitoring systems and therefore returns condensed data. It consists of a single dictionary with three keys: "lcore_ids", "total_cycles" and "busy_cycle

[PATCH v10 3/5] app/testpmd: add dump command for lcores

2023-02-09 Thread Robin Jarry
Add a simple command that calls rte_lcore_dump(). Signed-off-by: Robin Jarry Acked-by: Morten Brørup Acked-by: Konstantin Ananyev Reviewed-by: Kevin Laatz --- Notes: v9 -> v10: no change app/test-pmd/cmdline.c | 3 +++ doc/guides/testpmd_app_ug/testpmd_funcs.rst | 7

[PATCH v10 4/5] app/testpmd: report lcore usage

2023-02-09 Thread Robin Jarry
The --record-core-cycles option already accounts for busy cycles. One turn of packet_fwd_t is considered "busy" if there was at least one received or transmitted packet. Rename core_cycles to busy_cycles in struct fwd_stream to make it more explicit. Add total_cycles to struct fwd_lcore. Add cycle

[PATCH v6 1/4] pcapng: comment option support for epb

2023-02-09 Thread Amit Prakash Shukla
This change enhances rte_pcapng_copy to have comment in enhanced packet block. Signed-off-by: Amit Prakash Shukla --- v2: - Fixed code style issue - Fixed CI compilation issue on github-robot v3: - Code review suggestion from Stephen - Fixed potential memory leak v4: - Code review suggest

[PATCH v6 2/4] graph: pcap capture for graph nodes

2023-02-09 Thread Amit Prakash Shukla
Implementation adds support to capture packets at each node with packet metadata and node name. Signed-off-by: Amit Prakash Shukla --- v2: - Fixed code style issue - Fixed CI compilation issue on github-robot v3: - Code review suggestion from Stephen - Fixed potential memory leak v4: - Co

[PATCH v6 3/4] examples/l3fwd-graph: changes to configure pcap capture

2023-02-09 Thread Amit Prakash Shukla
Added support to configure pcap capture. Signed-off-by: Amit Prakash Shukla --- v2: - Fixed code style issue - Fixed CI compilation issue on github-robot v3: - Code review suggestion from Stephen - Fixed potential memory leak v4: - Code review suggestion from Jerin v5: - Code review sug

[PATCH v6 4/4] test/graph: initialize graph param variable

2023-02-09 Thread Amit Prakash Shukla
Initializing rte_graph_param variable with 0 to avoid any garbage value in structure elements which are not populated as part of this function. Signed-off-by: Amit Prakash Shukla Acked-by: Jerin Jacob --- v2: - Fixed code style issue - Fixed CI compilation issue on github-robot v3: - Code re

RE: [PATCH v6 1/4] pcapng: comment option support for epb

2023-02-09 Thread Amit Prakash Shukla
Please ignore this version. I will resend the patch. > -Original Message- > From: Amit Prakash Shukla > Sent: Thursday, February 9, 2023 3:26 PM > To: Reshma Pattan ; Stephen Hemminger > > Cc: dev@dpdk.org; Jerin Jacob Kollanukkaran ; > david.march...@redhat.com; Amit Prakash Shukla > >

[PATCH v7 1/3] pcapng: comment option support for epb

2023-02-09 Thread Amit Prakash Shukla
This change enhances rte_pcapng_copy to have comment in enhanced packet block. Signed-off-by: Amit Prakash Shukla --- v2: - Fixed code style issue - Fixed CI compilation issue on github-robot v3: - Code review suggestion from Stephen - Fixed potential memory leak v4: - Code review suggest

[PATCH v7 2/3] graph: pcap capture for graph nodes

2023-02-09 Thread Amit Prakash Shukla
Implementation adds support to capture packets at each node with packet metadata and node name. Signed-off-by: Amit Prakash Shukla --- v2: - Fixed code style issue - Fixed CI compilation issue on github-robot v3: - Code review suggestion from Stephen - Fixed potential memory leak v4: - Co

[PATCH v7 3/3] examples/l3fwd-graph: changes to configure pcap capture

2023-02-09 Thread Amit Prakash Shukla
Added support to configure pcap capture. Signed-off-by: Amit Prakash Shukla --- v2: - Fixed code style issue - Fixed CI compilation issue on github-robot v3: - Code review suggestion from Stephen - Fixed potential memory leak v4: - Code review suggestion from Jerin v5: - Code review sug

回复: [PATCH 1/2] net/i40e: replace put function

2023-02-09 Thread Feifei Wang
Hi, Morten > -邮件原件- > 发件人: Morten Brørup > 发送时间: Thursday, February 9, 2023 5:34 PM > 收件人: Kamalakshitha Aligeri ; > yuying.zh...@intel.com; beilei.x...@intel.com; olivier.m...@6wind.com; > andrew.rybche...@oktetlabs.ru; bruce.richard...@intel.com; > konstantin.anan...@huawei.com; Honnapp

RE: [EXT] Re: [PATCH v9 1/4] lib: add generic support for reading PMU events

2023-02-09 Thread Tomasz Duszynski
Hi David, Thanks for review. Comments inline. >-Original Message- >From: David Marchand >Sent: Monday, February 6, 2023 12:03 PM >To: Tomasz Duszynski >Cc: dev@dpdk.org; Thomas Monjalon ; >roret...@linux.microsoft.com; >ruifeng.w...@arm.com; bruce.richard...@intel.com; Jerin Jacob Ko

  1   2   3   >