Hi David,
Sorry for the delayed reply. I will send the next version of the patch, in
sometime, after squashing the fix.
Thanks,
Amit Shukla
> -----Original Message-----
> From: David Marchand <david.march...@redhat.com>
> Sent: Thursday, February 9, 2023 2:43 PM
> To: Amit Prakash Shukla <amitpraka...@marvell.com>
> Cc: Jerin Jacob Kollanukkaran <jer...@marvell.com>; Kiran Kumar
> Kokkilagadda <kirankum...@marvell.com>; Nithin Kumar Dabilpuram
> <ndabilpu...@marvell.com>; Anatoly Burakov
> <anatoly.bura...@intel.com>; dev@dpdk.org
> Subject: [EXT] Re: [PATCH v5 2/3] graph: pcap capture for graph nodes
>
> External Email
>
> ----------------------------------------------------------------------
> On Fri, Feb 3, 2023 at 9:19 AM Amit Prakash Shukla
> <amitpraka...@marvell.com> wrote:
> > diff --git a/lib/graph/rte_graph.h b/lib/graph/rte_graph.h index
> > b32c4bc217..c9a77297fc 100644
> > --- a/lib/graph/rte_graph.h
> > +++ b/lib/graph/rte_graph.h
> > @@ -35,6 +35,7 @@ extern "C" {
> >
> > #define RTE_GRAPH_NAMESIZE 64 /**< Max length of graph name. */
> > #define RTE_NODE_NAMESIZE 64 /**< Max length of node name. */
> > +#define RTE_GRAPH_PCAP_FILE_SZ 64 /**< Max length of pcap file
> name.
> > +*/
> > #define RTE_GRAPH_OFF_INVALID UINT32_MAX /**< Invalid graph
> offset. */
> > #define RTE_NODE_ID_INVALID UINT32_MAX /**< Invalid node id. */
> > #define RTE_EDGE_ID_INVALID UINT16_MAX /**< Invalid edge id. */
> > @@ -164,6 +165,10 @@ struct rte_graph_param {
> > uint16_t nb_node_patterns; /**< Number of node patterns. */
> > const char **node_patterns;
> > /**< Array of node patterns based on shell pattern. */
> > +
> > + bool pcap_enable; /**< Pcap enable. */
> > + uint64_t num_pkt_to_capture; /**< Number of packets to capture. */
> > + char *pcap_filename; /**< Filename in which packets to be
> > + captured.*/
> > };
>
> Repeating in this thread what I commented on a patch fixing compilation for
> the unit test.
>
> Extending this structure requires updating the graph unit test.
> Please squash this fix in this series.
>
>
> Thanks.
>
> --
> David Marchand
