Hello Robin, On Wed, Feb 8, 2023 at 9:45 AM Robin Jarry <rja...@redhat.com> wrote: > > This is a follow up on previous work by Kevin Laatz: > > http://patches.dpdk.org/project/dpdk/list/?series=24658&state=* > > This series is aimed at allowing DPDK applications to expose their CPU > usage stats in the DPDK telemetry under /eal/lcore/info. This is a much > more basic and naive approach which leaves the cpu cycles accounting > completely up to the application. > > For reference, I have implemented a draft patch in OvS to use > rte_lcore_register_usage_cb() and report the already available busy > cycles information. > > https://github.com/rjarry/ovs/commit/643e672fe388e348ea7ccbbda6f5a87a066fd919 > > v9: > > - Fixed changelog & version.map order. > - Updated with 64-bit integer telemetry functions. > - Refined docstrings (added notice about resetting the callback). > - Fixed accounting of total cycles in testpmd. > > v8: > > - Made /eal/lcore/info lcore_id argument parsing more robust. > > Robin Jarry (5): > eal: add lcore info in telemetry > eal: report applications lcore usage > app/testpmd: add dump command for lcores > app/testpmd: report lcore usage > eal: add lcore usage telemetry endpoint > > app/test-pmd/cmdline.c | 3 + > app/test-pmd/noisy_vnf.c | 8 +- > app/test-pmd/testpmd.c | 42 +++- > app/test-pmd/testpmd.h | 25 ++- > doc/guides/rel_notes/release_23_03.rst | 8 + > doc/guides/testpmd_app_ug/testpmd_funcs.rst | 7 + > lib/eal/common/eal_common_lcore.c | 219 ++++++++++++++++++-- > lib/eal/include/rte_lcore.h | 48 +++++ > lib/eal/version.map | 1 + > 9 files changed, 329 insertions(+), 32 deletions(-)
Thanks for this work. The EAL parts look ready to me, but I still have some concerns on the implementation in testpmd (see comments on patch 4). -- David Marchand
