[PATCH] pipeline: increase the pipeline instruction table size

2023-02-01 Thread Harshad Narayane
The complex P4 programs requires more custom instructions, therefore we increase the pipeline instruction table size from 256 to 1024. Signed-off-by: Harshad Narayane Signed-off-by: Kamalakannan R Acked-by: Cristian Dumitrescu --- lib/pipeline/rte_swx_pipeline_internal.h | 2 +- 1 file changed

RE: [PATCH] eal: introduce atomics abstraction

2023-02-01 Thread Morten Brørup
> From: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@arm.com] > Sent: Wednesday, 1 February 2023 02.08 > > > From: Thomas Monjalon > > Sent: Tuesday, January 31, 2023 4:42 PM > > > > Honnappa, please could you give your view on the future of atomics in > DPDK? > Thanks Thomas, apologies it h

RE: [PATCH v3] net/ice: add devargs for disabling default mac

2023-02-01 Thread Zhang, Qi Z
> -Original Message- > From: Zhang, Ke1X > Sent: Thursday, January 12, 2023 3:56 PM > To: Zhang, Qi Z ; Zhang, Yuying > ; dev@dpdk.org > Cc: Zhang, Ke1X > Subject: [PATCH v3] net/ice: add devargs for disabling default mac > > From: "ke1x.zhang" > > Add the feature that support to di

Re: [PATCH v4 2/3] ethdev: add standby state for live migration

2023-02-01 Thread Thomas Monjalon
01/02/2023 08:52, Andrew Rybchenko: > On 1/18/23 18:44, Rongwei Liu wrote: > > +* **Added process state in ethdev to improve live migration.** > > + > > + Hot upgrade of an application may be accelerated by configuring > > + the new application in standby state while the old one is still active.

Re: [PATCH v4 2/3] ethdev: add standby state for live migration

2023-02-01 Thread Thomas Monjalon
01/02/2023 08:32, Andrew Rybchenko: > On 2/1/23 01:55, Thomas Monjalon wrote: > > 31/01/2023 19:14, Jerin Jacob: > >> On Wed, Jan 18, 2023 at 9:15 PM Rongwei Liu wrote: > >>> > >>> When a DPDK application must be upgraded, > >>> the traffic downtime should be shortened as much as possible. > >>> D

Re: [EXT] Re: [PATCH v6 2/6] ethdev: add trace points for ethdev (part one)

2023-02-01 Thread Jerin Jacob
On Wed, Feb 1, 2023 at 3:50 AM Ferruh Yigit wrote: > > On 1/31/2023 6:46 PM, Jerin Jacob wrote: > > On Wed, Feb 1, 2023 at 12:09 AM Ferruh Yigit wrote: > >> > >> On 1/30/2023 4:01 PM, Ankur Dwivedi wrote: > >> > >> <...> > >> > > diff --git a/lib/ethdev/meson.build b/lib/ethdev/meson.build in

RE: [PATCH v2 2/2] net/igc: enable launch time offloading

2023-02-01 Thread Zhang, Qi Z
> -Original Message- > From: Su, Simei > Sent: Wednesday, February 1, 2023 3:30 PM > To: Zhang, Qi Z ; Guo, Junfeng > > Cc: dev@dpdk.org; Wu, Wenjun1 ; Su, Simei > > Subject: [PATCH v2 2/2] net/igc: enable launch time offloading > > The LaunchTime defines the scheduling time of the p

Re: [PATCH v4 2/3] ethdev: add standby state for live migration

2023-02-01 Thread Andrew Rybchenko
On 2/1/23 11:27, Thomas Monjalon wrote: 01/02/2023 08:52, Andrew Rybchenko: On 1/18/23 18:44, Rongwei Liu wrote: + * When configuring the device from a standby process, + * it has no effect except for below situations: + * - traffic not handled by the active process configuration + * - no a

Re: [PATCH v4 2/3] ethdev: add standby state for live migration

2023-02-01 Thread Jerin Jacob
On Wed, Feb 1, 2023 at 1:02 PM Andrew Rybchenko wrote: > > On 2/1/23 01:55, Thomas Monjalon wrote: > > 31/01/2023 19:14, Jerin Jacob: > >> On Wed, Jan 18, 2023 at 9:15 PM Rongwei Liu wrote: > >>> > >>> When a DPDK application must be upgraded, > >>> the traffic downtime should be shortened as muc

RE: [PATCH v2 0/2] net/igc: support launch time offloading

2023-02-01 Thread Morten Brørup
+To: Ferruh, Matan and Viacheslav, regarding feature documentation > From: Simei Su [mailto:simei...@intel.com] > Sent: Wednesday, 1 February 2023 08.30 > > [PATCH v2 1/2] expose packet pacing registers > [PATCH v2 2/2] enable launch time offloading > > v2: > * Refine title and commit log. > * A

Re: [PATCH v4 2/3] ethdev: add standby state for live migration

2023-02-01 Thread Thomas Monjalon
01/02/2023 09:40, Jerin Jacob: > On Wed, Feb 1, 2023 at 1:02 PM Andrew Rybchenko > wrote: > > > > On 2/1/23 01:55, Thomas Monjalon wrote: > > > 31/01/2023 19:14, Jerin Jacob: > > >> On Wed, Jan 18, 2023 at 9:15 PM Rongwei Liu wrote: > > >>> > > >>> When a DPDK application must be upgraded, > > >>

RE: [PATCH v3 1/6] common/idpf: add hw statistics

2023-02-01 Thread Wu, Jingjing
> @@ -327,6 +407,11 @@ idpf_dev_start(struct rte_eth_dev *dev) > goto err_vport; > } > > + if (idpf_dev_stats_reset(dev)) { > + PMD_DRV_LOG(ERR, "Failed to reset stats"); > + goto err_vport; If stats reset fails, will block the start process and rol

Re: [PATCH v2 1/2] ethdev: add PHY affinity match item

2023-02-01 Thread Andrew Rybchenko
On 1/30/23 20:00, Jiawei Wang wrote: For the multiple hardware ports connect to a single DPDK port (mhpsdp), Sorry, what is mhpsdp? currently, there is no information to indicate the packet belongs to which hardware port. This patch introduces a new phy affinity item in rte flow API, and "

Re: [EXT] Re: [PATCH v5 2/2] app/testpmd: add command to process Rx metadata negotiation

2023-02-01 Thread Jerin Jacob
On Wed, Feb 1, 2023 at 12:46 PM Andrew Rybchenko wrote: > > On 2/1/23 09:10, Ivan Malov wrote: > > Hello everyone, > > > > Since making automatic, or implicit, offload decisions does > > not belong in testpmd responsibility domain, it should be > > safer to avoid calling the "negotiate metadata de

RE: [EXT] Re: [PATCH v5 2/2] app/testpmd: add command to process Rx metadata negotiation

2023-02-01 Thread Ori Kam
Hi all, Sorry for jumping in late, > -Original Message- > From: Jerin Jacob > Sent: Wednesday, 1 February 2023 10:53 > > On Wed, Feb 1, 2023 at 12:46 PM Andrew Rybchenko > wrote: > > > > On 2/1/23 09:10, Ivan Malov wrote: > > > Hello everyone, > > > > > > Since making automatic, or imp

Re: [EXT] Re: [PATCH v5 2/2] app/testpmd: add command to process Rx metadata negotiation

2023-02-01 Thread Thomas Monjalon
01/02/2023 10:00, Ori Kam: > Hi all, > > Sorry for jumping in late, > > > -Original Message- > > From: Jerin Jacob > > Sent: Wednesday, 1 February 2023 10:53 > > > > On Wed, Feb 1, 2023 at 12:46 PM Andrew Rybchenko > > wrote: > > > > > > On 2/1/23 09:10, Ivan Malov wrote: > > > > Hello

[PATCH v4 0/4] Implementation of ML common code

2023-02-01 Thread Srikanth Yalavarthi
Machine Learning common code This patch series implements the common ML code that can be used by ML drivers. Common code include functions to convert ML IO type to string, IO format type to string, function get size of ML IO type, and functions for converting data type

[PATCH v4 1/4] mldev: add headers for internal ML functions

2023-02-01 Thread Srikanth Yalavarthi
Added header files for internal ML utility routines to convert IO type and format to string, IO type to size and routines to convert data types. Signed-off-by: Srikanth Yalavarthi --- lib/mldev/meson.build | 2 + lib/mldev/mldev_utils.c | 5 + lib/mldev/mldev_utils.h | 345

[PATCH v4 2/4] mldev: implement ML IO type handling functions

2023-02-01 Thread Srikanth Yalavarthi
Implemented ML utility functions to convert IO data type to name, IO format to name and routine to get the size of an IO data type in bytes. Signed-off-by: Srikanth Yalavarthi --- lib/mldev/mldev_utils.c | 113 lib/mldev/version.map | 4 ++ 2 files ch

[PATCH v4 3/4] mldev: add scalar type conversion functions

2023-02-01 Thread Srikanth Yalavarthi
Added scalar implementations to support conversion of data types. Support is enabled to handle int8, uint8, int16, uint16, float16, float32 and bfloat16 types. Signed-off-by: Srikanth Yalavarthi --- lib/mldev/meson.build | 1 + lib/mldev/mldev_utils_scalar.c | 720

[PATCH v4 4/4] mldev: add Arm NEON type conversion routines

2023-02-01 Thread Srikanth Yalavarthi
Added ARM NEON intrinsic based implementations to support conversion of data types. Support is enabled to handle int8, uint8, int16, uint16, float16, float32 and bfloat16 types. Signed-off-by: Srikanth Yalavarthi --- lib/mldev/meson.build| 4 + lib/mldev/mldev_utils_neon.c | 873 ++

Re: [PATCH v2 2/2] ethdev: introduce the PHY affinity field in Tx queue API

2023-02-01 Thread Andrew Rybchenko
On 1/30/23 20:00, Jiawei Wang wrote: For the multiple hardware ports connect to a single DPDK port (mhpsdp), the previous patch introduces the new rte flow item to match the phy affinity of the received packets. This patch adds the tx_phy_affinity setting in Tx queue API, the affinity "This pa

Re: [EXT] Re: [PATCH v5 2/2] app/testpmd: add command to process Rx metadata negotiation

2023-02-01 Thread Andrew Rybchenko
On 2/1/23 12:05, Thomas Monjalon wrote: 01/02/2023 10:00, Ori Kam: Hi all, Sorry for jumping in late, -Original Message- From: Jerin Jacob Sent: Wednesday, 1 February 2023 10:53 On Wed, Feb 1, 2023 at 12:46 PM Andrew Rybchenko wrote: On 2/1/23 09:10, Ivan Malov wrote: Hello ever

[PATCH v5 0/4] Implementation of ML common code

2023-02-01 Thread Srikanth Yalavarthi
Machine Learning common code This patch series implements the common ML code that can be used by ML drivers. Common code include functions to convert ML IO type to string, IO format type to string, function get size of ML IO type, and functions for converting data type

[PATCH v5 1/4] mldev: add headers for internal ML functions

2023-02-01 Thread Srikanth Yalavarthi
Added header files for internal ML utility routines to convert IO type and format to string, IO type to size and routines to convert data types. Signed-off-by: Srikanth Yalavarthi --- Depends-on: series-26046 ("app/mldev: implement test framework for mldev") v5: * Moved the code from drivers/com

[PATCH v5 2/4] mldev: implement ML IO type handling functions

2023-02-01 Thread Srikanth Yalavarthi
Implemented ML utility functions to convert IO data type to name, IO format to name and routine to get the size of an IO data type in bytes. Signed-off-by: Srikanth Yalavarthi --- v5: * Moved the code from drivers/common/ml to lib/mldev * Added rte_ml_io_ prefix to the functions v2: * Implemente

[PATCH v5 3/4] mldev: add scalar type conversion functions

2023-02-01 Thread Srikanth Yalavarthi
Added scalar implementations to support conversion of data types. Support is enabled to handle int8, uint8, int16, uint16, float16, float32 and bfloat16 types. Signed-off-by: Srikanth Yalavarthi --- v5: * Moved the code from drivers/common/ml to lib/mldev * Added rte_ml_io_ prefix to the function

[PATCH v5 4/4] mldev: add Arm NEON type conversion routines

2023-02-01 Thread Srikanth Yalavarthi
Added ARM NEON intrinsic based implementations to support conversion of data types. Support is enabled to handle int8, uint8, int16, uint16, float16, float32 and bfloat16 types. Signed-off-by: Srikanth Yalavarthi --- v5: * Moved the code from drivers/common/ml to lib/mldev * Added rte_ml_io_ pref

Re: [PATCH v4 2/3] ethdev: add modify IPv6 protocol field

2023-02-01 Thread Andrew Rybchenko
On 1/31/23 12:36, Rongwei Liu wrote: Add IPv6 protocol modify field definition. Add new modify field destination type string: "ipv6_proto". Signed-off-by: Rongwei Liu Acked-by: Ori Kam Acked-by: Andrew Rybchenko

RE: [EXT] Re: [PATCH v3 0/4] implementation of ML common code

2023-02-01 Thread Srikanth Yalavarthi
Srikanth Yalavarthi Senior Staff Engineer > -Original Message- > From: Srikanth Yalavarthi > Sent: 31 January 2023 19:15 > To: Jerin Jacob ; Thomas Monjalon > > Cc: Shivah Shankar Shankar Narayan Rao ; > dev@dpdk.org; Jerin Jacob Kollanukkaran ; Anup > Prabhu ; ferruh.yi...@amd.com; >

Re: [EXT] Re: [PATCH v5 2/2] app/testpmd: add command to process Rx metadata negotiation

2023-02-01 Thread Jerin Jacob
On Wed, Feb 1, 2023 at 2:37 PM Andrew Rybchenko wrote: > > On 2/1/23 12:05, Thomas Monjalon wrote: > > 01/02/2023 10:00, Ori Kam: > >> Hi all, > >> > >> Sorry for jumping in late, > >> > >>> -Original Message- > >>> From: Jerin Jacob > >>> Sent: Wednesday, 1 February 2023 10:53 > >>> > >>

Re: [PATCH v4 1/3] ethdev: add IPv6 routing extension header definition

2023-02-01 Thread Andrew Rybchenko
On 1/31/23 12:36, Rongwei Liu wrote: Add IPv6 routing extension header definition and no TLV support for now. At rte_flow layer, there are new items defined for matching type/nexthdr/segments_left field. Add command line support for IPv6 routing extension header matching: type/nexthdr/segment_l

[PATCH v4 00/39] Implementation of ML CNXK driver

2023-02-01 Thread Srikanth Yalavarthi
Marvell ML CNXK Driver -- This patch series implements common Machine Learning (ML) ROC code and driver for Marvell Octeon 10 (cnxk) platform. ML inferencing is supported on cnxk platform through an integrated ML inferencing processor. The current driver supports programming th

[PATCH v4 02/39] ml/cnxk: add skeleton for ML cnxk driver

2023-02-01 Thread Srikanth Yalavarthi
Added initial source files and build files for ML cnxk driver. Signed-off-by: Srikanth Yalavarthi --- MAINTAINERS| 1 + drivers/meson.build| 1 + drivers/ml/cnxk/cn10k_ml_dev.c | 8 drivers/ml/cnxk/cn10k_ml_dev.h | 8 drivers/ml/cnxk/meson.bu

[PATCH v4 03/39] ml/cnxk: enable probe and remove of ML device

2023-02-01 Thread Srikanth Yalavarthi
ML inference engine on cn10k platform is a PCI based device. Added driver support to probe and remove the device for cn10k poll mode driver. The device is named by the PMD as "ml_cn10k". Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_dev.c | 114 +

[PATCH v4 01/39] common/cnxk: add ML headers and ROC code for cnxk

2023-02-01 Thread Srikanth Yalavarthi
Added ML cnxk headers for register, structure definitions and ROC layer. Implemented ROC functions, registered logtype for ML module with the name pmd.ml.cnxk and defined ML hardware ID. Signed-off-by: Srikanth Yalavarthi --- Depends-on: series-26731 ("Implementation of ML common code") MAINTAI

[PATCH v4 04/39] ml/cnxk: add driver support to get device info

2023-02-01 Thread Srikanth Yalavarthi
Added support to get the cn10k ML device information. This is a driver implementation for the RTE function rte_ml_dev_info_get. ML device on cn10k supports one queue-pair in lock-free mode and does not support segmented input output data. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn

[PATCH v4 06/39] ml/cnxk: parse ML firmware path from device args

2023-02-01 Thread Srikanth Yalavarthi
Enabled parsing ML firmware path for cn10k. Default path is set as "/lib/firmware/mlip-fw.bin", when args are not provided. Added internal structures for ML firmware. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_dev.c | 71 ++ drivers/ml/cnxk/cn

[PATCH v4 05/39] ml/cnxk: add support for configure and close

2023-02-01 Thread Srikanth Yalavarthi
Implemented driver functions to configure and close ML devices. Added skeleton code and support to reconfigure ML device. PCI device remove is enabled in device close. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_dev.c | 2 ++ drivers/ml/cnxk/cn10k_ml_dev.h | 21

[PATCH v4 07/39] ml/cnxk: enable firmware load and device reset

2023-02-01 Thread Srikanth Yalavarthi
Enabled support to load ML firmware on cn10ka ROC model. Reset MLIP device during dev_close driver operation. Device can't be reconfigured after a call to close. Job execution is disabled after firmware load, execution is enabled in device start state. Added internal request structure. Signed-off-

[PATCH v4 09/39] ml/cnxk: enable support for device start and stop

2023-02-01 Thread Srikanth Yalavarthi
Implemented ML driver functions to start and stop ML device. Start / Stop would enable or disable ML device to accept inference requests. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_ops.c | 42 +++--- 1 file changed, 39 insertions(+), 3 deletions(-

[PATCH v4 08/39] ml/cnxk: enable support for simulator environment

2023-02-01 Thread Srikanth Yalavarthi
Enabled device initialization and firmware load on simulator platform. Firmware load stage on simulator would involve launching a firmware handshake request only. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_dev.c | 119 + 1 file changed, 107 in

[PATCH v4 10/39] ml/cnxk: add support to create device queue-pairs

2023-02-01 Thread Srikanth Yalavarthi
Enabled support to create and destroy device queue-pairs. Updated configure stage to create array to store queue-pair handles. Added internal structure for queue-pair, queue and ML inference requests. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_ops.c | 207 +++

[PATCH v4 11/39] ml/cnxk: add functions to load and unload models

2023-02-01 Thread Srikanth Yalavarthi
Added cnxk driver implementations to load and unload ML models. Enabled support in configure stage to allocate model handles array. Assign model ID and allocate resources per each model during load stage and release resources during model unload. Added internal structures to handle ML models. Sign

[PATCH v4 16/39] ml/cnxk: find OCM mask and page slots for a model

2023-02-01 Thread Srikanth Yalavarthi
Added support to compute OCM tilemask and page start for a model. The computed tilemask and page start are used during model start to copy model weights and bias to OCM. OCM slot for a model is allocated from the tiles with maximum amount of free memory. Signed-off-by: Srikanth Yalavarthi --- dr

[PATCH v4 19/39] ml/cnxk: enable support to stop an ML models

2023-02-01 Thread Srikanth Yalavarthi
Implemented model stop driver function. A model stop job is enqueued through scratch registers and is checked for completion through polling in a synchronous mode. OCM pages are released after model stop completion. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_ops.c | 115

[PATCH v4 20/39] ml/cnxk: enable support to get model information

2023-02-01 Thread Srikanth Yalavarthi
Added driver functions to get model information. Added internal functions to set and get model info. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_model.c | 55 drivers/ml/cnxk/cn10k_ml_model.h | 9 ++ drivers/ml/cnxk/cn10k_ml_ops.c | 37

[PATCH v4 15/39] ml/cnxk: add structures for slow and fast path JDs

2023-02-01 Thread Srikanth Yalavarthi
Added JD structures for load, unload and run jobs. Initialize job command and allocate memory for request structures for slow path jobs. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_dev.h | 99 drivers/ml/cnxk/cn10k_ml_model.h | 4 ++ driver

[PATCH v4 13/39] ml/cnxk: add internal structures for derived info

2023-02-01 Thread Srikanth Yalavarthi
Added internal structures to handle derived address fields and enabled support to compute DMA addresses for model start. Enabled updating internal model fields. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_model.c | 89 drivers/ml/cnxk/cn10k_ml

[PATCH v4 22/39] ml/cnxk: add support to get IO buffer sizes

2023-02-01 Thread Srikanth Yalavarthi
Added driver functions to get input and output buffer sizes for a given batch size. This function would compute the buffer size based on specific requirements of the device. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_ops.c | 52 ++ 1 file chan

[PATCH v4 21/39] ml/cnxk: enable support to update model params

2023-02-01 Thread Srikanth Yalavarthi
Added cnxk driver functions to update model params or weights and bias after a models is loaded. Updating model params would not require reloading the model. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_ops.c | 31 +++ 1 file changed, 31 insertions(

[PATCH v4 12/39] ml/cnxk: enable validity checks for model metadata

2023-02-01 Thread Srikanth Yalavarthi
Added model metadata structure and enabled metadata check during model load. Remap cnxk IO types with RTE IO types. Store and update model metadata in model structure. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_model.c | 211 + drivers/ml/cnxk/cn10k_ml_mo

[PATCH v4 25/39] ml/cnxk: add driver support for device selftest

2023-02-01 Thread Srikanth Yalavarthi
Added support for device selftest. Device selftest includes checking the status of firmware. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_ops.c | 57 ++ 1 file changed, 57 insertions(+) diff --git a/drivers/ml/cnxk/cn10k_ml_ops.c b/drivers/ml/c

[PATCH v4 26/39] ml/cnxk: enqueue a burst of inference requests

2023-02-01 Thread Srikanth Yalavarthi
Enabled driver support to enqueue a burst of inference requests to ML device. Enqueue uses internal ML request structure to queue the inferences and job completion through polling. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_ops.c | 96 ++ driv

[PATCH v4 14/39] ml/cnxk: add internal structures for tiles and OCM

2023-02-01 Thread Srikanth Yalavarthi
Added internal structures to handle tile and OCM information and OCM to model memory mapping. Initialize the fields to platform specific defaults and compute the OCM / tile requirements for model. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_dev.h | 5 ++ drivers/ml/cnxk/cn

[PATCH v4 17/39] ml/cnxk: add support to reserve and free OCM pages

2023-02-01 Thread Srikanth Yalavarthi
Added support to reserve and free OCM pages for a model. OCM pages are reserved upon completion of model start and are released after model stop. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_ocm.c | 131 - drivers/ml/cnxk/cn10k_ml_ocm.h | 3 +

[PATCH v4 28/39] ml/cnxk: add internal function for sync mode run

2023-02-01 Thread Srikanth Yalavarthi
Added internal function to execute ML inference requests in synchronous mode. Sync mode inference execution is used to launch inference requests without using a queue-pair. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_ops.c | 53 ++ drivers/ml/c

[PATCH v4 18/39] ml/cnxk: enable support to start an ML model

2023-02-01 Thread Srikanth Yalavarthi
Implemented model start driver function. A model start job is checked for completion in synchronous mode. Tilemask and OCM slot is calculated before starting the model. Model start is enqueued through scratch registers. OCM pages are reserved after model start completion. Signed-off-by: Srikanth

[PATCH v4 23/39] ml/cnxk: enable quantization and dequantization

2023-02-01 Thread Srikanth Yalavarthi
Implemented driver functions to quantize / dequantize input and output data. Support is enabled for multiple batches. Quantization / dequantization use the type conversion functions defined in ML common code. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_ops.c | 151 +++

[PATCH v4 31/39] ml/cnxk: add support to handle extended dev stats

2023-02-01 Thread Srikanth Yalavarthi
Added support to handle ML device extended stats. Support is enabled to get xstats names and stats values and reset xstats. Supported xstats include avg, min and max hardware and firmware latency. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_dev.h | 3 + drivers/ml/cnxk/cn

[PATCH v4 24/39] ml/cnxk: enable support to dump device debug info

2023-02-01 Thread Srikanth Yalavarthi
Added support to dump device debug information. Debug info on cn10k device includes model state info, OCM usage info, firmware debug and exception buffer. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_ocm.c | 51 + drivers/ml/cnxk/cn10k_ml_ocm.h | 1 + drivers/ml/cnx

[PATCH v4 27/39] ml/cnxk: dequeue a burst of inference requests

2023-02-01 Thread Srikanth Yalavarthi
Enabled driver support to dequeue inference requests from internal queue. Dequeue checks for request completion by polling the status field of the job request. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_ops.c | 61 ++ drivers/ml/cnxk/cn10k_ml_

[PATCH v4 35/39] ml/cnxk: add support to select OCM allocation mode

2023-02-01 Thread Srikanth Yalavarthi
Added device argument "ocm_alloc_mode" to select OCM allocation method during model start. Two modes are supported by the driver. Added implementation for ocm_alloc_mode lowest as default. ocm_alloc_mode: lowest: Allocate from first available free slot / lowest tile ID in OCM (default)

[PATCH v4 29/39] ml/cnxk: enable support for firmware error codes

2023-02-01 Thread Srikanth Yalavarthi
Enabled support for error handling. Added error types and subtypes supported by ML firmware. Enabled support to get device specific error code and message for a completed ML request. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_dev.c | 4 +- drivers/ml/cnxk/cn10k_ml_dev.h |

[PATCH v4 36/39] ml/cnxk: add support to use lock during jcmd enq

2023-02-01 Thread Srikanth Yalavarthi
Added device argument "hw_queue_lock" to select the JCMDQ enqueue ROC function to be used in fast path. hw_queue_lock: 0: Disable, use lock free version of JCMDQ enqueue ROC function for job queuing. To avoid race condition in request queuing to hardware, disabling hw_queue_lock

[PATCH v4 30/39] ml/cnxk: add support to get and reset device stats

2023-02-01 Thread Srikanth Yalavarthi
Enabled support to get and reset ML device stats. Device stats include number of requests enqueued/dequeued and error count. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_ops.c | 55 -- drivers/ml/cnxk/cn10k_ml_ops.h | 3 ++ 2 files changed, 55

[PATCH v4 37/39] ml/cnxk: add support to select poll memory region

2023-02-01 Thread Srikanth Yalavarthi
Added device argument "poll_mem" to select the memory region to be used for polling in fast-path requests. Implemented support to use scratch registers for polling. Available pool of scratch registers one-to-one mapped with the internal request queue. poll_mem: ddr: Use DDR memory location f

[PATCH v4 32/39] ml/cnxk: enable support to get xstats in cycles

2023-02-01 Thread Srikanth Yalavarthi
Enabled support to retrieve xstats in either cycles or ns. Access to sclk is enabled only if an RVU device is probed during initialization. Driver would return the xstats in nanoseconds only when an RVU device is probed, else would fallback to cycles. Signed-off-by: Srikanth Yalavarthi --- drive

[PATCH v4 33/39] ml/cnxk: add support to report DPE FW warnings

2023-02-01 Thread Srikanth Yalavarthi
Enabled support to enable and report DPE warnings from ML firmware. Configure firmware load flags based on the device arguments. Default values: enable_dpe_errors = 1 report_dpe_errors = 0 Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_dev.c | 94 +++

[PATCH v4 34/39] ml/cnxk: add support to enable model data caching

2023-02-01 Thread Srikanth Yalavarthi
Added device argument 'cache_model_data' to enable model data caching. An inference request would be executed with dummy data in synchronous mode during model start stage. This run would cache the model weights and bias in the memory and result in improved inference throughput. cache_model_data =

[PATCH v4 39/39] ml/cnxk: enable support for configurable ocm page

2023-02-01 Thread Srikanth Yalavarthi
Enabled support for configurable OCM page size. A new device argument "ocm_page_size" is added to specify the page size for OCM management. Supported page sizes are 1KB, 2KB, 4KB, 8KB and 16KB. Default page size is 16KB. Signed-off-by: Srikanth Yalavarthi --- doc/guides/mldevs/cnxk.rst | 1

[PATCH v4 38/39] ml/cnxk: add user guide for marvell cnxk ml driver

2023-02-01 Thread Srikanth Yalavarthi
Added user guide for Marvell cnxk ML driver for Marvell Octeon cnxk Soc family. Added details about device initialization, debug options and runtime device args supported by the driver. Signed-off-by: Srikanth Yalavarthi --- MAINTAINERS | 1 + doc/guides/index.rst| 1

RE: [PATCH v4 1/3] ethdev: add IPv6 routing extension header definition

2023-02-01 Thread Rongwei Liu
HI Andrew: BR Rongwei > -Original Message- > From: Andrew Rybchenko > Sent: Wednesday, February 1, 2023 17:21 > To: Rongwei Liu ; dev@dpdk.org; Matan Azrad > ; Slava Ovsiienko ; Ori Kam > ; NBU-Contact-Thomas Monjalon (EXTERNAL) > > Cc: Raslan Darawsheh ; Aman Singh > ; Yuying Zhang ; >

Re: [EXT] Re: [PATCH v5 2/2] app/testpmd: add command to process Rx metadata negotiation

2023-02-01 Thread Andrew Rybchenko
On 2/1/23 12:14, Jerin Jacob wrote: On Wed, Feb 1, 2023 at 2:37 PM Andrew Rybchenko wrote: On 2/1/23 12:05, Thomas Monjalon wrote: 01/02/2023 10:00, Ori Kam: Hi all, Sorry for jumping in late, -Original Message- From: Jerin Jacob Sent: Wednesday, 1 February 2023 10:53 On Wed, Fe

Re: [PATCH v4 1/3] ethdev: add IPv6 routing extension header definition

2023-02-01 Thread Andrew Rybchenko
On 2/1/23 12:27, Rongwei Liu wrote: HI Andrew: BR Rongwei -Original Message- From: Andrew Rybchenko Sent: Wednesday, February 1, 2023 17:21 To: Rongwei Liu ; dev@dpdk.org; Matan Azrad ; Slava Ovsiienko ; Ori Kam ; NBU-Contact-Thomas Monjalon (EXTERNAL) Cc: Raslan Darawsheh ; Aman Sin

RE: [PATCH v2 2/2] ethdev: introduce the PHY affinity field in Tx queue API

2023-02-01 Thread Jiawei(Jonny) Wang
> 30/01/2023 18:00, Jiawei Wang: > > --- a/devtools/libabigail.abignore > > +++ b/devtools/libabigail.abignore > > @@ -20,6 +20,11 @@ > > [suppress_file] > > soname_regexp = ^librte_.*mlx.*glue\. > > > > +; Ignore fields inserted in middle padding of rte_eth_txconf > > +[suppress_type]

Re: [PATCH v2 1/3] ethdev: add ICMPv6 ID and sequence

2023-02-01 Thread Thomas Monjalon
31/01/2023 07:53, Leo Xu (Networking SW): > From: Thomas Monjalon > > 20/12/2022 08:44, Leo Xu: > > > +/** > > > + * ICMP6 header > > > + */ > > > +struct rte_icmp6_hdr { > > > + uint8_t type; > > > + uint8_t code; > > > + rte_be16_t checksum; > > > +} __rte_packed; > > > + > > > +/**

Re: [PATCH v7] ethdev: add special flags when creating async transfer table

2023-02-01 Thread Thomas Monjalon
31/01/2023 06:30, Ivan Malov: > Hi Rongwei, > > OK, I hear ya. Thanks for persevering. > > I still hope community will comment on the possibility to > provide a hint mechanism for always-the-same match items, > with the perspective of becoming more versatile. Any hint could be imagined. But plea

Re: [PATCH v7] ethdev: add special flags when creating async transfer table

2023-02-01 Thread Andrew Rybchenko
On 1/18/23 19:18, Thomas Monjalon wrote: 18/01/2023 08:28, Andrew Rybchenko: On 11/14/22 14:59, Rongwei Liu wrote: In case flow rules match only one kind of traffic in a flow table, then optimization can be done via allocation of this table. Such optimization is possible only if the application

Re: [PATCH 2/2] net/vhost: support private dump

2023-02-01 Thread Maxime Coquelin
On 1/19/23 13:30, Chengwen Feng wrote: This patch implements eth_dev_priv_dump callback which could use for debugging. Signed-off-by: Chengwen Feng --- drivers/net/vhost/rte_eth_vhost.c | 21 + 1 file changed, 21 insertions(+) diff --git a/drivers/net/vhost/rte_eth_vh

Re: [PATCH 1/2] net/virtio: support private dump

2023-02-01 Thread Maxime Coquelin
On 1/19/23 13:30, Chengwen Feng wrote: This patch implements eth_dev_priv_dump callback which could use for debugging. Signed-off-by: Chengwen Feng --- drivers/net/virtio/virtio_ethdev.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/drivers/net/virtio/virtio_eth

Re: [PATCH 1/8] net/txgbe: fix Rx buffer size in configure register

2023-02-01 Thread Ferruh Yigit
On 2/1/2023 2:34 AM, Jiawen Wu wrote: > On Friday, January 27, 2023 11:36 PM, Ferruh Yigit wrote: >> On 1/18/2023 6:00 AM, Jiawen Wu wrote: >>> When round up buffer size to 1K, to configure the register, hardware >>> will receive packets exceeding the buffer size in LRO mode. It will >>> cause a se

Re: [PATCH 3/8] net/txgbe: fix packet type to parse from offload flags

2023-02-01 Thread Ferruh Yigit
On 2/1/2023 3:14 AM, Jiawen Wu wrote: > On Friday, January 27, 2023 11:37 PM, Ferruh Yigit wrote: >> On 1/18/2023 6:00 AM, Jiawen Wu wrote: >>> In some external applications, developers may fill in wrong >>> packet_type in rte_mbuf for transmission. It will result in Tx ring >>> hang when Tx checks

Re: [PATCH V6] ethdev: fix one address occupies two entries in MAC addrs

2023-02-01 Thread Thomas Monjalon
31/01/2023 07:41, Huisong Li: > The dev->data->mac_addrs[0] will be changed to a new MAC address when > applications modify the default MAC address by .mac_addr_set(). However, > if the new default one has been added as a non-default MAC address by > .mac_addr_add(), the .mac_addr_set() doesn't rem

Re: [EXT] Re: [PATCH v5 2/2] app/testpmd: add command to process Rx metadata negotiation

2023-02-01 Thread Jerin Jacob
On Wed, Feb 1, 2023 at 2:59 PM Andrew Rybchenko wrote: > > On 2/1/23 12:14, Jerin Jacob wrote: > > On Wed, Feb 1, 2023 at 2:37 PM Andrew Rybchenko > > wrote: > >> > >> On 2/1/23 12:05, Thomas Monjalon wrote: > >>> 01/02/2023 10:00, Ori Kam: > Hi all, > > Sorry for jumping in late,

Re: [EXT] Re: [PATCH v6 2/6] ethdev: add trace points for ethdev (part one)

2023-02-01 Thread Ferruh Yigit
On 2/1/2023 8:31 AM, Jerin Jacob wrote: > On Wed, Feb 1, 2023 at 3:50 AM Ferruh Yigit wrote: >> >> On 1/31/2023 6:46 PM, Jerin Jacob wrote: >>> On Wed, Feb 1, 2023 at 12:09 AM Ferruh Yigit wrote: On 1/30/2023 4:01 PM, Ankur Dwivedi wrote: <...> >>> diff --git a/lib/et

RE: [PATCH v5] enhance NUMA affinity heuristic

2023-02-01 Thread Jiale, SongX
> -Original Message- > From: Kaisen You > Sent: Wednesday, February 1, 2023 8:21 PM > To: dev@dpdk.org > Cc: Zhou, YidingX ; tho...@monjalon.net; > david.march...@redhat.com; Matz, Olivier ; > ferruh.yi...@amd.com; You, KaisenX ; > zhou...@loongson.cn; Burakov, Anatoly ; > sta...@dpdk.org

Re: [EXT] Re: [PATCH v5 2/2] app/testpmd: add command to process Rx metadata negotiation

2023-02-01 Thread Andrew Rybchenko
On 2/1/23 13:48, Jerin Jacob wrote: On Wed, Feb 1, 2023 at 2:59 PM Andrew Rybchenko wrote: On 2/1/23 12:14, Jerin Jacob wrote: On Wed, Feb 1, 2023 at 2:37 PM Andrew Rybchenko wrote: On 2/1/23 12:05, Thomas Monjalon wrote: 01/02/2023 10:00, Ori Kam: Hi all, Sorry for jumping in late, -

Re: [PATCH v7] ethdev: add special flags when creating async transfer table

2023-02-01 Thread Thomas Monjalon
01/02/2023 11:17, Andrew Rybchenko: > On 1/18/23 19:18, Thomas Monjalon wrote: > > 18/01/2023 08:28, Andrew Rybchenko: > >> On 11/14/22 14:59, Rongwei Liu wrote: > >>> In case flow rules match only one kind of traffic in a flow table, > >>> then optimization can be done via allocation of this table

Re: [PATCH v6 1/2] ethdev: add query_update sync and async function calls

2023-02-01 Thread Andrew Rybchenko
On 1/20/23 19:50, Gregory Etelson wrote: Hello Andrew, [] On 1/20/23 13:46, Gregory Etelson wrote: and it's async version `rte_flow_async_action_handle_query_update` to atomically query and update flow action. Sorry, may be I'm missing something, but after reading previous discussion I have

Re: [EXT] Re: [PATCH v5 2/2] app/testpmd: add command to process Rx metadata negotiation

2023-02-01 Thread Thomas Monjalon
01/02/2023 11:58, Andrew Rybchenko: > On 2/1/23 13:48, Jerin Jacob wrote: > > On Wed, Feb 1, 2023 at 2:59 PM Andrew Rybchenko > > wrote: > >> Frankly speaking I don't understand why default value is so > >> important if we have a way to change it. Reasons should be > >> really strong to change exi

Re: [PATCH v7] ethdev: add special flags when creating async transfer table

2023-02-01 Thread Andrew Rybchenko
On 2/1/23 13:58, Thomas Monjalon wrote: 01/02/2023 11:17, Andrew Rybchenko: On 1/18/23 19:18, Thomas Monjalon wrote: 18/01/2023 08:28, Andrew Rybchenko: On 11/14/22 14:59, Rongwei Liu wrote: In case flow rules match only one kind of traffic in a flow table, then optimization can be done via a

Re: [PATCH v2] net/i40e: support enabling/disabling source pruning

2023-02-01 Thread Thomas Monjalon
31/01/2023 04:28, Zhang, Ke1X: > From: David Marchand > > On Mon, Jan 30, 2023 at 9:23 AM Ke Zhang wrote: > > > > > > VRRP advertisement packets are dropped on i40e PF devices because > > when > > > a MAC address is added to a device, packets originating from that MAC > > > address are dropped. >

RE: [PATCH v7] ethdev: add special flags when creating async transfer table

2023-02-01 Thread Ori Kam
Hi > -Original Message- > From: Thomas Monjalon > Sent: Wednesday, 1 February 2023 12:59 > > 01/02/2023 11:17, Andrew Rybchenko: > > On 1/18/23 19:18, Thomas Monjalon wrote: > > > 18/01/2023 08:28, Andrew Rybchenko: > > >> On 11/14/22 14:59, Rongwei Liu wrote: > > >>> In case flow rules

[PATCH v5 0/9] Lock annotations

2023-02-01 Thread David Marchand
vhost internals involves multiple locks to protect data access by multiple threads. This series uses clang thread safety checks [1] to catch issues during compilation: EAL spinlock, seqlock and rwlock are annotated and vhost code is instrumented so that clang can statically check correctness. Tho

[PATCH v5 1/9] eal: annotate spinlock, rwlock and seqlock

2023-02-01 Thread David Marchand
clang offers some thread safety checks, statically verifying that locks are taken and released in the code. To use those checks, the full code leading to taking or releasing locks must be annotated with some attributes. Wrap those attributes into our own set of macros. rwlock, seqlock and the "no

[PATCH v5 2/9] vhost: simplify need reply handling

2023-02-01 Thread David Marchand
Dedicate send_vhost_slave_message() helper to the case when no reply is needed. Add a send_vhost_slave_message_process_reply() helper for the opposite. This new helper merges both send_vhost_slave_message() and the code previously in process_slave_message_reply(). The slave_req_lock lock is then o

[PATCH v5 3/9] vhost: terminate when access lock is not taken

2023-02-01 Thread David Marchand
Be a bit more strict when a programmatic error is detected with regards to the access_lock not being taken. Mark the new helper with __rte_assert_exclusive_lock so that clang understands where locks are expected to be taken. Signed-off-by: David Marchand Acked-by: Morten Brørup Reviewed-by: Maxi

[PATCH v5 4/9] vhost: annotate virtqueue access lock

2023-02-01 Thread David Marchand
vhost_user_lock/unlock_all_queue_pairs must be waived since clang annotations can't express taking a runtime number of locks. vhost_queue_stats_update() requirement can be expressed with a required tag. Signed-off-by: David Marchand Acked-by: Morten Brørup Reviewed-by: Maxime Coquelin --- Chan

[PATCH v5 5/9] vhost: annotate async accesses

2023-02-01 Thread David Marchand
vq->async is initialised and must be accessed under vq->access_lock. Signed-off-by: David Marchand Acked-by: Morten Brørup Reviewed-by: Maxime Coquelin --- Changes since RFC v3: - rebased, - fixed annotations vq->access_lock -> &vq->access_lock, - reworked free_vq, --- lib/vhost/vhost.c

  1   2   3   >