Re: [RFC] Remove Kernel Network Interface (KNI)

13/01/2023 06:03, Stephen Hemminger: > The Linux special network driver for kernel networking has been > a long term problem for DPDK. The performance benefits of KNI > are available via virtio-user and XDP, and the simpler kernel > interface via TAP is also available. > > This driver has required

RE: [PATCH v5 3/6] ethdev: add trace points for remaining functions

> -Original Message- > From: Ankur Dwivedi > Sent: Friday, January 13, 2023 12:01 PM > To: Sunil Kumar Kori ; dev@dpdk.org > Cc: tho...@monjalon.net; david.march...@redhat.com; m...@ashroe.eu; > or...@nvidia.com; ferruh.yi...@amd.com; ch...@att.com; > humi...@huawei.com; linvi...@tuxdriver

RE: [PATCH] app/testpmd: fix secondary process not forwarding

@Zhang, Yuying Hi, please take a look at this patch! Are there any comments? >-Original Message- >From: He, ShiyangX >Sent: Wednesday, January 4, 2023 10:02 AM >To: Stephen Hemminger >Cc: dev@dpdk.org; Zhou, YidingX ; >sta...@dpdk.org; Singh, Aman Deep ; Zhang, >Yuying ; Burakov, Anatoly

[PATCH v2 00/21] add support for cpfl PMD in DPDK

The patchset introduced the cpfl (Control Plane Function Library) PMD for Intel® IPU E2100’s Configure Physical Function (Device ID: 0x1453) The cpfl PMD inherits all the features from idpf PMD which will follow an ongoing standard data plan function spec https://www.oasis-open.org/committees/tc_h

[PATCH v2 01/21] net/cpfl: support device initialization

Support device init and add the following dev ops: - dev_configure - dev_close - dev_infos_get - link_update - cpfl_dev_supported_ptypes_get Signed-off-by: Mingxia Liu --- MAINTAINERS| 9 + doc/guides/nics/cpfl.rst | 66 +++ doc/guides/nics/featu

[PATCH v2 02/21] net/cpfl: add Tx queue setup

Add support for tx_queue_setup ops. In the single queue model, the same descriptor queue is used by SW to post buffer descriptors to HW and by HW to post completed descriptors to SW. In the split queue model, "RX buffer queues" are used to pass descriptor buffers from SW to HW while Rx queues are

[PATCH v2 03/21] net/cpfl: add Rx queue setup

Add support for rx_queue_setup ops. Signed-off-by: Mingxia Liu --- drivers/net/cpfl/cpfl_ethdev.c | 11 ++ drivers/net/cpfl/cpfl_rxtx.c | 232 + drivers/net/cpfl/cpfl_rxtx.h | 6 + 3 files changed, 249 insertions(+) diff --git a/drivers/net/cpfl/cpfl_ethde

[PATCH v2 04/21] net/cpfl: support device start and stop

Add dev ops dev_start, dev_stop and link_update. Signed-off-by: Mingxia Liu --- drivers/net/cpfl/cpfl_ethdev.c | 35 ++ 1 file changed, 35 insertions(+) diff --git a/drivers/net/cpfl/cpfl_ethdev.c b/drivers/net/cpfl/cpfl_ethdev.c index a113ed0de0..05c3ad1a9c 1006

[PATCH v2 05/21] net/cpfl: support queue start

Add support for these device ops: - rx_queue_start - tx_queue_start Signed-off-by: Mingxia Liu --- drivers/net/cpfl/cpfl_ethdev.c | 41 ++ drivers/net/cpfl/cpfl_rxtx.c | 138 + drivers/net/cpfl/cpfl_rxtx.h | 4 + 3 files changed, 183 insertions(+)

[PATCH v2 06/21] net/cpfl: support queue stop

Add support for these device ops: - rx_queue_stop - tx_queue_stop Signed-off-by: Mingxia Liu --- drivers/net/cpfl/cpfl_ethdev.c | 10 +++- drivers/net/cpfl/cpfl_rxtx.c | 87 ++ drivers/net/cpfl/cpfl_rxtx.h | 3 ++ 3 files changed, 99 insertions(+), 1 deleti

[PATCH v2 07/21] net/cpfl: support queue release

Add support for queue operations: - rx_queue_release - tx_queue_release Signed-off-by: Mingxia Liu --- drivers/net/cpfl/cpfl_ethdev.c | 2 ++ drivers/net/cpfl/cpfl_rxtx.c | 35 ++ drivers/net/cpfl/cpfl_rxtx.h | 2 ++ 3 files changed, 39 insertions(+) diff

[PATCH v2 08/21] net/cpfl: support MTU configuration

Add dev ops mtu_set. Signed-off-by: Mingxia Liu --- doc/guides/nics/features/cpfl.ini | 1 + drivers/net/cpfl/cpfl_ethdev.c| 26 ++ 2 files changed, 27 insertions(+) diff --git a/doc/guides/nics/features/cpfl.ini b/doc/guides/nics/features/cpfl.ini index a2d1ca9e15

[PATCH v2 09/21] net/cpfl: support basic Rx data path

Add basic Rx support in split queue mode and single queue mode. Signed-off-by: Mingxia Liu --- drivers/net/cpfl/cpfl_ethdev.c | 2 ++ drivers/net/cpfl/cpfl_rxtx.c | 11 +++ drivers/net/cpfl/cpfl_rxtx.h | 1 + 3 files changed, 14 insertions(+) diff --git a/drivers/net/cpfl/cpfl_eth

[PATCH v2 10/21] net/cpfl: support basic Tx data path

Add basic Tx support in split queue mode and single queue mode. Signed-off-by: Mingxia Liu --- drivers/net/cpfl/cpfl_ethdev.c | 3 +++ drivers/net/cpfl/cpfl_rxtx.c | 14 ++ drivers/net/cpfl/cpfl_rxtx.h | 1 + 3 files changed, 18 insertions(+) diff --git a/drivers/net/cpfl/cpfl

[PATCH v2 11/21] net/cpfl: support write back based on ITR expire

Enable write back on ITR expire, then packets can be received one by Signed-off-by: Mingxia Liu --- drivers/net/cpfl/cpfl_ethdev.c | 45 +- drivers/net/cpfl/cpfl_ethdev.h | 2 ++ 2 files changed, 46 insertions(+), 1 deletion(-) diff --git a/drivers/net/cpfl/cpfl

[PATCH v2 13/21] net/cpfl: support Rx offloading

Add Rx offloading support: - support CHKSUM and RSS offload for split queue model - support CHKSUM offload for single queue model Signed-off-by: Mingxia Liu --- doc/guides/nics/features/cpfl.ini | 2 ++ drivers/net/cpfl/cpfl_ethdev.c| 6 ++ 2 files changed, 8 insertions(+) diff --git

[PATCH v2 12/21] net/cpfl: support RSS

Add RSS support. Signed-off-by: Mingxia Liu --- drivers/net/cpfl/cpfl_ethdev.c | 51 ++ drivers/net/cpfl/cpfl_ethdev.h | 15 ++ 2 files changed, 66 insertions(+) diff --git a/drivers/net/cpfl/cpfl_ethdev.c b/drivers/net/cpfl/cpfl_ethdev.c index 8c968a8eeb

[PATCH v2 14/21] net/cpfl: support Tx offloading

Add Tx offloading support: - support TSO for single queue model and split queue model. Signed-off-by: Mingxia Liu --- doc/guides/nics/features/cpfl.ini | 1 + drivers/net/cpfl/cpfl_ethdev.c| 8 +++- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/doc/guides/nics/features/c

[PATCH v2 16/21] net/cpfl: support timestamp offload

Add support for timestamp offload. Signed-off-by: Mingxia Liu --- doc/guides/nics/features/cpfl.ini | 1 + drivers/net/cpfl/cpfl_ethdev.c| 3 ++- drivers/net/cpfl/cpfl_rxtx.c | 7 +++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/doc/guides/nics/features/cpfl.ini b

[PATCH v2 15/21] net/cpfl: add AVX512 data path for single queue model

Add support of AVX512 vector data path for single queue model. Signed-off-by: Wenjun Wu Signed-off-by: Mingxia Liu --- doc/guides/nics/cpfl.rst| 24 +- drivers/net/cpfl/cpfl_ethdev.c | 3 +- drivers/net/cpfl/cpfl_rxtx.c| 85 driv

[PATCH v2 17/21] net/cpfl: add AVX512 data path for split queue model

Add support of AVX512 data path for split queue model. Signed-off-by: Wenjun Wu Signed-off-by: Mingxia Liu --- drivers/net/cpfl/cpfl_rxtx.c| 25 + drivers/net/cpfl/cpfl_rxtx_vec_common.h | 17 +++-- 2 files changed, 40 insertions(+), 2 deletions(-

[PATCH v2 18/21] net/cpfl: add hw statistics

This patch add hardware packets/bytes statistics. Signed-off-by: Mingxia Liu --- drivers/net/cpfl/cpfl_ethdev.c | 88 ++ drivers/net/idpf/idpf_ethdev.c | 3 +- 2 files changed, 90 insertions(+), 1 deletion(-) diff --git a/drivers/net/cpfl/cpfl_ethdev.c b/drivers

[PATCH v2 19/21] net/cpfl: add RSS set/get ops

Add support for these device ops: - rss_reta_update - rss_reta_query - rss_hash_update - rss_hash_conf_get Signed-off-by: Mingxia Liu --- drivers/net/cpfl/cpfl_ethdev.c | 303 + 1 file changed, 303 insertions(+) diff --git a/drivers/net/cpfl/cpfl_ethdev.c b/drive

[PATCH v2 20/21] net/cpfl: support single q scatter RX datapath

This patch add single q recv scatter rx function. Signed-off-by: Wenjun Wu Signed-off-by: Mingxia Liu --- drivers/net/cpfl/cpfl_ethdev.c | 3 ++- drivers/net/cpfl/cpfl_rxtx.c | 26 -- drivers/net/cpfl/cpfl_rxtx.h | 2 ++ 3 files changed, 28 insertions(+), 3 deletio

[PATCH v2 21/21] net/cpfl: add xstats ops

Add support for these device ops: - dev_xstats_get - dev_xstats_get_names - dev_xstats_reset Signed-off-by: Mingxia Liu --- drivers/net/cpfl/cpfl_ethdev.c | 80 ++ 1 file changed, 80 insertions(+) diff --git a/drivers/net/cpfl/cpfl_ethdev.c b/drivers/net/cpfl/cpf

Request for src .p4

Hi Cristian I got your email via GitHub. I wonder if I can view the l2fwd.p4 that you guys compiled in order to get the l2fwd .spec in this commit: https://github.com/DPDK/dpdk/commit/43821022a4c1a35010e9f70a82e1fe0e12f6949f Thanks a lot for your time, Guy

Re: [PATCH] net/hns3: fix inaccurate RTC time to read

On 1/13/2023 6:49 AM, Dongdong Liu wrote: > Hi Huisong > > On 2023/1/9 16:23, Huisong Li wrote: >> The sequence of reading current RTC time register doesn't meet >> the hardware requirements, which causes this time obtained is >> the one before modifying RTC time. >> >> Fixes: 38b539d96eb6 ("net/h

Re: trace point symbols

On Thu, Jan 12, 2023 at 3:13 PM Morten Brørup wrote: > > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > Sent: Thursday, 12 January 2023 10.11 > > > > > > I would like to see a policy regarding trace symbols. > > If we decide option 1 is not so useful, > > then we should not export trac

RE: [RFC] net/i40e: replace get and put functions

+CC: i40e maintainers > From: Kamalakshitha Aligeri [mailto:kamalakshitha.alig...@arm.com] > Sent: Monday, 9 January 2023 15.58 > > Integrated zero-copy get and put API's in mempool cache in i40e PMD > > Signed-off-by: Kamalakshitha Aligeri > --- > 1. I have replaced the rte_mempool_get_bulk an

RE: [PATCH v2 1/4] crypto/ccp: remove some printf

[Public] Acked-by: Sunil Uttarwar -Original Message- From: David Marchand Sent: Tuesday, October 4, 2022 3:21 PM To: dev@dpdk.org Cc: gak...@marvell.com; Uttarwar, Sunil Prakashrao ; sta...@dpdk.org; Kumar, Ravi1 Subject: [PATCH v2 1/4] crypto/ccp: remove some printf Caution: This

RE: [PATCH v2 2/4] crypto/ccp: remove some dead code for UIO

[Public] Acked-by: Sunil Uttarwar -Original Message- From: David Marchand Sent: Tuesday, October 4, 2022 3:22 PM To: dev@dpdk.org Cc: gak...@marvell.com; Uttarwar, Sunil Prakashrao ; sta...@dpdk.org; Somalapuram, Amaranath Subject: [PATCH v2 2/4] crypto/ccp: remove some dead code fo

RE: [PATCH v2 3/4] crypto/ccp: fix IOVA handling

[Public] Acked-by: Sunil Uttarwar -Original Message- From: David Marchand Sent: Tuesday, October 4, 2022 3:22 PM To: dev@dpdk.org Cc: gak...@marvell.com; Uttarwar, Sunil Prakashrao ; sta...@dpdk.org; Somalapuram, Amaranath Subject: [PATCH v2 3/4] crypto/ccp: fix IOVA handling Cauti

RE: [EXT] Re: [PATCH] ring: compilation fix with GCC-12

Hi Thomas, > -Original Message- > From: Thomas Monjalon > Sent: Friday, January 13, 2023 3:12 AM > To: Konstantin Ananyev ; Honnappa > Nagarahalli ; Amit Prakash Shukla > > Cc: dev@dpdk.org; Jerin Jacob Kollanukkaran ; > david.march...@redhat.com; bruce.richard...@intel.com; > ferruh.yi.

RE: [PATCH v2 00/21] add support for cpfl PMD in DPDK

> -Original Message- > From: Mingxia Liu > Sent: Friday, January 13, 2023 4:19 PM > To: dev@dpdk.org; Zhang, Qi Z ; Wu, Jingjing > ; Xing, Beilei > Cc: Wu, Wenjun1 ; Liu, Mingxia > > Subject: [PATCH v2 00/21] add support for cpfl PMD in DPDK > > The patchset introduced the cpfl (Contr

Re: [PATCH] net/i40e: disable source pruning

On 1/9/2023 2:20 AM, Ke Zhang wrote: > VRRP advertisement packets are dropped on i40e PF devices because > when a MAC address is added to a device, packets originating from > that MAC address are dropped. > > This patch adds a interface in lib/ethdev to support disabling > source pruning to work a

Re: [EXT] Re: [PATCH] ring: compilation fix with GCC-12

13/01/2023 13:39, Amit Prakash Shukla: > From: Thomas Monjalon > > 23/08/2022 11:38, Amit Prakash Shukla: > > > From: Konstantin Ananyev > > > > 06/08/2022 19:35, Honnappa Nagarahalli пишет: > > > > >> Replacing memcpy with rte_memcpy fixes the GCC-12 compilation > > issue. > > > > > > > > > > An

RE: [PATCH v2 01/21] net/cpfl: support device initialization

> -Original Message- > From: Mingxia Liu > Sent: Friday, January 13, 2023 4:19 PM > To: dev@dpdk.org; Zhang, Qi Z ; Wu, Jingjing > ; Xing, Beilei > Cc: Wu, Wenjun1 ; Liu, Mingxia > > Subject: [PATCH v2 01/21] net/cpfl: support device initialization > > Support device init and add the

Re: [PATCH v2] net/i40e: don't check link status on device start

Hello i40e maintainers, John, On Mon, Jan 9, 2023 at 10:21 AM David Marchand wrote: > On Tue, Jan 3, 2023 at 3:02 PM David Marchand > wrote: > > Hi i40e maintainers, > > > > On Tue, Dec 13, 2022 at 10:19 AM David Marchand > > wrote: > > > > > > The mentioned changes broke existing applications

Re: [PATCH v4] net/iavf: add lock for vf commands

Hi iavf maintainers, On Thu, Dec 29, 2022 at 12:00 AM Mike Pattrick wrote: > > iavf admin queue commands aren't thread-safe. Bugs surrounding this > issue can manifest in a variety of ways but frequently pend_cmd is > over written. Simultaneously executing commands can result in a > misconfigured

RE: [PATCH v2] net/i40e: don't check link status on device start

> -Original Message- > From: David Marchand > Sent: Friday, January 13, 2023 9:33 PM > To: Zhang, Yuying ; Xing, Beilei > ; Mcnamara, John > Cc: dev@dpdk.org; sta...@dpdk.org; Zhang, Qi Z ; > Dapeng Yu ; Wenxuan Wu > > Subject: Re: [PATCH v2] net/i40e: don't check link status on device

Re: [PATCH v2] net/i40e: don't check link status on device start

On Fri, Jan 13, 2023 at 2:39 PM Zhang, Helin wrote: > > > > > -Original Message- > > From: David Marchand > > Sent: Friday, January 13, 2023 9:33 PM > > To: Zhang, Yuying ; Xing, Beilei > > ; Mcnamara, John > > Cc: dev@dpdk.org; sta...@dpdk.org; Zhang, Qi Z ; > > Dapeng Yu ; Wenxuan Wu >

RE: [PATCH v2] net/i40e: don't check link status on device start

> -Original Message- > From: David Marchand > Sent: Friday, January 13, 2023 9:47 PM > To: Zhang, Helin > Cc: Zhang, Yuying ; Xing, Beilei > ; Mcnamara, John ; > dev@dpdk.org; sta...@dpdk.org; Zhang, Qi Z ; > Dapeng Yu ; Wenxuan Wu > > Subject: Re: [PATCH v2] net/i40e: don't check link

Re: [PATCH v7 4/4] eventdev/timer: change eventdev reconfig logic

On Thu, Jan 12, 2023 at 10:01 PM Naga Harish K S V wrote: > > When rte_event_timer_adapter_create() is used for creating adapter > instance, eventdev is reconfigured with additional > ``rte_event_dev_config::nb_event_ports`` parameter. > > This eventdev reconfig logic is enhanced to increment the

Re: [PATCH v2] net/i40e: don't check link status on device start

On Fri, Jan 13, 2023 at 2:51 PM Zhang, Helin wrote: > > > > > -Original Message- > > From: David Marchand > > Sent: Friday, January 13, 2023 9:47 PM > > To: Zhang, Helin > > Cc: Zhang, Yuying ; Xing, Beilei > > ; Mcnamara, John ; > > dev@dpdk.org; sta...@dpdk.org; Zhang, Qi Z ; > > Dapen

Re: [PATCH v3] eventdev/timer: add API to get remaining ticks

On Tue, Dec 20, 2022 at 2:41 AM Erik Gabriel Carrillo wrote: > > Introduce an event timer adapter API which allows users to determine how > many adapter ticks remain until an event timer fires. > > Signed-off-by: Erik Gabriel Carrillo > > /** > diff --git a/lib/eventdev/rte_event_timer_adapter.c

Re: RFC abstracting atomics

As a user/developer I'll put a vote on Morten's side here. There are other libraries we utilize that have stated x.y.z is the last version that will support w, beginning on version l.m.n it will be standard o. I personally don't think a project asking for C11 support at a minimum would be unreaso

Marvell DPDK v23.03 Roadmap

Marvell DPDK v23.03 Roadmap for non-driver changes ~~ 1) New device class: a) Machine learning inference device library http://patches.dpdk.org/project/dpdk/patch/20221114120238.2143832-2-jer...@marvell.com/ b)Test application

Re: RFC abstracting atomics

On Fri, Jan 13, 2023 at 7:49 PM Ben Magistro wrote: > > As a user/developer I'll put a vote on Morten's side here. There are other > libraries we utilize that have stated x.y.z is the last version that will > support w, beginning on version l.m.n it will be standard o. I personally > don't th

[RFC PATCH v2 0/3] Split logging functionality out of EAL

There seems to be a general desire to reduce the size and scope of EAL. To this end, this patchset makes a (very) small step in that direction by taking the logging functionality out of EAL and putting it into its own library that can be built and maintained separately. As with the previous RFC fo

[RFC PATCH v2 1/3] eal/windows: move fnmatch function to header file

To allow the fnmatch function to be shared between libraries, without having to export it into the public namespace (since it's not prefixed with "rte"), we can convert fnmatch.c to replace fnmatch.h. This allows fnmatch function to be static and limited in scope to the current file, preventing dup

[RFC PATCH v2 2/3] log: separate logging functions out of EAL

Move the logging capability to a separate library, free from EAL. Signed-off-by: Bruce Richardson --- lib/eal/common/eal_private.h | 7 lib/eal/common/meson.build| 1 - lib/eal/include/meson.build | 1 - lib/eal/linux/meson.build

[RFC PATCH v2 3/3] telemetry: use standard logging

Now that logging is moved out of EAL, we don't need injection of the logtype and logging function from EAL to telemetry library, simplifying things. Signed-off-by: Bruce Richardson --- lib/eal/freebsd/eal.c | 6 +- lib/eal/linux/eal.c| 6 +- lib/telemetry/t

Re: [PATCH] net/vmxnet3: added checks for TCP for RSS Configuration

On 12/22/2022 8:24 AM, Raghav Roy wrote: > Added checks for TCP in vmxnet3_rss_configure() > This check ensures the hashType for RSS, when enabled > just for UDP, is not NONE. > Mandatory hash functions for v4 already added in the past: Commit 52ec00fd1474 ("net/vmxnet3: fix RSS setting on v4")

RE: [PATCH v3] eventdev/timer: add API to get remaining ticks

Hi Jerin, Thanks for the review. One response in-line: <...snipped...> > > +static int > > +swtim_get_remaining_ticks(const struct rte_event_timer_adapter > *adapter, > > + const struct rte_event_timer *evtim, > > + uint64_t *ticks_remaining) { >

RE: [PATCH v3 0/9] Standardize telemetry int types

Hi Bruce, > -Original Message- > From: Bruce Richardson > Sent: Thursday 12 January 2023 17:41 > To: dev@dpdk.org > Cc: Richardson, Bruce > Subject: [PATCH v3 0/9] Standardize telemetry int types > > Rather than having 64-bit unsigned types and 32-bit signed types supported > by the tel

RE: [RFC PATCH v2 1/3] eal/windows: move fnmatch function to header file

> From: Bruce Richardson [mailto:bruce.richard...@intel.com] > Sent: Friday, 13 January 2023 17.20 > > To allow the fnmatch function to be shared between libraries, without > having to export it into the public namespace (since it's not prefixed > with "rte"), we can convert fnmatch.c to replace f

Re: [RFC PATCH v2 1/3] eal/windows: move fnmatch function to header file

On Fri, Jan 13, 2023 at 05:41:29PM +0100, Morten Brørup wrote: > > From: Bruce Richardson [mailto:bruce.richard...@intel.com] > > Sent: Friday, 13 January 2023 17.20 > > > > To allow the fnmatch function to be shared between libraries, without > > having to export it into the public namespace (sin

Re: [PATCH v2 1/4] eal: add thread set name API operating on rte thread

On Fri, Jan 13, 2023 at 10:06:44AM +0530, Jerin Jacob wrote: > On Wed, Jan 11, 2023 at 9:39 PM David Marchand > wrote: > > > > On Wed, Dec 14, 2022 at 5:47 PM Tyler Retzlaff > > wrote: > > > diff --git a/lib/eal/common/eal_common_trace.c > > > b/lib/eal/common/eal_common_trace.c > > > index 5caa

Re: [RFC] Remove Kernel Network Interface (KNI)

On Fri, 13 Jan 2023 09:12:16 +0100 Thomas Monjalon wrote: > 13/01/2023 06:03, Stephen Hemminger: > > The Linux special network driver for kernel networking has been > > a long term problem for DPDK. The performance benefits of KNI > > are available via virtio-user and XDP, and the simpler kernel

Re: RFC abstracting atomics

On Fri, Jan 13, 2023 at 09:40:20PM +0530, Jerin Jacob wrote: > On Fri, Jan 13, 2023 at 7:49 PM Ben Magistro wrote: > > > > As a user/developer I'll put a vote on Morten's side here. There are other > > libraries we utilize that have stated x.y.z is the last version that will > > support w, begi

Re: [RFC PATCH v2 1/3] eal/windows: move fnmatch function to header file

On Fri, Jan 13, 2023 at 05:01:20PM +, Bruce Richardson wrote: > On Fri, Jan 13, 2023 at 05:41:29PM +0100, Morten Brørup wrote: > > > From: Bruce Richardson [mailto:bruce.richard...@intel.com] > > > Sent: Friday, 13 January 2023 17.20 > > > > > > To allow the fnmatch function to be shared betwe

Re: [RFC PATCH v2 1/3] eal/windows: move fnmatch function to header file

On Fri, Jan 13, 2023 at 09:31:26AM -0800, Tyler Retzlaff wrote: > On Fri, Jan 13, 2023 at 05:01:20PM +, Bruce Richardson wrote: > > On Fri, Jan 13, 2023 at 05:41:29PM +0100, Morten Brørup wrote: > > > > From: Bruce Richardson [mailto:bruce.richard...@intel.com] > > > > Sent: Friday, 13 January

Re: [RFC] Remove Kernel Network Interface (KNI)

13/01/2023 18:13, Stephen Hemminger: > On Fri, 13 Jan 2023 09:12:16 +0100 > Thomas Monjalon wrote: > > > 13/01/2023 06:03, Stephen Hemminger: > > > The Linux special network driver for kernel networking has been > > > a long term problem for DPDK. The performance benefits of KNI > > > are availab

[PATCH] ipsec: remove unneccessary null check

The function rte_ring_free() accepts NULL as vaild input like free() and other functions. Found with null_free_check.cocci. Fixes: 16d6ebb65d59 ("crypto/ipsec_mb: fix null checks") Cc: kai...@intel.com Signed-off-by: Stephen Hemminger --- drivers/crypto/ipsec_mb/ipsec_mb_ops.c | 5 + 1 file

[PATCH v4 0/4] add rte_thread_set_name API for rte_thread_t

Replace the rte_thread_setname API which operates on pthread_t with rte_thread_set_name that operates on rte_thread_t. We should try to align tracing output from the EAL for all platforms but in this case we are retaining an exception for linux as requested from the community. v4: * retain and

[PATCH v4 3/4] drivers: mlx5 use rte thread set name

Use the new internal rte_thread_set_name API instead of the now deprecated rte_thread_setname API. Signed-off-by: Tyler Retzlaff --- drivers/net/mlx5/mlx5_hws_cnt.c | 3 ++- drivers/vdpa/mlx5/mlx5_vdpa_event.c | 3 +-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/ne

[PATCH v4 4/4] eal: deprecate rte thread setname API

Notify deprecation of rte_thread_setname API, it is being removed as it exposes platform-specific thread details. The functionality it provided is now implicitly provided via the rte_lcore_set_name API if the underlying platform supports it. Signed-off-by: Tyler Retzlaff --- doc/guides/rel_notes

[PATCH v4 2/4] eal: remove thread getname API

Remove the rte_thread_getname API. The API is __rte_experimental and requires no deprecation notice. Fold the platform specific variants into the one place it is used as a special case to retain the functionality for linux only. Adjust the function as follows. * limit use of this very platform g

[PATCH v4 1/4] eal: add thread set name API operating on rte thread

Add a rte_thread_set_name that sets the name of an rte_thread_t thread. This is a replacement for the rte_thread_setname(pthread_t, ...) which exposes platform-specific details. Signed-off-by: Tyler Retzlaff --- lib/eal/common/eal_common_thread.c | 9 +++- lib/eal/freebsd/eal.c

Re: [PATCH v2 1/4] eal: add thread set name API operating on rte thread

On Fri, Jan 13, 2023 at 09:09:21AM -0800, Tyler Retzlaff wrote: > On Fri, Jan 13, 2023 at 10:06:44AM +0530, Jerin Jacob wrote: > > On Wed, Jan 11, 2023 at 9:39 PM David Marchand > > wrote: > > > > > > On Wed, Dec 14, 2022 at 5:47 PM Tyler Retzlaff > > > wrote: > > > > diff --git a/lib/eal/common/

Re: [PATCH] ipsec: remove unneccessary null check

On Fri, Jan 13, 2023 at 10:44:25AM -0800, Stephen Hemminger wrote: > The function rte_ring_free() accepts NULL as vaild input > like free() and other functions. > > Found with null_free_check.cocci. > > Fixes: 16d6ebb65d59 ("crypto/ipsec_mb: fix null checks") > Cc: kai...@intel.com > Signed-off-b

Re: [EXT] Re: [PATCH v5 0/4] add support for self monitoring

On Fri, Jan 13, 2023 at 07:44:57AM +, Tomasz Duszynski wrote: > > > >-Original Message- > >From: Tyler Retzlaff > >Sent: Wednesday, January 11, 2023 10:06 PM > >To: Tomasz Duszynski > >Cc: bruce.richard...@intel.com; m...@smartsharesystems.com; dev@dpdk.org; > >tho...@monjalon.net;

Re: [PATCH] eal: replace lcore direct use of pthread in the EAL

hey folks, any feedback here? incremental progress untangling pthread out of eal. thanks! On Thu, Dec 08, 2022 at 01:48:16PM -0800, Tyler Retzlaff wrote: > * Replace the use of pthread_t in struct lcore_config with the EAL > rte_thread_t type. > > * Replace the direct use of pthread_create(),

[PATCH v4] eventdev/timer: add API to get remaining ticks

Introduce an event timer adapter API which allows users to determine how many adapter ticks remain until an event timer expires. Signed-off-by: Erik Gabriel Carrillo --- v4: * Rename API to rte_event_timer_remaining_ticks_get * Return error if API out param is NULL instead asserting it is non-NUL

[PATCH v3 0/3] Split logging functionality out of EAL

There is a general desire to reduce the size and scope of EAL. To this end, this patchset makes a (very) small step in that direction by taking the logging functionality out of EAL and putting it into its own library that can be built and maintained separately. As with the v1 RFC for this, the mai

[PATCH v3 1/3] eal/windows: move fnmatch function to header file

To allow the fnmatch function to be shared between libraries, without having to export it into the public namespace (since it's not prefixed with "rte"), we can convert fnmatch.c to replace fnmatch.h. This allows fnmatch function to be static and limited in scope to the current file, preventing dup

[PATCH v3 2/3] log: separate logging functions out of EAL

Move the logging capability to a separate library, free from EAL. Rename files as appropriate, and use meson.build to select the correct file to be built for each operating system, rather than having a subdir per-os. Signed-off-by: Bruce Richardson Acked-by: Morten Brørup Acked-by: Tyler Retzlaf

[PATCH v3 3/3] telemetry: use standard logging

Now that logging is moved out of EAL, we don't need injection of the logtype and logging function from EAL to telemetry library, simplifying things. Signed-off-by: Bruce Richardson Acked-by: Morten Brørup Acked-by: Tyler Retzlaff --- lib/eal/freebsd/eal.c | 6 +- lib/eal/linu

[PATCH 0/7] replace zero length arrays

Zero length arrays are a GNU extension that has been superseded by flex arrays. https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html These are places found by cocci/zero_length_array.cocci Stephen Hemminger (7): member: replace zero length array with flex array cryptodev: replace zero length

[PATCH 1/7] member: replace zero length array with flex array

Zero length arrays are GNU extension. Replace with standard flex array. Signed-off-by: Stephen Hemminger --- lib/member/rte_member_heap.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/member/rte_member_heap.h b/lib/member/rte_member_heap.h index 9c4a01aebe95..ab6319bc2d

[PATCH 2/7] cryptodev: replace zero length array with flex array

Zero length arrays are GNU extension. Replace with standard flex array. Signed-off-by: Stephen Hemminger --- lib/cryptodev/cryptodev_pmd.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/cryptodev/cryptodev_pmd.h b/lib/cryptodev/cryptodev_pmd.h index 0020102eb7db..ffca31d

[PATCH 3/7] security: replace zero length array with flex array

Zero length arrays are GNU extension. Replace with standard flex array. Signed-off-by: Stephen Hemminger --- lib/security/rte_security_driver.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/security/rte_security_driver.h b/lib/security/rte_security_driver.h index 421e6

[PATCH 4/7] mlx5: replace zero length array with flex array

Zero length arrays are GNU extension. Replace with standard flex array. Signed-off-by: Stephen Hemminger --- drivers/net/mlx5/mlx5.h | 4 ++-- drivers/net/mlx5/mlx5_flow.h | 2 +- drivers/net/mlx5/mlx5_tx.h | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net

[PATCH 5/7] nfp: replace zero length array with flex array

Zero length arrays are GNU extension. Replace with standard flex array. Signed-off-by: Stephen Hemminger --- drivers/net/nfp/flower/nfp_flower_cmsg.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/nfp/flower/nfp_flower_cmsg.h b/drivers/net/nfp/flower/nfp_flower_

[PATCH 6/7] enic: replace zero length array with flex array

Zero length arrays are GNU extension. Replace with standard flex array. Signed-off-by: Stephen Hemminger --- drivers/net/enic/base/vnic_devcmd.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/enic/base/vnic_devcmd.h b/drivers/net/enic/base/vnic_devcmd.h index 25

[PATCH 7/7] dpaax: replace zero length array with flex array

Zero length arrays are GNU extension. Replace with standard flex array. Signed-off-by: Stephen Hemminger --- drivers/common/dpaax/caamflib/desc/ipsec.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/common/dpaax/caamflib/desc/ipsec.h b/drivers/common/dpaax/caamflib/

Re: [PATCH] net/vmxnet3: added checks for TCP for RSS Configuration

The check is at an additional location. I agree, and pointed out to him offline earlier, that a check for the h/w version should be used with the additional code, too. Jochen From: Ferruh Yigit Date: Friday, January 13, 2023 at 8:24 AM To: Raghav Roy , dev@dpdk.org Cc: Joche

Re: [RFC] Remove Kernel Network Interface (KNI)

On Fri, 13 Jan 2023 19:34:24 +0100 Thomas Monjalon wrote: > 13/01/2023 18:13, Stephen Hemminger: > > On Fri, 13 Jan 2023 09:12:16 +0100 > > Thomas Monjalon wrote: > > > > > 13/01/2023 06:03, Stephen Hemminger: > > > > The Linux special network driver for kernel networking has been > > > > a

Re: [PATCH 1/7] member: replace zero length array with flex array

On Fri, Jan 13, 2023 at 01:51:59PM -0800, Stephen Hemminger wrote: > Zero length arrays are GNU extension. Replace with > standard flex array. > > Signed-off-by: Stephen Hemminger > --- > lib/member/rte_member_heap.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/m

Re: [PATCH 1/7] member: replace zero length array with flex array

On Fri, 13 Jan 2023 16:19:21 -0800 Tyler Retzlaff wrote: > On Fri, Jan 13, 2023 at 01:51:59PM -0800, Stephen Hemminger wrote: > > Zero length arrays are GNU extension. Replace with > > standard flex array. > > > > Signed-off-by: Stephen Hemminger > > --- > > lib/member/rte_member_heap.h | 2 +-

Re: [PATCH 1/7] member: replace zero length array with flex array

On Fri, Jan 13, 2023 at 04:36:10PM -0800, Stephen Hemminger wrote: > On Fri, 13 Jan 2023 16:19:21 -0800 > Tyler Retzlaff wrote: > > > On Fri, Jan 13, 2023 at 01:51:59PM -0800, Stephen Hemminger wrote: > > > Zero length arrays are GNU extension. Replace with > > > standard flex array. > > > > > >

Re: [PATCH 6/7] enic: replace zero length array with flex array

Acked-by: John Daley From: Stephen Hemminger Date: Friday, January 13, 2023 at 1:52 PM To: dev@dpdk.org Cc: Stephen Hemminger , John Daley (johndale) , Hyong Youb Kim (hyonkim) Subject: [PATCH 6/7] enic: replace zero length array with flex array Zero length arrays are GNU extension. Replace w

[PATCH v6 0/1] Add support AVX512 split queue datapath

This patchset enables AVX512 data path for split queue model. It is based on the below two pathsets 1. https://patches.dpdk.org/project/dpdk/cover/20230106090501.9106-1-beilei.x...@intel.com/ 2. https://patches.dpdk.org/project/dpdk/cover/20230106091627.13530-1-beilei.x...@intel.com/ v3: fix l

[PATCH v6 1/1] common/idpf: add AVX512 data path for split queue model

Add support of AVX512 data path for split queue model. Signed-off-by: Wenjun Wu Reviewed-by: Wenjing Qiao Acked-by: Wenzhuo Lu --- drivers/common/idpf/idpf_common_rxtx.c| 22 +- drivers/common/idpf/idpf_common_rxtx.h| 19 +- drivers/common/idpf/idpf_common_rxtx_avx512.c | 797