There seems to be a general desire to reduce the size and scope of
EAL. To this end, this patchset makes a (very) small step in that
direction by taking the logging functionality out of EAL and putting
it into its own library that can be built and maintained separately.
As with the previous RFC for this, the main obstacle is the "fnmatch"
function which is needed by both EAL and the new log function when
building on windows. While the function cannot stay in EAL - or we
would have a circular dependency, moving it to a new library or just
putting it in the log library have the disadvantages that it then
"leaks" into the public namespace without an rte_prefix, which could
cause issues. Since only a single function is involved, this v2 RFC
takes a different approach to v1, and just moves the offending function
to be a static function in a header file. This allows use by multiple
libs without conflicting names or making it public.
The other complication, as explained in v1 RFC was that of multiple
implementations for different OS's. This is solved here in the same
way as v1, by including the OS in the name and having meson pick the
correct file for each build. Since only one file is involved, there
seemed little need for replicating EAL's separate subdirectories
per-OS.
Bruce Richardson (3):
eal/windows: move fnmatch function to header file
log: separate logging functions out of EAL
telemetry: use standard logging
lib/eal/common/eal_private.h | 7 -
lib/eal/common/meson.build | 1 -
lib/eal/freebsd/eal.c | 6 +-
lib/eal/include/meson.build | 1 -
lib/eal/linux/eal.c | 6 +-
lib/eal/linux/meson.build | 1 -
lib/eal/meson.build | 2 +-
lib/eal/version.map | 17 --
lib/eal/windows/fnmatch.c | 172 -----------------
lib/eal/windows/include/fnmatch.h | 175 ++++++++++++++++--
lib/eal/windows/meson.build | 2 -
lib/kvargs/meson.build | 3 +-
lib/{eal/common => log}/eal_common_log.c | 1 -
lib/{eal/common => log}/eal_log.h | 12 ++
.../linux/eal_log.c => log/eal_log_linux.c} | 0
.../eal_log.c => log/eal_log_windows.c} | 0
lib/log/meson.build | 9 +
lib/{eal/include => log}/rte_log.h | 0
lib/log/version.map | 34 ++++
lib/meson.build | 1 +
lib/telemetry/meson.build | 3 +-
lib/telemetry/telemetry.c | 12 +-
lib/telemetry/telemetry_internal.h | 3 +-
23 files changed, 229 insertions(+), 239 deletions(-)
delete mode 100644 lib/eal/windows/fnmatch.c
rename lib/{eal/common => log}/eal_common_log.c (99%)
rename lib/{eal/common => log}/eal_log.h (78%)
rename lib/{eal/linux/eal_log.c => log/eal_log_linux.c} (100%)
rename lib/{eal/windows/eal_log.c => log/eal_log_windows.c} (100%)
create mode 100644 lib/log/meson.build
rename lib/{eal/include => log}/rte_log.h (100%)
create mode 100644 lib/log/version.map
--
2.34.1
