On Fri, Jan 13, 2023 at 2:39 PM Zhang, Helin <helin.zh...@intel.com> wrote: > > > > > -----Original Message----- > > From: David Marchand <david.march...@redhat.com> > > Sent: Friday, January 13, 2023 9:33 PM > > To: Zhang, Yuying <yuying.zh...@intel.com>; Xing, Beilei > > <beilei.x...@intel.com>; Mcnamara, John <john.mcnam...@intel.com> > > Cc: dev@dpdk.org; sta...@dpdk.org; Zhang, Qi Z <qi.z.zh...@intel.com>; > > Dapeng Yu <dapengx...@intel.com>; Wenxuan Wu > > <wenxuanx...@intel.com> > > Subject: Re: [PATCH v2] net/i40e: don't check link status on device start > > > > Hello i40e maintainers, John, > > > > On Mon, Jan 9, 2023 at 10:21 AM David Marchand > > <david.march...@redhat.com> wrote: > > > On Tue, Jan 3, 2023 at 3:02 PM David Marchand > > <david.march...@redhat.com> wrote: > > > > Hi i40e maintainers, > > > > > > > > On Tue, Dec 13, 2022 at 10:19 AM David Marchand > > > > <david.march...@redhat.com> wrote: > > > > > > > > > > The mentioned changes broke existing applications when the link > > > > > status of i40e ports is down at the time the port is started. > > > > > Revert those changes, the original issue will need a different fix. > Hi David > > Does it break all the application or just a specific application?
I don't see how it would not affect all applications seeing how the original patch is dumb. > We may need to understand the issue you met, and try to fix it later. Just unplug the cable or fake a link down on your i40e port, start your application or port, then plug the cable back. The max frame size will never get applied to hw. -- David Marchand
