On 10/4/22 19:16, Nicolas Chautru wrote:
Added device status information, so that the PMD can
expose information related to the underlying accelerator device status.
Minor order change in structure to fit into padding hole.
Signed-off-by: Nicolas Chautru
Acked-by: Mingshan Zhang
Acked-by: H
On Tue, Oct 4, 2022 at 6:47 PM Kevin Laatz wrote:
>
> During EAL init, all buses are probed and the devices found are
> initialized. On eal_cleanup(), the inverse does not happen, meaning any
> allocated memory and other configuration will not be cleaned up
> appropriately on exit.
>
> Currently,
Add removal note for experimental empty poll API.
CC: David Hunt
Signed-off-by: Reshma Pattan
Acked-by: David Hunt
---
doc/guides/prog_guide/power_man.rst | 6 ++
1 file changed, 6 insertions(+)
diff --git a/doc/guides/prog_guide/power_man.rst
b/doc/guides/prog_guide/power_man.rst
index
On Tue, Oct 4, 2022 at 4:59 PM Olivier Matz wrote:
>
> The dev->device.numa_node field is set by each bus driver for
> every device it manages to indicate on which NUMA node this device lies.
>
> When this information is unknown, the assigned value is not consistent
> across the bus drivers.
>
> S
08/08/2022 23:21, Tyler Retzlaff:
> From: Tyler Retzlaff
>
> return fixed width uint32_t to be consistent with what appears to
> be the original authors intent. it doesn't make much sense to return
> signed integers for these functions.
>
> Signed-off-by: Tyler Retzlaff
> ---
> lib/eal/include
Hi David,
On Wed, Oct 05, 2022 at 10:52:49AM +0200, David Marchand wrote:
> On Tue, Oct 4, 2022 at 4:59 PM Olivier Matz wrote:
> >
> > The dev->device.numa_node field is set by each bus driver for
> > every device it manages to indicate on which NUMA node this device lies.
> >
> > When this infor
08/08/2022 23:21, Tyler Retzlaff:
> From: Tyler Retzlaff
>
> The cleanup resulted from request to review [1] the following
> functions where there appeared to be inconsistency in return type
> or parameter type selections for the following inline functions.
>
> rte_bsf32()
> rte_bsf32_safe()
> r
This series contains performance improvements and new statistics-
related functionality for the EAL service cores framework.
A new per-lcore TSC cycle counter is introduced, which reflect the
total amount of cycles spent by that lcore running services. This may
be used to estimate service lcore lo
As a part of its service function, a service usually polls some kind
of source (e.g., an RX queue, a ring, an eventdev port, or a timer
wheel) to retrieve one or more items of work.
In low-load situations, the service framework reports a significant
amount of cycles spent for all running services,
Introduce a per-lcore counter for the total time spent on processing
services on that core.
This counter is useful when measuring individual lcore load.
Signed-off-by: Mattias Rönnblom
---
app/test/test_service_cores.c | 2 +-
lib/eal/common/rte_service.c | 15 +++
lib/eal/include
Optimize service loop so that the starting point is the lowest-indexed
service mapped to the lcore in question, and terminate the loop at the
highest-indexed service.
While the worst case latency remains the same, this patch
significantly reduces the service framework overhead for the average
case
Have the SW event device conform to the service core convention, where
-EAGAIN is return in case no work was performed.
Prior to this patch, for an idle SW event device, a service lcore load
estimate based on RTE_SERVICE_ATTR_CYCLES would suggest 48% core
load.
At 7% of its maximum capacity, the
Refer to API functions with parenthesis, making doxygen create
hyperlinks.
Signed-off-by: Mattias Rönnblom
---
lib/eal/include/rte_service.h | 26 +-
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/lib/eal/include/rte_service.h b/lib/eal/include/rte_servic
Move the statistics from the service data structure to the per-lcore
struct. This eliminates contention for the counter cache lines, which
decreases the producer-side statistics overhead for services deployed
across many lcores.
Prior to this patch, enabling statistics for a service with a
per-ser
05/10/2022 11:04, Olivier Matz:
> Hi David,
>
> On Wed, Oct 05, 2022 at 10:52:49AM +0200, David Marchand wrote:
> > On Tue, Oct 4, 2022 at 4:59 PM Olivier Matz wrote:
> > >
> > > The dev->device.numa_node field is set by each bus driver for
> > > every device it manages to indicate on which NUMA
05/10/2022 09:45, David Marchand:
> On Tue, Oct 4, 2022 at 6:47 PM Kevin Laatz wrote:
> > This patch proposes adding bus cleanup to the eal_cleanup() to make EAL's
> > init/exit more symmetrical, ensuring all bus devices are cleaned up
> > appropriately without the application needing to be aware
> From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com]
> Sent: Wednesday, 5 October 2022 11.16
>
> This series contains performance improvements and new statistics-
> related functionality for the EAL service cores framework.
>
> A new per-lcore TSC cycle counter is introduced, which ref
Update net/af_xdp build to support libbfp v0.8.0.
Avoid library version based checks, check for function presense
instead.
v3:
- avoid version-based checks
Andrew Rybchenko (5):
net/af_xdp: move XDP library presence flag to right branch
net/af_xdp: make it clear which libxdp version is re
From: Morten Brørup
A flush threshold for the mempool cache was introduced in DPDK version
1.3, but rte_mempool_do_generic_get() was not completely updated back
then, and some inefficiencies were introduced.
Fix the following in rte_mempool_do_generic_get():
1. The code that initially screens t
RTE_NET_AF_XDP_LIBXDP is a conditional to include xdp/xsk.h and should
be set as soon as we know that the header is present.
RTE_NET_AF_XDP_SHARED_UMEM is one of conditions to use
xsk_socket__create_shared().
Both do not depend on libbpf and bpf/bpf.h presence.
Since else branch below returns erro
Check for xsk_socket__create_shared() function instead.
Signed-off-by: Andrew Rybchenko
---
drivers/net/af_xdp/meson.build | 21 +++--
1 file changed, 15 insertions(+), 6 deletions(-)
diff --git a/drivers/net/af_xdp/meson.build b/drivers/net/af_xdp/meson.build
index fa011c357d..
Include checked libxdp version in driver build skip reason.
Signed-off-by: Andrew Rybchenko
---
drivers/net/af_xdp/meson.build | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/net/af_xdp/meson.build b/drivers/net/af_xdp/meson.build
index 882d0b9518..fa011c357d 1
Version-based checks are bad. It is better to check for required
functions. Check for bpf_object__next_program() in this case since
it appears last in libbpf among functions used to load program
without bpf_prog_load() which is deprecated in libbpf v0.7.0.
Signed-off-by: Andrew Rybchenko
---
dri
Make it visible in logs if something goes wrong on XDP program
removal failure.
Signed-off-by: Andrew Rybchenko
---
drivers/net/af_xdp/rte_eth_af_xdp.c | 21 ++---
1 file changed, 14 insertions(+), 7 deletions(-)
diff --git a/drivers/net/af_xdp/rte_eth_af_xdp.c
b/drivers/net/af
From: Ciara Loftus
libbpf v0.8.0 deprecates the bpf_get_link_xdp_id() and
bpf_set_link_xdp_fd() functions. Use meson to detect if
bpf_xdp_attach() is available and if so, use the recommended
replacement functions bpf_xdp_query_id(), bpf_xdp_attach()
and bpf_xdp_detach().
Signed-off-by: Ciara Lof
On 9/6/22 15:06, Zhang, Qi Z wrote:
-Original Message-
From: Koikkara Reeny, Shibin
Sent: Friday, July 22, 2022 4:51 PM
To: dev@dpdk.org
Cc: Loftus, Ciara ; Zhang, Qi Z
Subject: [PATCH v2] net/af_xdp: improve documentation
From: Ciara Loftus
Instead of a one-liner describing each
I'm sorry, below duplicate is sent my mistake.
On 10/5/22 12:50, Andrew Rybchenko wrote:
From: Morten Brørup
A flush threshold for the mempool cache was introduced in DPDK version
1.3, but rte_mempool_do_generic_get() was not completely updated back
then, and some inefficiencies were introduce
09/08/2022 10:26, Morten Brørup:
> > From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com]
> > Sent: Monday, 8 August 2022 23.21
> >
> > The cleanup resulted from request to review [1] the following
> > functions where there appeared to be inconsistency in return type
> > or parameter type se
On 2022-10-05 11:49, Morten Brørup wrote:
>> From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com]
>> Sent: Wednesday, 5 October 2022 11.16
>>
>> This series contains performance improvements and new statistics-
>> related functionality for the EAL service cores framework.
>>
>> A new per-l
05/10/2022 00:09, Reshma Pattan:
> From: Hamza Khan
>
> Currently, when vm_power_manager exits, we are using a LIST_FOREACH
> macro to iterate over VM info structures while freeing them. This
> leads to use-after-free error. To address this, replace all usages of
> LIST_* with TAILQ_* macros, and
https://bugs.dpdk.org/show_bug.cgi?id=1094
Bug ID: 1094
Summary: Add FPGA bus cleanup
Product: DPDK
Version: unspecified
Hardware: All
OS: All
Status: UNCONFIRMED
Severity: normal
Priority: Norma
> -Original Message-
> From: Thomas Monjalon
> Sent: Tuesday 4 October 2022 18:09
> To: Kearney, Tadhg
> Cc: dev@dpdk.org; Hunt, David ; Burakov, Anatoly
> ; Pattan, Reshma
> Subject: Re: [PATCH v7 1/3] power: add uncore frequency control API to the
> power library
>
> 28/09/2022 15:30,
Hi Thomas, All,
On 05/10/2022 10:41, Thomas Monjalon wrote:
05/10/2022 09:45, David Marchand:
On Tue, Oct 4, 2022 at 6:47 PM Kevin Laatz wrote:
This patch proposes adding bus cleanup to the eal_cleanup() to make EAL's
init/exit more symmetrical, ensuring all bus devices are cleaned up
appropr
These actions have been deprecated since DPDK 21.11 as
ambiguous and hard-to-use, but their removal might not
be popular because net drivers i40e, ixgbe and txgbe
employ these actions in complicated "PF/VF + QUEUE"
tunnel rule support. Maintainers of these drivers
should voice their attitude to the
On 9/26/2022 7:59 AM, Chaoyong He wrote:
This is the first patch series to add the support of rte_flow offload for
nfp PMD, includes:
Add the support of flower firmware application
Add the support of representor port
Add the flower service infrastructure
Add the cmsg interactive channels between
05/10/2022 13:03, Kevin Laatz:
> Hi Thomas, All,
>
> On 05/10/2022 10:41, Thomas Monjalon wrote:
> > 05/10/2022 09:45, David Marchand:
> >> On Tue, Oct 4, 2022 at 6:47 PM Kevin Laatz wrote:
> >>> This patch proposes adding bus cleanup to the eal_cleanup() to make EAL's
> >>> init/exit more symmet
05/10/2022 12:50, Kearney, Tadhg:
> > -Original Message-
> > From: Thomas Monjalon
> > Sent: Tuesday 4 October 2022 18:09
> > To: Kearney, Tadhg
> > Cc: dev@dpdk.org; Hunt, David ; Burakov, Anatoly
> > ; Pattan, Reshma
> > Subject: Re: [PATCH v7 1/3] power: add uncore frequency control A
> > When more than two packets are merged in a flow, and if we receive a 3rd
> > packet which is matching the sequence of the 2nd packet the prev_idx will
> > be 1 and not 2, hence resulting in packet re-ordering
> >
> > Signed-off-by: Kumara Parameshwaran
> > ---
> > V1:
> > Initial changes
05/10/2022 10:44, Reshma Pattan:
> Add removal note for experimental empty poll API.
>
> CC: David Hunt
>
> Signed-off-by: Reshma Pattan
> Acked-by: David Hunt
[...]
> --- a/doc/guides/prog_guide/power_man.rst
> +++ b/doc/guides/prog_guide/power_man.rst
> @@ -192,6 +192,12 @@ User Cases
> ---
27/09/2022 06:37, Harshad Narayane:
> Coverity issue: 380863
> Coverity issue: 380866
> Fixes: 6bc14d9f ("examples/pipeline: add command for shared library build")
>
> Fix memory resource free for buffer allocation failure at pipeline
> library build.
>
> Signed-off-by: Harshad Narayane
> Signed
27/09/2022 06:35, Harshad Narayane:
> Coverity issue: 380860
> Fixes: 9043f66a ("examples/pipeline: add command for code generation")
>
> Fix file close at pipeline code generation.
>
> Signed-off-by: Harshad Narayane
> Signed-off-by: Kamalakannan R
> Acked-by: Cristian Dumitrescu
> ---
> ---
On 8/2/22 02:49, Claudio Fontana wrote:
check when increasing vec_idx that it is still valid
in the (buf_len < dev->vhost_hlen) case too.
Tested-by: Claudio Fontana
Signed-off-by: Claudio Fontana
---
lib/vhost/virtio_net.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff -
> > On Wed, Sep 14, 2022 at 9:03 PM Naga Harish K S V
> > wrote:
> > >
> > > There is a possibility of deadlock in this API, as same spinlock is
> > > tried to be acquired in nested manner.
> > >
> > > If the lcore that is stopping the timer is different from the lcore
> > > that owns the timer, t
On Mon, Jul 11, 2022 at 3:18 PM Harry van Haaren
wrote:
>
> This commit fixes a potential racey-add that could occur if
> multiple service-lcores were executing the same MT-safe service
> at the same time, with service statistics collection enabled.
>
> Because multiple threads can run and execute
On Wed, Oct 5, 2022 at 11:20 AM Mattias Rönnblom
wrote:
>
> This series contains performance improvements and new statistics-
> related functionality for the EAL service cores framework.
>
> A new per-lcore TSC cycle counter is introduced, which reflect the
> total amount of cycles spent by that l
On 14/09/2022 10:29, Kevin Laatz wrote:
Currently, there is no way to measure lcore polling busyness in a passive
way, without any modifications to the application. This patchset adds a new
EAL API that will be able to passively track core polling busyness. As part
of the set, new telemetry endpo
On 9/28/2022 6:25 AM, Gagandeep Singh wrote:
Add support of ESP packet type in packet receive path.
Signed-off-by: Gagandeep Singh
---
drivers/net/dpaa/dpaa_rxtx.c | 10 ++
drivers/net/dpaa/dpaa_rxtx.h | 6 ++
2 files changed, 16 insertions(+)
diff --git a/drivers/net/dpaa/dpa
On 9/28/2022 6:25 AM, Gagandeep Singh wrote:
Creating and using driver's mempool for
allocating the SG table memory required for
FD creation instead of relying on user mempool.
As far as I can see this is in the Tx path, can you please explain why
driver need an internal pktmbuf pool?
And s
On 9/28/2022 6:25 AM, Gagandeep Singh wrote:
Adding a check in slow path to free those buffers
which are not external.
Can you please explain what was the error before fix, what was happening
when you try to free all mbufs?
Also it seems previous logic was different, with 'prev_seg' etc, ca
On 9/28/2022 6:25 AM, Gagandeep Singh wrote:
From: Rohit Raj
Due to change in latest kernel, passing the interface name to
kernel through IOCTL as string instead of character pointer.
This kernel component is the one that is delivered part of SDK I assume,
instead of an upstreamed one.
Wh
On 9/28/2022 6:25 AM, Gagandeep Singh wrote:
This series have list of patch for bug fixes and
some enhancements to DPAA1 and DPAA2 net drivers.
Apeksha Gupta (2):
net/enetfec: fix restart issue
net/enetfec: fix buffer leak issue
Gagandeep Singh (7):
net/dpaa: support ESP packet type in
On 9/28/2022 6:25 AM, Gagandeep Singh wrote:
From: brick
Check if there exists free enqueue descriptors before enqueuing Tx
packet. Also try to free enqueue descriptors in case they are not
free.
Fixes: ed1cdbed6a15 ("net/dpaa2: support multiple Tx queues enqueue for
ordered")
Cc: sta...@dpdk
To ensure all users are aware of KNI's deprecated status at build time
we can take the following actions:
1. disable the library by default. It can be re-enabled by setting
disabled_libs to the empty string (or other string not including
'kni')
2. add support for a list of deprecated libs t
When KNI is being used at runtime, output a warning message about its
deprecated status. This is part of the deprecation process for KNI
agreed by the DPDK technical board.[1]
[1] http://mails.dpdk.org/archives/dev/2022-June/243596.html
Signed-off-by: Bruce Richardson
---
doc/guides/rel_notes/d
> From: Bruce Richardson [mailto:bruce.richard...@intel.com]
> Sent: Wednesday, 5 October 2022 16.35
>
> To ensure all users are aware of KNI's deprecated status at build time
> we can take the following actions:
>
> 1. disable the library by default. It can be re-enabled by setting
>disabled
This patch fixes a compilation issue met with GCC on
Loongarch64:
In function ‘mbuf_to_desc’,
inlined from ‘vhost_enqueue_async_packed’ at
../../../dpdk/lib/vhost/virtio_net.c:1822:6,
inlined from ‘virtio_dev_rx_async_packed’ at
../../../dpdk/lib/vhost/virtio_net.c:1836:6,
inlined fr
Hi Min,
On 9/26/22 05:25, zhoumin wrote:
Hi Chenbo,
On Mon, 26 Sep 2022, 10:57, Xia, Chenbo wrote:
Hi Min,
-Original Message-
From: Min Zhou
Sent: Monday, August 29, 2022 4:29 PM
To: david.march...@redhat.com; maxime.coque...@redhat.com; Xia, Chenbo
; zhou...@loongson.cn
Cc: dev@dp
On Wed, Oct 5, 2022 at 4:49 PM Maxime Coquelin
wrote:
>
> This patch fixes a compilation issue met with GCC on
GCC 12 (it is worth detailing, since I and Thomas hit the same issue
on some other cross compiling toolchains using GCC 12).
> Loongarch64:
LoongArch64
>
> In function ‘mbuf_to_desc’,
On 8/2/22 02:49, Claudio Fontana wrote:
in virtio_dev_split we cannot currently call desc_to_mbuf with
nr_vec == 0, or we end up trying to rte_memcpy from a source address
buf_vec[0] that is an uninitialized stack variable.
Improve this in general by having desc_to_mbuf and mbuf_to_desc
retur
On 10/5/22 16:56, David Marchand wrote:
On Wed, Oct 5, 2022 at 4:49 PM Maxime Coquelin
wrote:
This patch fixes a compilation issue met with GCC on
GCC 12 (it is worth detailing, since I and Thomas hit the same issue
on some other cross compiling toolchains using GCC 12).
Loongarch64:
This patch fixes a compilation issue met with GCC 12 on
LoongArch64:
In function ‘mbuf_to_desc’,
inlined from ‘vhost_enqueue_async_packed’ at
../../../dpdk/lib/vhost/virtio_net.c:1822:6,
inlined from ‘virtio_dev_rx_async_packed’ at
../../../dpdk/lib/vhost/virtio_net.c:1836:6,
inlined
On Wed, Oct 05, 2022 at 11:02:45AM +0200, Thomas Monjalon wrote:
> 08/08/2022 23:21, Tyler Retzlaff:
> > From: Tyler Retzlaff
> >
>
> You forgot the _safe versions:
>
> --- a/lib/eal/include/rte_common.h
> +++ b/lib/eal/include/rte_common.h
> @@ -660,7 +660,7 @@ rte_bsf32(uint32_t v)
> * @re
05/10/2022 17:15, Tyler Retzlaff:
> On Wed, Oct 05, 2022 at 11:02:45AM +0200, Thomas Monjalon wrote:
> > 08/08/2022 23:21, Tyler Retzlaff:
> > > From: Tyler Retzlaff
> > >
> >
> > You forgot the _safe versions:
>
> >
> > --- a/lib/eal/include/rte_common.h
> > +++ b/lib/eal/include/rte_common.h
and need to be included for the build
since they were removed from .
../examples/l2fwd-cat/cat.c: In function ‘parse_set’:
../examples/l2fwd-cat/cat.c:66:16:
warning: implicit declaration of function ‘isblank’
[-Wimplicit-function-declaration]
66 | while (isblank(*str))
|
On Wed, Oct 5, 2022 at 5:24 PM Kevin Traynor wrote:
>
> and need to be included for the build
> since they were removed from .
>
> ../examples/l2fwd-cat/cat.c: In function ‘parse_set’:
> ../examples/l2fwd-cat/cat.c:66:16:
> warning: implicit declaration of function ‘isblank’
> [-Wimplicit-functi
Protocol type based buffer split consists of splitting a received packet
into several separate segments based on the packet content. It is useful
in some scenarios, such as GPU acceleration. The splitting will help to
enable true zero copy and hence improve the performance significantly.
This patc
Add a new ethdev API to retrieve supported protocol headers
of a PMD, which helps to configure protocol header based buffer split.
Signed-off-by: Yuan Wang
Signed-off-by: Xuan Ding
Signed-off-by: Wenxuan Wu
Reviewed-by: Andrew Rybchenko
---
doc/guides/rel_notes/release_22_11.rst | 5
li
Currently, Rx buffer split supports length based split. With Rx queue
offload RTE_ETH_RX_OFFLOAD_BUFFER_SPLIT enabled and Rx packet segment
configured, PMD will be able to split the received packets into
multiple segments.
However, length based buffer split is not suitable for NICs that do split
b
Add command line parameter:
--rxhdrs=eth[,ipv4,udp]
Set the protocol_hdr of segments to scatter packets on receiving if
split feature is engaged. And the queues with BUFFER_SPLIT flag.
Add interactive mode command:
testpmd>set rxhdrs eth,ipv4,udp
(protocol sequence should be valid)
The protocol
This patch adds support for protocol based buffer split in normal Rx
data paths. When the Rx queue is configured with specific protocol type,
packets received will be directly split into protocol header and
payload parts limitation of pmd. And the two parts will be
put into different mempools.
Cur
On 10/5/22 17:11, Maxime Coquelin wrote:
This patch fixes a compilation issue met with GCC 12 on
LoongArch64:
In function ‘mbuf_to_desc’,
inlined from ‘vhost_enqueue_async_packed’ at
../../../dpdk/lib/vhost/virtio_net.c:1822:6,
inlined from ‘virtio_dev_rx_async_packed’ at
../../..
In a recent commit, changing return type from int to uint32_t,
I did a last minute change to functions rte_bsf32_safe and rte_bsf64_safe,
because thought they were forgotten.
Actually these functions are returning 0 or 1, so it should be int.
The return type is reverted to the original type for the
On 9/22/2022 2:09 PM, Niklas Söderlund wrote:
From: Long Wu
nfp_net_recv_pkts() should not return a value that less than 0 and the
inappropriate return value in receive loop also causes the memory leak.
Modify code to avoid return a value less than 0. Furthermore, When
nfp_net_recv_pkts() break
hi David,
On Wed, Sep 21, 2022 at 10:15:36AM +0200, David Marchand wrote:
> On Mon, Jun 27, 2022 at 6:56 PM Tyler Retzlaff
> wrote:
> >
> > add rte thread lifetime and attributes api. with these api additions
> > there is now sufficient platform abstracted thread api to remove the
> > use of pthr
This is targeting 22.11 and aims to add an API to DPDK power library to
allow uncore frequency adjustment. This will be called through the l3fwd-power
app and gives the ability to set the minimum and maximum uncore frequency to
both min, max or specific frequency index.
Signed-off-by: tadhgkearney
Add API to allow uncore frequency adjustment. Uncore is a
term used by Intel to describe function of a microprocessor
that are closely connected to the core to achieve high
performance. This is done through manipulating related
uncore frequency control sysfs entries to adjust the
minimum and maximu
Add basic unit tests covering all nine uncore API's.
Signed-off-by: Tadhg Kearney
Reviewed-by: David Hunt
Acked-by: David Hunt
---
app/test/meson.build | 2 +
app/test/test_power_intel_uncore.c | 301 +
2 files changed, 303 insertions(+)
create mode
Add option for setting uncore frequency min/max/index, through uncore API.
This will be set for each package and die on the SKU. On exit, uncore min
and max frequency will be reverted back to previous frequencies.
Signed-off-by: Tadhg Kearney
Reviewed-by: David Hunt
Acked-by: David Hunt
---
..
The pathnames in the license directory README are incorrect.
The current repository puts license text in license/ not licenses/.
Also, MIT license is used already in a couple of places so
add the necessary entry in the README.
Signed-off-by: Stephen Hemminger
---
license/README | 12 ---
On Wed, Oct 5, 2022 at 5:36 PM Maxime Coquelin
wrote:
> On 10/5/22 17:11, Maxime Coquelin wrote:
> > This patch fixes a compilation issue met with GCC 12 on
> > LoongArch64:
> >
> > In function ‘mbuf_to_desc’,
> > inlined from ‘vhost_enqueue_async_packed’ at
> > ../../../dpdk/lib/vhost/virti
On Wed, Oct 05, 2022 at 09:11:26AM -0700, Tyler Retzlaff wrote:
> hi David,
>
>
> >
> > Newly added code can go to eal_common_thread.c rather than introduce a
> > new common/rte_thread.c file (or is there a rationale for this?).
>
> i will make this change in the next revision. if anyone does o
On 9/22/2022 2:03 PM, Niklas Söderlund wrote:
Hi all,
This small series aims to reduce code duplication by using a single
shared struct eth_dev_ops for NFDk and NFD3.
Patch 1/2 is a small bug fix that suck in when adding support for
NFP3800 where the error code is not correctly propagated.
Pat
On 10/5/2022 12:34 PM, Ferruh Yigit wrote:
On 9/26/2022 7:59 AM, Chaoyong He wrote:
This is the first patch series to add the support of rte_flow offload for
nfp PMD, includes:
Add the support of flower firmware application
Add the support of representor port
Add the flower service infrastructur
On Wed, Oct 5, 2022 at 5:24 PM Kevin Traynor wrote:
>
> and need to be included for the build
> since they were removed from .
>
> ../examples/l2fwd-cat/cat.c: In function ‘parse_set’:
> ../examples/l2fwd-cat/cat.c:66:16:
> warning: implicit declaration of function ‘isblank’
> [-Wimplicit-functi
add rte thread lifetime and attributes api. with these api additions
there is now sufficient platform abstracted thread api to remove the
use of pthread in the unit tests.
v5:
* include errno.h in rte_thread.c since errno.h is no longer included
in rte_common.h
* move rte_thread_attr symbo
Add rte_thread_equal() that tests if two rte_thread_id are equal.
Signed-off-by: Narcisa Vasile
Signed-off-by: Tyler Retzlaff
Acked-by: Chengwen Feng
---
lib/eal/unix/rte_thread.c| 6 ++
lib/eal/version.map | 1 +
lib/eal/windows/rte_thread.c | 6 ++
3 files changed, 13 in
Implement thread attributes for:
* thread affinity
* thread priority
Implement functions for managing thread attributes.
Priority is represented through an enum that allows for two levels:
* RTE_THREAD_PRIORITY_NORMAL
* RTE_THREAD_PRIORITY_REALTIME_CRITICAL
Affinity is desc
The *rte_thread_create()* function can optionally receive an
rte_thread_attr_t object that will cause the thread to be created with
the affinity and priority described by the attributes object. If
no rte_thread_attr_t is passed (parameter is NULL), the default
affinity and priority are used.
On Wi
Test basic functionality and demonstrate use of following thread
lifetime api.
* rte_thread_create
* rte_thread_detach
* rte_thread_join
Signed-off-by: Narcisa Vasile
Signed-off-by: Tyler Retzlaff
---
app/test/test_threads.c | 54 +++--
1
Now that rte_thread provides thread lifetime functions stop using
pthread in unit tests.
Signed-off-by: Tyler Retzlaff
---
app/test/test_threads.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/app/test/test_threads.c b/app/test/test_threads.c
index 3c22cec..e0f18e4 1
Test basic functionality and demonstrate use of following thread
attributes api. Additionally, test attributes are processed when
supplied to rte_thread_create().
* rte_thread_attr_init
* rte_thread_attr_set_affinity
* rte_thread_attr_get_affinity
* rte_thread_attr_set_priority
Si
In rte_sched_subport_config() API, subport_profile_id is not set correctly.
Fixes: ac6fcb841b0f ("sched: update subport rate dynamically")
Cc: cristian.dumitre...@intel.com
Signed-off-by: Megha Ajmera
---
lib/sched/rte_sched.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/lib/sched/rte_s
On Mon, 13 Jun 2022 14:48:45 +0500
Sarosh Arif wrote:
> Thank you for help, I'll do it this way.
>
> On Sat, Jun 11, 2022 at 9:25 PM Mattias Rönnblom
> wrote:
> >
> > On 2022-06-10 08:04, Sarosh Arif wrote:
> > > On Thu, Jun 9, 2022 at 8:26 PM Stephen Hemminger
> > > wrote:
> > >>
> > >>
Removed ununsed subport field from profile.cfg
Correctly using subport profile id in subport config load.
Fixes: 802d214dc880 ("examples/qos_sched: update subport rate dynamically")
Cc: cristian.dumitre...@intel.com
Signed-off-by: Megha Ajmera
---
examples/qos_sched/cfg_file.c | 2 +-
examples
Removed unused subport field from profile.cfg
Correctly using subport profile id in subport config load.
Fixes: 802d214dc880 ("examples/qos_sched: update subport rate dynamically")
Cc: cristian.dumitre...@intel.com
Signed-off-by: Megha Ajmera
---
examples/qos_sched/cfg_file.c | 2 +-
examples/
Hello,
The service_autotest unit test has been failing randomly.
This is not something new.
We have been fixing this unit test and the service code, here and there.
For some time we were "fine": the failures were rare.
But recenly (for the last two weeks at least), it started failing more
frequen
> -Original Message-
> From: Ajmera, Megha
> Sent: Wednesday, October 5, 2022 6:23 PM
> To: dev@dpdk.org; Singh, Jasvinder ;
> Dumitrescu, Cristian
> Cc: sta...@dpdk.org
> Subject: [PATCH v2] sched: Fix subport profile id not set correctly.
>
> In rte_sched_subport_config() API, subpo
On Tue, Oct 4, 2022 at 1:18 PM Thomas Monjalon wrote:
>
> A pointer is passed to a macro and it seems mistakenly referenced.
> This issue is seen only when compiling with GCC 12 for 32-bit:
>
> drivers/net/qede/base/ecore_init_fw_funcs.c:1418:25:
> error: array subscript 1 is outside array
On Tue, Oct 4, 2022 at 10:00 AM David Marchand
wrote:
>
> As reported by Coverity, this check is pointless since dev is already
> dereferenced earlier. Besides, dev is passed by the rawdev layer and
> can't be NULL.
>
> Note: the issue was probably present before the incriminated commit.
> It is u
On Tue, Oct 4, 2022 at 2:58 PM Ferruh Yigit wrote:
>
> On 10/4/2022 9:01 AM, David Marchand wrote:
> > RTE_TEST_[RT]X_DESC_DEFAULT and RTE_TEST_[RT]X_DESC_MAX macros have been
> > copied in a lot of app/ and examples/ code.
> > Those macros are local to each program.
> >
> > They are not related t
1 - 100 of 143 matches
Mail list logo
