hi David, On Wed, Sep 21, 2022 at 10:15:36AM +0200, David Marchand wrote: > On Mon, Jun 27, 2022 at 6:56 PM Tyler Retzlaff > <roret...@linux.microsoft.com> wrote: > > > > add rte thread lifetime and attributes api. with these api additions > > there is now sufficient platform abstracted thread api to remove the > > use of pthread in the unit tests. > > > > v4: > > * update version.map to show api from series added in 22.11 instead > > of 22.07. > > Patch 1 still adds symbols in 22.07 section of the experimental block.
this looks like a goofup on my part, i will fix in the next revision. > > Compilation is broken when stopping at patch 4. this was because commit 72b452c5f2599f970f47fd17d3e8e5d60bfebe7a removed #include of <errno.h> from rte_common.h i will fix this in the next revision. > > Newly added code can go to eal_common_thread.c rather than introduce a > new common/rte_thread.c file (or is there a rationale for this?). i will make this change in the next revision. if anyone does object i hope they will do so quickly. > > There are guards for the new structs against RTE_HAS_CPUSET being defined. > Can you elaborate why those guards are needed? eal uses this guard in a couple of places so the best explanation i can provide is an existing pattern was being followed. that being said it's clear that this code won't work without RTE_HAS_CPUSET. i will remove the guard and test if the build breaks for the platforms i have toolchains available. if it builds cleanly i'll remove the guard in the next revision. > > Commitlogs / comments sentences must start with a capital letter. i will fix in next revision, but ew caps. > > Can you prepare a new revision for -rc1? assuming the above actions to address feedback are acceptable the new revision should be up today (PST). > > Thanks. thank you! ty
