Re: [PATCH 0/2] upgrade the log system of nfp PMD

2022-09-21 Thread Niklas Söderlund
On 2022-09-20 19:03:42 +0100, Ferruh Yigit wrote: > On 8/26/2022 7:03 AM, Chaoyong He wrote: > > This patch series do some upgrade of the log system of nfp PMD: > > Use DPDK debug macro to control the nfp Rx/Tx log. > > Add the support of nfp cpp log macro. > > > > Long Wu (2): > >net/nfp: add

Re: [PATCH v3 01/13] baseband/acc100: refactor to segregate common code

2022-09-21 Thread Maxime Coquelin
On 9/16/22 03:34, Nic Chautru wrote: Refactoring all shareable common code to be used by future PMD (including ACC200 in this patchset as well as taking into account following PMDs in roadmap) by gathering such structures or inline methods. Cleaning up the enum files to remove un-used registe

RE: [PATCH v2] net/pcap: fix timeout of stopping device

2022-09-21 Thread Zhou, YidingX
> -Original Message- > From: Stephen Hemminger > Sent: Tuesday, September 6, 2022 10:58 PM > To: Zhou, YidingX > Cc: dev@dpdk.org; Zhang, Qi Z ; Burakov, Anatoly > ; He, Xingguang ; > sta...@dpdk.org > Subject: Re: [PATCH v2] net/pcap: fix timeout of stopping device > > On Tue, 6 Sep

Malicious Driver Detection event

2022-09-21 Thread Srinivas Assampally
Hi, I'm facing the below error while running our DPDK-based application. i40e_dev_alarm_handler(): ICR0: malicious programming detected i40e_handle_mdd_event(): Malicious Driver Detection event 0x02 on TX queue 8 PF number 0x02 VF number 0x00 device :3b:00.2 I'm having 20 Rx queues and 8 Tx

Re: [PATCH v3 02/13] baseband/acc200: introduce PMD for ACC200

2022-09-21 Thread Maxime Coquelin
On 9/16/22 03:34, Nic Chautru wrote: From: Nicolas Chautru This patch introduce stubs for device driver for the ACC200 integrated VRAN accelerator on SPR-EEC Signed-off-by: Nicolas Chautru --- MAINTAINERS | 3 + doc/guides/bbdevs/acc200.rst | 2

Re: [PATCH] net/nfp: improve readability NFP HWINFO header

2022-09-21 Thread Niklas Söderlund
Hello Ferruh, On 2022-09-20 19:01:47 +0100, Ferruh Yigit wrote: > Instead of changing the log content and API with same patch, it is > better to have them separate. I agree. > > I prefer to convert them to proper log API first, and later fix the content > of the log (to not update a line with

RE: FW: [PATCH v1] buildtools: ensure the NUMA nodes are counted correct

2022-09-21 Thread Nole Zhang
> -Original Message- > From: Thomas Monjalon > Sent: 2022年9月20日 21:23 > To: Niklas Soderlund > Cc: Nole Zhang ; dev@dpdk.org; Chaoyong He > ; oss-drivers > Subject: Re: FW: [PATCH v1] buildtools: ensure the NUMA nodes are counted > correct > > Hi, > > 20/09/2022 12:11, Niklas Soderlu

Re: [PATCH v4] usertools: rewrite pmdinfo

2022-09-21 Thread Thomas Monjalon
20/09/2022 19:50, Ferruh Yigit: > Thomas, John, > > Should we have documentation for usertools, since they are user facing, > what do you think? We have doc/guides/tools/ > Can it be possible to find resource for it?

Re: [PATCH v9 07/12] net/nfp: add flower ctrl VNIC related logics

2022-09-21 Thread Thomas Monjalon
21/09/2022 04:02, Chaoyong He: > > On 9/15/2022 11:44 AM, Chaoyong He wrote: > > > Adds the setup/start logic for the ctrl vNIC. This vNIC is used by the > > > PMD and flower firmware application as a communication channel > > between > > > driver and firmware. In the case of OVS it is also used to

RE: [PATCH v1] ethdev: add direction info when creating the transfer table

2022-09-21 Thread Ori Kam
Hi Ivan, PSB my comments. In any case, I'm afraid we are in a deadlock. I understand your viewpoint, I don't think it is the correct one for the feature suggested here. For all the reasons I listed. So from my viewpoint, the patch is Acked. If you wish as I suggested before, we can have a meetin

Re: [PATCH v9 05/12] net/nfp: add flower PF setup logic

2022-09-21 Thread Thomas Monjalon
I don't understand your logic fully, but I understand you need special code to make your hardware work with OvS, meaning: - OvS must have a special handling for your HW - other applications won't work Tell me I misunderstand, but I feel we should not accept this patch, there is prob

RE: [PATCH v9 07/12] net/nfp: add flower ctrl VNIC related logics

2022-09-21 Thread Chaoyong He
> 21/09/2022 04:02, Chaoyong He: > > > On 9/15/2022 11:44 AM, Chaoyong He wrote: > > > > Adds the setup/start logic for the ctrl vNIC. This vNIC is used by > > > > the PMD and flower firmware application as a communication channel > > > between > > > > driver and firmware. In the case of OVS it is

RE: [PATCH v9 05/12] net/nfp: add flower PF setup logic

2022-09-21 Thread Chaoyong He
> Subject: Re: [PATCH v9 05/12] net/nfp: add flower PF setup logic > > I don't understand your logic fully, > but I understand you need special code to make your hardware work with > OvS, > meaning: > - OvS must have a special handling for your HW > - other applications won't work > Te

Re: [PATCH v4] usertools: rewrite pmdinfo

2022-09-21 Thread Ferruh Yigit
On 9/20/2022 8:15 PM, Robin Jarry wrote: Ferruh Yigit, Sep 20, 2022 at 19:48: +* The ``dpdk-pmdinfo.py`` script was rewritten to produce valid JSON only. + PCI-IDs parsing has been removed. + To get a similar output to the (now removed) ``-r/--raw`` flag, you may use the following command::

RE: [EXT] Re: [PATCH] event/cnxk: fix stale data in workslots

2022-09-21 Thread Pavan Nikhilesh Bhagavatula
> -Original Message- > From: Jerin Jacob > Sent: Tuesday, September 13, 2022 8:06 PM > To: Pavan Nikhilesh Bhagavatula > Cc: Jerin Jacob Kollanukkaran ; Shijith Thotton > ; dev@dpdk.org; sta...@dpdk.org > Subject: [EXT] Re: [PATCH] event/cnxk: fix stale data in workslots > > External E

Re: [PATCH v4] usertools: rewrite pmdinfo

2022-09-21 Thread Ferruh Yigit
On 9/21/2022 8:27 AM, Thomas Monjalon wrote: 20/09/2022 19:50, Ferruh Yigit: Thomas, John, Should we have documentation for usertools, since they are user facing, what do you think? We have doc/guides/tools/ Indeed, and there is even 'doc/guides/tools/pmdinfo.rst', so @Robin that documenta

Re: FW: [PATCH v1] buildtools: ensure the NUMA nodes are counted correct

2022-09-21 Thread Thomas Monjalon
Please send a v2 with the proper explanations. 21/09/2022 09:19, Nole Zhang: > > > -Original Message- > > From: Thomas Monjalon > > Sent: 2022年9月20日 21:23 > > To: Niklas Soderlund > > Cc: Nole Zhang ; dev@dpdk.org; Chaoyong He > > ; oss-drivers > > Subject: Re: FW: [PATCH v1] buildtoo

Re: [PATCH] net/nfp: improve readability NFP HWINFO header

2022-09-21 Thread Ferruh Yigit
On 9/21/2022 8:19 AM, Niklas Söderlund wrote: Hello Ferruh, On 2022-09-20 19:01:47 +0100, Ferruh Yigit wrote: Instead of changing the log content and API with same patch, it is better to have them separate. I agree. I prefer to convert them to proper log API first, and later fix the conten

Re: [PATCH v4 0/6] add thread lifetime and attributes API

2022-09-21 Thread David Marchand
On Mon, Jun 27, 2022 at 6:56 PM Tyler Retzlaff wrote: > > add rte thread lifetime and attributes api. with these api additions > there is now sufficient platform abstracted thread api to remove the > use of pthread in the unit tests. > > v4: > * update version.map to show api from series added i

Re: [PATCH] net/nfp: improve readability NFP HWINFO header

2022-09-21 Thread Ferruh Yigit
On 8/26/2022 6:39 AM, Chaoyong He wrote: From: James Hershaw Prepend `0x` to the NFP HWINFO header value that is printed to improve the readability of the printed statement. Signed-off-by: James Hershaw Reviewed-by: Chaoyong He Reviewed-by: Niklas Söderlund Fixes: c7e9729da6b5 ("net/n

Re: [PATCH v1] ethdev: add direction info when creating the transfer table

2022-09-21 Thread Andrew Rybchenko
Hi Ori, On 9/21/22 10:34, Ori Kam wrote: Hi Ivan, PSB my comments. In any case, I'm afraid we are in a deadlock. I understand your viewpoint, I don't think it is the correct one for the feature suggested here. For all the reasons I listed. So from my viewpoint, the patch is Acked. If you wish

EAL threads

2022-09-21 Thread Mattias Rönnblom
I have some lcore-related questions: The documentation make use of the term "non-EAL thread". Is a non-EAL thread the same thing as a non-lcore thread? I.e., are there EAL threads that are not lcore threads? I also have a question related to rte_register_thread(): shouldn't the documentation

Re: DPDK with i225/226 on elkhartlake

2022-09-21 Thread Bruce Richardson
On Wed, Sep 21, 2022 at 03:23:09AM +, SamChen 陳嘉良 wrote: >Hi, >We bind the uio_pci_generic driver and use the command of the attached >image to execute DPDK. However, we encountered the problem of device >cannot be used on i225V/i226V in elkhartlake platform. Currently, the >

RE: [PATCH v1] ethdev: add direction info when creating the transfer table

2022-09-21 Thread Ivan Malov
Hi Ori, On Wed, 21 Sep 2022, Ori Kam wrote: Hi Ivan, PSB my comments. In any case, I'm afraid we are in a deadlock. Hope we're not in fact. I understand your viewpoint, I don't think it is the correct one for the feature suggested here. For all the reasons I listed. Ori, your two most r

Re: EAL threads

2022-09-21 Thread Bruce Richardson
On Wed, Sep 21, 2022 at 10:39:15AM +0200, Mattias Rönnblom wrote: > I have some lcore-related questions: > > The documentation make use of the term "non-EAL thread". Is a non-EAL thread > the same thing as a non-lcore thread? I.e., are there EAL threads that are > not lcore threads? Yes, there ar

Re: [PATCH v4 4/4] eal: remove unneeded includes from a public header

2022-09-21 Thread David Marchand
On Sat, Aug 27, 2022 at 1:33 PM Dmitry Kozlyuk wrote: > diff --git a/lib/efd/rte_efd.c b/lib/efd/rte_efd.c > index bbc6fc585d..846c906aea 100644 > --- a/lib/efd/rte_efd.c > +++ b/lib/efd/rte_efd.c > @@ -1,9 +1,11 @@ > /* SPDX-License-Identifier: BSD-3-Clause > * Copyright(c) 2016-2017 Intel Cor

Re: [PATCH v1] ethdev: add direction info when creating the transfer table

2022-09-21 Thread Thomas Monjalon
21/09/2022 11:04, Ivan Malov: > Now it's clear to me that your intention is to match on exact ports, > as usual, but this time with a hint for the flow table. Got it. > > In your response, you say that matching on ALL vports is not what > the use case needs. OK, I understood. But please note that

Re: [PATCH] vhost: use try_lock in rte_vhost_vring_call

2022-09-21 Thread Maxime Coquelin
On 9/20/22 10:43, Liu, Changpeng wrote: -Original Message- From: Maxime Coquelin Sent: Tuesday, September 20, 2022 4:13 PM To: Liu, Changpeng ; dev@dpdk.org Cc: Xia, Chenbo Subject: Re: [PATCH] vhost: use try_lock in rte_vhost_vring_call On 9/20/22 09:45, Liu, Changpeng wrote:

RE: [PATCH v6 0/2] Add l2reflect measurement application

2022-09-21 Thread Morten Brørup
> From: Felix Moessbauer [mailto:felix.moessba...@siemens.com] > Sent: Friday, 2 September 2022 10.46 > > Dear DPDK community, > > this patch provides the l2reflect measurement tool > which will be discussed in our 2022 DPDK Userspace Summit talk: > "Using DPDK OVS for deterministic low latency c

Re: [PATCH v2 0/5] mbuf dynamic field expansion

2022-09-21 Thread David Marchand
On Wed, Sep 7, 2022 at 3:44 PM Shijith Thotton wrote: > > This is a continuation of the discussions[1] to add mbuf physical address > field to dynamic field. > Previous version was to add PA field to dynamic field area based on the EAL > IOVA mode option. It was > deemed unsafe as some component

RE: [PATCH] vhost: use try_lock in rte_vhost_vring_call

2022-09-21 Thread Liu, Changpeng
> -Original Message- > From: Maxime Coquelin > Sent: Wednesday, September 21, 2022 5:41 PM > To: Liu, Changpeng ; dev@dpdk.org > Cc: Xia, Chenbo > Subject: Re: [PATCH] vhost: use try_lock in rte_vhost_vring_call > > > > On 9/20/22 10:43, Liu, Changpeng wrote: > > > > > >> -Origin

Re: [PATCH v4] usertools: rewrite pmdinfo

2022-09-21 Thread Ferruh Yigit
On 9/21/2022 8:58 AM, Ferruh Yigit wrote: On 9/20/2022 8:15 PM, Robin Jarry wrote: Ferruh Yigit, Sep 20, 2022 at 19:48: +* The ``dpdk-pmdinfo.py`` script was rewritten to produce valid JSON only. +  PCI-IDs parsing has been removed. +  To get a similar output to the (now removed) ``-r/--raw`

Re: [PATCH v1] ethdev: add direction info when creating the transfer table

2022-09-21 Thread Andrew Rybchenko
On 9/21/22 12:40, Thomas Monjalon wrote: 21/09/2022 11:04, Ivan Malov: Now it's clear to me that your intention is to match on exact ports, as usual, but this time with a hint for the flow table. Got it. In your response, you say that matching on ALL vports is not what the use case needs. OK, I

[PATCH 0/2] ethdev: add GTP PSC QFI field

2022-09-21 Thread Dariusz Sosnowski
This patch series adds support for modifying GTP PSC QFI field using MODIFY_FIELD action. Dariusz Sosnowski (2): ethdev: add GTP PSC QFI field app/testpmd: add GTP PSC QFI field support app/test-pmd/cmdline_flow.c | 2 +- lib/ethdev/rte_flow.h | 1 + 2 files changed, 2 insertions(+),

[PATCH 1/2] ethdev: add GTP PSC QFI field

2022-09-21 Thread Dariusz Sosnowski
This patch introduces a GTP PSC QFI field to MODIFY_FIELD flow action. Signed-off-by: Dariusz Sosnowski --- lib/ethdev/rte_flow.h | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h index a79f1e7ef0..e64831f8f1 100644 --- a/lib/ethdev/rte_flow.h +++

[PATCH 2/2] app/testpmd: add GTP PSC QFI field support

2022-09-21 Thread Dariusz Sosnowski
This patch adds support for specifying GTP PSC QFI field as a source or destination of MODIFY_FIELD flow action in testpmd. An example for copying GTP PSC QFI field using MODIFY_FIELD action: modify_field op set dst_type meta src_type gtp_psc_qfi

RE: EAL threads

2022-09-21 Thread Morten Brørup
> From: Bruce Richardson [mailto:bruce.richard...@intel.com] > Sent: Wednesday, 21 September 2022 11.06 > > On Wed, Sep 21, 2022 at 10:39:15AM +0200, Mattias Rönnblom wrote: > > I have some lcore-related questions: > > > > The documentation make use of the term "non-EAL thread". Is a non-EAL > thr

RE: [PATCH v4 1/9] dts: add project tools config

2022-09-21 Thread Juraj Linkeš
> -Original Message- > From: Thomas Monjalon > Sent: Wednesday, September 14, 2022 4:29 PM > To: Juraj Linkeš ; Bruce Richardson > > Cc: Honnappa Nagarahalli ; > david.march...@redhat.com; ronan.rand...@intel.com; ohily...@iol.unh.edu; > lijuan...@intel.com; dev@dpdk.org > Subject: Re:

Re: [PATCH v2 1/6] app/procinfo: add version dump

2022-09-21 Thread Dongdong Liu
Hi Stephen Many thanks for your review. On 2022/9/20 23:21, Stephen Hemminger wrote: On Tue, 20 Sep 2022 18:51:42 +0800 Dongdong Liu wrote: From: "Min Hu (Connor)" This patch add support for dump dpdk version and ethdev firmware version. The command is like: dpdk-proc-info -a :xx:xx.x

Re: [PATCH v2 2/6] app/procinfo: add RSS RETA dump

2022-09-21 Thread Dongdong Liu
On 2022/9/20 23:24, Stephen Hemminger wrote: On Tue, 20 Sep 2022 18:51:43 +0800 Dongdong Liu wrote: + ret = rte_eth_dev_info_get(id, &dev_info); + if (ret < 0) { + printf("Error getting device info, ret = %d\n", ret); Proc-info should be s

Re: [PATCH v2 3/6] app/procinfo: add module info dump

2022-09-21 Thread Dongdong Liu
On 2022/9/20 23:22, Stephen Hemminger wrote: On Tue, 20 Sep 2022 18:51:44 +0800 Dongdong Liu wrote: + + RTE_ETH_FOREACH_DEV(i) { + /* Skip if port is not in mask */ + if ((enabled_port_mask & (1ul << i)) == 0) + continue; + +

RE: [PATCH v1 0/3] Fix meter hierarchy issue for represented port

2022-09-21 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Shun Hao > Sent: Saturday, September 17, 2022 9:02 AM > To: Slava Ovsiienko ; Matan Azrad > ; Ori Kam > Cc: dev@dpdk.org; Raslan Darawsheh > Subject: [PATCH v1 0/3] Fix meter hierarchy issue for represented port > > When the represented port item was i

Re: [PATCH v4 4/4] eal: remove unneeded includes from a public header

2022-09-21 Thread David Marchand
On Sat, Aug 27, 2022 at 1:33 PM Dmitry Kozlyuk wrote: > > Do not include , , and from , > because they are not used by this file. > Include the needed headers directly from the files that need them. > > Signed-off-by: Dmitry Kozlyuk > --- [snip] > examples/vdpa/main.c

Re: [PATCH 9/9] net/ngbe: support to set link down/up

2022-09-21 Thread Ferruh Yigit
On 9/2/2022 4:00 AM, Jiawen Wu wrote: Add support to set device link down/up. Signed-off-by: Jiawen Wu --- doc/guides/rel_notes/release_22_11.rst | 4 drivers/net/ngbe/base/ngbe_phy.c | 1 + drivers/net/ngbe/base/ngbe_phy_rtl.c | 13 drivers/net/ngbe/base/ngbe_ph

Re: [PATCH V3 00/21] net/softnic: replace the legacy pipeline with SWX pipeline

2022-09-21 Thread Thomas Monjalon
01/09/2022 16:20, Cristian Dumitrescu: > The legacy pipeline API is soon going to be marked for deprecation, > hence the Soft NIC driver is updated to support the new SWX pipeline > type. > > The SWX pipeline has better encapsulation than the legacy pipeline, > mainly due to P4 language alignment,

Re: [PATCH 0/9] Wangxun fixes and supports

2022-09-21 Thread Ferruh Yigit
On 9/2/2022 4:00 AM, Jiawen Wu wrote: Fix some bugs, remove unused logic, support new features. Jiawen Wu (9): net/txgbe: fix IPv6 rule in flow director net/txgbe: fix OEM customized LED net/txgbe: remove semaphore between SW/FW net/txgbe: rename some extended statistic net/ngbe:

[PATCH 0/8] Trace subsystem fixes

2022-09-21 Thread David Marchand
Hello, This series addresses a number of issues and limitations I have identified over time in the trace subsystem. The main issue was with dynamically enabling trace points which was not working if no trace point had been enabled at rte_eal_init() time. This is 22.11 material from my pov. We m

[PATCH 1/8] trace: fix mode for new trace point

2022-09-21 Thread David Marchand
If an application registers trace points later than rte_eal_init(), changes in the trace point mode were not applied. Fixes: 84c4fae4628f ("trace: implement operation APIs") Cc: sta...@dpdk.org Signed-off-by: David Marchand --- lib/eal/common/eal_common_trace.c | 1 + 1 file changed, 1 insertio

[PATCH 2/8] trace: fix mode change

2022-09-21 Thread David Marchand
The API does not state that changing mode should be refused if no trace point is enabled. Remove this limitation. Fixes: 84c4fae4628f ("trace: implement operation APIs") Cc: sta...@dpdk.org Signed-off-by: David Marchand --- app/test/test_trace.c | 3 --- lib/eal/common/eal_common_tr

[PATCH 3/8] trace: fix leak with regexp

2022-09-21 Thread David Marchand
The precompiled buffer initialised in regcomp must be freed before leaving rte_trace_regexp. Fixes: 84c4fae4628f ("trace: implement operation APIs") Cc: sta...@dpdk.org Signed-off-by: David Marchand --- lib/eal/common/eal_common_trace.c | 19 +++ 1 file changed, 11 insertions(+)

[PATCH 4/8] trace: fix dynamically enabling trace points

2022-09-21 Thread David Marchand
Enabling trace points at runtime was not working if no trace point had been enabled first at rte_eal_init() time. The reason was that trace.args reflected the arguments passed to --trace= EAL option. To fix this: - the trace subsystem initialisation is updated: trace directory creation is deferr

[PATCH 5/8] trace: fix race in debug dump

2022-09-21 Thread David Marchand
trace->nb_trace_mem_list access must be under trace->lock to avoid races with threads allocating/freeing their trace buffers. Fixes: f6b2d65dcd5d ("trace: implement debug dump") Cc: sta...@dpdk.org Signed-off-by: David Marchand --- lib/eal/common/eal_common_trace.c | 6 +++--- 1 file changed, 3

[PATCH 6/8] trace: fix metadata dump

2022-09-21 Thread David Marchand
The API does not describe that metadata dump is conditioned to enabling any trace points. While at it, merge dump unit tests into the generic trace_autotest to enhance coverage. Fixes: f6b2d65dcd5d ("trace: implement debug dump") Cc: sta...@dpdk.org Signed-off-by: David Marchand --- app/test/t

[PATCH 7/8] trace: remove limitation on trace point name

2022-09-21 Thread David Marchand
The name of a trace point is provided as a constant string via the RTE_TRACE_POINT_REGISTER macro. We can rely on the constant string in the binary and simply point at it. There is then no need for a (fixed size) copy. Signed-off-by: David Marchand --- lib/eal/common/eal_common_trace.c | 1

[PATCH 8/8] trace: remove limitation on directory

2022-09-21 Thread David Marchand
Remove arbitrary limit on 12 characters of the file prefix used for the directory where to store the traces. Simplify the code by relying on dynamic allocations. Signed-off-by: David Marchand --- lib/eal/common/eal_common_trace_utils.c | 68 + lib/eal/common/eal_trace.h

RE: [PATCH v1] net/mlx5: fix meter profile delete fail

2022-09-21 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Shun Hao > Sent: Sunday, September 18, 2022 3:58 AM > To: Slava Ovsiienko ; Matan Azrad > ; Ori Kam ; Suanming Mou > > Cc: dev@dpdk.org; Raslan Darawsheh ; > sta...@dpdk.org; Matan Azrad > Subject: [PATCH v1] net/mlx5: fix meter profile delete fail > >

RE: [PATCH v6 0/2] Add l2reflect measurement application

2022-09-21 Thread Morten Brørup
> From: Henning Schild [mailto:henning.sch...@siemens.com] > Sent: Wednesday, 21 September 2022 13.27 > > Am Wed, 21 Sep 2022 11:43:13 +0200 > schrieb Morten Brørup : > > > > From: Felix Moessbauer [mailto:felix.moessba...@siemens.com] > > > Sent: Friday, 2 September 2022 10.46 > > > > > > Dear D

Re: [PATCH v6 0/2] Add l2reflect measurement application

2022-09-21 Thread Henning Schild
Am Wed, 21 Sep 2022 11:43:13 +0200 schrieb Morten Brørup : > > From: Felix Moessbauer [mailto:felix.moessba...@siemens.com] > > Sent: Friday, 2 September 2022 10.46 > > > > Dear DPDK community, > > > > this patch provides the l2reflect measurement tool > > which will be discussed in our 2022 DPD

RE: [PATCH v1] ethdev: add direction info when creating the transfer table

2022-09-21 Thread Ori Kam
Hi All, To avoid multi threads, I will only answer this thread since I assume everyone is clear about the issue. > -Original Message- > From: Andrew Rybchenko > > On 9/21/22 12:40, Thomas Monjalon wrote: > > 21/09/2022 11:04, Ivan Malov: > >> Now it's clear to me that your intention is t

RE: [PATCH 1/2] ethdev: add GTP PSC QFI field

2022-09-21 Thread Ori Kam
Hi Dariusz, Please merge the testpmd and this commit. And you can add my ack. > -Original Message- > From: Dariusz Sosnowski > Sent: Wednesday, 21 September 2022 13:19 > To: Ori Kam ; NBU-Contact-Thomas Monjalon > (EXTERNAL) ; Ferruh Yigit > ; Andrew Rybchenko > > Cc: dev@dpdk.org > Subj

Re: [PATCH 2/2] app/testpmd: add GTP PSC QFI field support

2022-09-21 Thread Singh, Aman Deep
On 9/21/2022 3:48 PM, Dariusz Sosnowski wrote: This patch adds support for specifying GTP PSC QFI field as a source or destination of MODIFY_FIELD flow action in testpmd. An example for copying GTP PSC QFI field using MODIFY_FIELD action: modify_field op set dst_type m

[PATCH v3 0/5] add remaining SGL support to AESNI_MB

2022-09-21 Thread Ciara Power
Currently, the intel-ipsec-mb library only supports SGL for GCM and ChaCha20-Poly1305 algorithms through the JOB API. To add SGL support for other algorithms, a workaround approach is added in the AESNI_MB PMD. SGL feature flags can now be added to the PMD. This patchset also includes a fix for S

[PATCH v3 1/5] test/crypto: fix wireless auth digest segment

2022-09-21 Thread Ciara Power
The segment size for some tests was too small to hold the auth digest. This caused issues when using op->sym->auth.digest.data for comparisons in AESNI_MB PMD after a subsequent patch enables SGL. For example, if segment size is 2, and digest size is 4, then 4 bytes are read from op->sym->auth.dig

[PATCH v3 2/5] crypto/ipsec_mb: fix session creation for sessionless

2022-09-21 Thread Ciara Power
Currently, for a sessionless op, the session taken from the mempool contains some values previously set by a testcase that does use a session. This is due to the session object not being reset before going back into the mempool. This caused issues when multiple sessionless testcases ran, as the pr

[PATCH v3 3/5] crypto/ipsec_mb: add remaining SGL support

2022-09-21 Thread Ciara Power
The intel-ipsec-mb library supports SGL for GCM and ChaChaPoly algorithms using the JOB API. This support was added to AESNI_MB PMD previously, but the SGL feature flags could not be added due to no SGL support for other algorithms. This patch adds a workaround SGL approach for other algorithms us

[PATCH v3 4/5] test/crypto: add OOP snow3g SGL tests

2022-09-21 Thread Ciara Power
More tests are added to test variations of OOP SGL for snow3g. This includes LB_IN_SGL_OUT and SGL_IN_LB_OUT. Signed-off-by: Ciara Power --- app/test/test_cryptodev.c | 48 +++ 1 file changed, 39 insertions(+), 9 deletions(-) diff --git a/app/test/test_crypto

[PATCH v3 5/5] test/crypto: add remaining blockcipher SGL tests

2022-09-21 Thread Ciara Power
The current blockcipher test function only has support for two types of SGL test, INPLACE or OOP_SGL_IN_LB_OUT. These types are hardcoded into the function, with the number of segments always set to 3. To ensure all SGL types are tested, blockcipher test vectors now have fields to specify SGL type

RE: [PATCH v1] ethdev: add direction info when creating the transfer table

2022-09-21 Thread Morten Brørup
> From: Ori Kam [mailto:or...@nvidia.com] > Sent: Wednesday, 21 September 2022 14.41 > > > From: Andrew Rybchenko > > > > On 9/21/22 12:40, Thomas Monjalon wrote: > > > 21/09/2022 11:04, Ivan Malov: > > >> Now it's clear to me that your intention is to match on exact > ports, > > >> as usual, but

RE: [PATCH v4 1/7] ethdev: add meter color flow matching item

2022-09-21 Thread Ori Kam
Hi Alexander, > -Original Message- > From: Alexander Kozyrev > Sent: Wednesday, 21 September 2022 5:11 > Subject: [PATCH v4 1/7] ethdev: add meter color flow matching item > > Provide an ability to use a Color Marker set by a Meter > as a matching item in Flow API. The Color Marker refle

RE: [PATCH v2 2/5] crypto/ipsec_mb: fix sessionless cleanup

2022-09-21 Thread Power, Ciara
Hi Pablo, > -Original Message- > From: De Lara Guarch, Pablo > Sent: Thursday 15 September 2022 13:39 > To: Power, Ciara ; Zhang, Roy Fan > > Cc: dev@dpdk.org; Ji, Kai ; Mrozowicz, SlawomirX > > Subject: RE: [PATCH v2 2/5] crypto/ipsec_mb: fix sessionless cleanup > > Hi Ciara, > > > -

Re: [PATCH] lib: do not call memcpy with sz zero and null pointer

2022-09-21 Thread Thomas Monjalon
07/09/2022 17:05, Henning Schild: > There is no point in such a call and UBSan complains about a call to > memcpy with a null pointer as second arg. > > When building with -Db_sanitize=undefined, Clang gives the following > warning > ../lib/bpf/bpf_load.c:37:20: runtime error: null pointer passed

Re: [dpdk-test-report] |FAILURE| pw(116546) sid(24747) job(PER_PATCH_BUILD4259)[8/8] trace: remove limitation on directory

2022-09-21 Thread David Marchand
On Wed, Sep 21, 2022 at 2:23 PM wrote: > > > Test-Label: Intel-compilation > Test-Status: FAILURE > http://dpdk.org/patch/116546 > > _Compilation issues_ > > Submitter: David Marchand > Date: 2022-09-21 12:03:59 > Reply_mail: <20220921120359.2201131-9-david.march...@redhat.com> > > DPDK git basel

Re: [PATCH v4 0/4] eal: small rte_common.h fixes and cleanup

2022-09-21 Thread David Marchand
On Sat, Aug 27, 2022 at 1:32 PM Dmitry Kozlyuk wrote: > > v4: Fix build on ARM and RISC-V (CI). > > v3: Fix build (CI). > > v2: > * Extend and tidy up the macro unit test (Morten). > * Remove unneeded includes from rte_common.h (Morten, Bruce). > > > Dmitry Kozlyuk (4): > eal: fix pointe

RE: [PATCH v3 1/5] test/crypto: fix wireless auth digest segment

2022-09-21 Thread Zhang, Roy Fan
Hi Ciara, > -Original Message- > From: Power, Ciara > Sent: Wednesday, September 21, 2022 1:51 PM > To: Akhil Goyal ; Zhang, Roy Fan > > Cc: dev@dpdk.org; Ji, Kai ; De Lara Guarch, Pablo > ; Power, Ciara > Subject: [PATCH v3 1/5] test/crypto: fix wireless auth digest segment > > The se

RE: [PATCH v3 2/5] crypto/ipsec_mb: fix session creation for sessionless

2022-09-21 Thread Zhang, Roy Fan
> -Original Message- > From: Power, Ciara > Sent: Wednesday, September 21, 2022 1:51 PM > To: Zhang, Roy Fan ; De Lara Guarch, Pablo > ; Akhil Goyal > Cc: dev@dpdk.org; Ji, Kai ; Power, Ciara > ; Mrozowicz, SlawomirX > > Subject: [PATCH v3 2/5] crypto/ipsec_mb: fix session creation for s

[PATCH] drivers/net: remove alias for virtual devices

2022-09-21 Thread Ferruh Yigit
Virtual devices are probed/matched based on name, and this name is user facing value, since device name is provided by user as eal '--vdev' parameter, like: `dpdk-testpmd --vdev net_null0`. The current name format is 'net_', but previously it was 'eth_', and an alias to legacy naming format was in

Re: [PATCH v2] eal: change alloc_sz calculation which may cause unnecessarily allocation

2022-09-21 Thread David Marchand
On Thu, Jul 28, 2022 at 8:03 PM Dmitry Kozlyuk wrote: > > 2022-07-28 14:41 (UTC+0500), Fidaullah Noonari: > > The amount of memory to allocate from the system for heap expansion > > was calculated in a way that may yield one page more than needed. > > This could hit the allocation limit from the s

[PATCH] maintainers: update email address

2022-09-21 Thread Ferruh Yigit
Updating @xilinx.com domain to @amd.com domain. Signed-off-by: Ferruh Yigit --- MAINTAINERS | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 32ffdd1a61ca..0fc5c8dfe583 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -28,7 +28,7 @@ M: David M

RE: [PATCH v6 0/2] Add l2reflect measurement application

2022-09-21 Thread Morten Brørup
> From: Henning Schild [mailto:henning.sch...@siemens.com] > Sent: Wednesday, 21 September 2022 14.59 > > Am Wed, 21 Sep 2022 14:22:07 +0200 > schrieb Morten Brørup : > > > > From: Henning Schild [mailto:henning.sch...@siemens.com] > > > Sent: Wednesday, 21 September 2022 13.27 > > > > > > Am Wed

[PATCH v3 0/5] mbuf dynamic field expansion

2022-09-21 Thread Shijith Thotton
This is a continuation of the discussions[1] to add mbuf physical address field to dynamic field. Previous version was to add PA field to dynamic field area based on the EAL IOVA mode option. It was deemed unsafe as some components could still use the PA field without checking IOVA mode and ther

[PATCH v3 1/5] build: add meson option to configure IOVA mode as VA

2022-09-21 Thread Shijith Thotton
IOVA mode in DPDK is either PA or VA. The new build option iova_as_va configures the mode to VA at compile time and prevents setting it to PA at runtime. For now, all drivers which are not always enabled are disabled with this option. Supported driver can set the flag pmd_iova_as_va in its build fi

[PATCH v3 2/5] mbuf: add second dynamic field member for VA only build

2022-09-21 Thread Shijith Thotton
mbuf physical address field is not used in builds which only uses VA. It is used to expand the dynamic field area. Signed-off-by: Shijith Thotton --- lib/mbuf/rte_mbuf_core.h | 26 +- lib/mbuf/rte_mbuf_dyn.c | 2 ++ 2 files changed, 19 insertions(+), 9 deletions(-) dif

[PATCH v3 3/5] lib: move mbuf next pointer to first cache line

2022-09-21 Thread Shijith Thotton
Swapped position of mbuf next pointer and second dynamic field (dynfield2) if the build is configured to use IOVA as VA. This is to move the mbuf next pointer to first cache line. kni library is disabled for this change as it depends on the offset value of next pointer. Signed-off-by: Shijith Thot

[PATCH v3 4/5] drivers: mark Marvell cnxk PMDs work with IOVA as VA

2022-09-21 Thread Shijith Thotton
Enabled the flag pmd_iova_as_va in cnxk driver build files as they work with IOVA as VA. Updated cn9k and cn10k soc build configurations to enable the IOVA as VA build by default. Signed-off-by: Shijith Thotton --- config/arm/meson.build | 8 +++- drivers/common/cnxk/meson.bui

[PATCH v3 5/5] drivers: mark software PMDs work with IOVA as VA

2022-09-21 Thread Shijith Thotton
Enabled software PMDs in IOVA as VA build as they work with IOVA as VA. Signed-off-by: Shijith Thotton --- drivers/crypto/armv8/meson.build| 1 + drivers/crypto/ipsec_mb/meson.build | 1 + drivers/crypto/null/meson.build | 1 + drivers/crypto/openssl/meson.build | 1 + drivers/dma/skele

Re: [PATCH v6 0/2] Add l2reflect measurement application

2022-09-21 Thread Henning Schild
Am Wed, 21 Sep 2022 14:22:07 +0200 schrieb Morten Brørup : > > From: Henning Schild [mailto:henning.sch...@siemens.com] > > Sent: Wednesday, 21 September 2022 13.27 > > > > Am Wed, 21 Sep 2022 11:43:13 +0200 > > schrieb Morten Brørup : > > > > > > From: Felix Moessbauer [mailto:felix.moessba..

Re: [PATCH] lib: do not call memcpy with sz zero and null pointer

2022-09-21 Thread Henning Schild
Am Wed, 21 Sep 2022 15:06:12 +0200 schrieb Thomas Monjalon : > 07/09/2022 17:05, Henning Schild: > > There is no point in such a call and UBSan complains about a call to > > memcpy with a null pointer as second arg. > > > > When building with -Db_sanitize=undefined, Clang gives the following > >

RE: [EXT] Re: [PATCH v2 0/5] mbuf dynamic field expansion

2022-09-21 Thread Shijith Thotton
>> >> This is a continuation of the discussions[1] to add mbuf physical address >> field to >dynamic field. >> Previous version was to add PA field to dynamic field area based on the EAL >IOVA mode option. It was >> deemed unsafe as some components could still use the PA field without >checking IO

RE: [PATCH v3 3/5] lib: move mbuf next pointer to first cache line

2022-09-21 Thread Morten Brørup
> From: Shijith Thotton [mailto:sthot...@marvell.com] > Sent: Wednesday, 21 September 2022 15.56 > > Swapped position of mbuf next pointer and second dynamic field > (dynfield2) > if the build is configured to use IOVA as VA. This is to move the mbuf > next pointer to first cache line. kni library

Re: [PATCH] drivers/net: remove alias for virtual devices

2022-09-21 Thread Thomas Monjalon
I think this patch requires a techboard vote as it is dropping some user-facing naming. 21/09/2022 15:34, Ferruh Yigit: > Virtual devices are probed/matched based on name, and this name is user > facing value, since device name is provided by user as eal '--vdev' > parameter, like: > `dpdk-testpm

[PATCH v3 1/7] app/procinfo: add dpdk version dump

2022-09-21 Thread Dongdong Liu
From: "Min Hu (Connor)" Add support for dump dpdk version. The command is like: dpdk-proc-info -a :xx:xx.x --file-prefix=xxx -- --version Signed-off-by: Min Hu (Connor) Signed-off-by: Dongdong Liu --- app/proc-info/main.c | 19 ++- 1 file changed, 18 insertions(+), 1 dele

[PATCH v3 2/7] app/procinfo: add firmware version dump

2022-09-21 Thread Dongdong Liu
Add support for dump ethdev firmware version. The command is like: dpdk-proc-info -a :xx:xx.x --file-prefix=xxx -- --firmware-version Signed-off-by: Min Hu (Connor) Signed-off-by: Dongdong Liu --- app/proc-info/main.c | 35 +++ 1 file changed, 35 insertions(

[PATCH v3 4/7] app/procinfo: add module info dump

2022-09-21 Thread Dongdong Liu
From: "Min Hu (Connor)" This patch add support for module info dump. The command is like: dpdk-proc-info -a :xx:xx.x --file-prefix=xxx -- --show-module-info Signed-off-by: Min Hu (Connor) Signed-off-by: Dongdong Liu --- app/proc-info/main.c | 52 ++

[PATCH v3 0/7] app/procinfo: add some extended features

2022-09-21 Thread Dongdong Liu
This patchset is to add some extended features for dpdk-proc-info. v2->v3: Fix some comments from Stephen. 1. Use --version option for DPDK version and add --firmware-version option to show firmware. 2. Use errors on stderr, not stdout. 3. Delete some unnecessary code. v1->v2: Fix some comment

[PATCH v3 3/7] app/procinfo: add RSS RETA dump

2022-09-21 Thread Dongdong Liu
From: "Min Hu (Connor)" This patch add support for RSS reta dump. The command is like: dpdk-proc-info -a :xx:xx.x --file-prefix=xxx -- --show-rss-reta Signed-off-by: Min Hu (Connor) Signed-off-by: Dongdong Liu --- app/proc-info/main.c | 57 1

[PATCH v3 6/7] app/procinfo: fix some wrong doxygen syntax

2022-09-21 Thread Dongdong Liu
This code is to do cleanup for the wrong doxygen syntax comments. Signed-off-by: Dongdong Liu --- app/proc-info/main.c | 40 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/app/proc-info/main.c b/app/proc-info/main.c index e1a153c934..00ba

[PATCH v3 5/7] app/procinfo: add dump of Rx/Tx burst mode

2022-09-21 Thread Dongdong Liu
From: Jie Hai Add dump of Rx/Tx burst mode in --show-port. Sample output changes: - rx queue - -- 0 descriptors 0/1024 drop_en rx buffer size 2048 \ mempool mb_pool_0 socket 0 + -- 0 descriptors 0/1024 drop_en rx buffer size 2048 \ mempool mb_po

[PATCH v3 7/7] doc: add some extended features in procinfo guide

2022-09-21 Thread Dongdong Liu
Add the below extended features in procinfo guide. --show-port-private --version --firmware-version --show-rss-reta --show-module-info Signed-off-by: Dongdong Liu --- doc/guides/tools/proc_info.rst | 15 +++ 1 file changed, 15 insertions(+) diff --git a/doc/guides/tools/proc_info.r

[PATCH] eal: Pointer alignment check improvements

2022-09-21 Thread Morten Brørup
Checking a const pointer for alignment would emit a warning about the const qualifier being discarded. No need to calculate the aligned pointer; just check the last bits of the pointer. Signed-off-by: Morten Brørup --- lib/eal/include/rte_common.h | 6 +++--- 1 file changed, 3 insertions(+), 3

[PATCH v2] ethdev: add GTP PSC QFI field

2022-09-21 Thread Dariusz Sosnowski
This patch introduces the GTP PSC QFI modify field support and adds the testpmd CLI command support. An example for copying GTP QFI field using modify_field action: modify_field op set dst_type meta src_type gtp_psc_qfi width

  1   2   >