On Mon, Jun 27, 2022 at 6:56 PM Tyler Retzlaff <roret...@linux.microsoft.com> wrote: > > add rte thread lifetime and attributes api. with these api additions > there is now sufficient platform abstracted thread api to remove the > use of pthread in the unit tests. > > v4: > * update version.map to show api from series added in 22.11 instead > of 22.07.
Patch 1 still adds symbols in 22.07 section of the experimental block. Compilation is broken when stopping at patch 4. Newly added code can go to eal_common_thread.c rather than introduce a new common/rte_thread.c file (or is there a rationale for this?). There are guards for the new structs against RTE_HAS_CPUSET being defined. Can you elaborate why those guards are needed? Commitlogs / comments sentences must start with a capital letter. Can you prepare a new revision for -rc1? Thanks. > * fix missing parameter name in rte_thread_func declaration causing > doxygen ci failure. -- David Marchand
