Re: [PATCH] rib: fix traversal with /32 route

2022-06-01 Thread Thomas Monjalon
26/04/2022 16:30, Medvedkin, Vladimir: > Fixes: 5a5793a5ffa2 ("rib: add RIB library") > > On 26/04/2022 15:28, Medvedkin, Vladimir wrote: > > +Cc:sta...@dpdk.org > > > > On 14/04/2022 21:01, Stephen Hemminger wrote: > >> If a /32 route is entered in the RIB the code to traverse > >> will not see

[Bug 1022] [dpdk 22.07-rc0] meson build failed with doc args on Ubuntu22.04 with gcc11.2.0

2022-06-01 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1022 Thomas Monjalon (tho...@monjalon.net) changed: What|Removed |Added Resolution|--- |FIXED Status|

[RFC 0/2] queue-based flow aged report

2022-06-01 Thread Xiaoyu Min
For the queue-based flow managemnt, application can operate the same flow on the same queue. For example, application create flow with age action, query aged flow, and destroy aged flow. All operations of flow happens on the same queue. In this case, the PMD could be more optimized since all oper

[RFC v2 1/2] ethdev: port flags for pre-configuration flow hints

2022-06-01 Thread Xiaoyu Min
The data-path focused flow rule management can manage flow rules in more optimized way than traditional one by using hints provided by application in initialization phase. In addition to the current hints we have in port attr, more hints could be provided by application about its behaviour. One e

[RFC v2 2/2] ethdev: queue-based flow aged report

2022-06-01 Thread Xiaoyu Min
When application use queue-based flow rule management and operate the same flow rule on the same queue, e.g create/destroy/query, API of querying aged flow rules should also have queue id parameter just like other queue-based flow APIs. By this way, PMD can work in more optimized way since resourc

Re: [PATCH v2] vdpa/mlx5: workaround var offset within page

2022-06-01 Thread Maxime Coquelin
Hi Yajun, On 3/15/22 03:47, Yajun Wu wrote: vDPA driver first uses kernel driver to allocate doorbell(VAR) area for each device. Then uses var->mmap_off and var->length to mmap uverbs device file as doorbell userspace virtual address. Current kernel driver provides var->mmap_off equal to page s

Re: [PATCH] vhost: fix null pointer dereference

2022-06-01 Thread Maxime Coquelin
HI Jiayu, On 3/28/22 09:04, David Marchand wrote: On Mon, Mar 28, 2022 at 4:08 AM Jiayu Hu wrote: NULL check for vq->async must be protected by lock. Otherwise, it is possible that the data plane thread dereferences vq->async with NULL value, since the control plane thread is freeing vq->asyn

Re: [PATCH v9] eal: add seqlock

2022-06-01 Thread Mattias Rönnblom
On 2022-06-01 00:45, Stephen Hemminger wrote: > On Mon, 23 May 2022 16:23:46 +0200 > Mattias Rönnblom wrote: > >> +/** >> + * The RTE seqcount type. >> + */ >> +typedef struct { >> +uint32_t sn; /**< A sequence number for the protected data. */ >> +} rte_seqcount_t; > > Don't need structure

[RFC,0/2] introduce NitroSketch Mode into membership library

2022-06-01 Thread Leyi Rong
This patchset introduce a brand new NitroSketch Mode into membership library. This algorithm provides high-fidelity approximate measurements and appears as a promissing alternative to triditional approches such as packet sampling. Leyi Rong (2): member: implement NitroSketch mode test/member:

[RFC,1/2] member: implement NitroSketch mode

2022-06-01 Thread Leyi Rong
Sketching algorithm provide high-fidelity approximate measurements and appears as a promising alternative to traditional approches such as packet sampling. NitroSketch [1] is a software sketching framework that optimizes performance, provides accuracy guarantees, and supports a variety of sketches

[RFC,2/2] test/member: add functional and perf tests for sketch

2022-06-01 Thread Leyi Rong
This patch adds functional and performance tests for sketch mode of membership library. Signed-off-by: Yipeng Wang Signed-off-by: Leyi Rong --- app/test/test_member.c | 258 app/test/test_member_perf.c | 153 - 2 files changed, 407 i

Re: [PATCH v2 06/11] net/hns3: fix coverity codecheck

2022-06-01 Thread Andrew Rybchenko
On 6/1/22 06:52, Min Hu (Connor) wrote: In bitwise operation, "val" should be an unsigned type. This patch fixed it. Fixes: 38b539d96eb6 ("net/hns3: support IEEE 1588 PTP") Cc: sta...@dpdk.org Please, let me know coverity ID. No necessity to resend. I'll add it on applying. Signed-off-by: M

RE: [PATCH v3 1/7] ethdev: add meter color flow matching item

2022-06-01 Thread Ori Kam
Hi Alexander, > -Original Message- > From: Alexander Kozyrev > Sent: Wednesday, June 1, 2022 6:44 AM > To: dev@dpdk.org > Subject: [PATCH v3 1/7] ethdev: add meter color flow matching item > > Provide an ability to use a Color Marker set by a Meter > as a matching item in Flow API. The C

RE: [PATCH v3 2/7] ethdev: allow meter color marker modification

2022-06-01 Thread Ori Kam
Hi Alexander, > -Original Message- > From: Alexander Kozyrev > Sent: Wednesday, June 1, 2022 6:44 AM > To: dev@dpdk.org > Subject: [PATCH v3 2/7] ethdev: allow meter color marker modification > > Extend modify_field Flow API with support of Meter Color Marker > modifications. It allows s

Re: [PATCH] testpmd: optimize forward stream statistics

2022-06-01 Thread Singh, Aman Deep
Hi Junfeng On 5/24/2022 1:57 PM, Junfeng Guo wrote: 1. add throughput statistics for forward stream 2. display forward statistics for every forward stream Signed-off-by: Xiao Wang Signed-off-by: Junfeng Guo --- app/test-pmd/testpmd.c | 41 ++--- app/test

Re: [PATCH] kni: fix compile error

2022-06-01 Thread Andrew Rybchenko
On 6/1/22 04:52, Min Hu (Connor) wrote: Hi, Andrew , 在 2022/6/1 0:42, Andrew Rybchenko 写道: On 5/21/22 10:06, Min Hu (Connor) wrote: When kernel version change into 5.18 from 5.17, 'netif_rx_ni' is discard. It is replaced by 'netif_rx' and this API is also supported in the version below 5.18.

[Bug 1023] [dpdk-22.07][meson test] perf-tests/ipsec_perf_autotest: Failed to test

2022-06-01 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1023 Bug ID: 1023 Summary: [dpdk-22.07][meson test] perf-tests/ipsec_perf_autotest: Failed to test Product: DPDK Version: unspecified Hardware: All OS: All S

RE: [PATCH v3 3/7] ethdev: get meter profile/policy objects

2022-06-01 Thread Ori Kam
Hi Alexander, > -Original Message- > From: Alexander Kozyrev > Sent: Wednesday, June 1, 2022 6:44 AM > Subject: [PATCH v3 3/7] ethdev: get meter profile/policy objects > > Introduce a new Meter API to retrieve a Meter profile and policy > objects using the profile/policy ID previously cr

RE: [PATCH v3 4/7] ethdev: add meter color mark flow action

2022-06-01 Thread Ori Kam
Hi Alexander, Small comment, maybe worth saying that the marking is done on a metadata and not on a packet field. > -Original Message- > From: Alexander Kozyrev > Sent: Wednesday, June 1, 2022 6:44 AM > To: dev@dpdk.org > Cc: cristian.dumitre...@intel.com; jerinjac...@gmail.com; Ori Kam

Re: [PATCH 0/2] small RIB optimizations

2022-06-01 Thread Thomas Monjalon
13/04/2022 08:45, Morten Brørup: > > From: Stephen Hemminger [mailto:step...@networkplumber.org] > > Sent: Wednesday, 13 April 2022 04.10 > > > > A couple of small micro optimizations on the RIB code. > > > > Stephen Hemminger (2): > > rib: mark error checks with unlikely > > rib6: mark error

RE: [PATCH v3 5/7] app/testpmd: add meter color flow matching item

2022-06-01 Thread Ori Kam
Hi Alexander, > -Original Message- > From: Alexander Kozyrev > Sent: Wednesday, June 1, 2022 6:44 AM > Subject: [PATCH v3 5/7] app/testpmd: add meter color flow matching item > > Add testpmd command line to match on a meter color: > flow create 0 ingress group 0 pattern meter color

RE: [PATCH v3 6/7] app/testpmd: allow meter color marker modification

2022-06-01 Thread Ori Kam
Hi Alexander. > -Original Message- > From: Alexander Kozyrev > Sent: Wednesday, June 1, 2022 6:44 AM > Subject: [PATCH v3 6/7] app/testpmd: allow meter color marker modification > > Extend the list of available modify_field IDs to include > recently added meter color marker item in testp

RE: [PATCH v3 7/7] app/testpmd: add meter color mark flow action

2022-06-01 Thread Ori Kam
Hi Alexander, > -Original Message- > From: Alexander Kozyrev > Sent: Wednesday, June 1, 2022 6:44 AM > Subject: [PATCH v3 7/7] app/testpmd: add meter color mark flow action > > Add testpmd command line to match for METER_MARK action: > flow create ... actions meter_mark mtr_profile

Re: [PATCH v9] eal: add seqlock

2022-06-01 Thread Mattias Rönnblom
On 2022-05-31 13:52, David Marchand wrote: > On Mon, May 23, 2022 at 4:24 PM Mattias Rönnblom > wrote: >> >> A sequence lock (seqlock) is a synchronization primitive which allows >> for data-race free, low-overhead, high-frequency reads, suitable for >> data structures shared across many cores and

Re: [PATCH v4] kni: fix device address set

2022-06-01 Thread Andrew Rybchenko
On 6/1/22 04:59, Min Hu (Connor) wrote: Currently, run KNI APP When Kernel version is 5.17. When quit the APP, dmesg buffer get calltrace, info like: [ 5965.847401] rte_kni: Creating kni... [ 6225.627205] vEth0 (unregistered): Current addr: 70 fd 45 d0 72 a7 00.. [ 6225.640113] vEth0 (unregister

RE: [RFC v2 1/2] ethdev: port flags for pre-configuration flow hints

2022-06-01 Thread Ori Kam
Hi Jack, > -Original Message- > From: Jack Min > Sent: Wednesday, June 1, 2022 10:39 AM > Subject: [RFC v2 1/2] ethdev: port flags for pre-configuration flow hints > > The data-path focused flow rule management can manage flow rules in more > optimized way than traditional one by using h

RE: [PATCH v9] eal: add seqlock

2022-06-01 Thread Morten Brørup
> From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com] > Sent: Wednesday, 1 June 2022 11.02 > > On 2022-05-31 13:52, David Marchand wrote: > > On Mon, May 23, 2022 at 4:24 PM Mattias Rönnblom > > wrote: > >> > >> A sequence lock (seqlock) is a synchronization primitive which > allows > >

Re: [PATCH] mbuf: expose outer vlan in mbuf dump

2022-06-01 Thread Thomas Monjalon
13/04/2022 14:59, Morten Brørup: > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > Sent: Wednesday, 13 April 2022 14.03 > > > > 12/04/2022 18:11, Ben Magistro: > > > Was there a consensus on if this should be re-drafted as a bug and > > fixes or > > > left as a backportable feature/improv

Re: [PATCH v3 1/2] lpm: add const to lpm arg of rte_lpm_lookup

2022-06-01 Thread Medvedkin, Vladimir
On 30/05/2022 19:24, Stanislaw Kardach wrote: All other rte_lpm_lookup* functions take lpm argument as a const. As the basic rte_lpm_lookup() performs the same function, it should also do that. As this function is inline, no API/ABI change happens. Signed-off-by: Stanislaw Kardach --- lib

[PATCH v1] doc/l2_forward_crypto: fixed grammar and parameters

2022-06-01 Thread Jakub Poczatek
Doc was updated with fixed grammar in most cases. These include adding periods to ends of sentences and capitalizing some words. Some instances of "a" were changed to "an". The option "-n 4" has also been removed from the example of running the application. Fixes: ba7b86b1419 ("doc: add l2fwd-cryp

Re: [PATCH v3 2/2] lpm: add a scalar version of lookupx4 function

2022-06-01 Thread Medvedkin, Vladimir
Hi Stanislaw, On 30/05/2022 19:24, Stanislaw Kardach wrote: From: Michal Mazurek Add an implementation of the rte_lpm_lookupx4() function for platforms without support for vector operations. This will be useful in the upcoming RISC-V port as well as any platform which may want to start with

Re: [PATCH v2] vdpa/mlx5: workaround var offset within page

2022-06-01 Thread Maxime Coquelin
On 6/1/22 09:55, Maxime Coquelin wrote: Hi Yajun, On 3/15/22 03:47, Yajun Wu wrote: vDPA driver first uses kernel driver to allocate doorbell(VAR) area for each device. Then uses var->mmap_off and var->length to mmap uverbs device file as doorbell userspace virtual address. Current kernel

[dpdk-dev v1] doc/multi-process: fixed grammar and rephrasing

2022-06-01 Thread Kai Ji
Update and rephrasing some sentences, small improvements made to the multi-process sample application user guide Fixes: d0dff9ba445e ("doc: sample application user guide") Cc: bernard.iremon...@intel.com Signed-off-by: Kai Ji --- doc/guides/sample_app_ug/multi_process.rst | 67 +++--

Re: [PATCH v2] examples/vhost: fix floating point exception when no VMDq

2022-06-01 Thread Maxime Coquelin
On 5/18/22 15:36, Yuan Wang wrote: If the VMDQ limits is 0, a divide-by-zero error occurs. This patch replaces throwing a floating point exception with a normal error message. Fixes: d19533e86f ("examples/vhost: copy old vhost example") Cc: sta...@dpdk.org Signed-off-by: Yuan Wang --- exa

Re: [PATCH v10 00/13] add virtio_blk device support to vdpa/ifc

2022-06-01 Thread Maxime Coquelin
On 5/24/22 04:48, Andy Pei wrote: This patch set add virtio_blk device support to vdpa/ifc driver. With a lot of similarities, I re-use part of vdpa/ifc driver. Distinguish the virtio net and blk device by device id, and implement specific features and ops. Add example to vdpa to support virti

[PATCH v5 00/12] cryptodev: rsa, dh, ecdh changes

2022-06-01 Thread Arek Kusztal
This patchset introduces some of changes discussed on mailing list for 22.07 release in cryptodev asym. Key changes: - It fixes API for RSA (expescially signature paddings) - Adds Elliptic-Curve Diffie-Hellman - Adds Eliiptic-Curve point verification - Adds RSA missing padding fields - Adds asym

[PATCH v5 01/12] cryptodev: redefine ec group enum

2022-06-01 Thread Arek Kusztal
- EC enum was renamed to rte_crypto_curve_id. Elliptic curve enum name was incorrectly associated with a group (it comes from the current tls registry name). - Clarified comments about TLS deprecation. Some curves included are deprecated with TLS 1.3. Comments to address it were added. - Clarified

[PATCH v5 02/12] cryptodev: separate key exchange operation enum

2022-06-01 Thread Arek Kusztal
- Separated key exchange enum from asym op type. Key exchange and asymmetric crypto operations like signatures, encryption/decryption should not share same operation enum as its use cases are unrelated and mutually exclusive. Therefore op_type was separate into: 1) operation type 2) key exchange op

[PATCH v5 03/12] cryptodev: remove comment about using ephemeral key in dsa

2022-06-01 Thread Arek Kusztal
- Removed comment that stated DSA can be used with Diffie Hellman ephemeral key. DH and DSA integration allowed to use ephemeral keys for random integer, but not for private keys. Signed-off-by: Arek Kusztal --- lib/cryptodev/rte_crypto_asym.h | 8 +--- 1 file changed, 1 insertion(+), 7 dele

[PATCH v5 04/12] cryptodev: clarify usage of private key in dh

2022-06-01 Thread Arek Kusztal
- Clarified usage of private key in Diffie-Hellman. CSRNG capable device should generate private key and then use it for public key generation. Signed-off-by: Arek Kusztal --- lib/cryptodev/rte_crypto_asym.h | 5 + 1 file changed, 5 insertions(+) diff --git a/lib/cryptodev/rte_crypto_asym.h

[PATCH v5 05/12] cryptodev: move dh type from xform to dh op

2022-06-01 Thread Arek Kusztal
- Moved dh operation type to dh operation struct. Operation type (PUBLIC_KEY_GENERATION, SHARED_SECRET) should be free to choose for any operation. One xform/session should be enough to perform both DH operations, if op_type would be xform member, session would have to be to be created twice for th

[PATCH v5 06/12] cryptodev: add elliptic curve diffie hellman

2022-06-01 Thread Arek Kusztal
- Added elliptic curve Diffie-Hellman parameters. Point multiplication allows the user to process every phase of ECDH, but for phase 1, user should not really care about the generator. The user does not even need to know what the generator looks like, therefore setting ec xform would make this work

[PATCH v5 07/12] cryptodev: add public key verify option

2022-06-01 Thread Arek Kusztal
- Added key exchange public key verify option. For some elliptic curves public point in DH exchange needs to be checked, if it lays on the curve. Modular exponentiation needs certain checks as well, though mathematically much easier. This commit adds verify option to asym_op operations. Signed-off

[PATCH v5 08/12] cryptodev: add asym op flags

2022-06-01 Thread Arek Kusztal
- Added flags to rte_crypto_asym_op struct. It may be shared between different algorithms. - Added Diffie-Hellman padding flags. Diffie-Hellman padding is used in certain protocols, in others, leading zero bytes need to be stripped. Even same protocol may use a different approach - most glaring exa

[PATCH v5 09/12] cryptodev: clarify usage of rsa padding hash

2022-06-01 Thread Arek Kusztal
- Clarified usage of RSA padding hash. It was not specified how to use hash for PKCS1_5 padding. This could lead to incorrect implementation. Signed-off-by: Arek Kusztal --- lib/cryptodev/rte_crypto_asym.h | 25 ++--- 1 file changed, 22 insertions(+), 3 deletions(-) diff --g

[PATCH v5 10/12] cryptodev: move RSA padding into separate struct

2022-06-01 Thread Arek Kusztal
- move RSA padding into separate struct. More padding members should be added into padding, therefore having separate struct for padding parameters will make this more readable. Signed-off-by: Arek Kusztal --- app/test/test_cryptodev_asym.c | 10 ++-- drivers/common/cpt/cpt_ucode_as

[PATCH v5 11/12] cryptodev: clarify rsa verify with none padding

2022-06-01 Thread Arek Kusztal
- Clarified where should output be stored of signature decryption with padding none. PMD is not able to know what padding algorithm was used, therefore decrypted signature should be returned to the user. - Removed incorrect big-endian constraints. Not all data in RSA can be treated as big endian in

[PATCH v5 12/12] cryptodev: add salt length and optional label

2022-06-01 Thread Arek Kusztal
- Added salt length and optional label. Common parameters to PSS and OAEP padding for RSA. - Changed RSA hash padding fields names. Now it corresponds to the RSA documents. Signed-off-by: Arek Kusztal --- lib/cryptodev/rte_crypto_asym.h | 19 +-- 1 file changed, 17 insertions(+),

RE: [PATCH v5 06/12] cryptodev: add elliptic curve diffie hellman

2022-06-01 Thread Kusztal, ArkadiuszX
Hi Akhil, I did not put much effort into documentation part. I believe it needs bit more attention in asym area (one bigger patch) + backported fixes about ECDSA and ECPM. > -Original Message- > From: Kusztal, ArkadiuszX > Sent: Wednesday, June 1, 2022 11:03 AM > To: dev@dpdk.org > Cc:

Re: [PATCH v3 2/2] lpm: add a scalar version of lookupx4 function

2022-06-01 Thread Stanisław Kardach
Hi Vladimir, On Wed, Jun 1, 2022 at 11:41 AM Medvedkin, Vladimir wrote: > > Hi Stanislaw, > > > On 30/05/2022 19:24, Stanislaw Kardach wrote: > > From: Michal Mazurek > > > > Add an implementation of the rte_lpm_lookupx4() function for platforms > > without support for vector operations. > > > >

Re: [PATCH v3] ethdev: fix dev close in secondary process

2022-06-01 Thread Andrew Rybchenko
On 6/1/22 06:15, Min Hu (Connor) wrote: From: Min Hu Secondary process need to close dev to release process private resources. But secondary process should not be obliged to wait for device stop before closing ethdev. This patch fixed it. Fixes: febc855b358e ("ethdev: forbid closing started d

Re: [PATCH v2 0/3] doc: build on Windows

2022-06-01 Thread Thomas Monjalon
> Dmitry Kozlyuk (3): > doc: simplify CSS customization for Doxygen > doc: fix API index Markdown syntax > doc: rewrite shell scripts in Python Applied, thanks. I hope the Windows setup issue seen by Vipin can be workarounded.

Re: [PATCH] devtools: fix null test for NUMA systems

2022-06-01 Thread Thomas Monjalon
13/04/2022 13:19, David Marchand: > On NUMA systems, default cores (0 and 1) might be on different memory > nodes. Double the amount of memory. > > Cc: sta...@dpdk.org > > Signed-off-by: David Marchand Fixes: 9e6b36c34ce9 ("app/testpmd: reduce memory consumption") Applied, thanks.

[PATCH] test/ipsec: check for cryptodevs before testing

2022-06-01 Thread Stanislaw Kardach
Make sure that ipsec_perf_autotest checks if there are any crypto devices available before it starts performance testing. Same test is performed in the ipsec_autotest so it seems prudent to do it here too to not introduce false failures. Signed-off-by: Stanislaw Kardach --- app/test/test_ipsec_p

[PATCH v4 1/2] lpm: add const to lpm arg of rte_lpm_lookup

2022-06-01 Thread Stanislaw Kardach
All other rte_lpm_lookup* functions take lpm argument as a const. As the basic rte_lpm_lookup() performs the same function, it should also do that. As this function is inline, no API/ABI change happens. Signed-off-by: Stanislaw Kardach Acked-by: Vladimir Medvedkin Acked-by: Stephen Hemminger -

[PATCH v4 2/2] lpm: add a scalar version of lookupx4 function

2022-06-01 Thread Stanislaw Kardach
From: Michal Mazurek Add an implementation of the rte_lpm_lookupx4() function for platforms without support for vector operations. This will be useful in the upcoming RISC-V port as well as any platform which may want to start with a basic level of LPM support. Signed-off-by: Michal Mazurek Si

Re: [PATCH v4 2/2] lpm: add a scalar version of lookupx4 function

2022-06-01 Thread Medvedkin, Vladimir
On 01/06/2022 12:15, Stanislaw Kardach wrote: From: Michal Mazurek Add an implementation of the rte_lpm_lookupx4() function for platforms without support for vector operations. This will be useful in the upcoming RISC-V port as well as any platform which may want to start with a basic level

Re: [PATCH] pipeline: fix emit instruction for invalid headers

2022-06-01 Thread Thomas Monjalon
27/04/2022 23:56, Cristian Dumitrescu: > Fix the emit instruction for the pathological case of all headers to > be emitted being invalid. In this case, the for loop was essentially > skipped and the last emitted header (or an invalid memory location) > getting corrupted by setting its size to 0 thr

Re: [PATCH V4] pipeline: support default action arguments

2022-06-01 Thread Thomas Monjalon
11/04/2022 20:21, Cristian Dumitrescu: > Add support for arguments to the default action of regular and learner > tables at initialization time. Until now, only default actions with no > arguments were accepted in the .spec file. > > Signed-off-by: Cristian Dumitrescu > Signed-off-by: Yogesh Jang

Re: [PATCH V5 1/6] port: support packet mirroring

2022-06-01 Thread Thomas Monjalon
06/04/2022 20:55, Cristian Dumitrescu: > Add packet clone operation to the output ports in order to support > packet mirroring. > > Signed-off-by: Cristian Dumitrescu > Signed-off-by: Kamalakannan R Series applied, thanks.

Re: [PATCH V5 1/6] port: support packet mirroring

2022-06-01 Thread Thomas Monjalon
> +/** > + * Output port packet clone and transmit > + * > + * @param[in] port > + * Output port handle. > + * @param[in] pkt > + * Packet to be transmitted. A parameter is not documented here. Adding this while merging: * @param[in] truncation_length * Packet length to be cloned. > + */ >

[PATCH v7 0/3] ethdev: introduce protocol type based header split

2022-06-01 Thread wenxuanx . wu
From: Wenxuan Wu Buffer split consists of splitting a received packet into two separate regions based on the packet content. It is useful in some scenarios, such as GPU acceleration. The splitting will help to enable true zero copy and hence improve the performance significantly. This patchset e

[PATCH v7 2/3] net/ice: support buffer split in Rx path

2022-06-01 Thread wenxuanx . wu
From: Wenxuan Wu This patch adds support for proto based buffer split in normal Rx data paths. When the Rx queue is configured with specific protocol type, packets received will be directly splitted into protocol header and payload parts. And the two parts will be put into different mempools. Cu

[PATCH v7 1/3] ethdev: introduce protocol header based buffer split

2022-06-01 Thread wenxuanx . wu
From: Wenxuan Wu Currently, Rx buffer split supports length based split. With Rx queue offload RTE_ETH_RX_OFFLOAD_BUFFER_SPLIT enabled and Rx packet segment configured, PMD will be able to split the received packets into multiple segments. However, length based buffer split is not suitable for N

[PATCH v7 3/3] app/testpmd: add rxhdrs commands and parameters

2022-06-01 Thread wenxuanx . wu
From: Wenxuan Wu Add command line parameter: --rxhdrs=mac,[ipv4,udp] Set the protocol_hdr of segments to scatter packets on receiving if split feature is engaged. And the queues with BUFFER_SPLIT flag. Add interative mode command: testpmd>set rxhdrs mac,ipv4,l3,tcp,udp,sctp (protocol sequence a

Re: [PATCH v2] ethdev: fix dev close in secondary process

2022-06-01 Thread Ajit Khaparde
On Tue, May 31, 2022 at 8:18 PM Min Hu (Connor) wrote: > > Hi, Ajit > v3 has been sent, thanks Thanks smime.p7s Description: S/MIME Cryptographic Signature

[PATCH v7 0/3] ethdev: introduce protocol type based header split

2022-06-01 Thread wenxuanx . wu
From: Wenxuan Wu Buffer split consists of splitting a received packet into two separate regions based on the packet content. It is useful in some scenarios, such as GPU acceleration. The splitting will help to enable true zero copy and hence improve the performance significantly. This patchset e

[PATCH v7 1/3] ethdev: introduce protocol header based buffer split

2022-06-01 Thread wenxuanx . wu
From: Wenxuan Wu Currently, Rx buffer split supports length based split. With Rx queue offload RTE_ETH_RX_OFFLOAD_BUFFER_SPLIT enabled and Rx packet segment configured, PMD will be able to split the received packets into multiple segments. However, length based buffer split is not suitable for N

[PATCH v7 2/3] net/ice: support buffer split in Rx path

2022-06-01 Thread wenxuanx . wu
From: Wenxuan Wu This patch adds support for proto based buffer split in normal Rx data paths. When the Rx queue is configured with specific protocol type, packets received will be directly splitted into protocol header and payload parts. And the two parts will be put into different mempools. Cu

[PATCH v7 3/3] app/testpmd: add rxhdrs commands and parameters

2022-06-01 Thread wenxuanx . wu
From: Wenxuan Wu Add command line parameter: --rxhdrs=mac,[ipv4,udp] Set the protocol_hdr of segments to scatter packets on receiving if split feature is engaged. And the queues with BUFFER_SPLIT flag. Add interative mode command: testpmd>set rxhdrs mac,ipv4,l3,tcp,udp,sctp (protocol sequence a

Re: [PATCH V3 1/3] table: improve learner table timers

2022-06-01 Thread Thomas Monjalon
21/05/2022 00:12, Cristian Dumitrescu: > Previously, on lookup hit, the hit key had its timer automatically > rearmed with the same timeout in order to prevent its expiration. Now, > a broader set of actions is available on lookup hit, which has to be > managed explicitly: the key can have its time

RE: [PATCH v10 00/13] add virtio_blk device support to vdpa/ifc

2022-06-01 Thread Pei, Andy
Thanks Maxime > -Original Message- > From: Maxime Coquelin > Sent: Wednesday, June 1, 2022 6:11 PM > To: Pei, Andy ; dev@dpdk.org > Cc: Xia, Chenbo ; Cao, Gang ; > Liu, Changpeng ; Xu, Rosen > ; Xiao, QimaiX > Subject: Re: [PATCH v10 00/13] add virtio_blk device support to vdpa/ifc > >

Re: [PATCH v7 3/6] baseband/acc100: remove RTE prefix for internal macro

2022-06-01 Thread Maxime Coquelin
On 6/1/22 00:31, Nicolas Chautru wrote: Cosmetic update to remove RTE_ prefix for a define kept internal. Signed-off-by: Nicolas Chautru --- drivers/baseband/acc100/rte_acc100_pmd.c | 4 ++-- drivers/baseband/acc100/rte_acc100_pmd.h | 6 +++--- 2 files changed, 5 insertions(+), 5 deletio

[PATCH v8 0/3] ethdev: introduce protocol type based header split

2022-06-01 Thread wenxuanx . wu
From: Wenxuan Wu Buffer split consists of splitting a received packet into two separate regions based on the packet content. It is useful in some scenarios, such as GPU acceleration. The splitting will help to enable true zero copy and hence improve the performance significantly. This patchset e

[PATCH v8 1/3] ethdev: introduce protocol hdr based buffer split

2022-06-01 Thread wenxuanx . wu
From: Wenxuan Wu Currently, Rx buffer split supports length based split. With Rx queue offload RTE_ETH_RX_OFFLOAD_BUFFER_SPLIT enabled and Rx packet segment configured, PMD will be able to split the received packets into multiple segments. However, length based buffer split is not suitable for N

[PATCH v8 1/3] ethdev: introduce protocol header based buffer split

2022-06-01 Thread wenxuanx . wu
From: Wenxuan Wu Currently, Rx buffer split supports length based split. With Rx queue offload RTE_ETH_RX_OFFLOAD_BUFFER_SPLIT enabled and Rx packet segment configured, PMD will be able to split the received packets into multiple segments. However, length based buffer split is not suitable for N

[PATCH v8 2/3] net/ice: support buffer split in Rx path

2022-06-01 Thread wenxuanx . wu
From: Wenxuan Wu This patch adds support for proto based buffer split in normal Rx data paths. When the Rx queue is configured with specific protocol type, packets received will be directly splitted into protocol header and payload parts. And the two parts will be put into different mempools. Cu

[PATCH v8 3/3] app/testpmd: add rxhdrs commands and parameters

2022-06-01 Thread wenxuanx . wu
From: Wenxuan Wu Add command line parameter: --rxhdrs=mac,[ipv4,udp] Set the protocol_hdr of segments to scatter packets on receiving if split feature is engaged. And the queues with BUFFER_SPLIT flag. Add interative mode command: testpmd>set rxhdrs mac,ipv4,l3,tcp,udp,sctp (protocol sequence a

Re: [PATCH V5 1/2] pipeline: support hash functions

2022-06-01 Thread Thomas Monjalon
21/05/2022 00:31, Cristian Dumitrescu: > Add support for hash functions that compute a signature for an array > of bytes read from a packet header or meta-data. Useful for flow > affinity-based load balancing. > > Signed-off-by: Cristian Dumitrescu Series applied, thanks.

Re: [PATCH v2] libpcapng: fix timestamp wrapping in output files

2022-06-01 Thread Thomas Monjalon
17/05/2022 17:15, Stephen Hemminger: > On Tue, 17 May 2022 11:01:15 +0100 > Quentin Armitage wrote: > > > In pcap_tsc_to_ns(), delta * NSEC_PER_SEC will overflow approx 8 > > seconds after pcap_init is called when using a TSC with a frequency > > of 2.5GHz. > > > > To avoid the overflow, update

Re: [PATCH] doc: remove reference to pcapng init function

2022-06-01 Thread Thomas Monjalon
27/05/2022 17:38, Stephen Hemminger: > On Fri, 27 May 2022 13:21:42 + > Cian Ferriter wrote: > > > The rte_pcapng_init function doesn't exist, so remove it from the docs. > > > > Also fix minor mistakes in the file. > > > > Signed-off-by: Cian Ferriter > > Yes, this is leftover from earli

Re: [PATCH] eal/ppc: undefine AltiVec keyword vector

2022-06-01 Thread Thomas Monjalon
26/05/2022 13:02, Ray Kinsella: > Thomas Monjalon writes: > > 25/05/2022 20:34, Tyler Retzlaff: > >> On Wed, May 25, 2022 at 07:02:52PM +0100, Ray Kinsella wrote: > >> > Thomas Monjalon writes: > >> > > 25/05/2022 13:48, Ray Kinsella: > >> > >> Thomas Monjalon writes: > >> > >> > >> > >> > The

Re: [PATCH v7] eal/ppc: fix compilation for musl

2022-06-01 Thread David Marchand
On Tue, May 31, 2022 at 7:26 PM David Christensen wrote: > On 5/14/22 12:14 AM, Duncan Bellamy wrote: > > musl lacks __ppc_get_timebase() but has __builtin_ppc_get_timebase() > > > > Signed-off-by: Duncan Bellamy > Reviewed-by: David Christensen Applied, thanks. -- David Marchand

Re: [PATCH v2] examples/kni: clear warning about discarding const qualifier

2022-06-01 Thread Ferruh Yigit
On 6/1/2022 6:45 AM, Ke Zhang wrote: The warning info: warning: passing argument 1 of ‘memcpy’ discards ‘const’ qualifier from pointer target type Variable is done const intentionally to prevent using it directly, using the new helper functions : 'eth_hw_addr_set()' and 'eth_hw_addr_random()' F

Re: [PATCH] kni: fix compile error

2022-06-01 Thread Ferruh Yigit
On 6/1/2022 9:47 AM, Andrew Rybchenko wrote: On 6/1/22 04:52, Min Hu (Connor) wrote: Hi, Andrew , 在 2022/6/1 0:42, Andrew Rybchenko 写道: On 5/21/22 10:06, Min Hu (Connor) wrote: When kernel version change into 5.18 from 5.17, 'netif_rx_ni' is discard. It is replaced by 'netif_rx' and this API

Re: [PATCH v9] eal: add seqlock

2022-06-01 Thread Stephen Hemminger
On Wed, 1 Jun 2022 08:19:54 + Mattias Rönnblom wrote: > On 2022-06-01 00:45, Stephen Hemminger wrote: > > On Mon, 23 May 2022 16:23:46 +0200 > > Mattias Rönnblom wrote: > > > >> +/** > >> + * The RTE seqcount type. > >> + */ > >> +typedef struct { > >> + uint32_t sn; /**< A sequence numb

[PATCH v6] eal: add bus cleanup to eal cleanup

2022-06-01 Thread Kevin Laatz
During EAL init, all buses are probed and the devices found are initialized. On eal_cleanup(), the inverse does not happen, meaning any allocated memory and other configuration will not be cleaned up appropriately on exit. Currently, in order for device cleanup to take place, applications must cal

Re: [PATCH v6] eal: add bus cleanup to eal cleanup

2022-06-01 Thread Bruce Richardson
On Wed, Jun 01, 2022 at 06:02:34PM +0100, Kevin Laatz wrote: > During EAL init, all buses are probed and the devices found are > initialized. On eal_cleanup(), the inverse does not happen, meaning any > allocated memory and other configuration will not be cleaned up > appropriately on exit. > > Cu

Re: [PATCH 0/5] Fix IDXD PCI device close

2022-06-01 Thread Kevin Laatz
On 31/05/2022 17:37, Kevin Laatz wrote: On 31/05/2022 17:17, Thomas Monjalon wrote: Kevin Laatz (5):    dma/idxd: fix memory leak in pci close    dma/idxd: fix memory leak due to free on incorrect pointer    app/test: close dma devices during cleanup    app/testpmd: stop and close dmadevs at exi

RE: [EXT] Re: [PATCH v7 3/6] baseband/acc100: remove RTE prefix for internal macro

2022-06-01 Thread Akhil Goyal
Hi Maxime, > > Reviewed-by: Maxime Coquelin > Do you have any more comments on other patches of this series? If not, please ack other patches as well.

Re: [PATCH v4 0/2] ethdev: fix MAC addrs list

2022-06-01 Thread Andrew Rybchenko
On 6/1/22 09:39, Min Hu (Connor) wrote: The index zero of rte_eth_dev_data::mac_addrs array is as the default MAC index, and other indexes can't be the same as the address corresponding to index 0. If we break it, may cause following problems: 1) waste of MAC address spaces. 2) a fake MAC address

Re: [PATCH v4 1/2] ethdev: fix one address occupies two indexes in MAC addrs

2022-06-01 Thread Andrew Rybchenko
On 6/1/22 09:39, Min Hu (Connor) wrote: From: Huisong Li The dev->data->mac_addrs[0] will be changed to a new MAC address when applications modify the default MAC address by rte_eth_dev_default_mac_addr_set(). However, if the new default one has been added as a non-default MAC address by rte_et

Re: [PATCH v4 2/2] ethdev: document default and non-default MAC address

2022-06-01 Thread Andrew Rybchenko
On 6/1/22 09:39, Min Hu (Connor) wrote: From: Huisong Li The rte_eth_dev_data::mac_addrs is a MAC address array. The index zero of this array is as the default address index, and other indexes can't be the same as the address corresponding to index 0. If we break it, may cause following problem

Re: [PATCH v3 4/5] app/testpmd: fix slave device isn't released

2022-06-01 Thread Ferruh Yigit
On 5/3/2022 11:02 AM, Min Hu (Connor) wrote: From: Huisong Li Currently, some eth devices are added to bond device, these devices are not released when the quit command is executed in testpmd. This patch adds the release operation for all active slaves under a bond device. Fixes: 0e545d3047fe (

Re: [RFC v2 1/2] ethdev: port flags for pre-configuration flow hints

2022-06-01 Thread Andrew Rybchenko
Summary must not be a statement. May be: ethdev: add strict queue to pre-configuration flow hints On 6/1/22 10:39, Xiaoyu Min wrote: The data-path focused flow rule management can manage flow rules in more optimized way than traditional one by using hints provided by application in initializatio

Re: [RFC v2 2/2] ethdev: queue-based flow aged report

2022-06-01 Thread Andrew Rybchenko
Again, summary must not be a statement. On 6/1/22 10:39, Xiaoyu Min wrote: When application use queue-based flow rule management and operate the same flow rule on the same queue, e.g create/destroy/query, API of querying aged flow rules should also have queue id parameter just like other queue-b

Re: [PATCH v3 0/4] support HW Rx/Tx descriptor dump

2022-06-01 Thread Andrew Rybchenko
Again, please, add maintainers using --cc-cmd or --to-cmd to patches. Also, don't forget to keep in Cc participants of the discussion. On 6/1/22 10:49, Min Hu (Connor) wrote: This patch set support HW Rx/Tx descriptor dump by using procinfo tool. Min Hu (Connor) (4): ethdev: introduce ethdev

Re: [PATCH v3 0/4] support HW Rx/Tx descriptor dump

2022-06-01 Thread Ray Kinsella
Andrew Rybchenko writes: > Again, please, add maintainers using --cc-cmd or --to-cmd to patches. > Also, don't forget to keep in Cc participants of the discussion. And you can add my Acked-by to 1/4. > On 6/1/22 10:49, Min Hu (Connor) wrote: >> This patch set support HW Rx/Tx descriptor dump

Re: [v1 1/4] ethdev: add IPv4/IPv6 ECN header rewrite action

2022-06-01 Thread Ferruh Yigit
On 4/2/2022 8:11 AM, Sean Zhang wrote: From: Jiawei Wang This patch introduces the IPv4/IPv6 ECN modify field support, and adds the testpmd CLI commands support. Usage: modify_field op set dst_type ipv4_ecn src_type ... For example: flow create 0 ingress group 1 pattern eth / ipv4 /

Re: [v1 0/4] Add support for modifying ECN in IPv4/IPv6 header

2022-06-01 Thread Ferruh Yigit
On 4/2/2022 8:11 AM, Sean Zhang wrote: This patch set adds support for modifying ECN fields in IPv4/IPv6 header, and also adds support for modify_filed action in meter. Jiawei Wang (1): ethdev: add IPv4/IPv6 ECN header rewrite action Sean Zhang (3): common/mlx5: add modify ECN capability

  1   2   >