On 6/1/22 09:39, Min Hu (Connor) wrote:
The index zero of rte_eth_dev_data::mac_addrs array is as the default MAC
index, and other indexes can't be the same as the address corresponding to
index 0. If we break it, may cause following problems:
1) waste of MAC address spaces.
2) a fake MAC address in the MAC list, isn't in hardware MAC entries.
3) a MAC address is assigned to diffent pool.
Huisong Li (2):
ethdev: fix one address occupies two indexes in MAC addrs
ethdev: document default and non-default MAC address
---
v4:
- fix broken in the patchwork
v3:
- first explicitly remove the non-default MAC, then set default one.
- document default and non-default MAC address
v2:
- fixed commit log.
lib/ethdev/ethdev_driver.h | 7 ++++++-
lib/ethdev/rte_ethdev.c | 39 ++++++++++++++++++++++++++++++++++++--
2 files changed, 43 insertions(+), 3 deletions(-)
Please, don't forget to add maintainers in Cc when you send patches.
--cc-cmd ./devtools/get-maintainers.sh
or
--to-cmd ./devtools/get-maintainers.sh
(I'd prefer To and have dev@dpdk.org in Cc)
Don't worry about it right now. I'll add Thomas and Ferrh in my replies.
