Hi Arek, Akhil,
Please see inline.
Thanks,
Anoob
> -Original Message-
> From: Kusztal, ArkadiuszX
> Sent: Wednesday, May 25, 2022 12:06 PM
> To: Akhil Goyal ; dev@dpdk.org; Kiran Kumar
> Kokkilagadda ; Anoob Joseph
>
> Cc: Zhang, Roy Fan
> Subject: RE: [EXT] [PATCH 11/40] cryptodev: r
> From: Stephen Hemminger [mailto:step...@networkplumber.org]
> Sent: Wednesday, 25 May 2022 08.04
>
> On Tue, 24 May 2022 22:46:05 -0700
> Subendu Santra wrote:
>
> > Show all non-owned ports when no port mask is specified
> >
> > show-port option without the mask option, displays only the last
25/05/2022 02:11, Zhang, Qi Z:
> From: Thomas Monjalon
> > 24/05/2022 15:42, Zhang, Qi Z:
> > > From: Thomas Monjalon
> > > > 18/05/2022 02:03, Zhang, Qi Z:
> > > > > From: Jeff Daly
> > > > > >
> > > > > > Some SFP link partners exhibit a disinclination to autonegotiate
> > > > > > with X550 co
I'm pretty sure there is something wrong in the driver cnxk,
but you keep insisting and nobody complained,
so I accept the patch for the test application.
Applied
24/05/2022 07:39, Rakesh Kudurumalla:
> ping
>
> > From: Rakesh Kudurumalla
> > Sent: Monday, May 9, 2022 3:32 PM
> >
> > Hi Thomas
04/05/2022 22:40, David Christensen:
> On 5/3/22 5:03 AM, Thomas Monjalon wrote:
> > The keyword "vector" may conflict easily.
> > As a rule, it is better to use the alternative keyword "__vector".
> >
> > Signed-off-by: Thomas Monjalon
>
> Reviewed-by: David Christensen
Applied with a longer
> -Original Message-
> From: Thomas Monjalon
> Sent: Wednesday, May 25, 2022 3:56 PM
> To: Zhang, Qi Z
> Cc: Daly, Jeff ; dev@dpdk.org; Wang, Haiyue
> ; ferruh.yi...@amd.com;
> andrew.rybche...@oktetlabs.ru; Richardson, Bruce
> ; Mcnamara, John
>
> Subject: Re: [PATCH v2] ixgbe/base:
Hi, Pankaj,
On 5/25/22 03:40, Pankaj Gupta wrote:
VMXNET3 version 6 supports some new features, including but not limited to:
- Increased max MTU up to 9190
- Increased max number of queues, both for Rx and Tx
- Removes power-of-two limitations
- Extended interrupt structures, required implement
On 5/25/22 06:14, Robin Zhang wrote:
This patch implements SFF-8024 Rev 4.0 of pluggable I/O configuration
and some common utilities for SFF-8436/8636 and SFF-8472/8079.
Signed-off-by: Robin Zhang
[snip]
checkpatches.sh complains on the following, please, fix:
+ /* SFP Temp in 16-bit
> -Original Message-
> From: Nicolau, Radu
> Sent: Monday, May 23, 2022 8:05 PM
> To: Wu, Jingjing ; Xing, Beilei
> Cc: dev@dpdk.org; Buckley, Daniel M ; Zhang,
> Qi Z ; Nicolau, Radu ;
> sta...@dpdk.org
> Subject: [PATCH v2] net/iavf: fix device stop
>
> Move security context destroy
> -Original Message-
> From: Yang, Qiming
> Sent: Wednesday, May 25, 2022 1:58 PM
> To: Zhang, Qi Z ; dev@dpdk.org
> Cc: Yang, Qiming ; Liu, KevinX
>
> Subject: [PATCH v2] net/igc: add I226 support
>
> Added I226 Series device ID in igc driver and updated igc guide document for
> new dev
From: Pavan Nikhilesh
Add Tx first support to pipeline mode tests, the transmition is done
on all the ethernet ports. This helps in testing eventdev performance
with standalone loopback interfaces.
Example:
./dpdk-test-eventdev ... -- ... --tx_first 512
512 defines the number of
On 5/25/22 06:14, Robin Zhang wrote:
This patch implements format module EEPROM information for
SFF-8636 Rev 2.7
Signed-off-by: Robin Zhang
[snip]
+ /*
+* There is no clear identifier to signify the existence of
+* optical diagnostics similar to SFF-8472. So checking e
An additional check is added to avoid extra processing if
receive packets are 0.
Performance impact: with Marvell OCTEON TX2 platform, observed an
improvement by ~14%.
Signed-off-by: Rahul Bhansali
---
examples/l2fwd/main.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/examples/l2fwd/m
On 5/25/22 06:14, Robin Zhang wrote:
Add a new telemetry command /ethdev/module_eeprom to dump the module
EEPROM of each port. The format of module EEPROM information follows
the SFF(Small Form Factor) Committee specifications.
Please, add SFF to devtools/words-case.txt
Signed-off-by: Robin
Summary must not be a statement.
Consider: "add common code for different SFF specs" or
something like this.
On 5/25/22 06:14, Robin Zhang wrote:
This patch implements SFF-8024 Rev 4.0 of pluggable I/O configuration
"This patch implements" -> "Add support for"
Basicaly "This patches" does no
The AltiVec header file is defining "vector", except in C++ build.
The keyword "vector" may conflict easily.
As a rule, it is better to use the alternative keyword "__vector".
The DPDK header file rte_altivec.h takes care of undefining "vector",
so the applications and dependencies are free to def
Consider: "support SFF-8079 module information telemetry"
(if it fits in required number of symbols)
On 5/25/22 06:14, Robin Zhang wrote:
This patch implements format module EEPROM information for
SFF-8079 Rev 1.7
Add support for module EEPROM information format defined in
SFF-8079 Rev 1.7.
On Wed, May 25, 2022 at 11:53:07AM +0200, Thomas Monjalon wrote:
> The AltiVec header file is defining "vector", except in C++ build.
> The keyword "vector" may conflict easily.
> As a rule, it is better to use the alternative keyword "__vector".
>
> The DPDK header file rte_altivec.h takes care o
Hi Brian,
Thanks for the RFC and PFA inline my comments.
> -Original Message-
> From: Brian Dooley
> Sent: Friday, May 20, 2022 9:36 PM
> To: dev@dpdk.org
> Cc: Akhil Goyal ; Gowrishankar Muthukrishnan
> ; Brian Dooley ; Fan
> Zhang
> Subject: [EXT] [RFC] examples/fips_validation: add fi
Changes adds telemetry support to display memory occupancy
in memseg and the information of the elements allocated from
a memseg based on arguments provided by user. This patch
adds following endpoints:
1. /eal/memseg_list_array
The command displays the memseg list from which the memory
has been a
Changes adds telemetry support to display system memory information,
allocated using calls malloc, calloc, mmap, etc. This patch
is based on malloc_info. This patch adds following endpoints:
1. /sysmem/sys_heap_list
The commands displays the arenas currently in use.
Example:
--> /sysmem/sys_heap_l
25/04/2022 10:30, Thomas Monjalon:
> 10/04/2022 23:35, Dmitry Kozlyuk:
> > Whether it is allowed to call Rx/Tx functions for a stopped queue
> > was undocumented. Some PMDs make this behavior a no-op
> > either by explicitly checking the queue state
> > or by the way how their routines are implemen
During EAL init, all buses are probed and the devices found are
initialized. On eal_cleanup(), the inverse does not happen, meaning any
allocated memory and other configuration will not be cleaned up
appropriately on exit.
Currently, in order for device cleanup to take place, applications must
cal
12/04/2022 07:41, Singh, Aman Deep:
> On 4/11/2022 2:01 AM, Dmitry Kozlyuk wrote:
> >> From: Dmitry Kozlyuk
> >> Sent: Thursday, March 31, 2022 1:57 AM
> >> [...]
> >>> From: Singh, Aman Deep
> >>> Sent: Wednesday, March 30, 2022 5:24 PM
> >>> [...]
> >>> On 3/7/2022 10:18 PM, Dmitry Kozlyuk wrot
> -Original Message-
> From: Konstantin Ananyev
> Sent: Wednesday, May 25, 2022 4:30 AM
> To: Rahul Bhansali ; dev@dpdk.org; Radu Nicolau
> ; Akhil Goyal ; Ruifeng Wang
>
> Cc: Jerin Jacob Kollanukkaran
> Subject: [EXT] Re: [PATCH] examples/ipsec-secgw: add support of NEON with
> poll
> -Original Message-
> From: Thomas Monjalon
> Sent: Wednesday, May 25, 2022 12:53 PM
> To: dev@dpdk.org
> Cc: m...@ashroe.eu; david.march...@redhat.com; techbo...@dpdk.org;
> David Christensen
> Subject: [PATCH] eal/ppc: undefine AltiVec keyword vector
>
> The AltiVec header file is def
> -Original Message-
> From: Ali Alnubani
> Sent: Wednesday, May 25, 2022 2:09 PM
> To: Thomas Monjalon ; dev@dpdk.org
> Cc: m...@ashroe.eu; david.march...@redhat.com; techbo...@dpdk.org;
> David Christensen
> Subject: RE: [PATCH] eal/ppc: undefine AltiVec keyword vector
>
> > -Origin
On Wed, May 25, 2022 at 11:39:53AM +0100, Kevin Laatz wrote:
> During EAL init, all buses are probed and the devices found are
> initialized. On eal_cleanup(), the inverse does not happen, meaning any
> allocated memory and other configuration will not be cleaned up
> appropriately on exit.
>
> Cu
Thomas Monjalon writes:
> The AltiVec header file is defining "vector", except in C++ build.
> The keyword "vector" may conflict easily.
> As a rule, it is better to use the alternative keyword "__vector".
>
> The DPDK header file rte_altivec.h takes care of undefining "vector",
> so the applic
Stephen Hemminger writes:
> The PIE code and other applications can benefit from having a
> fast way to get a random floating point value. This new function
> is equivalent to erand48_r in the standard library.
>
> Signed-off-by: Stephen Hemminger
> ---
> app/test/test_rand_perf.c
On 5/25/22 06:14, Robin Zhang wrote:
This patch implements format module EEPROM information for
SFF-8472 Rev 12.0
Signed-off-by: Robin Zhang
[snip]
diff --git a/lib/ethdev/sff_8472.c b/lib/ethdev/sff_8472.c
new file mode 100644
index 00..98e31e9262
--- /dev/null
+++ b/lib/ethdev/sff
On 5/25/22 06:14, Robin Zhang wrote:
This patch implements format module EEPROM information for
SFF-8636 Rev 2.7
Signed-off-by: Robin Zhang
[snip]
diff --git a/lib/ethdev/sff_8636.c b/lib/ethdev/sff_8636.c
new file mode 100644
index 00..ad625fc73b
--- /dev/null
+++ b/lib/ethdev/sff_
> Allowing auth generation followed by encryption mode.
> --optype auth-then-cipher can take cipher-op as encrypt
> and auth-op as generate now.
>
> Signed-off-by: Tejasree Kondoj
Acked-by: Akhil Goyal
> -Original Message-
> From: sk...@marvell.com
> Sent: Tuesday, May 24, 2022 8:36 AM
> To: Li, Xiaoyun ; Singh, Aman Deep
> ; Zhang, Yuying ;
> Dumitrescu, Cristian
> Cc: dev@dpdk.org; Sunil Kumar Kori
> Subject: [PATCH v2 1/1] app/testpmd: support different input color method
>
> Fr
On 5/24/22 11:18, Thomas Monjalon wrote:
24/05/2022 04:50, Spike Du:
From: Thomas Monjalon
23/05/2022 05:01, Spike Du:
From: Stephen Hemminger
Spike Du wrote:
--- a/lib/ethdev/rte_ethdev.h
+++ b/lib/ethdev/rte_ethdev.h
@@ -1249,7 +1249,16 @@ struct rte_eth_rxconf {
*/
union
> -Original Message-
> From: Morten Brørup
> Sent: Wednesday, May 25, 2022 3:00 AM
> To: NBU-Contact-Thomas Monjalon (EXTERNAL) ;
> Spike Du
> Cc: Matan Azrad ; Slava Ovsiienko
> ; Ori Kam ; dev@dpdk.org;
> Raslan Darawsheh ; step...@networkplumber.org;
> andrew.rybche...@oktetlabs.ru;
Hi Nicolas,
On 5/24/22 02:08, Nicolas Chautru wrote:
Adding companion function specific to ACC100 and it
can be called from bbdev-test when running from PF.
Signed-off-by: Nicolas Chautru
---
app/test-bbdev/test_bbdev_perf.c | 22 ++-
drivers/baseband/acc100/rte_acc100_cfg.h | 17
> From: Spike Du [mailto:spi...@nvidia.com]
> Sent: Wednesday, 25 May 2022 15.15
>
> > From: Morten Brørup
> > Sent: Wednesday, May 25, 2022 3:00 AM
> >
> > > From: Thomas Monjalon [mailto:tho...@monjalon.net]
> > > Sent: Tuesday, 24 May 2022 17.59
> > >
> > > +Cc people involved in previous vers
25/05/2022 14:59, Andrew Rybchenko:
> On 5/24/22 11:18, Thomas Monjalon wrote:
> > 24/05/2022 04:50, Spike Du:
> >> From: Thomas Monjalon
> >>> 23/05/2022 05:01, Spike Du:
> From: Stephen Hemminger
> > Spike Du wrote:
> >> --- a/lib/ethdev/rte_ethdev.h
> >> +++ b/lib/ethdev/rte_
Fix the UDP header fields, wrong byte order used for src and dst port
and wrong offset used when updating UDP datagram length.
Fixes: 01eef5907fc3 ("ipsec: support NAT-T")
Cc: sta...@dpdk.org
Signed-off-by: Radu Nicolau
---
lib/ipsec/esp_outb.c | 2 +-
lib/ipsec/sa.c | 4 ++--
2 files cha
Use the proper IP protocol (UDP instead of ESP) and set the ports when
UDP encapsulation is enabled.
Fixes: 9ae86b4cfc77 ("examples/ipsec-secgw: support UDP encap for inline
crypto")
Cc: sta...@dpdk.org
Signed-off-by: Radu Nicolau
---
examples/ipsec-secgw/sa.c | 6 --
1 file changed, 4 ins
Correct the length calculation used for NAT-T
Fixes: 6bc987ecb860 ("net/iavf: support IPsec inline crypto")
Cc: sta...@dpdk.org
Signed-off-by: Radu Nicolau
---
drivers/net/iavf/iavf_ipsec_crypto.c | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/drivers/net/iavf/i
> -Original Message-
> From: Morten Brørup
> Sent: Wednesday, May 25, 2022 9:40 PM
> To: Spike Du ; NBU-Contact-Thomas Monjalon
> (EXTERNAL)
> Cc: Matan Azrad ; Slava Ovsiienko
> ; Ori Kam ; dev@dpdk.org;
> Raslan Darawsheh ; step...@networkplumber.org;
> andrew.rybche...@oktetlabs.ru;
On 5/24/22 22:22, Thomas Monjalon wrote:
24/05/2022 21:00, Morten Brørup:
From: Thomas Monjalon [mailto:tho...@monjalon.net]
24/05/2022 17:20, Spike Du:
LWM(limit watermark) is per RX queue attribute, when RX queue
fullness reach the LWM limit, HW sends an event to dpdk application.
Please
> From: Spike Du [mailto:spi...@nvidia.com]
> Sent: Wednesday, 25 May 2022 15.59
>
> > From: Morten Brørup
> > Sent: Wednesday, May 25, 2022 9:40 PM
> >
> > > From: Spike Du [mailto:spi...@nvidia.com]
> > > Sent: Wednesday, 25 May 2022 15.15
> > >
> > > > From: Morten Brørup
> > > > Sent: Wednes
Hi Cristian,
Oh .. you absolutely right. I did not found them all .. I've missed them in
all unneeded lines when you reply to full source code in message. I'll add
changes from rest of the comments asap.
BR,
/Marcin
-Original Message-
From: Dumitrescu, Cristian
Sent: Tuesday, May 2
On 5/25/22 16:58, Thomas Monjalon wrote:
25/05/2022 14:59, Andrew Rybchenko:
On 5/24/22 11:18, Thomas Monjalon wrote:
24/05/2022 04:50, Spike Du:
From: Thomas Monjalon
23/05/2022 05:01, Spike Du:
From: Stephen Hemminger
Spike Du wrote:
--- a/lib/ethdev/rte_ethdev.h
+++ b/lib/ethdev/rte_
On 5/25/22 17:16, Morten Brørup wrote:
From: Spike Du [mailto:spi...@nvidia.com]
Sent: Wednesday, 25 May 2022 15.59
From: Morten Brørup
Sent: Wednesday, May 25, 2022 9:40 PM
From: Spike Du [mailto:spi...@nvidia.com]
Sent: Wednesday, 25 May 2022 15.15
From: Morten Brørup
Sent: Wednesday, M
> -Original Message-
> From: Dumitrescu, Cristian
> Sent: Wednesday, May 25, 2022 6:07 PM
> To: Sunil Kumar Kori ; Li, Xiaoyun
> ; Singh, Aman Deep ;
> Zhang, Yuying
> Cc: dev@dpdk.org
> Subject: [EXT] RE: [PATCH v2 1/1] app/testpmd: support different input color
> method
>
> External
On 5/24/22 02:08, Nicolas Chautru wrote:
The validation requirement is different for the two
devices.
Signed-off-by: Nicolas Chautru
---
drivers/baseband/acc100/rte_acc100_pmd.c | 47
1 file changed, 35 insertions(+), 12 deletions(-)
diff --git a/drivers/
> -Original Message-
> From: Min Hu (Connor)
> Subject: [PATCH v2] app/procinfo: add devcie private info dump
Typo: device*
> +static void
> +show_port_private_info(void)
> +{
> + int i;
> +
> + snprintf(bdr_str, MAX_STRING_LEN, " show - Port PMD Private ");
Better to have h
From: Sunil Kumar Kori
To enable input coloring, based on VLAN or DSCP, patch adds
command line interface to configure the following:
- configuring input coloring using VLAN or DSCP while creating
meter i.e. during rte_mtr_create()
- Update VLAN input coloring table at runtime.
- configu
> -Original Message-
> From: sk...@marvell.com
> Sent: Wednesday, May 25, 2022 3:37 PM
> To: Li, Xiaoyun ; Singh, Aman Deep
> ; Zhang, Yuying ;
> Dumitrescu, Cristian
> Cc: dev@dpdk.org; Sunil Kumar Kori
> Subject: [PATCH v2 1/1] app/testpmd: support different input color method
>
>
On 2022-05-25 00:18, Stephen Hemminger wrote:
> The PIE code and other applications can benefit from having a
> fast way to get a random floating point value. This new function
> is equivalent to erand48_r in the standard library.
>
Seems like a good addition to the API.
> Signed-off-by: Stephen
> -Original Message-
> From: Zhang, Qi Z
> Sent: Monday, May 23, 2022 7:22 PM
> To: Jeff Daly ; Thomas Monjalon
> ; dev@dpdk.org
> Cc: Stephen Douthit ; Yang, Qiming
> ; Wu, Wenjun1
> Subject: RE: [PATCH] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the X550
> devices
>
> Caution: This is
> From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com]
> Sent: Wednesday, 25 May 2022 16.46
>
> On 2022-05-25 00:18, Stephen Hemminger wrote:
> > The PIE code and other applications can benefit from having a
> > fast way to get a random floating point value. This new function
> > is equiv
25/05/2022 13:48, Ray Kinsella:
>
> Thomas Monjalon writes:
>
> > The AltiVec header file is defining "vector", except in C++ build.
> > The keyword "vector" may conflict easily.
> > As a rule, it is better to use the alternative keyword "__vector".
> >
> > The DPDK header file rte_altivec.h tak
On Wed, 25 May 2022 14:45:37 +
Mattias Rönnblom wrote:
> On 2022-05-25 00:18, Stephen Hemminger wrote:
> > The PIE code and other applications can benefit from having a
> > fast way to get a random floating point value. This new function
> > is equivalent to erand48_r in the standard library.
Adds a very basic introduction to JSON vector sets in
the fips validation example application. This patch set
will only introduce the AES-GCM test using a JSON request
file because the other algorithms need more information
than what is given in the new JSON format.
v5:
* AES_CBC support appended
From: Brandon Lo
Added a check for RTE_HAS_JANSSON into the meson
configuration file for JSON support.
Signed-off-by: Brandon Lo
---
examples/fips_validation/meson.build | 4
1 file changed, 4 insertions(+)
diff --git a/examples/fips_validation/meson.build
b/examples/fips_validation/mes
From: Brandon Lo
Added json-specific functions and other information needed to
test the new FIPS test vectors.
Signed-off-by: Brandon Lo
Signed-off-by: Gowrishankar Muthukrishnan
---
v5:
* fix typo in macro name for prefixes.
v2:
* fix type of prefix to suffix
---
examples/fips_validation/fi
From: Brandon Lo
Added functions to parse the required information from a vector set
given in the new json format.
Signed-off-by: Brandon Lo
---
v3:
* fix checkpatch warnings
v2:
* fix for loop initialization
---
examples/fips_validation/fips_validation.c | 92 ++
1 file c
From: Brandon Lo
Added the ability to use the json format as the input
and output of the example application.
Signed-off-by: Brandon Lo
Signed-off-by: Gowrishankar Muthukrishnan
--
v5:
* fix to check info.file_type in json file type as well.
v3:
* fix checkpatch warnings
v2:
* remove use_jso
From: Brandon Lo
Adds json-specific testing and writeback function. Allows
the user to test AES-GCM vector sets.
Signed-off-by: Brandon Lo
---
v3:
* fix checkpatch warnings
---
examples/fips_validation/fips_validation.h| 3 +
.../fips_validation/fips_validation_gcm.c | 151 ++
From: Brandon Lo
Adds JSON support for the HMAC algorithm.
Signed-off-by: Brandon Lo
---
examples/fips_validation/fips_validation.c| 2 +
examples/fips_validation/fips_validation.h| 6 ++
.../fips_validation/fips_validation_hmac.c| 93 +++
examples/fips_validation
From: Brandon Lo
Implemented JSON support for the CMAC test.
Signed-off-by: Brandon Lo
--
v5:
* parser_read_cmac_direction_str is static.
---
examples/fips_validation/fips_validation.h| 3 +
.../fips_validation/fips_validation_cmac.c| 80 +++
2 files changed, 83 insert
07/03/2022 13:53, Dmitry Kozlyuk:
> Calling Rx/Tx functions on a stopped queue is not supported.
> Do not run packet forwarding for streams that use stopped queues.
>
> Each stream has a read-only "disabled" field,
> so that lcore function can skip such streams.
> Forwarding engines can set this f
From: Brandon Lo
Added function to parse algorithm for CMAC test.
Signed-off-by: Brandon Lo
Signed-off-by: Gowrishankar Muthukrishnan
--
v5:
* parser_read_cmac_direction_str implementation moved to static.
---
examples/fips_validation/fips_validation.c | 19 ---
examples/fips_
Remove garbage entries for bypassed tests in response file.
Signed-off-by: Gowrishankar Muthukrishnan
---
examples/fips_validation/main.c | 74 -
1 file changed, 35 insertions(+), 39 deletions(-)
diff --git a/examples/fips_validation/main.c b/examples/fips_valida
Reset IV generation in every test group.
Signed-off-by: Gowrishankar Muthukrishnan
---
examples/fips_validation/fips_validation_gcm.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/examples/fips_validation/fips_validation_gcm.c
b/examples/fips_validation/fips_validation_gcm.c
index 3604b21
Added function to parse algorithm for AES_CBC test.
Signed-off-by: Gowrishankar Muthukrishnan
---
examples/fips_validation/fips_validation.c| 8 +-
examples/fips_validation/fips_validation.h| 4 +
.../fips_validation/fips_validation_aes.c | 223 ++
examples/fips_v
On Wed, 25 May 2022 14:45:37 +
Mattias Rönnblom wrote:
> I would call it something else than "float", in particular since it
> doesn't return "float" but a "double" type floating point value.
>
> rte_drand() maybe? Short, but might be confused with rte_rand(), given
> the visual similarity
Since openssl 3.0 now deprecates the low level API QAT required to
perform partial hash & aes operation when creating the session. This
patch add in qat_ipsec_mb_lib driver parameter to allow QAT PMD to
switch APIs between openssl and intel ipsec-mb library.
Signed-off-by: Kai Ji
Signed-off-by: F
> -Original Message-
> From: Zhang, Qi Z
> Sent: Wednesday, May 11, 2022 9:27 PM
> To: Jeff Daly ; dev@dpdk.org
> Cc: sta...@dpdk.org; Stephen Douthit
> Subject: RE: [PATCH v6 2/2] net/ixgbe: Fix SFP detection and linking on
> hotplug
>
> Caution: This is an external email. Please tak
This patchset introduces some of changes discussed on mailing list for 22.07
release in cryptodev asym.
Key changes:
- It fixes API for RSA (expescially signature paddings)
- Adds Elliptic-Curve Diffie-Hellman
- Adds Eliiptic-Curve point verification
- Adds RSA missing padding fields
- Adds asym
- EC enum was renamed to rte_crypto_curve_id.
Elliptic curve enum name was incorrectly associated
with group (it comes from current tls registry name).
- Clarified comments about TLS deprecation.
Some curves included are deprecated with TLS 1.3.
Comments to address it were added.
- Clarified FFDH g
- Reduced number of comments in asymmetric xform.
Information describing basic functionality of well known
algorithms are unnecessary.
- Removed NONE asymetric xform.
Signed-off-by: Arek Kusztal
---
app/test/test_cryptodev_asym.c | 2 -
lib/cryptodev/rte_crypto_asym.h | 114 --
- Separated key exchange enum from asym op type.
Key exchange and asymmetric crypto operations like signatures,
encryption/decryption should not share same operation enum as
its use cases are unrelated and mutually exclusive.
Therefore op_type was separate into:
1) operation type
2) key exchange op
- Removed comment that stated dsa can be used with Diffie
Hellman ephemeral key.
DH and DSA integration allowed to use ephemeral keys for
random integer but not for private keys.
Signed-off-by: Arek Kusztal
---
lib/cryptodev/rte_crypto_asym.h | 8 +---
1 file changed, 1 insertion(+), 7 delet
- Clarified usage of private key in Diffie-Hellman.
CSRNG capable device should generate private key and then
use it for public key generation.
Signed-off-by: Arek Kusztal
---
lib/cryptodev/rte_crypto_asym.h | 5 +
1 file changed, 5 insertions(+)
diff --git a/lib/cryptodev/rte_crypto_asym.h
- Moved dh operation type to dh operation struct.
Operation type (PUBLIC_KEY_GENERATION, SHARED_SECRET) should
be free to choose for any operation. One xform/session should
be enough to perform both DH operations, if op_type would be xform
member, session would have to be to be created twice for th
- Added elliptic curve Diffie-Hellman parameters.
Point multiplication allows the user to process every phase of
ECDH, but for phase 1, user should not really care about the generator.
The user does not even need to know what the generator looks like,
therefore setting ec xform would make this work
- Added key exchange public key verify option.
For some elliptic curves public point in DH exchange
needs to be checked, if it lays on the curve.
Modular exponentiation needs certain checks as well, though
mathematically much easier.
This commit adds verify option to asym_op operations.
Signed-off
- Added flags to rte_crypto_asym_op struct.
It may be shared between different algorithms.
- Added Diffie-Hellman padding flags.
Diffie-Hellman padding is used in certain protocols,
in others, leading zero bytes need to be stripped.
Even same protocol may use a different approach - most
glaring exa
- Clarified usage of RSA padding hash.
It was not specified how to use hash for PKCS1_5
padding. This could lead to incorrect implementation.
Signed-off-by: Arek Kusztal
---
lib/cryptodev/rte_crypto_asym.h | 25 +
1 file changed, 21 insertions(+), 4 deletions(-)
diff --g
- move RSA padding into separate struct.
More padding members should be added into padding,
therefore having separate struct for padding parameters will
make this more readable.
Signed-off-by: Arek Kusztal
---
app/test/test_cryptodev_asym.c | 10 ++--
drivers/common/cpt/cpt_ucode_as
- Clarified where should output be stored of signature
decryption with padding none.
PMD is not able to know what padding algorithm was used,
therefore decrypted signature should be returned to the user.
Signed-off-by: Arek Kusztal
---
lib/cryptodev/rte_crypto_asym.h | 7 ++-
1 file changed,
- Added salt length and optional label.
Common parameters to PSS and OAEP padding for RSA.
- Fixed hash API in RSA padding.
Now it is specified how hash should be used with
particular RSA padding modes.
Signed-off-by: Arek Kusztal
---
lib/cryptodev/rte_crypto_asym.h | 19 +--
1 f
- Added asymmetric crypto algorithm specific capability struct.
Included fields like random number capability, padding flags etc.
Signed-off-by: Arek Kusztal
---
app/test-crypto-perf/main.c | 12 +-
app/test-eventdev/test_perf_common.c | 2 +-
app/test/test_cryptodev_
Added function to parse algorithm for AES_CBC test.
Signed-off-by: Gowrishankar Muthukrishnan
---
examples/fips_validation/fips_validation.c| 8 +-
examples/fips_validation/fips_validation.h| 4 +
.../fips_validation/fips_validation_aes.c | 223 ++
examples/fips_v
Hello,
I recently wrapped up the conversion from makefiles to meson on another
project and while everything seems functional, if there is anyone that has
experience with meson/time/interest, I would appreciate some more eyes on
this change. For the change, most things were modeled off of how DPDK
Introduce a new random number function to get a floating
point value. Then use it to fix PIE scheduler.
v3
- rename to rte_drand() and other review feedback
- fix warnings with some compilers in test code
Stephen Hemminger (3):
random: add rte_drand() funciton
rte_pie: remove unnecessar
The PIE code and other applications can benefit from having a
fast way to get a random floating point value. This new function
is equivalent to drand() in the standard library.
Signed-off-by: Stephen Hemminger
---
app/test/test_rand_perf.c | 7 +++
doc/guides/rel_notes/release_
The qdelay variable is derived from and compared to 64 bit
value so it doesn't have to be floating point.
Fixes: 44c730b0e379 ("sched: add PIE based congestion management")
Cc: wojciechx.liguzin...@intel.com
Signed-off-by: Stephen Hemminger
---
lib/sched/rte_pie.h | 2 +-
1 file changed, 1 inser
The function rte_pie_drop was attempting to do a random probability
drop, but because of incorrect usage of fixed point divide
it would always return 1.
Change to use new rte_drand() instead.
Fixes: 44c730b0e379 ("sched: add PIE based congestion management")
Cc: wojciechx.liguzin...@intel.com
Sig
Hi Andrew,
>> Extended interrupt structures, required implementation for additional number
>> of queues
It is about Vmxnet3_IntrConfExt.
Vmxnet3_IntrConfExt is a control data structure shared with ESX.
ESX introduced it for this version to increase the number of queues that can be
used.
Vmxnet3
Adds a very basic introduction to JSON vector sets in
the fips validation example application. This patch set
will only introduce the AES-GCM test using a JSON request
file because the other algorithms need more information
than what is given in the new JSON format.
v6:
* CI centos platform fix.
From: Brandon Lo
Added a check for RTE_HAS_JANSSON into the meson
configuration file for JSON support.
Signed-off-by: Brandon Lo
---
examples/fips_validation/meson.build | 4
1 file changed, 4 insertions(+)
diff --git a/examples/fips_validation/meson.build
b/examples/fips_validation/mes
From: Brandon Lo
Added json-specific functions and other information needed to
test the new FIPS test vectors.
Signed-off-by: Brandon Lo
Signed-off-by: Gowrishankar Muthukrishnan
---
v5:
* fix typo in macro name for prefixes.
v2:
* fix type of prefix to suffix
---
examples/fips_validation/fi
From: Brandon Lo
Added functions to parse the required information from a vector set
given in the new json format.
Signed-off-by: Brandon Lo
---
v3:
* fix checkpatch warnings
v2:
* fix for loop initialization
---
examples/fips_validation/fips_validation.c | 92 ++
1 file c
1 - 100 of 150 matches
Mail list logo
