> From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com]
> Sent: Sunday, 10 April 2022 15.52
>
> This patch adds a wrapper macro __rte_warn_unused_result for the
> warn_unused_result function attribute.
>
> Marking a function __rte_warn_unused_result will make the compiler
> emit a warning
On Fri, Apr 8, 2022 at 3:46 PM Tyler Retzlaff
wrote:
>
> On Fri, Apr 08, 2022 at 10:57:55AM +0200, David Marchand wrote:
> > Hello Tyler,
> >
> > On Fri, Apr 1, 2022 at 3:30 PM Tyler Retzlaff
> > wrote:
> > >
> > > this series provides basic dependencies for additional eal thread api
> > > additi
> -Original Message-
> From: Thomas Monjalon
> Sent: Thursday, April 7, 2022 9:34 AM
> To: Juraj Linkeš
> Cc: Jerin Jacob ; David Marchand
> ; Honnappa Nagarahalli
> ; ohily...@iol.unh.edu; Tu, Lijuan
> ; dpdk-dev
> Subject: Re: [RFC PATCH v1 00/15] merge DTS core files to DPDK
>
> 07
Hi Bruce,
> -Original Message-
> From: Richardson, Bruce
> Sent: Friday, April 8, 2022 7:27 PM
> To: Zhang, RobinX
> Cc: dev@dpdk.org; Yang, Qiming ; Zhang, Qi Z
> ; Yang, SteveX
> Subject: Re: [PATCH v2] common/sff_module: add telemetry command to
> dump module EEPROM
>
> On Fri, Apr
On Mon, Apr 11, 2022 at 12:35:50AM +0300, Dmitry Kozlyuk wrote:
> Whether it is allowed to call Rx/Tx functions for a stopped queue
> was undocumented. Some PMDs make this behavior a no-op
> either by explicitly checking the queue state
> or by the way how their routines are implemented or HW works
On Fri, Jul 09, 2021 at 08:33:28PM +0200, Thomas Monjalon wrote:
> Hi,
>
> I would like to open a discussion about RHEL 7 support in DPDK.
> How long do we want to support it in new DPDK versions?
> Can we drop RHEL 7 support starting DPDK 21.11?
did this thread/question ever reach conclusion?
>
l3fwd-acl contains duplicate functions to l3fwd.
For this reason we merge l3fwd-acl code into l3fwd
with '--lookup acl' cmdline option to run ACL.
Signed-off-by: Sean Morrissey
---
V5:
* remove undefined functions
* remove unused struct members
V4:
* update maintainers
* fix doc changes
V3:
* rem
If the VMDQ limits is 0, a divide-by-zero error occurs.
This patch replaces throwing a floating point exception with
a normal error message.
Signed-off-by: Yuan Wang
---
examples/vhost/main.c | 4
1 file changed, 4 insertions(+)
diff --git a/examples/vhost/main.c b/examples/vhost/main.c
in
On Mon, Apr 11, 2022 at 01:23:13AM -0700, Tyler Retzlaff wrote:
> On Fri, Jul 09, 2021 at 08:33:28PM +0200, Thomas Monjalon wrote:
> > Hi,
> >
> > I would like to open a discussion about RHEL 7 support in DPDK.
> > How long do we want to support it in new DPDK versions?
> > Can we drop RHEL 7 supp
On Mon, Apr 11, 2022 at 09:13:47AM +0100, Zhang, RobinX wrote:
> Hi Bruce,
>
> > -Original Message-
> > From: Richardson, Bruce
> > Sent: Friday, April 8, 2022 7:27 PM
> > To: Zhang, RobinX
> > Cc: dev@dpdk.org; Yang, Qiming ; Zhang, Qi Z
> > ; Yang, SteveX
> > Subject: Re: [PATCH v2] c
On Sun, Apr 10, 2022 at 03:51:38PM +0200, Mattias Rönnblom wrote:
> This patch adds a wrapper macro __rte_warn_unused_result for the
> warn_unused_result function attribute.
>
> Marking a function __rte_warn_unused_result will make the compiler
> emit a warning in case the caller does not use the
On Mon, Apr 11, 2022 at 10:56:34AM +0800, Chengwen Feng wrote:
> This patch adds minimal copy size parameter(-m/--min-copy-size), so
> when do copy by CPU or DMA, the real copy size will be the maximum of
> mbuf's data_len and this parameter.
>
> This parameter was designed to compare the performa
From: Xuan Ding
The presence of asynchronous path allows applications to offload memory
copies to DMA engine, so as to save CPU cycles and improve the copy
performance. This patch set implements vhost async dequeue data path
for split ring. The code is based on latest enqueue changes [1].
This p
From: Xuan Ding
This patch extracts the descriptors to buffers filling from
copy_desc_to_mbuf() into a dedicated function. Besides, enqueue
and dequeue path are refactored to use the same function
sync_fill_seg() for preparing batch elements, which simplifies
the code without performance degradat
From: Xuan Ding
This patch refactors vhost async enqueue path and dequeue path to use
the same function async_fill_seg() for preparing batch elements,
which simplifies the code without performance degradation.
Signed-off-by: Xuan Ding
---
lib/vhost/virtio_net.c | 23 +++
1
From: Xuan Ding
This patches refactors copy_desc_to_mbuf() used by the sync
path to support both sync and async descriptor to mbuf filling.
Signed-off-by: Xuan Ding
---
lib/vhost/vhost.h | 1 +
lib/vhost/virtio_net.c | 48 --
2 files changed, 38 in
From: Xuan Ding
This patch implements asynchronous dequeue data path for vhost split
ring, a new API rte_vhost_async_try_dequeue_burst() is introduced.
Signed-off-by: Xuan Ding
Signed-off-by: Yuan Wang
---
doc/guides/prog_guide/vhost_lib.rst| 7 +
doc/guides/rel_notes/release_22_07.rst
From: Xuan Ding
This patch adds the use case for async dequeue API. Vswitch can
leverage DMA device to accelerate vhost async dequeue path.
Signed-off-by: Wenwu Ma
Signed-off-by: Yuan Wang
Signed-off-by: Xuan Ding
---
doc/guides/sample_app_ug/vhost.rst | 9 +-
examples/vhost/main.c
> -Original Message-
> From: Kevin Traynor
> Sent: Friday, April 1, 2022 1:22 PM
> To: sta...@dpdk.org
> Cc: dev@dpdk.org; Abhishek Marathe ;
> Ali Alnubani ; benjamin.wal...@intel.com; David
> Christensen ;
> hariprasad.govindhara...@intel.com; Hemant Agrawal
> ; Ian Stokes ; Jerin
> Jaco
vhost internals involves multiple locks to protect data access by
multiple threads.
This series is a try at using clang thread safety checks [1] to catch
issues during compilation: EAL spinlock and rwlock are annotated and
vhost code is instrumented so that clang can statically check
correctness.
clang offers some thread safety checks, statically verifying that locks
are taken and released in the code.
To use those checks, the full code leading to taking or releasing locks
must be annotated with some attributes.
Wrap those attributes into our own set of macros.
rwlock and the "normal" spi
This change simply annotates existing paths of the code leading to
manipulations of the vq->access_lock.
One small change is required: vhost_poll_enqueue_completed was getting
a queue_id to get hold of the vq, while its callers already knew of
the vq. For the annotation sake, vq is now directly pa
vq->async accesses must be protected with vq->access_lock.
Fixes: eb666d24085f ("vhost: fix async unregister deadlock")
Fixes: 0c0935c5f794 ("vhost: allow to check in-flight packets for async vhost")
Cc: sta...@dpdk.org
Signed-off-by: David Marchand
Acked-by: Sunil Pai G
---
lib/vhost/vhost.c
vq->async is initialised and must be accessed under vq->access_lock.
Top level "_thread_unsafe" functions could be checked at runtime (clang
provides a lock aware assert()-like check), but they are simply skipped
because those functions are not called in-tree, and as a result,
their annotations wo
When a reply from the slave is required (VHOST_USER_NEED_REPLY flag),
a spinlock is taken before sending the message.
This spinlock is released if an error occurs when sending the message, and
once a reply is received.
A problem is that this lock is taken under a branch and annotating
conditionall
vdpa_device_list access must be protected with vdpa_device_list_lock
spinlock.
Signed-off-by: David Marchand
---
lib/vhost/vdpa.c | 17 ++---
1 file changed, 10 insertions(+), 7 deletions(-)
diff --git a/lib/vhost/vdpa.c b/lib/vhost/vdpa.c
index 8fa2153023..a3f9f8f072 100644
--- a/l
This change simply annotates existing paths of the code leading to
manipulations of the IOTLB r/w locks.
clang does not support conditionally held locks, so always take iotlb
locks regardless of VIRTIO_F_IOMMU_PLATFORM feature.
vdpa and vhost_crypto code are annotated though they end up not takin
Now that all locks in this library are annotated, we can enable the
check.
Signed-off-by: David Marchand
---
lib/vhost/meson.build | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/vhost/meson.build b/lib/vhost/meson.build
index bc7272053b..197a51d936 100644
--- a/lib/vhost/meson.build
+
Please review and let me know if any comments.
From: Shijith Thotton
Sent: Tuesday, April 5, 2022 11:10 AM
To: dev@dpdk.org ; Jerin Jacob Kollanukkaran
Cc: Shijith Thotton ; Pavan Nikhilesh Bhagavatula
; harry.van.haa...@intel.com
; mattias.ronnb...@ericsson.com
On Sun, Apr 10, 2022 at 3:53 PM Mattias Rönnblom
wrote:
>
> The conditional rte_spinlock_trylock() was used as if it is an
> unconditional lock operation in a number of places.
>
> Fixes: cc7e8ae84faa ("examples/bond: add example application for link bonding
> mode 6")
> Cc: michalx.k.jastrzeb...
>
> l3fwd-acl contains duplicate functions to l3fwd.
> For this reason we merge l3fwd-acl code into l3fwd
> with '--lookup acl' cmdline option to run ACL.
>
> Signed-off-by: Sean Morrissey
> ---
> V5:
> * remove undefined functions
> * remove unused struct members
> V4:
> * update maintainers
>
On 2022-04-11 11:16, Bruce Richardson wrote:
> On Sun, Apr 10, 2022 at 03:51:38PM +0200, Mattias Rönnblom wrote:
>> This patch adds a wrapper macro __rte_warn_unused_result for the
>> warn_unused_result function attribute.
>>
>> Marking a function __rte_warn_unused_result will make the compiler
>>
On Fri, Apr 8, 2022 at 3:17 AM wrote:
>
> From: Owen Hilyard
>
> Currently, DTS uses Testpmd for most of its testing. This has been
> successful in reducing the need to create more test apps, but it has a few
> drawbacks. First, if some part of DPDK is not exposed via Testpmd or one of
> t
On 2022-04-11 09:17, Morten Brørup wrote:
>> From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com]
>> Sent: Sunday, 10 April 2022 15.52
>>
>> This patch adds a wrapper macro __rte_warn_unused_result for the
>> warn_unused_result function attribute.
>>
>> Marking a function __rte_warn_unused
On 2022-04-11 03:01, Min Hu (Connor) wrote:
> Acked-by: Min Hu (Connor)
>
Thanks.
It was pretty obvious that something was wrong with this example's use
of the spinlock, but after the brief look I had it was a little less
obvious if this patch would fix the problem or not.
> 在 2022/4/10 21:5
On 2022-04-11 13:25, David Marchand wrote:
> On Sun, Apr 10, 2022 at 3:53 PM Mattias Rönnblom
> wrote:
>>
>> The conditional rte_spinlock_trylock() was used as if it is an
>> unconditional lock operation in a number of places.
>>
>> Fixes: cc7e8ae84faa ("examples/bond: add example application for
Hi folks,
Thanks to the community colleagues that participated to the call earlier today.
Apologies for not CC-ing all the 9 attendants, as I don't have the email
address for all of them.
We had a good meeting, I think we agreed on a good solution that will also
simplify the API proposal.
Rec
Those optimisations were only enabled with make builds, fix the meson
part.
Fixes: 77d66da83834 ("net/virtio: add vectorized packed ring Rx")
Cc: sta...@dpdk.org
Signed-off-by: David Marchand
---
drivers/net/virtio/meson.build | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --
Mark the trylock family of spinlock functions with
__rte_warn_unused_result.
Acked-by: Bruce Richardson
Signed-off-by: Mattias Rönnblom
---
lib/eal/include/generic/rte_spinlock.h | 4
1 file changed, 4 insertions(+)
diff --git a/lib/eal/include/generic/rte_spinlock.h
b/lib/eal/include/g
The conditional rte_spinlock_trylock() was used as if it is an
unconditional lock operation in a number of places.
Fixes: cc7e8ae84faa ("examples/bond: add example application for link bonding
mode 6")
Cc: michalx.k.jastrzeb...@intel.com
Cc: sta...@dpdk.org
Acked-by: Bruce Richardson
Acked-by:
This patch adds a wrapper macro __rte_warn_unused_result for the
warn_unused_result function attribute.
Marking a function __rte_warn_unused_result will make the compiler
emit a warning in case the caller does not use the function's return
value.
Changes since RFC:
* Include usage recommendatio
> From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com]
> Sent: Monday, 11 April 2022 17.16
>
> This patch adds a wrapper macro __rte_warn_unused_result for the
> warn_unused_result function attribute.
>
> Marking a function __rte_warn_unused_result will make the compiler
> emit a warning
> From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com]
> Sent: Monday, 11 April 2022 17.16
>
> Mark the trylock family of spinlock functions with
> __rte_warn_unused_result.
>
> Acked-by: Bruce Richardson
>
> Signed-off-by: Mattias Rönnblom
> ---
> lib/eal/include/generic/rte_spinloc
>
> scheme is probably over-engineered
I tried my hardest to keep this as simple as possible. The requirements
imposed by DTS being a distributed system in Python restricted what I could
do a lot. Needing to be compatible with DPDK's license also got rid of a
lot of options. Binding generators ar
> >
> > 07/04/2022 07:04, Jerin Jacob:
> > > On Wed, Apr 6, 2022 at 8:26 PM Juraj Linkeš
> > >
> > wrote:
> > > >
>
> First of all, thanks for the feedback. We've already done a bit of a
> pre-review
> and this is where we decided we want the feedback from the rest of the
> community. We under
Use new email address.
Signed-off-by: Ferruh Yigit
---
MAINTAINERS | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 15008c03bcef..7c4f541dbae1 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -28,7 +28,7 @@ M: David Marchand
T: git://dpdk.o
>
> 3) In my private discussions with David Marchand, he expressed interest
> in getting the git log history. The current review process will not help in
> this regard. Is this a must? If yes, are there any known methods to do this?
The git docs point to https://github.com/newren/git-filter-repo
Add support for arguments to the default action of regular and learner
tables at initialization time. Until now, only default actions with no
arguments were accepted in the .spec file.
Signed-off-by: Cristian Dumitrescu
Signed-off-by: Yogesh Jangra
---
lib/pipeline/rte_swx_pipeline.c | 237
On Mon, Apr 11, 2022 at 10:16:35AM +0100, Bruce Richardson wrote:
> On Sun, Apr 10, 2022 at 03:51:38PM +0200, Mattias Rönnblom wrote:
> > This patch adds a wrapper macro __rte_warn_unused_result for the
> > warn_unused_result function attribute.
> >
> > Marking a function __rte_warn_unused_result
>
> On Wed, Apr 6, 2022 at 8:26 PM Juraj Linkeš
> wrote:
> >
> > These are the basic libraries that other libraries depend on. There's
> > also the basic framework functionality related to test execution.
> >
> > Juraj Linkeš (15):
> > dts: merge DTS dep/tclclient.tgz to DPDK
> > dts: merge
2022-04-09 01:56 (UTC-0700), Tyler Retzlaff:
> On Fri, Apr 08, 2022 at 05:01:45PM +0300, Dmitry Kozlyuk wrote:
> > 2022-04-01 06:29 (UTC-0700), Tyler Retzlaff:
> > [...]
> > > +static int
> > > +test_thread_affinity(void)
> > > +{
> > > + pthread_t id;
> > > + rte_thread_t thread_id;
> > > +
> >
From: Beilei Xing
Add Yuying as Intel i40e maintainer.
Signed-off-by: Beilei Xing
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 4ba4c8d67c..e4c5c238e8 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -718,6 +718,7 @@ F: doc/guides/nics/intel_v
On 4/11/2022 2:01 AM, Dmitry Kozlyuk wrote:
Hi Aman,
From: Dmitry Kozlyuk
Sent: Thursday, March 31, 2022 1:57 AM
[...]
From: Singh, Aman Deep
Sent: Wednesday, March 30, 2022 5:24 PM
[...]
On 3/7/2022 10:18 PM, Dmitry Kozlyuk wrote:
When a port was closed, indirect actions could remain
wit
On Mon, Apr 11, 2022 at 11:19 PM Owen Hilyard wrote:
>>
>> scheme is probably over-engineered
>
>
> I tried my hardest to keep this as simple as possible. The requirements
> imposed by DTS being a distributed system in Python restricted what I could
> do a lot. Needing to be compatible with DPDK
From: zhichao zeng
Remove expired experimental symbols.
Signed-off-by: zhichao zeng
---
drivers/net/ixgbe/rte_pmd_ixgbe.h | 20 +---
drivers/net/ixgbe/version.map | 10 +-
2 files changed, 10 insertions(+), 20 deletions(-)
diff --git a/drivers/net/ixgbe/rte_pmd_ixg
Adding some missing guys, that I know about.
Ori
> -Original Message-
> From: Dumitrescu, Cristian
> Sent: Monday, April 11, 2022 5:46 PM
> To: dev@dpdk.org; NBU-Contact-Thomas Monjalon (EXTERNAL)
> ; Andrew
> Rybchenko ; Ray Kinsella
> Cc: Jerin Jacob ; Jerin Jacob ;
> sk...@marvel
56 matches
Mail list logo
