On Fri, Apr 8, 2022 at 3:46 PM Tyler Retzlaff <roret...@linux.microsoft.com> wrote: > > On Fri, Apr 08, 2022 at 10:57:55AM +0200, David Marchand wrote: > > Hello Tyler, > > > > On Fri, Apr 1, 2022 at 3:30 PM Tyler Retzlaff > > <roret...@linux.microsoft.com> wrote: > > > > > > this series provides basic dependencies for additional eal thread api > > > additions. series includes basic error handling, initial get/set thread > > > affinity functions and minimal unit test. > > > > > > Tyler Retzlaff (3): > > > eal/windows: translate Windows errors to errno-style errors > > > eal: implement functions for get/set thread affinity > > > test/threads: add unit test for thread API > > > > > > app/test/meson.build | 2 + > > > app/test/test_threads.c | 86 +++++++++++++++++++ > > > lib/eal/include/rte_thread.h | 45 ++++++++++ > > > lib/eal/unix/rte_thread.c | 16 ++++ > > > lib/eal/version.map | 4 + > > > lib/eal/windows/eal_lcore.c | 173 > > > +++++++++++++++++++++++++++---------- > > > lib/eal/windows/eal_windows.h | 10 +++ > > > lib/eal/windows/include/rte_os.h | 2 + > > > lib/eal/windows/rte_thread.c | 179 > > > ++++++++++++++++++++++++++++++++++++++- > > > 9 files changed, 472 insertions(+), 45 deletions(-) > > > create mode 100644 app/test/test_threads.c > > > > We have two concurrent series, can you clarify what are the intentions > > on this work? > > yes, i should have clarified this up front sorry. > > > Is this series superseding Narcisa series? > > this series supersedes the series from Narcisa. it was resolved through > discussion that the current series should be abandoned as it is too > large and not making progress. > > we've elected to submit a series of smaller patchsets that incorporate > the feedback received to date and build up the api surface for > threading. the patches are still the work of Narcisa but she is > overscheduled so i will assist in upstreaming and addressing feedback. > > additionally, rather than port the tree to the new __experimental api as > they are added we will prefer to add unit tests that provide validation > of the api and example usage. > > our hope is the smaller scoped series will attract more attention and > have better acknowledgement velocity. > > i will have Narcisa mark the monolithic series as superseded on > patchwork.
Ok, thanks Tyler. -- David Marchand
