RE: [PATCH v3 04/15] vdpa/ifc: add vdpa interrupt for blk device

2022-03-23 Thread Pei, Andy
Hi Maxime, Thanks for your reply and my reply is inline. -Original Message- From: Maxime Coquelin Sent: Tuesday, March 22, 2022 6:05 PM To: Pei, Andy ; dev@dpdk.org Cc: Xia, Chenbo ; Cao, Gang ; Liu, Changpeng Subject: Re: [PATCH v3 04/15] vdpa/ifc: add vdpa interrupt for blk device

RE: [PATCH v3 04/15] vdpa/ifc: add vdpa interrupt for blk device

2022-03-23 Thread Pei, Andy
Hi Maxime, I think it is better to change the commit log to your description. "For the block device type, we have to relay the commands on all queues." In the next version of patch set. -Original Message- From: Pei, Andy Sent: Wednesday, March 23, 2022 3:08 PM To: Maxime Coquelin ; dev@

Re: [PATCH] net/netvsc: fix the calculation of checksums based on mbuf flag

2022-03-23 Thread David Marchand
On Wed, Mar 23, 2022 at 5:28 AM wrote: > > From: Long Li > > The netvsc should use RTE_MBUF_F_TX_L4_MASK and check the value to decide > the correct way to calculate checksums. It's better to describe what the impact for an application is. Do I understand correctly that UDP checksum offloading w

Re: [PATCH] net/netvsc: report correct stats values

2022-03-23 Thread David Marchand
On Wed, Mar 23, 2022 at 5:28 AM wrote: > > From: Long Li > > The netvsc should add to the values from the VF and report the sum. We need a Fixes: tag. > > Signed-off-by: Long Li -- David Marchand

RE: [PATCH v3 05/15] vdpa/ifc: add blk dev sw live migration

2022-03-23 Thread Pei, Andy
Hi Maxime, Thanks for your reply and reply is inline. -Original Message- From: Maxime Coquelin Sent: Tuesday, March 22, 2022 7:10 PM To: Pei, Andy ; dev@dpdk.org Cc: Xia, Chenbo ; Cao, Gang ; Liu, Changpeng Subject: Re: [PATCH v3 05/15] vdpa/ifc: add blk dev sw live migration Hi Andy

Re: [PATCH 2/6] net/hns3: fix inconsistent enabled RSS behavior

2022-03-23 Thread Thomas Monjalon
23/03/2022 04:05, lihuisong (C): > 在 2022/3/23 1:13, Thomas Monjalon 写道: > > 21/03/2022 08:14, lihuisong (C): > >> 2022/3/10 16:08, lihuisong (C): > >>> 2022/3/9 17:55, Ori Kam: > From: lihuisong (C) > > 2022/3/3 10:47, lihuisong (C): > >> 2022/3/2 22:07, Ori Kam: > >>> From: lihu

[PATCH] devtools: document ABI suppression rules

2022-03-23 Thread David Marchand
Suppression rules are being added during the life of an ABI and cleaned when bumping the major version. Sort and document those rules to avoid pruning rules that should be kept. Signed-off-by: David Marchand --- devtools/libabigail.abignore | 20 1 file changed, 16 insertion

[PATCH] eal: factorize lcore main loop

2022-03-23 Thread David Marchand
All OS implementations provide the same main loop. Introduce helpers (shared for Linux and FreeBSD) to handle synchronisation between main and threads and factorize the rest as common code. Thread id are now logged as string in a common format across OS. Signed-off-by: David Marchand --- I had th

RE: [PATCH v3 06/15] example/vdpa:add vdpa blk support in example

2022-03-23 Thread Pei, Andy
Hi Maxime, I seems a lot of problem with the example. I think I will re-work the example according to your comments. Thanks for your comments. -Original Message- From: Maxime Coquelin Sent: Tuesday, March 22, 2022 7:30 PM To: Pei, Andy ; dev@dpdk.org Cc: Xia, Chenbo ; Cao, Gang ; Liu,

RE: [PATCH] eal: factorize lcore main loop

2022-03-23 Thread Morten Brørup
> From: David Marchand [mailto:david.march...@redhat.com] > Sent: Wednesday, 23 March 2022 10.30 > > All OS implementations provide the same main loop. > Introduce helpers (shared for Linux and FreeBSD) to handle > synchronisation > between main and threads and factorize the rest as common code. >

RE: DPDK seqlock

2022-03-23 Thread Morten Brørup
> From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com] > Sent: Tuesday, 22 March 2022 17.10 > > Hi. > > Would it make sense to have a seqlock implementation in DPDK? Certainly! > > I think so, since it's a very useful synchronization primitive in data > plane applications. Yes, and h

RE: [PATCH v5] ip_frag: add IPv4 options fragment and test data

2022-03-23 Thread Ananyev, Konstantin
> According to RFC791,the options may appear or not in datagrams. > They must be implemented by all IP modules (host and gateways). > What is optional is their transmission in any particular datagram, > not their implementation.So we have to deal with it during the > fragmenting process.Add some

Re: 20.11.5 patches review and test

2022-03-23 Thread Pei Zhang
Hello Luca, The testing with dpdk 20.11.5-rc1 from Red Hat looks good. We tested below 17 scenarios and all got PASS on RHEL8: (1)Guest with device assignment(PF) throughput testing(1G hugepage size): PASS (2)Guest with device assignment(PF) throughput testing(2M hugepage size) : PASS (3)Guest wi

[Bug 975] Power DOWN of copper interface not working in e1000 driver

2022-03-23 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=975 Bug ID: 975 Summary: Power DOWN of copper interface not working in e1000 driver Product: DPDK Version: 22.03 Hardware: All OS: All Status: UNCONFIRMED

Re: [PATCH] net/netvsc: fix the calculation of checksums based on mbuf flag

2022-03-23 Thread Stephen Hemminger
On Tue, 22 Mar 2022 21:28:07 -0700 lon...@linuxonhyperv.com wrote: > From: Long Li > > The netvsc should use RTE_MBUF_F_TX_L4_MASK and check the value to decide > the correct way to calculate checksums. > > Signed-off-by: Long Li Acked-by: Stephen Hemminger

Re: [PATCH] net/netvsc: report correct stats values

2022-03-23 Thread Stephen Hemminger
On Tue, 22 Mar 2022 21:28:25 -0700 lon...@linuxonhyperv.com wrote: > From: Long Li > > The netvsc should add to the values from the VF and report the sum. > > Signed-off-by: Long Li > --- Acked-by: Stephen Hemminger

Re: 20.11.5 patches review and test

2022-03-23 Thread Luca Boccassi
On Wed, 2022-03-23 at 21:33 +0800, Pei Zhang wrote: > Hello Luca, > > The testing with dpdk 20.11.5-rc1 from Red Hat looks good. We tested > below 17 scenarios and all got PASS on RHEL8: > > (1)Guest with device assignment(PF) throughput testing(1G hugepage > size): PASS > (2)Guest with device a

[PATCH v1] dmadev: add telemetry support

2022-03-23 Thread Sean Morrissey
Telemetry commands are now registered through the dmadev library for the gathering of DSA stats. The corresponding callback functions for listing dmadevs and providing info and stats for a specific dmadev are implemented in the dmadev library. An example usage can be seen below: Connecting to /va

Re: [PATCH 2/6] net/hns3: fix inconsistent enabled RSS behavior

2022-03-23 Thread Thomas Monjalon
23/03/2022 12:04, lihuisong (C): > 在 2022/3/23 17:14, Thomas Monjalon 写道: > > 23/03/2022 04:05, lihuisong (C): > >> 在 2022/3/23 1:13, Thomas Monjalon 写道: > >>> 21/03/2022 08:14, lihuisong (C): > 2022/3/10 16:08, lihuisong (C): > > 2022/3/9 17:55, Ori Kam: > >> From: lihuisong (C) > >>

Re: [PATCH 2/6] net/hns3: fix inconsistent enabled RSS behavior

2022-03-23 Thread Ajit Khaparde
On Wed, Mar 23, 2022 at 12:04 PM Thomas Monjalon wrote: > > 23/03/2022 12:04, lihuisong (C): > > 在 2022/3/23 17:14, Thomas Monjalon 写道: > > > 23/03/2022 04:05, lihuisong (C): > > >> 在 2022/3/23 1:13, Thomas Monjalon 写道: > > >>> 21/03/2022 08:14, lihuisong (C): > > 2022/3/10 16:08, lihuisong (

[PATCH v3] net/ixgbe: Retry SFP ID read field to handle misbehaving SFPs

2022-03-23 Thread jeffd
From: Stephen Douthit Some XGS-PON SFPs have been observed ACKing I2C reads and returning uninitialized garbage while their uC boots. This can lead to the SFP ID code marking an otherwise working SFP module as unsupported if a bogus ID value is read while its internal PHY/microcontroller is stil

Minutes of Technical Board Meeting, 2022-03-09

2022-03-23 Thread Honnappa Nagarahalli
Members Attending: 2022-03-09 - Aaron Conole - Bruce Richardson - Ferruh Yigit - Hemant Agrawal - Honnappa Nagarahalli (Host) - Jerin Jacob - Kevin Traynor - Konstantin Ananyev - Maxime Coquelin - Olivier Matz -

RE: [PATCH] net/netvsc: fix the calculation of checksums based on mbuf flag

2022-03-23 Thread Long Li
> Subject: Re: [PATCH] net/netvsc: fix the calculation of checksums based on > mbuf flag > > On Wed, Mar 23, 2022 at 5:28 AM wrote: > > > > From: Long Li > > > > The netvsc should use RTE_MBUF_F_TX_L4_MASK and check the value to > > decide the correct way to calculate checksums. > > It's better

[Bug 976] rte_rib (and rte_rib6) do not handle /0 correctly

2022-03-23 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=976 Bug ID: 976 Summary: rte_rib (and rte_rib6) do not handle /0 correctly Product: DPDK Version: 21.11 Hardware: All OS: All Status: UNCONFIRMED Severity: normal

Re: [Bug 976] rte_rib (and rte_rib6) do not handle /0 correctly

2022-03-23 Thread Stephen Hemminger
On Wed, 23 Mar 2022 22:46:02 + bugzi...@dpdk.org wrote: > https://bugs.dpdk.org/show_bug.cgi?id=976 > > Bug ID: 976 >Summary: rte_rib (and rte_rib6) do not handle /0 correctly >Product: DPDK >Version: 21.11 > Hardware: All >

RE: [PATCH v3] net/ixgbe: Retry SFP ID read field to handle misbehaving SFPs

2022-03-23 Thread Wang, Haiyue
> -Original Message- > From: je...@silicom-usa.com > Sent: Thursday, March 24, 2022 04:04 > To: dev@dpdk.org > Cc: Stephen Douthit ; Daly, Jeff > ; Wang, Haiyue > > Subject: [PATCH v3] net/ixgbe: Retry SFP ID read field to handle misbehaving > SFPs > > From: Stephen Douthit > > Some

[Bug 977] [dpdk-19.11.12-rc1] meson and make build Error on Fedora35-64 and Ubuntu2110-64 with gcc11.2.1 and gcc11.2.0

2022-03-23 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=977 Bug ID: 977 Summary: [dpdk-19.11.12-rc1] meson and make build Error on Fedora35-64 and Ubuntu2110-64 with gcc11.2.1 and gcc11.2.0 Product: DPDK Version: 19.11 Ha

[PATCH] net/ice: fix error set of queue number

2022-03-23 Thread Wenjun Wu
The queue number actually applied should be the maximum integer power of 2 less than or equal to min(vsi->nb_qps, ICE_MAX_Q_PER_TC), so we need to get the most significant 1 bit. However the return value of function rte_bsf32 is the least significant 1 bit. This patch replaces the function rte_bsf3

RE: DPDK seqlock

2022-03-23 Thread Honnappa Nagarahalli
> > Hi Mattias, > > > > > Would it make sense to have a seqlock implementation in DPDK? I do not have any issues with adding the seqlock to DPDK. However, I am interested in understanding the use case. As I understand, seqlock is a type of reader-writer lock. This means that it is possible th

Re: DPDK seqlock

2022-03-23 Thread Stephen Hemminger
On Thu, 24 Mar 2022 04:52:07 + Honnappa Nagarahalli wrote: > > > > > > Hi Mattias, > > > > > > > > Would it make sense to have a seqlock implementation in DPDK? > I do not have any issues with adding the seqlock to DPDK. > > However, I am interested in understanding the use case. As

[PATCH] ethtool: correct format strings according to the arguments

2022-03-23 Thread huzaifa.rahman
The corrected format strings are not consistent with the given arguments. So they are changed accordingly. Signed-off-by: huzaifa.rahman --- examples/ethtool/ethtool-app/main.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/examples/ethtool/ethtool-app/main.c b/exampl

[PATCH v1] net/ice: support 256 queues

2022-03-23 Thread Wenjun Wu
256 queues can be allowed now. This patch improves the code to support 256 queues for per PF. Signed-off-by: Wenjun Wu --- drivers/net/ice/ice_ethdev.c | 8 drivers/net/ice/ice_ethdev.h | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/net/ice/ice_ethdev.c