[Bug 896] [20.11.4-rc1] net/af_xdp build failure with gcc 11 on Fedora 35

2021-12-08 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=896 Bug ID: 896 Summary: [20.11.4-rc1] net/af_xdp build failure with gcc 11 on Fedora 35 Product: DPDK Version: 20.11 Hardware: All OS: All Status: UNCONFIRM

Re: [PATCH v4 0/4] regex/cn9k: use cnxk infrastructure

2021-12-08 Thread Jerin Jacob
On Wed, Dec 8, 2021 at 12:02 AM wrote: > > From: Liron Himi > > 3 patches add support for REE into cnkx infrastructure. > the last patch change the octeontx2 driver to use > the new cnxk code. in addition all references to > octeontx2/otx2 were replaced with cn9k. Series Acked-by: Jerin Jacob

[PATCH] devtools/cocci: update cocci for ethdev namespace

2021-12-08 Thread Aman Singh
Added two specific execptions for ETH_SPEED_10G and ETH_SPEED_25G to avoid there name change. Signed-off-by: Aman Singh --- devtools/cocci/namespace_ethdev.cocci | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/devtools/cocci/namespace_ethdev.cocci b/devtools/cocci/namespac

RE: [PATCH 1/3] common/mlx5: add min WQE size for striding RQ

2021-12-08 Thread Michael Baum
On 12/07/2021 3:32 PM, ferruh.yi...@intel.com wrote: > > On 11/23/2021 6:38 PM, michae...@nvidia.com wrote: > > From: Michael Baum > > > > Some devices have a WQE size limit for striding RQ. On some newer > > devices, this limitation is smaller and information on its size is > > provided by the

RE: [PATCH 2/3] net/mlx5: improve stride parameter names

2021-12-08 Thread Michael Baum
On 12/07/2021 3:34 PM, ferruh.yi...@intel.com wrote: > > On 11/23/2021 6:38 PM, michae...@nvidia.com wrote: > > From: Michael Baum > > > > In the striding RQ management there are two important parameters, the > > size of the single stride in bytes and the number of strides. > > > > Both the data-

RE: [PATCH 3/3] net/mlx5: fix missing adjustment MPRQ stride devargs

2021-12-08 Thread Michael Baum
On 12/07/2021 3:41 PM, ferruh.yi...@intel.com wrote: > > On 11/23/2021 6:38 PM, michae...@nvidia.com wrote: > > From: Michael Baum > > > > In Multy-Packet RQ creation, the user can choose the number of strides > > Multi-Packet ? Yes, you're right. It should have been Multi-Packet, thank you fo

Re: [PATCH 3/3] net/mlx5: fix missing adjustment MPRQ stride devargs

2021-12-08 Thread Ferruh Yigit
On 12/8/2021 12:52 PM, Michael Baum wrote: On 12/07/2021 3:41 PM, ferruh.yi...@intel.com wrote: On 11/23/2021 6:38 PM, michae...@nvidia.com wrote: From: Michael Baum In Multy-Packet RQ creation, the user can choose the number of strides Multi-Packet ? Yes, you're right. It should have be

[PATCH] net/mlx5: fix the memory socket selection in ASO management

2021-12-08 Thread michaelba
From: Michael Baum In ASO objects creation (WQE, CQE and MR), socket number is given as a parameter. The selection was wrongly socket 0 hardcoded even if the user didn't configure memory for this socket. This patch replaces the selection to default socket (SOCKET_ID_ANY). Fixes: f935ed4b645a (

RE: [PATCH 3/3] net/mlx5: fix missing adjustment MPRQ stride devargs

2021-12-08 Thread Matan Azrad
Hi Ferruh Thanks for the review. Please see inside some clarifications. From: Ferruh Yigit > On 12/8/2021 12:52 PM, Michael Baum wrote: > > > > On 12/07/2021 3:41 PM, ferruh.yi...@intel.com wrote: > >> > >> On 11/23/2021 6:38 PM, michae...@nvidia.com wrote: > >>> From: Michael Baum > >>> > >>> I

[Bug 897] [20.11.4-rc1] librte_eal/windows cross build failure with gcc 11 on Fedora 35

2021-12-08 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=897 Bug ID: 897 Summary: [20.11.4-rc1] librte_eal/windows cross build failure with gcc 11 on Fedora 35 Product: DPDK Version: 20.11 Hardware: All OS: Linux S

Re: [PATCH v13 11/11] app/test: enable unit test on Windows

2021-12-08 Thread Bruce Richardson
On Tue, Dec 07, 2021 at 05:51:02PM -0800, Jie Zhou wrote: > Enable a subset of unit tests for Windows CI > > - For driver tests, driver owners should enable corresponding tests when > enabling driver for Windows. For example, the cryptodev tests will be > enabled by "patch-18949: app/test: ena

Re: [PATCH v1] gpudev: return EINVAL if invalid input pointer for free and unregister

2021-12-08 Thread Tyler Retzlaff
On Thu, Dec 02, 2021 at 01:01:26PM +, Ananyev, Konstantin wrote: > > > > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > Sent: Thursday, 2 December 2021 08.19 > > > > > > 01/12/2021 22:37, Tyler Retzlaff: > > > > On Wed, Nov 24, 2021 at 06:04:56PM +, Bruce Richardson wrote: > >

Re: [PATCH v1] gpudev: return EINVAL if invalid input pointer for free and unregister

2021-12-08 Thread Tyler Retzlaff
On Fri, Dec 03, 2021 at 11:37:10AM +0100, Morten Brørup wrote: > > From: Morten Brørup [mailto:m...@smartsharesystems.com] > > Sent: Thursday, 2 December 2021 14.56 > > > > > > I disagree: Negative value does not mean failure. Only -1 means > > failure. > > > > There is no -2 return value. There

Re: [PATCH v13 11/11] app/test: enable unit test on Windows

2021-12-08 Thread Jie Zhou
On Wed, Dec 08, 2021 at 04:57:52PM +, Bruce Richardson wrote: > On Tue, Dec 07, 2021 at 05:51:02PM -0800, Jie Zhou wrote: > > Enable a subset of unit tests for Windows CI > > > > - For driver tests, driver owners should enable corresponding tests when > > enabling driver for Windows. For exa

Re: [PATCH v13 11/11] app/test: enable unit test on Windows

2021-12-08 Thread Bruce Richardson
On Wed, Dec 08, 2021 at 10:19:27AM -0800, Jie Zhou wrote: > On Wed, Dec 08, 2021 at 04:57:52PM +, Bruce Richardson wrote: > > On Tue, Dec 07, 2021 at 05:51:02PM -0800, Jie Zhou wrote: > > > Enable a subset of unit tests for Windows CI > > > > > > - For driver tests, driver owners should enable

Re: [PATCH v13 11/11] app/test: enable unit test on Windows

2021-12-08 Thread Jie Zhou
On Wed, Dec 08, 2021 at 06:23:30PM +, Bruce Richardson wrote: > On Wed, Dec 08, 2021 at 10:19:27AM -0800, Jie Zhou wrote: > > On Wed, Dec 08, 2021 at 04:57:52PM +, Bruce Richardson wrote: > > > On Tue, Dec 07, 2021 at 05:51:02PM -0800, Jie Zhou wrote: > > > > Enable a subset of unit tests f

RE: [PATCH v1] gpudev: return EINVAL if invalid input pointer for free and unregister

2021-12-08 Thread Morten Brørup
> From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > Sent: Wednesday, 8 December 2021 18.35 > > On Fri, Dec 03, 2021 at 11:37:10AM +0100, Morten Brørup wrote: > > > From: Morten Brørup [mailto:m...@smartsharesystems.com] > > > Sent: Thursday, 2 December 2021 14.56 > > > > > > > > > I dis

[PATCH v14 03/11] app/test: fix incorrect errno variable

2021-12-08 Thread Jie Zhou
Fix incorrect errno variable used in memory autotest. Use rte_errno instead. Fixes: 086d426406bd ("app/test: fix memory autotests on FreeBSD") Cc: bruce.richard...@intel.com Signed-off-by: Jie Zhou Acked-by: Dmitry Kozlyuk --- app/test/test_memory.c | 2 +- 1 file changed, 1 insertion(+), 1 d

[PATCH v14 00/11] app/test: enable subset of tests on Windows

2021-12-08 Thread Jie Zhou
The goal of this patchset is to enable unit tests in CI for Windows. It mainly contains: - Replace POSIX specific codes - Fix some lib and tests per failures investigation - Add test stubs for not yet supported ones on Windows - Replace .sh script with .py script for meson.build - Enable build and

[PATCH v14 01/11] eal/windows: return ENOTSUP for not supported API

2021-12-08 Thread Jie Zhou
UT memory_autotest on Windows has 2 failed cases on eal APIs eal_memalloc_get_seg_fd and eal_memalloc_get_seg_fd_offset. These 2 APIs are not supported on Windows yet. Should return ENOTSUP such that in test_memory.c these 2 ENOTSUP cases will not be marked as failures, same as other ENOTSUP cases.

[PATCH v14 04/11] app/test: skip interrupt tests on Windows

2021-12-08 Thread Jie Zhou
Even though test_interrupts.c can compile on Windows, skip interrupt tests for now since majority of eal_interrupt on Windows are stubs. Will remove the skip after interrupt being fully enabled on Windows. Signed-off-by: Jie Zhou Acked-by: Dmitry Kozlyuk --- app/test/test_interrupts.c | 10 +++

[PATCH v14 02/11] app/test: remove POSIX-specific code

2021-12-08 Thread Jie Zhou
- Replace POSIX-specific code with DPDK equivalents or conditionally disable it on Windows - Use NUL on Windows as /dev/null for Unix - Exclude tests not supported on Windows yet * multi-process * PMD performance statistics display on signal Signed-off-by: Jie Zhou Signed-off-by: Dmitry Koz

[PATCH v14 05/11] app/test: skip two logs_autotest cases on Windows

2021-12-08 Thread Jie Zhou
DPDK logs_autotest on Windows failed at "dynamic log types" tests. The failures are on 2 test cases for rte_log_set_level_regexp API, due to regular expression is not supported on Windows in DPDK yet and regcomp/regexec are just stubs on Windows (in regex.h). In app\test\test_logs.c, ifndef these

[PATCH v14 10/11] app/test: replace .sh script with .py script

2021-12-08 Thread Jie Zhou
- Add python script to check if system supports hugepages - Remove corresponding .sh script - Replace calling of .sh with corresponding .py in meson.build Signed-off-by: Jie Zhou Acked-by: Dmitry Kozlyuk --- app/test/has-hugepage.sh | 11 --- app/test/has_hugepage.py | 26 +

[PATCH v14 08/11] app/test: resolve name collision

2021-12-08 Thread Jie Zhou
Add OP_ prefix to resolve name collision to enable hash_perf test Signed-off-by: Jie Zhou --- app/test/test_hash_perf.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/app/test/test_hash_perf.c b/app/test/test_hash_perf.c index 76cdac5d53..7e98ec3964 100644

[PATCH v14 06/11] app/test: differentiate a strerror on different OS

2021-12-08 Thread Jie Zhou
On Windows, strerror returns just "Unknown error" for errnum greater than MAX_ERRNO, while linux and freebsd returns "Unknown error ", which is the current expectation for errno_autotest. Differentiate the error string on Windows to remove a "duplicate error code" failure. Signed-off-by: Jie Zhou

[PATCH v14 07/11] app/test: remove two alarm_autotest cases

2021-12-08 Thread Jie Zhou
Remove two alarm_autotest test cases which do bogus range check on Windows. Signed-off-by: Jie Zhou Acked-by: Dmitry Kozlyuk --- app/test/test_alarm.c | 4 1 file changed, 4 insertions(+) diff --git a/app/test/test_alarm.c b/app/test/test_alarm.c index b4034339b8..70e97a3109 100644 --- a

[PATCH v14 11/11] app/test: enable unit test on Windows

2021-12-08 Thread Jie Zhou
Enable a subset of unit tests for Windows CI - For driver tests, driver owners should enable corresponding tests when enabling driver for Windows. For example, the cryptodev tests will be enabled by "patch-18949: app/test: enable crypto unit tests on Windows" (which depends on this patchset

[PATCH v14 09/11] app/test: add test stubs for not supported ones

2021-12-08 Thread Jie Zhou
Add test stubs for tests which are not yet supported for Windows: - The libraries that tests depend on are not enabled on Windows yet - The tests can compile but with issue still under investigation * test_func_reentrancy: Windows EAL has no protection against repeated calls. * test_l

Re: [PATCH v14 06/11] app/test: differentiate a strerror on different OS

2021-12-08 Thread Dmitry Kozlyuk
2021-12-08 10:59 (UTC-0800), Jie Zhou: > On Windows, strerror returns just "Unknown error" for errnum greater > than MAX_ERRNO, while linux and freebsd returns "Unknown error ", > which is the current expectation for errno_autotest. Differentiate > the error string on Windows to remove a "duplicate

Re: [PATCH v14 08/11] app/test: resolve name collision

2021-12-08 Thread Dmitry Kozlyuk
2021-12-08 10:59 (UTC-0800), Jie Zhou: > Add OP_ prefix to resolve name collision to enable hash_perf test "name collision with Windows system headers" > > Signed-off-by: Jie Zhou Acked-by: Dmitry Kozlyuk

[PATCH] net/ice: fix error forwarding IPv6 VXLAN packet

2021-12-08 Thread Kevin Liu
In ice_txd_enable_offload(), when set tunnel packet Tx checksum offload enable, td_offset should be set with outer l2/l3 len instead of inner l2/l3 len. This patch fix the bug that the checksum engine can forward tunnle packets. Fixes: 28f9002ab67f ("net/ice: add Tx AVX512 offload path") Cc: sta.

Re: [PATCH v14 04/11] app/test: skip interrupt tests on Windows

2021-12-08 Thread Jerin Jacob
On Thu, Dec 9, 2021 at 12:30 AM Jie Zhou wrote: > > Even though test_interrupts.c can compile on Windows, skip interrupt > tests for now since majority of eal_interrupt on Windows are stubs. > Will remove the skip after interrupt being fully enabled on Windows. > > Signed-off-by: Jie Zhou > Acked