On Wed, Dec 08, 2021 at 06:23:30PM +0000, Bruce Richardson wrote:
> On Wed, Dec 08, 2021 at 10:19:27AM -0800, Jie Zhou wrote:
> > On Wed, Dec 08, 2021 at 04:57:52PM +0000, Bruce Richardson wrote:
> > > On Tue, Dec 07, 2021 at 05:51:02PM -0800, Jie Zhou wrote:
> > > > Enable a subset of unit tests for Windows CI
> > > >
> > > > - For driver tests, driver owners should enable corresponding tests when
> > > > enabling driver for Windows. For example, the cryptodev tests will be
> > > > enabled by "patch-18949: app/test: enable crypto unit tests on
> > > > Windows"
> > > > (which depends on this patchset to be merged).
> > > > - For dump tests, currently the tests hang on Windows which require
> > > > further investigation.
> > > >
> > > > Signed-off-by: Jie Zhou <j...@linux.microsoft.com>
> > > >
> > >
> > > Mostly these changes look ok to me. One small query below.
> > >
> > > /Bruce
> > > > ---
> > > > app/test/meson.build | 111 ++++++++++++++++++++++---------------------
> > > > 1 file changed, 58 insertions(+), 53 deletions(-)
> > > >
> > > > diff --git a/app/test/meson.build b/app/test/meson.build
> > > > index 97ee83029e..fcf38729e7 100644
> > > > --- a/app/test/meson.build
> > > > +++ b/app/test/meson.build
> > > > @@ -1,12 +1,6 @@
> > > > # SPDX-License-Identifier: BSD-3-Clause
> > > > # Copyright(c) 2017 Intel Corporation
> > > >
> > > > -if is_windows
> > > > - build = false
> > >
> > > <snip>
> > >
> > > > # The following linkages are an exception to allow running the
> > > > # unit tests without requiring that the developer install the
> > > > # DPDK libraries. Explicit linkage of drivers (plugin libraries)
> > > > @@ -385,7 +390,7 @@ if dpdk_conf.has('RTE_LIB_METRICS')
> > > > test_sources += ['test_metrics.c']
> > > > fast_tests += [['metrics_autotest', true]]
> > > > endif
> > > > -if dpdk_conf.has('RTE_LIB_TELEMETRY')
> > > > +if not is_windows and dpdk_conf.has('RTE_LIB_TELEMETRY')
> > > > test_sources += ['test_telemetry_json.c', 'test_telemetry_data.c']
> > > > fast_tests += [['telemetry_json_autotest', true],
> > > > ['telemetry_data_autotest', true]]
> > >
> > > If telemetry is enabled, is there a reason these won't run on Windows?
> >
> > Hi Bruce, the telemetry test has many POSIX socket specific codes which
> > requires replacement for Windows. We will work on investigation of enabling
> > more tests (including the telemetry tests) after this patchset. Sorry I
> > forgot to mention that in the commit message, but it is on my list. The
> > current goal is to get this patchset merged asap before another upstream
> > churn to rebase, rework, etc. If you prefer me to send out a V14 to add
> > this info into commit message or remove this change from meson.build but
> > add test stub into the specific test files, please just let me know. Thanks
> > for your understanding. -- Jie
>
> A line to two added to the commit log is probably sufficient.
>
> Acked-by: Bruce Richardson <bruce.richard...@intel.com>
Thanks Bruce. Will add the info into commit message in V14.
