In ice_txd_enable_offload(), when set tunnel packet Tx checksum
offload enable, td_offset should be set with outer l2/l3 len instead
of inner l2/l3 len.

This patch fix the bug that the checksum engine can forward tunnle
packets.

Fixes: 28f9002ab67f ("net/ice: add Tx AVX512 offload path")
Cc: sta...@dpdk.org

Signed-off-by: Kevin Liu <kevinx....@intel.com>
---
 drivers/net/ice/ice_rxtx_vec_common.h | 52 +++++++++++++++++++--------
 1 file changed, 37 insertions(+), 15 deletions(-)

diff --git a/drivers/net/ice/ice_rxtx_vec_common.h 
b/drivers/net/ice/ice_rxtx_vec_common.h
index dfe60c81d9..8ff01046e1 100644
--- a/drivers/net/ice/ice_rxtx_vec_common.h
+++ b/drivers/net/ice/ice_rxtx_vec_common.h
@@ -364,23 +364,45 @@ ice_txd_enable_offload(struct rte_mbuf *tx_pkt,
        uint32_t td_offset = 0;
 
        /* Tx Checksum Offload */
-       /* SET MACLEN */
-       td_offset |= (tx_pkt->l2_len >> 1) <<
+       /*Tunnel package usage outer len enable L2/L3 checksum offload*/
+       if (ol_flags & RTE_MBUF_F_TX_TUNNEL_MASK) {
+               /* SET MACLEN */
+               td_offset |= (tx_pkt->outer_l2_len >> 1) <<
                        ICE_TX_DESC_LEN_MACLEN_S;
 
-       /* Enable L3 checksum offload */
-       if (ol_flags & RTE_MBUF_F_TX_IP_CKSUM) {
-               td_cmd |= ICE_TX_DESC_CMD_IIPT_IPV4_CSUM;
-               td_offset |= (tx_pkt->l3_len >> 2) <<
-                       ICE_TX_DESC_LEN_IPLEN_S;
-       } else if (ol_flags & RTE_MBUF_F_TX_IPV4) {
-               td_cmd |= ICE_TX_DESC_CMD_IIPT_IPV4;
-               td_offset |= (tx_pkt->l3_len >> 2) <<
-                       ICE_TX_DESC_LEN_IPLEN_S;
-       } else if (ol_flags & RTE_MBUF_F_TX_IPV6) {
-               td_cmd |= ICE_TX_DESC_CMD_IIPT_IPV6;
-               td_offset |= (tx_pkt->l3_len >> 2) <<
-                       ICE_TX_DESC_LEN_IPLEN_S;
+               /* Enable L3 checksum offload */
+               if (ol_flags & RTE_MBUF_F_TX_IP_CKSUM) {
+                       td_cmd |= ICE_TX_DESC_CMD_IIPT_IPV4_CSUM;
+                       td_offset |= (tx_pkt->outer_l3_len >> 2) <<
+                               ICE_TX_DESC_LEN_IPLEN_S;
+               } else if (ol_flags & RTE_MBUF_F_TX_IPV4) {
+                       td_cmd |= ICE_TX_DESC_CMD_IIPT_IPV4;
+                       td_offset |= (tx_pkt->outer_l3_len >> 2) <<
+                               ICE_TX_DESC_LEN_IPLEN_S;
+               } else if (ol_flags & RTE_MBUF_F_TX_IPV6) {
+                       td_cmd |= ICE_TX_DESC_CMD_IIPT_IPV6;
+                       td_offset |= (tx_pkt->outer_l3_len >> 2) <<
+                               ICE_TX_DESC_LEN_IPLEN_S;
+               }
+       } else {
+               /* SET MACLEN */
+               td_offset |= (tx_pkt->l2_len >> 1) <<
+                       ICE_TX_DESC_LEN_MACLEN_S;
+
+               /* Enable L3 checksum offload */
+               if (ol_flags & RTE_MBUF_F_TX_IP_CKSUM) {
+                       td_cmd |= ICE_TX_DESC_CMD_IIPT_IPV4_CSUM;
+                       td_offset |= (tx_pkt->l3_len >> 2) <<
+                               ICE_TX_DESC_LEN_IPLEN_S;
+               } else if (ol_flags & RTE_MBUF_F_TX_IPV4) {
+                       td_cmd |= ICE_TX_DESC_CMD_IIPT_IPV4;
+                       td_offset |= (tx_pkt->l3_len >> 2) <<
+                               ICE_TX_DESC_LEN_IPLEN_S;
+               } else if (ol_flags & RTE_MBUF_F_TX_IPV6) {
+                       td_cmd |= ICE_TX_DESC_CMD_IIPT_IPV6;
+                       td_offset |= (tx_pkt->l3_len >> 2) <<
+                               ICE_TX_DESC_LEN_IPLEN_S;
+               }
        }
 
        /* Enable L4 checksum offloads */
-- 
2.25.1

Reply via email to