Re: [dpdk-dev] [PATCH] eventdev: fix Rx adapter stalls on event device backpressure

2021-11-10 Thread Kundapura, Ganapati
Hi Mattias, > -Original Message- > From: Mattias Rönnblom > Sent: 09 November 2021 13:58 > To: Kundapura, Ganapati ; > jer...@marvell.com; Jayatheerthan, Jay > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: Re: [PATCH] eventdev: fix Rx adapter stalls on event device > backpressure > > On

Re: [dpdk-dev] [EXT] Re: [PATCH v5 1/4] doc: add skeleton for eventdevs feature matrices

2021-11-10 Thread Jerin Jacob Kollanukkaran
> > 1) Please sync the doc order with flag definition order in header file[1] > > 2) You can remove RTE_EVENT_DEV_CAP_REQUIRES_MAINT from the > > list(*CAP_REQUIRES*) as this > > is limitation. > > > > > > Maybe we should negate RTE_EVENT_DEV_CAP_REQUIRES_MAINT to make it > fit > better with the o

[dpdk-dev] [PATCH] doc: update release notes for DCF reset API

2021-11-10 Thread dapengx . yu
From: Dapeng Yu The ice DCF device reset has been supported. Release notes is updated to synchronize with the feature. Signed-off-by: Dapeng Yu --- doc/guides/rel_notes/release_21_11.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/doc/guides/rel_notes/release_21_11.rst b/doc/guides/re

[dpdk-dev] [PATCH v2] app/testpmd: fix DCB configuration

2021-11-10 Thread Jie Wang
When set port DCB mode enabled, it should remove RSS HASH offload before reconfiguring the device and queues. Because port multi-queue mode is changed from RSS to DCB. Fixes: 2a977b891f99 ("app/testpmd: fix DCB configuration") Signed-off-by: Jie Wang --- v2: * update commit log. * remove RSS

Re: [dpdk-dev] [EXTERNAL] Re: [PATCH v16 2/9] eal: add thread attributes

2021-11-10 Thread Bruce Richardson
On Tue, Nov 09, 2021 at 10:29:25PM -0800, Stephen Hemminger wrote: > On Wed, 10 Nov 2021 04:20:52 + > Tyler Retzlaff wrote: > > > > > > > > > High performance applications benefit from an option to raise the > > > > priority of their threads to avoid being preemted by other threads on > > >

Re: [dpdk-dev] [PATCH v17 00/13] eal: Add EAL API for threading

2021-11-10 Thread Thomas Monjalon
10/11/2021 04:01, Narcisa Ana Maria Vasile: > Narcisa Vasile (13): > eal: add basic threading functions > eal: add thread attributes > eal/windows: translate Windows errors to errno-style errors > eal: implement functions for thread affinity management > eal: implement thread priority man

Re: [dpdk-dev] [PATCH] eventdev: negate maintenance capability flag

2021-11-10 Thread Van Haaren, Harry
> -Original Message- > From: Mattias Rönnblom > Sent: Wednesday, November 10, 2021 9:29 AM > To: jer...@marvell.com; Jerin Jacob ; Sunil Kumar Kori > > Cc: dev@dpdk.org; Pavan Nikhilesh Bhagavatula ; > Hemant Agrawal ; Nipun Gupta > ; Van Haaren, Harry ; > Thomas Monjalon ; David Marchand

Re: [dpdk-dev] [PATCH] eventdev: fix Rx adapter stalls on event device backpressure

2021-11-10 Thread Jayatheerthan, Jay
> -Original Message- > From: Kundapura, Ganapati > Sent: Wednesday, November 10, 2021 1:56 PM > To: mattias.ronnblom ; jer...@marvell.com; > Jayatheerthan, Jay > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: RE: [PATCH] eventdev: fix Rx adapter stalls on event device > backpressure > >

Re: [dpdk-dev] [PATCH] eventdev: negate maintenance capability flag

2021-11-10 Thread Jerin Jacob
On Wed, Nov 10, 2021 at 3:37 PM Mattias Rönnblom wrote: > > On 2021-11-10 10:55, Van Haaren, Harry wrote: > >> -Original Message- > >> From: Mattias Rönnblom > >> Sent: Wednesday, November 10, 2021 9:29 AM > >> To: jer...@marvell.com; Jerin Jacob ; Sunil Kumar > >> Kori > >> > >> Cc: de

Re: [dpdk-dev] [PATCH] test: enable bitmap in fast tests

2021-11-10 Thread David Marchand
On Wed, Oct 27, 2021 at 4:55 PM Dumitrescu, Cristian wrote: > > This test was never added to the list of tests to run in CI. > > Its name does not follow the implicit convention of ending with > > _autotest. > > Let's fix this. > > > > Fixes: 5e9647fd5a1a ("test/bitmap: test scan after half cachel

Re: [dpdk-dev] [PATCH] test/ipfrag: add test content to the test unit

2021-11-10 Thread David Marchand
On Thu, Oct 28, 2021 at 2:25 PM Ananyev, Konstantin wrote: > > Add the test content of the fragment_offset(offset and MF) > > to the test_ip_frag function. Add test data for a fragment > > that is not the last fragment. > > > > Signed-off-by: huichao cai > Acked-by: Konstantin Ananyev Applied,

Re: [dpdk-dev] [PATCH v2] power: fix unused-but-set variable error

2021-11-10 Thread Jiang, YuX
> -Original Message- > From: dev On Behalf Of Jim Harris > Sent: Friday, November 5, 2021 11:54 PM > To: dev@dpdk.org; Hunt, David ; > david.march...@redhat.com > Cc: Harris, James R > Subject: [dpdk-dev] [PATCH v2] power: fix unused-but-set variable error > > clang-13 rightfully complai

Re: [dpdk-dev] [PATCH v2] examples: skip example when missing dependencies

2021-11-10 Thread David Marchand
On Sat, Nov 6, 2021 at 6:54 PM David Marchand wrote: > > Trying to disable the vhost library, meson will complain it can't build > the vhost* and vdpa examples when passing -Dexamples=all. > > -Dexamples=all skips examples if the example itself announces it can't > be built (for external dependenc

Re: [dpdk-dev] [PATCH 1/2] build: cleanup libpcap dependent components

2021-11-10 Thread David Marchand
On Mon, Nov 8, 2021 at 5:57 PM Stephen Hemminger wrote: > > The RTE_PORT_PCAP variable is used to signal libpcap availability, > > though its name seems to refer to pcap support in the port library. > > Prefer a generic name and add explicit link dependencies where needed. > > > > Fixes: 7a944656b

Re: [dpdk-dev] [PATCH v2] ci: enable ppc64le cross compilation in GHA

2021-11-10 Thread David Marchand
On Mon, Nov 8, 2021 at 6:53 PM David Christensen wrote: > > Enable Github Actions to cross-compile code for POWER systems. > > Signed-off-by: David Christensen > Reviewed-by: David Marchand Applied, thanks. -- David Marchand

Re: [dpdk-dev] [PATCH] net/ice: fix AdminQ handling on DCF passive reset

2021-11-10 Thread Zhang, Qi Z
> -Original Message- > From: Yu, DapengX > Sent: Tuesday, November 9, 2021 3:50 PM > To: Yang, Qiming ; Zhang, Qi Z > > Cc: dev@dpdk.org; Wang, Haiyue ; Yu, DapengX > ; sta...@dpdk.org > Subject: [PATCH] net/ice: fix AdminQ handling on DCF passive reset > > From: Dapeng Yu > > DCF t

Re: [dpdk-dev] [PATCH v2] power: fix unused-but-set variable error

2021-11-10 Thread David Marchand
On Wed, Nov 10, 2021 at 11:56 AM Jiang, YuX wrote: > We verify this patch > http://patches.dpdk.org/project/dpdk/patch/20211105155351.350403-1-james.r.har...@intel.com/ > based on dpdk21.11-rc2 main > branch(f4801fdb7828f45ddc4ada148b1b0a230a226570), still verify failed. > Could you pls have a

Re: [dpdk-dev] [PATCH v2] eventdev: fix Rx adapter stalls on event device backpressure

2021-11-10 Thread Jayatheerthan, Jay
Looks good. Thanks for posting this change! Acked-by: Jay Jayatheerthan > -Original Message- > From: Mattias Rönnblom > Sent: Wednesday, November 10, 2021 4:44 PM > To: jerinjac...@gmail.com; Jayatheerthan, Jay ; > Kundapura, Ganapati > ; jer...@marvell.com > Cc: dev @ dpdk . org ; mat

Re: [dpdk-dev] [PATCH] test/crypto: skip plain text compare for null cipher OOP

2021-11-10 Thread De Lara Guarch, Pablo
Hi Anoob, > -Original Message- > From: dev On Behalf Of Anoob Joseph > Sent: Monday, November 8, 2021 3:20 PM > To: Akhil Goyal ; Doherty, Declan > ; Zhang, Roy Fan > Cc: Anoob Joseph ; Jerin Jacob ; > Archana Muniganti ; Tejasree Kondoj > ; Hemant Agrawal ; > Nicolau, Radu ; Power, Ciar

Re: [dpdk-dev] [PATCH v2] power: fix unused-but-set variable error

2021-11-10 Thread Jiang, YuX
> -Original Message- > From: David Marchand > Sent: Wednesday, November 10, 2021 7:08 PM > To: Jiang, YuX > Cc: Harris, James R ; dev@dpdk.org; Hunt, David > > Subject: Re: [dpdk-dev] [PATCH v2] power: fix unused-but-set variable error > > On Wed, Nov 10, 2021 at 11:56 AM Jiang, YuX wr

[dpdk-dev] [PATCH] net/axgbe: fix PCI ID to distinguish v1000 vs e3000

2021-11-10 Thread Arsalan H. Awan
The RV PCI Root Complex Device is not visible to DPDK on the PCI bus via pci_search_device on some OSs including Ubuntu and Yocto. This makes it impossible to determine which machine DPDK/axgbe is running on. As a result, DPDK/axgbe does not work on v1000. Let's use the Raven Internal PCIe GPP Bri

Re: [dpdk-dev] [PATCH] test/crypto: skip plain text compare for null cipher OOP

2021-11-10 Thread Anoob Joseph
Hi Pablo, Thanks for the review. Please see inline. Thanks, Anoob > -Original Message- > From: De Lara Guarch, Pablo > Sent: Wednesday, November 10, 2021 4:54 PM > To: Anoob Joseph ; Akhil Goyal > ; Doherty, Declan ; > Zhang, Roy Fan > Cc: Jerin Jacob Kollanukkaran ; Archana Muniganti

Re: [dpdk-dev] [PATCH v4 0/5] Introduce DPAA DMA driver

2021-11-10 Thread Thomas Monjalon
09/11/2021 05:39, Gagandeep Singh: > Gagandeep Singh (5): > dma/dpaa: introduce DPAA DMA driver > dma/dpaa: add device probe and remove functionality > dma/dpaa: support basic operations > dma/dpaa: support DMA operations > dma/dpaa: support statistics Applied with multiple minor details

[dpdk-dev] [PATCH v2] test/crypto: skip plain text compare for null cipher

2021-11-10 Thread Anoob Joseph
NULL cipher is used for validating auth only cases. With NULL cipher, validating plain text should not be done as the PMD is only expected to update auth data. Fixes: e847fc512817 ("test/crypto: add encrypted digest case for AES-CTR-CMAC") Cc: adamx.dybkow...@intel.com Signed-off-by: Anoob Joseph

Re: [dpdk-dev] [PATCH v2] usertools/devbind: update octeontx2 DMA device

2021-11-10 Thread Thomas Monjalon
10/11/2021 00:32, Radha Mohan Chintakuntla: > The octeontx2_dma rawdev driver is removed in DPDK-21.11. The new driver > for the same device uses the dmadev. So this patch updates the device > naming and lists it under dma devices section. > > Signed-off-by: Radha Mohan Chintakuntla Applied, tha

Re: [dpdk-dev] [PATCH v9 1/5] net/enetfec: introduce NXP ENETFEC driver

2021-11-10 Thread Ferruh Yigit
On 11/10/2021 7:48 AM, Apeksha Gupta wrote: ENETFEC (Fast Ethernet Controller) is a network poll mode driver for NXP SoC i.MX 8M Mini. This patch adds skeleton for enetfec driver with probe function. Signed-off-by: Sachin Saxena Signed-off-by: Apeksha Gupta <...> @@ -0,0 +1,133 @@ +.. SPD

Re: [dpdk-dev] [PATCH v9 3/5] net/enetfec: support queue configuration

2021-11-10 Thread Ferruh Yigit
On 11/10/2021 7:48 AM, Apeksha Gupta wrote: This patch adds Rx/Tx queue configuration setup operations. On packet reception the respective BD Ring status bit is set which is then used for packet processing. Signed-off-by: Sachin Saxena Signed-off-by: Apeksha Gupta <...> + + rte_write

Re: [PATCH v9 4/5] net/enetfec: add Rx/Tx support

2021-11-10 Thread Ferruh Yigit
On 11/10/2021 7:48 AM, Apeksha Gupta wrote: This patch adds burst enqueue and dequeue operations to the enetfec PMD. Loopback mode is also added, compile time flag 'ENETFEC_LOOPBACK' is used to enable this feature. By default loopback mode is disabled. Basic features added like promiscuous enable

Re: [PATCH v9 5/5] net/enetfec: add features

2021-11-10 Thread Ferruh Yigit
On 11/10/2021 7:48 AM, Apeksha Gupta wrote: This patch adds checksum and VLAN offloads in enetfec network poll mode driver. Signed-off-by: Sachin Saxena Signed-off-by: Apeksha Gupta <...> @@ -191,7 +195,12 @@ enet_free_buffers(struct rte_eth_dev *dev) static int enetfec_eth_configure(s

[PATCH] app/testpmd: fix parameters order when calling rte_ether_addr_copy()

2021-11-10 Thread Xu, Wei1
Running in 'csum' mode, the 'from' and 'to' parameters are not in correct order when calling rte_ether_addr_copy() which means the src/dst mac addresses will be overwriten. As a result, the packets will not be recognized and received by the receiver(s). Test CLI: ./app/dpdk-testpmd -n 1 -l 1-2 -a

[PATCH] ut_test_compressdev:fix test case skipping due to missing device init

2021-11-10 Thread Changsheng Wu
The testsuite_setup function in the compressdev_autotest test case, the rte_compressdev_count() return 0 due to the lack of device init. It is considered that there is no equitment to skip execution. So add rte_vdev_init init compress_zlib device. Signed-off-by: Changsheng Wu --- app/test/te

RE: [EXTERNAL] Re: [dpdk-dev] [PATCH v16 2/9] eal: add thread attributes

2021-11-10 Thread Tyler Retzlaff
-Original Message- From: Stephen Hemminger Sent: Tuesday, November 9, 2021 8:00 PM To: Narcisa Ana Maria Vasile Cc: thomas ; dev@dpdk.org; Dmitry Kozlyuk ; Khoa To ; Dmitry Malloy ; Tyler Retzlaff ; talshn ; Omar Cardona ; bruce.richard...@intel.com; david.march...@redhat.com; Kad

Re: [dpdk-dev] [PATCH] ethdev: fine tune error reporting in pick transfer proxy API

2021-11-10 Thread Ferruh Yigit
On 11/2/2021 5:04 PM, David Marchand wrote: On Tue, Nov 2, 2021 at 4:59 PM Andrew Rybchenko wrote: IMHO, spamming of testpmd logs in described case should be fixed in testpmd itself to avoid logs in the case of ENOTSUP. That's it. I think we should not call this API in testpmd if not doing rt

Re: [PATCH 2/2] ethdev: fix the race condition for fp ops reset

2021-11-10 Thread Ferruh Yigit
On 10/23/2021 12:39 PM, Ananyev, Konstantin wrote: 22/10/2021 23:14, Bing Zhao: In the function "eth_dev_fp_ops_reset", a structure assignment operation is used to reset one queue's callback functions, etc., but it is not thread safe. The structure assignment is not atomic, a lot of instruct

RE: [PATCH 2/2] ethdev: fix the race condition for fp ops reset

2021-11-10 Thread Ananyev, Konstantin
Hi Ferruh, > >> 22/10/2021 23:14, Bing Zhao: > >>> In the function "eth_dev_fp_ops_reset", a structure assignment > >>> operation is used to reset one queue's callback functions, etc., but > >>> it is not thread safe. > >>> > >>> The structure assignment is not atomic, a lot of instructions will

Re: [dpdk-dev] [PATCH v3 0/5] mlx5: workaround MR issues

2021-11-10 Thread Thomas Monjalon
> Matan Azrad (2): > common/mlx5: add wrapped MR create API > vdpa/mlx5: workaround dirty bitmap MR creation > > Michael Baum (3): > common/mlx5: glue MR registration with IOVA > vdpa/mlx5: workaround guest MR registrations > net/mlx5: workaround MR creation for flow counter Applied, th

Re: [PATCH 2/2] ethdev: fix the race condition for fp ops reset

2021-11-10 Thread Thomas Monjalon
10/11/2021 15:37, Ananyev, Konstantin: > > Hi Ferruh, > > > >> 22/10/2021 23:14, Bing Zhao: > > >>> In the function "eth_dev_fp_ops_reset", a structure assignment > > >>> operation is used to reset one queue's callback functions, etc., but > > >>> it is not thread safe. > > >>> > > >>> The struct

[PATCH] net/szedata2: remove driver

2021-11-10 Thread Martin Spinler
Removing the szedata2 device driver as the platform is no longer supported. Signed-off-by: Martin Spinler --- MAINTAINERS |6 - doc/guides/nics/features/szedata2.ini | 18 - .../img/szedata2_nfb200g_architecture.svg | 214 -- doc/guides/nics/i

[PATCH] net/nfb: update links in documentation

2021-11-10 Thread Martin Spinler
Update the software dependency link because of website shutdown. Netcope Technologies was recently renamed to Magmio and no longer provides packages and support for the FPGA cards and NDK platform. However the project Liberouter@CESNET continues with the maintenance of Network Development Kit and

Re: [dpdk-dev] [PATCH] test/bpf_convert: do not require DNS lookup

2021-11-10 Thread Thomas Monjalon
09/11/2021 22:04, Stephen Hemminger: > These tests are testing with strings with hostname (dpdk.org) > and this makes test code do a DNS lookup. In container test > runs, DNS is unavailable. Replace dpdk.org with the current > IP and IPV6 addresses. Actual addresses don't matter the purpose > of

RE: [PATCH 2/2] ethdev: fix the race condition for fp ops reset

2021-11-10 Thread Bing Zhao
Yes +1 Let the application handle it once there is an issue. BR. Bing > -Original Message- > From: Thomas Monjalon > Sent: Wednesday, November 10, 2021 10:58 PM > To: Yigit, Ferruh ; Bing Zhao > ; Ananyev, Konstantin > > Cc: andrew.rybche...@oktetlabs.ru; dev@dpdk.org > Subject: Re: [P

Re: [dpdk-dev] [PATCH] build: factorize jansson availability check

2021-11-10 Thread Thomas Monjalon
08/11/2021 11:08, David Marchand: > Since two components wants to know if the jansson library is available, > move it to config/. > > Signed-off-by: David Marchand Applied, thanks.

[PATCH v2] net/szedata2: remove driver

2021-11-10 Thread Martin Spinler
Remove the szedata2 device driver as the platform is no longer supported. Signed-off-by: Martin Spinler --- MAINTAINERS |6 - doc/guides/nics/features/szedata2.ini | 18 - .../img/szedata2_nfb200g_architecture.svg | 214 -- doc/guides/nics/ind

[PATCH v2] net/nfb: update links in documentation

2021-11-10 Thread Martin Spinler
Update the software dependency link because of website shutdown. Netcope Technologies was recently renamed to Magmio and no longer provides packages and support for the FPGA cards and NDK platform. However the project Liberouter@CESNET continues with the maintenance of Network Development Kit and

[PATCH] mempool: fix rte primary program coredump

2021-11-10 Thread Tianli Lai
the primary program(such as ofp app) run first, then run the secondary program(such as dpdk-pdump), the primary program would receive signal SIGSEGV. the function stack as follow: aived signal SIGSEGV, Segmentation fault. [Switching to Thread 0x7fffee60e700 (LWP 112613)] 0x75f2cc0b in buck

Re: [PATCH] mempool: fix rte primary program coredump

2021-11-10 Thread David Marchand
On Wed, Nov 10, 2021 at 4:57 PM Tianli Lai wrote: > > the primary program(such as ofp app) run first, then run the secondary > program(such as dpdk-pdump), the primary program would receive signal > SIGSEGV. the function stack as follow: Is OpenFastPath linked against the same dpdk binary than yo

Re: [PATCH] app/testpmd: fix parameters order when calling rte_ether_addr_copy()

2021-11-10 Thread Stephen Hemminger
On Wed, 10 Nov 2021 08:17:59 + "Xu, Wei1" wrote: > eth_hdr = rte_pktmbuf_mtod(m, struct > rte_ether_hdr *); > - > rte_ether_addr_copy(&peer_eth_addrs[fs->peer_addr], > - > ð_

Re: [PATCH] mempool: fix rte primary program coredump

2021-11-10 Thread laitianli
Yes, OpenFastPath is the same dpdk binary with dpdk-pdump tool.

Re: [PATCH v2] net/szedata2: remove driver

2021-11-10 Thread Ferruh Yigit
On 11/10/2021 3:39 PM, Martin Spinler wrote: Remove the szedata2 device driver as the platform is no longer supported. Signed-off-by: Martin Spinler Thanks Martin for the update. It would be better to announce the removal a release in advance, to let possible users know about it and cover the

Re: [PATCH v2] net/nfb: update links in documentation

2021-11-10 Thread Ferruh Yigit
On 11/10/2021 3:39 PM, Martin Spinler wrote: Update the software dependency link because of website shutdown. Netcope Technologies was recently renamed to Magmio and no longer provides packages and support for the FPGA cards and NDK platform. However the project Liberouter@CESNET continues with

[PATCH v2] test/bpf_convert: do not require DNS lookup

2021-11-10 Thread Stephen Hemminger
These tests were using strings with hostname (dpdk.org) and this makes test code do a DNS lookup. In container environment used for OpenSuse build, DNS is unavailable. Replace dpdk.org with an IPv4 address reserved for documentation (RFC 5737) and use IPv6 in one example (RFC 3849). Actual address

Re: [dpdk-dev] [PATCH v2] net/mlx5: fix the RSS consistency check of meter policy

2021-11-10 Thread Ferruh Yigit
On 10/18/2021 3:43 PM, Bing Zhao wrote: After yellow color actions in the metering policy were supported, the RSS could be used for both green and yellow colors and only the queues attribute could be different. When specifying the attributes of a RSS, some fields can be ignored and some default

Dead code in compress/octeontx ?

2021-11-10 Thread David Marchand
Looking at drivers/compress/octeontx/meson.build: # SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2018 Cavium, Inc if not is_linux or not dpdk_conf.get('RTE_ARCH_64') build = false reason = 'only supported on 64-bit Linux' subdir_done() endif sources = files('otx_zip.c', 'otx_z

[PATCH 0/5] Extend optional libraries list

2021-11-10 Thread David Marchand
This series extends the optional libraries list adding to them testpmd non essential dependencies. We were not testing the disable_libs option, so let's add a minimum target in the the public CI script (mainly for GHA) and in test-meson-builds.sh script. The last patch is an idea for enhancing th

[PATCH 1/5] ci: test build with minimum configuration

2021-11-10 Thread David Marchand
Disabling optional libraries was not tested. Add a new target in test-meson-builds.sh and GHA. The Bluefield target is removed from test-meson-builds.sh to save space and compilation time in exchange of the new target. Signed-off-by: David Marchand --- .ci/linux-build.sh| 3 +++ .gi

[PATCH 2/5] build: make GRO/GSO optional

2021-11-10 Thread David Marchand
GRO and GSO integration in testpmd is relatively self contained and easy to extract. Those libraries can be made optional as they provide standalone features. Signed-off-by: David Marchand --- app/test-pmd/cmdline.c | 14 ++ app/test-pmd/config.c| 6 ++ app/test-pmd/csumon

[PATCH 3/5] build: make metrics libraries optional

2021-11-10 Thread David Marchand
metrics, bitratestats, jobstats and latencystats libraries can be made optional as they provide standalone features. Signed-off-by: David Marchand --- app/proc-info/main.c | 16 app/proc-info/meson.build | 5 - app/test-pmd/meson.build | 5 - app/test-pmd/testpmd

[PATCH 4/5] build: make pdump optional

2021-11-10 Thread David Marchand
This library can be made optional. dumpcap and pdump applications depend on this library, check for dependencies like what we have for examples. Signed-off-by: David Marchand --- app/meson.build | 18 +- app/test/meson.build | 10 +- lib/meson.build | 1 + 3 fi

[PATCH 5/5] build: select optional libraries

2021-11-10 Thread David Marchand
There is currently no way to know which libraries are optional. Introduce a enable_libs option (close to what we have for drivers) so that packagers or projects consuming DPDK can more easily select the optional libraries that matter to them and disable other optional libraries. Note: the enabled_

[PATCH v3] examples/multi_proces: fix Rx packets distribution

2021-11-10 Thread Gregory Etelson
MP servers distributes Rx packets between clients according to round-robin scheme. Current implementation always started packets distribution from the first client. That procedure resulted in uniform distribution in cases when Rx packets number was around clients number multiplication. However, if

Re: [dpdk-dev] [PATCH v5] net/mlx5: fix mutex unlock in txpp cleanup

2021-11-10 Thread Ferruh Yigit
On 10/12/2021 11:02 AM, Chengfeng Ye wrote: The lock sh->txpp.mutex was not correctly released on one path of cleanup function return, potentially causing the deadlock. Fixes: d133f4cdb7 ("net/mlx5: create clock queue for packet pacing") Cc: sta...@dpdk.org Signed-off-by: Chengfeng Ye --- dr

[PATCH v4] examples/multi_process: fix Rx packets distribution

2021-11-10 Thread Gregory Etelson
MP servers distributes Rx packets between clients according to round-robin scheme. Current implementation always started packets distribution from the first client. That procedure resulted in uniform distribution in cases when Rx packets number was around clients number multiplication. However, if

RE: [PATCH v2] test/crypto: skip plain text compare for null cipher

2021-11-10 Thread Power, Ciara
Hi Anoob, >-Original Message- >From: Anoob Joseph >Sent: Wednesday 10 November 2021 13:04 >To: Akhil Goyal ; Doherty, Declan >; Zhang, Roy Fan ; De >Lara Guarch, Pablo >Cc: Anoob Joseph ; Jerin Jacob ; >Archana Muniganti ; Tejasree Kondoj >; Hemant Agrawal ; >Nicolau, Radu ; Power, Ciara

Re: [PATCH] mempool: fix rte primary program coredump

2021-11-10 Thread Jerin Jacob
On Wed, Nov 10, 2021 at 9:38 PM Tianli Lai wrote: > > the primary program(such as ofp app) run first, then run the secondary > program(such as dpdk-pdump), the primary program would receive signal > SIGSEGV. the function stack as follow: > > aived signal SIGSEGV, Segmentation fault. > [Switching t

RE: [PATCH v2] test/crypto: skip plain text compare for null cipher

2021-11-10 Thread De Lara Guarch, Pablo
Hi Anoob, > -Original Message- > From: Power, Ciara > Sent: Wednesday, November 10, 2021 5:01 PM > To: Anoob Joseph ; Akhil Goyal ; > Doherty, Declan ; Zhang, Roy Fan > ; De Lara Guarch, Pablo > > Cc: Jerin Jacob ; Archana Muniganti > ; Tejasree Kondoj ; Hemant > Agrawal ; Nicolau, Radu

Re: [PATCH 5/5] build: select optional libraries

2021-11-10 Thread Bruce Richardson
On Wed, Nov 10, 2021 at 05:48:14PM +0100, David Marchand wrote: > There is currently no way to know which libraries are optional. > Introduce a enable_libs option (close to what we have for drivers) so > that packagers or projects consuming DPDK can more easily select the > optional libraries that

Re: [PATCH 0/5] Extend optional libraries list

2021-11-10 Thread Bruce Richardson
On Wed, Nov 10, 2021 at 05:48:09PM +0100, David Marchand wrote: > This series extends the optional libraries list adding to them testpmd > non essential dependencies. > > We were not testing the disable_libs option, so let's add a minimum target > in the the public CI script (mainly for GHA) and i

[PATCH] net: add macro for VLAN header length

2021-11-10 Thread Ferruh Yigit
Multiple drivers are defining macros for VLAN header length, to remove the redundancy defining macro in the ether header. And updated drivers to use the new macro. Signed-off-by: Ferruh Yigit --- drivers/net/bnx2x/bnx2x_vfpf.c | 2 +- drivers/net/bnx2x/bnx2x_vfpf.h | 2 -- drivers/ne

[PATCH] devtools: add acronyms in dictionary for commit checks

2021-11-10 Thread Ferruh Yigit
FD -> File Descriptor GUID-> Globally Unique Identifier Netlink -> Linux Netlink socket family PCIe-> Peripheral Component Interconnect Express Signed-off-by: Ferruh Yigit --- devtools/words-case.txt | 4 1 file changed, 4 insertions(+) diff --git a/devtools/words-case.txt b/d

RE: [dpdk-dev] [PATCH] hash: clarify comments for RTE_HASH_BUCKET_ENTRIES

2021-11-10 Thread Wang, Yipeng1
> -Original Message- > From: Honnappa Nagarahalli > Sent: Tuesday, November 9, 2021 11:46 AM > To: Medvedkin, Vladimir ; dev@dpdk.org > Cc: tho...@monjalon.net; Wang, Yipeng1 ; > Gobriel, Sameh ; Richardson, Bruce > ; nd ; nd > Subject: RE: [dpdk-dev] [PATCH] hash: clarify comments for >

[PATCH v2] hash: clarify comments for RTE_HASH_BUCKET_ENTRIES

2021-11-10 Thread Vladimir Medvedkin
This patch adds a comment for RTE_HASH_BUCKET_ENTRIES explaining why a particular value was chosen. Signed-off-by: Vladimir Medvedkin --- lib/hash/rte_cuckoo_hash.h | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/lib/hash/rte_cuckoo_hash.h b/lib/hash/rte_cuckoo_hash.h

Re: [PATCH v3] eventdev: negate maintenance capability flag

2021-11-10 Thread Jerin Jacob
On Wed, Nov 10, 2021 at 5:02 PM Mattias Rönnblom wrote: > > Replace RTE_EVENT_DEV_CAP_REQUIRES_MAINT, which signaled the need > for the application to call rte_event_maintain(), with > RTE_EVENT_DEV_CAP_MAINTENANCE_FREE, which does the opposite (i.e., > signifies that the event device does not req

Re: [PATCH v2] eventdev: fix Rx adapter stalls on event device backpressure

2021-11-10 Thread Jerin Jacob
On Wed, Nov 10, 2021 at 4:53 PM Jayatheerthan, Jay wrote: > > Looks good. Thanks for posting this change! > > Acked-by: Jay Jayatheerthan Changed the subject to: eventdev/eth_rx: fix stalls on event device backpressure Applied to dpdk-next-net-eventdev/for-main. Thanks > > > -Original Mes

Re: [dpdk-dev] [PATCH v2] eventdev/eth_tx: fix queue_del function

2021-11-10 Thread Jerin Jacob
On Wed, Nov 10, 2021 at 11:30 AM Naga Harish K S V wrote: > > This patch fixes heap-use-after-free reported by ASAN, > please reference https://bugs.dpdk.org/show_bug.cgi?id=869 > > The application can use the queue_id as `-1` to delete all > the queues of the eth_device that are added to tx_adapt

RE: [PATCH v2] hash: clarify comments for RTE_HASH_BUCKET_ENTRIES

2021-11-10 Thread Honnappa Nagarahalli
> > This patch adds a comment for RTE_HASH_BUCKET_ENTRIES explaining why a > particular value was chosen. > > Signed-off-by: Vladimir Medvedkin Looks good Reviewed-by: Honnappa Nagarahalli > --- > lib/hash/rte_cuckoo_hash.h | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) > >

RE: [PATCH v1 11/12] app/bbdev: use compiler atomics for thread sync

2021-11-10 Thread Honnappa Nagarahalli
> Subject: [PATCH v1 11/12] app/bbdev: use compiler atomics for thread sync There are multiple fields which are getting synchronized. How about the following: app/bbdev: use compiler atomics for synchronizing shared data > > Convert rte_atomic usages to compiler atomic built-ins for thread par

RE: [PATCH v1 07/12] app/eventdev: use compiler atomic builtins for packets sync

2021-11-10 Thread Honnappa Nagarahalli
> Subject: [PATCH v1 07/12] app/eventdev: use compiler atomic builtins for > packets sync How about the following: app/eventdev: use compiler atomic builtins for shared data synchronization > > Convert rte_atomic usages to compiler atomic built-ins for outstanding_pkts > sync in eventdev cases.

RE: [EXTERNAL] Re: [dpdk-dev] [PATCH v16 2/9] eal: add thread attributes

2021-11-10 Thread Tyler Retzlaff
-Original Message- From: Bruce Richardson Sent: Wednesday, November 10, 2021 1:21 AM To: Stephen Hemminger Cc: Tyler Retzlaff ; Narcisa Ana Maria Vasile ; thomas ; dev@dpdk.org; Dmitry Kozlyuk ; Khoa To ; Dmitry Malloy ; talshn ; Omar Cardona ; david.march...@redhat.com; Kadam, Pa

RE: [PATCH] net: add macro for VLAN header length

2021-11-10 Thread Wang, Haiyue
> -Original Message- > From: Yigit, Ferruh > Sent: Thursday, November 11, 2021 01:40 > To: Rasesh Mody ; Shahed Shaikh ; > Rahul Lakkireddy > ; Zhang, Qi Z ; Wang, > Xiao W > ; Ziyang Xuan ; Xiaoyun Wang > ; Guoyang Zhou ; Xing, > Beilei > ; Wu, Jingjing ; Yang, Qiming > ; > Xu, Rosen

[PATCH v18 3/8] eal/windows: translate Windows errors to errno-style errors

2021-11-10 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Add function to translate Windows error codes to errno-style error codes. The possible return values are chosen so that we have as much semantical compatibility between platforms as possible. Signed-off-by: Narcisa Vasile --- lib/eal/windows/rte_thread.c | 48 +

[PATCH v18 0/8] eal: Add EAL API for threading

2021-11-10 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile EAL thread API **Problem Statement** DPDK currently uses the pthread interface to create and manage threads. Windows does not support the POSIX thread programming model, so it currently relies on a header file that hides the Windows calls under pthread matched interfaces. Gi

[PATCH v18 1/8] eal: add basic threading functions

2021-11-10 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Use a portable, type-safe representation for the thread identifier. Add functions for comparing thread ids and obtaining the thread id for the current thread. Signed-off-by: Narcisa Vasile --- lib/eal/common/meson.build| 1 + lib/eal/{unix => common}/rte_threa

[PATCH v18 4/8] eal: implement functions for thread affinity management

2021-11-10 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Implement functions for getting/setting thread affinity. Threads can be pinned to specific cores by setting their affinity attribute. Signed-off-by: Narcisa Vasile Signed-off-by: Dmitry Malloy --- lib/eal/common/rte_thread.c | 16 lib/eal/include/rte_thread.h |

[PATCH v18 2/8] eal: add thread attributes

2021-11-10 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Implement thread attributes for: * thread affinity * thread priority Implement functions for managing thread attributes. Priority is represented through an enum that allows for two levels: - RTE_THREAD_PRIORITY_NORMAL - RTE_THREAD_PRIORITY_REALTIME_CRITICAL

[PATCH v18 8/8] eal: implement functions for mutex management

2021-11-10 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Add functions for mutex init, destroy, lock, unlock, trylock. Windows does not have a static initializer. Initialization is only done through InitializeCriticalSection(). To overcome this, RTE_INIT_MUTEX macro is added to replace static initialization of mutexes. The macro c

[PATCH v18 6/8] eal: add thread lifetime management

2021-11-10 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Add functions for thread creation, joining, detaching. The *rte_thread_create()* function can optionally receive an rte_thread_attr_t object that will cause the thread to be created with the affinity and priority described by the attributes object. If no rte_thread_attr_t is

[PATCH v18 5/8] eal: implement thread priority management functions

2021-11-10 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Add functions for setting and getting the priority of a thread. Priorities on multiple platforms are similarly determined by a priority value and a priority class/policy. Currently in DPDK most threads operate at the OS-default priority level but there are cases when increas

[PATCH v18 7/8] eal: implement functions for thread barrier management

2021-11-10 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Add functions for barrier init, destroy, wait. A portable type is used to represent a barrier identifier. The rte_thread_barrier_wait() function returns the same value on all platforms. Add unit tests to verify that the barrier correctly synchronizes all threads. Verify tha

[PATCH] net/iavf: fix pointer of meter data

2021-11-10 Thread Alvin Zhang
This patch fixes coverity issue by directly passing the address of the meter data to subfunction. Coverity issue: 373858 Fixes: 91f27b2e39ab ("net/iavf: refactor RSS") Cc: sta...@dpdk.org Signed-off-by: Alvin Zhang --- drivers/net/iavf/iavf_hash.c | 5 ++--- 1 file changed, 2 insertions(+), 3

Re: [dpdk-dev] [PATCH v2] doc: propose correction rte_{bsf, fls} inline functions type use

2021-11-10 Thread Tyler Retzlaff
On Tue, Oct 26, 2021 at 09:45:20AM +0200, Morten Brørup wrote: > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thomas Monjalon > > Sent: Monday, 25 October 2021 21.14 > > > > 15/03/2021 20:34, Tyler Retzlaff: > > > The proposal has resulted from request to review [1] the following > > > f

[Bug 881] [dpdk-21.11] drivers/libtmp_rte_bus_fslmc.a.p build failed on OS Fedora35 with clang 13.0.0

2021-11-10 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=881 Bug ID: 881 Summary: [dpdk-21.11] drivers/libtmp_rte_bus_fslmc.a.p build failed on OS Fedora35 with clang 13.0.0 Product: DPDK Version: 21.11 Hardware: All OS: All

Re: [dpdk-dev] [PATCH] devtools: forbid additions of __reserved

2021-11-10 Thread Tyler Retzlaff
On Sat, Oct 23, 2021 at 12:29:00PM +0200, David Marchand wrote: > __reserved is a reserved keyword in Windows system headers. > fwiw it's the c standard that stipulates identifiers starting with __ are reserved for any use. C11/C99 "ANSI-C" 7.1.3 Reserved Identifiers `All identifiers that be

[PATCH v2] net/iavf: fix pointer of meter data

2021-11-10 Thread Alvin Zhang
This patch fixes coverity issue by directly passing the address of the meter data to lower function. Coverity issue: 373867 Fixes: 91f27b2e39ab ("net/iavf: refactor RSS") Cc: sta...@dpdk.org Signed-off-by: Alvin Zhang --- drivers/net/iavf/iavf_hash.c | 5 ++--- 1 file changed, 2 insertions(+),

[PATCH] vhost: fix get hpa fail from guest pages

2021-11-10 Thread Yuan Wang
When processing front-end memory regions messages, vhost saves the guest/host physical address mappings to guest pages and merges adjacent contiguous pages if hpa is contiguous, however gpa is likely not contiguous in PA mode and merging will cause the gpa range to change. This patch distinguishes

Re: [PATCH v2] net/nfb: update links in documentation

2021-11-10 Thread Martin Spinler
On Wed, 2021-11-10 at 16:12 +, Ferruh Yigit wrote: > On 11/10/2021 3:39 PM, Martin Spinler wrote: > > Update the software dependency link because of website shutdown. > > > > Netcope Technologies was recently renamed to Magmio and no longer > > provides packages and support for the FPGA cards

RE: [EXT] Re: [dpdk-dev] [PATCH v5 1/4] doc: add skeleton for eventdevs feature matrices

2021-11-10 Thread Sunil Kumar Kori
>-Original Message- >From: Thomas Monjalon >Sent: Tuesday, November 9, 2021 5:05 PM >To: Sunil Kumar Kori ; Jerin Jacob > >Cc: Jerin Jacob Kollanukkaran ; Nikhil Rao >; Pavan Nikhilesh Bhagavatula >; Hemant Agrawal >; Nipun Gupta ; Van >Haaren, Harry ; Mattias Rönnblom >; Liang Ma ; dpdk-

[PATCH v1] net/ice: support max burst size configuration

2021-11-10 Thread Wenjun Wu
This patch adds support for max burst size configuration for TX scheduler. This feature can be tuned on by devargs: -a :18:00.0,max_burst_size=x The value of x should between 64 and 1023*1024. Signed-off-by: Wenjun Wu --- drivers/net/ice/ice_ethdev.c | 36

RE: [dpdk-dev] [PATCH v5] net/mlx5: fix mutex unlock in txpp cleanup

2021-11-10 Thread Slava Ovsiienko
Hi, Ferruh > -Original Message- > From: Ferruh Yigit > Sent: Wednesday, November 10, 2021 18:57 > To: Chengfeng Ye ; david.march...@redhat.com; > Slava Ovsiienko ; Shahaf Shuler > ; Matan Azrad > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v5] net/mlx5: fix mutex u

RE: [PATCH v1 07/12] app/eventdev: use compiler atomic builtins for packets sync

2021-11-10 Thread Joyce Kong
> > > > Subject: [PATCH v1 07/12] app/eventdev: use compiler atomic builtins > > for packets sync > How about the following: > app/eventdev: use compiler atomic builtins for shared data synchronization > Yes, please see next version. > > > > Convert rte_atomic usages to compiler atomic built-i