Hi Anoob, > -----Original Message----- > From: Power, Ciara <ciara.po...@intel.com> > Sent: Wednesday, November 10, 2021 5:01 PM > To: Anoob Joseph <ano...@marvell.com>; Akhil Goyal <gak...@marvell.com>; > Doherty, Declan <declan.dohe...@intel.com>; Zhang, Roy Fan > <roy.fan.zh...@intel.com>; De Lara Guarch, Pablo > <pablo.de.lara.gua...@intel.com> > Cc: Jerin Jacob <jer...@marvell.com>; Archana Muniganti > <march...@marvell.com>; Tejasree Kondoj <ktejas...@marvell.com>; Hemant > Agrawal <hemant.agra...@nxp.com>; Nicolau, Radu > <radu.nico...@intel.com>; Gagandeep Singh <g.si...@nxp.com>; Ji, Kai > <kai...@intel.com>; dev@dpdk.org; adamx.dybkow...@intel.com; De Lara > Guarch, Pablo <pablo.de.lara.gua...@intel.com> > Subject: RE: [PATCH v2] test/crypto: skip plain text compare for null cipher > > Hi Anoob, > > >-----Original Message----- > >From: Anoob Joseph <ano...@marvell.com> > >Sent: Wednesday 10 November 2021 13:04 > >To: Akhil Goyal <gak...@marvell.com>; Doherty, Declan > ><declan.dohe...@intel.com>; Zhang, Roy Fan <roy.fan.zh...@intel.com>; > >De Lara Guarch, Pablo <pablo.de.lara.gua...@intel.com> > >Cc: Anoob Joseph <ano...@marvell.com>; Jerin Jacob > ><jer...@marvell.com>; Archana Muniganti <march...@marvell.com>; > >Tejasree Kondoj <ktejas...@marvell.com>; Hemant Agrawal > ><hemant.agra...@nxp.com>; Nicolau, Radu <radu.nico...@intel.com>; > >Power, Ciara <ciara.po...@intel.com>; Gagandeep Singh > ><g.si...@nxp.com>; Ji, Kai <kai...@intel.com>; dev@dpdk.org; > >adamx.dybkow...@intel.com > >Subject: [PATCH v2] test/crypto: skip plain text compare for null > >cipher > > > >NULL cipher is used for validating auth only cases. With NULL cipher, > >validating plain text should not be done as the PMD is only expected to > >update auth data. > > > >Fixes: e847fc512817 ("test/crypto: add encrypted digest case for > >AES-CTR- > >CMAC") > >Cc: adamx.dybkow...@intel.com > > > >Signed-off-by: Anoob Joseph <ano...@marvell.com> > >--- > >Changes in v2: > >- Made the skip applicable for in place also (comment from Pablo) > >- Re-organized code as suggested by Pablo > >- Made same change in test_mixed_auth_cipher_sgl (comment from Pablo) > > > > app/test/test_cryptodev.c | 63 > > ++++++++++++++++++++++++++-------------- > > Acked-by: Ciara Power <ciara.po...@intel.com>
Wonder if this patch needs to CC stable, as it's fixing a commit from 2019? Apart from this: Acked-by: Pablo de Lara <pablo.de.lara.gua...@intel.com>