[dpdk-dev] [PATCH v2] examples/flow_filtering: fix wrong comment

2021-11-04 Thread Joyce Kong
Change the 'IPV4' level to 'ETH' level in the comment as it was previously misdescribed. Fixes: 9a212dc06c7a ("doc: use code snippets in sample app guides") Cc: sta...@dpdk.org Signed-off-by: Joyce Kong Reviewed-by: Ruifeng Wang --- doc/guides/sample_app_ug/flow_filtering.rst | 2 +- examples/

Re: [dpdk-dev] [PATCH v1] examples/flow_filtering: fix wrong comment

2021-11-04 Thread Joyce Kong
> > --- > > examples/flow_filtering/flow_blocks.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/examples/flow_filtering/flow_blocks.c > > b/examples/flow_filtering/flow_blocks.c > > index 3251ed9f8f..b168dc6e71 100644 > > --- a/examples/flow_filtering/flow_blocks

Re: [dpdk-dev] [PATCH v2 1/5] common/cnxk: add SSO XAQ pool create and free

2021-11-04 Thread Jerin Jacob
On Wed, Nov 3, 2021 at 2:07 PM wrote: > > From: Pavan Nikhilesh > > Add common API to create and free SSO XAQ pool. > > Signed-off-by: Pavan Nikhilesh Series applied to dpdk-next-net-eventdev/for-main. Thanks > --- > v2 Changes: > - Merge patchsets 19356,18614 to avoid merge conflicts. >

Re: [dpdk-dev] [RFC] mempool: implement index-based per core cache

2021-11-04 Thread Morten Brørup
+ Ring library maintainers (@Honnappa and @Konstantin) for my rants about its documentation. > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Dharmik Thakkar > Sent: Thursday, 4 November 2021 05.42 > > > On Nov 3, 2021, at 10:52 AM, Morten Brørup > wrote: > > > >> From: dev [mailto:dev-bo

Re: [dpdk-dev] [PATCH] config/ppc: fix meson build failure with gcc 4.8.5 on RHEL/CENTOS7

2021-11-04 Thread David Marchand
On Wed, Nov 3, 2021 at 9:01 PM David Christensen wrote: > > The POWER meson.build file incorrectly checks if the detected CPU is > "greater than" POWER8 when it should actually test for "greater than or > equal to" POWER8. Fixed the comparison operator. > > Bugzilla ID: 875 > Fixes: 750196880843

[dpdk-dev] [PATCH v3 2/2] net/ice: fix flow redirect failure

2021-11-04 Thread dapengx . yu
From: Dapeng Yu It's possible that a switch rule can't be redirect successfully due to kernel driver is busy to handle an ongoing VF reset, so the redirect action need to be deferred into next redirect request which is promised by kernel driver after VF reset done. This patch uses the saved flow

[dpdk-dev] [PATCH v3 1/2] net/ice: save rule on switch filter creation

2021-11-04 Thread dapengx . yu
From: Dapeng Yu The VSI number, lookup elements and rule information for creating switch filter are abandoned when switch filter is created in original implementation. This patch saved the abandoned data in RTE flow, it is for future use on replay when handling exception at flow redirect. Cc: s

Re: [dpdk-dev] [PATCH v20 0/5] Add PIE support for HQoS library

2021-11-04 Thread Liguzinski, WojciechX
Hi Thomas, Thanks, I will apply your suggestions asap. Wojtek -Original Message- From: Thomas Monjalon Sent: Wednesday, November 3, 2021 6:53 PM To: Liguzinski, WojciechX Cc: dev@dpdk.org; Singh, Jasvinder ; Dumitrescu, Cristian ; Ajmera, Megha ; Mcnamara, John Subject: Re: [dpdk-d

Re: [dpdk-dev] [PATCH] eal/memory: fix unused SIGBUS handler

2021-11-04 Thread Olivier Matz
On Wed, Nov 03, 2021 at 09:03:19PM +0100, David Marchand wrote: > On Fri, Oct 29, 2021 at 11:53 AM Olivier Matz wrote: > > > > Since its introduction in 2018, the SIGBUS handler was never registered, > > and all related functions were unused. > > > > A SIGBUS can be received by the application whe

[dpdk-dev] [PATCH v4 1/2] net/ice: save rule on switch filter creation

2021-11-04 Thread dapengx . yu
From: Dapeng Yu The VSI number, lookup elements and rule information for creating switch filter are abandoned when switch filter is created in original implementation. This patch saved the abandoned data in RTE flow, it is for future use on replay when handling exception at flow redirect. Cc: s

[dpdk-dev] [PATCH v4 2/2] net/ice: fix flow redirect failure

2021-11-04 Thread dapengx . yu
From: Dapeng Yu It's possible that a switch rule can't be redirect successfully due to kernel driver is busy to handle an ongoing VF reset, so the redirect action need to be deferred into next redirect request which is promised by kernel driver after VF reset done. This patch uses the saved flow

Re: [dpdk-dev] [PATCH] eal: fix mem alloc from control thread if socket 0 is unused

2021-11-04 Thread Olivier Matz
On Wed, Nov 03, 2021 at 09:26:02PM +0100, David Marchand wrote: > On Fri, Oct 29, 2021 at 11:49 AM Olivier Matz wrote: > > > > From: Ilyes Ben Hamouda > > > > When using rte_malloc() from a control thread, the used heap is the one > > from numa socket 0, which may not have available memory. > > >

Re: [dpdk-dev] [PATCH] bus/pci: fix selection of default device NUMA node

2021-11-04 Thread Olivier Matz
On Wed, Nov 03, 2021 at 09:36:49PM +0100, David Marchand wrote: > On Fri, Oct 29, 2021 at 10:45 AM Olivier Matz wrote: > > > > +CC David > > > > On Tue, Oct 26, 2021 at 11:17:08AM +0200, Olivier Matz wrote: > > > On Tue, Oct 26, 2021 at 11:06:10AM +0200, Houssem Bouhlel wrote: > > > > There can be

Re: [dpdk-dev] [RFC] build: allow build DPDK as a meson submodule

2021-11-04 Thread Bruce Richardson
On Wed, Nov 03, 2021 at 03:12:05PM -0700, Stephen Hemminger wrote: > Some other projects using meson may not be able to use DPDK > using the standard distribution pkg-config mechanism. > Meson supports a way to handle this via the subproject > https://mesonbuild.com/Subprojects.html > > This pat

Re: [dpdk-dev] [PATCH] ethdev: fix variable length flow elements support

2021-11-04 Thread Ferruh Yigit
On 11/4/2021 5:33 AM, Gregory Etelson wrote: Hello Ferruh, lib/ethdev/rte_flow.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/ethdev/rte_flow.c b/lib/ethdev/rte_flow.c index d268784532..a93f68abbc 100644 --- a/lib/ethdev/rte_flow.c +++ b/lib/ethdev/rte_fl

Re: [dpdk-dev] [PATCH v4 01/10] vdpa/sfc: introduce Xilinx vDPA driver

2021-11-04 Thread Maxime Coquelin
On 11/3/21 14:57, Vijay Srivastava wrote: From: Vijay Kumar Srivastava Add new vDPA PMD to support vDPA operations of Xilinx devices. This patch implements probe and remove functions. Signed-off-by: Vijay Kumar Srivastava Acked-by: Andrew Rybchenko --- v2: * Updated logging macros to remo

[dpdk-dev] [PATCH v2] app/testpmd: fix set Rx offloads RSS hash off

2021-11-04 Thread Jie Wang
When we set Rx offloads RSS hash off in cmdline, then we start port, if dev->data->dev_conf.rxmode.mq_mode RSS enable(multiple queues mode), it will load RSS hash in driver and sync to port. After setting Rx offloads RSS hash off, this patch removes RTE_ETH_MQ_RX_RSS in port->dev_conf.rxmode.mq_mo

Re: [dpdk-dev] [PATCH v1] examples/flow_filtering: fix wrong comment

2021-11-04 Thread Walsh, Conor
> From: Joyce Kong > Sent: Thursday 4 November 2021 07:34 > To: Walsh, Conor ; Ori Kam ; > Mcnamara, John ; Conor Fogarty > > Cc: dev@dpdk.org; nd ; sta...@dpdk.org > Subject: RE: [PATCH v1] examples/flow_filtering: fix wrong comment > > > > > > --- > > > examples/flow_filtering/flow_blocks.c

Re: [dpdk-dev] [PATCH v2] examples/flow_filtering: fix wrong comment

2021-11-04 Thread Walsh, Conor
> From: Joyce Kong > Sent: Thursday 4 November 2021 07:32 > To: Ori Kam ; Mcnamara, John > ; Conor Fogarty ; > Walsh, Conor > Cc: dev@dpdk.org; n...@arm.com; sta...@dpdk.org > Subject: [PATCH v2] examples/flow_filtering: fix wrong comment > > Change the 'IPV4' level to 'ETH' level in the comment

Re: [dpdk-dev] [PATCH v4 02/10] vdpa/sfc: add support for device initialization

2021-11-04 Thread Maxime Coquelin
On 11/3/21 14:57, Vijay Srivastava wrote: From: Vijay Kumar Srivastava Add HW initialization and vDPA device registration support. Signed-off-by: Vijay Kumar Srivastava Acked-by: Andrew Rybchenko --- v2: * Used rte_memzone_reserve_aligned for mcdi buffer allocation. * Freeing mcdi buff wh

Re: [dpdk-dev] [PATCH] test/cmdline: fix memory leak

2021-11-04 Thread David Marchand
On Fri, Oct 29, 2021 at 2:13 PM Olivier Matz wrote: > > On Fri, Oct 29, 2021 at 01:23:15PM +0200, David Marchand wrote: > > Previous change wrongly removed a valid cmdline_free(). > > > > Fixes: 6ad06203a587 ("cmdline: free on exit") > > > > Signed-off-by: David Marchand > Acked-by: Olivier Matz

Re: [dpdk-dev] [PATCH] test/mbuf: fix access to freed memory

2021-11-04 Thread David Marchand
On Wed, Nov 3, 2021 at 4:00 PM David Marchand wrote: > On Fri, Oct 29, 2021 at 2:16 PM Olivier Matz wrote: > > > > Seen by ASan. > > > > In the external buffer mbuf test, we check that the buffer is freed > > by checking that its refcount is 0. This is not a valid condition, > > because it access

Re: [dpdk-dev] [PATCH v4 06/10] vdpa/sfc: add support for dev conf and dev close ops

2021-11-04 Thread Maxime Coquelin
On 11/3/21 14:57, Vijay Srivastava wrote: From: Vijay Kumar Srivastava Implement vDPA ops dev_conf and dev_close for DMA mapping, interrupt and virtqueue configurations. Signed-off-by: Vijay Kumar Srivastava Acked-by: Andrew Rybchenko --- v2: * Removed redundant null check while calling f

[dpdk-dev] [Bug 867] [asan] mbuf: use-after-free in mbuf_autotest

2021-11-04 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=867 David Marchand (david.march...@redhat.com) changed: What|Removed |Added Resolution|--- |FIXED Sta

Re: [dpdk-dev] [PATCH v8 0/4] optimized Toeplitz hash implementation

2021-11-04 Thread Thomas Monjalon
02/11/2021 19:38, Vladimir Medvedkin: > This patch series adds a new optimized implementation for the Toeplitz hash > function using Galois Fields New instruction (GFNI). > The main use case of this function is to calculate the hash value for a single > data, so there is no bulk implementation. > F

Re: [dpdk-dev] [PATCH v4 1/3] examples/l3fwd: increase number of routes

2021-11-04 Thread Walsh, Conor
> From: dev On Behalf Of > pbhagavat...@marvell.com > Sent: Sunday 3 October 2021 21:25 > To: david.march...@redhat.com; jer...@marvell.com > Cc: dev@dpdk.org; Pavan Nikhilesh > Subject: [dpdk-dev] [PATCH v4 1/3] examples/l3fwd: increase number of > routes > > From: Pavan Nikhilesh > > Increas

Re: [dpdk-dev] [PATCH 2/3] examples/l3fwd: print port bdf when adding routes

2021-11-04 Thread Walsh, Conor
> From: dev On Behalf Of > pbhagavat...@marvell.com > Sent: Sunday 3 October 2021 21:11 > To: jer...@marvell.com > Cc: dev@dpdk.org; Pavan Nikhilesh > Subject: [dpdk-dev] [PATCH 2/3] examples/l3fwd: print port bdf when > adding routes > > From: Pavan Nikhilesh > > Since the number of Ethernet

Re: [dpdk-dev] [PATCH] eal: fix device iterator issue to find device for class type

2021-11-04 Thread David Marchand
On Tue, Nov 2, 2021 at 7:13 AM Xueming(Steven) Li wrote: > On Fri, 2021-10-29 at 16:23 +0530, Vijay Srivastava wrote: > > devarg parser rte_devargs_layers_parse() does not configures > devargs->bus_str for class type. rte_dev_iterator_init is not > setting devargs->bus_str to NULL before passing i

[dpdk-dev] [dpdk-dev v8 0/9] drivers/qat: isolate implementations of qat generations

2021-11-04 Thread Kai Ji
This patchset introduces new qat driver structure and updates existing symmetric crypto qat PMD. The purpose of the change is to isolate QAT generation specific implementations from one to another. It is expected the changes to the specific generation driver code does minimum impact to other gene

[dpdk-dev] [dpdk-dev v8 1/9] common/qat: define gen specific structs and functions

2021-11-04 Thread Kai Ji
From: Fan Zhang This patch adds the data structure and function prototypes for different QAT generations. Signed-off-by: Arek Kusztal Signed-off-by: Fan Zhang Signed-off-by: Kai Ji Acked-by: Ciara Power --- drivers/common/qat/qat_common.h | 14 -- drivers/common/qat/qat_device.c

[dpdk-dev] [dpdk-dev v8 2/9] common/qat: add gen specific device implementation

2021-11-04 Thread Kai Ji
From: Fan Zhang This patch replaces the mixed QAT device configuration implementation by separate files with shared or individual implementation for specific QAT generation. Signed-off-by: Arek Kusztal Signed-off-by: Fan Zhang Signed-off-by: Kai Ji Acked-by: Ciara Power --- drivers/common/q

[dpdk-dev] [dpdk-dev v8 3/9] common/qat: add gen specific queue pair function

2021-11-04 Thread Kai Ji
From: Fan Zhang This patch adds the queue pair data structure and function prototypes for different QAT generations. Signed-off-by: Fan Zhang Acked-by: Ciara Power --- drivers/common/qat/qat_qp.c | 3 ++ drivers/common/qat/qat_qp.h | 103 2 files changed

[dpdk-dev] [dpdk-dev v8 4/9] common/qat: add gen specific queue implementation

2021-11-04 Thread Kai Ji
From: Fan Zhang This patch replaces the mixed QAT queue pair configuration implementation by separate files with shared or individual implementation for specific QAT generation. Signed-off-by: Arek Kusztal Signed-off-by: Fan Zhang Signed-off-by: Kai Ji Acked-by: Ciara Power --- drivers/comm

[dpdk-dev] [dpdk-dev v8 5/9] compress/qat: define gen specific structs and functions

2021-11-04 Thread Kai Ji
From: Fan Zhang This patch adds the compression data structure and function prototypes for different QAT generations. Signed-off-by: Adam Dybkowski Signed-off-by: Arek Kusztal Signed-off-by: Fan Zhang Signed-off-by: Kai Ji Acked-by: Ciara Power --- .../common/qat/qat_adf/icp_qat_hw_gen4_co

[dpdk-dev] [dpdk-dev v8 6/9] compress/qat: add gen specific implementation

2021-11-04 Thread Kai Ji
From: Fan Zhang This patch replaces the mixed QAT compression support implementation by separate files with shared or individual implementation for specific QAT generation. Signed-off-by: Adam Dybkowski Signed-off-by: Arek Kusztal Signed-off-by: Fan Zhang Signed-off-by: Kai Ji Acked-by: Ciar

[dpdk-dev] [dpdk-dev v8 7/9] crypto/qat: unified device private data structure

2021-11-04 Thread Kai Ji
From: Fan Zhang This patch unifies the QAT symmetric and asymmetric device private data structures and functions. Signed-off-by: Arek Kusztal Signed-off-by: Fan Zhang Signed-off-by: Kai Ji Acked-by: Ciara Power --- drivers/common/qat/meson.build | 2 +- drivers/common/qat/qat_common

[dpdk-dev] [dpdk-dev v8 8/9] crypto/qat: define gen specific structs and functions

2021-11-04 Thread Kai Ji
From: Fan Zhang This patch adds the symmetric and asymmetric crypto data structure and function prototypes for different QAT generations. Signed-off-by: Arek Kusztal Signed-off-by: Fan Zhang Signed-off-by: Kai Ji Acked-by: Ciara Power --- drivers/crypto/qat/README |7 -

[dpdk-dev] [dpdk-dev v8 9/9] crypto/qat: add gen specific implementation

2021-11-04 Thread Kai Ji
From: Fan Zhang This patch replaces the mixed QAT symmetric and asymmetric support implementation by separate files with shared or individual implementation for specific QAT generation. Signed-off-by: Arek Kusztal Signed-off-by: Fan Zhang Signed-off-by: Kai Ji Acked-by: Ciara Power --- driv

Re: [dpdk-dev] [PATCH] hash: fix use after free in thash

2021-11-04 Thread Thomas Monjalon
03/11/2021 16:41, David Marchand: > On Fri, Oct 29, 2021 at 4:55 PM Vladimir Medvedkin > wrote: > > > > This patch fixes use after free in thash library, reported by ASAN. > > > > Bugzilla ID: 868 > > Fixes: 28ebff11c2dc ("hash: add predictable RSS") > > > > Signed-off-by: Vladimir Medvedkin > >

[dpdk-dev] [PATCH v21 0/3] Add PIE support for HQoS library

2021-11-04 Thread Liguzinski, WojciechX
From: Wojciech Liguzinski DPDK sched library is equipped with mechanism that secures it from the bufferbloat problem which is a situation when excess buffers in the network cause high latency and latency variation. Currently, it supports RED for active queue management. However, more advanced q

[dpdk-dev] [PATCH v21 1/3] sched: add PIE based congestion management

2021-11-04 Thread Liguzinski, WojciechX
Implement PIE based congestion management based on rfc8033. The Proportional Integral Controller Enhanced (PIE) algorithm works by proactively dropping packets randomly. PIE is implemented as more advanced queue management is required to address the bufferbloat problem and provide desirable qualit

[dpdk-dev] [PATCH v21 2/3] examples/qos_sched: add PIE support

2021-11-04 Thread Liguzinski, WojciechX
From: Wojciech Liguzinski patch add support enable PIE or RED by parsing config file. Signed-off-by: Wojciech Liguzinski Acked-by: Cristian Dumitrescu Acked-by: Jasvinder Singh --- config/rte_config.h| 1 - examples/qos_sched/cfg_file.c | 127 +++-- examples/qo

[dpdk-dev] [PATCH v21 3/3] examples/ip_pipeline: add PIE support

2021-11-04 Thread Liguzinski, WojciechX
From: Wojciech Liguzinski Adding the PIE support for IP Pipeline Signed-off-by: Wojciech Liguzinski Acked-by: Cristian Dumitrescu Acked-by: Jasvinder Singh --- examples/ip_pipeline/tmgr.c | 142 +++- 1 file changed, 74 insertions(+), 68 deletions(-) diff --gi

Re: [dpdk-dev] [EXT] [PATCH] doc: add table of supported operating systems for cryptodevs

2021-11-04 Thread Akhil Goyal
> Added table to the crypto device drivers documentation > stating the support of each PMD on Linux, FreeBSD and Windows. > > Signed-off-by: Tal Shnaiderman > --- Can you rebase this patch on current TOT. It needs update for the newly added PMD Chacha20-poly1305

Re: [dpdk-dev] [dpdk-stable] [PATCH v1] eal: fix random device arguments in device iterator

2021-11-04 Thread David Marchand
On Wed, Oct 27, 2021 at 10:23 AM Xueming Li wrote: > > Devargs used in device iterator initialization wasn't set to zero, random > data like bus string lead to invalid address access. > > This patch initializes devargs. > > Fixes: c99a2d4c6b7f ("eal: implement device iteration initialization") > C

Re: [dpdk-dev] [PATCH] ethdev: promote device removal check function as stable

2021-11-04 Thread Ferruh Yigit
On 10/28/2021 9:56 AM, Andrew Rybchenko wrote: On 10/28/21 11:38 AM, Kinsella, Ray wrote: On 28/10/2021 09:35, Thomas Monjalon wrote: The function rte_eth_dev_is_removed() was introduced in DPDK 18.02, and is integrated in error checks of ethdev library. It is promoted as stable ABI. Signed

Re: [dpdk-dev] [PATCH v2] net/ice: fix order of flow filter parser list

2021-11-04 Thread Zhang, Qi Z
> -Original Message- > From: Zhang, Yuying > Sent: Tuesday, November 2, 2021 6:45 PM > To: dev@dpdk.org; Zhang, Qi Z ; Zhang, Yuying > > Cc: sta...@dpdk.org > Subject: [PATCH v2] net/ice: fix order of flow filter parser list > > The order of flow filter parser list was not definite an

[dpdk-dev] [PATCH v22 0/3] Add PIE support for HQoS library

2021-11-04 Thread Liguzinski, WojciechX
From: Wojciech Liguzinski DPDK sched library is equipped with mechanism that secures it from the bufferbloat problem which is a situation when excess buffers in the network cause high latency and latency variation. Currently, it supports RED for active queue management. However, more advanced q

[dpdk-dev] [PATCH v22 1/3] sched: add PIE based congestion management

2021-11-04 Thread Liguzinski, WojciechX
From: Wojciech Liguzinski Implement PIE based congestion management based on rfc8033. The Proportional Integral Controller Enhanced (PIE) algorithm works by proactively dropping packets randomly. PIE is implemented as more advanced queue management is required to address the bufferbloat problem

[dpdk-dev] [PATCH v22 2/3] examples/qos_sched: add PIE support

2021-11-04 Thread Liguzinski, WojciechX
From: Wojciech Liguzinski patch add support enable PIE or RED by parsing config file. Signed-off-by: Wojciech Liguzinski Acked-by: Cristian Dumitrescu Acked-by: Jasvinder Singh --- config/rte_config.h| 1 - examples/qos_sched/cfg_file.c | 127 +++-- examples/qo

[dpdk-dev] [PATCH v22 3/3] examples/ip_pipeline: add PIE support

2021-11-04 Thread Liguzinski, WojciechX
From: Wojciech Liguzinski Adding the PIE support for IP Pipeline Signed-off-by: Wojciech Liguzinski Acked-by: Cristian Dumitrescu Acked-by: Jasvinder Singh --- examples/ip_pipeline/tmgr.c | 142 +++- 1 file changed, 74 insertions(+), 68 deletions(-) diff --gi

Re: [dpdk-dev] [PATCH v4 07/10] vdpa/sfc: add support to get queue notify area info

2021-11-04 Thread Maxime Coquelin
On 11/3/21 14:57, Vijay Srivastava wrote: From: Vijay Kumar Srivastava Implement the vDPA ops get_notify_area to get the notify area info of the queue. Signed-off-by: Vijay Kumar Srivastava Acked-by: Andrew Rybchenko --- v2: * Added error log in sfc_vdpa_get_notify_area. v4: * Updated pa

[dpdk-dev] [Bug 862] Uninitialized value of devargs.bus_str for RTE_DEVARGS_KEY_CLASS case

2021-11-04 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=862 David Marchand (david.march...@redhat.com) changed: What|Removed |Added Status|IN_PROGRESS |RESOLVED

Re: [dpdk-dev] [v5] security: add telemetry endpoint for cryptodev security capabilities

2021-11-04 Thread Akhil Goyal
> > Add telemetry endpoint for cryptodev security capabilities. > > Signed-off-by: Gowrishankar Muthukrishnan > --- > v5: > - fixed parsing security capabilities for a requested index. > Acked-by: Akhil Goyal Applied to dpdk-next-crypto Thanks.

Re: [dpdk-dev] [PATCH v3] test/crypto: fix: test vectors for zuc 256 bit key

2021-11-04 Thread Akhil Goyal
> Subject: [PATCH v3] test/crypto: fix: test vectors for zuc 256 bit key > > Fix the test vectors added for zuc 256-bit key > Add known vectors form ZUC 256 RFC. > > Fixes: fa5bf9345d4e (test/crypto: add ZUC cases with 256-bit keys) > > Signed-off-by: Vidya Sagar Velumuri @Pablo/Fan: Any objec

Re: [dpdk-dev] [EXT] [PATCH] test/crypto: fix test vectors for ZUC-256

2021-11-04 Thread Akhil Goyal
> Fix the IV for ZUC-256 test vectors > > Fixes: 216125c62d28 ("test/crypto: add ZUC-256 vectors") > > Signed-off-by: Pablo de Lara > --- Applied to dpdk-next-crypto Thanks.

Re: [dpdk-dev] [PATCH v4 08/10] vdpa/sfc: add support for MAC filter config

2021-11-04 Thread Maxime Coquelin
On 11/3/21 14:57, Vijay Srivastava wrote: From: Vijay Kumar Srivastava Add support for unicast and broadcast MAC filter configuration. Signed-off-by: Vijay Kumar Srivastava Acked-by: Andrew Rybchenko --- v4: * Removed redundant NULL check. * Improved line usage by rearranging function par

Re: [dpdk-dev] [PATCH v2] ethdev: mark old macros as deprecated

2021-11-04 Thread Ferruh Yigit
On 11/3/2021 10:48 PM, Ferruh Yigit wrote: Old macros kept for backward compatibility, but this cause old macro usage to sneak in silently. Marking old macros as deprecated. Downside is this will cause some noise for applications that are using old macros. Fixes: 295968d17407 ("ethdev: add name

Re: [dpdk-dev] Overriding rte_config.h

2021-11-04 Thread Ananyev, Konstantin
Hi Ben, I also don’t think 64 is a common case here. For such cases we probably should think up some different approach for the reassembly table. From: Ben Magistro Sent: Wednesday, November 3, 2021 2:38 PM To: Ananyev, Konstantin Cc: Richardson, Bruce ; dev@dpdk.org; ben.magis...@trinitycybe

[dpdk-dev] [PATCH v23 0/3] Add PIE support for HQoS library

2021-11-04 Thread Liguzinski, WojciechX
From: Wojciech Liguzinski DPDK sched library is equipped with mechanism that secures it from the bufferbloat problem which is a situation when excess buffers in the network cause high latency and latency variation. Currently, it supports RED for active queue management. However, more advanced q

[dpdk-dev] [PATCH v23 1/3] sched: add PIE based congestion management

2021-11-04 Thread Liguzinski, WojciechX
From: Wojciech Liguzinski Implement PIE based congestion management based on rfc8033. The Proportional Integral Controller Enhanced (PIE) algorithm works by proactively dropping packets randomly. PIE is implemented as more advanced queue management is required to address the bufferbloat problem

[dpdk-dev] [PATCH v23 2/3] examples/qos_sched: add PIE support

2021-11-04 Thread Liguzinski, WojciechX
From: Wojciech Liguzinski patch add support enable PIE or RED by parsing config file. Signed-off-by: Wojciech Liguzinski Acked-by: Cristian Dumitrescu Acked-by: Jasvinder Singh --- config/rte_config.h| 1 - examples/qos_sched/cfg_file.c | 127 +++-- examples/qo

[dpdk-dev] [PATCH v23 3/3] examples/ip_pipeline: add PIE support

2021-11-04 Thread Liguzinski, WojciechX
From: Wojciech Liguzinski Adding the PIE support for IP Pipeline Signed-off-by: Wojciech Liguzinski Acked-by: Cristian Dumitrescu Acked-by: Jasvinder Singh --- examples/ip_pipeline/tmgr.c | 142 +++- 1 file changed, 74 insertions(+), 68 deletions(-) diff --gi

[dpdk-dev] [PATCH] ethdev: fix crash on owner delete

2021-11-04 Thread Ferruh Yigit
'eth_dev->data' can be null before ethdev allocated. The API walks through all eth devices, at least for some data can be null. Adding 'eth_dev->data' null check before accessing it. Fixes: 33c73aae32e4 ("ethdev: allow ownership operations on unused port") Cc: sta...@dpdk.org Signed-off-by: Ferr

Re: [dpdk-dev] [PATCH v4 1/2] net/ice: save rule on switch filter creation

2021-11-04 Thread Zhang, Qi Z
> -Original Message- > From: Yu, DapengX > Sent: Thursday, November 4, 2021 4:46 PM > To: Yang, Qiming ; Zhang, Qi Z > > Cc: dev@dpdk.org; Wang, Haiyue ; Yu, DapengX > ; sta...@dpdk.org > Subject: [PATCH v4 1/2] net/ice: save rule on switch filter creation > > From: Dapeng Yu > > Th

Re: [dpdk-dev] [PATCH v4] examples/l3fwd: ipv4 and udp/tcp cksum verification through software

2021-11-04 Thread Walsh, Conor
> From: dev On Behalf Of Usama Nadeem > Sent: Thursday 14 October 2021 19:43 > To: tho...@monjalon.net > Cc: dev@dpdk.org; Usama Nadeem > Subject: [dpdk-dev] [PATCH v4] examples/l3fwd: ipv4 and udp/tcp cksum > verification through software > > checks if ipv4 and udptcp cksum offload capability a

Re: [dpdk-dev] [PATCH v4 10/10] vdpa/sfc: set a multicast filter during vDPA init

2021-11-04 Thread Maxime Coquelin
On 11/3/21 14:57, Vijay Srivastava wrote: From: Vijay Kumar Srivastava Insert unknown multicast filter to allow IPv6 neighbor discovery Signed-off-by: Vijay Kumar Srivastava Acked-by: Andrew Rybchenko Reviewed-by: Chenbo Xia --- v4: * Improved line usage by rearranging function params.

Re: [dpdk-dev] [PATCH v4 2/2] net/ice: fix flow redirect failure

2021-11-04 Thread Zhang, Qi Z
> -Original Message- > From: Yu, DapengX > Sent: Thursday, November 4, 2021 4:46 PM > To: Yang, Qiming ; Zhang, Qi Z > > Cc: dev@dpdk.org; Wang, Haiyue ; Yu, DapengX > ; sta...@dpdk.org > Subject: [PATCH v4 2/2] net/ice: fix flow redirect failure > > From: Dapeng Yu > > It's possibl

Re: [dpdk-dev] [PATCH v3] net/enic: support GTP header flow matching

2021-11-04 Thread Ferruh Yigit
On 10/28/2021 9:04 PM, John Daley wrote: The GTP, GTP-U, GTP-C header fields can be matched, however NIC does not support GTP tunneling so no items after the GTP header can be specified. If a GTP-U or GTP-C item is specified without a preceding UDP item, the UDP destination port is implicitly mat

Re: [dpdk-dev] [PATCH v2] fib: add rib extension size parameter

2021-11-04 Thread Thomas Monjalon
27/10/2021 17:49, Vladimir Medvedkin: > This patch adds a new parameter to the fib configuration to specify > the size of the extension for internal RIB structure. > > Signed-off-by: Vladimir Medvedkin > Tested-by: Conor Walsh > --- > --- a/doc/guides/rel_notes/release_21_11.rst > +++ b/doc/guid

Re: [dpdk-dev] [EXT] [dpdk-dev v8 0/9] drivers/qat: isolate implementations of qat generations

2021-11-04 Thread Akhil Goyal
> This patchset introduces new qat driver structure and updates > existing symmetric crypto qat PMD. > > The purpose of the change is to isolate QAT generation specific > implementations from one to another. > > It is expected the changes to the specific generation driver > code does minimum impa

Re: [dpdk-dev] [PATCH] crypto/qat: fix qp number

2021-11-04 Thread Akhil Goyal
> > Subject: [dpdk-dev] [PATCH] crypto/qat: fix qp number > > > > This patch fixes incorrect number of queue pairs > > > > Fixes: 4c0d2ee23c39 ("crypto/qat: remove incorrect usage of bundle > number" ) > > Cc: roy.fan.zh...@intel.com > > > > Signed-off-by: Przemyslaw Zegan > > --- > > Acked-by: A

Re: [dpdk-dev] [EXT] [PATCH] crypto/qat: fix access to null pointer

2021-11-04 Thread Akhil Goyal
> This patch fixes a possible access to null pointer > > Fixes: 9f4b9222019c ("common/qat: add gen specific queue > implementation") > Cc: roy.fan.zh...@intel.com > > Signed-off-by: Przemyslaw Zegan Patch squashed to original patch as it was not merged. Fixed check patch error.

Re: [dpdk-dev] [PATCH] net/sfc: add Xilinx vendor/device ID for Riverhead VF

2021-11-04 Thread Ferruh Yigit
On 10/29/2021 4:33 PM, Andrew Rybchenko wrote: From: Igor Romanov Add the device and vendor numbers to the PCI ID map so that a VF can be probed. Signed-off-by: Igor Romanov Signed-off-by: Andrew Rybchenko Updated patch title as: net/sfc: support Xilinx Riverhead VF Applied to dpdk-next-n

Re: [dpdk-dev] [PATCH v4] net/af_packet: fix ignoring full ring on tx

2021-11-04 Thread Ferruh Yigit
On 11/3/2021 9:31 AM, Tudor Cornea wrote: The poll call can return POLLERR which is ignored, or it can return POLLOUT, even if there are no free frames in the mmap-ed area. We can account for both of these cases by re-checking if the next frame is empty before writing into it. We have attempted

Re: [dpdk-dev] [PATCH v3] test/crypto: fix: test vectors for zuc 256 bit key

2021-11-04 Thread De Lara Guarch, Pablo
> -Original Message- > From: Akhil Goyal > Sent: Thursday, November 4, 2021 10:53 AM > To: Vidya Sagar Velumuri ; Ankur Dwivedi > ; Anoob Joseph ; Tejasree > Kondoj ; Nithin Kumar Dabilpuram > ; Zhang, Roy Fan ; De > Lara Guarch, Pablo > Cc: dev@dpdk.org > Subject: RE: [PATCH v3] test/

Re: [dpdk-dev] [PATCH] eal: fix unused-but-set-variable error

2021-11-04 Thread David Marchand
On Fri, Oct 29, 2021 at 8:48 PM David Marchand wrote: > > On Fri, Oct 29, 2021 at 7:17 PM Jim Harris wrote: > > > > clang-13 rightfully complains that the total_mem > > variable in eal_parse_socket_arg is set but not > > used, since the final accumulated total_mem > > result isn't used anywhere.

Re: [dpdk-dev] [PATCH] net/mlx5: fix debug variable initialization

2021-11-04 Thread Ferruh Yigit
On 11/4/2021 12:23 PM, Gregory Etelson wrote: Use `__rte_unused` macro to mask a debug variable instead of `#ifdef`. This way, if the variable is used in a macro, it does not depend on how the macro is expanded. Fixes: 91f0e029ce5f ("net/mlx5: translate flex item pattern into matcher") Signed-of

Re: [dpdk-dev] [PATCH 1/3] eventdev: allow for event devices requiring maintenance

2021-11-04 Thread Jerin Jacob
On Sun, Oct 31, 2021 at 6:47 PM Jerin Jacob wrote: > > On Sat, Oct 30, 2021 at 10:49 PM Mattias Rönnblom > wrote: > > > > On 2021-10-29 17:17, Jerin Jacob wrote: > > > On Fri, Oct 29, 2021 at 8:33 PM Mattias Rönnblom > > > wrote: > > >> On 2021-10-29 16:38, Jerin Jacob wrote: > > >>> On Tue, Oct

Re: [dpdk-dev] [PATCH v2] ethdev: fix variable length flow elements support

2021-11-04 Thread Ferruh Yigit
On 11/4/2021 11:27 AM, Gregory Etelson wrote: RTE flow API defines two flow elements types - common and PMD private. Common RTE flow types are defined in rte_flow.h while PMD private types exists inside specific PMD only. Application can create a flow rule with PMD private items or actions. RTE f

Re: [dpdk-dev] [PATCH v2] ethdev: mark old macros as deprecated

2021-11-04 Thread Thomas Monjalon
04/11/2021 12:03, Ferruh Yigit: > On 11/3/2021 10:48 PM, Ferruh Yigit wrote: > > Old macros kept for backward compatibility, but this cause old macro > > usage to sneak in silently. > > > > Marking old macros as deprecated. Downside is this will cause some noise > > for applications that are using

Re: [dpdk-dev] [PATCH v4 00/10] vdpa/sfc: introduce Xilinx vDPA driver

2021-11-04 Thread Maxime Coquelin
On 11/3/21 14:57, Vijay Srivastava wrote: This patch series introduces vDPA driver for Xilinx devices. The Xilinx vDPA (vhost data path acceleration) provides support for the Xilinx SN1022 SmartNICs. Vijay Kumar Srivastava (10): vdpa/sfc: introduce Xilinx vDPA driver vdpa/sfc: add suppo

Re: [dpdk-dev] [PATCH v4] examples/l3fwd: ipv4 and udp/tcp cksum verification through software

2021-11-04 Thread Ananyev, Konstantin
> checks if ipv4 and udptcp cksum offload capability available > If not available, cksum is verified through software > If cksum is corrupt, packet is dropped, rest of the packets > are forwarded back. >From what I see right now l3fwd: a) enables HW RX cksum offload b) simply ignores HW pro

Re: [dpdk-dev] [PATCH] doc: remove deprecation notices for eventdev

2021-11-04 Thread Jerin Jacob
On Tue, Nov 2, 2021 at 9:59 PM Jerin Jacob wrote: > > On Tue, Nov 2, 2021 at 9:31 PM Thomas Monjalon wrote: > > > > 02/11/2021 16:49, jer...@marvell.com: > > > From: Jerin Jacob > > > > > > All deprecation notice targeted for v21.11 of eventdev has been > > > committed in the following commits,

Re: [dpdk-dev] [PATCH v23 1/3] sched: add PIE based congestion management

2021-11-04 Thread Thomas Monjalon
04/11/2021 12:03, Liguzinski, WojciechX: > From: Wojciech Liguzinski > > Implement PIE based congestion management based on rfc8033. > > The Proportional Integral Controller Enhanced (PIE) algorithm works > by proactively dropping packets randomly. > PIE is implemented as more advanced queue man

Re: [dpdk-dev] [PATCH] eal/linux: fix uevent message parsing

2021-11-04 Thread Maxime Coquelin
On 11/2/21 19:40, David Marchand wrote: Caught with ASan: ==9727==ERROR: AddressSanitizer: stack-buffer-overflow on address 0x7f0daa2fc0d0 at pc 0x7f0daeefacb2 bp 0x7f0daa2fadd0 sp 0x7f0daa2fa578 READ of size 1 at 0x7f0daa2fc0d0 thread T1 #0 0x7f0daeefacb1 (/lib64/libasan.so.5+0xbacb1

[dpdk-dev] [pull-request] dpdk-next-eventdev - v21.11 - RC2

2021-11-04 Thread Jerin Jacob Kollanukkaran
The following changes since commit b5832a0d1524b31782eb04a6e8f95f952a7eed66: regex/mlx5: prevent double setup of queue pair (2021-11-03 23:15:10 +0100) are available in the Git repository at: http://dpdk.org/git/next/dpdk-next-eventdev for you to fetch changes up to 784cc4352850895706619044

Re: [dpdk-dev] [PATCH 2/4] net/mlx5: add support for Rx queue delay drop

2021-11-04 Thread David Marchand
On Thu, Nov 4, 2021 at 12:27 PM Bing Zhao wrote: > > For an Ethernet RQ, packets received when receive WQEs are exhausted > are dropped. This behavior prevents slow or malicious software > entities at the host from affecting the network. While for hairpin > cases, even if there is no software invo

Re: [dpdk-dev] [PATCH] eal: fix device hotplug

2021-11-04 Thread Maxime Coquelin
On 11/2/21 08:52, David Marchand wrote: The device event interrupt handler was always freed. Bugzilla ID: 845 Fixes: c2bd9367e18f ("lib: remove direct access to interrupt handle") Signed-off-by: David Marchand --- lib/eal/linux/eal_dev.c | 12 +--- 1 file changed, 9 insertions(+)

Re: [dpdk-dev] Doubt regarding DPDK hash Library implementation

2021-11-04 Thread Thomas Monjalon
+Cc hash lib maintainers 01/11/2021 11:55, Syam Prasad N Pearson: > Dear Sir/Madam, > I am a developer trying to get familiar with the DPDK hash library. I tried > to make and use a hash table successfully. > During the development I came across a variable > > /** Number of items per bucket. */ >

Re: [dpdk-dev] [PATCH] bus/pci: fix use after free on unplug

2021-11-04 Thread Maxime Coquelin
On 11/3/21 12:16, David Marchand wrote: rte_pci_unmap_device() needs intr_handle objects to unregister callbacks. Bugzilla ID: 845 Fixes: d61138d4f0e2 ("drivers: remove direct access to interrupt handle") Signed-off-by: David Marchand --- drivers/bus/pci/pci_common.c | 17 +---

Re: [dpdk-dev] [PATCH] eal: fix device hotplug

2021-11-04 Thread David Marchand
On Tue, Nov 2, 2021 at 10:35 AM Jiang, YuX wrote: > > -Original Message- > > From: David Marchand > > Sent: Tuesday, November 2, 2021 3:53 PM > > To: dev@dpdk.org > > Cc: Jiang, YuX ; Harman Kalra > > Subject: [PATCH] eal: fix device hotplug > > > > The device event interrupt handler was

Re: [dpdk-dev] [PATCH] eal/linux: fix uevent message parsing

2021-11-04 Thread David Marchand
On Thu, Nov 4, 2021 at 3:00 PM Maxime Coquelin wrote: > On 11/2/21 19:40, David Marchand wrote: > > Caught with ASan: > > ==9727==ERROR: AddressSanitizer: stack-buffer-overflow on address > >0x7f0daa2fc0d0 at pc 0x7f0daeefacb2 bp 0x7f0daa2fadd0 sp 0x7f0daa2fa578 > > READ of size 1 at 0x7f0daa2

Re: [dpdk-dev] [PATCH] bus/pci: fix use after free on unplug

2021-11-04 Thread David Marchand
On Thu, Nov 4, 2021 at 3:16 PM Maxime Coquelin wrote: > On 11/3/21 12:16, David Marchand wrote: > > rte_pci_unmap_device() needs intr_handle objects to unregister > > callbacks. > > > > Bugzilla ID: 845 > > Fixes: d61138d4f0e2 ("drivers: remove direct access to interrupt handle") > > > > Signed-of

Re: [dpdk-dev] [PATCH 2/4] net/hns3: fix MP action register and unregister

2021-11-04 Thread Ferruh Yigit
On 11/2/2021 1:38 AM, Min Hu (Connor) wrote: From: Huisong Li The multi-process has the following problems: 1) After a port in primary process is closed, the mp action of the process is unregistered. which will cause that other device in the primary process cannot respond to requests fr

Re: [dpdk-dev] [PATCH] eal: fix device hotplug

2021-11-04 Thread David Marchand
On Thu, Nov 4, 2021 at 3:11 PM Maxime Coquelin wrote: > On 11/2/21 08:52, David Marchand wrote: > > The device event interrupt handler was always freed. > > > > Bugzilla ID: 845 > > Fixes: c2bd9367e18f ("lib: remove direct access to interrupt handle") > > > > Signed-off-by: David Marchand Tested-

Re: [dpdk-dev] [PATCH 0/4] bugfix for multi process of hns3 PMD

2021-11-04 Thread Ferruh Yigit
On 11/2/2021 1:38 AM, Min Hu (Connor) wrote: This patch set contains bugfix and code optimization for multi process of hns3 PMD. Huisong Li (4): net/hns3: decrease the count when secondary process exits net/hns3: fix MP action register and unregister net/hns3: fix lack of unregistering

Re: [dpdk-dev] [PATCH v23 1/3] sched: add PIE based congestion management

2021-11-04 Thread Dumitrescu, Cristian
> -Original Message- > From: Thomas Monjalon > Sent: Thursday, November 4, 2021 1:58 PM > To: Singh, Jasvinder ; Dumitrescu, Cristian > ; Liguzinski, WojciechX > > Cc: dev@dpdk.org; Ajmera, Megha ; Liguzinski, > WojciechX > Subject: Re: [dpdk-dev] [PATCH v23 1/3] sched: add PIE based

[dpdk-dev] [Bug 792] [asan] The dev_uev_parse function has a stack overflow bug

2021-11-04 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=792 David Marchand (david.march...@redhat.com) changed: What|Removed |Added Resolution|--- |FIXED Sta

Re: [dpdk-dev] Doubt regarding DPDK hash Library implementation

2021-11-04 Thread Kinsella, Ray
I would guess it - I would say it is related to cache alignment. Assuming each entry is 8 bytes 😊 Ray K > -Original Message- > From: Thomas Monjalon > Sent: Thursday 4 November 2021 14:12 > To: Syam Prasad N Pearson > Cc: us...@dpdk.org; dev@dpdk.org; Wang, Yipeng1 > ; Gobriel, Sameh ;

  1   2   >