Hi Thomas, Thanks, I will apply your suggestions asap.
Wojtek -----Original Message----- From: Thomas Monjalon <tho...@monjalon.net> Sent: Wednesday, November 3, 2021 6:53 PM To: Liguzinski, WojciechX <wojciechx.liguzin...@intel.com> Cc: dev@dpdk.org; Singh, Jasvinder <jasvinder.si...@intel.com>; Dumitrescu, Cristian <cristian.dumitre...@intel.com>; Ajmera, Megha <megha.ajm...@intel.com>; Mcnamara, John <john.mcnam...@intel.com> Subject: Re: [dpdk-dev] [PATCH v20 0/5] Add PIE support for HQoS library 03/11/2021 00:57, Liguzinski, WojciechX: > From: Wojciech Liguzinski <wojciechx.liguzin...@intel.com> > > DPDK sched library is equipped with mechanism that secures it from the > bufferbloat problem which is a situation when excess buffers in the > network cause high latency and latency variation. Currently, it > supports RED for active queue management. However, more advanced queue > management is required to address this problem and provide desirable quality > of service to users. > > This solution (RFC) proposes usage of new algorithm called "PIE" > (Proportional Integral controller Enhanced) that can effectively and > directly control queuing latency to address the bufferbloat problem. > > The implementation of mentioned functionality includes modification of > existing and adding a new set of data structures to the library, adding PIE > related APIs. > This affects structures in public API/ABI. That is why deprecation > notice is going to be prepared and sent. > > Wojciech Liguzinski (5): > sched: add PIE based congestion management Did you see the checkpatch issues on this patch? http://mails.dpdk.org/archives/test-report/2021-November/238253.html > example/qos_sched: add PIE support The strict minimum is to explain why you add PIE and what the acronym means, inside the commit log. > example/ip_pipeline: add PIE support Title should follow same convention as history. For examples, it start with "examples/" as the directory name. > doc/guides/prog_guide: added PIE doc should be squashed with code patches Is there any doc update related to the examples? If not, it should be fully squashed with lib changes. > app/test: add tests for PIE If there is nothing special, it can be squashed with the lib patch.
