> -----Original Message-----
> From: Thomas Monjalon <tho...@monjalon.net>
> Sent: Thursday, November 4, 2021 1:58 PM
> To: Singh, Jasvinder <jasvinder.si...@intel.com>; Dumitrescu, Cristian
> <cristian.dumitre...@intel.com>; Liguzinski, WojciechX
> <wojciechx.liguzin...@intel.com>
> Cc: dev@dpdk.org; Ajmera, Megha <megha.ajm...@intel.com>; Liguzinski,
> WojciechX <wojciechx.liguzin...@intel.com>
> Subject: Re: [dpdk-dev] [PATCH v23 1/3] sched: add PIE based congestion
> management
>
> 04/11/2021 12:03, Liguzinski, WojciechX:
> > From: Wojciech Liguzinski <wojciechx.liguzin...@intel.com>
> >
> > Implement PIE based congestion management based on rfc8033.
> >
> > The Proportional Integral Controller Enhanced (PIE) algorithm works
> > by proactively dropping packets randomly.
> > PIE is implemented as more advanced queue management is required to
> > address the bufferbloat problem and provide desirable quality of
> > service to users.
> >
> > Tests for PIE code added to test application.
> > Added PIE related information to documentation.
> >
> > Signed-off-by: Wojciech Liguzinski <wojciechx.liguzin...@intel.com>
> > Acked-by: Cristian Dumitrescu <cristian.dumitre...@intel.com>
> > Acked-by: Jasvinder Singh <jasvinder.si...@intel.com>
> >
> > --
>
> It should be 3 dashes to make the below hidden in git.
>
> > Changes in V23:
> > - Coding style fixed
> >
> > Changes in V22:
> > - Coding style fixed
> >
> > Changes in V21:
> > - Coding style fixed
> > - Patches reorganized according to comments
> >
> > Changes in V20:
> > - Removed API conditional compilation
> > - Added flag to indicate cman enabled/disabled
> > - Fixed submitter data in patches
> >
> > Changes in V19:
> > - ACKs included in patches
> >
> > Changes in V18:
> > - Resolved merge conflict in lib/sched/meson.build after rebasing ontop of
> main
> > - Reverted whitespace change in app_thread.c - comment from Stephen
> Hemminger
> >
> > Changes in V17:
> > - Corrected paragraph link naming in qos_framework.rst to fix CI builds
> >
> > Changes in V16:
> > - Fixed 'title underline too short' error in qos_framework.rst
> > - Applied __rte_unused macro to parameters in
> rte_sched_port_pie_dequeue()
> >
> > ---
> > app/test/meson.build | 4 +
> > app/test/test_pie.c | 1065 ++++++++++++++++++
> > doc/guides/prog_guide/glossary.rst | 3 +
> > doc/guides/prog_guide/qos_framework.rst | 64 +-
> > doc/guides/prog_guide/traffic_management.rst | 13 +-
> > drivers/net/softnic/rte_eth_softnic_tm.c | 6 +-
> > lib/sched/meson.build | 3 +-
> > lib/sched/rte_pie.c | 86 ++
> > lib/sched/rte_pie.h | 398 +++++++
> > lib/sched/rte_sched.c | 254 +++--
> > lib/sched/rte_sched.h | 64 +-
> > lib/sched/version.map | 4 +
> > 12 files changed, 1860 insertions(+), 104 deletions(-)
> > create mode 100644 app/test/test_pie.c
> > create mode 100644 lib/sched/rte_pie.c
> > create mode 100644 lib/sched/rte_pie.h
>
> Adding this change to include the new test in sched library maintainership:
>
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1428,6 +1428,7 @@ M: Cristian Dumitrescu
> <cristian.dumitre...@intel.com>
> M: Jasvinder Singh <jasvinder.si...@intel.com>
> F: lib/sched/
> F: doc/guides/prog_guide/qos_framework.rst
> +F: app/test/test_pie.c
> F: app/test/test_red.c
> F: app/test/test_sched.c
> F: examples/qos_sched/
>
> Cristian, Jasvinder, I didn't see a lot of comments from you on this patch,
> so I assume you are OK with this change.
>
Hi Thomas,
Yes, I am.
Regards,
Cristian
