[dpdk-dev] [PATCH] net/i40e: fix forward outer IPv6 VXLAN packets

2021-11-02 Thread Jie Wang
Testpmd forwards packets in checksum mode that it need to calculate the checksum of each layer's protocol. Then it will fill flags and header length into mbuf. In process_outer_cksums, HW calculates the outer checksum if tx_offloads contains outer UDP checksum otherwise SW calculates the outer che

[dpdk-dev] [PATCH v2] net/ice: fix order of flow filter parser list

2021-11-02 Thread Yuying Zhang
The order of flow filter parser list was not definite and linked to the register order of parsers. It caused ACL filter covered by switch filter in some cases. This patch fixed order of parser list to guarantee the usage of each filter. Below lists the order. ACL filter > Switch filter > FDIR > Ha

[dpdk-dev] [PATCH] net/i40e: fix forward outer IPv6 VXLAN packets

2021-11-02 Thread Jie Wang
Testpmd forwards packets in checksum mode that it need to calculate the checksum of each layer's protocol. Then it will fill flags and header length into mbuf. In process_outer_cksums, HW calculates the outer checksum if tx_offloads contains outer UDP checksum otherwise SW calculates the outer che

Re: [dpdk-dev] [PATCH v3 03/10] vdpa/sfc: add support to get device and protocol features

2021-11-02 Thread Xia, Chenbo
> -Original Message- > From: Vijay Srivastava > Sent: Friday, October 29, 2021 10:47 PM > To: dev@dpdk.org > Cc: maxime.coque...@redhat.com; Xia, Chenbo ; > andrew.rybche...@oktetlabs.ru; Vijay Kumar Srivastava > Subject: [PATCH v3 03/10] vdpa/sfc: add support to get device and protocol >

Re: [dpdk-dev] [PATCH v3 05/10] vdpa/sfc: add support to get VFIO device fd

2021-11-02 Thread Xia, Chenbo
> -Original Message- > From: Vijay Srivastava > Sent: Friday, October 29, 2021 10:47 PM > To: dev@dpdk.org > Cc: maxime.coque...@redhat.com; Xia, Chenbo ; > andrew.rybche...@oktetlabs.ru; Vijay Kumar Srivastava > Subject: [PATCH v3 05/10] vdpa/sfc: add support to get VFIO device fd > > F

Re: [dpdk-dev] [PATCH v3 06/10] vdpa/sfc: add support for dev conf and dev close ops

2021-11-02 Thread Xia, Chenbo
Hi Vijay, > -Original Message- > From: Vijay Srivastava > Sent: Friday, October 29, 2021 10:47 PM > To: dev@dpdk.org > Cc: maxime.coque...@redhat.com; Xia, Chenbo ; > andrew.rybche...@oktetlabs.ru; Vijay Kumar Srivastava > Subject: [PATCH v3 06/10] vdpa/sfc: add support for dev conf and

Re: [dpdk-dev] [PATCH v3 04/10] vdpa/sfc: get device supported max queue count

2021-11-02 Thread Xia, Chenbo
> -Original Message- > From: Vijay Srivastava > Sent: Friday, October 29, 2021 10:47 PM > To: dev@dpdk.org > Cc: maxime.coque...@redhat.com; Xia, Chenbo ; > andrew.rybche...@oktetlabs.ru; Vijay Kumar Srivastava > Subject: [PATCH v3 04/10] vdpa/sfc: get device supported max queue count >

Re: [dpdk-dev] [PATCH v3 07/10] vdpa/sfc: add support to get queue notify area info

2021-11-02 Thread Xia, Chenbo
Hi Vijay, > -Original Message- > From: Vijay Srivastava > Sent: Friday, October 29, 2021 10:47 PM > To: dev@dpdk.org > Cc: maxime.coque...@redhat.com; Xia, Chenbo ; > andrew.rybche...@oktetlabs.ru; Vijay Kumar Srivastava > Subject: [PATCH v3 07/10] vdpa/sfc: add support to get queue noti

Re: [dpdk-dev] [PATCH v3 02/10] vdpa/sfc: add support for device initialization

2021-11-02 Thread Vijay Kumar Srivastava
Hi Chenbo, >-Original Message- >From: Xia, Chenbo >Sent: Monday, November 1, 2021 5:19 PM >To: Vijay Kumar Srivastava ; dev@dpdk.org >Cc: maxime.coque...@redhat.com; andrew.rybche...@oktetlabs.ru; Vijay >Kumar Srivastava >Subject: RE: [PATCH v3 02/10] vdpa/sfc: add support for device in

Re: [dpdk-dev] [PATCH v3 02/10] vdpa/sfc: add support for device initialization

2021-11-02 Thread Xia, Chenbo
> -Original Message- > From: Vijay Kumar Srivastava > Sent: Tuesday, November 2, 2021 3:43 PM > To: Xia, Chenbo ; dev@dpdk.org > Cc: maxime.coque...@redhat.com; andrew.rybche...@oktetlabs.ru; Praveen Kumar > Jain ; Harpreet Singh Anand > Subject: RE: [PATCH v3 02/10] vdpa/sfc: add support

[dpdk-dev] [PATCH] eal: fix device hotplug

2021-11-02 Thread David Marchand
The device event interrupt handler was always freed. Bugzilla ID: 845 Fixes: c2bd9367e18f ("lib: remove direct access to interrupt handle") Signed-off-by: David Marchand --- lib/eal/linux/eal_dev.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/lib/eal/linux/ea

[dpdk-dev] [PATCH 1/2] net/txgbe: fix RxTx packet statistics

2021-11-02 Thread Jiawen Wu
Fix specific length packet statistics caused by wrong register addresses. Fixes: 24a4c76aff4d ("net/txgbe: add error types and registers") Cc: sta...@dpdk.org Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_regs.h | 48 ++--- 1 file changed, 24 insertions(+), 2

[dpdk-dev] [PATCH 2/2] net/txgbe: fix link process in KR mode

2021-11-02 Thread Jiawen Wu
Set the 'present' parameter to 0 by default. It is configured by hardware, users can set it to 1 for manual configuration. Fixes: f611dada1af8 ("net/txgbe: update link setup process of backplane NICs") Cc: sta...@dpdk.org Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_phy.c | 2 +- d

Re: [dpdk-dev] [PATCH v3 08/10] vdpa/sfc: add support for MAC filter config

2021-11-02 Thread Xia, Chenbo
Hi Vijay, > -Original Message- > From: Vijay Srivastava > Sent: Friday, October 29, 2021 10:47 PM > To: dev@dpdk.org > Cc: maxime.coque...@redhat.com; Xia, Chenbo ; > andrew.rybche...@oktetlabs.ru; Vijay Kumar Srivastava > Subject: [PATCH v3 08/10] vdpa/sfc: add support for MAC filter co

Re: [dpdk-dev] [PATCH v3 09/10] vdpa/sfc: add support to set vring state

2021-11-02 Thread Xia, Chenbo
> -Original Message- > From: Vijay Srivastava > Sent: Friday, October 29, 2021 10:47 PM > To: dev@dpdk.org > Cc: maxime.coque...@redhat.com; Xia, Chenbo ; > andrew.rybche...@oktetlabs.ru; Vijay Kumar Srivastava > Subject: [PATCH v3 09/10] vdpa/sfc: add support to set vring state > > From

Re: [dpdk-dev] [PATCH v3 10/10] vdpa/sfc: set a multicast filter during vDPA init

2021-11-02 Thread Xia, Chenbo
> -Original Message- > From: Vijay Srivastava > Sent: Friday, October 29, 2021 10:47 PM > To: dev@dpdk.org > Cc: maxime.coque...@redhat.com; Xia, Chenbo ; > andrew.rybche...@oktetlabs.ru; Vijay Kumar Srivastava > Subject: [PATCH v3 10/10] vdpa/sfc: set a multicast filter during vDPA init

Re: [dpdk-dev] [PATCH v2 1/6] dma/dpaa: introduce DPAA DMA driver

2021-11-02 Thread fengchengwen
On 2021/11/1 16:51, Gagandeep Singh wrote: > The DPAA DMA driver is an implementation of the dmadev APIs, > that provide means to initiate a DMA transaction from CPU. > The initiated DMA is performed without CPU being involved > in the actual DMA transaction. This is achieved via using > the QDMA

Re: [dpdk-dev] [PATCH v2] vhost: mark vDPA driver API as internal

2021-11-02 Thread Maxime Coquelin
On 11/1/21 07:50, Xia, Chenbo wrote: -Original Message- From: Maxime Coquelin Sent: Thursday, October 28, 2021 10:16 PM To: dev@dpdk.org; techbo...@dpdk.org; Xia, Chenbo ; xuemi...@nvidia.com; Wang, Xiao W ; david.march...@redhat.com Cc: Maxime Coquelin Subject: [PATCH v2] vhost: mar

Re: [dpdk-dev] [PATCH v2 2/6] dma/dpaa: add device probe and remove functionality

2021-11-02 Thread fengchengwen
On 2021/11/1 16:51, Gagandeep Singh wrote: > This patch add device initialisation functionality. > > Signed-off-by: Gagandeep Singh [snip] > + > +static void fsl_qdma_free_chan_resources(struct fsl_qdma_chan *fsl_chan) > +{ > + struct fsl_qdma_queue *fsl_queue = fsl_chan->queue; > + str

Re: [dpdk-dev] [PATCH v2 4/6] dma/dpaa: support basic operations

2021-11-02 Thread fengchengwen
On 2021/11/1 16:51, Gagandeep Singh wrote: > This patch support basic DMA operations which includes > device capability and channel setup. > > Signed-off-by: Gagandeep Singh > --- > drivers/dma/dpaa/dpaa_qdma.c | 185 +++ > drivers/dma/dpaa/dpaa_qdma.h | 6 ++

Re: [dpdk-dev] [PATCH v2 5/6] dma/dpaa: support DMA operations

2021-11-02 Thread fengchengwen
On 2021/11/1 16:51, Gagandeep Singh wrote: > This patch support copy, submit, completed and > completed status functionality of DMA driver. > > Signed-off-by: Gagandeep Singh ... > + > +static int fsl_qdma_enqueue_desc(struct fsl_qdma_chan *fsl_chan, > + struct fsl

Re: [dpdk-dev] [PATCH] eal: fix device hotplug

2021-11-02 Thread Jiang, YuX
> -Original Message- > From: David Marchand > Sent: Tuesday, November 2, 2021 3:53 PM > To: dev@dpdk.org > Cc: Jiang, YuX ; Harman Kalra > Subject: [PATCH] eal: fix device hotplug > > The device event interrupt handler was always freed. > > Bugzilla ID: 845 > Fixes: c2bd9367e18f ("lib:

Re: [dpdk-dev] [PATCH v3 07/10] vdpa/sfc: add support to get queue notify area info

2021-11-02 Thread Vijay Kumar Srivastava
Hi Chenbo, >-Original Message- >From: Xia, Chenbo >Sent: Tuesday, November 2, 2021 1:05 PM >To: Vijay Kumar Srivastava ; dev@dpdk.org >Cc: maxime.coque...@redhat.com; andrew.rybche...@oktetlabs.ru; Vijay >Kumar Srivastava >Subject: RE: [PATCH v3 07/10] vdpa/sfc: add support to get queue

Re: [dpdk-dev] [PATCH v3 02/10] vdpa/sfc: add support for device initialization

2021-11-02 Thread Vijay Kumar Srivastava
Hi Chenbo, >-Original Message- >From: Xia, Chenbo >Sent: Tuesday, November 2, 2021 10:47 AM >To: Vijay Kumar Srivastava ; dev@dpdk.org >Cc: maxime.coque...@redhat.com; andrew.rybche...@oktetlabs.ru; Praveen >Kumar Jain >Subject: RE: [PATCH v3 02/10] vdpa/sfc: add support for device initi

[dpdk-dev] [PATCH v3] vhost: mark vDPA driver API as internal

2021-11-02 Thread Maxime Coquelin
This patch marks the vDPA driver APIs as internal and rename the corresponding header file to vdpa_driver.h. Signed-off-by: Maxime Coquelin Acked-by: Thomas Monjalon Reviewed-by: Chenbo Xia --- Changes in v3: == - Update deprecation notice and release note Changes in v2: ==

Re: [dpdk-dev] [PATCH 2/2] devtools: disable fixes authors in get maintainers

2021-11-02 Thread Ferruh Yigit
On 11/1/2021 10:20 PM, Thomas Monjalon wrote: 01/11/2021 14:35, Ferruh Yigit: 'get_maintainer.pl' by default returns authors that has fixes in relevant code, to reduce the output only maintainers from MAINTAINERS file, disabling fixes authors, by making '--no-fixes' default. Do you mean it is

Re: [dpdk-dev] [PATCH 2/2] devtools: disable fixes authors in get maintainers

2021-11-02 Thread Ferruh Yigit
On 11/1/2021 11:19 PM, Stephen Hemminger wrote: On Mon, 1 Nov 2021 13:35:33 + Ferruh Yigit wrote: 'get_maintainer.pl' by default returns authors that has fixes in relevant code, to reduce the output only maintainers from MAINTAINERS file, disabling fixes authors, by making '--no-fixes' de

[dpdk-dev] [PATCH v3 0/3] Mempool fixes for FreeBSD

2021-11-02 Thread Dmitry Kozlyuk
mempool_autotest was failing on FreeBSD, because rte_virt2iova() is not implemented. After the test started using memzones, it appeared that in --no-huge memzones have iova=RTE_BAD_IOVA, which is unexpected and contradicts with selected IOVA-as-PA. Intead of working around this in the unit test, fi

[dpdk-dev] [PATCH v3 1/3] eal/freebsd: fix IOVA mode selection

2021-11-02 Thread Dmitry Kozlyuk
FreeBSD EAL selected IOVA mode PA even in --no-huge mode where PA are not available. Memory zones were created with IOVA equal to RTE_BAD_IOVA with no indication this field is not usable. Change IOVA mode detection: 1. Always allow to force --iova-mode=va. 2. In --no-huge mode, disallow forcing --

[dpdk-dev] [PATCH v3 2/3] app/test: fix mempool test on FreeBSD

2021-11-02 Thread Dmitry Kozlyuk
FreeBSD EAL does not implement rte_mem_virt2iova() causing an error: EAL: Test assert test_mempool_flag_non_io_unset_when_populated_with_valid_iova line 781 failed: Cannot get IOVA test failed at test_mempool():1030 Test Failed Change unit test to use rte_memzone_reserve() to all

[dpdk-dev] [PATCH v3 3/3] app/test: fix mempool test in no-huge mode

2021-11-02 Thread Dmitry Kozlyuk
Amount of locked memory for regular users is limited, it is usually 64 KB by default. Hitting this limit in rte_mempool_populate_anon() resulted in not populating the mempool, and a test case failure: EAL: Test assert test_mempool_events line 585 failed: Failed to populate mempool empty1: Suc

Re: [dpdk-dev] [PATCH v1] ethdev: remove deprecation notice for shared Rx queue

2021-11-02 Thread Ferruh Yigit
On 11/2/2021 9:29 AM, Xueming Li wrote: Shared Rx queue feature has been supported in commit[1], remove deprecation notice. [1]: commit dd22740cc291 ("ethdev: introduce shared Rx queue") Signed-off-by: Xueming Li Since it is too late to squash this patch, it will be a separate commit, for th

[dpdk-dev] [PATCH] kni: allow configuring the kni thread granularity

2021-11-02 Thread Tudor Cornea
The Kni kthreads seem to be re-scheduled at a granularity of roughly 1 milisecond right now, which seems to be insufficient for performing tests involving a lot of control plane traffic. Even if KNI_KTHREAD_RESCHEDULE_INTERVAL is set to 5 microseconds, it seems that the existing code cannot resche

[dpdk-dev] [PATCH v2] app/flow-perf: added option to support flow priority

2021-11-02 Thread psatheesh
From: Satheesh Paul Added support to create flows with priority attribute set randomly between 0 and a user supplied maximum value. This is useful to measure performance on NICs which may have to rearrange flows to honor flow priority. Removed the lower limit of 10 flows per batch. Signed-o

Re: [dpdk-dev] [PATCH] app/flow-perf: added option to support flow priority

2021-11-02 Thread Satheesh Paul
Hi, Thanks for the review. Please find the reply inline. -Original Message- From: Wisam Monther Sent: 01 November 2021 02:37 PM To: Satheesh Paul Cc: dev@dpdk.org; Asaf Penso Subject: [EXT] RE: [dpdk-dev] [PATCH] app/flow-perf: added option to support flow priority External Email -

Re: [dpdk-dev] [PATCH v2] test/crypto: refactor DOCSIS to show hidden cases

2021-11-02 Thread Power, Ciara
>-Original Message- >From: Troy, Rebecca >Sent: Friday 29 October 2021 10:04 >To: dev@dpdk.org >Cc: Power, Ciara ; Zhang, Roy Fan >; Coyle, David ; Troy, >Rebecca ; Akhil Goyal ; >Doherty, Declan >Subject: [PATCH v2] test/crypto: refactor DOCSIS to show hidden cases > >In the current impl

Re: [dpdk-dev] [PATCH v2] common/cnxk: support BPHY telemetry

2021-11-02 Thread Ferruh Yigit
On 11/2/2021 4:32 AM, Jerin Jacob wrote: On Mon, Nov 1, 2021 at 8:32 PM Ferruh Yigit wrote: On 10/22/2021 12:56 PM, Tomasz Duszynski wrote: Add initial support for baseband telemetry. Signed-off-by: Tomasz Duszynski --- v2: - make bphy telemetry available only on platforms supporting baseban

Re: [dpdk-dev] [PATCH v2] test/crypto: refactor DOCSIS to show hidden cases

2021-11-02 Thread Coyle, David
> -Original Message- > From: Troy, Rebecca > Sent: Friday, October 29, 2021 10:04 AM > To: dev@dpdk.org > Cc: Power, Ciara ; Zhang, Roy Fan > ; Coyle, David ; Troy, > Rebecca ; Akhil Goyal ; > Doherty, Declan > Subject: [PATCH v2] test/crypto: refactor DOCSIS to show hidden cases > > I

[dpdk-dev] [PATCH] vhost: rename driver callbacks struct

2021-11-02 Thread Maxime Coquelin
As previously announced, this patch renames struct vhost_device_ops to struct rte_vhost_device_ops. Signed-off-by: Maxime Coquelin --- doc/guides/rel_notes/deprecation.rst | 3 --- doc/guides/rel_notes/release_21_11.rst | 2 ++ drivers/net/vhost/rte_eth_vhost.c | 2 +- examples/vdpa/main.

[dpdk-dev] [PATCH v3] app/flow-perf: added option to support flow priority

2021-11-02 Thread psatheesh
From: Satheesh Paul Added support to create flows with priority attribute set randomly between 0 and a user supplied maximum value. This is useful to measure performance on NICs which may have to rearrange flows to honor flow priority. Removed the lower limit of 10 flows per batch. Signed-o

Re: [dpdk-dev] [PATCH v2 2/2] bpf: fix convert API can be undefined

2021-11-02 Thread Ananyev, Konstantin
> > rte_bpf_convert() implementation depends on libpcap. > > Right now it is defined only when this library is installed and > > RTE_PORT_PCAP is defined. > > Fix that by providing for such case stub rte_bpf_convert() > > implementation that will always return an error. > > Also move stub for an

Re: [dpdk-dev] [PATCH v3 1/3] eventdev/eth_rx: add queue stats get and reset APIs

2021-11-02 Thread Jerin Jacob
On Thu, Oct 28, 2021 at 4:22 PM Naga Harish K S V wrote: > > This patch adds new api ``rte_event_eth_rx_adapter_queue_stats_get`` to > retrieve queue stats. The queue stats are in the format > ``struct rte_event_eth_rx_adapter_queue_stats``. > > For resetting the queue stats, > ``rte_event_eth_rx_

Re: [dpdk-dev] [PATCH] regex/octeontx2: use cnxk infrastructure

2021-11-02 Thread Jerin Jacob
On Thu, Oct 28, 2021 at 2:53 PM wrote: > > From: Liron Himi > > update driver to use the REE cnxk code > > Signed-off-by: Liron Himi Waiting for depending patch's v2 version to merge this. > --- > drivers/regex/octeontx2/meson.build | 6 +- > drivers/regex/octeontx2/otx2_regexdev

Re: [dpdk-dev] [PATCH v2] common/cnxk: support BPHY telemetry

2021-11-02 Thread Jerin Jacob
On Tue, Nov 2, 2021 at 3:58 PM Ferruh Yigit wrote: > > On 11/2/2021 4:32 AM, Jerin Jacob wrote: > > On Mon, Nov 1, 2021 at 8:32 PM Ferruh Yigit wrote: > >> > >> On 10/22/2021 12:56 PM, Tomasz Duszynski wrote: > >>> Add initial support for baseband telemetry. > >>> > >>> Signed-off-by: Tomasz Dusz

Re: [dpdk-dev] [PATCH v1] test/crypto: fix: test vectors for zuc 256 bit key

2021-11-02 Thread De Lara Guarch, Pablo
Hi Sagar, Yes, those vectors pass for us too. >From our vectors, the ones for encryption (zuc256_test_case_cipher_1 and >zuc256_test_case_cipher_2) work for you, and only the authentication one >(zuc256_test_case_auth_1) doesn't? Since verifying authentication is more difficult, we should try to

Re: [dpdk-dev] Overriding rte_config.h

2021-11-02 Thread Ananyev, Konstantin
> On Fri, Oct 29, 2021 at 09:48:30AM -0400, Ben Magistro wrote: > > With the transition to meson, what is the best way to provide custom values > > to parameters in rte_config.h? When using makefiles, (from memory, I > > think) we used common_base as a template that was copied in as a > > replac

Re: [dpdk-dev] [PATCH v2] common/cnxk: support BPHY telemetry

2021-11-02 Thread Ferruh Yigit
On 11/2/2021 11:11 AM, Jerin Jacob wrote: On Tue, Nov 2, 2021 at 3:58 PM Ferruh Yigit wrote: On 11/2/2021 4:32 AM, Jerin Jacob wrote: On Mon, Nov 1, 2021 at 8:32 PM Ferruh Yigit wrote: On 10/22/2021 12:56 PM, Tomasz Duszynski wrote: Add initial support for baseband telemetry. Signed-off-

Re: [dpdk-dev] [PATCH 2/2] devtools: disable fixes authors in get maintainers

2021-11-02 Thread Thomas Monjalon
02/11/2021 11:04, Ferruh Yigit: > On 11/1/2021 10:20 PM, Thomas Monjalon wrote: > > 01/11/2021 14:35, Ferruh Yigit: > >> 'get_maintainer.pl' by default returns authors that has fixes in > >> relevant code, to reduce the output only maintainers from MAINTAINERS > >> file, disabling fixes authors, by

Re: [dpdk-dev] [PATCH v2 1/4] common/cnxk: add DPI DMA support

2021-11-02 Thread fengchengwen
On 2021/11/2 11:40, Radha Mohan Chintakuntla wrote: > Add base support as ROC(Rest of Chip) API which will be used by PMD > dmadev driver. > > This patch adds routines to init, fini, configure the DPI DMA device > found in Marvell's CN9k or CN10k SoC families. > > Signed-off-by: Radha Mohan Chint

Re: [dpdk-dev] [PATCH v2 2/4] dma/cnxk: create and initialize dmadev on pci probe

2021-11-02 Thread fengchengwen
On 2021/11/2 11:40, Radha Mohan Chintakuntla wrote: > This patch creates and initializes a dmadev device on pci probe. > > Signed-off-by: Radha Mohan Chintakuntla > --- ... > +RTE_PMD_REGISTER_PCI(cnxk_dmadev_pci_driver, cnxk_dmadev); > +RTE_PMD_REGISTER_PCI_TABLE(cnxk_dmadev_pci_driver, cnxk_d

Re: [dpdk-dev] [PATCH v2 3/4] dma/cnxk: add dma channel operations

2021-11-02 Thread fengchengwen
On 2021/11/2 11:40, Radha Mohan Chintakuntla wrote: > Add functions for the dmadev vchan setup and DMA operations. > > Signed-off-by: Radha Mohan Chintakuntla ... > > +static int > +cnxk_dmadev_info_get(const struct rte_dma_dev *dev, > + struct rte_dma_info *dev_info, uint32_

Re: [dpdk-dev] [PATCH v2 4/4] dma/cnxk: add copy_sg function

2021-11-02 Thread fengchengwen
On 2021/11/2 11:40, Radha Mohan Chintakuntla wrote: > Add the copy_sg function that will do the multiple DMA transfers of > different sizes and different source/destination as well. > ... > > +static int > +cnxk_dmadev_copy_sg(void *dev_private, uint16_t vchan, > + const struct

Re: [dpdk-dev] Overriding rte_config.h

2021-11-02 Thread Bruce Richardson
On Tue, Nov 02, 2021 at 11:20:04AM +, Ananyev, Konstantin wrote: > > > On Fri, Oct 29, 2021 at 09:48:30AM -0400, Ben Magistro wrote: > > > With the transition to meson, what is the best way to provide custom > > > values > > > to parameters in rte_config.h? When using makefiles, (from memory

Re: [dpdk-dev] [PATCH 2/2] devtools: disable fixes authors in get maintainers

2021-11-02 Thread Ferruh Yigit
On 11/2/2021 11:28 AM, Thomas Monjalon wrote: 02/11/2021 11:04, Ferruh Yigit: On 11/1/2021 10:20 PM, Thomas Monjalon wrote: 01/11/2021 14:35, Ferruh Yigit: 'get_maintainer.pl' by default returns authors that has fixes in relevant code, to reduce the output only maintainers from MAINTAINERS fil

Re: [dpdk-dev] Overriding rte_config.h

2021-11-02 Thread Ananyev, Konstantin
> > > On Fri, Oct 29, 2021 at 09:48:30AM -0400, Ben Magistro wrote: > > > > With the transition to meson, what is the best way to provide custom > > > > values > > > > to parameters in rte_config.h? When using makefiles, (from memory, I > > > > think) we used common_base as a template that was

[dpdk-dev] [PATCH v2 0/6] dma: add hisilicon DMA driver

2021-11-02 Thread Chengwen Feng
This patch set add hisilicon DMA driver. Chengwen Feng (6): dma/hisilicon: add device probe and remove functions dma/hisilicon: add dmadev instances create and destroy dma/hisilicon: add control path functions dma/hisilicon: add data path functions dma/hisilicon: support multi-process

[dpdk-dev] [PATCH v2 1/6] dma/hisilicon: add device probe and remove functions

2021-11-02 Thread Chengwen Feng
Add the basic device probe and remove functions and initial documentation for new hisilicon DMA drivers. Maintainers update is also included in this patch. Signed-off-by: Chengwen Feng --- MAINTAINERS| 5 ++ doc/guides/dmadevs/hisilicon.rst | 21 + doc/gu

[dpdk-dev] [PATCH v2 5/6] dma/hisilicon: support multi-process

2021-11-02 Thread Chengwen Feng
This patch add multi-process support for Kunpeng DMA devices. Signed-off-by: Chengwen Feng --- drivers/dma/hisilicon/hisi_dmadev.c | 21 + 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/drivers/dma/hisilicon/hisi_dmadev.c b/drivers/dma/hisilicon/hisi_dmadev.c

[dpdk-dev] [PATCH v2 3/6] dma/hisilicon: add control path functions

2021-11-02 Thread Chengwen Feng
This patch add control path functions for Kunpeng DMA devices. Signed-off-by: Chengwen Feng --- doc/guides/dmadevs/hisilicon.rst| 10 + drivers/dma/hisilicon/hisi_dmadev.c | 385 drivers/dma/hisilicon/hisi_dmadev.h | 99 +++ 3 files changed, 494 insertions(

[dpdk-dev] [PATCH v2 4/6] dma/hisilicon: add data path functions

2021-11-02 Thread Chengwen Feng
This patch add data path functions for Kunpeng DMA devices. Signed-off-by: Chengwen Feng --- drivers/dma/hisilicon/hisi_dmadev.c | 206 drivers/dma/hisilicon/hisi_dmadev.h | 16 +++ 2 files changed, 222 insertions(+) diff --git a/drivers/dma/hisilicon/hisi_dmadev.c

[dpdk-dev] [PATCH v2 2/6] dma/hisilicon: add dmadev instances create and destroy

2021-11-02 Thread Chengwen Feng
This patch add dmadev instances create during the PCI probe, and destroy them during the PCI remove. Internal structures and HW definitions was also included. Signed-off-by: Chengwen Feng --- doc/guides/dmadevs/hisilicon.rst| 10 ++ drivers/dma/hisilicon/hisi_dmadev.c | 212

[dpdk-dev] [PATCH v2 6/6] devbind: add Kunpeng DMA to dmadev category

2021-11-02 Thread Chengwen Feng
add Kunpeng DMA device ID to dmadev category. Signed-off-by: Chengwen Feng --- usertools/dpdk-devbind.py | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py index bb00f43702..a74a68ed82 100755 --- a/usertools/dpdk-devbind

[dpdk-dev] [PATCH] doc: cleanup flow mark Rx offload deprecation notice

2021-11-02 Thread Andrew Rybchenko
The problem is solved using Rx metadata delivery negotiation API [1]. [1] commit f6d8a6d3fad7 ("ethdev: negotiate delivery of packet metadata from HW to PMD") Signed-off-by: Andrew Rybchenko --- doc/guides/rel_notes/deprecation.rst | 8 1 file changed, 8 deletions(-) diff --git a/doc

[dpdk-dev] [PATCH] net/sfc: merge Rx and Tx doorbell counters into one

2021-11-02 Thread Andrew Rybchenko
Datapath queue is either Rx or Tx, so just one counter is sufficient for doorbells. It can count Tx doorbells in the case of Tx queue and Rx doorbells in the case of Rx queue. Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/sfc_dp.h | 3 +-- drivers/net/sfc/sfc_ef100_rx.c | 2 +

Re: [dpdk-dev] [PATCH v19 1/5] sched: add PIE based congestion management

2021-11-02 Thread Liguzinski, WojciechX
Sure, I will correct the name. As I can see from a distance that some things could be resolved/corrected from the very beginning (like e.g. the name and its format). -Original Message- From: Thomas Monjalon Sent: Friday, October 29, 2021 3:44 PM To: Liguzinski, WojciechX Cc: dev@dpdk.

Re: [dpdk-dev] [PATCH] net/txgbe: fix link macro

2021-11-02 Thread Ferruh Yigit
On 11/2/2021 1:51 AM, Jiawen Wu wrote: On November 1, 2021 9:20 PM, Ferruh Yigit wrote: Macro is changed unintentionally while adding RTE_ prefix, fixing the original value. Fixes: 295968d17407 ("ethdev: add namespace") Signed-off-by: Ferruh Yigit Acked-by: Jiawen Wu Applied to dpdk-n

Re: [dpdk-dev] [PATCH v2] ethdev: fix deprecation notice for shared Rx queue

2021-11-02 Thread Ferruh Yigit
On 11/2/2021 11:42 AM, Xueming Li wrote: Shared Rx queue feature has been supported, remove deprecation notice. Fixes: dd22740cc291 ("ethdev: introduce shared Rx queue") Signed-off-by: Xueming Li Reviewed-by: Ferruh Yigit Applied to dpdk-next-net/main, thanks.

Re: [dpdk-dev] [PATCH] doc: cleanup flow mark Rx offload deprecation notice

2021-11-02 Thread Ferruh Yigit
On 11/2/2021 12:50 PM, Andrew Rybchenko wrote: The problem is solved using Rx metadata delivery negotiation API [1]. Can this API replace RX_OFFLOAD_RSS_HASH too? [1] commit f6d8a6d3fad7 ("ethdev: negotiate delivery of packet metadata from HW to PMD") Signed-off-by: Andrew Rybchenko ---

[dpdk-dev] [dpdk-dev v3 2/8] crypto/qat: qat driver sym op refactor

2021-11-02 Thread Kai Ji
This patch add-in refactored qat symmetirc build request function implementation (qat_sym_refactor.c & qat_sym_refactor.h) Add-in QAT sym build ops in auth, cipher, chain and aead operation for QAT generation 1 Signed-off-by: Kai Ji --- drivers/crypto/qat/dev/qat_crypto_pmd_gens.h | 1071 +++

[dpdk-dev] [dpdk-dev v3 0/8] drivers/qat: QAT symmetric crypto datapatch rework

2021-11-02 Thread Kai Ji
This patch reworks QAT symmetric crypto datapatch implementation where each generation request building separated and the crypto operation under the raw datapath api implementation are unified. In addtion this patchset also enables QAT OOP support in raw datapath api implementation. This patch de

[dpdk-dev] [dpdk-dev v3 1/8] crypro/qat: qat driver refactor skeleton

2021-11-02 Thread Kai Ji
Add-in enqueue/dequeue op burst and build-request skeleton functions for qat crypto driver refactor. Signed-off-by: Kai Ji --- drivers/common/qat/qat_qp.c | 16 + drivers/common/qat/qat_qp.h | 54 drivers/crypto/qat/qat_asym.c| 43 ++

[dpdk-dev] [dpdk-dev v3 3/8] crypto/qat: qat driver asym op refactor

2021-11-02 Thread Kai Ji
This patch add-in refactored qat asymmetric build request function implementation (qat_asym_refactor.c & qat_asym_refactor.h) Signed-off-by: Kai Ji --- drivers/crypto/qat/dev/qat_asym_pmd_gen1.c | 7 + drivers/crypto/qat/qat_asym_refactor.c | 994 + drivers/crypto/qat/q

[dpdk-dev] [dpdk-dev v3 4/8] crypto/qat: qat driver session method rework

2021-11-02 Thread Kai Ji
The patch introduce set_session & set_raw_dp_ctx methods to qat gen dev ops Replace min_qat_dev_gen_id with dev_id, the session will be invalid if the device generation id is not matching during init and ops Signed-off-by: Kai Ji --- drivers/crypto/qat/dev/qat_crypto_pmd_gen2.c | 90 drive

[dpdk-dev] [dpdk-dev v3 5/8] crypto/qat: qat driver datapath rework

2021-11-02 Thread Kai Ji
This patch introduce op_build_request func in qat enqueue op burst. Add-in qat_dequeue_process_response in qat dequeue op burst. Enable session build request op based on crypto operation Signed-off-by: Kai Ji --- drivers/common/qat/meson.build | 4 +- drivers/common/qat/qat_qp.c

[dpdk-dev] [dpdk-dev v3 6/8] crypto/qat: support sgl oop operation

2021-11-02 Thread Kai Ji
This patch add-in sgl oop support in qat driver Signed-off-by: Kai Ji --- drivers/crypto/qat/dev/qat_crypto_pmd_gen3.c | 28 -- drivers/crypto/qat/dev/qat_crypto_pmd_gen4.c | 14 - drivers/crypto/qat/dev/qat_sym_pmd_gen1.c| 55 +--- 3 files changed, 83 insertions(

[dpdk-dev] [dpdk-dev v3 7/8] app/test: cryptodev test fix

2021-11-02 Thread Kai Ji
test_mixed_auth_cipher: ensure enough space allocate in ibuf & obuf for mbuf to vec conversion test_kasumi_decryption: cipher length update. Fixes: 681f540da52b ("cryptodev: do not use AAD in wireless algorithms") Cc: pablo.de.lara.gua...@intel.com Fixes: e847fc512817 ("test/crypto: add encrypted

Re: [dpdk-dev] [PATCH v4 0/6] Flow entites behavior on port restart

2021-11-02 Thread Ferruh Yigit
On 10/21/2021 7:34 AM, Dmitry Kozlyuk wrote: It is unspecified whether flow rules and indirect actions are kept when a port is stopped, possibly reconfigured, and started again. Vendors approach the topic differently, e.g. mlx5 and i40e PMD disagree in whether flow rules can be kept, and mlx5 PMD

[dpdk-dev] [PATCH v5 0/6] Flow entites behavior on port restart

2021-11-02 Thread Dmitry Kozlyuk
It is unspecified whether flow rules and indirect actions are kept when a port is stopped, possibly reconfigured, and started again. Vendors approach the topic differently, e.g. mlx5 and i40e PMD disagree in whether flow rules can be kept, and mlx5 PMD would keep indirect actions. In the end, appli

[dpdk-dev] [PATCH v5 1/6] ethdev: add capability to keep flow rules on restart

2021-11-02 Thread Dmitry Kozlyuk
Previously, it was not specified what happens to the flow rules when the device is stopped, possibly reconfigured, then started. If flow rules were kept, it could be convenient for application developers, because they wouldn't need to save and restore them. However, due to the number of flows and p

[dpdk-dev] [PATCH v5 2/6] ethdev: add capability to keep shared objects on restart

2021-11-02 Thread Dmitry Kozlyuk
rte_flow_action_handle_create() did not mention what happens with an indirect action when a device is stopped and started again. It is natural for some indirect actions, like counter, to be persistent. Keeping others at least saves application time and complexity. However, not all PMDs can support

[dpdk-dev] [PATCH v5 3/6] net: advertise no support for keeping flow rules

2021-11-02 Thread Dmitry Kozlyuk
When RTE_ETH_DEV_CAPA_FLOW_RULE_KEEP capability bit is zero, the specified behavior is the same as it had been before this bit was introduced. Explicitly reset it in all PMDs supporting rte_flow API in order to attract the attention of maintainers, who should eventually choose to advertise the new

[dpdk-dev] [PATCH v5 4/6] net/mlx5: discover max flow priority using DevX

2021-11-02 Thread Dmitry Kozlyuk
Maximum available flow priority was discovered using Verbs API regardless of the selected flow engine. This required some Verbs objects to be initialized in order to use DevX engine. Make priority discovery an engine method and implement it for DevX using its API. Cc: sta...@dpdk.org Signed-off-b

[dpdk-dev] [PATCH v5 5/6] net/mlx5: create drop queue using DevX

2021-11-02 Thread Dmitry Kozlyuk
Drop queue creation and destruction were not implemented for DevX flow engine and Verbs engine methods were used as a workaround. Implement these methods for DevX so that there is a valid queue ID that can be used regardless of queue configuration via API. Cc: sta...@dpdk.org Signed-off-by: Dmitr

[dpdk-dev] [PATCH v5 6/6] net/mlx5: preserve indirect actions on restart

2021-11-02 Thread Dmitry Kozlyuk
MLX5 PMD uses reference counting to manage RX queue resources. After port stop shared RSS actions kept references to RX queues, preventing resource release. As a result, internal PMD mempool for such queues had been exhausted after a number of port restarts. Diagnostic message from rte_eth_dev_star

Re: [dpdk-dev] [PATCH] doc: cleanup flow mark Rx offload deprecation notice

2021-11-02 Thread Andrew Rybchenko
On 11/2/21 4:47 PM, Ferruh Yigit wrote: On 11/2/2021 12:50 PM, Andrew Rybchenko wrote: The problem is solved using Rx metadata delivery negotiation API [1]. Can this API replace RX_OFFLOAD_RSS_HASH too? It can, but it should not. RSS hash is an offload since it is a calculation of the hash

Re: [dpdk-dev] Overriding rte_config.h

2021-11-02 Thread Bruce Richardson
On Tue, Nov 02, 2021 at 12:24:43PM +, Ananyev, Konstantin wrote: > > > > > On Fri, Oct 29, 2021 at 09:48:30AM -0400, Ben Magistro wrote: > > > > > With the transition to meson, what is the best way to provide custom > > > > > values > > > > > to parameters in rte_config.h? When using makefil

Re: [dpdk-dev] [PATCH v5 0/6] Flow entites behavior on port restart

2021-11-02 Thread Ferruh Yigit
On 11/2/2021 1:54 PM, Dmitry Kozlyuk wrote: It is unspecified whether flow rules and indirect actions are kept when a port is stopped, possibly reconfigured, and started again. Vendors approach the topic differently, e.g. mlx5 and i40e PMD disagree in whether flow rules can be kept, and mlx5 PMD

Re: [dpdk-dev] [PATCH] doc: cleanup flow mark Rx offload deprecation notice

2021-11-02 Thread Ferruh Yigit
On 11/2/2021 2:09 PM, Andrew Rybchenko wrote: On 11/2/21 4:47 PM, Ferruh Yigit wrote: On 11/2/2021 12:50 PM, Andrew Rybchenko wrote: The problem is solved using Rx metadata delivery negotiation API [1]. Can this API replace RX_OFFLOAD_RSS_HASH too? It can, but it should not. RSS hash is an

[dpdk-dev] [v3] security: add telemetry endpoint for cryptodev security capabilities

2021-11-02 Thread Gowrishankar Muthukrishnan
Add telemetry endpoint for cryptodev security capabilities. Signed-off-by: Gowrishankar Muthukrishnan --- v3: - secure cryptodev capability endpoint is added and endpoints renamed. --- doc/guides/prog_guide/rte_security.rst | 28 doc/guides/rel_notes/release_21_11.rst | 5 + lib/sec

[dpdk-dev] [v4] security: add telemetry endpoint for cryptodev security capabilities

2021-11-02 Thread Gowrishankar Muthukrishnan
Add telemetry endpoint for cryptodev security capabilities. Signed-off-by: Gowrishankar Muthukrishnan --- v4: - fixed typo in help. --- doc/guides/prog_guide/rte_security.rst | 28 doc/guides/rel_notes/release_21_11.rst | 5 + lib/security/rte_security.c| 182 ++

[dpdk-dev] [PATCH] config/x86: add support for AMD platform

2021-11-02 Thread Aman Kumar
-Dcpu_instruction_set=znverX meson option can be used to build dpdk for AMD platforms. Supported options are znver1, znver2 and znver3. Signed-off-by: Aman Kumar --- config/x86/meson.build | 9 + doc/guides/linux_gsg/build_dpdk.rst | 2 +- 2 files changed, 10 insertions(+),

Re: [dpdk-dev] [PATCH v2 2/2] bpf: fix convert API can be undefined

2021-11-02 Thread Stephen Hemminger
On Tue, 2 Nov 2021 10:54:59 + "Ananyev, Konstantin" wrote: > > > rte_bpf_convert() implementation depends on libpcap. > > > Right now it is defined only when this library is installed and > > > RTE_PORT_PCAP is defined. > > > Fix that by providing for such case stub rte_bpf_convert() > > > im

Re: [dpdk-dev] Overriding rte_config.h

2021-11-02 Thread Ananyev, Konstantin
> > > > > On Fri, Oct 29, 2021 at 09:48:30AM -0400, Ben Magistro wrote: > > > > > > With the transition to meson, what is the best way to provide > > > > > > custom values > > > > > > to parameters in rte_config.h? When using makefiles, (from memory, > > > > > > I > > > > > > think) we used co

Re: [dpdk-dev] [PATCH] config/x86: add support for AMD platform

2021-11-02 Thread Thomas Monjalon
02/11/2021 15:52, Aman Kumar: > -Dcpu_instruction_set=znverX meson option can be used > to build dpdk for AMD platforms. Supported options are > znver1, znver2 and znver3. > > Signed-off-by: Aman Kumar > --- > +# AMD platform support > +if get_option('cpu_instruction_set') == 'znver1' > +dpdk

Re: [dpdk-dev] [PATCH v2] net/af_packet: fix ignoring full ring on tx

2021-11-02 Thread Tudor Cornea
On Tue, 26 Oct 2021 at 17:41, Ferruh Yigit wrote: > Hi Tudor, > > I have used testpmd, 'txonly' forwarding. Tx recovers after interface up, > but by adding some debug logs I can see 'poll()' returns with POLLOUT even > there is no space in the buffer. > > According the logic in the PMD, when 'pol

Re: [dpdk-dev] [PATCH v2 2/2] bpf: fix convert API can be undefined

2021-11-02 Thread Stephen Hemminger
On Mon, 1 Nov 2021 16:10:13 + Konstantin Ananyev wrote: > rte_bpf_convert() implementation depends on libpcap. > Right now it is defined only when this library is installed and > RTE_PORT_PCAP is defined. > Fix that by providing for such case stub rte_bpf_convert() > implementation that will

Re: [dpdk-dev] [PATCH v2 1/6] dma/dpaa: introduce DPAA DMA driver

2021-11-02 Thread Thomas Monjalon
02/11/2021 09:51, fengchengwen: > On 2021/11/1 16:51, Gagandeep Singh wrote: > > The DPAA DMA driver is an implementation of the dmadev APIs, > > that provide means to initiate a DMA transaction from CPU. > > The initiated DMA is performed without CPU being involved > > in the actual DMA transacti

Re: [dpdk-dev] [PATCH] ethdev: fine tune error reporting in pick transfer proxy API

2021-11-02 Thread Thomas Monjalon
01/11/2021 10:41, Andrew Rybchenko: > On 10/27/21 12:00 PM, Ivan Malov wrote: > > There are PMDs which do not support flow offloads at all. > > In such cases, the API in question returns ENOTSUP. This > > is too loud. Restructure the code to avoid spamming logs. > > > > Fixes: 1179f05cc9a0 ("ethde

[dpdk-dev] [PATCH v3] net/af_packet: fix ignoring full ring on tx

2021-11-02 Thread Tudor Cornea
The poll call can return POLLERR which is ignored, or it can return POLLOUT, even if there are no free frames in the mmap-ed area. We can account for both of these cases by re-checking if the next frame is empty before writing into it. We have attempted to reproduce this issue with pktgen-dpdk, u

[dpdk-dev] [PATCH] meson.build: replace tabs with spaces

2021-11-02 Thread Stephen Hemminger
Per the meson recommendation the meson.build file should be indented with spaces not tabs. This patch is semi-automatically generated by running all the meson.build files through expand command. Signed-off-by: Stephen Hemminger --- Note: if users (like me) just editconfig setup in their favorite

  1   2   >