Hi Sagar, Yes, those vectors pass for us too. >From our vectors, the ones for encryption (zuc256_test_case_cipher_1 and >zuc256_test_case_cipher_2) work for you, and only the authentication one >(zuc256_test_case_auth_1) doesn't? Since verifying authentication is more difficult, we should try to cross check encryption, mainly check if we are generating the same keystream. Could you change the plaintext of your encryption test vector (zuc_test_case_cipher_800b_key_256b ) to all 0s, and see which ciphertext you see (will be the keystream generated by your device). Our implementation actually matches with GmSSL library, so it looks like you might have some issue in yours, but let's see.
Thanks, Pablo From: Vidya Sagar Velumuri <vvelum...@marvell.com> Sent: Tuesday, November 2, 2021 4:41 AM To: De Lara Guarch, Pablo <pablo.de.lara.gua...@intel.com>; Ankur Dwivedi <adwiv...@marvell.com>; Anoob Joseph <ano...@marvell.com>; Tejasree Kondoj <ktejas...@marvell.com>; Nithin Kumar Dabilpuram <ndabilpu...@marvell.com>; Akhil Goyal <gak...@marvell.com>; Doherty, Declan <declan.dohe...@intel.com> Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v1] test/crypto: fix: test vectors for zuc 256 bit key Hi Pablo, We verified vectors mentioned in below link in our platform and all the vectors passed (i.e: the digest matches with the doc). http://www.is.cas.cn/ztzl2016/zouchongzhi/201801/W020180126529970733243.pdf The ZUC-256 Stream Cipher<http://www.is.cas.cn/ztzl2016/zouchongzhi/201801/W020180126529970733243.pdf> The ZUC-256 Stream Cipher 5 3. X 2 = s 7L ks 5H 4. X 3 = s 2L ks 0H, where s iH is the high 16 bits of the cell s i and s jL is the low 16 bits of the cell s j. F(X 0;X 1;X 2) 1. W = (X 0 R 1) R 2 2. W 1 = R 1 X 1 3. W 2 = R 2 X 2 4. R 1 = S(L 1(W 1L kW 2H)) 5. R 2 = S(L 2(W 2L kW 1H)), where S = (S 0;S 1;S 0;S 1) is the 4 parallel S-boxes which are the same as those used in the previous ZUC ... www.is.cas.cn<http://www.is.cas.cn> Could you please check if these vectors work in your platform. Regards Sagar ________________________________ From: Vidya Sagar Velumuri <vvelum...@marvell.com<mailto:vvelum...@marvell.com>> Sent: 01 November 2021 15:53 To: De Lara Guarch, Pablo <pablo.de.lara.gua...@intel.com<mailto:pablo.de.lara.gua...@intel.com>>; Ankur Dwivedi <adwiv...@marvell.com<mailto:adwiv...@marvell.com>>; Anoob Joseph <ano...@marvell.com<mailto:ano...@marvell.com>>; Tejasree Kondoj <ktejas...@marvell.com<mailto:ktejas...@marvell.com>>; Nithin Kumar Dabilpuram <ndabilpu...@marvell.com<mailto:ndabilpu...@marvell.com>>; Akhil Goyal <gak...@marvell.com<mailto:gak...@marvell.com>>; Doherty, Declan <declan.dohe...@intel.com<mailto:declan.dohe...@intel.com>> Cc: dev@dpdk.org<mailto:dev@dpdk.org> <dev@dpdk.org<mailto:dev@dpdk.org>> Subject: Re: [dpdk-dev] [PATCH v1] test/crypto: fix: test vectors for zuc 256 bit key Hi Pablo, Verified with updated test vector. the output did not change from previous output but also, it did not match the ouput present in the vector. Regards Sagar ________________________________ From: De Lara Guarch, Pablo <pablo.de.lara.gua...@intel.com<mailto:pablo.de.lara.gua...@intel.com>> Sent: 01 November 2021 03:36 To: Vidya Sagar Velumuri <vvelum...@marvell.com<mailto:vvelum...@marvell.com>>; Ankur Dwivedi <adwiv...@marvell.com<mailto:adwiv...@marvell.com>>; Anoob Joseph <ano...@marvell.com<mailto:ano...@marvell.com>>; Tejasree Kondoj <ktejas...@marvell.com<mailto:ktejas...@marvell.com>>; Nithin Kumar Dabilpuram <ndabilpu...@marvell.com<mailto:ndabilpu...@marvell.com>>; Akhil Goyal <gak...@marvell.com<mailto:gak...@marvell.com>>; Doherty, Declan <declan.dohe...@intel.com<mailto:declan.dohe...@intel.com>> Cc: dev@dpdk.org<mailto:dev@dpdk.org> <dev@dpdk.org<mailto:dev@dpdk.org>> Subject: [EXT] RE: [dpdk-dev] [PATCH v1] test/crypto: fix: test vectors for zuc 256 bit key External Email ________________________________ Hi Sagar, Thanks for flagging this. I submitted a patch fixing the IV of the test vectors I pushed (it didn't change the output): http://patches.dpdk.org/project/dpdk/patch/20211031220421.52181-1-pablo.de.lara.gua...@intel.com/<https://urldefense.proofpoint.com/v2/url?u=http-3A__patches.dpdk.org_project_dpdk_patch_20211031220421.52181-2D1-2Dpablo.de.lara.guarch-40intel.com_&d=DwMFAg&c=nKjWec2b6R0mOyPaz7xtfQ&r=9VCCg7VNdg-jfzaFw1fN59x7Py9yM-ofwvekNj6MPxM&m=2eElny5n4QewacnppQimeCdeyB6B6GXxfdF4oet4KAlTXpwgcfhUF0Z3q2Ph4evt&s=pputaMk4g9cVhsjiJ1euKMLuGx24bIVTDh0AA4WrKwI&e=> Could you check if they work for you? Thanks, Pablo From: Vidya Sagar Velumuri <vvelum...@marvell.com<mailto:vvelum...@marvell.com>> Sent: Saturday, October 30, 2021 1:26 PM To: De Lara Guarch, Pablo <pablo.de.lara.gua...@intel.com<mailto:pablo.de.lara.gua...@intel.com>>; Ankur Dwivedi <adwiv...@marvell.com<mailto:adwiv...@marvell.com>>; Anoob Joseph <ano...@marvell.com<mailto:ano...@marvell.com>>; Tejasree Kondoj <ktejas...@marvell.com<mailto:ktejas...@marvell.com>>; Nithin Kumar Dabilpuram <ndabilpu...@marvell.com<mailto:ndabilpu...@marvell.com>>; Akhil Goyal <gak...@marvell.com<mailto:gak...@marvell.com>>; Doherty, Declan <declan.dohe...@intel.com<mailto:declan.dohe...@intel.com>> Cc: dev@dpdk.org<mailto:dev@dpdk.org> Subject: Re: [dpdk-dev] [PATCH v1] test/crypto: fix: test vectors for zuc 256 bit key Hi Pablo, Tried the test vector zuc256_test_case_auth_1 and the digest did not match with the generated digest in our platform. As per spec, IV[i] for i = 17 to 24 are 6-bit string occupying the 6 least signi cant bits of a byte. But in the vectors, The values in the IV(byte -17 to 24) are > 0x3f. Could you please elaborate how these bytes are considered for generation of digest. Regards Sagar ________________________________ From: De Lara Guarch, Pablo <pablo.de.lara.gua...@intel.com<mailto:pablo.de.lara.gua...@intel.com>> Sent: 29 October 2021 18:07 To: Vidya Sagar Velumuri <vvelum...@marvell.com<mailto:vvelum...@marvell.com>>; Ankur Dwivedi <adwiv...@marvell.com<mailto:adwiv...@marvell.com>>; Anoob Joseph <ano...@marvell.com<mailto:ano...@marvell.com>>; Tejasree Kondoj <ktejas...@marvell.com<mailto:ktejas...@marvell.com>>; Nithin Kumar Dabilpuram <ndabilpu...@marvell.com<mailto:ndabilpu...@marvell.com>>; Akhil Goyal <gak...@marvell.com<mailto:gak...@marvell.com>>; Doherty, Declan <declan.dohe...@intel.com<mailto:declan.dohe...@intel.com>> Cc: dev@dpdk.org<mailto:dev@dpdk.org> <dev@dpdk.org<mailto:dev@dpdk.org>> Subject: [EXT] RE: [dpdk-dev] [PATCH v1] test/crypto: fix: test vectors for zuc 256 bit key External Email ---------------------------------------------------------------------- Hi Vidya, > -----Original Message----- > From: dev <dev-boun...@dpdk.org<mailto:dev-boun...@dpdk.org>> On Behalf Of > Vidya Sagar Velumuri > Sent: Wednesday, October 27, 2021 9:41 AM > To: adwiv...@marvell.com<mailto:adwiv...@marvell.com>; > ano...@marvell.com<mailto:ano...@marvell.com>; > ktejas...@marvell.com<mailto:ktejas...@marvell.com>; > ndabilpu...@marvell.com<mailto:ndabilpu...@marvell.com>; > gak...@marvell.com<mailto:gak...@marvell.com>; Doherty, Declan > <declan.dohe...@intel.com<mailto:declan.dohe...@intel.com>> > Cc: dev@dpdk.org<mailto:dev@dpdk.org> > Subject: [dpdk-dev] [PATCH v1] test/crypto: fix: test vectors for zuc 256 bit > key > > Fix the IV and MAC in the test vectors added for zuc 256-bit key > > Fixes: fa5bf9345d4e (test/crypto: add ZUC cases with 256-bit keys) > > Signed-off-by: Vidya Sagar Velumuri > <vvelum...@marvell.com<mailto:vvelum...@marvell.com>> The new vectors are failing for us. Could you check if the ones we added work for you? Thanks, Pablo
