Re: [dpdk-dev] [PATCH] eal: promote random function with upper bound to stable

2021-10-02 Thread David Marchand
On Wed, Sep 1, 2021 at 1:17 PM Kinsella, Ray wrote: > On 01/09/2021 08:29, Mattias Rönnblom wrote: > > Remove experimental tag from rte_rand_max(). > > > > Signed-off-by: Mattias Rönnblom > > Acked-by: Ray Kinsella Applied, thanks. -- David Marchand

Re: [dpdk-dev] [PATCH] eal: promote register type and pick level API as stable

2021-10-02 Thread David Marchand
On Tue, Aug 31, 2021 at 8:31 PM Kinsella, Ray wrote: > On 31/08/2021 19:14, Ivan Malov wrote: > > This one might be quite mature to be attested as stable. > > > > Signed-off-by: Ivan Malov > > Reviewed-by: Andrew Rybchenko > > --- > > Acked-by: Ray Kinsella > Applied, thanks. -- David Marcha

Re: [dpdk-dev] [PATCH v1] lib/ring: remove experimental tag from functions

2021-10-02 Thread David Marchand
Hello, On Thu, Sep 30, 2021 at 7:42 PM Sean Morrissey wrote: > > These methods were introduced in 20.05. > There has been no changes in their public API since then. > They seem mature enough to remove the experimental tag. I am a bit skeptical at the patch. Can you double check? /** prod/cons

Re: [dpdk-dev] [PATCH] net: promote make rarp packet API as stable

2021-10-02 Thread David Marchand
On Thu, Sep 16, 2021 at 1:38 PM Olivier Matz wrote: > > On Wed, Sep 08, 2021 at 06:59:15PM +0800, Xiao Wang wrote: > > rte_net_make_rarp_packet was introduced in version v18.02, there was no > > change in this public API since then, and it's still being used by vhost > > lib and virtio driver, so

Re: [dpdk-dev] [PATCH 1/2] rib: announce experimental tag removal of the rib API

2021-10-02 Thread David Marchand
On Thu, Aug 5, 2021 at 1:26 PM Vladimir Medvedkin wrote: > > This patch announces the experimental tag removal of all rib APIs, > which have been experimental for 2 years. > API will be promoted to stable in DPDK 21.11 > > Signed-off-by: Vladimir Medvedkin Either this series was missed or judged

Re: [dpdk-dev] [PATCH] rib: promote experimental API's to stable

2021-10-02 Thread David Marchand
On Wed, Sep 1, 2021 at 9:16 PM Medvedkin, Vladimir wrote: > On 31/08/2021 23:49, Stephen Hemminger wrote: > > The rib and rib6 API's have been in since 19.11 and > > should be marked as stable. > > > > Signed-off-by: Stephen Hemminger > Acked-by: Vladimir Medvedkin Applied, thanks. -- David

Re: [dpdk-dev] [PATCH] fib: promote experimental API's to stable

2021-10-02 Thread David Marchand
On Wed, Sep 8, 2021 at 7:04 PM Conor Walsh wrote: > > The fib and fib6 API's have been in since 19.11 and > > should be marked as stable. > > > > Signed-off-by: Vladimir Medvedkin > Acked-by: Conor Walsh Updated MAINTAINERS accordingly. Applied, thanks. -- David Marchand

Re: [dpdk-dev] [PATCH v3 3/4] mbuf: make rte_mbuf_tx_offload as stable

2021-10-02 Thread David Marchand
On Tue, Aug 31, 2021 at 9:35 PM Stephen Hemminger wrote: > > This function should be made stable now. > > Also, fix the docbook comment format. > > Fixes: 8d9c2c3a1f01 ("mbuf: add function to generate raw Tx offload value") > Cc: konstantin.anan...@intel.com > Signed-off-by: Stephen Hemminger > -

Re: [dpdk-dev] [PATCH] net: make rte_ether_unformat_addr stable

2021-10-02 Thread David Marchand
On Thu, Sep 16, 2021 at 1:36 PM Olivier Matz wrote: > > On Wed, Sep 01, 2021 at 09:49:09AM +0100, Ferruh Yigit wrote: > > On 9/1/2021 8:11 AM, Andrew Rybchenko wrote: > > > On 8/31/21 11:07 PM, Stephen Hemminger wrote: > > >> This function has been in since 19.11. > > >> > > >> Signed-off-by: Step

Re: [dpdk-dev] [PATCH] net: promote ip6 external headers skip API as stable

2021-10-02 Thread David Marchand
On Fri, Sep 24, 2021 at 3:02 PM Olivier Matz wrote: > > This function is public since commit 8f0e4d6a78a5 ("net: export IPv6 > header extensions skip function") (2018), and is used by vmxnet3 driver. > Promote it as stable. > > Signed-off-by: Olivier Matz Acked-by: David Marchand -- David Ma

Re: [dpdk-dev] [PATCH v1] lib/ring: remove experimental tag from functions

2021-10-02 Thread Ananyev, Konstantin
Hi David, > Hello, > > On Thu, Sep 30, 2021 at 7:42 PM Sean Morrissey > wrote: > > > > These methods were introduced in 20.05. > > There has been no changes in their public API since then. > > They seem mature enough to remove the experimental tag. > > I am a bit skeptical at the patch. > Can

Re: [dpdk-dev] [PATCH v3 00/28] net/cnxk: support for inline ipsec

2021-10-02 Thread Jerin Jacob
On Fri, Oct 1, 2021 at 7:10 PM Nithin Dabilpuram wrote: > > Support for inline ipsec in CN9K event mode and in Cn10K event mode and > poll mode. > > Kommula Shiva Shankar (1): > common/cnxk: add CQ enable support in NIX Tx path > > Nithin Dabilpuram (18): > common/cnxk: support CPT parse heade

Re: [dpdk-dev] [PATCH v3 01/27] common/cnxk: update policer MBOX APIs and HW definitions

2021-10-02 Thread Jerin Jacob
On Thu, Sep 30, 2021 at 3:31 PM Kinsella, Ray wrote: > > > > On 30/09/2021 10:08, sk...@marvell.com wrote: > > From: Sunil Kumar Kori > > > > To support ingress policer on CN10K, MBOX interfaces and HW > > definitions are synced. > > > > Signed-off-by: Sunil Kumar Kori # Please add cover letter

[dpdk-dev] [PATCH] mbuf: promote some helpers to stable

2021-10-02 Thread David Marchand
Those accessors have been introduced more than two years ago (rte_mbuf_to_priv in v18.05, rte_mbuf_*_addr* in v19.02). Time to mark them stable. rte_mbuf_to_baddr() could be removed, but since we lack a deprecation notice, keep it as a simple wrapper. Signed-off-by: David Marchand --- lib/mbuf/

Re: [dpdk-dev] [PATCH] app/test: fix memory autotests on FreeBSD

2021-10-02 Thread David Marchand
On Fri, Sep 17, 2021 at 5:09 PM Bruce Richardson wrote: > > The memory autotests were failing on FreeBSD, due to an incorrect errno > variable being checked for ENOTSUP. The test checked "errno" while the > DPDK API sets "rte_errno". Changing to check the right variable makes > the test behave pro

Re: [dpdk-dev] [PATCH] eal/freebsd: lock memory device to prevent conflicts

2021-10-02 Thread David Marchand
On Mon, Sep 13, 2021 at 3:15 PM Burakov, Anatoly wrote: > On 13-Sep-21 12:06 PM, Bruce Richardson wrote: > > Only a single DPDK process on the system can be using the /dev/contigmem > > mappings at a time, but this was never explicitly enforced, e.g. when > > using --in-memory flag on two processe

Re: [dpdk-dev] [PATCH] eal/freebsd: lock memory device to prevent conflicts

2021-10-02 Thread David Marchand
On Mon, Sep 13, 2021 at 4:40 PM Burakov, Anatoly wrote: > >> I'm a bit uneasy with --in-memory mode pretending to work on > >> FreeBSD and Windows, but that's a separate problem :) > > > > Yes, it is, though one that does belong is the same area as this one. The > > "fix" is probably to just print

Re: [dpdk-dev] [PATCH] test/hash: use compiler atomics for sync

2021-10-02 Thread David Marchand
Hello guys, On Wed, Sep 22, 2021 at 11:52 PM Dharmik Thakkar wrote: > > Convert rte_atomic usages to compiler atomic built-ins > for stats sync > > Signed-off-by: Dharmik Thakkar > Reviewed-by: Joyce Kong > Reviewed-by: Ruifeng Wang Review please. -- David Marchand

[dpdk-dev] [Bug 752] Leak in ice init if ice_flow_init or ice_reset_fxp_resource fails

2021-10-02 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=752 David Marchand (david.march...@redhat.com) changed: What|Removed |Added Status|IN_PROGRESS |RESOLVED Reso

[dpdk-dev] [Bug 818] [asan] hash: buffer overflow in hash_autotest

2021-10-02 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=818 Bug ID: 818 Summary: [asan] hash: buffer overflow in hash_autotest Product: DPDK Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal

[dpdk-dev] [Bug 819] [asan] lpm: buffer overflow in lpm6_autotest

2021-10-02 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=819 Bug ID: 819 Summary: [asan] lpm: buffer overflow in lpm6_autotest Product: DPDK Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal

[dpdk-dev] [Bug 820] [asan] table: buffer overflow in table_autotest

2021-10-02 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=820 Bug ID: 820 Summary: [asan] table: buffer overflow in table_autotest Product: DPDK Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal

[dpdk-dev] [kmods PATCH 0/4] windows: independent fixes

2021-10-02 Thread Dmitry Kozlyuk
Fixes for building with Windows Development Kit 22000.1 and some build configuration cleanup. Dmitry Kozlyuk (4): windows: specify signature hash algorithm windows/virt2phys: support only x86 configurations windows/virt2phys: change setup class GUID to custom windows/virt2phys: add PnpLock

[dpdk-dev] [kmods PATCH 1/4] windows: specify signature hash algorithm

2021-10-02 Thread Dmitry Kozlyuk
Windows Driver Kit version 22000.1 requires the signature hash algorithm to be specified, otherwise an error occurs: SIGNTASK : SignTool error : No file digest algorithm specified. Specify "certHash" to match the algorithm of any certificate used. Signed-off-by: Dmitry Kozlyuk --- windows/

[dpdk-dev] [kmods PATCH 2/4] windows/virt2phys: support only x86 configurations

2021-10-02 Thread Dmitry Kozlyuk
While non inherently limited to one platform, virt2phys is only developed on x86 and tested for it. Arm configurations were created by the driver template project and were never maintained. Remove them to reduce the burden of keeping all configurations in sync. The template also enabled tracing fo

[dpdk-dev] [kmods PATCH 3/4] windows/virt2phys: change setup class GUID to custom

2021-10-02 Thread Dmitry Kozlyuk
virt2phys was using the setup class GUID of sample drivers with class name "kernel bypass". Windows Driver Kit version 22000.1 recognizes this GUID and emits an error: error 1280: Class name and ClassGuid mismatch, expecting Class "Sample" for ClassGuid "{78A1C341-4539-11d3-B88D-00C04FAD51

[dpdk-dev] [kmods PATCH 4/4] windows/virt2phys: add PnpLockdown directive

2021-10-02 Thread Dmitry Kozlyuk
WDK for Windows 10, version 2004 emits a warning suggesting to add PnpLockdown directive to INI [1]. Add it since virt2phys has no potential use-cases that require modifications to driver files. [1]: https://docs.microsoft.com/en-us/windows-hardware/drivers/install/inf-version-section Signed-off

[dpdk-dev] [PATCH v2 0/3] Experiment ASAN in GHA

2021-10-02 Thread David Marchand
Following fixes for ASAN, I added ASAN in GHA to see where we stand. Here are two fixes that can be merged. The last patch enables ASAN, but as we can see, there are still some unit tests who fails because of ASAN: - multiprocess is broken, we could flag the ut requiring/testing mp, - hash tests h

[dpdk-dev] [PATCH v2 2/3] test/latencystats: fix incorrect loop boundary

2021-10-02 Thread David Marchand
Caught running ASAN. lat_stats_strings[] is an array containing NUM_STATS strings. Fixes: 1e3676a06e4c ("test/latency: add unit tests for latencystats library") Cc: sta...@dpdk.org Signed-off-by: David Marchand Acked-by: Reshma Pattan --- app/test/test_latencystats.c | 2 +- 1 file changed,

[dpdk-dev] [PATCH v2 3/3] ci: run unit tests with ASAN

2021-10-02 Thread David Marchand
Enable ASAN for clang jobs. This can greatly help identify leaks and buffer overflows. This patch is more a fyi, as some unit tests stil have issues. Signed-off-by: David Marchand --- .ci/linux-build.sh | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/.ci/linux-build.s

[dpdk-dev] [PATCH v2 1/3] bus/vmbus: fix leak on device scan

2021-10-02 Thread David Marchand
Caught running ASAN. The device name was leaked on scan. rte_device name field being a const, use a local pointer and release in error path. Fixes: 831dba47bd36 ("bus/vmbus: add Hyper-V virtual bus support") Cc: sta...@dpdk.org Signed-off-by: David Marchand --- Changes since v1: - left rte_vmbus

Re: [dpdk-dev] [RFC] mempool: implement index-based per core cache

2021-10-02 Thread Ananyev, Konstantin
> > > Current mempool per core cache implementation is based on pointer For > > > most architectures, each pointer consumes 64b Replace it with > > > index-based implementation, where in each buffer is addressed by (pool > > > address + index) > > > > I don't think it is going to work: > > On 64-

Re: [dpdk-dev] [EXT] Re: [RFC 06/15] eventdev: use new API for inline functions

2021-10-02 Thread Pavan Nikhilesh Bhagavatula
>Hello Pavan, > >On Mon, Aug 23, 2021 at 9:41 PM wrote: >> >> From: Pavan Nikhilesh >> >> Use new driver interface for the fastpath enqueue/dequeue inline >> functions. >> >> Signed-off-by: Pavan Nikhilesh >> --- >> lib/eventdev/rte_event_crypto_adapter.h | 13 +- >> lib/eventdev/rte_event_

[dpdk-dev] Recent change to make rte_cryptodev_pmd.h internal prevents some important functionality

2021-10-02 Thread Luse, Paul E
Hi Everyone, I sent this last week and haven’t heard back – apologize if I missed the response but if not here it is again… We use cryptodev in SPDK and included rte_cryptodev_pmd.h so that we may release qpair memory that was allocated when we called rte_cryptodev_queue_pair_setup(). We’d do

[dpdk-dev] [PATCH] common/cnxk: add REE support

2021-10-02 Thread lironh
From: Liron Himi Adding REE definitions and related ROC code Signed-off-by: Liron Himi --- drivers/common/cnxk/hw/ree.h| 165 +++ drivers/common/cnxk/hw/rvu.h| 5 + drivers/common/cnxk/meson.build | 1 + drivers/common/cnxk/roc_api.h | 4 + drivers/common/cn