On Mon, Sep 13, 2021 at 4:40 PM Burakov, Anatoly <anatoly.bura...@intel.com> wrote: > >> I'm a bit uneasy with --in-memory mode pretending to work on > >> FreeBSD and Windows, but that's a separate problem :) > > > > Yes, it is, though one that does belong is the same area as this one. The > > "fix" is probably to just print a warning when --in-memory is used, > > informing the user that the flag is ignored and then continue. > > Alternatively we can error out, but I think the warn+continue is better, > > myself. > > I think erroring out is better. The feature is intended to work a > certain way, so if we can't guarantee that it does, we can't pretend it > is "supported" or "is working". But again, irrelevant to this patch :) >
Please, can you review https://patchwork.dpdk.org/project/dpdk/patch/20210913140848.184928-1-bruce.richard...@intel.com/ ? Thanks. -- David Marchand
